Unalterable Admins Can Edit Themselves

[akanevsky]

I no longer support my hacks. Please feel free to update them and release new versions elsewhere as long as I get the credit for the original modification.

/*===================================*\
|| Unalterable Admins Can Edit Themselves
||
|| Author : Anton Kanevsky
|| Co-Author(s) : Andreas
|| Works on : vBulletin 3.5.x - 3.8.x
|| Released : Jan 31, 2009
||
|| Time required to install: 30 seconds
|| Difficulty: easy
\*===================================*/

DESCRIPTION

Allows unalterable administrators to modify their own accounts (with the exception of the password, usergroup and membergroups) via admincp.

STATISTICS

Products to Install: 1


VERSION HISTORY

1.0.5
[+] Ported to vBulletin 3.7.x - 3.8.x.

1.0.4
[+] The modification is now compatible with vBulletin 3.6.4 - a plugin code change was required due to changed format of CVS_REVISION constant.
[+] It is no more possible for an uneditable admin to modify the usergroup(s) he or she belongs to.

1.0.3
[+] The modification is now officially compatible with vBulletin 3.6.0 and above.
[+] The modification is now a product rather than a plugin, and it supports version check.

1.0.2
[+] Added restriction to prevent code from executing anywhere but within user.php.
[+] Added restriction to prevent alteration of password for unalterable administrators.

1.0.1
This is now a plugin instead of a code hack. Cheers to Andreas.

1.0.0
First Public Release

The installation manual is contained within the attached file.

IF YOU LIKE MY HACK, PLEASE CLICK INSTALL (https://vborg.vbsupport.ru/vborg_miscactions.php?do=installhack&threadid=203760)

[Troak]

Thank you :)

[tehste]

Nice idea. I hate the fact undeletable users can't be edited. Though I prefer just to have one super admin so it doesn't really matter for me.

[Troak]

The code in the hack makes sense but for some reason doesn't work. I might have done something wrong though.

[akanevsky]

Did you find and replace both instances?

[Troak]

Yes, I still get this message
Sorry, this user is protected from being altered in the config.php file by the $config['SpecialUsers']['undeletableusers'] variable.

[akanevsky]

Hmm.. Hold on, I'll take a look at what the problem might be...

[Troak]

I can't figure out why it doesn't work =/

[akanevsky]

Give me a minute please...

[Troak]

Sure thing, I've just been going through the code to see if there was anything causing a problem, but I couldn't find anything, then again I don't know much about php.. lol

[akanevsky]

Sorry for the delay, didn't have time to look.
I am uploading the fixed version. It is just a matter of an extra $ sign lol.

EDIT: A fixed and tested version uploaded. :)

[EasyTarget]

great idea, thanks.

[akanevsky]

You are welcome, but don't forget to click install -.- :)

[Snake]

Cute hack, thanks. ^_^

[Troak]

Yay works fine now ^^
Thanks a ton!

[Andreas]

Nice Code Hack.
How about a Plugin? ;)

Hook: admin_global

if ($_POST['do'] != 'kill')
{
$noalter = array_flip(explode(',', $vbulletin->config['SpecialUsers']['undeletableusers']));
unset($noalter[$vbulletin->userinfo['userid']]);
$vbulletin->config['SpecialUsers']['undeletableusers'] = implode(',', array_flip($noalter));
}

[Snake]

That's much better as a plugin so thankies!!

[akanevsky]

Nice Code Hack.
How about a Plugin?

Thanks. I did not know about the array_flip function :)
I will set it up as a plugin.

[akanevsky]

Done, converted to a plugin.
Except in mine, it's $_POST['do'] == 'update'

[Snake]

Well what's the difference? :P

[akanevsky]

The difference is, in Kirby's version you could delete the admin (but not edit him). In mine, you can edit, but not delete.

[akanevsky]

Mod, move it to plugins please thanks.

[IceBurn3000]

Awesome plugin!

*Clicks install

It was a real pain having to edit the config file to modify my settings! Not any more!

[Sovereign]

Thank you! I couldn't edit myself (I set myself as unalterable for security reasons) and had to keep FTPing new config.phps every time I changed something...

[Andreas]

The difference is, in Kirby's version you could delete the admin (but not edit him). In mine, you can edit, but not delete.
Erm ... I check for do != 'kill', you checked for do == 'update'
As those are the only actions in user.php that check undeletableusers it should be the same?

[akanevsky]

Erm ... I check for do != 'kill', you checked for do == 'update'
As those are the only actions in user.php that check undeletableusers it should be the same?

Oh. Sorry. I read it as do=='kill'... lol. Yeah, it would do the same, but I prefer a specific action, rather than any exclusive actions if you know what I mean. :)

[Andreas]

Yeah, I didn't want to check for update as this is used by almost all Scripts.
Maybe

if ($_POST['do'] == 'update' AND basename($vbulletin->scriptpath) == 'user.php')
{
stuff
}


Then it would really be disabled just for this action.

[akanevsky]

Then it would really be disabled just for this action.

Actually, only user.php does any changes to user accounts. So it would be pointless to check for the script as well, wouldn't it?

[Andreas]

I was too lazy to check other Scripts ^.^
If it's only being used in this one, great.

[BlackRabbit1971]

Getting a "Invalid File Specified" on trying to import :(

[akanevsky]

Then specify a valid file :)

[TCM]

Thankyouthankyouthankyou! THANK YOU!

*Click install*

EDIT: -_-

It doesn't work on RC2. Drat.

Or I've done something stupid.

[akanevsky]

It's for RC1... Didn't test on RC2.

[Snake]

I'm running on RC2 and it works fine. ;)

[BlackRabbit1971]

Then specify a valid file :)


And just exactly where would I find a valid file.... I downloaded it from here... ???

[akanevsky]

I downloaded it from here... ???

That would be the valid file that you have to specify in your admincp :)

[TCM]

I'm running on RC2 and it works fine. ;)Odd. It isn't working for me. =/

[BlackRabbit1971]

That would be the valid file that you have to specify in your admincp :)


Ok... this is getting silly....

This what I do...

1. Download you zip and unzip it...
2. In the Plugin System/Manage Products I click [Add/Import Product]
3. I then click BROWSE and point the file selection box to your "plg_uacet.xml" file.
4. I click Import.

The screen changes to the "Importing Product, Please Wait..." page. I then get 2 sets of dots "[::]" and an error box... "Invalid File Specified" and a "Go Back" button...


So, you tell me what I'm doing wrong??

[akanevsky]

Try removing the text from the textbox that allows you to upload a file from the server.

[BlackRabbit1971]

Try removing the text from the textbox that allows you to upload a file from the server.


Nope.. same thing... I've even tried uping directly to the server and using that damn box ya telling me empty.. :(

I would so like to use this plugin... :(

BR :(

[TCM]

I tried it again on RC2. Still didn't work. =/

[akanevsky]

I suppose RC1 plugins are incompatible with RC2.

[Boofo]

They seem to be working fine between versions with all the other one I've seen. ;)

Maybe they need to un-install and re-install? ;)

[Daniel]

Thanks a bunch!

[akanevsky]

You're welcome.

[dsotmoon]

is this working in gold?

[akanevsky]

Yes.

[dsotmoon]

Yes.

installed, thank you

[akanevsky]

No problem ;) 45 installs in one day. Wow.

[secret1980]

i dont get how to install this .. can some one help me ??
In Hook Location I dont have anything called as admin_global :s

& should i copy even this : <?xml version="1.0" encoding="ISO-8859-1" ?> ???

[akanevsky]

You just need to import the plugin using your plugin manager...

[Emil]

Thanks

[Quillz]

Just installed this very useful hack! Since my admin account is unalterable and undeletable, it's nice to not have to edit config.php anytime I want to change my account info!

[akanevsky]

Just a reminder - this hack goes against vBulletin's security measures, because unalterability was made in order for hackers to be unable to edit your account (in case they gain access). So install this only if you are not afraid of it.

Maybe in next version I'll make it so that you cannot change usergroup of the person if he is undeletable. :) Then it will be compeltely secure.

[akanevsky]

1.0.2

[+] Added restriction to code execution in user.php only.
[+] Added restriction to password alteration.

[EasyTarget]

nice job.

[akanevsky]

Thanks :)

[Snake]

Wooho. Thanks.

[akanevsky]

You might want to use vBulletin to import the plugin from a file for you.
PLUGIN SYSTEM --> DOWNLOAD/UPLOAD PLUGINS

[Iceburg22]

Installed. Thanks

[Calisse]

works perfectly and nice and easy for dopes like me. lol. cheers, was looking for a way to do this (damn kids on the admin cpanel want to change their rep making me work grumble grumble mutter)

[Telegon80]

edit: nm works good

[Talisman]

I'm getting a strange error, but have no idea why. I installed the plug-in and that went through just fine. But when I try to access my ACP, I get a parse error from global.php.

Parse error: parse error, unexpected '<' in /......../forum/admincp/global.php(194) : eval()'d code on line 1

Locking myself out of my own ACP isn't quite the result I was going for, especially since that's where I'd have to go now to un-install this plugin ... lol. So I commented out the hook instruction in admin/global.php Line 194. And that let me access the ACP again.

So here's the code from that line. Does anyone see why I'd get a parse error from this? And is this the correct syntax to be installed by the xml file?

($hook = vBulletinHook::fetch_hook('admin_global')) ? eval($hook) : false;

[IrPr]

seems not workin on 3.5.2

[akanevsky]

seems not workin on 3.5.2
Really? I'll check.

[da prez]

Psionic this hack interferes with the ability to add users through admincp, do you have any idea why ?

when adding a user, i get invalid password specified error.

i am guessing it is the password thing for admins.

it is not huge deal as i can turn it off, but if it could be fixed that would be kickass.

[akanevsky]

Psionic this hack interferes with the ability to add users through admincp

Are you sure that it is my hack?

[norwichcanary]

Are you sure that it is my hack?

I can confirm I had the same issue and uninstalled the mod. It would not let me edit any user passwords.

[akanevsky]

Ah. It was supposed to restrict password alteration for unalterable administrators, but apparently it does so for everyone. FIXED!

[Telegon80]

ah so this is the reason why i couldnt add new users lmfao... damn, so this is fixed? ill go ahead and re-install... :D

[akanevsky]

Yes. I couldn't understand why I couldn't add new users either lol... :p Now it only disables (or is supposed to disable) the password alteration when an unalterable admin is editing himself. ;P

[da prez]

thank you much

[IrPr]

Really? I'll check.

yeah

still w8in .. :)

[akanevsky]

I thought I just released an update. ;)
>> Last Update: 27. Dec 2005

[EasyTarget]

thanks for the update.

[IrPr]

nize ;) thanks mate keep on

[IrPr]

[+] Added restriction to code execution in user.php only.

is it possible to use this with Quick (inline) User Editor (https://vborg.vbsupport.ru/showthread.php?t=102789) ?

[darkman]

Thank you :)

*installed

[theFAILURE]

Nice job, works tip-top!

[Guest210212002]

/me clicks install

[Mindwarp]

dosn't seam to work on 3.5.3 :(

[Snake]

Works just fine here. :)

[kizzmet]

Installed and works great. Thank you for this.

Only thing I would request is to actually put the instructions in the plug in manual rather then sending your users to look something up in the VB manual. We are not all tech geeks (meant as a compliment) and I searched for the intructions in the manual using the search function to no avail. I did figure it out though, but it would have been nice just to have the instructions rather then going around looking for them.

Thanks =)

[cynix2]

has anyone tested this on 3.6?

[Zelda-King]

I haven't received any errors updating myself on 3.6.

[akanevsky]

This hack is so simple that it should work fine on 3.6.