Keep Redirects for merged Threads

[Andreas]

Keep redirections for merged Threads
This is just a fast redux of my vB 3.0 Mini-Mod, now as a Plugin for vB 3.5 :)

Description
If you merge Thread A into Thread B, Thread A will be deleted afterwards.
Now your users might be confused as they can't find the thread anymore.

This hack changes this behaviour: Thread A will become a redirect to the merged Thread B.

Details
1 Plugin XML

History
0.1 Initial Version for vBulletin 3.5
0.2 Added Support for Inline Moderation
0.3 Added Support for Table-Prefixes

Unfortunately no Screenshots as there is nothing to see :D

Please only click Install if you actually have installed/are using this Hack, and click Uninstall whan you don't use it any longer!

This Hack is redundant as of vBulletin 3.5 Final.
Do not install it on this or any higher Version

[Biker_GA]

Hmmmmmm. I'm not getting a redirect message left behind. I've just tested by merging two threads into the same forum, and by merging two threads and moving to a different forum.

[Andreas]

Works for me, no matter if the Threads are in the same Forum or in different Forums.

[Christine]

Not working for me either -- same forum or different forums.

[Andreas]

Hmm, then I don't know why :(
Can you put


die("Attempting to delete Thread " . $threadid . " as it was merged with " . $GLOBALS['threadinfo']['threadid']);


inside the if to see if it gets executed?

[Biker_GA]

Do you want me to replace the existing code with that, or add it?

[Biker_GA]

I just noticed something.. I did a split and move, and saw the options for merging a thread when I selected the "move" option. However, there was no option to leave a redirect in the dialog box.

[Andreas]

Man I dont understand anything :)

From the Thread Tools mean you just select "Merge Thread".
In the upcoming dialog you enter the URL of the other Thread that should be merged.
Without this Hack, after the merge this other Thread will be deleted.
With this Hack it should become a redirect to the first one.

[Christine]

Added the die statement, and that isn't it -- the query is executing. Gave me the 'merging threads - you will be redirected...' splash screen and took me to the new thread.

Just no redirect links.

I attempted a merge with 3 threads on this -- 2 in one forum and 1 in another, leaving the new combined thread in the forum where the 2 originated.

I have no other plugins for threaddata_delete -- so don't believe it is being stepped on.

[Christine]

Man I dont understand anything :)

From the Thread Tools mean you just select "Merge Thread".
In the upcoming dialog you enter the URL of the other Thread that should be merged.
Without this Hack, after the merge this other Thread will be deleted.
With this Hack it should become a redirect to the first one.
HA!

I was using inline and thread checkboxes...

Edit to add: Just tested the 'add URL' way, and is working just fine. :D

[Andreas]

Hmm ... dunno if inline works as I hadn't thought of this, lol.
*checking*

[Biker_GA]

HA!

I was using inline and thread checkboxes...

Edit to add: Just tested the 'add URL' way, and is working just fine. :D

Yep. I was using inline as well. Why use the old fashioned method when we have these nifty new tools? LMAO

[Andreas]

Well, I simply hadn't thought of it :)
Anyway, should be supported now.
Delete the old Plugin and redownload please.

[Biker_GA]

Well, I smiply hadn't thought of it :)
Anyway, should be supported now.
Delete the old Plugin and redownload please.
LOL! Will do.

[Christine]

That works like a charm. Thanks!!

BTW -- does this mean you are close on APM? :D This ZIP File has been automatically created with Advanced Plugin Manager (C) 2005 KirbyDE.

All Hacks are copyrighted to their respective owner.

This is a Release for vBulletin.org

[Andreas]

It's work in Progress ;)

[Biker_GA]

Works great now. :)

[Paul M]

I'll give this a try.

I installed the 3.0.x version on our live forum and had to remove it after two days because of the errors it caused.

[Andreas]

Hmm, which errors?
This Hack does not do much - it just changes the Threads to be redirects ...

[Paul M]

SQL errors on replies, due to no parentid.

As best I could tell what I think was happening was that person A has thread 1 open, and were posting a reply - in the meantime thread 1 is merged with thread 2, leaving thread 1 as a redirect. Person A now hits submit, for their reply, and it fails as they are now trying to add a reply to a redirect.

[phlogiston]

two things I've found with this:

1st. queries within the plugin need changing for THREAD_PREFIX ;)


2nd. not really a problem with this hack, just something I found unexpected; using the inline method of merging works differently - rather than merging thread 2 into thread 1 - it actually creates a new thread 3 containing both 1+2.
Means you get two redirects plus the new thread!
(or obviously however many threads you chose to merge)

Still, very nice & handy plugin :up:

[Andreas]

Those bloody Table-Prefixes keep driving me nuts ;)

[FD929]

2nd. not really a problem with this hack, just something I found unexpected; using the inline method of merging works differently - rather than merging thread 2 into thread 1 - it actually creates a new thread 3 containing both 1+2.
Means you get two redirects plus the new thread!
Great hack, though it would be nice for that not to happen. Anything you can do kirby? :)

[Andreas]

Nah, I fear that would require major changes and can't be done without File edits.

/me hates File Edits!

[FD929]

Right on. Yeah I hate them too. It's not big deal anyways, just delete the extra redirect it creates. :)

[Andreas]

This Hack is now redundant as of vBulletin 3.5 Final
Do not install it on this Version

If you already have it installed, I recommend uninstalling it.

As this has become a standard feature, I am withdrawing support for this Hack.