Multiquote

[Andreas]

Multiquote

Credits
This is a port of the vB 3.0.X-Version of Multiquote (https://vborg.vbsupport.ru/showthread.php?t=59702) made by Chroder - all credits to him and Hoffi for the images.

Description (copy & paste as I am lazy ;))
This multiquote hack allows your members to select multiple posts to quote from. These posts can be on a different
page, in a different thread, or on an entirely different forum. Don't worry, the hack checks to make sure the user
has read permissions on the post so no sneaky members can insert random post ID's in hopes to find what's going on
in your secret staff forums.

This Hack is not designed to work with Quick Reply, it also does not quote the last post of a Thread if you click the New Reply button, as this button is meant to reply without quoting the last post.

Details
1 Plugin XML
1 Phrase
1 Template Edit
2 Images
1 JS File
No file edits!

Note: As I did not test this extensivly i'll class it as Beta :)

Please only click Install if you actually have installed/are using this Hack, and click Uninstall when you don't use it any longer!

[Bad Bunny]

Niiice. Thanks to the original hack author, and to you, Kirby.

[Allan]

screenshot please :)

[Bad Bunny]

screenshot please :)
It's an update of the thread he linked to. Go look at the link for your screenshots.

[Chris M]

Excellent hack Kirby :)

Will be installing this as soon as I get Beta 3 fixed :)

Satan

[Frenck]

Nice hack :) Just what I needed

[Forum-Style]

Very nice, be counting me in for this one :) Great job.

[Frenck]

It seems that it doesn't work with posts that already contain a quote!?

[Andreas]

It does, but just like the normal Quote function it does not quote Quotes :)

[Frenck]

I know, but overhere it does not quote those posts at all!

Normal posts (without any quotes) works fine, single or multiple.
When I use your plugin to quote posts that already have quotes themselfs, than it does not quote anything.

Tested it on a clean vbulletin 3.5.0 beta 3 installation...

One note, maybe that's the problem, I'm quoting a post wich contains a quote of myself...

[Andreas]

Hmm, seems to work just fine for me.
Do you have a Board where I can test this, or tell me exactly how to reproduce the problem?

[Frenck]

I will create a account for you on my dev site. Keep track of your pm inbox ;)

[Andreas]

Problem solved: No problem existed :)
Just misunderstanding:
If you select the last post of a Thread for Multiquote and then click the Big Reply Button it will not be quoted, as this button sets noquote=1 for the last Post.
This is intended behaviour.

[jpt62089]

isnt this a plug in? if so why is it in code mods?

[Andreas]

It comes with an additional JS File, so as of our definition it is not a Plugin ...

[jpt62089]

it does not change the original code tho.... or does it?

[Andreas]

No, it does not touch any vBulletin files.

[jpt62089]

No, it does not touch any vBulletin files.
then it should be a plug in.... vb.org plugin definition: "Plugins are addons that do NOT require ANY source code modification."

[Andreas]

... if they do not come with additional files.
That's the current definition.
Anyway, this discussion is OT here.

If you want to further discuss this matter we should move on to Site Feedback.

[Chris M]

<if+condition="$post['replylink'] AND $show['multiquote']">
<img+src="$stylevar[imgdir_misc]/mq_img_off.gif"+alt="$vbphrase[multiquote]"+border="0"+width="21"+height="15"+name="multiquote_$post[postid]"+id="multiquote_$post[postid]"+onclick="toggleMultiQuote($post[postid],+this)"+style="cursor:pointer"+/>
</if>
Invalid template content - Eventually found it:p
Change:
<if condition="$post['replylink'] AND $show['multiquote']">
to:
<if condition="$show['replylink'] AND $show['multiquote']">
:)

Satan

[Andreas]

But $show['replylink'] is defined nowhere ....

[Chris M]

Well it wouldn't work with $post['replylink'], and does work with $show['replylink'] for me o_O

Satan

[Chris M]

This is the error I get when I use $post['replylink']:

The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/xxxx/public_html/forums/includes/adminfunctions_template.php(3504) : eval()'d code on line 188

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

Satan

[Andreas]

Strange. Does work just fine for me.
And I really can't understand why this would happen, seeing as postbit itself uses $post['replylink']
Anyone else expiriencing the problem?

[Chris M]

Strange. Does work just fine for me.
And I really can't understand why this would happen, seeing as postbit itself uses $post['replylink']
Anyone else expiriencing the problem?
Hrm strange now I don't see the image on showthread when I use $show['replylink'] and when I try and use your template code it gives me that error :ermm:

It also gives me this error upon trying to view a thread when I click "continue" regardless:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/xxxx/public_html/forums/includes/class_postbit.php(241) : eval()'d code on line 188

Satan

[Andreas]

Really strange. Which Version do you use?
Although it does not make sense, did you try to just put the Code in a new Template and save it, does this compile without errors?

[Chris M]

Of vB? 3.5.0 Beta 3 :)

I put it in it's own template, and got this:

The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/xxxx/public_html/forums/includes/adminfunctions_template.php(3504) : eval()'d code on line 1

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

It's obviously something wrong in this line:
<if condition="$post['replylink'] AND $show['multiquote']">
:ermm:

Satan

[Andreas]

Well, if you put only this line then the </if> is missing ...


<if condition="$post['replylink'] AND $show['multiquote']">
<img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>


This is the whole code and does compile just fine for me?

[Chris M]

Strange - I took out the ' s and it was fine o_O

Another problem though, unrelated to templates... I think...

If I have a thread with, say, 5 replies - If I select the multi-quote button for posts, 1, 3, 4 and 5, it will only quote posts 1, 3 and 4 :ermm:

What is happening to the last post in the thread?

Edit: The template code you posted above works, but the same code from your .txt file doesn't o_O Weird :p

Satan

[Joe Gronlund]

Strange. Does work just fine for me.
And I really can't understand why this would happen, seeing as postbit itself uses $post['replylink']
Anyone else expiriencing the problem?


I did with beta 3 just today

[Joe Gronlund]

Well, if you put only this line then the </if> is missing ...


<if condition="$post['replylink'] AND $show['multiquote']">
<img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>


This is the whole code and does compile just fine for me?


yaa that works :)

[Andreas]

What is happening to the last post in the thread?
https://vborg.vbsupport.ru/showpost.php?p=727270&postcount=13


Edit: The template code you posted above works, but the same code from your .txt file doesn't o_O Weird :p
That's really weird, as I just copypasted from the Readme ...

[Chris M]

Bleh - What's the point in multi-quoting if you cannot quote the last post either? :p

Satan

[Andreas]

You can, you must just click Quote.
It's intended behaviour if the Big Reply Button not to quote the last Post, so I kept this.

Do you want a Setting to turn Off this behaviour? :D

[Chris M]

You can, you must just click Quote.
It's intended behaviour if the Big Reply Button not to quote the last Post, so I kept this.

Do you want a Setting to turn Off this behaviour? :D
Yes please :)

I know I will forget to do this otherwise, and my users, when I have some, will get doublely confused :p

Satan

[Bad Bunny]

I did with beta 3 just today
I'm not sure if this has been brought up, or if anyone had an issue with it. But when I installed it, I had to change all the plus signs to spaces.
I'm on a mac using the default text editor.

Also, I would like to point out that most of my users use quick reply, and we have it so no click is required. If it were possible to have all the normal functionality, but have the quotes selected appear inside a post, it would be useful. But as it is right now, it is a little confusing for novice users.

[amykhar]

With so many people using quick reply now, it's a shame this doesn't integrate with the quick reply box at all.

[Biker_GA]

Edit: The template code you posted above works, but the same code from your .txt file doesn't o_O Weird :p

Satan

I ran into this issue just now as well. The code from the text file didn't work, yet the copied code from Kirby's post worked just fine.

[Andreas]

With so many people using quick reply now, it's a shame this doesn't integrate with the quick reply box at all.
Hmm, how do wou want it to integrate?
Of cour I could make it so QR takes all the Quotes selected for MQ, but does that make sense?

[Biker_GA]

Question.. Can the order that the quotes are displayed be reversed? It's showing the most recent post/quote first, rather than the oldest.

[Andreas]

Erm ... it does show older Quotes first?

[Biker_GA]

No.. If I run down the thread, selecting the oldest quotes first, it displays in reverse order when I click the "quote" button on the last quoted thread.

[Andreas]

Hmm, for me it does.
But it could be that different mySQL-Versions behave differently.

In Hook newreply_forum_start change

ORDER BY post.postid


to


ORDER BY post.dateline ASC


Does this work?
I think the best idea would be to make this dependand on the Users setting (Oldest First or Newset First).

[Biker_GA]

I'll give it a shot. The majority of our users are using linear mode, oldest first. There's only a couple that use Hybrid or Threaded.

[Biker_GA]

Does this work?
I think the best idea would be to make this dependand on the Users setting (Oldest First or Newset First).

No workie. :( Still showing in reverse order.

I take that back.. It sort of works.

The very first quote is from the last post where I clicked "Quote". The rest ARE in order, oldest to newest first.

[Andreas]

That is ... impossible.
ORDER BY post.dateline ASC selects older posts first.

But you might try ORDER BY post.dateline DESC (this gives newest Posts first, at least theoretically and on my system)

[Andreas]

Well, the first Quote will always be the one where you clicked Quote.

Getting this at the right place time-wise would require some more changes.

[Biker_GA]

OK.. I'll just change my instructions to the users to click the multiquote icons and then the Post Reply icon.


Edit -- Just tested and that procedure works just fine. :)

[amykhar]

Hmm, how do wou want it to integrate?
Of cour I could make it so QR takes all the Quotes selected for MQ, but does that make sense?
I think it makes sense that if you click a post and then select the quote checkbox, that it pick up all the quotes selected by MQ.

[Andreas]

But you can't reply to them then as your text would appear below all the Quotes?

[Biker_GA]

OK... Found another "issue". If you select the multiquote on the last post in a thread, it isn't included.

[Andreas]

I guess you clicked the big Reply-Button which sets noquote for the last Post?

[amykhar]

But you can't reply to them then as your text would appear below all the Quotes?
That's ok. A lot of people do that anyway. Ideally, it would show in the QR box for edit before the post is submitted, but if that's not doable, the other option would work.

[Biker_GA]

I guess you clicked the big Reply-Button which sets noquote for the last Post?

Yeah... So what to do? If I use "quote" on the last post, it puts it in front of all the older quotes. :(

[Andreas]

That's ok. A lot of people do that anyway. Ideally, it would show in the QR box for edit before the post is submitted, but if that's not doable, the other option would work.
Should be doable with AJAX, but I am not yet familiar with this so it might take some time.

For the moment I changed it so that the Postorder will always be correct and that the Big Reply Button also quotes the last Post if it was selected for MQ. I think this might make more sense.
An update will be released soon.

[Andreas]

OK, I currently got Support for QR this way:
If Posts are selected for MQ and "Quote Message in Reply" is checked the Quotes will be on Top of the Post (Order depends on User Setting Oldest or Newest First), the Reply is below them.
If "Quote message in reply" is not checked they will not appear in the Post, but they will still be selected for MQ.
Furthermore, the MQ Icon for the quoted Posts does not change after an AJAX Post, only if you reload the Page - i'll try to get them reset too.

Does this behaviour make sense?

[Biker_GA]

Ummmmmmmmm. No? LOL "Quote message in reply".. As in the check on QR?

[Andreas]

No, I am talking about the Checkbox below the QR Editor.
Which global setting do you mean?

[Biker_GA]

I changed it. LMAO

I think I see how it works... Oh hell. Make the changes. I'll delete, reload and test. Why not? I've busted just about everything else on my site today.

[amykhar]

OK, I currently got Support for QR this way:
If Posts are selected for MQ and "Quote Message in Reply" is checked the Quotes will be on Top of the Post (Order depends on User Setting Oldest or Newest First), the Reply is below them.
If "Quote message in reply" is not checked they will not appear in the Post, but they will still be selected for MQ.
Furthermore, the MQ Icon for the quoted Posts does not change after an AJAX Post, only if you reload the Page - i'll try to get them reset too.

Does this behaviour make sense?
Yes. Makes sense to me. We can always tweak it as necessary.

[Biker_GA]

Kirby? Any joy with the changes?

[theArchitect]

One of my members is a coder and has a JavaScript consol open along with FireFox for some work he is doing.

He also has the forum open in another tab and he has a constant error warning of: "Error: initMultiQuote is not defined".

It has not affected me as I don't have this type of error reporting on, but thought you might like to know. Also I wouldn't mind hearing about a fix as this must be annoying for him and as he is an Admin...

[Andreas]

@theArchitect
initMultiQuote() is defined in multiquote.js, so make sure this File is located in clientscript and is being loaded bei showthread.php

[theArchitect]

@theArchitect
initMultiQuote() is defined in multiquote.js, so make sure this File is located in clientscript and is being loaded bei showthread.php

Thanks, I will look into that. Though I have had to turn it off on my live board as I have just installed a spell check system (https://vborg.vbsupport.ru/showthread.php?t=92202) and it seems to have cancelled this hack out.

I don't think it should, but until I get to the bottom of the problem I have removed the multiquote button as clicking it now does nothing.

[Boofo]

Well, if you put only this line then the </if> is missing ...


<if condition="$post['replylink'] AND $show['multiquote']">
<img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>


This is the whole code and does compile just fine for me?

I'm getting this error now when I try to add that code to the template:

The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /xxxx/xxxx/xxxxxx_xxxx/boards/includes/adminfunctions_template.php(3504) : eval()'d code on line 191

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

[amykhar]

Bob, that error is common for many of us when there are apostrophes within the brackets in the template. Kill the surrounding apostrophes wherever they occur and you should be good to go.

[Boofo]

Thank you, Amy. ;)

I did that right after I posted the message above and it worked fine after that.

[BamaStangGuy]

Installed on RC1 and working good

[Biker_GA]

Kirby? Any joy with the changes?

Bumpity bump.. ???

[BamaStangGuy]

I think I found a problem when using this:

http://www.vbulletin.com/forum/showthread.php?t=146909

I get this:

Parse error: parse error, unexpected T_STRING, expecting ')' in /home/httpd/vhosts/mustangevolution.com/httpdocs/forum/includes/datastore_cache.php on line 4065

and this is line 4065

eval(\'$newpost[\\'message\\'] .= "\n\' . fetch_template(\'newpost_quote\', 1, 0) . \'";\');

and this is the whole code section:


// ################################################## ###########################
// # START MULTI QUOTE #
// ################################################## ###########################
if (!$newpost[\'preview\'] AND $postids = $vbulletin->input->clean_gpc(\'c\', COOKIE_PREFIX . \'multiquote\', TYPE_STR))
{
$postids = explode(\',\', $postids);
$tmp = array();

//------------------------------
// Make sure we don\'t double
// posts if user selected and
// pressed the "reply" button
//------------------------------
if ($postinfo[\'postid\'] AND !$vbulleitn->GPC[\'noquote\'])
$remove_postid = $postinfo[\'postid\'];
else
$remove_postid = false;


//------------------------------
// Fetch valid PIDs
//------------------------------
foreach ($postids AS $pid)
{
if (is_numeric($pid) AND $pid != $remove_postid)
$tmp[] = $pid;
}

$postids = $tmp;
$postids = implode(\',\', $postids);

if ($postids)
{
//------------------------------
// Fetch the posts and
// get ready to assign them to
// the message area.
//------------------------------
$q = $db->query_read("SELECT
post.username,
post.pagetext,
thread.postuserid,
forum.forumid
FROM
" . TABLE_PREFIX . "post AS post,
" . TABLE_PREFIX . "thread AS thread,
" . TABLE_PREFIX . "forum AS forum
WHERE
post.postid IN($postids)
AND thread.threadid = post.threadid
AND forum.forumid = thread.forumid
ORDER BY post.postid");

while ($data = $db->fetch_array($q))
{
//------------------------------
// Make sure user has perms to
// read the post they are
// quoting
//------------------------------
$forumperms = fetch_permissions($data[\'forumid\']);

if (!($forumperms & $vbulletin->bf_ugp_forumpermissions[\'canview\']) OR !($forumperms & $vbulletin->bf_ugp_forumpermissions[\'canviewthreads\']))
{
continue;
}
if (!($forumperms & $vbulletin->bf_ugp_forumpermissions[\'canviewothers\']) AND ($data[\'postuserid\'] != $bbuserinfo[\'userid\'] OR $bbuserinfo[\'userid\'] == 0))
{
continue;
}

//------------------------------
// Now set up the textarea with
// the quotes
//------------------------------
$originalposter = fetch_quote_username($data[\'username\']);
$pagetext = htmlspecialchars_uni($data[\'pagetext\']);
$pagetext = trim(strip_quotes($pagetext));
eval(\'$newpost[\\'message\\'] .= "\n\' . fetch_template(\'newpost_quote\', 1, 0) . \'";\');
}

//------------------------------
// Clean up a bit and delete
// cookie
//------------------------------
unset($postids, $tmp, $remove_postid, $q, $data, $forumperms, $originalposter, $pagetext);
vbsetcookie(\'multiquote\', \'\', false);
}
}
// ################################################## ###########################
// # END MULTI QUOTE #
// ################################################## ###########################

[BamaStangGuy]

Actually I can confirm this code is causing it:

I disabled only the newreply_form_start hook and it works now which had this code:

// ################################################## ###########################
// # START MULTI QUOTE #
// ################################################## ###########################
if (!$newpost['preview'] AND $postids = $vbulletin->input->clean_gpc('c', COOKIE_PREFIX . 'multiquote', TYPE_STR))
{
$postids = explode(',', $postids);
$tmp = array();

//------------------------------
// Make sure we don't double
// posts if user selected and
// pressed the "reply" button
//------------------------------
if ($postinfo['postid'] AND !$vbulleitn->GPC['noquote'])
$remove_postid = $postinfo['postid'];
else
$remove_postid = false;


//------------------------------
// Fetch valid PIDs
//------------------------------
foreach ($postids AS $pid)
{
if (is_numeric($pid) AND $pid != $remove_postid)
$tmp[] = $pid;
}

$postids = $tmp;
$postids = implode(',', $postids);

if ($postids)
{
//------------------------------
// Fetch the posts and
// get ready to assign them to
// the message area.
//------------------------------
$q = $db->query_read("SELECT
post.username,
post.pagetext,
thread.postuserid,
forum.forumid
FROM
" . TABLE_PREFIX . "post AS post,
" . TABLE_PREFIX . "thread AS thread,
" . TABLE_PREFIX . "forum AS forum
WHERE
post.postid IN($postids)
AND thread.threadid = post.threadid
AND forum.forumid = thread.forumid
ORDER BY post.postid");

while ($data = $db->fetch_array($q))
{
//------------------------------
// Make sure user has perms to
// read the post they are
// quoting
//------------------------------
$forumperms = fetch_permissions($data['forumid']);

if (!($forumperms & $vbulletin->bf_ugp_forumpermissions['canview']) OR !($forumperms & $vbulletin->bf_ugp_forumpermissions['canviewthreads']))
{
continue;
}
if (!($forumperms & $vbulletin->bf_ugp_forumpermissions['canviewothers']) AND ($data['postuserid'] != $bbuserinfo['userid'] OR $bbuserinfo['userid'] == 0))
{
continue;
}

//------------------------------
// Now set up the textarea with
// the quotes
//------------------------------
$originalposter = fetch_quote_username($data['username']);
$pagetext = htmlspecialchars_uni($data['pagetext']);
$pagetext = trim(strip_quotes($pagetext));
eval('$newpost[\'message\'] .= "\n' . fetch_template('newpost_quote', 1, 0) . '";');
}

//------------------------------
// Clean up a bit and delete
// cookie
//------------------------------
unset($postids, $tmp, $remove_postid, $q, $data, $forumperms, $originalposter, $pagetext);
vbsetcookie('multiquote', '', false);
}
}
// ################################################## ###########################
// # END MULTI QUOTE #
// ################################################## ###########################

[Andreas]

Confirmed. Seems to be a vBulletin Bug to me.
http://www.vbulletin.com/forum/bugs35.php?do=view&bugid=976

[Boofo]

So as long as we don't set it up to use filecahe datastore, this won't show up?

[Andreas]

Yes. And it actually was a vBulletin Bug :)

[Boofo]

Yes. And it actually was a vBulletin Bug :)

I saw that. ;)

What does the filecache datastore code he posted on the com supposed to do, anyway? ;)

[SkyShadow]

Does this plugin work for vB 3.5?
Anyone tested yet?

[Boofo]

Does this plugin work for vB 3.5?
Anyone tested yet?

Works fine. ;)

[FASherman]

Template edit gives the following error:

The following error occurred when attempting to evaluate this template:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/httpd/vhosts/news-talk.org/httpdocs/forums/includes/adminfunctions_template.php(3510) : eval()'d code on line 187

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

[Biker_GA]

Yeah, for some reason, the original copy and past from the file doesn't work right. Try this:


<if condition="$post['replylink'] AND $show['multiquote']">
<img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>


Should work just fine.

[FASherman]

Even in cyberspace, I can always count on a fellow Texan. Thanks neighbor.

[TTG]

Very useful addition .. thanks KirbyDE
Clicked install.

[slank]

cheers ...nice hack - clicks install

[Aeolian]

this ia a great addon.. :)

is it compatible with vb 3.5 gold..

thanx~

[TTG]

this ia a great addon.. :)

is it compatible with vb 3.5 gold..

thanx~

Works fine on 3.5.0 gold :)

[MrGoodbyte]

Seem's it won't work in vb 3.5.0 Gold, after changing the postbit-template the following error occurs:
Parse error: parse error, unexpected '\"', expecting T_STRING or T_VARIABLE or T_NUM_STRING in /www/htdocs/v156404/vb35/includes/adminfunctions_template.php(3519) : eval()'d code on line 464

https://vborg.vbsupport.ru/

[Andreas]

Then you did smth. wrong :)

[Xplorer4x4]

You sure Kirby? I had this working great on RC3. Now I reinstalled the plug in, and made the template mod.

Here is my template now.
http://img192.imageshack.us/img192/6695/p10104372ho.jpg

[Andreas]

I see a "crip /if>" in this screenshot. That looks like a broken template conditional which gives the error. Check your edits is all I can say.

[Xplorer4x4]

I tried to search for that "crip /if>". No luck. :-/

Here is the controls section of the postbit_legacy template. Maybe you can point out something I missed. I am thinking maybe its a broke if condition?
<!-- controls -->
<if condition="$post['editlink']">
<a href="$post[editlink]" name="vB::QuickEdit::$post[postid]"><img src="$stylevar[imgdir_button]/edit.gif" alt="$vbphrase[edit_delete_message]" border="0" /></a>
</if>
<if condition="$post['forwardlink']">
<a href="$post[forwardlink]"><img src="$stylevar[imgdir_button]/forward.gif" alt="$vbphrase[forward_message]" border="0" /></a>
</if>
<if condition="$post['replylink']">
<a href="$post[replylink]" rel="nofollow"><img src="$stylevar[imgdir_button]/<if condition="$post['forwardlink']">reply_small<else />quote</if>.gif" alt="$vbphrase[reply_with_quote]" border="0" /></a>
</if>
<if condition="$post[replylink] AND $show[multiquote]">
<img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>
<if condition="$show['quickreply'] AND !$show['threadedmode']">
<a href="$post[replylink]" rel="nofollow" id="qr_$post[postid]" onclick="return false"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a>
</if>
<if condition="$show['moderated']">
<img src="$stylevar[imgdir_misc]/moderated.gif" alt="$vbphrase[moderated_post]" border="0" />
</if>
<!-- / controls -->

[MrGoodbyte]

Then you did smth. wrong :)

-g- I feared You'd say this, so I tried it once again:
Created phrase - ok
Edited postbit - same as above

For your control, if I did right (or made errors in Your oppinion) I here my edited postbit ... ;) :

<if+condition="$post['replylink'] AND $show['multiquote']">


<img+src="$stylevar[imgdir_misc]/mq_img_off.gif"+alt="$vbphrase[multiquote]"+border="0"+width="21"+heigh

t="15"+name="multiquote_$post[postid]"+id="multiquote_$post[postid]"+onclick="toggleMultiQuote($post[pos

tid],+this)"+style="cursor:pointer"+/>
</if>
<!-- / controls -->

I really don't know where the fu..... +-symbols come from, they neither appear in my postbit-template nor in my text-editor .... :disappointed:

I'm really sorry, but I think there really is an mistake in the code ... :o

http://www.mr-goodbyte.de/greetz.png

[ManagerJosh]

Not sure what to say Kirby, but it doesn't work for me either.

[Andreas]

I am sorry for having to say that, but:
Installed and working fine on Gold.
http://kirbydemos.ath.cx/forum

Nevertheless, I'll convert it to a product so manually adding the phrase is not necessary :)

[Xplorer4x4]

Quit lieing to us Kirby! ;)

[Colejo]

Yeah, for some reason, the original copy and past from the file doesn't work right. Try this:


<if condition="$post['replylink'] AND $show['multiquote']">
<img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>


Should work just fine.

Thanks. I was getting an error before but it worked with this copy.

[Snake]

Well it's working fine for me here. And yes, I'm running on 3.5.0 Gold. Have a look: http://forums.mgszone.com

Kirby one thing, I'm currently using a black / grey skin and those two button images do not fit on my skin so could you change the color of the buttons?

[Snake]

Errr actually it is not working now. The images are displayed so I thought the hack's working but it ain't. Kirby man, I guess those guys were right about it. The hack truly ain't working so you gotta upgrade it for 3.5 Gold.

[Andreas]

Snake, I got it installed on my Testboard which is running 3.5 Final.
Wanna confirm there that it does work?

http://kirbydemos.ath.cx/forum

[Snake]

Haha I have just registered your testboard, tested the hack and finally... it DOESN'T work! Why don't you go and check it yourself if ya ain't gonna believe me? :P

[Xplorer4x4]

Sorry to tell ya Kirby but I registered as well. It does not work.

[Andreas]

Haha I have just registered your testboard, tested the hack and finally... it DOESN'T work! Why don't you go and check it yourself if ya ain't gonna believe me? :P
I did test it (http://kirbydemos.ath.cx/forum/showpost.php?p=15&postcount=10) - and it works fine for me.
So, how exactly did you get it to not work?
I can't reproduce it.

[ManagerJosh]

I did test it (http://kirbydemos.ath.cx/forum/showpost.php?p=15&postcount=10) - and it works fine for me.
So, how exactly did you get it to not work?
I can't reproduce it.

Kirby, I can't get it to work either. Perhaps if you post procedures on how to get multiquote working (like what you are doing) and maybe we can see if we can follow those steps to reproduce what you are doing)

[theArchitect]

Kirby, I can't get it to work either. Perhaps if you post procedures on how to get multiquote working (like what you are doing) and maybe we can see if we can follow those steps to reproduce what you are doing)

Do you have any other hacks installed?

I test all hacks locally before uploading them to my live board (the experience of having a wayward MySQL command obliterate all but 9 of my forums tables on my live board once has taught me that much). But I have noticed that every hack I have tried on my test board (which has no mods) works perfectly. But when I then try the install on my live board most work, but some don't, others cancel out unrelated hacks and some even stop default functions from working.

I have never been able to work out what causes this, and doubt if I ever will as vB.com staff won't address issues caused by mods, and mod authors often can't help as their hacks work fine, just not in conjunction with some others.

[Darat]

Just thought I'd post this here, some of my members didn't find the "selected" icon (mq_img_on.gif) very noticeable so I added a bit of yellow to make it stand out a bit more.

[Xplorer4x4]

Kirby how about listing the step to using it? I have tired it yet again and it does not work. I think that it apers to have some sort of flaws seeing as 3 of us can not set it to work on your board.

[Andreas]

Kirby, I can't get it to work either. Perhaps if you post procedures on how to get multiquote working (like what you are doing) and maybe we can see if we can follow those steps to reproduce what you are doing)
I click several multiquote icons, then click the reply button - the form appears will all the quotes in it.

[Colejo]

If works fine on my board.

[ManagerJosh]

I click several multiquote icons, then click the reply button - the form appears will all the quotes in it.

Ah it does work. I now know what's the problem. It's how it's setup to work Kirby.

For those that didn't work, test these steps out:

1) Select several posts you want quoted.
2) After quoting them, press "QUOTE" and it will activate.


Kirby, my suggestion is that you get this to work with Quick Reply as well as honestly, many people, including myself, thought it would work in quick reply.

[Xplorer4x4]

OK Kirby I see it worked. I was using the quick reply. Not reply. However the code simple will not work. I assume it is from one of the two template mods I have. One is custom profile field and the other is Adsense after the first post. Is there anyways possibel you could fidn a work around for this when you have some free time from fixing other hacks and espcialy AWS. :p

[ThePimp]

I get the following error in Step 4:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /web/www.site.com/html/includes/adminfunctions_template.php(3519) : eval()'d code on line 250

[ThePimp]

Ok, I just removed the <if> conditional and got the buttons to display, however, the multi-quote doesn't seem to be functioning properly. I've tried quoting 3 different people, and it seems that only 2 of them show in the Reply box.

After further testing, it seems as though the "LAST POST" in a thread doesn't seem to be taking. I can quote 20 other posts, but if I include the last post in the thread, all will show except for that one.

EDIT:

I can multiquote a few posts, then "Quote" the last post and it seems to work fine (All multiquotes + the last post). Just that "Multiquote" doesn't seem to function when you multiquote all of them, then click "REPLY".

[Andreas]

Kirby, my suggestion is that you get this to work with Quick Reply as well as honestly, many people, including myself, thought it would work in quick reply.
I clearly stated somewhere up in the Thread that it currently does not work with QR.
I got the Code that works with QR ready since months, but it is 70 km away on another computer which isn't online and I didn't have the time to go there ... yet.

@The Pimp
I don't understand your post.
Please tell me what exactly does not work (eg. what are the necessary steps to reproduce the failure).

[ThePimp]

I clearly stated somewhere up in the Thread that it currently does not work with QR.
I got the Code that works with QR ready since months, but it is 70 km away on another computer which isn't online and I didn't have the time to go there ... yet.

@The Pimp
I don't understand your post.
Please tell me what exactly does not work (eg. what are the necessary steps to reproduce the failure).

In a thread, click "Multiquote" on 2 or 3 different posts (make sure one of them is the LAST post in the thread). Then click "NEW REPLY" at the bottom or top.

The "Last" post doesn't get quoted for some reason.

[Allan]

work on vB 3.5 ? no update ?

[Andreas]

In a thread, click "Multiquote" on 2 or 3 different posts (make sure one of them is the LAST post in the thread). Then click "NEW REPLY" at the bottom or top.

The "Last" post doesn't get quoted for some reason.
This is actually working as designed (and has also been mentioned earlier):
The default vBulletin behaviour of the New Reply Button is set to be a reply to the last post without quoting it.
This Hack respects this behaviour and therefore doesn't quote this post, even if it was selected for multiquote.
If you want to quote it, you have to click the Quote button of the last reply.

[ManagerJosh]

I clearly stated somewhere up in the Thread that it currently does not work with QR.
I got the Code that works with QR ready since months, but it is 70 km away on another computer which isn't online and I didn't have the time to go there ... yet.

@The Pimp
I don't understand your post.
Please tell me what exactly does not work (eg. what are the necessary steps to reproduce the failure).

Perhaps it would be a good idea to update the description of the hack :p

[Andreas]

Done :)

[drumsy]

I get:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/hondaacu/public_html/forums/includes/adminfunctions_template.php(3519) : eval()'d code on line 190

When attempting to add the template changes to the postbit_legacy template.

[Darat]

I get:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/hondaacu/public_html/forums/includes/adminfunctions_template.php(3519) : eval()'d code on line 190

When attempting to add the template changes to the postbit_legacy template.

I was getting this error when I tried to copy it directly from the text file, what I did was copy the code from this post: https://vborg.vbsupport.ru/showpost.php?p=728214&postcount=28

[Xplorer4x4]

I was getting this error when I tried to copy it directly from the text file, what I did was copy the code from this post: https://vborg.vbsupport.ru/showpost.php?p=728214&postcount=28

I used this code and it works, HOWEVER, I am having a odd problem now. I qoute 2 posts...

Post 1: Hi
Post 2: Hello

I click the multiqoute buttons. I can click reply or quote, but when the quoted posts show up in the reply page, Post 1 will be quoted once, but Post 2 is being quoted 3 times.

[drumsy]

One of my users is reporting the following bug:

here's how to reproduce it.

1. go to any thread and click the multiquote checkbox on a few posts (say 4 of them)
2. use your back button
3. go to another thread, and use the quote button. (just to reply to one post)

look at your reply box, it's filled with the posts from the other thread.

Is there anyway to clear any cookies associated with multiquotes when entering a new thread?

[Lottis]

This wont work in my place. I can see the image, but it wont post it.

[Andreas]

@drumsy
This not a Bug but working as designed :)
Like with inline moderation, you can select posts for quotes from anywhere.
But I recon that a feature to clear the cookies might be useful, so i'll put this on teh todo-list.

[Xplorer4x4]

I used this code and it works, HOWEVER, I am having a odd problem now. I qoute 2 posts...

Post 1: Hi
Post 2: Hello

I click the multiqoute buttons. I can click reply or quote, but when the quoted posts show up in the reply page, Post 1 will be quoted once, but Post 2 is being quoted 3 times.

Now it seems to quote the first post ONLY, and quotes it 3 times. Being this is a cookie related I seem to be having some cookie problems as of late. I noticed on some of the Invision Free forusm there not stroing my cookies.

Any ideas?

[Snake]

@drumsy
This not a Bug but working as designed :)
Like with inline moderation, you can select posts for quotes from anywhere.
But I recon that a feature to clear the cookies might be useful, so i'll put this on teh todo-list.

Not to be rude or anything but I really don't like the way how you designed it.

[Andreas]

You don't have to use it if you don't like it.
Really simple, isn't it? :)

[prawn]

Why is that noquote=1 implented in the default vBulletin script? I don't get the use of it.

[EvilHawk]

It works fine!

/me clicks install!

[SpaceStar]

This is the error I get when I use $post['replylink']:



Satan

I got exactly the same error - but chaing it to what Chris suggested - it worked :)


I cannot se if there is happening anything when marking a text and clicking on that icon....

[BlackxRam]

How Safe is This with vb 3.5 Gold?

[Vierie]

Works fine with vb 3.5 Gold.

[Ranger187]

It comes with an additional JS File, so as of our definition it is not a Plugin ...

Odd, I installed it and see nothing. And I followed the instructions to a T.

[Zachery]

Odd, I installed it and see nothing. And I followed the instructions to a T.

Did you remember to edit the right postbit / postbit_legacy template?

[The Wise One]

nice. installed.

[Allan]

thanks for this hack Kirby ;)

Click Install

[GrendelKhan{TSU]

lol grrr..I was waiting for someone to put this hack out only to find that it was already out for a while now. *@&#$#@&!
* GrendelKhan{TSU clicks INSTALL!! :D
<<working fine on 3.5.0 gold ;)

FYI... I know why it doesn't work when cutting and pasting from the readme (and/or adds weird character stuff sometimes)

it has to do with how the readme was saved....
utf, unicode, ascii, or just txt file whatever.

I see this happen cause when I opened the readme ...I had a ton of characters broken and or in Korean. And when I close it it asks me if I want to save as TXT file and remove all formatting. NOTE: that's without touching anything...just opening it and closing it again. I have lots of computer and this only happens on my computer I have that I have to switch between languages a lot. honestly, don't realllly understand when or why it saves one way or another...just know to expect it and adjust. :ermm:

I bet Andreas has a computer with other languages installed or deals with unicode more--which is why it works fine for him, but not for others (who probably only have english fonts or don't deal with Unicode stuff much). Andreas...make sure your readme is saved a TXT file only. (see? everyone else wasn't imagining it ;)) anyway....so that why that is.

if he doesn't resave the readme. Be sure to just copy and paste from this thread instead of copy paste from the readme. ;)

[Andreas]

I really wonder how that happened, lol.

[GrendelKhan{TSU]

I really wonder how that happened, lol.


... :)

[bretthoerner]

Can anyone explain why it doesn't let you MQ the last post in a thread? I realize this is intended, but why?

[Vierie]

MQ the other threads and use quote instead of answer and you get all of them.

[ronoxQ]

Help! My images aren't appearing! I uploaded them to the misc directory, but...

Save me...

[Adam14]

Ok, please excuse my noobness...but, how do I :

3) Create the following Phrase

Phrasetype: Show Thread
Varname: multiquote
Text-Multi-Quote with this Post

this is something I'd love to have, instead of opening multiple windows to quote multiple quotes, but this is the part I am stuck on. Any help would be great! Thanks.

[DS MrSinister]

Ok, please excuse my noobness...but, how do I :

3) Create the following Phrase

Phrasetype: Show Thread
Varname: multiquote
Text-Multi-Quote with this Post

this is something I'd love to have, instead of opening multiple windows to quote multiple quotes, but this is the part I am stuck on. Any help would be great! Thanks.


In the admincp look under Languages & Phrases --> Phrase Manager and add new phrase.

[Vierie]

Help! My images aren't appearing! I uploaded them to the misc directory, but...

Save me...

A little bit more information would help people to help you. How are we supposed to know why you don't see your images?

Do you use different styles? What's the link to your images? What's the link to your forum? etc...

[ronoxQ]

Sorry for being vague.

I use the Techus style for my forum, and it uses a different directory for images. Would that change the base images directory as well?

[brent_strong]

Sorry for being vague.

I use the Techus style for my forum, and it uses a different directory for images. Would that change the base images directory as well?

Yes, it did for me. I found this out by checking the bad url for the multiquote image, which was pointing to /images/style/misc not /images/misc as I had expected.

Drop them into the style misc or I'm sure someone could change around the variable that points the directory to just read from /images/misc

[TosaInu]

Another Kirby hack rocking on our 3.5.3 board. Thanks. :)

[hiiped]

....I got the Code that works with QR ready since months, but it is 70 km away on another computer which isn't online and I didn't have the time to go there ....

was that code ever released here ?

I've seen it on another board ( cant remember where exactly )

this is how it worked on that board

example: when I click the QR button in post 2, the message from post 2 appears in the QR box and I can comment....
then I can click the QR button in post 3 and the message from post 3 appears below my QR comment, ... etc, etc ...


looking for the QR code

Thanks in advance

[vietfancy]

was that code ever released here ?

I've seen it on another board ( cant remember where exactly )

this is how it worked on that board

example: when I click the QR button in post 2, the message from post 2 appears in the QR box and I can comment....
then I can click the QR button in post 3 and the message from post 3 appears below my QR comment, ... etc, etc ...


looking for the QR code

Thanks in advance

i saw that hack on NamePros.com

[Andreas]

this is how it worked on that board

example: when I click the QR button in post 2, the message from post 2 appears in the QR box and I can comment....
then I can click the QR button in post 3 and the message from post 3 appears below my QR comment, ... etc, etc ...


looking for the QR code

Thanks in advance
AFAIK that is different Hack Xenon did for 3.0, not sure if it is already available for 3.5.

[SpaceStar]

A question: Does this work with 3.5.3 as well??

[alluidh]

It does very well

THX Andreas - Installed

[Kmaster]

great hack, really hope it can work with QR.

[Tralala]

Just installed this this evening and it seems to be working fine, for the most part... just one concern that'll cause confusion:

Question.. Can the order that the quotes are displayed be reversed? It's showing the most recent post/quote first, rather than the oldest.



I find when I select a bunch of posts, and click "New Reply" at the bottom of the screen, the quotes are in the correct chronological order. :up:

However, when I select a bunch of posts, and click "Quote" on the last one, that one ends up displaying first... and then the rest are in chronological order.

Is there any way to make the "Quote" button work the same way as the "New Reply" button, when Multi-Quote is in effect? I'd like Multi-Quotes to always be prepared chronologically, regardless of what button was pressed to get to the post composition window.

[Tralala]

What would explain this?

On my default style (a 3rd party one I've chosen) if I select the first post in a thread for multi-quoting, it doesn't get included when I click "New Reply." It only gets included when I click "Quote" -- and as mentioned above, the quotes are out of order.

Yet on the other style (vBulletin Generic,) clicking "New Reply" or "Quote" have the same effect, the first post is always included.

What can I edit in my default style so that it works consistently?



EDIT: More info. On vBulletin Generic, the last post doesn't get included (as intended, as explained by Andreas,) but first one does. On 3rd party style, last post does get included... but first one doesn't. So somehow the rules are reversed for these styles. :confused:

[Nathan2006]

Thank you Andreas

Working fully :)

Install

[Bulent Tekcan]

Also this is standart for vB3.6

[Nathan2006]

Also this is standart for vB3.6

Yeah but I dont want to upgrade just yet ;)

[bairy]

Plugin location: newreply_form_start
Code:

// ################################################## ###########################
// # START MULTI QUOTE #
// ################################################## ###########################
if (!$newpost['preview'] AND $postids = $vbulletin->input->clean_gpc('c', COOKIE_PREFIX . 'multiquote', TYPE_STR))
{
$postids = explode(',', $postids);
$tmp = array();

//------------------------------
// Make sure we don't double
// posts if user selected and
// pressed the "reply" button
//------------------------------
if ($postinfo['postid'] AND !$vbulleitn->GPC['noquote'])

[//snipped the rest//]


Last line: $vbulleitn :P

[between worlds]

Just installed it on vb3.5.4 and it installed ok but doesn't seem to work. There are no obvious problems. It just doesn't quote what we want it to quote. There are no error messages etc... any idea what we could possibly have done wrong? I did have it installed before I upgraded the board to the newer version, so its really just upgrading it.

[noonespecial]

I wish the "mutiquote" icon would work/show up still on posts that appear after using quick reply (the ajax pulled posts) ... that'd be nice.

[Watched]

i don't suppose this hack will be updated anytime soon w/ full ajax support and full quick reply support, will it?

[navjotjsingh]

How to make it work on 3.6.0? Will this work on 3.6.0 without any editing?

[Nathan2006]

How to make it work on 3.6.0? Will this work on 3.6.0 without any editing?

This is already a default option in version 3.60 so you dont need to use this hack when you already have it:D

[navjotjsingh]

I haven't started using my vb 3.6.0 so I didn't know...thanks!

[Nathan2006]

I haven't started using my vb 3.6.0 so I didn't know...thanks!

You can find a list of just a few things that are in version 3.60 here
http://www.vbulletin.com/forum/showthread.php?t=186803

Im going to wait a few more months until my favorite hacks
are updated for 3.60 ;)

Also a lot more info can be found here about other things with version 3.60 too http://www.vbulletin.com/forum/forumdisplay.php?f=1

[Ziki]

Andreas this doesn't work ;)

[JohnBee]

Can anyone fix this so it works with Quick Reply?
Our site is very large and there are still a lareg number of mods missing in 3.6 yet.

[neverknow1]

plugin installed.... although it was a bit confuse towards the last of the insturction.

5) Install the Plugin from multiquote.xml

Normally I go to Plugins & Products ==> Manage Products ==> Add/Import Product.

Apparently this doesnt work as the vb told me it is a plugin, can install this way.

What I did was I go to Plugins & Products ==> Download / upload plugins==> Scroll to the bottom the upload plugin option to import the plugin.

Then, it is DONE!!! You can see my forum for how does it look like.. it is in working condition now.