Attachment Upload by URL

[akanevsky]

/*================================================= =====================*\
|| Attachment Upload by URL
|| Author : Psionic Vision
|| Works on : vBulletin 3.0.7 Only
\*================================================ ======================*/

There have been some requests for attachment upload by URL option... So here it is - my atttempt to create something like this. I am not sure that the way I did it is completely valid, but it does work. That is why I put it in beta releases. The code is fairly short, so it will not take more than one minute to install or remove it.

What this does is, it allows a user to upload an attachment from an URL rather than directly from user's computer. Sometime it is very useful.

Please test it out and comment and/or criticize. Thanks.

Edit: A fix was posted, please see this post:
https://vborg.vbsupport.ru/showpost.php?p=648337&postcount=14
This fix is included into the new manual.

[nexialys]

a description of the tool please.. .title is not making any credit to your work.. ;)

[jugo]

I believe it allows you to attach a file from a url instead of uploading it.

[akanevsky]

jugo,
Exactly.

[jugo]

In That Case:

/me installed faster than a fat chick heads to the buffet.

Thanks Bro!!!

[KTBleeding]

Does this attach images using the [img] bbcode? Or does it add a new line to the attachment part with the option of a URL?

[akanevsky]

Yes, it adds a field for URL input next to the field for file input :)

Thanks Bro!!!
:)

[sabret00the]

very sweet mod, should've been part of the product ages ago.

[Reminder]

Not working. Error "Please select a file to attach using the "Browse..." button."

[akanevsky]

Then you did not install it correctly. What is your vB version?

[Zachery]

Not working. Error "Please select a file to attach using the "Browse..." button."
Please do not report a post if its not working for you. You should contact the author or uninstall the hack

[Reminder]

Please do not report a post if its not working for you. You should contact the author or uninstall the hack

Oppps. Sory. Ok. :)

[Lionel]

Your problem is in the javascript in template that checks for a value in upload field.

[akanevsky]

Sorry, I forgot to include that into the instructions. Will update them in a minute.

The fix is as follows:

In template 'newattachment', find:

if (elm.type == 'file')

and replace with:

if ((elm.type == 'file') || (elm.type == 'text'))

[AN-net]

from the looks of it this hack requires curl which is not a standard library, you should mention this in the first post;)

pretty cool though, i may look into it;)

[Trigunflame]

from the looks of it this hack requires curl which is not a standard library, you should mention this in the first post;)

pretty cool though, i may look into it;)

Yes he is using curl.
This can be done much easier with fopen.

I have not Installed this hack, or tested my file change.. It should work though.

Replace the Code he gives in the install file with this.


if (is_array($_POST['attachmenturl']))
{
foreach ($_POST['attachmenturl'] AS $key => $url)
{
// attempt to fetch the filename from the url
preg_match('/\/([A-z0-9]*)([\.]{1})([A-z0-9]{2,6})$/si', $url, $matches);
$filename['original'] = str_replace("/", "", $matches[0]);

// did we retrieve a valid filename?
$validurl = iif(!empty($url) AND !empty($filename['original']), true, false);

/*
* FOPEN Modification By Trigunflame
*/
// valid url
if ($validurl)
{
// init
$data = '';

// cancel the file that might have been uploaded
unset($_FILES["attachment{$key}"]);

// attempt opening of remote file
if ($fileOpen = @fopen($url, "rb"))
{
while (!feof($fileOpen))
{
$data = @fread($fileOpen, 4096);
}
@fclose($fileOpen);
}

// empty
if (empty($data))
{
$error = construct_phrase($vbphrase['error_cannot_retrieve_url'], $url);
$errors[] = array(
'filename' => htmlspecialchars_uni($url),
'error' => $error
);
}

// save file
else
{
$tmp_name = 'vbupload' . substr(TIMENOW, -4);
$filesize = strlen($data);

// write file to temporary directory...
if ($vboptions['safeupload'])
{
// ... in safe mode
$filename['temp'] = $vboptions['tmppath'] . "/$tmp_name";
$filenum = @fopen($filename['temp'], 'wb');
@fwrite($filenum, $data);
@fclose($filenum);
}
else
{
// ... in normal mode
$filename['temp'] = tempnam(ini_get('upload_tmp_dir'), 'vbupload');
$fp = @fopen($filename['temp'], 'wb');
@fwrite($fp, $data);
@fclose($fp);
}

$_FILES["attachment$key"]['name'] = $filename['original'];
$_FILES["attachment$key"]['type'] = '';
$_FILES["attachment$key"]['size'] = $filesize;
$_FILES["attachment$key"]['tmp_name'] = $filename['temp'];
$_FILES["attachment$key"]['error'] = 0;
$_FILES["attachment$key"]['url_upload_by_curl'] = 1;
}
}
}
}

[Allan]

screenshot please, just for looking ?

[Reminder]

Then you did not install it correctly. What is your vB version?
Vbulletin Version 3.0.7

[Boofo]

Yes he is using curl.
This can be done much easier with fopen.

I have not Installed this hack, or tested my file change.. It should work though.

Replace the Code he gives in the install file with this.


if (is_array($_POST['attachmenturl']))
{
foreach ($_POST['attachmenturl'] AS $key => $url)
{
// attempt to fetch the filename from the url
preg_match('/\/([A-z0-9]*)([\.]{1})([A-z0-9]{2,6})$/si', $url, $matches);
$filename['original'] = str_replace("/", "", $matches[0]);

// did we retrieve a valid filename?
$validurl = iif(!empty($url) AND !empty($filename['original']), true, false);

/*
* FOPEN Modification By Trigunflame
*/
// valid url
if ($validurl)
{
// init
$data = '';

// cancel the file that might have been uploaded
unset($_FILES["attachment{$key}"]);

// attempt opening of remote file
if ($fileOpen = @fopen($url, "rb"))
{
while (!feof($fileOpen))
{
$data = @fread($fileOpen, 4096);
}
@fclose($fileOpen);
}

// empty
if (empty($data))
{
$error = construct_phrase($vbphrase['error_cannot_retrieve_url'], $url);
$errors[] = array(
'filename' => htmlspecialchars_uni($url),
'error' => $error
);
}

// save file
else
{
$tmp_name = 'vbupload' . substr(TIMENOW, -4);
$filesize = strlen($data);

// write file to temporary directory...
if ($vboptions['safeupload'])
{
// ... in safe mode
$filename['temp'] = $vboptions['tmppath'] . "/$tmp_name";
$filenum = @fopen($filename['temp'], 'wb');
@fwrite($filenum, $data);
@fclose($filenum);
}
else
{
// ... in normal mode
$filename['temp'] = tempnam(ini_get('upload_tmp_dir'), 'vbupload');
$fp = @fopen($filename['temp'], 'wb');
@fwrite($fp, $data);
@fclose($fp);
}

$_FILES["attachment$key"]['name'] = $filename['original'];
$_FILES["attachment$key"]['type'] = '';
$_FILES["attachment$key"]['size'] = $filesize;
$_FILES["attachment$key"]['tmp_name'] = $filename['temp'];
$_FILES["attachment$key"]['error'] = 0;
$_FILES["attachment$key"]['url_upload_by_curl'] = 1;
}
}
}
}


I get a filesize stats failed error with this code. ;)

[Lionel]

Can't get the fopen() code to work either.

[Boofo]

Can't get the fopen() code to work either.

You get the same error?

[Lionel]

Can't tell as error has been turned off. I get a blank page, or nothing. I managed to upload only one url... from my site

[akanevsky]

Yeah...

1. The reason I used CURL library is safety. Originally, prior to installation of my hack, the code posted above would not work, as the is_uploaded_file function would not allow it. Right now, however, his code, would pose a security threat to your board, because it would tell the API that the file was uploaded by CURL and is safe, while that is not really true.

Therefore, the alternate code of yours is completely impertinent to the hack and I would like you to remove it. Thanks.

2. The code works for my site, however I set it to time out after 25 seconds of no response. Now, what exactly is the problem?

P.S. Please read here if you don't know why fopen is not safe:
https://vborg.vbsupport.ru/showthread.php?t=80541

[Lionel]

I kind of agree with Dark Visor. Someone posted a hack, if there is a problem, let him fix it. No need to hijack his thread. That only creates confusion. If you have a different idea, create your own thread.

[Nordinho]

hmmm...this seems interesting...so does it actually upload the file on the server?? that would save loads off red crosses...and is the original version working for all??

[akanevsky]

so does it actually upload the file on the server??
Yes, it does. It creates a standard attachment, just as if you uploaded the file from your computer.

[eplus_revenge]

Dude,,i dont get any error..but after i click upload..it just says uploading..then nothign happens...

[akanevsky]

There is a timeout after 25 seconds. And it works only if you have Curl installed...

[lange]

Thanks.

[akanevsky]

I guess this could be moved to Final Releases?

[jugo]

It worked just fine for me...and i love it...time to place this puppy on the live boards!!!

[quachvu]

how can i change time out from 25s to 1 minute of more?

[quachvu]

Dude,,i dont get any error..but after i click upload..it just says uploading..then nothign happens... and i have alread installed curl

[quachvu]

Sorry, I forgot to include that into the instructions. Will update them in a minute.

The fix is as follows:

In template 'newattachment', find:

if ((elm.type == 'file'))

and replace with:

if ((elm.type == 'file') || (elm.type == 'text'))
i just found if (elm.type == 'file') in my template ...

[yoyoyoyo]

I guess this could be moved to Final Releases?I installed this in 2 minutes, and it works as described! Thanks!

It would be nice to have "upload by URL" on the same line as the entry box, though, since it is kind of confusing, but otherwise works great!

[akanevsky]

quachvu,
I do not provide support for modified templates.

yoyoyo,
thanks :) Maybe I'll make it on one line. I'll see.

[quachvu]

its a original template and was not modified, and even i set up a fresh Vbulletin 307 forum and look in newattachment i just only can find this code in it

var haveupload = false;
for (var i=0; i < formobj.elements.length; i++)
{
var elm = formobj.elements[i];
if (elm.type == 'file')
{
if (elm.value != "")
{
haveupload = true;

[akanevsky]

Sorry, my bad.
You would need to replace
if (elm.type == 'file')
with
if ((elm.type == 'file') || (elm.type == 'text'))

[logofreax]

Thank youn for this Hack but i?ve got one Problem:

If I want to attach any File by URL I get this Error Message:

Warning: filesize(): Stat failed for /kunden/73715_63755/domains/handy-faq.de/files/anhaenge/09783ad8c17c227c60f91d23b073d58c (errno=2 - No such file or directory) in /includes/functions_file.php on line 286

Can you please help me?

cu
logofreax

[akanevsky]

I don't think it has anything to do with my hack...

[yoyoyoyo]

I got the "or upload by URL:" phrase on the right line by changing this phrase:
or upload by url: to this:<br>or upload by url:

[GrusPer]

Warning: filesize(): Stat failed for /home/grusper/public_html/files_points/random/83ec84548761132acc6ed40f21085c5f (errno=2 - No such file or directory) in /includes/functions_file.php on line 286

:((
Can you please help me?

[akanevsky]

Are you running in safe mode?

[Kirk Y]

Works great... although sometimes when I try to upload an attachment, everything seems to go fine but when I try to view the attachment, there's nothing there... just a white screen. It happened when I tried to attach some image from your site Dark Visor... that coding site.

[akanevsky]

What site are you talking about??? I don't have any..

[Kirk Y]

The Rent-A-Coder site; I clicked your Bio Link.

[akanevsky]

Oh.. well maybe they have an anti-leech. That's not my site, it's a site I am a member of..

[Kirk Y]

Yeah, I figured anti-leech may be the cause, but just thought I'd mention it, if that wasn't the case.

[akanevsky]

Well do you get any error messages at all?

[adill420]

ah man..thank you!!!!!

i didn't even know this hack was here!

once again thanks dark visor!

[Replicators]

This is one hack i seriously need,but it doesn't work on 3.0.9 >8(

Is there any plans to make it compatible with 3.0.8 and higher?

[akanevsky]

No, as I do not support the 3.0.x series anymore. I'd suggest you upgrade your board to 3.5, where this functionality exists by default.