Geek Article System 3.5 RC2

[The Geek]

Woohoo.

This is the RC for the next release of the Geek Article System.
I have decided to take it out of private beta as results from the private beta are taking yonks to come back in. I have fixed all known issues so we should be cooking on gas (hohohahaha).

Special thanks to gltdn for help with beta testing

Install instructions:
Read the readme in the package. Should be straight forward stuff.
It is important to note that THIS IS FOR A CLEAN INSTALL. I will devise an upgrade script when the package is final.

New features:

Crap loads.
New Article header image functions (global gallery, forum gallery and uploadable images)
New forumdisplay/threadbit look and feel
Synopsis box
Post as user
Autolink into the Geek Autolink system
Turn on/off synopsis/byline
Auto synopsis (if synopsis is off or left blank, it uses first x amount of posts from article)
Synopsis uses BB code
etc...etc...etc
A word about the installer.
This has taken me ages to do. The installer does everything for you (including all file changes). It will make backup copies of all files changed, make the file changes, and leave them in a folder for you to copy over when you are done. This may not work with PHP in safe mode. If you are using PHP in safe mode, you may have to do the changes manually (which you have the option to do anyway).

Click the install button if you install. Otherwise you may miss very important updates.

Demo: http://www.thenailgeek.com/forumdisplay.php?f=17

Missing phrases after install? Just search for a GAS phrase name... edit it, then click save. This will rebuild your phrases.

nJoy

[The Geek]

To upgrade from 3.5 you CAN do this:

Run the uninstall for version 3 and replace the following files with clean copies:
showthread
editpost
newthread
printthread
includes/function_showthread

Then remove the GAS reference in admincp/index.php

Then follow the install instructions for this package.

[Juan]

To upgrade from 3.5 you CAN do this:


Does upgrading using those instructions keep the old artitles or will the tables be overwritten?

Thanks

[FleaBag]

Hey, nice work! I've been watching this project with a keen eye for some time... And I like! I'm eventually going to move over to a new article system from vBarticles for various reasons. Nice to see an installer that modifies the files for you too!!! Haven't seen that since my days in UBB. :D

[Magic Spark]

Hi The Geek,

first - thank you, for that wonderful hack.

I think I found the first little bugs:

1) Deletion of an article, doesn't delete the row in geek_articles table.
2) The file GAS_image_upload.php is not in the ZIP-Package
3) On showthread.php Templates 'GAS_article_pb' and 'GAS_showthread' needs to be cached.
4) On forumdisplay.php Template 'GAS_threadbit' needs to be cached.
5) When I edit an article, the article-image disappear.

Keep on the good work...

[roundhost]

Looks cool! (maybe there could be an addon to get news off rss feeds :p)

[The Geek]

Does upgrading using those instructions keep the old artitles or will the tables be overwritten?

Thanks
Hey Juan - It will keep the articles as is. However It just occured to me that the DB will have to be manually altered as it only does a clean install if it doesnt already exists. In other words if the table exits 0 it ignores it and there are a couple of columns that need adding. Ill post an updated on that tonight.

Magic - Cheers for the info - Ill do an update later tonight

[The Geek]

Hi The Geek,

first - thank you, for that wonderful hack.

I think I found the first little bugs:

1) Deletion of an article, doesn't delete the row in geek_articles table.
2) The file GAS_image_upload.php is not in the ZIP-Package
3) On showthread.php Templates 'GAS_article_pb' and 'GAS_showthread' needs to be cached.
4) On forumdisplay.php Template 'GAS_threadbit' needs to be cached.
5) When I edit an article, the article-image disappear.

Keep on the good work...
Updated package but....

1) Didnt address this as of yet. The only downside to the article header row not being deleted is that its a spare row floating about. Ill address this eventually but since I dont see it as ever being a problem - Ill make it low priority :)
2) The file was in the root of the folder... It goes in your root directory.
3) Done... thanks!
4) Done... thanks!
5) Cant reproduce. Maybe it was the missing GAS_image_upload file?

Let me know if that sorts it. Thanks again!

[The Geek]

BTW: just updated package so that when upgrading, it will upgrade the geek_article Table too.

[gldtn]

2) The file was in the root of the folder... It goes in your root directory.

2) root dir of the forum or the server?

[The Geek]

2) root dir of the forum or the server?
Sorry man - forum root :)

[gldtn]

Ok, thanks! :)

Remaining Issues;


// Showthread/Article

.Tweaks needed

>> bottom COMMENT button needs a space from article body(perhaps another <br />?(I use FIREFOX/Have not checked under IE))

To fix this edit GAS_showthread and find:
<table cellpadding="0" cellspacing="0" border="0" width="100%">
<tr valign="top">
<if condition="$show['largereplybutton']">
<td class="smallfont"><a href="newreply.php?$session[sessionurl]do=newreply&amp;noquote=1&amp;p=$LASTPOSTID"><if condition="$show['closethread']"><img src="$stylevar[imgdir_button]/comment.gif" alt="$vbphrase[reply]" border="0" /><else /><img src="$stylevar[imgdir_button]/threadclosed.gif" alt="$vbphrase[geek_articles_closed_article]" border="0" /></if></a></td>
<else />
<td class="smallfont">&nbsp;</td>
</if>
</tr>
</table>


Replace with:

<table cellpadding="0" cellspacing="0" border="0" width="100%" style="margin-top:3px">
<tr valign="top">
<if condition="$show['largereplybutton']">
<td class="smallfont"><a href="newreply.php?$session[sessionurl]do=newreply&amp;noquote=1&amp;p=$LASTPOSTID"><if condition="$show['closethread']"><img src="$stylevar[imgdir_button]/comment.gif" alt="$vbphrase[reply]" border="0" /><else /><img src="$stylevar[imgdir_button]/threadclosed.gif" alt="$vbphrase[geek_articles_closed_article]" border="0" /></if></a></td>
<else />
<td class="smallfont">&nbsp;</td>
</if>
</tr>
</table>



// Editing Article


.Article Image

>> is showing to be edited/changed
>> is NOT getting edited/changed

[The Geek]

Thanks... make sure you installed the latest package and reverted your templates from the private beta test. The comment placement was fixed.

Once again, make sure you have reverted your templates. There was a typo in that was causing the article header image not to display but this was fixed.

Let me know if that sorts it as both issues seem fine on my system.

[Magic Spark]

Updated package but....

1) Didnt address this as of yet. The only downside to the article header row not being deleted is that its a spare row floating about. Ill address this eventually but since I dont see it as ever being a problem - Ill make it low priority :)
2) The file was in the root of the folder... It goes in your root directory.
3) Done... thanks!
4) Done... thanks!
5) Cant reproduce. Maybe it was the missing GAS_image_upload file?

Let me know if that sorts it. Thanks again!

Hi Geek,

1) I think we misunderstood: I talked about the db table geek_articles. ;)
When I delete an article, the article-row stays in the db-table 'geek_articles'.
2) Sorry, i've overlooked it.

One new little bug:
Tested with TABLE_PREFIX: Do a fresh Install - the installer creates the the table 'geek_articles' without the prefix.

Thanks for address the reported bugs so fast.
Testing the new Version asap.

[The Geek]

Hi Geek,

1) I think we misunderstood: I talked about the db table geek_articles. ;)
When I delete an article, the article-row stays in the db-table 'geek_articles'.
2) Sorry, i've overlooked it.

One new little bug:
Tested with TABLE_PREFIX: Do a fresh Install - the installer creates the the table 'geek_articles' without the prefix.

Thanks for address the reported bugs so fast.
Testing the new Version asap.
Hey Magic - Na, I know what you meant. It doesnt remove the entry from the geek_articles table. But like I said - I cant foresee that as causing any problems.

THanks for the heads up about the table_prefix. However thats a trip as it is in there! I am wondering if the scoping of table_prefix has been changed. I dont use them so ill have to look into that a bit more. Can anyone else verify?

Thanks again Magic - your points are helping me get this thing live ;)

[gldtn]

Thanks... make sure you installed the latest package and reverted your templates from the private beta test. The comment placement was fixed.

Once again, make sure you have reverted your templates. There was a typo in that was causing the article header image not to display but this was fixed.

Let me know if that sorts it as both issues seem fine on my system.
If you do an install shouldn't this overwrite your existing templates? Because all templates are shown to be last edited by the install script;

Last edited March 13 2005 at 13:10 by Geek

Also note; The header image is showing, what I tried to say is that it cannot be changed to something else if we wish to.

[Magic Spark]

Hi Geek,

5) When I edit an article, the article-image disappear.

This happens only when I set in the gas-options 'Use first attachment thumbnail as avatar' to yes.

By the way, in the gas-options, under 'Header images' there is a input row without title and description. The name of the text-input is 'ugs_allow_header_upload'.
Maybe it helps to find it.

I'll try the help to find bugs as fast as possible, to help to get this superb addon live.

[The Geek]

Cool guys.

I have:

Sorted out the bugs where regarding 'show first thumbnail as avatar'. Now you can get the same forum home effect as when using header images - but with thumbs! However I STRONGLY advise having users upload or choose from the gallery instead - it is MUCH faster.
I found the TABLE_PREFIX bug so that now works.
The Image header option in editthread and newpost only appear if you are not using the 'show thumbnail as header image' option. THis was the source of earlier confusion.
I found the missing phrase in the admincp
I fixed the comment button spacing (sorry gldtn - I hadnt updated the install package with the latest template).
Bunch of other minor fixes too.
Package is updated :)

[eva01_]

question The_Geek are some of the intros on http://www.thenailgeek.com/forumdisplay.php?f=17 supposed to be blank?

[The Geek]

question The_Geek are some of the intros on http://www.thenailgeek.com/forumdisplay.php?f=17 supposed to be blank?
Yea - havent filled in all of the synopsis's yet.

[eva01_]

ok just was making sure that it was compatible with safari ;)

[The Geek]

Package updated to beta 1.03
Very minor bug in GAS_article_pb. For those that updated to 1.02, simply upload latest files and re-install the templates only.

[KTBleeding]

Looks very good as always, Geek. I will wait to install when it's out of Beta though.

[The Geek]

Woo-hoo. Gotta love a Beta :)

Package updated to 1-04. Minor bug found in step 603.
To upgrade from last 2 packages just replace all files and then manually replace step 603.

Thanks guys (think it should be almost there now!)

[shiva]

This may be a silly question, but after installing this, then what do we do if there's no listing for this in our VB Options? :)

[The Geek]

This may be a silly question, but after installing this, then what do we do if there's no listing for this in our VB Options? :)
Its graduated to its very own admin page ;)

There should be a Geek Article System link in your admincp (one of the file edits was adding this)

[shiva]

well, no link... in the left column?

Everything else is fine, created the templates fine etc, added the edits, just can't find the admin link,

[The Geek]

well, no link... in the left column?

Everything else is fine, created the templates fine etc, added the edits, just can't find the admin link,
Did you check manually edit the files or did you run the auto file editor?

If you did the auto, did you copy the changed files from gas/changed/ into their corresponding forum/ folder location?

In there will have been gas/changed/admincp/index.php which will be your altered admincp page with the GASK group in it.
You could also just go to admincp/GAS_admin.php

[shiva]

damn, know why, I use 3.05, and I bet you those **** devs changed something again. doing a dirct url to the admincp shows the thing though, so I can change them there, or at least try too. Maybe I have a ghost or something. (Note to other people, update the phrases...)

[The Geek]

damn, know why, I use 3.05, and I bet you those **** devs changed something again. doing a dirct url to the admincp shows the thing though, so I can change them there, or at least try too. Maybe I have a ghost or something. (Note to other people, update the phrases...)
could be the phrases didnt update.

Please check your admincp/index page for the GAS edit though. If that didnt go through - it should have informed you to do it manually.

[Magic Spark]

Hi Geek,

one more bug in actual Beta Release found:

When I create a new article, fill out Byline and Synopsis, hit Preview and then create the article, the Byline and Synopsis disappear.
The same, if I edit an article and hit preview first.

One more:

In printthtread.php Template 'GAS_printthreadbit' should be cached.

[shiva]

yeap, now it works, reloaded it in.

Least I have it listed in now, now just to figure out how to get the thing to display the way I want it.

You know Geek, your installer is very cool and all, but there's nothing on the settings themselves. I redid the phrases, and also reupped the includes file as well.

So a couple questions here:

My forum is a subdirectory, that make a difference? So absolute path to images will be /var/www/html/forums/gas/images?

also, in the first field, for forums. I'm assuming that would be the id number, but multiple forums would be say 2,33, 19 right?

I guess the converter should now work as well, but we would still have to edit each thread then for a synopsis and a byline? Yikes. over 400 articles. :)

[Snow]

Excellent installer!! :D:D If there was an award for best installer, you'd win it Nail Geek! Anyway, so far so good. :)

[Snow]

Bit of a silly question.... can we upload our own article header images and if so, how?

[The Geek]

Thanks guys.

I am very proud of the installer. In fact, it has taken me almost as long to code that as to code the hack! I just felt that with so many file modifications - its would be a butt pain to manually maintain and install (especially as we have seen so many vB security updates as of late). Im glad it is working well for everyone so far.

Now on to the Q's:
Magic: Im on to the Preview bugs now. Should have fixed in the next couple hours.
I will also add the template chache for print thread
Shiva: Ill add an install page for the settings. Im not sure what your absolute server path will be for your setup. However in the next install, Ill have the file do a pretty darn good guess for you ;)
Yes, you are right about the forum ID's. Comma seperated. You will need to edit for synopsis/byline and header images

Snow - Your Article Header images go in gas/images. Replace the default, or dump several in there. When you click the Image button in a new article, it pops up a window with all images in the gas/images directory INCLULDING any images it finds in gas/images/forums/[CURRENT_FORUMID]

In other words, you can have a global gallery for users to choose from in gas/images/
And then have forum specific gallery images in gas/images/forum/[forumid]

Furthermore, users can upload their own by clicking the image button (as long as there are not usergroup settings preventing them in the admin page)

Hope that makes sense ;)

Thanks everyone

[gldtn]

Geek,

I'm still unable to change the image header after I set one. In other words, after I submit an article and choose the article image and want to change that image later I can no longer change it.. I choose the image that I want to change to and it selects it, but when I hit apply changes it does not change to the image I choose.

I have the latest beta version installed,but did not do a fully clean install.. All I did is replaced all the *.php's files from the mod and re-ran the install script, but the databases remains the same according to your installer that ignores database modifications if it's already there(I think you said thats what it does earlier in this thread). If your sure this was fixed let me know so I can drop the tables added to the database and do a fully clean install.

Thank You!

[The Geek]

Package updated.

This package rectifies the previewing of new or edited threads munching your synopsis and images.
I also adjusted a few phrases (mainly admin cp ones) to be more explanitory.
I also added the GAS_printthread template to the global template cache.

To upgrade from 1.04, overwrite all existing files with this latest package and reinstall the templates and phrases ONLY.
To apply the printthread fix, manually complete step 702.

Thanks

[The Geek]

Geek,

I'm still unable to change the image header after I set one. In other words, after I submit an article and choose the article image and want to change that image later I can no longer change it.. I choose the image that I want to change to and it selects it, but when I hit apply changes it does not change to the image I choose.

I have the latest beta version installed,but did not do a fully clean install.. All I did is replaced all the *.php's files from the mod and re-ran the install script, but the databases remains the same according to your installer that ignores database modifications if it's already there(I think you said thats what it does earlier in this thread). If your sure this was fixed let me know so I can drop the tables added to the database and do a fully clean install.

Thank You!
Hey gldtn.

I cant verify at this end - all seems to be working fine. The table wont have anything to do with it - I suspect a template or file modification.

I just changed a couple of things in the last package that may have actually fixed it now that I think about it. Upgrade and let me know so I can look into it more.

Thanks

[gldtn]

Hey gldtn.

I cant verify at this end - all seems to be working fine. The table wont have anything to do with it - I suspect a template or file modification.

I just changed a couple of things in the last package that may have actually fixed it now that I think about it. Upgrade and let me know so I can look into it more.

Thanks
Seems to be working up to a certain point. It now changes only if I upload a new image, but if I try to choose/select an image thats already on the server It does not change back. I also encountered a weird problem, when I uploaded http://www.fruitbody.org/forum/gas/images/default.jpg. It gave me this http://www.fruitbody.org/forum/gas/images/1/default2.jpg.

[Allan]

thank you for this hack, it is superb Geek :)

PS: I have a prob, I obtains a white page in "forumdisplay" (category)

[gldtn]

thank you for this hack, it is superb Geek :)

PS: I have a prob, I obtains a white page in "forumdisplay" (category)
can you provide a link so we can see? Also I would suggest to go manually thru the changes of forumdisplay.php and make sure everything is correct.

[The Geek]

Gldtn: Im looking into this right now.

Allan - Thanks! White pages are usually down to either a missing template or a file edit mistake. Is the forumdisplay blank regardless of the forumid - or just when you go to an 'article' forum?

[Allan]

@Gldtm: nop, I have to install it in localhost, but I will check the changes make in the forumdisplay.php

@The Geek: veiled, I have remakes the installation of the file manually "forumldisplay.php" is that does not have anything to change, I always obtains a white page, yes, I put a forumid well.

ps: tested with IE et Firefox (vBulletin3.0.7)

I have to install the version 1.04, which file php or other changed please ?

[The Geek]

Hey Allan - Im not sure if I follow you 100% - If you get a blank page regardless of the forum you are in - then check forumdisplay for the following code:

eval('print_output("' . fetch_template($GAS_setting['rt_template']) . '");');

above it try putting this:

echo("###$GAS_setting[rt_template]###");


And see what it spits out.

Gldtm- I simply cant reproduce your problem! Can anyone else verify? Can you at least PM me a step by step process of what you are doing to reproduce the problem and give me a test account to go try it myself?

[Allan]

which step please ?

because I have just remade manually the change of the file "forumdisplay.php", and of step 200 to 208, one does not find the 2 lines that you a post shows me higher :surprised:

[Allan]

afflicted, veiled, I have to find:

eval('print_output("' . fetch_template($GAS_setting['rt_template']) . '");');


and i'm add abode :

echo("###$GAS_setting[rt_template]###");


and it is similar, page blank :(

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

will be able you to say exactly which file one be to change in the version 1.50 please ?

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
(20:46)
veiled, I have just reinstalled vBulletin 3.0.7 locally and I have also to install your last version (1.50) and similar, white page ...

[shiva]

Well, have to say I'm quite pleased with this, once I got it working, though I am now finding my members are a bit confused about the difference between a byline, a Synopsis and the actual editor to post the main article. Before you comment on the intellegance level of my members, we are all older guys, who didn't have computers to play with when we were young, so we get confused easily.

To be honest, they hate change. So, I have a couple questions and some ideas, based on what I've seen so far:

1. What's the template used for the fields for posting, I think a line explaining what each field does would help people.
2. Is there a way to not have bylines? I've noticed it stretches the header image down on my forum with my themes
3. On the listing for the synopsis, it cuts off the amount of characters automatically, is there a way to change it?
4. OR... instead of having the synopsis, having the system instead display as a option the first 100 or whatever characters of the post instead. Like how VBA CMPS news pages do it, and would be a lot simplier especially if we are using that new vb3articles convertor of yours (Besides, I already had someone post and not bother with bylines and synopsis) Also, maybe a read more link at the forum board listing at the bottom of each synopsis would be nice.
5. I love the way it displays, but I noticed there's a space on the left menu at the top, and I think it would look a bit better if the header image for the article rating etc be in line with the first line in the article. Is there a way to set a different CSS code for the background color there? I would like to play a bit with that left menu, add some stuff, so which template would that be?

Really top notch though, and it's nice to have it so intergrated with the forum system, but these are just suggestions for future versions.

[uae]

So far so good, waiting for the final release.

**Clicked Install**

[The Geek]

Hey Shiva....

Excellent points.
1- its called GAS_article_options
2- Just comment the byline field out of the above template. Then no one can enter them.
3- The cut off point for synopsis is the field size (255). If enough people want - I suppose I can make it a blob field or you can do that yourself. Then edit GAS_article_options and change the length.
4- Ill have to look into that. I know what you mean though... the synopsis box was a specific requested feature that was seperate from the article. Let me mull it over.
5- Can you give me a screenie of what you mean?

Thanks guys!

[shiva]

First off:

My main article page (http://www.shivasite.com/forums/forumdisplay.php?f=56&styleid=40)

:)

will make the changes and see what happens, getting braver every day...

The space is marked (can't miss it) but is very apparent on one theme, the others are okay, weird, as all 3 themes are extremepixel themes.

The left menu should be a slightly different color, just to make it slightly more apparent, and set a nice color contrast. I believe that the main posting field would be set to alt1 in the CSS, the left menu would then be a different class, but it also occured to me that it would be theme specific as well. Is the code for that in GAS_article_options as well?

I think having the ability to just put out the first characters of a post is rather handy, to be honest, that's all I did with my articles so far, just copy and paste in the first few lines. I'm Lazy... :)

[The Geek]

First off:

My main article page (http://www.shivasite.com/forums/forumdisplay.php?f=56&styleid=40)

:)

will make the changes and see what happens, getting braver every day...

The space is marked (can't miss it) but is very apparent on one theme, the others are okay, weird, as all 3 themes are extremepixel themes.

The left menu should be a slightly different color, just to make it slightly more apparent, and set a nice color contrast. I believe that the main posting field would be set to alt1 in the CSS, the left menu would then be a different class, but it also occured to me that it would be theme specific as well. Is the code for that in GAS_article_options as well?

I think having the ability to just put out the first characters of a post is rather handy, to be honest, that's all I did with my articles so far, just copy and paste in the first few lines. I'm Lazy... :)
The space there is a result of the cellspacing./cellpadding setting.
That (and the class setting) can be changed in GAS_article_pb if you are eager :)

Your other wishes have been implimented and a new release will be out today so you can stop cutting and pasting :)

[The Geek]

BTW: I see you are using the 'first attachment thumbnail' as the article header.
When I browse, all I get are missing images in the headers. Is it working for you?

[The Geek]

Package updated to RC1.

This fixes all known remaining bugs

Added couple of new features:


Byline/synopsis can be turned on and off.
If synopsis is left blank (or turned off) then the threadbit in forumdisplay will show first x amount of characters for synopsis.
Synopsis character length is now controlled via admincp
Synopsis box now takes BBcode.

To update, replace all existing files with the ones in the latest package.
Run the installer. I would suggest a complete reinstall (use your gas/changes/backup files) to revert your file changes before upgrading.

Is there anything else? I would like to get this thing released!
Just out of curiosity - For those with GAS3 installed - is an upgrade script needed for file changes? Chances are it will only work on MOST file edits as the previous version was manual. Dont you think it would be easier to simply upgrade file changes by using fresh files?

Thanks all!

[Magic Spark]

...

When you click the Image button in a new article, it pops up a window with all images in the gas/images directory INCLULDING any images it finds in gas/images/forums/[CURRENT_FORUMID]

In other words, you can have a global gallery for users to choose from in gas/images/
And then have forum specific gallery images in gas/images/forum/[forumid]

...

Hi Geek,

found one little typo in actual RC1 Package:

Folder: /gas/images/forum
Should be: /gas/images/forums


One more: If I choose "yes" in gas-options "Use the legacy forumdisplay template? Choosing no will show the article header images". There's a table and colspan problem in the templates.

Thanks for working so hard on this hack...

I have already voted for the Hack of the month (https://vborg.vbsupport.ru/showthread.php?t=78141) *click-dee-click*

[The Geek]

You the man! (Or woman - so hard to tell now a-days!).

Amazing no one picked it up before. I just updated the package. For those already on RC-1... just rename your gas/images/forum folder to gas/images/forums

And thanks for voting!

[Magic Spark]

Geek,

is the template error cleaned out in the updated package. I've edit my previous post.

[The Geek]

cleaned out in the updated
er... you would have to refresh my memory. As far as I know - everything that has been brought up has been sorted.

[Magic Spark]

Okay, I check this - doing a fresh install on my local test-webserver. I come back then after checking.

[Magic Spark]

Geek,

the following Bugs found in the actual RC1 package:

1) The buttons "newarticle.gif" and "comment.gif" in images/buttons/ are not in the actual package.
2) If I choose "yes" in gas-option "Use the legacy forumdisplay template? Choosing no will show the article header images". Then there's a <table> and/or colspan problem in forumdisplay.php. (see attachment)

[The Geek]

Oops.

Where the heck did they get off to? Ill put them back in once I look into the legacy display issue (it also looks like your Last post and rating phrases are spelled wrong [haha - damn Im amusing])

Thanks Magic

[Magic Spark]

Hehehe, no, no - they're right.

One more point:
I have problems with attachments when your hack is installed.
Tested it with clean install of vb 3.0.7 - no problems.
If hack is installed the following problems occured:

I have an apache 2 webserver with gd2 running. In vb-Options configured to create thumbnails of images.

- I wrote an article, choose a header image and save.
- All is well so far.
- I edit my article and add an attachment to it (the normal vb attachments).
- Then sometimes it displays the right thumbnail, sometimes it displays nothing and sometimes the wrong thumbnail (or better wrong image) shows up.

It looks like the previous uploaded images are cached in some way and get mixed up, with this hack installed.

Can you please check this...

[The Geek]

Can you verify with the latest build? I havent had this problem. There have been thumbnail issues in earlier beta builds.

PS... am updating package as we speak to fix your legacy GAS_forumdisplay issue. Also found a hard coded phrase in the same line so I took that out.
I have also put the article and comment button images in.

To upgrade, replace all files and then run the Phrase and template install portion ONLY (or you can always pass... it really only fixes the display if using legacy forumdisplay)

Here it comes ;)

[Magic Spark]

Hmm,

now I get the following error:

Parse error: parse error, expecting `T_STRING' or `T_VARIABLE' or `T_NUM_STRING' in C:\...greyedout...\forumdisplay.php(851) : eval()'d code on line 66

After upgraded the templates and phrases, I did once again a fresh install - same error...

[Magic Spark]

I install your GAL-System to test it with the GAS.
Maybe I can find there some bugs too! ;)
Only to push some work over to The Geek. [now - I am amused.]

[The Geek]

Hmm,

now I get the following error:

Parse error: parse error, expecting `T_STRING' or `T_VARIABLE' or `T_NUM_STRING' in C:\...greyedout...\forumdisplay.php(851) : eval()'d code on line 66

After upgraded the templates and phrases, I did once again a fresh install - same error...
Be amused all you want - I wont rest until you cant find any ;)

Just updated package to fix typo in inc_template.
To update from rc1.01, just replace old gas/install/inc_templates.php with new one and run the installer - just install the templates though.
Or, you can just edit your GAS_forumdisplay template, and on line 66 replace $vbphrase['GAS_order_by'] with $vbphrase[GAS_order_by]

Thanks :)

[Magic Spark]

Man (or maybe woman), you're fast.

Test the thumbnail issue with attachments once again with actual release, to be sure there's no problem.

Then I check the implementation of GAL.

Come back then...

[The Geek]

Im like greased lightening ;)

However - I can not reproduce the error your talking about. The only annoying thing for me is that my article header image popup isnt wide enough (going off to sort it now)

As far as Im concerned - this things about ready to go live (unless you can find any other reason not to).

BTW: I still havent gotten any feedback on upgrading from Gas3. Maybe ill pop over to that thread and find out.

[Magic Spark]

Geek,

the following bugs were found:

1) One more colspan needed if using legacy display

In Template "GAS_forumdisplay" (row 66) search for:

colspan="4"

Replace with:

colspan="5"

2) Article Image broken when edit article. It seems, this only occurs, if not explicity set an image by yourself when create an article.

3) GAL-Implementation Error (tested with actual GAL-Release "gal_206.zip"):

Following error occurs only after submit new article and keywords for GAL are inserted:

Warning: gas_add_article(functions_gal.php): failed to open stream: No such file or directory in \includes\functions_geekarticles.php on line 264
Fatal error: gas_add_article(): Failed opening required 'functions_gal.php' (include_path='.;c:\php4\pear') in C:\Apache2\htdocs\test\includes\functions_geekarti cles.php on line 264

By the way: Is the attachment-table edit (description) for later updates or new releases?

[The Geek]

Hey Magic - squashed them and updated package.

1) Done
2) Done
3) Done

The attachment description is for later implimentation and to support those coming over from vb3articles (man you really are combing through the code arent you?!?)

To upgrade, replace all files and reinstall templates and phrases (found another hardcoded phrase that I quickly fixed).
The GAL error was because I forgot to include the include in the package. Its there now.

To be honest, you guys most likely dont need to upgrade, but I would download the latest package and replace files so you fix issue #2 (though its rare to occur).

Next? :)

[Magic Spark]

Hey Geek,

thanks for fixing.

I try to find out where my problems with the attachments (thumbnails) come from. Without luck for now.

I think you should release it. ;)

If you need an beta-tester for further project, just call me.
You're an outstanding coder... thanks again.

[Snow]

BTW: I still havent gotten any feedback on upgradingfrom Gas3. Maybe ill pop over to that thread and find out.Theinstall went great on my test forum as I remembered to completelyuninstall the previous version. I forgot to do so for my liveforum and things went horribly wrong. Maybe if its feasible, youcould include a 'detect previous version' in the installer with theoption/reminder to uninstall. If it was just a minor issue of thehack not working because someone forgot to uninstall it's not so bad,but it made my forum inaccessible (Thank God for backups!). Ohand a little note somewhere to mention that the changes folder shouldbe emptied if you try to re-install after an unsuccesful install :o:o

[The Geek]

Good suggestions Snow.

I am actually just finishing up the upgrader. Got tired of waiting for feedback so I felt it was better to be safer than sorrier!

Ill also put in the checks to advise.

[shiva]

BTW: I see you are using the 'first attachment thumbnail' as the article header.
When I browse, all I get are missing images in the headers. Is it working for you?
If that's my site, it works fine as a guest, displays on firefox. May be blasted IE, I use the attachment feature for the images, but as a hack, because i have a lot of files, and want them member only.
VB does have problems with that though, you know of a solution? how about a field just for loading in a header image
Playing around with the permissions anyway, see if that works.

[gldtn]

Geek,

A few things I've noticed...

1.) In forumdisplay where it says "Order By | Title | ..", "| Title |" took place of "Order By", "Order By" is gone and it left with a blank "| |". See Attachment.

2.) "Read More" on Synopsis line IMO should be spaced out in case synopsis undergo 300 chars. See attachment.

3.) "By Line" and "Synopsis" input boxes still shows when marked as no under Geek Articles settings.

4.) On "GAS_image_upload" Template.. I would suggest to to set the popup window to open to this size;
window.resizeTo(($windowwidth + 250),($windowheight + 341));

5.) I'm still having problems with editing article header image from both global and specific forums.

6.) Other than that it seems great :P

[The Geek]

Shiva - nope. Im stumped. Ill check again later with FF and IE.

Gldtn - thanks for those. Order by was replaced with a new phrase. Try installing the phrases with the latest package.
Ill look into the other issues. There is still 1 or 2 more minor things to tidy up before the release.

The good news is that I now have an upgrade script for users of 3.0x. That will revert all the files before changing them. I think she shall be set for a release date of tomorrow.

[gldtn]

Geek,

Could it be that you got the phrases confused? I seen in forumdisplay template $vbphrase[GAS_order_by] | $vbphrase[GAS_title] | $vbphrase[geek_articles_posted_by] | $vbphrase[last_post] | $vbphrase[geek_articles_comment] | $vbphrase[geek_article_reads] | $vbphrase[rating]

But I can not find "GAS_title" and "GAS_order_by" says Title.

Also check this line:
<a href="$sorturl&amp;order=desc&amp;sort=views">$vbphrase[geek_article_reads]</a> $sortarrow[views]&nbsp;

Note the extra &nbsp;

[kevinnguyen]

After I edit a post, the user's avatar is replaced by the article image even though I set No to Use first attachment thumbnail as avatar

How to fix that?

Im running the lastest version btw

[PennylessZ28]

Don't work, how can I unistall all this garabge?

[gldtn]

Don't work, how can I unistall all this garabge?

Maybe if you quit the trash talking we can give you a hand.

Note the the ppl that write these mods are under no obligation to make codes or give you any type of support at all. Also it's most likely that you did not read the READMEs and made a note of it that this is a BETA version of this mod, so you installed it at your own risk.

Feel lucky that this mod has no potential to mess up your board cause your whole community could've been garbage by now.

Please have a little bit of courtersy!

[spence2]

Don't work, how can I unistall all this garabge?"Unistall this garabge?"

Wellba...I duhno, butt u mite wanna git u-self sum black cofee fore u giveitago.

:rolleyes:

[The Geek]

If you would have actually read the README/Install script as it was installing - you would have found that:
A- There is no current uninstaller for this BETA hack.
B- You should only use it on a test site
C- that backups of your original files may be found in gas/changes/backup

The other changes will not affect anything else on your board - it will just leave you with some extra templates and phrases that you can uninstall when this package goes live.

[The Geek]

After I edit a post, the user's avatar is replaced by the article image even though I set No to Use first attachment thumbnail as avatar

How to fix that?

Im running the lastest version btw
Hey Kevin - So you are not using first attachment as image... but when you edit an article, you get the default article image? If I understand right - that is by design. If you do not use the first thumbnail (which I dont recommend doing) then it is set to use the image system (gallery or uploaded) unless you turn off the 'use article header image'. With both of those options turned off - it should use the posters avatar.

HTH's

[The Geek]

Thanks gldtn - will sort your points out today for a final release.

[gldtn]

Hey Kevin - So you are not using first attachment as image... but when you edit an article, you get the default article image? If I understand right - that is by design. If you do not use the first thumbnail (which I dont recommend doing) then it is set to use the image system (gallery or uploaded) unless you turn off the 'use article header image'. With both of those options turned off - it should use the posters avatar.

HTH's


When I upgraded to the latest version I noticed that the header image while viewing the article became the poster avatar. When I edit the article the avatar while viewing the article changed to the header image.

I hope I make since.

* gldtn drinks coffee

[Snow]

When I upgraded to the latest version I noticed thattheheader image while viewing the article became the poster avatar.When Iedit the article the avatar while viewing the article changed totheheader image.

I hope I make since.

* gldtn drinks coffeeSame here. Old articles havethe user's avatar and need editing to update to the header image, but Iassumed that's because of the old data that was stored in thedatabase. Maybe there's a query we could run to update all oldarticles to show a header image on "view article" instead of themember's avatar?

[The Geek]

Im kind of confused here. I have fixed all other bugs that you guys have brought up since the latest build and I am just working on finishing up the installer (damn its huge).

I may have fixed this as there was an issue with default images - however I want to be sure. Is there anyway you guys can post me a walkthough to reproduce on my end?

[Snow]

Im kind of confused here. I have fixed all otherbugsthat you guys have brought up since the latest build and I amjustworking on finishing up the installer (damn its huge).

I may have fixed this as there was an issue with default images-however I want to be sure. Is there anyway you guys can post meawalkthough to reproduce on my end?Umm, I'm not sure which version I ended up installing on my live forum, but an example of what I mean is in this article http://www.aboho.com/forum/thread2128.html Notice that the member's avatar is showing at the moment (it doesn't in the forumdisplay (http://www.aboho.com/forum/tutorials-and-articles.html),that'sOK). To update the header image to one of the actual header images, I shall have to go and edit the article (which gives no image initially)then reselect an image from the popup (am I making sense?) and save.

[The Geek]

Your not on the latest release which may be one of the problems (the latest build auto creates your synopsis if its blank).

I think this has been fixed in the current release (if not I am almost positive its in the next one that I should release here within the hour).

[Snow]

Your not on the latest release which may be one of the problems (the latest build auto creates your synopsis if its blank).

I think this has been fixed in the current release (if not I am almost positive its in the next one that I should release here within the hour).
To wait or not to wait.... Ohhhhh I can wait an hour or two. I downloaded AN updated release yesterday at some point but when the install went wrong with my live forum I kinda lost track of which release was which as I wasn't following the thread. :o

[The Geek]

Should be able to revert with your backup files ;)

The installer inst 100% done (finished the install and upgrade options but not the uninstall yet) guess I can post it here in the next 20 minutes or so - then I can finsih the uninstall and put my finishing touches on it (and the readme) while you are testing.

Check back soon

[Snow]

Should be able to revert with your backup files ;)

The installer inst 100% done (finished the install and upgrade options but not the uninstall yet) guess I can post it here in the next 20 minutes or so - then I can finsih the uninstall and put my finishing touches on it (and the readme) while you are testing.

Check back soon
Excellent! Thanks :D

[The Geek]

Package updated to RC2

This should really be it. Here is what I have left on my TODO list:

Finish uninstaller
Create proper README
Add my 'witty' (if I do say so myself) touches to installer ;)

If anyone could start verifying this latest package - I would appreciate it. ESPECIALLY if they have GAS 3.0x installed - I would like verification on the upgrade process.

Thanks!

[gldtn]

I installed it over the rc1 and got no problem, however there are some issues that I'm not sure if it's because of the old beta I have installed. So I'm in the process of installing it on a different board, a clean install and I just got this message while going thru Installing Settings ...

Here is the error:
Warning: Invalid argument supplied for foreach() in /gas/install/inc_functions.php on line 91

Everything else seems 100% on the new board that I installed this mod.. I'll have to do a clean install on the main board cause it's some how keeping all the old issues in there.

[The Geek]

sounds like you dont have the latest inc_functions

Can you verify by opening your gas/install/inc_functions.php and serach for:
global $datastore,$version;

That was causing the error you mentioned.

[gldtn]

sounds like you dont have the latest inc_functions

Can you verify by opening your gas/install/inc_functions.php and serach for:
global $datastore,$version;

That was causing the error you mentioned.
Yes, it's there, shal I remove it? This came with the RC2 version..

[The Geek]

nope... should be there. ahhh.... I think I know...

That bit grabs any existing $gas_settings you have... you said this was on a fresh install?
I think I just need to put a test wrapper around it. You can ignore the error.

How is the rest?

[gldtn]

nope... should be there. ahhh.... I think I know...

That bit grabs any existing $gas_settings you have... you said this was on a fresh install?
I think I just need to put a test wrapper around it. You can ignore the error.

How is the rest?

* gldtn ignores it!

Yes, it's a fresh install. Everything else seems great, have'nt done any major checking, but the article images issues I was having is gone on the fresh install.. I'll wait for the uninstaller to see if I can verify that everything is good on my original board I was testing with. Any idea when the uninstaller is being released?

[The Geek]

How about now? (I added checking to prevent the error as well)

New package includes uninstall

[gldtn]

Trying it out.. I used the uninstaller and it did great...

but I got another forreach error once re-installing it;

This time on a different file.
Warning: Invalid argument supplied for foreach() in /admincp/gas3_install.php on line 593

[The Geek]

Squashed foreach error. Updated package.

[Snow]

Squashed foreach error. Updated package.
I got a slight problem Nail Geek :( Go here http://www.aboho.com/forum/forumdisplay.php?f=57 and scroll right to the bottom where it says "The XHTML Chronicles". :(

[gldtn]

Squashed foreach error. Updated package.
Will check when I get home(im at work now), and I'm having problems with my ftp server, so I got wait till they fix it.

[gldtn]

I got a slight problem Nail Geek :( Go here http://www.aboho.com/forum/forumdisplay.php?f=57 and scroll right to the bottom where it says "The XHTML Chronicles". :(
have a test login?

[The Geek]

I got a slight problem Nail Geek :( Go here http://www.aboho.com/forum/forumdisplay.php?f=57 and scroll right to the bottom where it says "The XHTML Chronicles". :(
need a username/password :(

[Snow]

need a username/password :(
Ooops sorry.... I PMd you the details. :o

[The Geek]

hmmm... The quote block is messing it up.

Ill have to put on my thinking cap regarding that one... All you have to do is put some type of synopsis in and it will use that instead of your quote block.
Im not going to stress to much about it right now as I think that there is an easy workaround and it would be a very rare case that it does occur.

What do you think?

Let me know.

[Snow]

hmmm... The quote block is messing it up.

Ill have to put on my thinking cap regarding that one... All you have to do is put some type of synopsis in and it will use that instead of your quote block.
Im not going to stress to much about it right now as I think that there is an easy workaround and it would be a very rare case that it does occur.

What do you think?

Let me know.
Thank you... fixed it for the moment. Agreed, it's not going to happen all the time, but would this be a problem with the ["code] tag as well?

[The Geek]

possibly.

I guess I could always turn off the auto synopsis.
If you think this would be a problem I would either always include a synopsis, use the forumdisplay legacy option, or limit the wordcount to character count to where it is manageable (I doubt anyone would start an article with a long codeblock).

Like I said - ill try to figure out how to work around it - but it will be a pain. Ill have to check the spliced text for div and td's

[Snow]

possibly.

I guess I could always turn off the auto synopsis.
If you think this would be a problem I would either always include a synopsis, use the forumdisplay legacy option, or limit the wordcount to character count to where it is manageable (I doubt anyone would start an article with a long codeblock).

Like I said - ill try to figure out how to work around it - but it will be a pain. Ill have to check the spliced text for div and td's
I doubt anyone would start an article with a code aswell, I guess it could wait for a later version. (It's not a security risk is it?)

OK you wanted us to be picky...... :nervous: you remember that issue with the avatars showing instead of the header image?.... it's still doing it. :nervous: It doesn't bother me, but I thought I'd mention it.

The install went OK for me, but I didn't use upgrade, I did a clean install. Only one point, although it didn't seem to affect the install, I received this error on admincp/gas3_install.php?do=templatemodinstall&h=1&m=1 page

Warning: Invalid argument supplied for foreach() in /admincp/gas3_install.php on line 593

[The Geek]

I doubt anyone would start an article with a code aswell, I guess it could wait for a later version. (It's not a security risk is it?)

OK you wanted us to be picky...... :nervous: you remember that issue with the avatars showing instead of the header image?.... it's still doing it. :nervous: It doesn't bother me, but I thought I'd mention it.

The install went OK for me, but I didn't use upgrade, I did a clean install. Only one point, although it didn't seem to affect the install, I received this error on admincp/gas3_install.php?do=templatemodinstall&h=1&m=1 page

Warning: Invalid argument supplied for foreach() in /admincp/gas3_install.php on line 593
which package? I think I just fixed that.

Can you list steps to reproduce the image problem?

[Snow]

which package? I think I just fixed that.

Can you list steps to reproduce the image problem?
The zip file is gas3-5_rc2.01 (well I downloaded it and by the time I finished installing it you'd released the next package :o )

To reproduce the image problem? Well it's not something that is occuring with new articles if you know what I mean. It's with the previous articles from your GAS 3.0x version. I had selected in that previous version that the user's avatar be used and not the first image or whatever the other option was. It just seems that it hasn't updated in this new version and it's still showing the users avatar until I edit and save the article in order to update it.

When I say I did a clean install I didn't remove any template edits or mess with the database, I only used un-hacked copies of the actual files. Could it be this has caused the problem? :o

[The Geek]

Snow - more than likely. There was an old bug that stored the default image in the table - but that was fixed a few days ago. Maybe that was wigging it out.



Closing this thread down as its now a final release over at -> https://vborg.vbsupport.ru/showthread.php?t=75916Thanks for everyones help. Much appreciated.