Kill 1 Query In BBCode Manager (ACP)

[Zero Tolerance]

While looking through bbcode.php in admincp/, i noticed that a global query was executed on all of it's pages, however only 2 actions need this query to be executed, so its a useless query on other pages within the BBCode Manager.

In admincp/bbcode.php
Find:
$bbcodes = $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " . TABLE_PREFIX . "bbcode");
$searcharray = array();
$replacementarray = array();
$doubleRegex = "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
$singleRegex = "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

while ($bbcode = $DB_site->fetch_array($bbcodes))
{
if ($bbcode['twoparams'])
{
$regex = sprintf($doubleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
}
else
{
$regex = sprintf($singleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
}
$searcharray[] = $regex;
$replacementarray[] = $bbcode['bbcodereplacement'];
}

Replace It With:
if($_REQUEST['do'] == "test" || $_REQUEST['do'] == "modify"){

$bbcodes = $DB_site->query("SELECT bbcodetag, bbcodereplacement, twoparams FROM " . TABLE_PREFIX . "bbcode");
$searcharray = array();
$replacementarray = array();
$doubleRegex = "/(\[)(%s)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/%s\])/siU";
$singleRegex = "/(\[)(%s)(])(.*)(\[\/%s\])/siU";

while ($bbcode = $DB_site->fetch_array($bbcodes))
{
if ($bbcode['twoparams'])
{
$regex = sprintf($doubleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
}
else
{
$regex = sprintf($singleRegex, $bbcode['bbcodetag'], $bbcode['bbcodetag']);
}
$searcharray[] = $regex;
$replacementarray[] = $bbcode['bbcodereplacement'];
}
}

I know it's not much, but every little helps!

- Zero Tolerance

[nexialys]

hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!

[Zero Tolerance]

Hey, 1 thing at a time, here: http://www.vbulletin.com/forum/bugs.php?do=view&bugid=3864

And yes a mini mod, however its result is optomizing the forum, so i put it in here instead :p

- Zero Tolerance

[Zachery]

at least its not being run on ever non acp page :)

[ericgtr]

hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!
Geez dude, you are always the first to post and discredit mods in any way possible, nothing better to do?

Zero, thanks for posting this up, every little bit helps streamline the process. :)

[Bad Bunny]

hum.. a Mini Hack... why not release this in the Bug Reports at vb.com ?!!!
Yeah, it does seem like you're the unofficial homeland security of v.org. Nex.

Anyway! Keen eye, and thanks for this.

[Zero Tolerance]

Heh, well i got an expected reply from the vb team:

Not a bug, the code isn't executed enough to justify the change.

Disapointing really, justification of the change shouldn't be based on how much it is executed, executing once is more than enough, personally if i saw a minor area where i could improve the script, i go for it, no matter how small it is. Meh =/

- Zero Tolerance

[eva01_]

wow that is just a bunch of crap from them, you would think that if they find something that fixes it ever so slightly they would do it

vbulletin seems to me like micro++++

now then we just need something that is like Apple where they care ;)

[Polo]

personally if i saw a minor area where i could improve the script, i go for it, no matter how small it is. Meh =/

- Zero Tolerance
I'm with you on this one Zero Tolerance..... :ermm:

[yoyoyoyo]

I agree- it is total crap for them to give you that reply- what is the point of NOT fixing it?

[Corriewf]

Yeah, I dont run my air conditioning much in my car but when it needs to be charged I am filling that chit up.

[eva01_]

maybe we will have to create our own forum code that whenever there is a problem it gets fixed no matter how small. :P

either way, great catch zero ^^

[Paul M]

Given some of the very minor bugs they have fixed I find that reply very strange.

[Corriewf]

Yeah, given that the excuse for updating vb versions everyday is discovering problems and fixing them right away..................................

[neocorteqz]

And such a simple fix too. as I see, it's only two lines.

When i upgrade I'll be sure to apply this.

[Zero Tolerance]

And such a simple fix too. as I see, it's only two lines.

When i upgrade I'll be sure to apply this.
Yeah, the code is just wrapped in an if statement, easy as pie :)

- Zero Tolerance

[neocorteqz]

Yeah, the code is just wrapped in an if statement, easy as pie :)

- Zero Tolerance

You would figure it's such a quick modification they would consider it.

[diettalk]

Isn't reducing a query a good thing... especially on busy boards?

[Oblivion Knight]

Isn't reducing a query a good thing... especially on busy boards?It doesn't really matter in the Admin CP so much.. Still if a query can be killed where it isn't needed, that can only be a good thing and I don't see why Jelsoft aren't taking this into consideration.

[neocorteqz]

It doesn't really matter in the Admin CP somuch.. Still if a query can be killed where it isn't needed, that canonly be a good thing and I don't see why Jelsoft aren't taking thisinto consideration.
Now if my admin panel would load faster, I'd be a happy camper. :D

I agree with you. For the query minded. This would make us happy.

[Polo]

Still if a query can be killed where it isn't needed, that can only be a good thing and I don't see why Jelsoft aren't taking this into consideration.I totally with you Oblivion Knight

[Oblivion Knight]

I have a feeling this change is the cause of an error when removing custom BB Codes..
Warning: Empty regular expression in /admincp/bbcode.php on line 300


[EDIT]
Yup, I removed the if statement and the error disappeared when removing another custom BB Code.

[Yorixz]

Thanks; all improvements in speed are welcome ;)