PDA

View Full Version : [Pending] Great Hack. I have a few notes/suggestions


DRJ
02-28-2005, 09:29 AM
First of all, great hack. I just installed it and it was very easy. The installer was excellent.

For some reason for me the image folders were not made. I was gettingsome errors so I checked and there were no folders. Added then and thenthere were no more problems.

You have 3 uncached templates on articles.php

editor_smilie_wysiwyg
editor_smiliebox_category
editor_smiliebox_row

The images that are shown when you view a category were not lining upfor me (in IE and FireFox). They were close, but some of the imageswere slightly offset even though they were all 80x80.

So I added this and it fixed the problem:

vbArticles_browsecategory

<if condition="$vbart_options[usecaticon]"><td class="alt1" align="center" width="25%">$caticonimgc</td></if>

vbArticles_subcatbits

<if condition="$vbart_options[usecaticon]"><td class="alt1" align="center" width="25%">$subcaticonimg</td></if>

And I got my first two articles up already and they are looking great. :)

Take Care

cinq
02-28-2005, 12:10 PM
Any errors (mkdir errors) when you try to create an article ?
If not, your paths should be correct and the article images folders created automatically.

Where do you see the uncached templates ? I presume you are in debug mode, but on which page of the articles section do you see it ?

Category images in the browse category part ?

DRJ
02-28-2005, 12:38 PM
There were no errors that I saw, but the the folders were not made.

When I was on articles.php?action=submitarticle I saw the uncached templates. I have a hack I got from here that shows the number of queries in the footer, so that was how I noticed.

See here http://www.vbaexpress.com/forum/articles.php?action=viewcat&catid=1

The images for the categories were not lined up although they were centered. I did a copy paste into front page and the table or tds were not all the same size. So the pics were centered, but the box was smaller/bigger than the others.

I thought it was just a FireFox thing, but the same thing happened in IE6. When I set the width then there was no more problem.

One more thing I just noticed now that I got some entries. On one of the Articles it was being stretched way off to the right. I determined that it was the web page addy being displayed for the user info section on the right (with their avatar, post count etc). It was not wrapping.

I commented out that code since I didnt want it posted anyways, but just an FYI that if someone has a long url for a home page it could mess up the look of any of their Articles.

cinq
03-01-2005, 11:12 PM
Right, will check up on the uncached templates.

The category template changes you made, I will include into the next revision. Thanks for bringing it up :)

As for the home page thingy, I will think of something for that too :)

DRJ
03-02-2005, 01:09 AM
Glad to help :)

I look forward to the next version with even more features :)