Log in

View Full Version : Quick Reply Multiquote


Xenon
01-02-2005, 10:00 PM
This Modification allows users to highlight text in user's posts and after clicking the QR-icon it will get entered into the qr-form surrounded by quote tags When no text is highlighted, the QR icon will work as it did before.

You can see a demo version on vb.org already :)

Thx to EvilS1 for the IE-JS code :)

Notice: the .js Files are cached by most browsers, so if you installed the hack, and don't notice a change, do a hard refresh to download the newest version from the server.

Notice: The hack is designed to work with normal text boxes, right now the wysiwyg editor is not supported.

Princeton
01-03-2005, 02:07 PM
nice little addon ...

a few things that could be improved.... (here on vb.org)
1. there is no quick reply button on firstpostid
2. anchor has been removed or it is not working as it should (firefox) ... FYI: the default quick reply button takes you to the quick reply

SnowBot
01-03-2005, 02:11 PM
nice little addon ...

nice one :)

floleb7
01-03-2005, 03:44 PM
very nice i'll install very soon

only limitation : it doesn't keep smily in quote

floleb7
01-03-2005, 03:52 PM
another one : url are keeping as url but as txt

Erwin
01-03-2005, 08:21 PM
This way too cool. :) Nice Stefan.

HiDeo
01-03-2005, 09:04 PM
Thanks

/me clicks install

Xenon
01-03-2005, 09:11 PM
@floleb: i know, but that's not so easy to change as it's working on the output and not on the post's search (JS hack, not php hack) so i think that will stay as it is

2. anchor has been removed or it is not working as it should (firefox) ... FYI: the default quick reply button takes you to the quick reply
i think i don't get you right now?

nexialys
01-03-2005, 09:45 PM
princeton is relating to the fact that the original feature focus the cluster to the quick reply box, that's the goal of the feature...

your hack (Xenon) is not shooting us to the quickreply box... (htmlwindow.focus()...)

Xenon
01-03-2005, 10:06 PM
well, as i said in site feedback that's by design

if you want to quote more than one line in a post it's annoying to alway scroll back

it's just shooting directly to the qr box if no text is highlighted :)

heynurse
01-04-2005, 07:12 AM
Great Hack! Although, I cannot seem to be able to get it to work, I have adsense code displaying above the quick reply box, I wonder if that has something to do with it?

All that happens when I highlight the text in a post, and click the quickreply button, is it scolls down to the quick reply box, but does nothing is entered into the Quick reply box. any ideas?

deathemperor
01-04-2005, 08:37 AM
this is super cool, I was always thinking of this and now it comes true.

/me clicks installed

Princeton
01-04-2005, 12:02 PM
It's always good to give some form of feedback.
With short threads, there's no problem. The user will "see" the quotes in the quickreply but with long threads there is nothing telling me that everything is working as it should.

Again, with long threads and as a user of site, I like to be directed to the quick reply on onclick rather than having to scroll. However, as a STAFF, I see how it would be beneficial to NOT direct user to quick reply on onclick.

If I had to choose, I would opt to make things easier for the user.

Great hack!!

Boofo
01-04-2005, 12:26 PM
Nice one, Stefan! ;)

EDIT: For some reason this isn't working for me. I am still using RC3. Would that have anything to do with it? When I highlight text and hit the buitton, the text does not get entered into the Quick Reply Box. :(

Lethal
01-04-2005, 12:38 PM
OMG sweet, thank you!!!!!

Lethal
01-04-2005, 12:43 PM
whatever happened to the multiple quote hack from 2.x? the one where you can click on a check box for each post you want to quote. wouldn't that be easy to do also?

Lethal
01-04-2005, 01:44 PM
oh I did find one but I think I might like xenons better ;)

https://vborg.vbsupport.ru/showthread.php?t=59702&highlight=multi-quote

sblum
01-04-2005, 04:02 PM
Wow, this is absolutely awesome. Thank you.

SnowBot
01-04-2005, 04:36 PM
Nice one, Stefan! ;)

EDIT: For some reason this isn't working for me. I am still using RC3. Would that have anything to do with it? When I highlight text and hit the buitton, the text does not get entered into the Quick Reply Box. :(
Running 3.0.4 and same problem for me also.

Erwin
01-04-2005, 08:27 PM
Boofo, it's time to upgrade to 3.0.4. :) Or at least, use the 3.0.4 init.php to plug a potential security hole.

I'll be installing this one at my own forums soon.

Boofo
01-04-2005, 11:23 PM
Boofo, it's time to upgrade to 3.0.4. :) Or at least, use the 3.0.4 init.php to plug a potential security hole.

I'll be installing this one at my own forums soon.
I know, I know. But RC3 is running so well for me I hate to mess anything up. LOL

I do all the sercurity updates on every upgrade so I am covered on that part of it anyways. ;)

Xenon
01-04-2005, 11:37 PM
@heynurse: hmm, no idea, do you have 3.0.3 or a different version?
also did you do a total refresh, as sometimes the browser holds an old cache of the .js files

that goes to you bob as well ;)

@princeton: yeah, you have a point. that's why i left the part, when nothing is selected then the old jump will apply on click :)

Xenon
01-04-2005, 11:38 PM
@SnowBot: look at my post above, it may just be an old cache, i think i should update the first post ;)

sabret00the
01-05-2005, 09:51 AM
well this is installed, works a treat in FF (standard editor) just not in IE (with WYSIWYG not checked other editors) :(

but thank you stefan, i really appreciate this release :)

moethelawn
01-05-2005, 04:59 PM
Running 3.0.4 and it works like a charm :)

Thanks Xenon

shadiguy1
01-06-2005, 02:20 AM
3.0.3 and not working for me either.

Boofo
01-06-2005, 03:06 AM
I got it working on my site. It turns out that it doesn't work with the WYSIWYG editor there for some reason. It works as it is supposed to with the others editors. ;)

Xenon
01-06-2005, 12:05 PM
yep, it's designed to work with the normal editors (did i say that i hate wysiwyg ^^)

i may look at the wysiwyg part maybe :)

Boofo
01-06-2005, 01:00 PM
yep, it's designed to work with the normal editors (did i say that i hate wysiwyg ^^)

i may look at the wysiwyg part maybe :)That would be great! ;)

You might want to add that it only works with the normal editors in your first post so others will know what to do if it doesn't seem to work at first for them. ;)

Xenon
01-06-2005, 01:07 PM
you're right bob

sabret00the
01-06-2005, 01:39 PM
yep, it's designed to work with the normal editors (did i say that i hate wysiwyg ^^)

i may look at the wysiwyg part maybe :) that's my problem fixed then lol

Erwin
01-15-2005, 05:13 AM
yep, it's designed to work with the normal editors (did i say that i hate wysiwyg ^^)

i may look at the wysiwyg part maybe :)
If you can get it to work with WYSIWYG, that would be great. ;)

heynurse
01-15-2005, 06:06 AM
If you can get it to work with WYSIWYG, that would be great. ;) Yes, that would be great ;) Thanks for your hack regardless, you always put out great stuff :)

yoyoyoyo
01-15-2005, 06:21 AM
I agree... excellent hack, and great work!

catocom2
01-18-2005, 12:00 AM
do you have to install the regular mutiquote by Chroder First?

Erwin
01-18-2005, 12:48 AM
do you have to install the regular mutiquote by Chroder First?
No. Different hack.

catocom2
01-18-2005, 12:53 AM
hmm, well I can't seem to get it to do anything with 3.0.5...?
I must be missing something

catocom2
01-18-2005, 01:04 AM
ah, I found "my" problem.
I'm using postbit_legacy, so I had to put it in there also.

Works great, Thanks!

Xenon
01-18-2005, 04:27 PM
glad you like it :)

heynurse
01-18-2005, 05:44 PM
ah, I found "my" problem.
I'm using postbit_legacy, so I had to put it in there also.

Works great, Thanks!DOH! Thanks for posting your solution, that was my problem as well :) I forgot that I was using the postbit_legacy!

Xenon, Thanks again for this hack, very clever and simple to install :)

Guy G
01-28-2005, 06:05 PM
Its a treat.

fridayweb
01-31-2005, 04:19 PM
I've got it working on 3.0.5, but it seems to be hit and miss? Some posts I can highlight and hit the quick reply button and it does exactly what it should, others it quotes it and takes me to the full reply page. I'm not exactly sure what could be doing that...

I'll give it some time and see if it works out its kinks! :)

Xenon
01-31-2005, 07:33 PM
hmm, could be a buggy browser cache, sounds like it doesn't fully load the js file sometimes...

as you can see here on vb.org it works good normally

Lottis
02-02-2005, 06:50 AM
It wont work any place with my place. : (

Deviant++
02-02-2005, 07:47 AM
I've got it working on 3.0.5, but it seems to be hit and miss? Some posts I can highlight and hit the quick reply button and it does exactly what it should, others it quotes it and takes me to the full reply page. I'm not exactly sure what could be doing that...

I'll give it some time and see if it works out its kinks! :)
test

Deviant++
02-02-2005, 07:49 AM
hmm, is there anyway u can modify the hack 'multiquote' to work with 3.0.6 please cause thats what more people could use and the creator isn't really giving too much support :(

Xenon
02-02-2005, 03:18 PM
i don't manipulate other peoples hack, sorry

@Lottis: have you uploded everytzhing correctly?
have you done the refresh of the browsercache?

Deviant++
02-02-2005, 04:46 PM
any possibility of making a new one in that way.. cause ipb migrators find the mod useful :(

it dosn't work on anything 3.0.5 +

Xenon
02-02-2005, 06:42 PM
you have to ask in that support thread

maybe someone else can post a fix for that hack.

I don't have the time to work on other hacks, i don't need myself.

Nick0r
02-04-2005, 05:43 AM
woah amazing hack, it's so handy when you want to address lots of people in 1 post!

catocom2
02-04-2005, 09:40 AM
any possibility of making a new one in that way.. cause ipb migrators find the mod useful :(

it dosn't work on anything 3.0.5 +

I have both installed on 3.0.6 and they work fine... :ermm: ??

Deviant++
02-05-2005, 03:20 AM
didn't work on lots of other people's stuff

Xenon
02-05-2005, 10:42 AM
please don't talk in this thread about another hack.

if another hack has bugs, please discuss the in the supportthread of that specific hack, thx.

EvilHawk
02-07-2005, 06:08 AM
Works fine on 3.0.6 !

M1th
02-07-2005, 11:19 AM
Xenon, I'm not sure whether it's a firefox bug or not, but the hack doesnt seem to work on the latest nighly build. :)

Anyone else having this problem?

Nick0r
02-07-2005, 11:33 AM
I noticed that m1th, the hack was working one day but not the next ;)

Hoffi
02-07-2005, 11:58 AM
nice little addon ...
Great Addon! Thanks!

Xenon
02-07-2005, 03:06 PM
@Mith: hmm, seems like a bug in the newest build then, as i don't have a problem with FireFox' official release

auveeb
02-15-2005, 07:41 PM
nvm.....

S.Shady
02-25-2005, 02:05 AM
@Mith: hmm, seems like a bug in the newest build then, as i don't have a problem with FireFox' official release

scratch that.

:ermm: any news on the wysiwyg upgrade ?

S.Shady
02-25-2005, 07:00 AM
you ,may want to fix this too !!Style: Smooth Blue

nvm.....
auveeb is offline Report Bad Post Reply With Quote Quick reply to this message
auveeb
View Public Profile
Send a private message to auveeb
Find More Posts by auveeb
Add auveeb to Your Buddy List
Old Yesterday, 23:05 #60
S.Shady
Member

S.Shady's Avatar

Join Date: Apr 2003
Posts: 177

Real name: Mike
Location: Cleveland, Ohio

Style: Smooth Blue

Quote:
Originally Posted by Xenon
@Mith: hmm, seems like a bug in the newest build then, as i don't have a problem with FireFox' official release


scratch that.


i dont want users quoting the entire page.

Xenon
02-25-2005, 04:15 PM
erm?

sorry i don't get it.

it's quoted what is highlighted, and nothing more.

@wysiwyg: sorry nothing new right now, i'm currently were busy in RL, and don't find enough time to update my hacks :(

theArchitect
03-08-2005, 12:27 AM
Nice hack. It is just a shame that it doesn't work with the other multi-quote hack on here.

When I installed yours it gives me a new reply page instead of just quoting the selected text in the Quick Reply box.

catocom2
03-08-2005, 02:02 AM
Nice hack. It is just a shame that it doesn't work with the other multi-quote hack on here.

I'm running both of them on my board, with no problems. ?? :smoke:

Xenon
03-08-2005, 04:13 PM
When I installed yours it gives me a new reply page instead of just quoting the selected text in the Quick Reply box.

did you do a hardrefresh of your cache?

if not that's the problem, as the js files are cached normally

theArchitect
03-16-2005, 10:46 AM
did you do a hardrefresh of your cache?

if not that's the problem, as the js files are cached normally
Ok. I am clearly doing something wrong.

I have coped the code into the .js file and changed the code in the postbit template. But now when I click on the Quick Reply nothing happens. I doesn't even put the cursor in the QR box. The url generated is http://www.mysite.com/forum/newreply.php?do=newreply&p=22479

I have obviously got something very wrong, but can't work out what it is.

noonespecial
03-18-2005, 04:48 AM
Ok. I am clearly doing something wrong.

I have coped the code into the .js file and changed the code in the postbit template. But now when I click on the Quick Reply nothing happens. I doesn't even put the cursor in the QR box. The url generated is http://www.mysite.com/forum/newreply.php?do=newreply&p=22479

I have obviously got something very wrong, but can't work out what it is.
this doesn't work if you have quick reply set to not work unless the qr button is pressed (for threaded and hybrid users). just fyi.

theArchitect
03-18-2005, 05:04 AM
Thanks for the suggestion. But I have tried setting that to "no" and clicking the QR button still does nothing.

boeserwolf
03-31-2005, 08:53 PM
Dear Xenon,

I have a question about translating your hack:

Some guys from vbulletin-germany.com built up a community called : vBHacks
(URL: http://www.vbhacks-germany.com/forum/index.php?)

After the verification that you own a license, you may download hacks there.

I am very interested in this Hack because I came from WBB, and I miss this feature in vB 3.

Unfortunately there exists no german hack for this feature, so I would like to translate your hack to german language if that is okay for you.

I would then also like to post this Hack in the vbhack community for license owners.


And sorry for my english, but as I live in Austria, I am not a native speaker.


Yours


Markus

Xenon
04-03-2005, 03:36 PM
Ich antworte mal auf Deutsch, machts einfacher ;)

Tut mir leid, aber wie ich schon bei fr?heren anfragen gesagt habe, meine Hacks ?bersetze ich wenn dann selbst, solange die seite nicht im offiziellen Jelsoft netzwerk ist, werden auch meine Hacks da nicht draufkommen, als Admin hier hab ich da wenig freiraum ;)

deathemperor
04-08-2005, 09:28 AM
I found a bug

when username has ' (like it'sme ) it display error even you didn't click.

Someone fix it please, I'm too lazy ^^

boeserwolf
04-08-2005, 06:11 PM
@ Xenon

Ich finde den hack sehr nützlich speziell weil er für meine Seite sehr viel bringen würde.

Würdest du vielleicht, so du Zeit hast, ein deutsches Sprachpaket rausbringen und hier posten, wenn du nicht möchtest, das jemand anderes deine Hacks übersetzt?

lg

Markus

TwinsForMe
04-10-2005, 02:08 AM
* TwinsForMe clicks install.

Thanks. :)

zetetic
04-10-2005, 03:18 PM
Is it possible to modify this so that "Quote message in reply" is not automatically checked when used without selecting any text?

Also, noonespecial mentioned that the vb setting "Require Click for Quick Reply" must be off for this to work, and that seems to be true. Is there any way around that?

zetetic
04-10-2005, 04:08 PM
Is it possible to modify this so that "Quote message in reply" is not automatically checked when used without selecting any text?
I fixed this by changing:

else if (document.vbform.qr_message.value == "")
{
document.vbform.qr_quickreply.checked = 'checked';
return qr(postid);
}

To:

else if (document.vbform.qr_message.value == "")
{
document.vbform.qr_quickreply.checked = '';
return qr(postid);
}

That seems to work fine.

Xenon
04-11-2005, 07:54 PM
I found a bug

when username has ' (like it'sme ) it display error even you didn't click.

Someone fix it please, I'm too lazy ^^
yep, you're right.

hmm, will have to look how to fix it without great rewritings ^^

boeserwolf
04-15-2005, 12:13 PM
Da habe ich noch ne kleine Frage:

Arbeitet der Hack mit der vBulletin 3.07 auch zusammen?

lg

Markus

chriswible
04-15-2005, 01:19 PM
yep, you're right.

hmm, will have to look how to fix it without great rewritings ^^
I had the same problem with my hack. Luckily, there was a user with apostrophes in his name, so I fixed it before I released it. ;) addcslashes did the trick for me.

zetetic
04-16-2005, 01:09 PM
I had the same problem with my hack. Luckily, there was a user with apostrophes in his name, so I fixed it before I released it. ;) addcslashes did the trick for me.
I just found this problem. There's no error, but when the guy with an apostrophe in his name clicks the quick reply button it opens the full editor. How exactly did you fix that?

zetetic
05-05-2005, 07:38 PM
Bump.

Hey Xenon,

Any chance of fixing this for people with apostrophes in their username and/or WYSIWYG editor? (I've also had users say it doesn't work in Safari or Maxthon, but that's less important).

Xenon
05-09-2005, 07:48 AM
i cannot test every browser ;)

actually, i didn't find the time yet to do bugfixing, as i am very busy these weeks...
(damn university)

zetetic
05-09-2005, 02:44 PM
i cannot test every browser ;)

actually, i didn't find the time yet to do bugfixing, as i am very busy these weeks...
(damn university)
I totally understand it's low on your priority list, I just thought I'd let you know someone out there is hoping for an eventual fix. :)

TwinsForMe
05-09-2005, 08:59 PM
It seems to conflict with the /me hack. Is there a way for both to be used?

Xenon
05-10-2005, 06:05 PM
erm, there is no conflict between those two hacks.

as you can see on vb.org both are working perfectly together

TwinsForMe
05-10-2005, 06:08 PM
When someone uses quick-reply multiquote on a quote that has a /me in it, it reverts to "/me".

Let me go get a screenshot.

Xenon
05-10-2005, 06:11 PM
nope, the name stayes as it should.

TwinsForMe
05-10-2005, 06:15 PM
Sorry. It isn't your multi-quote hack. It's the other one.

:bangshead:

Xenon
05-10-2005, 06:22 PM
ahh :)

Megareus Rex
05-12-2005, 05:56 PM
Excellen hack! Works like a charm :)

deathemperor
05-24-2005, 05:05 AM
I had the same problem with my hack. Luckily, there was a user with apostrophes in his name, so I fixed it before I released it. addcslashes did the trick for me.
care to share it ?

zetetic
05-24-2005, 05:19 AM
care to share it ?
I figured out that he means he fixed that problem in his own hack (https://vborg.vbsupport.ru/showthread.php?s=&threadid=76594), not this one. I looked at his but couldn't figure out how what he did could be applied to this one, though. :(

zetetic
05-28-2005, 09:04 PM
Okay I'm not a skilled coder but here's the workaround I came up with for users who have apostrophes in their names:

Edit functions_showthread.php:

Find:

// do posts from ignored users

Add Above:

$post['qrusername'] = addslashes($post['username']);

Then edit the postbit template:

Find:

onclick="return doMultiQuote('$post[username]',

Replace with:

onclick="return doMultiQuote('$post[qrusername]',

This works for me, but use at your own risk. :)

Edited to add: Don't forget to change legacy_postbit too, if you give your users the option to use it. I always forget that. :D

Boofo
05-29-2005, 06:01 AM
Okay I'm not a skilled coder but here's the workaround I came up with for users who have apostrophes in their names:

Edit functions_showthread.php:

Find:

// do posts from ignored users

Add Above:

$post['qrusername'] = addslashes($post['username']);

Then edit the postbit template:

Find:

onclick="return doMultiQuote('$post[username]',

Replace with:

onclick="return doMultiQuote('$post[qrusername]',

This works for me, but use at your own risk. :)

Good one, sir. Thanks! ;)

zetetic
05-29-2005, 01:29 PM
Good one, sir. Thanks! ;)
Thanks and you're welcome. :)

Lurk
06-02-2005, 11:07 PM
Edited to add: Don't forget to change legacy_postbit too, if you give your users the option to use it. I always forget that.
Damn, wow... That's amazing.

zetetic
06-02-2005, 11:18 PM
Damn, wow... That's amazing.
Um... huh? Why's it amazing that I forget to edit the legacy postbit?

sv1cec
06-03-2005, 05:27 AM
Um... huh? Why's it amazing that I forget to edit the legacy postbit?
I do not know if it is amazing, but it happens to me too, all the time!

On a sidenote, I just install this on 3.0.7 and it works fine. Just one question, I got from reading the previous pages. I saw too many requests for porting this to the WYSIWYG editor. Do you guys get WYSIWIG in the Quck Reply? And if you do, how did you do it? I am using WYSIWYG in the normal reply etc, but I didn't know you can have it in the QR as well.

Rgds

deathemperor
07-01-2005, 09:41 AM
On a sidenote, I just install this on 3.0.7 and it works fine. Just one question, I got from reading the previous pages. I saw too many requests for porting this to the WYSIWYG editor. Do you guys get WYSIWIG in the Quck Reply? And if you do, how did you do it? I am using WYSIWYG in the normal reply etc, but I didn't know you can have it in the QR as well.

ACP -> Vboptions -> Message Posting and Editing Options -> Quick Reply Enabled -> Yes - Show Enhanced (WYSIWYG) Editor Toolbar

sv1cec
07-01-2005, 09:46 AM
Thank You Sir!

csidlernet
07-20-2005, 09:15 AM
goodwork Xenon!

Logikos
08-10-2005, 05:25 PM
* Logikos installs since I just found it :)

Chris M
08-11-2005, 01:09 PM
* Chris M does the same lol :p

Satan

catocom2
10-04-2005, 07:16 PM
This is a great hack.
I'm going to try to port it to 3.5, if it hasn't been done yet, and posted.

moethelawn
10-09-2005, 09:50 PM
This is a great hack.
I'm going to try to port it to 3.5, if it hasn't been done yet, and posted.

I had this hack installed in my 3.0.7 board but now that it's 3.5 I would like to see a port of this (cause I don't want to add another button for multiquote).... unless this hack does work for 3.5 :D

stan111
10-24-2005, 06:19 AM
work like a champ
install it on 3.0.7 without any error

clicked install

zetetic
11-13-2005, 06:06 PM
I'm going to try to port it to 3.5, if it hasn't been done yet, and posted.
Deathemperor has done that (https://vborg.vbsupport.ru/showthread.php?t=99408), but apparently it's still a bit buggy.

Steve123
12-01-2005, 11:49 AM
It seems that this no longer works in Firefox 1.5?

Can anyone confirm this?

Steve123
12-07-2005, 11:36 AM
bump

sv1cec
12-07-2005, 01:30 PM
As far as I know it works in the latest version of Mozilla Firefox (1.0.7).

zetetic
12-10-2005, 07:29 PM
I noticed it doesn't work in Firefox 1.5 also, so I'm sticking with Firefox 1.0.7 for now.

sv1cec
02-08-2006, 06:06 AM
The script does not work in Firefox 1.5, the quoted text is NOT shown in the Quick Reply window. I went back to 1.0.7, due to that, and some other issues I found on Firefox 1.5.x.x.

Any help from the author?

Xenon
02-08-2006, 05:36 PM
nope, sorry didn't find a fix for that FF bug yet.

i just hope they will fix it, as i found several other scripts with the same problem, but no fix..

sv1cec
06-29-2007, 06:53 AM
Xenon, I know this is a very old hack, and you have probably advanced to later versions of vB, but I am still using 3.0.xx in my site and I do not plan to upgrade any more. Since this is one of the hacks we are using heavily, and since this was brought up in a recent discussion, I have a question for you.

When clicking on the QR icon, without selecting any text, the whole post in which the icon was, is quoted in your reply. Would it be possible, in this case, to show the quoted text in the QR box, just like it does when you have selected some text? I am not good with Javascript so there is nothing much I can do.

Many thanks