Reoccurring Paypal Subscriptions

[insanctus]

What this does (added in first post)

With the current vbulletin subscription set up, it only charges your members one time. So if you have a pay based site, or forum area they have to keep subscribing, and causing them to waste time and effort (and maybe you lose money)

What this does, is give you the option if you want one time payment (standard vb) or reoccurring payment.

When you choose reoccurring the script has them sign up for a reoccurring payment, as paypal sends you confirmation each time you get a subscription payment, your system will now update their access time.

This will save your members from having to resign up all the time and hopefully save you some money :)


For instance, say you have a paying member?s only area, and you want them to have to pay $10 a month.

With this you can charge per month and it handles all the charges, and every month they send another payment automatically your script gets updated and sets their new expiration.


This has been asked for many times and IMO should have been in to begin with.

Enjoy and I will help as I can.

Note from the new supporter: This hack is now being actively supported again. I have updated the install instructions to work for version 3.0.7, and we can now begin to work out any existing bugs. This code is still raw and has not been tested extensively due to the difficult nature of testing paypal transactions.

[Skyline_GT]

Nice..
very useful:D

[insanctus]

Most welcome :) , don't forget to click install if you use this :)

I have been using something simular on my site for some time, makes life so much easier.

[FWF]

awesome!

i agree this should have been included in vB 3, anywho...ive got this installed thanks for releasing it :D

*installs*

[dkny]

I get error:
Fatal error: Call to a member function on a non-object in /home/jb/public_html/forum/includes/functions_subscriptions.php on line 332

doesn't agree with this command:
$paypalextra = $DB_site->query_first("SELECT * FROM " . TABLE_PREFIX . "subscription AS subscription WHERE subscriptionid=$subscriptionid");

btw I ran ALTER TABLE `subscription` ADD `reoccur` VARCHAR( 10 ) DEFAULT '0' NOT NULL ;

Any suggestions?

[insanctus]

I get error:
Fatal error: Call to a member function on a non-object in /home/jb/public_html/forum/includes/functions_subscriptions.php on line 332

doesn't agree with this command:
$paypalextra = $DB_site->query_first("SELECT * FROM " . TABLE_PREFIX . "subscription AS subscription WHERE subscriptionid=$subscriptionid");

btw I ran ALTER TABLE `subscription` ADD `reoccur` VARCHAR( 10 ) DEFAULT '0' NOT NULL ;

Any suggestions?
Yes I am sorry about that (will update the txt, had it in there but right before saved power went out)

To fix find in includes/functions_subscriptions.php

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userid)
{
global $vboptions;

Replace With

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userid)
{
global $vboptions,$DB_site;

[dkny]

Wow that was the fastest reply EVER! Will try it now, thanks!

[insanctus]

lmao no trouble at all, I had it in then I had to redo the todo , power went out right before I hit save, this area is bad for power.

[dkny]

Yep that worked, you the man!

[insanctus]

Yep that worked, you the man!
Very cool :) I know alot had been after this. I had time since one my clients is MIA and I am waiting on a responce.

[insanctus]

Updated File If You Already Installed Do The Following.

Open /subscriptions/paypal.php And Find
if ($_POST['txn_type'] == 'web_accept' AND $_POST['payment_status'] == 'Completed')

Replace With
if ($_POST['txn_type'] == 'web_accept' AND $_POST['payment_status'] == 'Completed' OR $_POST['txn_type'] == 'subscr_payment' AND $_POST['payment_status'] == 'Completed')

Sorry about that, darn power.....

[Boofo]

I don't mean to sound simple here, but what does this actually do?

[insanctus]

I don't mean to sound simple here, but what does this actually do?
Ok vbulletin paypal subscriptions only charges one time, so if you set up a monthly fee your users have to redo it every month or loss there forum access or what ever else you give them.

This takes it and turns it into reoccuring payments (if you choose that option)

This way they pay you every set ammount of time you picked for that subscription and it checks to see if it gets paid every month :)

For instance, say you have a paying members only area, and you want them to have to pay $10 a month.

With this you can charge per month and it handles all the charges, and every month they send another payment automaticly your script gets updated and sets their new expiration.

The vbulletin subscriptions before only worked one time per click now you can do reoccuring :)

Hope that makes sence, if not I will drink some coffee and try again :)

[Boofo]

No, you explained it very well, thank you. I don't have any paypal subscriptions set up on my board but I will click install and install it anyway as this should be default in vb3. Good job! ;)

[insanctus]

No, you explained it very well, thank you. I don't have any paypal subscriptions set up on my board but I will click install and install it anyway as this should be default in vb3. Good job! ;)
Many thanks :) , I prolly should write a better explination in first post.

Never know they may toss my code in the next update

* insanctus laughs and dreams on.

[Boofo]

If this working in this version then?

I have mine set up to do monthly reacuring on my personal site, the only thing it does not have so far is a check to see if paid monthly, so if they cancled I have to change it manualy.

This quote is from the other thread.

[insanctus]

Yes it is working in this version :) hence why the release.

I had to get some data built up on it.

[Boofo]

I thought so but I wanted to be sure. Again, excellent job! ;)

[insanctus]

I thought so but I wanted to be sure. Again, excellent job! ;)
Never hurts to ask :) and most welcome.

I learned 'alot' about paypal in last 4 days or so, and I wanted to make sure I had the payments tight :)

[TheEDIGuy]

Excellent job. Clicking Install, and installing it right now, much to the delight of my monthly subscribers.

Thanks!

[Erwin]

The only thing keeping me from installing this is that I am sure the next vB3 update will have this, and I don't want to muck up the database with extra fields. :) On the other hand, great job. I will press install in the meantime.

[Erwin]

Ah, what the heck, I installed it. :)

[Erwin]

By the way, if the member wants to cease the reoccuring subscriptions, how does he or she do that? I need to provide instructions.

[TheEDIGuy]

One little typo in Step 3:

<input type=\"hidden\" name=\"ammount\" value=\"$cost\" />Only one M in there...

[ranger2kxlt]

what about something like.....another drop down right under the price on the subscription page...that says one time or reoccuring? that way they can choose if they want to pay once or for life? I would install that :-D

Thanks...looks like a useful hack (wish i could use that)

[insanctus]

By the way, if the member wants to cease the reoccuring subscriptions, how does he or she do that? I need to provide instructions.
They log into their paypal, and hit cancle on that subscription. It will stop their payments , hence stoping the update of their time expire date.

what about something like.....another drop down right under the price on the subscription page...that says one time or reoccuring? that way they can choose if they want to pay once or for life? I would install that :-D

Thanks...looks like a useful hack (wish i could use that)

I may in the future, sounds like an interesting idea.

[insanctus]

One little typo in Step 3:

Only one M in there...
Actually that <input type=\"hidden\" name=\"ammount\" value=\"$cost\" /> is useless any how :)

Subscriptions uses a3

[Majik?]

Excellent addition.. :up: I'll never know why some things weren't inluded originally.

[Erwin]

I agree... if you make the checkbox on the subscription page itself, it would make it easier to implement. Great hack nonetheless.

[insanctus]

I think that would be a sepperate hack, and the two would conflict.

Reason is, say you as admin want it to be reoccuring, then their check box is in effect useless.

Plus lets face it most members are not bright enough to read all of what they are doing in the first place.

[Fluous]

Okay, before I install this I have a couple questions.

When the month comes, where do they pay? From their usercp? Like if they bought a month. It expires how would they go about renewing it. If it's from paypal, then what would be the difference of a manual one. Or does it automatically just take it out. *what I'm thinking*. And what if they hit the bunkers...aka below zero in their account. I know that paypal accounts can go negative, but would this stop it upon hitting 0? Doesn't matter to me jw.

But now that I rethought and figures it pays every month itself. It's all good and I'll install. :)

[insanctus]

Okay, before I install this I have a couple questions.

When the month comes, where do they pay? From their usercp? Like if they bought a month. It expires how would they go about renewing it. If it's from paypal, then what would be the difference of a manual one. Or does it automatically just take it out. *what I'm thinking*. And what if they hit the bunkers...aka below zero in their account. I know that paypal accounts can go negative, but would this stop it upon hitting 0? Doesn't matter to me jw.

But now that I rethought and figures it pays every month itself. It's all good and I'll install. :)
It auto bills them if you select reoccur, if they hit 0 and it shows as pending, they do not get updated time limit until their payment goes thru (so they would lose access while not paid)

[Fluous]

Thank you. Was wondering how that little part worked :).

[aloha]

Thanks insanctus! Erwin... just keep the install button clicked :P

[Erwin]

I've set it up. :) Let's see how it goes.

[insanctus]

I've set it up. :) Let's see how it goes.
It is working good on mine :) ..

[dkny]

I installed this excellent hack. I have a test account set up. The problem I have, even before installing this hack is that the members dont show up in the subscription section in admin, plus there group doesn't chang (from Regular member to Paid Member). I went to MYPHPadmin and the Subscriptionlog tables are blank. I tried it with a few test accounts. Anyone have the same problem? I need this fixed, I'm willing to pay.

[insanctus]

I installed this excellent hack. I have a test account set up. The problem I have, even before installing this hack is that the members dont show up in the subscription section in admin, plus there group doesn't chang (from Regular member to Paid Member). I went to MYPHPadmin and the Subscriptionlog tables are blank. I tried it with a few test accounts. Anyone have the same problem? I need this fixed, I'm willing to pay.
Sounds like you did not edit paypal.php :) Step 4

[insanctus]

After some thought, I may add in some more on this.

For my uses I and I think others would like it, is one time of so much , then so much each time after. :)

I will play with it when wake.

[insanctus]

Here is an example of what it would look like.

So say you wanted to charge them $50 at first then $10 a month each month after this would allow that.

I will release this update once I get a chance to test it.

[Erwin]

Cool. :)

[insanctus]

Cool. :)
I tested it, and it works, now I just have to think on how to make the templates look.

Here is what I have thus far.

[Fluous]

Can't wait :-D

[insanctus]

Hmm, I am so stumped on how I want it to look on user end, specially the first subscription page.

Atleast it is working, tested it on my page. As soon as I can get it in my mind how I want client side to look it will be out (the upgrade)

[The Watcher]

hi just installed this and it works just as you say - sweet :)

I have a few suggestions however:

1) Ability for users to choose the subscription amount
2) Ability to make it a one-time payment
3) Ability for users to cancel their subscription from within vbulletin
4) Send user a PM each time their subscription renews

I don't know if these are possible but be good if they were - especially as I am thinking that its gonna take Jelsoft a decade to do their PayPal rewrite. They say they will do it for v3.1 yet they are still only on 3.0.1 so er mayb a decade is too soon ... who knows !!!

Anyways, thanks for this excellent hack.

[insanctus]

hi just installed this and it works just as you say - sweet :)

I have a few suggestions however:

1) Ability for users to choose the subscription amount
2) Ability to make it a one-time payment
3) Ability for users to cancel their subscription from within vbulletin
4) Send user a PM each time their subscription renews

I don't know if these are possible but be good if they were - especially as I am thinking that its gonna take Jelsoft a decade to do their PayPal rewrite. They say they will do it for v3.1 yet they are still only on 3.0.1 so er mayb a decade is too soon ... who knows !!!

Anyways, thanks for this excellent hack.


Glad you like :)

As for list

1, hmm not sure how I like that idea
2, you can do this in admin cp, just do not click reoccur
3, I do not think this is possible , they have to via paypal or you do
4, Very possible and easy to do, may add it in I like idea.

[dkny]

Sounds like you did not edit paypal.php :) Step 4

you right I did skip this step, I modified it but I still cant get the members group to change plus they users dont show up in the subscription page. Any ideas what it could be?

[insanctus]

you right I did skip this step, I modified it but I still cant get the members group to change plus they users dont show up in the subscription page. Any ideas what it could be?
Are you trying with your own accounts? If so are they both active, due to if one is pending it will not change their group, until such time as it is confirmed.

[dkny]

Are you trying with your own accounts? If so are they both active, due to if one is pending it will not change their group, until such time as it is confirmed.

No I'm trying with my girlfriends account which is active. Shouldn't it show active users even without your hack? I have 2 VB boards and same issue on both.

[insanctus]

No I'm trying with my girlfriends account which is active. Shouldn't it show active users even without your hack? I have 2 VB boards and same issue on both.
Hmm that is odd, mine working fine, moves me up and everything on subscriptions.

Both boards using my hack?

[Majik?]

3, I do not think this is possible , they have to via paypal or you doYou can do it by creating a cancellation link to PayPal, but you'd need to store PayPal's subscription ID in the database. The cancellation link's made using the subscription ID. ;)

[insanctus]

You can do it by creating a cancellation link to PayPal, but you'd need to store PayPal's subscription ID in the database. The cancellation link's made using the subscription ID. ;)
Yes and they would still have to log in :) so hence doing it themselves.

[Majik?]

Yes and they would still have to log in :) so hence doing it themselves.Yes, but they aren't having to look through there history to find the subscriptio nthey're wanting to cancel. If you make the link, which most site's I've seen do (at least where I've purchased subscriptions), it's a lot easier and more user-friendly for the end-user.

It's a matter of convenience for the end-user more than anything. ;)

[insanctus]

Yes, but they aren't having to look through there history to find the subscriptio nthey're wanting to cancel. If you make the link, which most site's I've seen do (at least where I've purchased subscriptions), it's a lot easier and more user-friendly for the end-user.

It's a matter of convenience for the end-user more than anything. ;)
Hmm, I do not see where it would be hard then..... I will look into it when I have time.

[Majik?]

Hmm, I do not see where it would be hard then..... I will look into it when I have time.Sure, no rush.. It's not really a neccessity, but would be something that the memebers would appreciate having I'm sure. I know it's something I like to see myself when I purchase reocurring subs from a site. I don't have to dig through all the stuff at PayPal to find it if and when the time comes to cancel it.

[DivisionByZero]

I found a bug:

I'm running 3.0.1, and found the following that should be updated:

for includes/functions_subscriptions.php, in your text, there is:
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]\" />

in my vb 3.0.1, there is:

<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]]/$vboptions[forumhome].php\" />

I installed it fine, just thought I'd let you know :)

[Majik?]

I found a bug:That's not a bug, just something that's changed from v3.0.0 to v3.0.1 is all. The only difference that'll make is if you've renamed your index.php to something else and it's not a DirectoryIndex file. i'm assuming the author's using v3.0.0 when he made this. ;)

[DivisionByZero]

i know it's not a bug, but novice users would be confused with this, so I thought I'd update it :)

[rookie7]

Absolutely brilliant hack! Thank you very much for sharing. If this works out well, I'll be sure to donate $ to your paypal account. Do you have a paypal account?

*Install*

[Rick]

I have a yearly membership system. Can this be setup to make yearly transactions?

This looks like a great hack. Thanks.

[insanctus]

i know it's not a bug, but novice users would be confused with this, so I thought I'd update it :)
Yes if they read down the thread, I think making two instructions would be more confusing.


I have a yearly membership system. Can this be setup to make yearly transactions?

This looks like a great hack. Thanks.

Yes just pick one year, those who subscribe after you set it up will be reoccuring :)

[corsacrazy]

what about all the members who are already subscribed?

[insanctus]

what about all the members who are already subscribed?
This will not effect them until next time they subscribe.

[corsacrazy]

This will not effect them until next time they subscribe.
any query i can run to make them already have the auto subscribe option?

[insanctus]

any query i can run to make them already have the auto subscribe option?
No due to that is all paypal side, when they paid they agreed with paypal one time.

Now with this they are agreeing to reoccuring. So next time they subscribe, it is all set.

[spence2]

Thank you very much for this hack!

Can you say how your testing with offering an initial payment & reoccuring subscription payments is coming along?

BTW, just because you would know and getting a question answered at vb.com is like waiting for the icecap to thaw...in the SM, there appear to be options for currencies:

Could anyone tell me whether I can enter payments in all three currencies? Or do you choose one? (Say, either dollars or pounds?) To accept all three currencies is there any back-ending that I need to implement at Paypal?

Thanks again for sharing your work.

[insanctus]

Thank you very much for this hack!

Can you say how your testing with offering an initial payment & reoccuring subscription payments is coming along?

BTW, just because you would know and getting a question answered at vb.com is like waiting for the icecap to thaw...in the SM, there appear to be options for currencies:

Could anyone tell me whether I can enter payments in all three currencies? Or do you choose one? (Say, either dollars or pounds?) To accept all three currencies is there any back-ending that I need to implement at Paypal?

Thanks again for sharing your work.
As for types of currencie I can only assume it would work, I have never used them so there I am at a loss, but from what I have 'seen' I would say they would be ok.

As for my initial it is doing a hit or miss, and with my gallery taking up more time I have yet to fine tune it.

But I can assure that hack to do an initial will be out soon :)

[insanctus]

The new one I am working on is almost done, that will allow for you to choose an initial payment and a dif reoccurring :)

It is working, just a bit of work to do on the look

[corsacrazy]

slightly off topic:

any way to make the system move the user from the paid usergroup back to the standard one as my vb3 doesnt do that mate

[insanctus]

It should do it in the cron job, due to it sets how long it is active for....

[Boofo]

Any progress on the new version?

[insanctus]

It is all done cept the look, I have been putting most my time into the gallery I sell, seems it is becoming a hot item.

But I hope to finish up the new version of this hack this week. Although it will be released in a seperate thread due to it does more then some may need...

[Boofo]

Please let me know when the new version is posted. ;)

[sketch42]

i like this hack very much and have installed it but i would like to know if its possible in the next vers or if this is a paypal issue... but i offer access to a download seection and if they cancel their subscriptionafter one day they get what they downloaded and ended up not paying.. so is it possible to get the payments prorated upon cancelling subscription???

Great Hack BTW

[Jpax]

i like this hack very much and have installed it but i would like to know if its possible in the next vers or if this is a paypal issue... but i offer access to a download seection and if they cancel their subscriptionafter one day they get what they downloaded and ended up not paying.. so is it possible to get the payments prorated upon cancelling subscription???


Great Hack BTW


I would like to know also, I m running VB3.0.1 and would like to have a yearly subscription to allow into a forum for viewing content they paid for, ALSO is it possable to EDIT the USER that paid for the subscription to be able to UPLOAD attachments, like they pay and they can add attchments now.

[sketch42]

ALSO is it possable to EDIT the USER that paid for the subscription to be able to UPLOAD attachments, like they pay and they can add attchments now.

just set it up in the ACP ....
ACP >Forums and Moderators > Forum Permissions> Forum X(insert your forum here)> Usergroup X(insert the your usergroup here) > Edit > Post Permissions > Can Upload Attachments [x] Yes [ ]No

and save :classic:

EDIT: almost forgot ... goto your subscription manager and make sure you check off on the right by the usergroups the name of the usergroup you want to have access to that section... as well as setting the forums that they have access to ;)

[insanctus]

^ Correct.

As for if they cancle well sadly if they buy then download and cancle there is little you can do but be happy you got the first payment.

Myself I use a first time payment on my site (price of software) then a reoccuring yearly (for updates on said software)

[sketch42]

^ Correct.

As for if they cancle well sadly if they buy then download and cancle there is little you can do but be happy you got the first payment.

Myself I use a first time payment on my site (price of software) then a reoccuring yearly (for updates on said software)
if they cancel after a day does it refund them the money?

[Yahhoon23]

Nope. Say they sign up for a monthly sub at $5 per month.

You get their first $5 payment, then they cancel the subscription. You still get to keep their first payment and they don't get any refunds unless they try to request a refund from paypal.

Then since their sub has been cancelled, after their first month of use is up, they go back to the registered group.

[Amzadi]

I offer subscriptions based on daily, weekly, monthly and yearly rates.
Daily - $4, Weekly - $21, Monthly - $60 & Yearly - $365
Now while the amounts may be excessive for your sites, look at the structure. It increases the daily cost for the shorter terms. If you're getting a lot of cancellations after the first subscription, this may be a good idea for you to use.

[sketch42]

I offer subscriptions based on daily, weekly, monthly and yearly rates.
Daily - $4, Weekly - $21, Monthly - $60 & Yearly - $365
Now while the amounts may be excessive for your sites, look at the structure. It increases the daily cost for the shorter terms. If you're getting a lot of cancellations after the first subscription, this may be a good idea for you to use.
o no i was just wondering if with the subscription cancellation they get refunded as well

[Amzadi]

No, they don't. It just cancels future subscription payments and VB puts them back in their previous group when it expires.

[sketch42]

No, they don't. It just cancels future subscription payments and VB puts them back in their previous group when it expires.
BIG problem with subscription cancellations... they arent being taken out of the subscription... so i can only think that this is a prob with vb or the hack

[insanctus]

BIG problem with subscription cancellations... they arent being taken out of the subscription... so i can only think that this is a prob with vb or the hack
Well if they paid why would you want them taken out till the paid time is up?

[sketch42]

Well if they paid why would you want them taken out till the paid time is up?
because even afterwards like the month is up.... heck i even had a guy that reported a fraudulent purchase and the money was refunded .. yet he still wasnt removed

[insanctus]

That is vb , but at that point I would have banned him...... give them all ip info (if he claiming it is fake) and then let them take care of legal stuff.

[sketch42]

That is vb , but at that point I would have banned him...... give them all ip info (if he claiming it is fake) and then let them take care of legal stuff.
hmm i never thought of that......

so this is a vb bug?

[insanctus]

It is not as much a bug as just not an option?

[Boofo]

It is not as much a bug as just not an option?
Any word on the new version? ;)

[sketch42]

I thought i would update anyone else experiencing the issue with the refunded payments.. i hope noone minds....
Paypal have changed the variables again without notifying customers. I've now updated the paypal script to handle the new reversal methods and it will be in 3.0.2.


Here's the FIX clickity click click click (http://www.vbulletin.com/forum/showpost.php?p=693228&postcount=6)

[trainer]

It is not as much a bug as just not an option?


can you get back to me on the contest hack?

[Amzadi]

I thought i would update anyone else experiencing the issue with the refunded payments.. i hope noone minds....



Here's the FIX clickity click click click (http://www.vbulletin.com/forum/showpost.php?p=693228&postcount=6)
Thanks for the link Sketch42

[Cold Steel]

Installed. Thanks!

[heynurse]

Does anyone have this installed on 3.0.3? I'm having difficulties getting it to work correctly?

I'm installing this on 3.0.3 and I'm having a problem with this step:

Step 3. Open includes/functions_subscriptions.php

It says to find:
case 'paypal':
$form['action'] = 'https://www.paypal.com/cgi-bin/webscr';
$form['method'] = 'post';
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"amount\" value=\"$cost\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";
break;


But I can't find that exactly, I'm sure the code was modified since this hack was writtne, the closest thing to it is this:

case 'paypal':
$form['action'] = 'https://www.paypal.com/cgi-bin/webscr';
$form['method'] = 'post';
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"amount\" value=\"$cost\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"shipping\" value=\"0.00\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]/$vboptions[forumhome].php\" />
<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />
<input type=\"hidden\" name=\"custom\" value=\"$userinfo[username]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";
break;


This is what is supposed to be what is to replace the first set of code above:
case 'paypal':
$form['action'] = 'https://www.paypal.com/cgi-bin/webscr';
$form['method'] = 'post';
/// Add In For Reacuring Payments
$paypalextra = $DB_site->query_first("SELECT * FROM " . TABLE_PREFIX . "subscription AS subscription WHERE subscriptionid=$subscriptionid");
if($paypalextra[reoccur]==0){// It is one time
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"amount\" value=\"$cost\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";
}else{
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick-subscriptions\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"ammount\" value=\"$cost\" />
<input type=\"hidden\" name=\"a3\" value=\"$cost\" />
<input type=\"hidden\" name=\"p3\" value=\"$paypalextra[length]\">
<input type=\"hidden\" name=\"t3\" value=\"$paypalextra[units]\">
<input type=\"hidden\" name=\"src\" value=\"1\">
<input type=\"hidden\" name=\"sra\" value=\"1\">
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";

}
break;

Does anyone have any updated instructions for this step in 3.0.3? Any assistance would be greatly appreciated. Thanks

[nexialys]

you just need to find the corresponding lines, and that's all... put the missing lines.

the new version of 3.0.3 is adding some lines in the paypal reoccuring process that may answer the bugs with the older versions, that's why...

[heynurse]

Cool, thanks for the advice, but I've tried messing with the code, I keep getting all kinds of errors, I am a complete novice and don't know what the heck I'm doing when it comes to programing.

$$$$ If someone wants to figure this out, I'd pay them for their time and share it with the forum for free :) I'll pay you by paypal.

[heynurse]

duplicate post removed... oops

[RapCheck]

heynurse, I just upgraded to 3.03 myself, and re-adding hacks I ran into the same problem. This is what I put in, and everything appears to be working fine. I don't receive any errors at all. Hopefully it's correct.


case 'paypal':
$form['action'] = 'https://www.paypal.com/cgi-bin/webscr';
$form['method'] = 'post';
/// Add In For Reacuring Payments
$paypalextra = $DB_site->query_first("SELECT * FROM " . TABLE_PREFIX . "subscription AS subscription WHERE subscriptionid=$subscriptionid");
if($paypalextra[reoccur]==0){// It is one time
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"amount\" value=\"$cost\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"shipping\" value=\"0.00\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]/$vboptions[forumhome].php\" />
<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />
<input type=\"hidden\" name=\"custom\" value=\"$userinfo[username]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";
}else{
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick-subscriptions\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"ammount\" value=\"$cost\" />
<input type=\"hidden\" name=\"a3\" value=\"$cost\" />
<input type=\"hidden\" name=\"p3\" value=\"$paypalextra[length]\">
<input type=\"hidden\" name=\"t3\" value=\"$paypalextra[units]\">
<input type=\"hidden\" name=\"src\" value=\"1\">
<input type=\"hidden\" name=\"sra\" value=\"1\">
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";

}
break;

[por4x4]

Trying to install this on 3.0.3, and am having trouble finding some of the code....

Instructions call to find -

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userid)
{
global $vboptions;

But all I can find is this -

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userinfo)
{
global $vboptions;

What to do?

[sblum]

I had the same problem, por4x4. I tried changing userid to userinfo and it didn't work. I'd get the paypal subscription and money, but their subscription was not activated.

[por4x4]

Trying to install this on 3.0.3, and am having trouble finding some of the code....

Instructions call to find -

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userid)
{
global $vboptions;

But all I can find is this -

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userinfo)
{
global $vboptions;

What to do?

Buller? Buller? This is one of the BEST hacks of all time. Come awn, someone has got to know how to get this to work with 3.0.3!

[RapCheck]

guys, instead of replacing the whole section theres just one part that is added so just change
global $vboptions;
to
global $vboptions,$DB_site;

;)

[por4x4]

guys, instead of replacing the whole section theres just one part that is added so just change
global $vboptions;
to
global $vboptions,$DB_site;

;)
lol I knew it had to be an easy fix, but that was ridiculous! :D Thanks man!

[Ted S]

Great hack, it took only a few minutes to install on 3.0.3, thanks!

[rs-host.net]

I coded something like this for my site, but not a bad hack here.

[Chazz Layne]

you right I did skip this step, I modified it but I still cant get the members group to change plus they users dont show up in the subscription page. Any ideas what it could be?
Any updates on this problem from anyone? Having the same issue here, v3.0.1. Checked and rechecked the install...

[Doug Quance]

Rob-

I'm getting an error when executing the SQL query:


An error occurred while attempting to execute your query. The following information was returned.
error number: 1146
error desc: Table 'webster3_forums.subscription' doesn't exist


Your thoughts?

BTW, I am running 3.0.3 with the vBadvanced CMPS... which script should I use?

Thanks so much for this hack... I am going to send you a few bucks for your time :)

[Doug Quance]

Btw... I've never seen an INSTALL button in the header of a thread before... how does that work? After all... the code I need to install is not on my local computer, but on a server...

Just curious.

[Doug Quance]

Well... I found that particular issue.... I had to change my query to "vb3_subscription"

[Doug Quance]

Well... everything seemed to go pretty well, until I tried purchasing a subscription. When (as a customer) I click the link to purchase, I go to:

https://www.paypal.com/cgi-bin/webscr

and that page displays:

Error Detected

The link you have used to enter the PayPal system is invalid. Please review the link and try again.


Any clues as to how to fix this?

I checked the code over as best as I can, and I can't see where the problem might be. :(

[Doug Quance]

I just discovered the problem only occurs when I select "reoccuring" in the ACP. If I uncheck it, it works fine...

Any ideas?

[Yahhoon23]

Just a quick question, maybe I could get an answer here.

I have it set for recurring subscriptions etc etc but one problem.

Whenever someone subscribes to my website, it gives them the option to provide a shipping address or not provide one. Well I want to make it where they have no option and it automatically provides the shipping address for me.

I have a Paypal donation button added on my website that auto-provides the shipping address but when you actually subscribe through the website and not the donation button you have the option to pick shipping address or no shipping address.

Any feedback would be great.

[AidanII]

I've been taking a quick look at the code for one or two purposes of my own...

Would it not make more sense to change

if ($_POST['txn_type'] == 'web_accept' AND $_POST['payment_status'] == 'Completed' OR $_POST['txn_type'] == 'subscr_payment' AND $_POST['payment_status'] == 'Completed')

to be:

if (($_POST['txn_type'] == 'web_accept' OR $_POST['txn_type'] == 'subscr_payment') AND $_POST['payment_status'] == 'Completed')

I beleive this is functionally the same, but does one less comparison. Yes, I'm being picky here, sometimes things like this just irk me a bit.

A possible addition might be setting up the POST request to Paypal to automatically submit the correct URL for the notification. I beleive the parameter is called "notify_url". This should automatically enable IPN for the transaction posted, regardless of the settings in the account - As long as it's capable of IPN of course!

[AidanII]

Any clues as to how to fix this?

Doug, check the code you added to the includes/functions_subscriptions.php, in particular the bit under case 'paypal' after the case statement. Also check to see if it still works correctly for a one-off payment. If you're getting an error from that part, then ensure things like your paypal email address are set correctly in the configuration.

That would be my guess!

[Doug Quance]

Yes, it works fine until I select the recurring option... then I get the error message.

I don't really understand PHP, so I can't tell where the problem might exist...

[idslamyou]

I have had this installed for a month or so. I am just starting to get some members. They are able to subscribe and I get the notice from paypal about their payment, but their usergroup is not changing. I have doublechecked to make sure I have checked the additional usergroup to add them too. Can anyone help?

[idslamyou]

Can anyone help me with the problem I am having in the post above this? I have doublechecked all of the edits and still have the same problem or vbulletin not adding the user to the additional usergroup.

TIA

[Illuvatar]

Okay.....what in the world did I do wrong! lol

I copied the query in and ran it against the 'subscriptions' table, and after applying all the php edits, I get this when I attempt to update the subscriptions area in the admin cp. Invalid SQL: UPDATE subscription SET

### UPDATE QUERY GENERATED BY fetch_query_sql() ###
title = 'Silver Subscriber Monthly',
description = 'Thank you for your interest in subscribing to WotR. Forum Benefits for the Silver Subscriber are:
A custom Avatar of your choice
A custom title of your choice
An additional avatar showing their status as subscribers and supporters of the site.',
length = '30',
units = 'D',
cost = 'a:3:{s:3:\"usd\";s:4:\"5.00\";s:3:\"gbp\";s:4:\"0.00\";s:3:\"eur\";s:4:\"0.00\";}',
nusergroupid = '9',
active = '0',
reoccur = '0',
membergroupids = '',
forums = 'N;'
WHERE subscriptionid=1
mysql error: Unknown column 'reoccur' in 'field list'

mysql error number: 1054

Date: Friday 01st of October 2004 07:01:28 PM

[jbroder]

Hi,
I've never used a hack before, I usually just do my own thing. But, this one made things so much easier, I am really glad I downloaded.

I made some modifications to my install, so that the user could tell whether their subscription is going to be billed again or not. I added a cancel button right on the user cp for paid subscriptions, and when the user cancels through paypal, the subscriptionslog table is updated to show that the subscription has been cancelled.

I don't know if anyone else needs this, but here it is attached. I just wrote it today, so maybe there are errors I haven't found yet. For instance, my board only has rebilling transactions, so that might cause an issue on your board.

cheers!

[version2]

I thought i would update anyone else experiencing the issue with the refunded payments.. i hope noone minds....



Here's the FIX clickity click click click (http://www.vbulletin.com/forum/showpost.php?p=693228&postcount=6)
Hey, uh, everyone...I think I might see a problem here.

When I installed this last month my subscribers started subscribing. In my paypal register I can see the 'Subscription Creation' line as well as the 'Payment' line for each new subscriber. Well, a month later it is *almost* time for renewal and I am getting 'Subscription Creations' as well as payments again. And the first subscription creation still look like they are active and are not set to renew for a couple of days now.

What do I need to do?! Is this a problem? I dont really want to wait a couple to find out I am doublebilling all my subscribers.

[version2]

Hey, uh, everyone...I think I might see a problem here.

When I installed this last month my subscribers started subscribing. In my paypal register I can see the 'Subscription Creation' line as well as the 'Payment' line for each new subscriber. Well, a month later it is *almost* time for renewal and I am getting 'Subscription Creations' as well as payments again. And the first subscription creation still look like they are active and are not set to renew for a couple of days now.

What do I need to do?! Is this a problem? I dont really want to wait a couple to find out I am doublebilling all my subscribers.
Well, its because vb is still sending out reminders and my members are re-subscribing. How can I stop this?!

[alkatraz]

vb3.0.3
didn't work for me

got this error in admincp \ clicking on subscriptions
Parse error: parse error, unexpected T_CASE in /home/alkatraz/public_html/board/includes/functions_subscriptions.php on line 410

may have something to do with my functions_subscriptions being different.. (but unmodified to my knowledge)
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"amount\" value=\"$cost\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"shipping\" value=\"0.00\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]/$vboptions[forumhome].php\" />
<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />
<input type=\"hidden\" name=\"custom\" value=\"$userinfo[username]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";
break;

uninstalled

[cosycole]

I installed this hack as we are a subscription site with downloadable linkware collection for the game The Sims. I never got it to work though, if anyone would care to give me a hand I would be most appreciative, as this hack sure is every subscription sites dream :)
NiCole

[nautiqeman]

I'm having a problem whereby when I have the recurring checkbox clicked it doesn't update the user info in vb -- but if I don't have it clicked it works just fine. Any Ideas???

[Godzilla MR2]

any issues on 3.0.3?

[hichew]

any issues on 3.0.3?
i think it's not working with vb 3.0.3
any response from the author ?

[hasan2k]

i think it's not working with vb 3.0.3
any response from the author ?I agree.

The one time payment goes through.
Reoccuring feature does not work.

I have double checked everything to make sure the hack is properly coded in the forum but NO luck. Can someone help?

I am using VB 3.0.3

[jcr]

I have had this installed for a month or so. I am just starting to get some members. They are able to subscribe and I get the notice from paypal about their payment, but their usergroup is not changing. I have doublechecked to make sure I have checked the additional usergroup to add them too. Can anyone help?
I have the exact same problem :-/ Please we need help!

[amykhar]

The author can't support you guys. He is no longer a licensed user.

[kbadr]

Anyone get this to work on 3.0.3? I was all excited about this hack until I read the last few posts.

[MajorFm.com]

Its workin on 3.0.3 for me...!


http://www.majorfm.com/forum/subscriptions.php

[sub_ubi]

Working on 3.03 for me as well, but I paid someone for help :P

Anyone have any luck with the upgrade to 3.04? It doesn't seem to overwrite any of the files..

http://www.vbulletin.com/forum/showthread.php?t=124876

[MajorFm.com]

also what if the user e.g. its £1 a month

on the second month, paypal will take the money out automatially but how does vb know its been paid, and if the user cancels the paypal account, how does vb know to withdraw the subsciption?

[sub_ubi]

Paypal has a service called Instant Payment Notification (IPN). The information paypal relays to your site (aka, your forum) is handled accordingly.

If a person cancels or doesn't have enough funds to pay, IPN sends that information to vbulletin.

So has anyone done an upgrade with this to 3.04? I'm running 3.03 right now.

[MajorFm.com]

So if someone cancels payment, it will tell my forum this payment was not made, cancel their "vip" access...

Ok fantastic, i have IPN set up all ready so this will be automatic!

Thank you... perfect hack!!

[Sal Collaziano]

I''m sorry if this has already been noted but does the User have the option to pay with recurring payments or not? If not, I think it would be a good idea - and that's the only reason I wont install this mod.. Reason being, I think some people might get scared-away from the thought of being automatically billed.. If they're given the option to have the funds taken from their account automatically, that would be perfect...

[MajorFm.com]

When you set up the subscription, you can set it so its reoccuring or standard, so you can set up 2 options if you like e.g.

VIP Re-Occuring
VIP Standard

[Sal Collaziano]

Very good! I'm going to download this now and install it shortly. :)

[sub_ubi]

Anyone have this working with 3.06?

[Zate]

yes does it work with 3.0.6 ?

if not whats the errors?

[Glenn379]

has anyone gotten this hack to work with 3.0.6 yet?

[Illuvatar]

Welllllll.....we've got a slight issue...lol

Due to the criticality(sp?) of the release of version 3.07, and the fact that we were still running 3.03, I went ahead and upgraded this afternoon. This is one of only two hacks that I needed to reapply and they have modified the original code for the includes/functions_subscription.php file so that now the hack instructions are no longer valid. There is no function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userid)
{
global $vboptions; to replace any more. :(

I'll go back through this thread and see if this may have happened for releases 4-6, but until then (as I am not a decent coder lol) I am here to plead for help! :p

[ChrisSy]

Welllllll.....we've got a slight issue...lol

Due to the criticality(sp?) of the release of version 3.07, and the fact that we were still running 3.03, I went ahead and upgraded this afternoon. This is one of only two hacks that I needed to reapply and they have modified the original code for the includes/functions_subscription.php file so that now the hack instructions are no longer valid. There is no to replace any more. :(

I'll go back through this thread and see if this may have happened for releases 4-6, but until then (as I am not a decent coder lol) I am here to plead for help! :p

I had the same proble myself, but after looking through the functions_subscriptions.php file, the update just changed the variable $userid to $userinfo.

So hopefully this hack still works

Edit: yes i can confirm this works in 3.0.7

[Illuvatar]

I had the same proble myself, but after looking through the functions_subscriptions.php file, the update just changed the variable $userid to $userinfo.

So hopefully this hack still works

Edit: yes i can confirm this works in 3.0.7
Thank you ChrisSy!!! *Bows low*

[WoodiE]

I've got this hack installed and when the subscription is about to end vBulletin sends an email letting that user know their subscription is about to expire, however now mine sends out about 20-30 emails to that user.

What can I do so it only sends one email?

-Michael

[sub_ubi]

What happens to old subscribers if you upgrade from 3.03 to 3.07? Do they all get lost?

[AlienSector]

Has anyone successfully got this working with 3.0.7 and if so, would you be so kind as to detail how you possibly completed the task? I as well as many others would appreciate it very very much :).

[Apophis]

This does work with 3.0.7 with one minor modification.

Open
/includes/functions_subscriptions.php

Find

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userid)
{
global $vboptions,$DB_site;


Replace With

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userinfo)
{
global $vboptions,$DB_site;


It's a simple variable change from $userid to $userinfo

[Illuvatar]

This does work with 3.0.7 with one minor modification.

Open
/includes/functions_subscriptions.php

Find

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userid)
{
global $vboptions,$DB_site;


Replace With

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userinfo)
{
global $vboptions,$DB_site;


It's a simple variable change from $userid to $userinfo
Confirmed...works just fine in 3.0.7 :)

The only thing I saw there Apophis that was different in the function construct_payment from the original code was the addition of $DB_site;

My original mistake was putting too much info in the Find bit so it couldn't find the doggone statement. As soon as I just used the keyword "payment" it took me right there. That's why I was freaked out earlier! hehe I thought the original statements for that paragraph may have changed....it didn't...I just couldn't find the bugger! lol

Oh...also... I tried changing from $userid to $userinfo and back again, and it seemed to make no difference. It was that $DB that made the difference.

Overall...I am very pleased that with just this, the SMTP hack, and "How many posts since last visit" one, our boards have all the features and functionality that we used to have to apply 10 or more hacks to achieve! This leaves room for the "would be nice ...but not critical" enhancements if I so choose. *Hats off to dem dere VB developers man* :p

[MajorFm.com]

is this working on 3.0.7?

[Marco van Herwaarden]

is this working on 3.0.7?
Are you making a joke?

Just read 1 post above yours.

[MajorFm.com]

lol... whoooops... just did a quick reply... flicked through the thread and missed that! thanks!

[Dragon_Z]

I installed this and got this error whenI attempted to run the SQL Query, forgive me if this is simple but this is only my first day at this.

ALTER TABLE `subscription` ADD `reoccur` VARCHAR( 10 ) DEFAULT '0' NOT NULL ;

An error occurred while attempting to execute your query. The following information was returned.
error number: 1146
error desc: Table 'zforum.subscription' doesn't exist

[Illuvatar]

Well....hmmmmm...

I just had one of my users send me this Subject: Paid Subscription Expiry Notice

Hello,

Your access to the paid subscription "Silver Subscriber Monthly" is about
to expire.
To extend this you must visit
http://www.warofthering.net/forums/vbulletin225/upload/subscriptions.php

If you do not extend your subscription access will be removed.

Yours,
War of the Ring Community team

Now this concerns me for obvious reasons. The subscription is indeed showing as recurring in the Subscription Manager, but of course the expiry date remains the same whether it says recurring or not, and I'm assuming here that this automatic notification is based on the expiry date.

I'm going to tell this user not to do anything and let's see what it does. Has anyone else ran into this?

Thanks!

[thenewuser]

I just did this, and now when people sign up they don't get access to the forums...

Please help me I've had to manually add over 100 people alone today.

[amykhar]

To keep the original author from losing credit for his work, I am adopting this abandoned baby. I have updated the install instructions to get them right for vb 3.0.7 and am including them here until an admin adds me to the support list.

I have been in contact with the original author, and he has blessed my helping out. So, we are good to go there.

I understand there are some bugs. Once I get this code posted, and a few people have installed it, we can start working on any remaiing issues such as emails going out to subscribed users when the deadline approaches.

Please understand that a hack like this takes a while to test because the time frame for reoccurring subscriptions to process.

[spence2]

Thank you, Amy, for taking on the development & support of this hack! Also a big thank you to insanctus for the original code and for giving you permission to carry on with it (and to the admins here for adding you on as a supporter).

I'm sure everyone will be glad that you are here. ;)

[Illuvatar]

Thank you amykhar for taking this on! *bows low*

I will go ahead and either compare yours against the orignal or back the original out and then apply yours.

My issue as I listed above is actually not as major as it first appeared, as while it did issue the expiry notification and then went ahead and kept the subscription active in VB AND it left Paypal alone. My only issue now is the expiry notices going out and I'm hoping your changes will sort it for me.

I also have another question. I have the subscriptions set-up to automatically change a member's usergroup to either Silver or Gold for both annual and monthly subs and that works fine. However, I also have custom groups set-up for my mods, admins, etc. that are also subscribers. The subscription works a charm in that as it recurrs it ensures that the user is in the proper usergroup. What I had happen is that the member I mentioned above was reset from Silver Moderator to Silver Subscriber and I really cannot have it de-modding my staff at will. hehe

I decided to just manage those subs via Paypal and manually set the custom usergroups when it's appropriate. This may be my only recourse, but like the Rank deal where many people have asked about having it modified to pick up swecondary usergroups, this might be something to look at as well here.

All I have to do now is get these monthlys recurring properly without sending expiry notices and I will be a happy camper! :)

[amykhar]

Thank you amykhar for taking this on! *bows low*

I will go ahead and either compare yours against the orignal or back the original out and then apply yours.

My issue as I listed above is actually not as major as it first appeared, as while it did issue the expiry notification and then went ahead and kept the subscription active in VB AND it left Paypal alone. My only issue now is the expiry notices going out and I'm hoping your changes will sort it for me.

I also have another question. I have the subscriptions set-up to automatically change a member's usergroup to either Silver or Gold for both annual and monthly subs and that works fine. However, I also have custom groups set-up for my mods, admins, etc. that are also subscribers. The subscription works a charm in that as it recurrs it ensures that the user is in the proper usergroup. What I had happen is that the member I mentioned above was reset from Silver Moderator to Silver Subscriber and I really cannot have it de-modding my staff at will. hehe

I decided to just manage those subs via Paypal and manually set the custom usergroups when it's appropriate. This may be my only recourse, but like the Rank deal where many people have asked about having it modified to pick up swecondary usergroups, this might be something to look at as well here.

All I have to do now is get these monthlys recurring properly without sending expiry notices and I will be a happy camper! :)
I haven't done anything about the expiration emails yet. At this point, my code simply updates the install instructions for the new version of vbulletin.

As to your other problem, make your gold and silver secondary usergroups. In other words, when your members subscribe, they'll stay in their basic user group, but also be added to gold or silver. This way, your mods and admins don't lose their rank.

[Illuvatar]

I haven't done anything about the expiration emails yet. At this point, my code simply updates the install instructions for the new version of vbulletin.

As to your other problem, make your gold and silver secondary usergroups. In other words, when your members subscribe, they'll stay in their basic user group, but also be added to gold or silver. This way, your mods and admins don't lose their rank.
That's a real good idea and thankyee!

The only issue we would have is that if I make the sub usergroups secondary, then the rank that is assigned to them would not be displayed due to that pesky "primary usergroup only" issue. :ermm:

See...I currently have a rank assigned for all levels of subscriptions so that a pretty Silver or Gold Ring is displayed in the members postbit. Seeing as we're a Lord of the Rings site, having a ring has been a pretty good incentive. :p

From what I can tell now...if VB would just enable the blasted ranks to work with secondary usergroups, ALL my problems will be solved! lol

And no worries about the expiry emails for now. I too am gratefull that you are taking this on and will wait patiently for the fix. :-)

[amykhar]

Actually, you can still show the rank if you use a template conditional. Do a check for is_member_of and display the titles based on that.

[Illuvatar]

Actually, you can still show the rank if you use a template conditional. Do a check for is_member_of and display the titles based on that.
Ya know....that's what I've been thinking! It has to be a real simple fix to pick up the secondaries, and I have even seen a post here before that it would be a simple if-then-else condition.

Thing is....I may be able to edit code and get a hack to work, but a coder I am not. lol

You don't suppose Ole Illu could trouble you for another bit of a teeny hack would ya? Just give me the code and tell me where to put it and I will good as gold! Oh...there are actually tons of folks here that would be ever so gratefull to you as well! :p

[cgjackson2001]

Hi,

I cant find this line of text in the includes/functions_subscriptions.php

function construct_payment($method, $cost, $currency, $subscriptionid, $title, $userinfo)
{
global $vboptions;

Can someone help me to find it, i'm using the latest version 3.07.

Thanks,
Chris

[Marco van Herwaarden]

You will find it on line:
362

[thenewuser]

Hello, very nice program and I thank you. I believe I installed it correctly and made the 1 line of code change that was needed for the new VB.

The problem I am having here is:

people are paying paypal, and not showing up as subscribed so right now I'm having to manually add 10-100 people a day which is killing me.

I have a group set up and everything, they just don't seem to be added to be able to view the forums. but when I use your "add user" feature then they can view the forums.

So for some reason the script is not adding them to the subscription group.

Any thoughts?

[amykhar]

It's more than one line in the new VB, and I saw the same problem today on my own site. Testing takes a while on these things because I have to wait for payments to trickle in. I'm going to look into it tomorrow.

[thenewuser]

It's more than one line in the new VB, and I saw the same problem today on my own site. Testing takes a while on these things because I have to wait for payments to trickle in. I'm going to look into it tomorrow.

Could you point me in the right direction? :)

[amykhar]

Could you point me in the right direction? :)
I have the correct replacement code in the install file. Several of the hidden variables changed in the newer version of vbulletin. I incorporated them into the hack, but haven't had time to really go over them. Also, I believe some things have changed on the paypal side since this hack was written. I need to wait until tomorrow when my brain is a little less groggy and dive into it in detail.

[amykhar]

OK. I've had some time to poke around and found the one line of code that was making the subscriptions not set up properly.

Remove this line from your functions_subscriptions.php



<input type=\"hidden\" name=\"ammount\" value=\"$cost\" />

[amykhar]

OK. Let's try this code to handle the emails going out that shouldn't be:

in your includes/cron/subscriptions.php file
Find:

user.languageid


Add after:

,subscription. reoccur


Find:
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = subscriptionlog.userid)

Add After:

LEFT JOIN " . TABLE_PREFIX . "subscription AS subscription ON (subscription.subscriptionid = subscriptionlog.subscriptionid)


Find:

vbmail_start();


Add Above:

if (!$subscriptions_reminder[reoccur]){


Find:

vbmail_end();


Add After:
}

I have not updated the install instructions yet because this code has not been thoroughly tested yet. Let me know how it works for you, please.

[oztrack]

I added the new code and it still is not adding new apid members properly even though they go through paypal. Paypal was processed OK as a subscription payment.

[amykhar]

Well, at least that's a step forward. The problem with adding people properly is NOT a problem with the hack. I've had this problem with subscriptions since they were first released. All Jelsoft ever says to me is "it works for me"

So, over the next few days, I am going to dive into Jelsoft code and see if I can't get it working. If possible, can some of you pm me and volunteer to sign up for a one month membership to my site for testing purposes at times I ask you to? I can refund the payment, but am unable to pay myself. (I don't have a second bank account to use to set up a test paypal account)

[aggiefan]

I was wondering...does this install work now without the problems? Where does it stand? I'm about to launch my new board (and recurring payments) would be very awesome....I just don't have time or the man power to manually adjust people.

Can anybody update this?

[amykhar]

The hack, as it is, installs fine. And, it sets up the recurring subscriptions fine. What isn't working right is something that isn't working right with subscriptions in general - even without the hack installed. Some times, payments don't process and subscriptions aren't added or updated.

[Romeos Tune]

This will be great when it's working properly.... When I go to my ACP and test communication I get this error:

cURL Fail
Streams Pass

Whatever cURL is it's showing that it fails. I haven't had anyone sign up yet so it's untested...It takes them to the paypal page to sign up for the right amount but like I said.... It's untested. Can I ignore this or is it going to cause problems and what exactly is the problem? Thanks!

[twoseven]

curl is another set of libs for php and it isnt necessary just makes it nice

[Romeos Tune]

hmmmm, well it's definitely not working properly... I've had several people sign up with paypal but it's not changing their usergroup. I'm having to manually go in and add them to the subscriptions. Anyone have any ideas??

[amykhar]

Romeos, as I said before, that could be the problem with the stock vbulletin subscriptions. I have had problems with those ever since vbulletin 3 was in beta.

Make sure the paypal recurring subscription was set up and make sure you made the changes to the paypal.php file. If you did the paypal.php changes, you are probably seeing the same problem many of us see with subscriptions in general.

[Romeos Tune]

Alrighty then..... Thanks Amy..... I guess I'll just have to wait 'til VB gets it fixed.... If anyone figures out the error or problem I hope they let us know........ :)

[Lee]

Alrighty then..... Thanks Amy..... I guess I'll just have to wait 'til VB gets it fixed.... If anyone figures out the error or problem I hope they let us know........ :)
Amy,

I am happy to help trouble shoot this if you'd like. I have two paypal accounts to test with if need be. Let me know if I can help - I have installed the hack successfully and also just got through updating your page 12 update for the email fix.

Thanks!

[amykhar]

Thanks for the offer :) I've read the stock subscription code several times and am not seeing any clear problems. I am starting to wonder if it's a sporadic issue on the pay-pal side.

[Lee]

Thanks for the offer :) I've read the stock subscription code several times and am not seeing any clear problems. I am starting to wonder if it's a sporadic issue on the pay-pal side.
I am not sure, but I just got a few subscriptions in and it didn't put them in the new usergroup...I had to do it manually...:)

[amykhar]

speedpro - email me your paypal.php file please. If none of them are working for you, I have to wonder if you got the changes in correctly.

[Xtrm2Matt]

Hi all,

I'm wondering if its possible to add a small addition to this mod? When the renew is due (a few days before and possibly on the day), it emails the user informing them what will happen?

Cheers,
Matt (using 3.0.3 btw)

[amykhar]

That's built into 3.0.7. If you don't want to upgrade your entire board, just get the new code and make the necessary changes to the subscriptions related files.

In addition, that wouldn't be an add-on for this hack. That would be a separate hack of its own. Given the issues this hack has had in the past and the problems some people have with subscriptions in general, I'm not sure this thread is the best place to discuss added subscription features.

[Erwin]

I've been using this hack ever since it came out and never had a complaint so far. :)

[amykhar]

Erwin, the problems I've had have never been with this hack per-say. It's with the paypal subscriptions themselves, even unhacked. Since I started using VB3 beta, a significant percentage of subscriptions never process - and that's with stock vbulletin. I'm not the only one with this problem, but it's been ignored for more than a year now by Jelsoft.

[Xtrm2Matt]

Erwin, the problems I've had have never been with this hack per-say. It's with the paypal subscriptions themselves, even unhacked. Since I started using VB3 beta, a significant percentage of subscriptions never process - and that's with stock vbulletin. I'm not the only one with this problem, but it's been ignored for more than a year now by Jelsoft.

That's PayPal's side. If that happens once, or twice, re-add your URL that it uses thingy-ma-jick in the PayPal Options.

On a side note, I'm asking for a quick feature!

Subscription Terms:
$9.99 USD for each month
Item Name:
<SUBSCRIPTION NAME>
Item Number:
2_395
Postal Address:

No Address Provided

Unlike the "basic" subscription (unedited basically) that already comes with vBulletin, it puts in the users forum name in this area. Could you add this to the mod please? If not, I have to rely on them using the same email address for their PayPal + Forum Account and not everyone does that.

And as stated above, if the account is changed by the forum, I then have to ask publically who sent me the money and thats a bit of a breach of privacy!

Cheers if someone can understand my request :up: :cool:

Matt


== edit ==

This is what I mean, this is the unedited subscription mail from paypal:

Item Title:
<SUBSCRIPTION NAME>
Item Number:
2_358
Custom:
<FORUM NAME>

[amykhar]

Somebody already released what you are asking for. Do a search and you should find it.

[Erwin]

Erwin, the problems I've had have never been with this hack per-say. It's with the paypal subscriptions themselves, even unhacked. Since I started using VB3 beta, a significant percentage of subscriptions never process - and that's with stock vbulletin. I'm not the only one with this problem, but it's been ignored for more than a year now by Jelsoft.
It's probably to do with your server/ host communicating with the Paypal IPN.

My site has never had a single Paypal subscription problem, except for when it so happens that my webservers are down for maintenance.

[whatthehell]

Is there anyone available to help install this update?

I am a complete noob and have to say dont really understand the instructions

Especially- Run the following SQL-query

:( Really would like the update though

[amykhar]

Is there anyone available to help install this update?

I am a complete noob and have to say dont really understand the instructions

Especially- Run the following SQL-query

:( Really would like the update though
https://vborg.vbsupport.ru/showthread.php?t=39142

[whatthehell]

Thanks that is perfect :)

[Storage Guy]

https://vborg.vbsupport.ru/showthread.php?t=39142

you can run execute SQL queries in 3.0.7 from AdminCP > Import & Maintenance.

I'm about to install... see how it goes with a test subscription, recurring every 2 days for a dollar.

My damn vB isn't sending registration e-mails right now.. POS.

[Storage Guy]

Amy, can ask you how to do this:

https://vborg.vbsupport.ru/showthread.php?p=650220#post650220

I can't find any access masks specific enough! Thank you!

[amykhar]

Create a usergroup with the permissions that you want your paid members to have.
Change the permissions of your registered usergroup so that they can't see the threads, posts, etc.
In your navbar template, do a conditional to show a link to subscribe to your registered usergroup. After they subscribe, promote them to the new usergroup with access.

Making this work is going to hinge on how good you are with template edits and such so that you make it clear to your users what they need to do to see your content.

I would also edit the template that users see immediately after they register. The screen should inform them that the final step is to pay up.

But, this bit of advice is off topic for this thread. Please post your future questions in the other thread so that others may help you as well.

[mfarmerhi]

Curious if the reoccurring Email reminders problem was solved?

[amykhar]

Reocurring email reminders was not a problem with this hack as far as I know. What was solved is that it stopped emailing people who have pay-pal subscriptions which automatically renew.

Make sure you didn't change the frequency that the subscriptions cron job runs. If you did, your subscribers will get multiple emails.

[mfarmerhi]

Yea Amy, that was what I was asking.

So, I was looking at the coding and it looks like it would be relatively easy to add in trial periods (PayPal allows for up to 2). You'd just need another 2 variables (trial period 1 and trial period 2 -- you can enter -0- if you don't want trial periods) and this hack would offer ALL the functionality PayPal offers...

Has anyone else added in trial periods?

[kmike]

I noticed the notification url form field is missing from this hack:

<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />

Is it deliberate? It causes vB to not perform any action after payment has been made, if there were some actions set (such as usergroup change and forum permissions updates).

[amykhar]

I noticed the notification url form field is missing from this hack:

<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />

Is it deliberate? It causes vB to not perform any action after payment has been made, if there were some actions set (such as usergroup change and forum permissions updates).
The return doesn't do what you think it does. To make the actions happen, you have to set up your ipn url at paypal, as per the instructions in the subscriptions system.

[nexialys]

"notify_url" is for the paypal verification script to send a notice to vbulletin and say if the payment is done or refused...

"return" is the one to send you back to page X... if you want to modify that url so users are taken back to a thanks page of some sort, you can do that with THAT input.

[kmike]

IPN setup isn't available for all types of PayPal accounts.
Specifying notify_url at the form submission time is a more compatible way for notifications to work, and in fact vB itself does submit it, so I see no valid reasons of the field removal in this hack.

[mfarmerhi]

IPN setup isn't available for all types of PayPal accounts.
Specifying notify_url at the form submission time is a more compatible way for notifications to work, and in fact vB itself does submit it, so I see no valid reasons of the field removal in this hack.
A question regarding trial periods: It appears that this hack uses straight forward PayPal code (the same that would be provided by PayPal if one were to enter the prices and product info through their code generator).

Is there any reason why you can't simply generate the code from PayPal, including trial periods, and paste it in the appropriate places in this hack?

Seems to me this hack would easily allow for trial periods (e.g. 1 week for $5, then $10/mo there after).

[amykhar]

IPN setup isn't available for all types of PayPal accounts.
Specifying notify_url at the form submission time is a more compatible way for notifications to work, and in fact vB itself does submit it, so I see no valid reasons of the field removal in this hack.
Have you tried using the subscription service without this hack and without ipn? I don't believe it works for you because the subscription code is looking for specific variables passed back by the IPN.

[kmike]

Yes, subscriptions worked nicely before this hack installation.

This is taken from one of the numerous manuals on PayPal integration:

Alternatively, you can activate IPN by including the notify_url field in your PayPal
button. This field specifies the URL of a script that can process the IPN.

This is from Business::PayPal::IPN perl package man page:

PAYPAL IPN OVERVIEW

As soon as you receive payment to your PayPal account, PayPal posts the transaction details to your specified URL, which you either configure in your PayPal preferences, or in your HTML forms' "notify_url" hidden field.

[amykhar]

To replace the notify url line, simply go to includes/functions_subscriptions.php and find (2 time)

<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]\" />

Add After:

<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />


BUT. I'm NOT going to guarantee that when subscriptions are renewed that they will be processed correctly if you use the notify url in there rather than the IPN. Unless you are not using IPN, I would leave the hack installed as before, which we knew worked.

It may work fine with the notify url, but if it ain't broke for you, I don't suggest that you "fix" it by adding in the notify url.

Amy

[concreteweb]

Have you tried using the subscription service without this hack and without ipn? I don't believe it works for you because the subscription code is looking for specific variables passed back by the IPN.

Hi Amy,

Same thing happened for us. Successfully using the subscription service for about a year. Did your mod last week - the subscription works up to a point - it connects with PayPal, sends us an email and the customer an email - but now it does not update the account on our forum.

I've tried out the code above - doesn't make a difference. We are running the 3.0.3 (patched for the security bugs.)

This is the first time I've had a problem with a mod. :ermm:

[amykhar]

As I said, I can't guarantee that it will. The reoccurring subscriptions are sending back specific ipn variables that I just don't believe would be sent the other way. I haven't had a chance to look at vbulletin 3.5 yet to see what it offers in subscriptions. It may be a moot point if it handles recurring subscriptions out of the box.

Amy

[concreteweb]

The hack, as it is, installs fine. And, it sets up the recurring subscriptions fine. What isn't working right is something that isn't working right with subscriptions in general - even without the hack installed. Some times, payments don't process and subscriptions aren't added or updated.

We've had some time to test all of our subscriptions.

Here's an update from my earlier message today.

1. All of our regular non-recurring subscriptions work fine - everyone gets their account updated a.o.k.

2. None of the recurring subscriptions get their accounts updated.

It sure looks like this is an issue with the mod since standard subs work like a charm.

Comments anyone?

[amykhar]

We've had some time to test all of our subscriptions.

Here's an update from my earlier message today.

1. All of our regular non-recurring subscriptions work fine - everyone gets their account updated a.o.k.

2. None of the recurring subscriptions get their accounts updated.

It sure looks like this is an issue with the mod since standard subs work like a charm.

Comments anyone?
Are you using IPN or are you using the notify url? I don't think this hack works if you haven't set up IPN.
Have you followed all of the hack's directions? You may have missed the file changes to paypal.php. If you did, it won't recognize the new IPN variables.
I am not using 3.0.3 and can't test on that platform.

[concreteweb]

Are you using IPN or are you using the notify url? I don't think this hack works if you haven't set up IPN.
Have you followed all of the hack's directions? You may have missed the file changes to paypal.php. If you did, it won't recognize the new IPN variables.
I am not using 3.0.3 and can't test on that platform.

Yes, we are using IPN. Checked and double-checked the install files - including paypal.php.

Strange indeed. This underscores the weakness of the current vbulletin software with all the variations between the different versions.

I hope 3.5 will get us to some kind of mod stability.

[fashunphotog]

Hey! I'm interested in this hack but I'd like to know first if it will allow me to set up a free period of say 90days and then begin charging the appropriate fee from that point on?

If not, anyone know of any hacks that will allow that?

Thanks for whatever info you can supply,

FaShUnPhOtOg

[amykhar]

No. It doesn't have the free period, fashun. I don't know if there is a hack that does.

Amy

[fashunphotog]

I noticed after I posted my reply/question that insanctus, in a later post, indicated s/he (gender unknown to me, sorry), had actually coded that option but had not decided how it should look so had not released it yet.

I'm wondering now if s/he has since released it and I haven't found it yet? If not, would Insanctus please release what s/he has and let us worry about how it looks to our end users? Perhaps one of us can make suggestions after we see it in action?

FaShUnPhOtOg

[amykhar]

Insanctus no longer posts here. And he's a he. ;)

Amy

[fashunphotog]

well, hmph! we need this option rather quickly.... I was hoping he (thank you for that ;) would be willing to supply it. Would it be a difficult hack do you think? Do you know anyone willing to code it? (Hint, hint, "wink, wink, nudge, nudge, know what ah mean, guvnor?")

FaShUnPhOtOg
aka Michael

[Anarchy]

Romeos, as I said before, that could be the problem with the stock vbulletin subscriptions. I have had problems with those ever since vbulletin 3 was in beta.

Make sure the paypal recurring subscription was set up and make sure you made the changes to the paypal.php file. If you did the paypal.php changes, you are probably seeing the same problem many of us see with subscriptions in general.

This script works perfect on 3.0.6 so its a change from .6 to .7

Im using it for hundreds of subs on a .6 board and it won't work on my .7 boards

[amykhar]

I am using .7 and it works just fine for me.

[bchertov]

Hi,

I am considering installing this hack for my 3.0.6 board.

Do the same install insructions apply to 3.0.6?

ALSO, is there a provision for the price to change on the recurring charge - say the price goes up after an introductory special?

Thanks!
Barry

[amykhar]

Hi,

I am considering installing this hack for my 3.0.6 board.

Do the same install insructions apply to 3.0.6?

ALSO, is there a provision for the price to change on the recurring charge - say the price goes up after an introductory special?

Thanks!
Barry
Yes, it should work on 3.0.6

No. There is nothing to regulate price changes. You would have to go to paypal and unsubscribe your users and have them resubscribe.

[sub_ubi]

Anyone up for porting a bunch of old "reocurring" subscriptions to 3.5? The new payment system is much better, so having both work at the same time would be wonderful. Old people keep their subscriptions, new people sign up with the new system.

[Anarchy]

I'm having trouble now with both my forums and they were working fine. Did paypal change the way it sends back its info?

Its making the subscription, but not adding the subscription to the subscriptions in vbulletin.

[amykhar]

I've upgraded to 3.5 and am no longer running this mod. So, I'm honestly not sure if anything has changed on the paypal side.

Is anybody else having problems?

[sunnycher]

This thread is very confusing.
I am running VB 3.07 and VBA 1.0
so the paypal subscriptions I have set up (without this hack) are not going to automatically renew? BUT they will get a notice that their subscription is getting ready to expire though, right? And they have the option of renewing.

BUT, with this hack, it will automatically do it for them? Mine are annually.
also, when it automatically renews it, does it do it at the CURRENT rate or the rate they paid a year ago?

Thanks for helping me understand!

[Q-v-n-s-Q]

I'm having trouble now with both my forums and they were working fine. Did paypal change the way it sends back its info?

Its making the subscription, but not adding the subscription to the subscriptions in vbulletin.
i have the same problem too, when i install this hack work perfect , but i have to add new members subscription manually.

* wondering is there anyway to fix it?? im running vb 3.0.7 ** thanks

[kmike]

I, too, had to uninstall this hack because of missing PayPal callbacks. Not sure if it ever worked for us.

[sunnycher]

any answers on this?

This thread is very confusing.
I am running VB 3.07 and VBA 1.0
so the paypal subscriptions I have set up (without this hack) are not going to automatically renew? BUT they will get a notice that their subscription is getting ready to expire though, right? And they have the option of renewing.

BUT, with this hack, it will automatically do it for them? Mine are annually.
also, when it automatically renews it, does it do it at the CURRENT rate or the rate they paid a year ago?

Thanks for helping me understand!

[Apophis]

Anyone up for porting a bunch of old "reocurring" subscriptions to 3.5? The new payment system is much better, so having both work at the same time would be wonderful. Old people keep their subscriptions, new people sign up with the new system.

I started a thread in the 3.5 Modification Request Forums that addresses this very issue. I'm willing to pay a coder to pull this one off for me.

https://vborg.vbsupport.ru/showthread.php?t=94843

It will be near impossible for me to get all of my subscribed members to cancel and resubscribe through the new system so I would love a way to be able to upgrade to 3.5 while maintaining backwards compatibility with 3.0.7.

[Apophis]

Has anyone managed to work out a vBulletin 3.5.0 backwards compatible hack yet? My offer still stands, if anyone can develop this, I will certainly be willing to pay for your efforts!

[ashley53680]

I would love this for 3.5!

[contemptx]

anyone managed to get this working or is this hacknow dead and we dont have a recurring payment hack for 3.0.x?

it would be great to get this hack working as i find 3.5 hogs cpu usage.

[mfarmerhi]

anyone managed to get this working or is this hacknow dead and we dont have a recurring payment hack for 3.0.x?

it would be great to get this hack working as i find 3.5 hogs cpu usage.

For 3.0.x versions, I believe there's an error in the instructions for Step #3 Open includes/functions_subscriptions.php

I believe it should read:

case 'paypal':
$form['action'] = 'https://www.paypal.com/cgi-bin/webscr';
$form['method'] = 'post';
/// Add In For Reacuring Payments
$paypalextra = $DB_site->query_first("SELECT * FROM " . TABLE_PREFIX . "subscription AS subscription WHERE subscriptionid=$subscriptionid");
if($paypalextra[reoccur]==0){// It is one time
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"amount\" value=\"$cost\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"shipping\" value=\"0.00\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]/$vboptions[forumhome].php\" />
<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />
<input type=\"hidden\" name=\"custom\" value=\"$userinfo[username]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";

}else{
$form['hiddenfields'] = "
<input type=\"hidden\" name=\"cmd\" value=\"_xclick-subscriptions\" />
<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
<input type=\"hidden\" name=\"a3\" value=\"$cost\" />
<input type=\"hidden\" name=\"p3\" value=\"$paypalextra[length]\">
<input type=\"hidden\" name=\"t3\" value=\"$paypalextra[units]\">
<input type=\"hidden\" name=\"src\" value=\"1\">
<input type=\"hidden\" name=\"sra\" value=\"1\">
<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]\" />
<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />
<input type=\"hidden\" name=\"custom\" value=\"$userinfo[username]\" />
<input type=\"hidden\" name=\"no_note\" value=\"1\" />";

}
break;


As it was written, non-reoccurring subscriptions were not being updated by vB for Paypal users not using IPN; and subscriber were charged shipping. Further, as it was written Emails to the Admin didn't include the subscriber's names.

The updated code was taken directly from vB's original coding and, for the life of me, I can't see why it would have been changed in the if/else statement. The if/else statement takes care of non-reoccurring/reoccurring, but the coding for non-reoccurring should remain the same in either the hacked version or the non-hacked version. (Hope that makes sense...)

~ Mark

[mfarmerhi]

I'd like to ensure that this thread is linked to this thread discussing what the heck to do if you decide later to raise prices: https://vborg.vbsupport.ru/showthread.php?t=73419

If you raise prices after installing the reoccurring hack, you'll have problems with everyone's subscription who subscribed BEFORE the price raise: because their auto subscription payments no longer match the new price, their subscriptions will fail, requiring them to re-subscribe.

In that linked thread I describe a down and dirty hack to prevent some of the problems.