Show icon if user has Profile Picture

[TechGuy]

What does this do?
Basically, when viewing a thread, if a user has a Profile Picture, it will show a camera icon (or whatever picture you choose) next to his/her online status icon. For example:
https://vborg.vbsupport.ru/attachment.php?attachmentid=17973

How to do this hack:
Download the instructions! (https://vborg.vbsupport.ru/attachment.php?attachmentid=19447)

Updates!
July 1, 2004: I finally got around to re-writting this a bit so that you don't have a query for every post in every thread. However, after you install this, you'll notice that the first time you view a thread there will be a ton of queries. That will happen until we've essentially cached each user's "haspic" status in the user table... meaning that, in the end, this should be a lot nicer than the last version. :)

[Boofo]

Nice idea but this adds a query for every post on the page. If you have 15 posts, the page will show 15 extra queries whether the user has a profile pic or not. You might want to rework the code a bit to have it only add 1 query per page. ;)

[TechGuy]

Yeah, I know -- maybe someone around here will be smart enough to do that. ;)

[Boofo]

Put it above the loop for the postbit and declare the globals in the loop. ;)

[pixelpunk]

Put it above the loop for the postbit and declare the globals in the loop. ;)


Will this decrease the queries? If so please show us where, I'd love to use this hack!

[Alien]

Anyone get this to work right, with just 1 query per page? I'd appreciate the instructions too...

[FutureDEV]

Anyone? Pretty please?? ;)

[Alien]

I hope someone updates this, as it's an excellent little add-on...

[Polo]

I agree.

if 1 query per page = I install

lol

[Dean C]

It'd probably be easier to add a field to the user table for this :) That way no extra queries other than when updating the profile picture :)

[Erwin]

You can do this without any queries whatsoever. There's another hack somewhere that does the same without a query - just add the variable to an existing query.

[Alien]

I haven't been able to locate this, any pointers? :(

I'd really like to get this one up.

[TechGuy]

I don't know how to do anything with no queries... ? But, I'm no expert. The only way I can think to do this with only one query would be to add a field to the user table, but I didn't want to worry with those who have already uploaded a pic, though it'd certainly be possible. Maybe I'll play around with it a bit.

[Polo]

You can do this without any queries whatsoever. There's another hack somewhere that does the same without a query - just add the variable to an existing query.

can you give us the link? :ermm: :squareeyed: :rolleyes: :)

[Alien]

Please. :)

[TechGuy]

I think I've got it working. :)

[Alien]

What did you come up with? :)

If it just adds one query total (or even 0) to each page I'd be thrilled!

[TechGuy]

It's included with the user query now -- check it out!

[Andreas]

Nice one, but let me suggest an optimization (this is how I did it some weeks ago):

In showthread.php FIND

post_parsed.pagetext_html, post_parsed.hasimages,


BELOW that ADD

NOT ISNULL(customprofilepic.userid) AS haspic,


Further down in showthread.php FIND

LEFT JOIN " . TABLE_PREFIX . "post_parsed AS post_parsed ON(post_parsed.postid = post.postid)


BELOW that ADD

LEFT JOIN " . TABLE_PREFIX . "customprofilepic AS customprofilepic ON(customprofilepic.userid=post.userid)


And use this template modification:

In template postbit FIND

$post[onlinestatus]


BELOW that ADD

<if condition="$post['haspic']"><img src="/photo.gif" border=0 alt="Photo in Profile!"></if>


That's it. This way you don't have to alter table user, file profile.php and functions_showthread.php.
You also might want to extend this for single post display and PM ;)

[Boofo]

Nice one, but let me suggest an optimization (this is how I did it some weeks ago):

In showthread.php FIND

post_parsed.pagetext_html, post_parsed.hasimages,


BELOW that ADD

NOT ISNULL(customprofilepic.userid) AS haspic,


Further down in showthread.php FIND

LEFT JOIN " . TABLE_PREFIX . "post_parsed AS post_parsed ON(post_parsed.postid = post.postid)


BELOW that ADD

LEFT JOIN " . TABLE_PREFIX . "customprofilepic ON(customprofilepic.userid=post.userid)


And use this template modification:

In template postbit FIND

$post[onlinestatus]


BELOW that ADD

<if condition="$post['haspic']"><img src="/photo.gif" border=0 alt="Photo in Profile!"></if>


That's it. This way you don't have to alter table user, file profile.php and functions_showthread.php.
You also might want to extend this for single post display and PM ;)
Do we need to do this in the posts AND the caheposts queries?

[Andreas]

Yes. Posts is for linear mode, chacheposts is for hybrid and threaded mode.

But I only tested in linear mode so far ... don't know if this does work in other modes.

[Boofo]

Yes. Posts is for linear mode, chacheposts is for hybrid and threaded mode.

But I only tested in linear mode so far ... don't know if this does work in other modes.
I installed it in both queries. I'll test it out for hybrid and threaded and let you know. Thanks.

[y2krazy]

/me clicks install!

[SIINSI]

* y2krazy clicks install!
For some reason I get a parse error on this line...

{$mjctemp = $DB_site->query_first("SELECT count(*) AS count FROM " . TABLE_PREFIX . "customprofilepic WHERE userid=" . $pos$

Miguel

[Chazz Layne]

Getting the same problem here... happened right after upgrading to 3.0.5 from 3.0.1.

Edit - just tried the other method posted by Kirby, which seems to do absolutely nothing on Threaded mode (the only mode our forum uses). :ermm:

/me begins uninstalling hack. :tired:

[Andreas]

Hmm, I haven't upgraded to 3.0.5 yet (currently 3.0.3) but I don't see why the code I sposted shouldn't work.

Did you modify both queries?

[DR?@M W?@V?R]

For some reason I get a parse error on this line...

{$mjctemp = $DB_site->query_first("SELECT count(*) AS count FROM " . TABLE_PREFIX . "customprofilepic WHERE userid=" . $pos$

Miguel

same here as well, also the code changes for profile.php are different for 3.0.5.

[DR?@M W?@V?R]

Nice one, but let me suggest an optimization (this is how I did it some weeks ago):

In showthread.php FIND

post_parsed.pagetext_html, post_parsed.hasimages,


BELOW that ADD

NOT ISNULL(customprofilepic.userid) AS haspic,


Further down in showthread.php FIND

LEFT JOIN " . TABLE_PREFIX . "post_parsed AS post_parsed ON(post_parsed.postid = post.postid)


BELOW that ADD

LEFT JOIN " . TABLE_PREFIX . "customprofilepic AS customprofilepic ON(customprofilepic.userid=post.userid)


And use this template modification:

In template postbit FIND

$post[onlinestatus]


BELOW that ADD

<if condition="$post['haspic']"><img src="/photo.gif" border=0 alt="Photo in Profile!"></if>


That's it. This way you don't have to alter table user, file profile.php and functions_showthread.php.
You also might want to extend this for single post display and PM ;)

Thanks for that it works on 3.0.5 in all display modes :)

I added this code to the image link.

<if condition="$post['haspic']"><a href="image.php?u=$post[userid]&amp;type=profile"><img src="$stylevar[imgdir_misc]/photo.gif" align="absmiddle" border="0" alt="$post[musername] Has A Photo Click Here To View"></a></if>

I would like to add a 100x100 pop up window to show the image, if anyone could help out.

[DR?@M W?@V?R]

Sorted.



<if condition="$post['haspic']"><a href="image.php?u=$post[userid]&amp;type=profile" onclick="window.open('image.php?u=$post[userid]&amp;type=profile', 'popup', 'statusbar=no,menubar=no,scrollbars=no,resizable=n o,width=110,height=110'); return false"><img src="$stylevar[imgdir_misc]/photo.gif" align="absmiddle" border=0 alt="$post[musername] Has A Photo Click Here To View"></a></if>

[MorrisMcD]

I was going to install this but when I got to the profile.php, I noticed the code was different.. So I decided to abandon...

I did already run the query though.. What command would I run to reverse that?

Or, is there a set of instructions on a fresh install on 3.0.5?

Thanks

[DR?@M W?@V?R]

I was going to install this but when I got to the profile.php, I noticed the code was different.. So I decided to abandon...

I did already run the query though.. What command would I run to reverse that?

Or, is there a set of instructions on a fresh install on 3.0.5?

Thanks

If you read KirbyDE post for the the optimized version all you need to edit is showthread.php and thats it done.

[MorrisMcD]

If you read KirbyDE post for the the optimized version all you need to edit is showthread.php and thats it done.
I saw that but I noticed that

LEFT JOIN " . TABLE_PREFIX . "post_parsed AS post_parsed ON(post_parsed.postid = post.postid)

exists twice in my showthread.php

Should I add

LEFT JOIN " . TABLE_PREFIX . "customprofilepic AS customprofilepic ON(customprofilepic.userid=post.userid)

below both instances?

Should I remove the queries I already installed? Sorry.. I dont know what the last few posts really meant, so that may answer my question, but not really since I am not sure what you all are talking about..

Thanks

[Andreas]

As already stated here (https://vborg.vbsupport.ru/showpost.php?p=529152&postcount=21) you must edit both queries.

[MorrisMcD]

As already stated here (https://vborg.vbsupport.ru/showpost.php?p=529152&postcount=21) you must edit both queries.
I thought that is what was meant, but I just wanted to check..

Thanks

[MorrisMcD]

Ok.. Got it working... Thanks for the help.. I am running 3.0.5 and with Kirby's instructions, all works well...

Although I think I am going to change the code to have the image located in the images directory rather than the root, which is where it must be by your code..

Thanks again

[Andreas]

Well, I just adapted this from the original hack.
You can palce the image whereever you want, just make sure you got the correct path in the IMG-Tag :)

[Alien]

Well, I just adapted this from the original hack.
You can palce the image whereever you want, just make sure you got the correct path in the IMG-Tag :)
Again, this is awesome.. Nice work..

Any way in the popup window version to get the photo to display centered and not left aligned whenever it pops up? Or have it be dynamic so that no matter what size the picture is it will adjust the pop to be that exact size? Just an asthetics idea..

[ninjaneo]

Looks like the current versoin you copied out of some vterm window from a shell of some kind... one of the lines is cut off.


######### OPEN includes/functions_showthread.php ########

## FIND:
$show['messageicon'] = iif($post['iconpath'], true, false);


## BELOW ADD:

// profile pic in thread
if ($post[haspic] == "" && isset($post['userid']))
{
$show['haspic']=false;
$mjctemp = $DB_site->query_first("SELECT count(*) AS count FROM " . TABLE_PREFIX . "customprofilepic WHERE userid=" . $pos$
if ($mjctemp[count]==1) {
$show['haspic']=true;
$DB_site->query("UPDATE " . TABLE_PREFIX . "user SET haspic='1' WHERE userid = $post[userid]");
} else {
$DB_site->query("UPDATE " . TABLE_PREFIX . "user SET haspic='0' WHERE userid = $post[userid]");
}
} else {
if ($post[haspic]=="1")
{ $show['haspic']=true; }
else
{ $show['haspic']=false; }
}
// profile pic in thread

// SAVE & CLOSE includes/functions_showthread.php


* ninjaneo points to

$mjctemp = $DB_site->query_first("SELECT count(*) AS count FROM " . TABLE_PREFIX . "customprofilepic WHERE userid=" . $pos$

[HarryBO]

Nice Hack, but i became an parse error:

Parse error: parse error, unexpected '$' in /www/htdocs/v*****/includes/functions_showthread.php on line 1421

This is line 1421

$mjctemp = $DB_site->query_first("SELECT count(*) AS count FROM " . TABLE_PREFIX . "customprofilepic WHERE userid=" . $pos$

[Marco van Herwaarden]

Replace the line:
$mjctemp = $DB_site->query_first("SELECT count(*) AS count FROM " . TABLE_PREFIX . "customprofilepic WHERE userid=" . $pos$

with:
$mjctemp = $DB_site->query_first("SELECT count(*) AS count FROM " . TABLE_PREFIX . "customprofilepic WHERE userid=" . $post['userid']);