[VB3 RC3] Attachments in private messages

[T3MEDIA]

Ok works like a charm. Thank you. Only down side is the attachments stay. If I send a private message it should be on his/hers quota not mine. so if they want to keep it they can. also what if you want to send 3 differn people a picture of youself. you already have it saved on the site. so you cant re upload it. you have to delte your attachments. it should be a bit more seperate in that sense from forums.
Agreed. Can someone get a work around on this? Just have it put on that users quota and its fixed. Also maybe a cronjob to check to see if the user doesnt exist remove the PM.

This hack isnt finished if you think about it.
BUT what a nice idea. its like internal email now.

[dookie]

Is this hack working in 3.0.6?

[gemmagy]

I am brand new at this, I just got my database and tried to load this. I followed the directions very carefully. When I got to the part where I query I got the following error:

An error occurred while attempting to execute your query. The following information was returned.
error number: 1146
error desc: Table 'scribble_forum.pmtext' doesn't exist

my forum is completely down now. Please help me.
Gemma

[gemmagy]

I am brand new at this, I just got my database and tried to load this. I followed the directions very carefully. When I got to the part where I query I got the following error:

An error occurred while attempting to execute your query. The following information was returned.
error number: 1146
error desc: Table 'scribble_forum.pmtext' doesn't exist

my forum is completely down now. Please help me.
Gemma

One more thing to add. When I go to my database on the server the file pmtext is there but it's titled jelsoft_pmtext,,,, not scribble_forum.pmtext. Every file is titled that way, with the jelsoft in front of the files. Am i going to have this issue everytime i do a query?????

[gemmagy]

I tried to contact vbulletin to see if they could help me this is their answer:

It sounds like you are trying to install a resource from vBulletin.org. We do not give support for customizations as we aren't the author of that code. I suggest to contact the author of this resource. Ask him to update his code to take table prefixes into account. Your table prefix is jelsoft_ if I remember correctly.

please help!!!

[gemmagy]

I tried to contact vbulletin to see if they could help me this is their answer:

It sounds like you are trying to install a resource from vBulletin.org. We do not give support for customizations as we aren't the author of that code. I suggest to contact the author of this resource. Ask him to update his code to take table prefixes into account. Your table prefix is jelsoft_ if I remember correctly.


please help!!!

Here's the email I got from my database when one of the mods went into the GUI pm:

Database error in vBulletin 3.0.6:

Invalid SQL:
DELETE FROM jelsoft_attachment
WHERE postid = 0 AND private = 0 AND
dateline < 1108738351
mysql error: Unknown column 'private' in 'where clause'

mysql error number: 1054


and,,,,,,,,,,,,,,,,,,,,,

Database error in vBulletin 3.0.6:

Invalid SQL:
SELECT
pm.*, pmtext.*,
icon.title AS icontitle, icon.iconpath,
IF(ISNULL(pmreceipt.pmid), 0, 1) AS receipt, pmreceipt.readtime, pmreceipt.denied, attach
FROM jelsoft_pm AS pm
LEFT JOIN jelsoft_pmtext AS pmtext ON(pmtext.pmtextid = pm.pmtextid)
LEFT JOIN jelsoft_icon AS icon ON(icon.iconid = pmtext.iconid)
LEFT JOIN jelsoft_pmreceipt AS pmreceipt ON(pmreceipt.pmid = pm.pmid)
WHERE pm.userid=3 AND pm.pmid=128

mysql error: Unknown column 'attach' in 'field list'

mysql error number: 1054

[T3MEDIA]

Agreed. Can someone get a work around on this? Just have it put on that users quota and its fixed. Also maybe a cronjob to check to see if the user doesnt exist remove the PM.

This hack isnt finished if you think about it.
BUT what a nice idea. its like internal email now.bump?

[gemmagy]

Hi,

Can anyone please help me, my forum is down. Please see the other for posts I posted yesterday.

Please help!!
gemmagy

[gemmagy]

Bump!

Please read the previous four posts I posted.

Gemma

[BluPhoenix]

Maybe too late now but here goes..

in includes/cron/cleanup2.php find:
$attachments = $DB_site->query("
SELECT attachmentid, userid
FROM " . TABLE_PREFIX . "attachment
WHERE postid = 0 AND private = 0 AND
dateline < " . (TIMENOW - 3600)
);

and change it to:
$attachments = $DB_site->query("
SELECT attachmentid, userid
FROM " . TABLE_PREFIX . "attachment AS pmattach
WHERE pmattach.postid = 0 AND pmattach.private = 0 AND
pmattach.dateline < " . (TIMENOW - 3600)
);

[gemmagy]

Maybe too late now but here goes..

in includes/cron/cleanup2.php find:
$attachments = $DB_site->query("
SELECT attachmentid, userid
FROM " . TABLE_PREFIX . "attachment
WHERE postid = 0 AND private = 0 AND
dateline < " . (TIMENOW - 3600)
);

and change it to:
$attachments = $DB_site->query("
SELECT attachmentid, userid
FROM " . TABLE_PREFIX . "attachment AS pmattach
WHERE pmattach.postid = 0 AND pmattach.private = 0 AND
pmattach.dateline < " . (TIMENOW - 3600)
);

Thanks, I restored my forum back to wait for an answer. Will this take care of the naming of the tables? Support said I need to add a prefix to the name of the tables.

I really appreciate your help, I will give this a try in the next day or two.
gemmagy

[msimplay]

Maybe too late now but here goes..

in includes/cron/cleanup2.php find:
$attachments = $DB_site->query("
SELECT attachmentid, userid
FROM " . TABLE_PREFIX . "attachment
WHERE postid = 0 AND private = 0 AND
dateline < " . (TIMENOW - 3600)
);

and change it to:
$attachments = $DB_site->query("
SELECT attachmentid, userid
FROM " . TABLE_PREFIX . "attachment AS pmattach
WHERE pmattach.postid = 0 AND pmattach.private = 0 AND
pmattach.dateline < " . (TIMENOW - 3600)
);

would this work on vb3.0 ?

[paulomt1]

I had installed this hack in VB 3.0.7 but I have a problem!
When I click in the button Manage Attachments in new PM screen, opens the window for manage attachments but only say this:
Sorry! This forum is not accepting new posts.

Please help, I have lot's of PM with attachments and I need this working in this new version.

Thanks
Sorry my English.

[smess]

Does anyone have a clue as how to make this work for 3.0.3. I now have broken pictures and pm's that don't get attachements

[DivisionByZero]

I had installed this hack in VB 3.0.7 but I have a problem!
When I click in the button Manage Attachments in new PM screen, opens the window for manage attachments but only say this:
Sorry! This forum is not accepting new posts.

yeah me too... same error!

[DivisionByZero]

hello????

[josian]

Im using file system for attachments storage, how can I use this hack if the code is written only for db storage type?

Also, can I limit the extensions to be allowed in the PM? apart from the regular forum extensions.

thanks!!

[bkaul]

Hmm... looks like an interesting hack; I might try it if I see verification that it works in 3.0.7...

[jbell]

what would be the syntax to uninstall should I ever need to?

[paulomt1]

Anyone can fix this hack for working in vb 3.0.7?
I really need this one. I can pay for it.

Thanks
Thinking Games

[TouchStone]

Hello I has chops inserted and gets if I with PM a file to attach wants:

Apology, but in this forum no new contributions can be written.


Sorry for my bad English i'm a German User

Thanks for help

Text in German:
Hallo ich habe den HAck eingebaut und es geht auch soweit , nur wenn ich in den PM einen Anhang rein machen m?chte bekomme ich:

Entschuldigung, aber in diesem Forum k?nnen keine neuen Beitr?ge geschrieben werden.


Wo liegt der fehler?

Mfg

[TouchStone]

Hello I has chops inserted and gets if I with PM a file to attach wants:


Sorry for my bad English i'm a German User

Thanks for help

Text in German:
Hallo ich habe den HAck eingebaut und es geht auch soweit , nur wenn ich in den PM einen Anhang rein machen m?chte bekomme ich:


Wo liegt der fehler?

Mfg

Please I need Help?

[paulomt1]

My friend. Nobody will help you here.
I have requested help for this hack a few times and nobody reply.
Exist lots of coders that can help you make this hack working for version 3.0.7, but nobody help. It's true :-(

[TouchStone]

I do not find that good, if one makes sowas should it also to support give? What can one make, I have chop now already drinne and it can actually if one Coden can not much be?

[Marco van Herwaarden]

According to the the installation instructions (i hope you used the 3.0.3 version), you should made some modifications to your attachment.php file. Please check if those edits are done correct, pay special attention to the second and the third modification in that file. Or one of the modifications to newattachment.php could be wrong.

[TouchStone]

no I have the 3.0.7, have that the version and only am too late seen, but up to the error all.I thinks times some Coder the error goes fast for repairing could?

[Jagged Tooth]

I have complted the hack up to executing the query. When i try to run it get this error. Also I have no prefix for my tables.

An error occurred while attempting to execute your query. The following information was returned.
error number: 1064
error desc: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ';
ALTER TABLE pmtext add attach int not null;
ALTER TABLE attachment add index' at line 1

PHP Version: 4.3.10
mySQL version: 4.1.10a-standard
vBulletin Version: 3.07

Any help would be great.


--Jagged Tooth--

[Marco van Herwaarden]

If you are running the queries from your AdminCP, you can only run 1 statement at a time. A statement is ended by a semicolon ( ; ).

Execute 1 statement at a time.

[Jagged Tooth]

Thanks MarcoH64 got that working now. But now a new problem when I click the manage attachments button ig et this messege

Sorry! This forum is not accepting new posts.

Any ideas


--Jagged Tooth--

[paulomt1]

I have the same error.
Only a coder can help us, but nobody are interested :-(

[Marco van Herwaarden]

Don't keep me to it, but i will try to find some time tomorrow to do a test install and see if i can find your problems.

Feel free to bump me in 1 week if i didn't respond by then.

[paulomt1]

Thank you :-)

[altsounds]

Thanks MarcoH64 got that working now. But now a new problem when I click the manage attachments button ig et this messege



Any ideas


--Jagged Tooth--


I am also having this issue, anyone come up with a solution for this yet?

[Marco van Herwaarden]

Upgrade instructions for vB3.0.7 added to the hack.

[paulomt1]

Thank you very much for your help:-)

[Marco van Herwaarden]

Please give feedback, if this solve your problems.

[paulomt1]

Solve part of the problem.
Now when I attach a file I read this in the Manage Attachments window:
"This forum is not accepting new attachments"

Thanks

[Marco van Herwaarden]

Sorry i forgot to add 1 changes in the instructions (i hope i only forgot 1 ;))

Zip-File Updated, just do the last modification in the new instructions, and report back.

[paulomt1]

Work very well now :-)))

Thank you one more time

[Marco van Herwaarden]

No problem

[altsounds]

Yes thanks VERY much marco. Works like a charm.

[paulomt1]

I have a problem.
I can send attachs very well but I can download the attachments in PM.
Invalid Attachment specified. If you followed a valid link, please notify the webmaster

However if I sent a message to myself with an attachment I can download it without problems.

Anyone else has this problem?

[altsounds]

I'm experiencing the same as paulomt1 I just changed the attachments to not be in the database today. Be honest though I am not sure if it was or wasn't working b4. Either way could someone please help?

[altsounds]

This is the problem that we are having (after further testing). I can view my own attachments whether i send the link or they do. And vice versa. It's almost as if when the attachments are uploaded the wrong permissions are given??

Can anyone help?

[ssabmud]

I have this installed a VB303 and i have the quickreply hack instaaled to and the Attachments in private messages hack only shows up when you go to reply on the quickreply box.. It doent show up on new pms or if you go to the real reply or the forward pm page..

Can anyone help me with this as i have looked and looked trying to find what is cauing this to happen..

Ive add 2 pics one of the quickreply that shows the Attachments and on of the rest that dont show it..

[ssabmud]

any help here now?

[altsounds]

Anyone??

[DivisionByZero]

3.5.0? please? :)

[landry]

Hi!
Ver 3.0.8 can make Attachments in private messages?
Thanks!

[xfaethorx]

i've installed the hack onto 3.07

I have no problems with the sending of the attachment,that works fine.

however no attachment appears in the actuall message.

the attachment is there, if i go to manage attacments in the user cp it knows that i've got a pm with an attachment in it. but the message doesn't pick it up

i checked the code in private.php and im pretty certain its a fault in the showpm section of the code as it doesn't seem to pull the info from the database properly.

Has anyone fixed this, i really want to get this working!!!!

All help in resolving this appriciated.

[Icehawk002]

error occurs when running the instal queries says table db.attachment does not exist.

any help

do i need to prefix if so how

[xfaethorx]

you might not be logged into the correct db

make sure you've connected to the correct database

connect vbulletin ;

if vbulletin is the name of your database

then run the queries...bottom line make sure your on the right db!
:D

[xfaethorx]

ok further update to my issue I was having...Turns out i already had a private field in the database for attachments that was a tinyint i removed it and added the one required here and everything appears correctly in the post but now nothing will download.

in attachment.php i believe the postid is coming out as zero which in indicates that the user who uploaded the file isn't the person who is trying to view the file and therefore we have an error.

im wondering if its a newattachment issue or something? anyone have a solution?

[Icehawk002]

ok queries issue resolved, and everything appears in place following carrying out the upgrade instructions, however when a user attempts to attach a file and uplaod

the response 'This forum is not accepting new attachments'

any ideas?

[Icehawk002]

Ok I can attach file but as per xfaethorx post I just get a red cross box when the PM with attachment is viewed any help thanks

[xfaethorx]

icehawk002 - i've an idea what the problem is but its going to involve some recoding of the hack itself. I don't have the time to do it due to work commitments the best thing to do is unwind the hack as the author no longer seems to support it nor does the guy who made the alterations to this hack.

It needs someone else to pick up the development.

[Icehawk002]

I note that many have the almost identical problem in the "unsupported" hack version for 3.5 LOL https://vborg.vbsupport.ru/showthread.php?t=91220 but unfortunately the author does not appear to have resolved the issue there either.

Its a real shame if it cannot be corrected another add on that I would have like to have seen would be to specify user groups which can or cannot use PM attachments set in admin cp.

If someone can resolve the issue I would be willing to make a donation

[xfaethorx]

basically an assosiation needs to be created between the user who uploaded the image and the user who is to browse said image. However its not made in newattachment.php.

Thats why you get the error, if you send the message to yourself you'll see that it works fine.

One solution would be to alter the database AFTER the image has been uploaded so that when you submit the the PM it alters the database to change ownership of the attachment to the user it is being submitted to..

that would be a dirty fix but would also mean that the sender could no longer see said attachment in their attachment list or in the sent messages so should you want to get the message attachment back you couldn't.

Now if theres a way to have multiple owners of an attachment in this case then we've got the solution as all we need to do is add the destination user as the attachment owner and we'll have fixed this problem.

If I get any spare time I'll try my best to look at this but Its doubtful with my work load tbh.

[Icehawk002]

Yes, I agree sending a PM with attachment to oneself works fine.

As to the dirty fix or any other I am afraid its likely to be out of my league so I am hoping you or someone can resolve the matter.

I will however play and you never know and I take on board your thoughts.

I currently have the attachments stored in the database if these were transfered to be stored in a folder with relevant permissions might that help?

thanks