Page Numbers with Mod_Rewrite

[Ian Cunningham]

I have created a mod_rewrite hack for my site, and I can get the main thread to appear in the form thread-xxx.php (where xxx is the threadid). Example : http://www.pcreview.co.uk/thread-3930.php

I have a problem in the temlates when I want to call each new page thread-xxx-y.php (where y is the page number). I have coded this fine in Mod_Rewrite, but I can't find out how to mod this in the VB templates.

In the pagenav_pagelink template, there is the following code:

[b]<a href="$address&pagenumber=$curpage">$curpage</a>[b]

I want this changed to this format:

[b]<a href="thread-$thread[threadid]-$curpage">$curpage</a>[b]

I have tried using this code, but $thread[threadid] is not recognised. Can anyone tell me how to allow this to be called, or any other ideas? Once I have the mod_rewrite hack complete, I'll release it onto the forums. :)

[Dean C]

I had this exact same problem. In the end I decided just to leave the spider to index the first page only.

[Ian Cunningham]

Oh poo - I'll keep working on it, and I'll let you know here if I can get it working. If anyone has any ideas that would be great :)

[NTLDR]

The page nav templates are used in places other than threads which is why the variable isn't avalible. I'd take a look at functions.php (in particular the constuct_page_nav() function, and the information that is passed to the function in showthread.php for example.

[Ian Cunningham]

OK, I will take a look at that, but I am php novice, so I hope it is easy to understand :) Should it be simple to do?

[Ian Cunningham]

I've given it a go, but I cant find constuct_page_nav anywhere in the functions.php file (2.2.8)

[Dean C]

That's because Lee assumed you were using vB3 :) Look for getpagenav :)

[Ian Cunningham]

Cheers Dean! I found that section and tried adding $threadid into the "function getpagenav($results,$address) {" part, but I got an error. Would you be able to point me in the right direction?

[NTLDR]

You'd want to change it to somthing similar to:

function getpagenav($results,$address, $threadid = 0) {

and then in showthread.php modify the call to the function to pass the threadid across. Note the = 0 on the end which means it won't generate errors if you don't send a threadid for example on the members list.

[Ian Cunningham]

I do appologise for keeping asking you questions, I just can't get my head round this :) I have modified the line in functions.php which you told me, but I don't understand the showthread part.

Would I add something to this line in showthread.php?

"$pagenav = getpagenav($totalposts,"showthread.php?threadid=$threadid&perpage=$perpage".iif(isset($highlight), "&highlight=$highlight", ""));"

[Ian Cunningham]

I did it :) Thanks for your help guys :)

"$threadid= $thread[threadid];

$pagenav = getpagenav($totalposts,"showthread.php?threadid=$threadid&perpage=$perpage".iif(isset($highlight), "&highlight=$highlight", ""),$threadid);"

[Dean C]

Your welcome :) Btw you have a horizontal scrollbar at 800 X 600 res on your site :(

[Ian Cunningham]

Cheers Mist - I'll have to re-organise the width a little :)