PDA

View Full Version : MultiQuote


Chroder
01-04-2004, 10:00 PM
Introduction
This multiquote hack allows your members to select multiple posts to quote from. These posts can be on a different page, in a different thread, or on an entirely different forum. Don't worry, the hack checks to make sure the user has read permissions on the post so no sneaky members can insert random post ID's in hopes to find what's going on in your secret staff forums.

What's new in this "version 2"?


Better programmed!
"Go Advanced" works with Quick Reply
Fixed the bug with IE not "turning on" the MQ icons when re-viewing a thread with MQ'd posts.
Included vB3-styled icons (I just resized the images posted by Hoffi -- thanks Hoffi!)

Overview

vB files to modify: 1 (newreply.php)
Templates to modify: 2 (SHOWTHREAD, postbit)
Phrases to create: 1 (multiquote)
Files to upload: 3 (2 images, 1 Javascript file)
(Included missing Javascript file from post #75. Sorry for the delays, I don't come around often!)

BillaBongUSA
01-05-2004, 01:38 AM
Sweet, I'll download it and give it a try right now...

MGM
01-05-2004, 01:44 AM
sweeet, nice hack man, thanks for creating it!

is there a way to have the multiquote's show up in the Quick Reply though?

/me clicks install

Chroder
01-05-2004, 01:54 AM
Mabe on a click-to-click basis (ie. only the page the posts are on) but even that is a little over-the-top I think. 'Cuz you'll have all that text you'll be adding to the QR.

But I'm not the best at javascript -- mabe another guru will code it ;)

BillaBongUSA
01-05-2004, 01:55 AM
I just installed it with no problems at all, nice job. :) But shouldn't the multi-quote button be added into the postbit_legacy template as well?

Chroder
01-05-2004, 02:02 AM
It could... But I've got school tomorrow -- c'mon! :p I'll do it later perhaps, the HTML is the same (<img ...>).

Koutaru
01-05-2004, 02:32 AM
Nice :) I was waiting for this one! Will definately install ;) Thanks

mtellin
01-05-2004, 03:53 AM
great hack, I had been waiting for something like this :)

* mtellin clicks install

tomshawk
01-05-2004, 04:49 AM
Installed and works like a champ

Clicks install

;)

mtellin
01-05-2004, 04:55 AM
I already un-installed it without thinking, but I got a SQL error when I clicked the quote button, then unclick it and hit the post reply button...anyone else get this?

Chroder
01-05-2004, 05:17 AM
I already un-installed it without thinking, but I got a SQL error when I clicked the quote button, then unclick it and hit the post reply button...anyone else get this?
Your fast :p I was right in the middle of fixing it when you posted ;) Anyway, see first post and you can download the new file. Only the code in newreply.php was updated. (You'll see an 'updated' text next to it in the HTML instructions).

mtellin
01-05-2004, 05:41 AM
Your fast :p I was right in the middle of fixing it when you posted ;) Anyway, see first post and you can download the new file. Only the code in newreply.php was updated. (You'll see an 'updated' text next to it in the HTML instructions).
:) thanks, did the trick

NuclioN
01-05-2004, 09:00 AM
When quoting (after the updated file) and reply with quick reply another mysql error:

Database error in vBulletin 3.0.0 Release Candidate 1:

Invalid SQL: SELECT postid, username, pagetext FROM vb3_post WHERE postid IN(6566,6568) AND postid <> ORDER BY postid ASC
mysql error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY postid ASC' at line 1

mysql error number: 1064

Chroder
01-05-2004, 10:03 PM
Another update that deals with these things more cleanly. I'm working on an addition that'll allow the "go advance" in the QR to also have all the quotes.

Change the newreply.php code to the following:

//################################################## ##########################
//# START MULTI QUOTE #
//################################################## ##########################
if(isset($_COOKIE[COOKIE_PREFIX . 'mq']))
{
$pids = $_COOKIE[COOKIE_PREFIX . 'mq'];
$pids = urldecode($pids);

if(!empty($pids) && preg_match("/^[0-9,]+$/", $pids))
{
$mq_postid = (empty($_REQUEST['noquote']) ? "AND postid <> {$postinfo['postid']}" : '');

$q = $DB_site->query("SELECT postid, username, pagetext FROM ".TABLE_PREFIX."post WHERE postid IN($pids) $mq_postid ORDER BY postid ASC LIMIT 20");
while($row = $DB_site->fetch_array($q))
{
$originalposter = fetch_quote_username($row['username']);
$pagetext = htmlspecialchars_uni($row['pagetext']);
$pagetext = trim(strip_quotes($pagetext));
eval('$newpost[\'message\'] .= "' . fetch_template('newpost_quote', 1, 0) . '\n";');
}
}

setcookie(COOKIE_PREFIX . 'mq', '', time() - 3600, $vboptions['cookiepath'], $vboptions['cookiedomain']);
}
//################################################## ##########################
//# END MULTI QUOTE #
//################################################## ##########################

This should fix all mysql errors recieved above, on my test board it seemed to do fine :) It also now checks that the $pids is only numbers/commas so there are no tricky users trying to screw up the board.

[Updated file uploaded in first post]

mtellin
01-05-2004, 10:22 PM
I still get one error with this, when I click the multi quote button and then click go advanced I get this:

Database error in vBulletin 3.0.0 Release Candidate 1:

Invalid SQL: SELECT postid, username, pagetext FROM post WHERE postid IN(19123) AND postid <> ORDER BY postid ASC LIMIT 20
mysql error: You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY postid ASC LIMIT 20' at line 1

mysql error number: 1064

EDIT: looks like NuclioN already posted this

Chroder
01-05-2004, 11:43 PM
I can't recreate this problem on my localhost, so I asume this was prior to the Jan05-2 update? So its fixed -- correct?

mtellin
01-05-2004, 11:49 PM
I can't recreate this problem on my localhost, so I asume this was prior to the Jan05-2 update? So its fixed -- correct?
in my case it wasnt, thats with your latest version that you have :(

BillaBongUSA
01-06-2004, 12:01 AM
Yeah, I just updated everything with the new code that you just posted, and I'm getting the same error when I click on the "Go Advanced" button.

NuclioN
01-06-2004, 12:20 AM
The go advanced button is producing this error but after your last update the quick reply gives that error again. I hope you can fix it because this is a great addition. :)

Chroder
01-06-2004, 01:43 AM
Ok, clicking MQ button followed by a "Go Advanced" in the QR gives an error? I think I've found it, forgot a '!' on a line. But before I make an 'update' would someone please try it? :p

//################################################## ##########################
//# START MULTI QUOTE #
//################################################## ##########################
if(isset($_COOKIE[COOKIE_PREFIX . 'mq']))
{
$pids = $_COOKIE[COOKIE_PREFIX . 'mq'];
$pids = urldecode($pids);

if(!empty($pids) && preg_match("/^[0-9,]+$/", $pids))
{
$mq_postid = (!empty($_REQUEST['noquote']) ? "AND postid <> {$postinfo['postid']}" : '');

$q = $DB_site->query("SELECT postid, username, pagetext FROM ".TABLE_PREFIX."post WHERE postid IN($pids) $mq_postid ORDER BY postid ASC LIMIT 20");
while($row = $DB_site->fetch_array($q))
{
$originalposter = fetch_quote_username($row['username']);
$pagetext = htmlspecialchars_uni($row['pagetext']);
$pagetext = trim(strip_quotes($pagetext));
eval('$newpost[\'message\'] .= "' . fetch_template('newpost_quote', 1, 0) . '\n";');
}
}

setcookie(COOKIE_PREFIX . 'mq', '', time() - 3600, $vboptions['cookiepath'], $vboptions['cookiedomain']);
}
//################################################## ##########################
//# END MULTI QUOTE #
//################################################## ##########################

Sorry if even this doesn't work. Not thinking clearly today. :tired:

// edit. yep, the correct code..

mtellin
01-06-2004, 01:54 AM
I got a parse error when I tried that one, no matter what type of reply I tried

Chroder
01-06-2004, 02:03 AM
You sure you pasted it correctly? I've got the exact code and nothing is comeing up for me. Whats the error your getting?

BillaBongUSA
01-06-2004, 02:12 AM
That new code seems to work okay for me.

mtellin
01-06-2004, 02:20 AM
You sure you pasted it correctly? I've got the exact code and nothing is comeing up for me. Whats the error your getting?
Yup it was something completly unrelated that I messed up, wasnt your code and its working now

However for me if I click more than one to quote, and then click post reply, it only has one quoted (but I didnt get any errors when clicking one to quote then clicking go advanced)

BillaBongUSA
01-06-2004, 02:42 AM
Yeah, same here, but I think that that only happens when you try to quote the last reply in the thread. Any other reply that I try to quote works, but when I try to quote the last reply, it doesn't show up.

[Edit: I don't know if that was very clear... To clarify, if I select three posts to quote, they will all show up. But if one of those is the last post in the thread, only two will show up, and the last post in the thread is omitted.]

Zelda-King
01-06-2004, 03:52 PM
Yeah, I get a database error when using Quick Reply (which is important to fix as most people use Quick Reply). Same one as posted already;

Database error in vBulletin 3.0.0 Release Candidate 2:

Invalid SQL: SELECT postid, username, pagetext FROM post WHERE postid IN(19134) AND postid <> ORDER BY postid ASC LIMIT 20
mysql error: You have an error in your SQL syntax near 'ORDER BY postid ASC LIMIT 20' at line 1

mysql error number: 1064

Also, considering this works across threads and such, shouldn't the button for selected posts stay on? If you go back to a post on another page that you selected, the button turns off though the quote still works.

Chroder
01-06-2004, 06:57 PM
//################################################## ##########################
//# START MULTI QUOTE #
//################################################## ##########################
if(isset($_COOKIE[COOKIE_PREFIX . 'mq']))
{
$pids = $_COOKIE[COOKIE_PREFIX . 'mq'];
$pids = urldecode($pids);

if(!empty($pids) && preg_match("/^[0-9,]+$/", $pids))
{
if($_REQUEST['noquote'])
$mq_postid = '';
elseif(!empty($postinfo['postid']))
$mq_postid = "AND postid <> {$postinfo['postid']}";
else
$mq_postid = '';

$q = $DB_site->query("SELECT username, pagetext FROM ".TABLE_PREFIX."post WHERE postid IN($pids) $mq_postid ORDER BY postid ASC LIMIT 20");
while($row = $DB_site->fetch_array($q))
{
$originalposter = fetch_quote_username($row['username']);
$pagetext = htmlspecialchars_uni($row['pagetext']);
$pagetext = trim(strip_quotes($pagetext));
eval('$newpost[\'message\'] .= "' . fetch_template('newpost_quote', 1, 0) . '\n";');
}
}

setcookie(COOKIE_PREFIX . 'mq', '', time() - 3600, $vboptions['cookiepath'], $vboptions['cookiedomain']);
}
//################################################## ##########################
//# END MULTI QUOTE #
//################################################## ##########################


That should fix the last post not being included. I got screwed up because in RC2 (mabe RC1?) the template changed and the reply button actually replies to the _last_ post as to the first post. So I was having trouble reproducing the bug ;)

I'll update the main file with this code. The "go advanced" in the quick reply still doesn't show the quotes, though I'm working on it :)

Chroder
01-06-2004, 07:06 PM
Zelda-King -- I assume you were using the code from the file? I posted a fix to that above, but the main file is now updated.

Also, considering this works across threads and such, shouldn't the button for selected posts stay on? If you go back to a post on another page that you selected, the button turns off though the quote still works. It should be doing this already, that is the reason for the mq_init() function. Is anyone else not getting this functionality? Remember that the New Reply page, when loaded, will clear the cookie that has saved the posts you've selected. This is the intended action, because after they've been added to the message box they're not needed. Though the problem comes with the "go advanced" button in the QR that will not display the quotes but will still clear them.

BillaBongUSA
01-06-2004, 09:01 PM
Yeah, the button doesn't stay on for me cross-thread either.

Chroder
01-06-2004, 10:36 PM
Doh. Seems to only work in Moz. I'll look into that too.

Zelda-King
01-07-2004, 04:09 PM
Yeah, I'm using Internet Explorer 6. The database problem I had is fixed now I downloaded the Jan 6th update. I redid the hack from scratch just in case.

EDIT: Just to say, seeing as this hack requires postbit alterations, the button also shows in PMs and usernotes. It doesn't do anything of course, though I get errors on my usernotes page. ie, I get that alert "done but with errors on page".

Erwin
01-09-2004, 02:22 AM
Great hack. Should be made standard in vB3. :)

Erwin
01-09-2004, 02:24 AM
Yeah, I'm using Internet Explorer 6. The database problem I had is fixed now I downloaded the Jan 6th update. I redid the hack from scratch just in case.

EDIT: Just to say, seeing as this hack requires postbit alterations, the button also shows in PMs and usernotes. It doesn't do anything of course, though I get errors on my usernotes page. ie, I get that alert "done but with errors on page".
For a quick and dirty way to make it so that the button does not show up in PM or usernote, just wrap it with a conditional:

<if condition="$SHOWQUICKREPLY">button</if>

Zelda-King
01-09-2004, 07:41 AM
Oh yes! Why didn't I think of conditions? :/

Nice one! :)

NuclioN
01-09-2004, 09:31 AM
Where to add that code Erwin?

Erwin
01-09-2004, 09:32 AM
Where to add that code Erwin?
I haven't installed this hack, so I don't know exactly. Whatever the <img src=...> is for the button. :)

pie
01-09-2004, 11:56 AM
Doesnt work, I multi quote a few posts, click QUOTE MESSAGE IN REPLY. And no quotes appear

SnowBot
01-10-2004, 08:19 AM
How can we format it so it looks like the quotes on here? I mean the box around the quotes? :) so it looks nice and neat like vb.org's do and make a space between the quote box and the start of the users comment as now there is no line return.

Zelda-King
01-16-2004, 09:41 PM
The mq_script template needs caching in showthread.php to avoid one extra query.

Under 'im_yahoo',add'mq_script',

anabolicedge
01-17-2004, 06:11 PM
this isnt working for my site... ive read the instuctions a few time and re-did it all 3 times... i dont see no quick reply button or check box?? Can someone help.. here's my site

http://www.anabolicedge.net/forum

OmaniMan
01-20-2004, 05:14 PM
Really Great Hack ... Thanks Dear
I Installed It ...

Hoffi
01-21-2004, 09:43 PM
<font color="yellow">* Hoffi clicks Install.</font>

Works perfectly.

Oblivion Knight
01-23-2004, 01:45 PM
Awesome mod, though I'd be highly interested in using this for the quick reply box rather than the post new reply box.. :)

mharmon
02-05-2004, 03:31 AM
I love this hack -- but ever since I installed it -- Some users have been complainig of "Invalid Thread Specified" errors occurring when they reply to messages.

I've attached a screen shot. Could this have anything to do with hack? I haven't done anything else to newreply.php

catocom2
02-07-2004, 02:18 AM
I've just upgraded to RC4, and have the quickreply in pm + smilies addition,
along with the attachments addition hacks.
I think I finanlly got all that panned out, and am now going to attempt to
integrate this one in there.
I'll post back and let you know how it goes. :smoke:

catocom2
02-07-2004, 05:03 AM
Well I got it installed now, and it went off with out a hitch.
Great coding! Thanks!

catocom2
02-07-2004, 05:43 AM
For a quick and dirty way to make it so that the button does not show up in PM or usernote, just wrap it with a conditional:

<if condition="$SHOWQUICKREPLY">button</if>

Where to add that code Erwin?

I think it would be in the Postbit, or Postbit_legacy templates,
or both, but I'm not sure where.

codemonkey
03-23-2004, 06:50 PM
Very nice to see that the hack also works with vB3 gold :D Nice job!

poetic
03-25-2004, 09:18 AM
I would really like it if it worked with quick reply and i think alot of people would want it too

sabret00the
03-31-2004, 10:47 PM
gotta think of some images that would fit with the new vb3 images :(

what would've been great was if it used the existing quickreply image

sabret00the
04-03-2004, 12:28 PM
my idea would've been <if condition="THIS_SCRIPT == showthread.php">Show quick reply multiquote<else>show normal quick reply</if>

something along those lines.

sabret00the
04-03-2004, 02:26 PM
does this work with "go advanced" yet :nervous:

subu1
04-05-2004, 09:58 AM
subu clicks install, it works perfekt in my Girlfriend Comm, vB3 Gold ;)

thank you

Hoffi
04-05-2004, 09:19 PM
Does anyone makes Buttons for the Gold Button Set?

BigJohnson
04-14-2004, 01:43 AM
none of the conditionals work what can work for this to stop it showing in the private messages?

sabret00the
04-18-2004, 10:52 AM
i'll take a look at the conditionals when i finally install this but does anyone know how to get this working with check boxes instead?

gwhooooey
05-25-2004, 12:57 AM
Any updates being worked on for this?

DiscussAnything
06-01-2004, 11:41 PM
Anyone working on this for check boxes?

sabret00the
06-03-2004, 11:27 AM
i've seen it with check boxes on bearfacts2.com, not sure if the code for it is there or not though.

Ron1n
06-20-2004, 07:45 PM
<a href="http://64.91.226.37/community/showthread.php?t=1727" target="_blank">http://64.91.226.37/community/showthread.php?t=1727</a>

^ this doesnt work. i am assuming that it is because I am using the quick-reply box, is that correct? (doesnt work with go advanced).

Hoffi
06-23-2004, 04:19 PM
OK, I now did some Images that fit with vB3 Design.

Here they are.

sabret00the
06-24-2004, 09:43 PM
would really love this with a tick box still

DiscussNASCAR
07-01-2004, 01:22 AM
would really love this with a tick box still
wonder if this will ever happen? we're anxiously awaiting! :)

ZiRu$
07-04-2004, 12:44 AM
would really love this with a tick box still

Yes, please do.....i dont really like the image idea.....

DiscussNASCAR
07-28-2004, 09:52 PM
I fear it will never be complete :(

X-Fan
08-01-2004, 09:20 AM
I just installed this and I'm not seeing the multiquote graphics at all in any threads on my site. Any reason why they wouldn't be showing up?

X-Fan
08-08-2004, 04:18 AM
Anyone...?

X-Fan
08-08-2004, 04:55 AM
Okay, I managed to get the buttons displayed but there's a Javascript error being caused now in this line:

<body onload="$onload; mq_init();">

In the source of a given showthread page, that comes up as:

<body onload=" editInit();; mq_init();">

Any ideas anyone?

Corvette
08-12-2004, 11:56 AM
Cool, just like IPB 2! Without the IPB.

VAN
09-30-2004, 04:33 AM
would really love this with a tick box still

Sometimes you just gotta improvise. Just replace your current images with these and change the height/width values in the postbit template to both be "13". Done. ;)

Chroder
10-01-2004, 03:23 AM
Just letting everyone know, I'm making a total new one that's a little better. Works the same, but more sleek on the underside.

Also checks for user permissions (to ensure they aren't getting a post out of a staff forum, for example, by just plugging random post ids into the cookie).

I'll post it one of these days once I get around to debugging it.

MickDoneDee
10-02-2004, 07:52 AM
If I wanted to use checkboxes instead of the graphics I would insert this code in the postbit template:
<input type="checkbox" name="multiquote[]" style="border:2px;border-style:outset" title="Multi Quote" />
instead of:
<img src="$stylevar[imgdir_button]/mq_img_off.gif" alt="$vbphrase[multi_quote]" border="0" width="21" height="15" name="mq_post_$post[postid]" id="mq_post_$post[postid]" onclick="multiquote($post[postid], this)" style="cursor: hand" />
but what changes do I need to make to the mq_script template?

MickDoneDee
10-02-2004, 01:31 PM
*install* on vB3.0.3 without problems. Earlier versions didn't seem to use cookies. Why are cookies used with this version?

Chroder
10-02-2004, 03:52 PM
You need cookies, or the selected posts to be quoted would be lost when you left one page for another, meaning no cross-thread or cross-forum (or even cross-page) mutli-quoting.

To change the images to checkboxes, the easiest would just be what VAN suggested. But you could just attach an onclick to the checkbox and alter the Javascript to test for checked state instead of image src.

Chroder
10-02-2004, 08:17 PM
If anyone wants to try out the newest one, here it is. I've tested it and it works fine, but it'll be nice if anyone else wants to try it and confirm. This one was created from the ground-up using vB3.0.3.

theArchitect
10-04-2004, 03:38 AM
If anyone wants to try out the newest one, here it is. I've tested it and it works fine, but it'll be nice if anyone else wants to try it and confirm. This one was created from the ground-up using vB3.0.3.
I must be missing something. Where do I find the multiquote.js file.

It wasn't in multiquote.zip. And it wasn't in the first attachment either.

Chroder
10-04-2004, 08:55 PM
LoL

Good point! Updated the archive in post #76.

theArchitect
10-04-2004, 11:41 PM
Sensational
mod. Certainly one of my favourites.

*theArchitect clicks install*.

MickDoneDee
10-05-2004, 08:17 AM
I have the original installed. Is it worth switching across to the new version? I have 3.0.3.

Lionel
10-07-2004, 02:23 AM
I changed the conditional in postbit to <if condition="$post['replylink'] && THIS_SCRIPT == 'showthread'">
because it was also displaying the hack image in PM . I was getting a javascript error in private message (you cannot really do multiquote in there anyway)

Chroder
10-07-2004, 02:29 AM
Thanks Lionel, I didn't think of that. I'll update the package tomorrow.

Lionel
10-07-2004, 02:30 AM
Thanks to you for a great useful hack!

Lionel
10-14-2004, 01:24 PM
I have problems with my who's online and I am troubleshooting. Since I see in this hack you are using a different set of cookie, could that affect vb cookie for who's online?

kurv
10-14-2004, 07:09 PM
Chroder, this looks like a fantastic mod... I just can not get it to work... I just updated my board to Ver 3.0.3 and then installed your mod. There are no images added to the posts to click on for the multi quote option... Am I missing something..?

I have gone through the install instructions several times...

NuclioN
10-14-2004, 09:38 PM
it generates a javascript (object) error

gwhooooey
10-15-2004, 01:27 AM
There's another multi-quote hack i'm using at the moment that uses check boxes instead of images... would it be easy to change it to do that with this hack? (check box instead of image to click on)

Lionel
10-15-2004, 01:30 AM
that is the same one. The check box is just two images to create an illusion. Look for them a few posts above

Lionel
10-15-2004, 01:32 AM
I have problems with my who's online and I am troubleshooting. Since I see in this hack you are using a different set of cookie, could that affect vb cookie for who's online?

please, a simple yes or no... I am going crazy here with that who's online issue.

smashingyoungma
10-15-2004, 07:55 AM
Chroder, this looks like a fantastic mod... I just can not get it to work... I just updated my board to Ver 3.0.3 and then installed your mod. There are no images added to the posts to click on for the multi quote option... Am I missing something..?

I have gone through the install instructions several times...

Same problem here. I've carefully gone over the instructions multiple times and zilch, nadda, nothing. I'm not getting any errors or anything; it's simply as if I didn't install the hack at all. :(

kurv
10-15-2004, 07:24 PM
Same problem here. I've carefully gone over the instructions multiple times and zilch, nadda, nothing. I'm not getting any errors or anything; it's simply as if I didn't install the hack at all. :(

Yep... Chroder if you have time... this sounds like an awesome mod... can you tell what it sounds like is wrong..?

Chroder
10-16-2004, 04:32 PM
I have problems with my who's online and I am troubleshooting. Since I see in this hack you are using a different set of cookie, could that affect vb cookie for who's online?
What issues are you having with WOL? This hack shouldn't do anything like that. It sets its own cookie prefix_multiquote, which vB obviously doesn't use anywhere else.

it generates a javascript (object) error
Where and when (like just clicking one, or clicking the second one, clicking after refresh etc)? Make sure you do a hard refresh on any sites that were using the old hack to ensure you have the most recent Javascript file in your cache.

Chroder, this looks like a fantastic mod... I just can not get it to work... I just updated my board to Ver 3.0.3 and then installed your mod. There are no images added to the posts to click on for the multi quote option... Am I missing something..?
If there are no images added to the posts, then it could be two things. One, if you are using the legacy postbit (the verticle layout), then you will need to edit the postbit_legacy and add in the images. Or two, you edited a template in a different skin that you aren't using.

Sorry for the late reply guys, I've been busy with other matters lately.

Lionel
10-16-2004, 04:48 PM
OK, you answered my question. This hack is fantastic and I would have hated to remove it. In the meantimes, who's online is still not working. I will be focusing on another hack, whom I believe might be the culprit.

DiscussAnything
10-18-2004, 08:41 PM
works perfectly, nice job. Our members are happy again! :D

smashingyoungma
10-19-2004, 02:34 AM
Yup, it's working on my site now; it was simply that I didn't modify the postbit_legacy template. Thanks for pointing that out, Chroder. :)

One little problem, though: sometimes when I quote a post, old quotes from completely different threads I multiquoted previously will show up in the message box. Nothing major, but somewhat annoying - and confusing - when it happens. I assume there is a cache or something somewhere that's not being cleared when you move on to another thread.

Ber|Art
10-19-2004, 12:35 PM
Thx! Works great, very usefull hack :)

Ber|Art
10-19-2004, 12:40 PM
Oeps, spoke to soon, i get this error:

Parse error: parse error, unexpected $ in ../forum/newreply.php on line 555 (this is the very last line?)


//edit: Never mind I solved the problem (Typo)

moethelawn
10-30-2004, 04:24 AM
hmm..... Aren't we missing the javascript file (.js)? It seems like that's the only thing missing and that could be why it doesn't work on my forums, lol (click but nothing happens)

Edit: Ok, so it's in a different post... but shouldn't you update that archive in the first post?

Also, can you let it be able to put the quotes in the quick reply box when you click on the multiquote button? That would be great. Then you can reply to each quote individually instead of the quotes stacked on top of each other and not seeing that until you post...

X-Fan
11-06-2004, 09:32 PM
Works perfectly now, many thanks Chroder!!! :D

elastomaniac
11-12-2004, 04:02 AM
theres no multiquote.js in the .zip file :(

Aceman
12-13-2004, 03:51 PM
theres no multiquote.js in the .zip file :(


YEs... there is a file missing!!!
Aceman

skinny
12-18-2004, 01:49 AM
Works superbly! Thankyou, great addition. :up:

Aeolian
12-30-2004, 06:12 PM
Nice mod..
but have u guies looked into the pm window? u ll see the JS error (status bar of IE)..
i am working hard to fix this error.

any idea ppl?

theArchitect
01-02-2005, 04:10 AM
Will you be updating newpost.php for the multiquote hack, or does it stay the same now we are on 3.0.4

MikaK
01-05-2005, 09:54 AM
Kool! *install*. No issues at all.

Aeolian
01-08-2005, 03:30 PM
When u update keep in mind about the JS error in PM window.
Its due to the fact its checking postid not pmid.. plz fix it..

thanx

Lottis
01-13-2005, 09:16 AM
If there are no images added to the posts, then it could be two things. One, if you are using the legacy postbit (the verticle layout), then you will need to edit the postbit_legacy and add in the images. Or two, you edited a template in a different skin that you aren't using.
.
I have the same problem. But where and how should the postbit legacy bee change?

Deviant++
01-23-2005, 09:10 AM
The buttons are working but when I click reply, there's no quotes...

what gives ?

MickDoneDee
01-23-2005, 09:43 AM
To Deviant: Have you checked the multi-quote icons?

For example, I want to quote post #41 and #42 so I check both multi-quote icons and click Reply or Post Reply. The message editor opens with #41 quoted followed by #42 quoted.

Deviant++
01-23-2005, 09:46 AM
I know how it works...used it on ipb 2..

its not carrying the messages, only thing I can think of is cookies but everything else works on the board, why only this ?

MickDoneDee
01-23-2005, 10:13 AM
Makes it difficult to troubleshoot if you're not getting database, script or template errors. I have the earlier version installed so not sure if your problem relates to something in the latest version. I could email the earlier version to you if you want to try that otherwise PM Chroder (aka Chris) on this site or http://www.devboxforums.com/member.php?u=1?u=1

Deviant++
01-23-2005, 11:26 AM
Oh thanks :)

Aeolian
01-24-2005, 01:33 AM
still no update...
the JS error in pm window still exists...

catocom2
01-31-2005, 05:58 PM
For a quick and dirty way to make it so that the button does not show up in PM or usernote, just wrap it with a conditional:

<if condition="$SHOWQUICKREPLY">button</if>

In the new ver, the code looks different.
How would I fix this same problem here?

<if condition="$SHOWQUICKREPLY AND !$show['threadedmode']">
<a href="$post[replylink]" onclick="return doMultiQuote('$post[username]', $post[postid]);"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a>
</if>
<if condition="$post['replylink']"> <img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>

Deviant++
02-01-2005, 12:00 PM
someone should put a notice saying this mod cause it dosnt work for 3.0.5+ :( :(

KBV
02-15-2005, 08:27 PM
It's work fine in 3.0.6, having one problem though. Whenever someone uses Quick Reply to multi-quote someone, it double posts the quote.

http://www.naruto.no/forum/showpost.php?p=31695&postcount=4

Anyway to fix this?

Thanks for a great hack!

Allan
02-15-2005, 11:38 PM
I work on vBulletin 3.0.6

I have a problem, the button, does not appear and one cannot click above, an idea please ?
:(

even by putting the URL of the image in a navigator, it does not find whereas it is well in the file "images/misc" (tested on firefox and IE)

Allan
02-17-2005, 07:23 PM
arf :(

Gnappy
02-24-2005, 01:34 PM
I work on vBulletin 3.0.6

I have a problem, the button, does not appear and one cannot click above, an idea please ?
:(

even by putting the URL of the image in a navigator, it does not find whereas it is well in the file "images/misc" (tested on firefox and IE)
coz maybe u need to update ur postbit_legacy too...







anyways i have the same problem of Deviant++, i can see the buttons, i click on it, but when i click new reply i got a white blank page(quickreply or advanced its the same).... i dont know why, i hacked it twice, and im sure its correct... the only one thing is not completly correct is that Chroder wrote to search "$headerinclude" in SHOWTHREAD template, but i have just "$headinclude" in that template, anyways i added the istructions under it...i think Chroder made a mystake when wrote that istruction...


any ideas to fix my problem? thx to all for help

outlaw621
03-24-2005, 04:53 PM
In the new ver, the code looks different.
How would I fix this same problem here?

<if condition="$SHOWQUICKREPLY AND !$show['threadedmode']">
<a href="$post[replylink]" onclick="return doMultiQuote('$post[username]', $post[postid]);"><img src="$stylevar[imgdir_button]/quickreply.gif" alt="$vbphrase[quick_reply_to_this_message]" border="0" /></a>
</if>
<if condition="$post['replylink']"> <img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>

Find the following:

<if condition="$post['replylink']">
<img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>

And chage to the following:

<if condition="$SHOWQUICKREPLY AND $post['replylink']">
<img src="$stylevar[imgdir_misc]/mq_img_off.gif" alt="$vbphrase[multiquote]" border="0" width="21" height="15" name="multiquote_$post[postid]" id="multiquote_$post[postid]" onclick="toggleMultiQuote($post[postid], this)" style="cursor:pointer" />
</if>

catocom2
03-24-2005, 06:07 PM
Cool! :D
yep, that did it.
Thanks outlaw621 :cool:

outlaw621
03-24-2005, 06:22 PM
Cool! :D
yep, that did it.
Thanks outlaw621 :cool:

Your very welcome.

TwinsForMe
04-10-2005, 02:20 AM
Can someone tell me how to get the image to appear in the Postbit Legaacy?

Borgs8472
04-28-2005, 08:04 PM
Hey everyone.

I've just lost this hack following an upgrade from 3.03 to 3.07 and now try as I may, I cannot reinstall it.

Could I have a copy of multiquote 1 to install? This newer version I'm having no joy with :(

LuBi
05-12-2005, 02:34 AM
any updates to the ongoing issues? does the current available release work? :up: :down:

dsboyce8624
05-12-2005, 02:54 AM
Just installed on 3.0.7 and running fine.

Snake
06-19-2005, 10:42 AM
Will this work on 3.0.7?

Marco van Herwaarden
06-19-2005, 09:49 PM
Will this work on 3.0.7?Did you read the last post before your question???

dsboyce8624
06-19-2005, 10:29 PM
Roflmao

FD929
06-20-2005, 12:25 AM
Is this going to be ported for 3.5 final?

Oh and uh ... does it work with .07???? :p

Snake
06-20-2005, 09:49 AM
Did you read the last post before your question???

Sorry I meant 3.5 Beta, not 3.0.7. Tehe... and how many queries it runs?

Marco van Herwaarden
06-20-2005, 09:55 AM
And the question if a hack made for vB3.0.x will work on vB3.5 would have to be answered with No, with the occasional exception.

Snake
06-20-2005, 10:12 AM
Ok hope to see it convert to 3.5 soon.

MorrisMcD
07-06-2005, 12:23 AM
This hack is nice, but so is quick reply.. Already a few members have has issues.. If you click multi post and then do a quick reply, it quotes them.. But every time you quick reply after that, it quotes those same posts.... ??? Whats up with that? Its like it doesnt reset a table or something after you reply.. Is this by design? And is there a fix in process? Otherwise, I think I will uninstall :(

paul41598
07-07-2005, 07:10 PM
Mine doesnt work with quick reply...hmmm

MThornback
07-28-2005, 02:41 AM
Tried it....it was holding all the quotes as previously mentioned....so I uninstalled....its a great idea....but it needs some fine tuning before i'll try again :)

MET920
08-16-2005, 06:12 AM
I tried installing this on my vB 3.0.7 and I got the following error:
Parse error: parse error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ']' in /home/met920/public_html/forums/newreply.php on line 110

line 110 of newreply.php is:
if(isset($_COOKIE[COOKIE_PREFIX+.+'multiquote']))
That line is part of the code I have to put for this mod..

yoyoyoyo
08-20-2005, 03:10 PM
I tried installing this on my vB 3.0.7 and I got the following error:


line 110 of newreply.php is:
if(isset($_COOKIE[COOKIE_PREFIX+.+'multiquote']))
That line is part of the code I have to put for this mod..
the proper code is
if(isset($_COOKIE[COOKIE_PREFIX . 'multiquote']))

installed easily in 3.0.8

thanks

MET920
08-21-2005, 01:14 PM
Now I got this error:
Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/met920/public_html/forums/includes/adminfunctions_template.php(3096) : eval()'d code on line 292
when I was editting the postbit template

AuronTSR
09-08-2005, 02:37 AM
Hello :)

I had this previously installed (2.0 ver.), on a 3.0.3 board. Then I re-installed it when i upgraded our board to 3.0.7 and I wasnt having any problems. I had installed the who quoted me hack afterwards which caused our forums to act weird. I so un-install all the hacks until I got that one working properly. Then I re-installed mutliquote. It works perfectly fine, tested with both IE and FireFox. Theres only one problem tho, everytime someone views a thread it gives me/them this error:

onload="initMultiQuote();if (is_ie || is_moz) { fetch_object('currentPost').scrollIntoView(!is_moz ); } editInit();"

in the showthread.php at the very top of each thread, every time. :disappointed: Outside of that it works perfectly fine. :D Does anyone have a clue as to how to fix this? Or what I can do to hide this from showing? Any help would be much appreciated, thank you in advance.

Quillz
09-11-2005, 07:31 PM
This hack works perfectly on my 3.0.9 board except for one small thing: the icon doesn't appear for those who choose postbit_legacy! (On my board, users can switch between postbit and postbit_legacy.) What do I have to add, and to where, to get the icon to appear?

AuronTSR
09-15-2005, 07:01 PM
Hello :)

I had this previously installed (2.0 ver.), on a 3.0.3 board. Then I re-installed it when i upgraded our board to 3.0.7 and I wasnt having any problems. I had installed the who quoted me hack afterwards which caused our forums to act weird. I so un-install all the hacks until I got that one working properly. Then I re-installed mutliquote. It works perfectly fine, tested with both IE and FireFox. Theres only one problem tho, everytime someone views a thread it gives me/them this error:

onload="initMultiQuote();if (is_ie || is_moz) { fetch_object('currentPost').scrollIntoView(!is_moz ); } editInit();"

in the showthread.php at the very top of each thread, every time. :disappointed: Outside of that it works perfectly fine. :D Does anyone have a clue as to how to fix this? Or what I can do to hide this from showing? Any help would be much appreciated, thank you in advance.

Boo. It suddenly stopped working two days later. I have removed all the code from the scripts and the templates. And I still get that same error :( Any ideas anyone?