Quick Edit! -Edit posts directly from within the thread itself

[EvilLS1]

This hack will allow your users to edit their posts without having to load the editpost page..

How it works: In the bottom right-hand corner of all your posts will be a small Quick Edit icon (users will only see it in posts which belong to them).. When you click it a text box will drop down below your post allowing you to edit it instantly in the thread itself.

This will save you a lot of time when fixing those spelling mistakes, typos, or broken links. It should also help save on bandwidth since your users will no longer need to load the editpost page.

Very easy to install.. 2 file edits, 2 template edits, and 1 template to add.

Known bug: Quick Edit will NOT work with Opera web browsers. Those who use Opera simply won't see the option to quick edit (icon will be invisible when viewed in that browser). It'll work fine in other browsers such as IE or firefox.

Support: Due to work my time is limited as of late so this hack is released AS IS with no support. However, several questions have already been answered in this thread.

Update (7-25-04): Fixed a minor bug with the QE window moving further to the left with each click in mozilla/firefox browsers. To update simply replace your showthread_quickedit template with the new one. Thanks to sv1cec (https://vborg.vbsupport.ru/member.php?u=56616) for this bug fix. :)

Add Ons:
*Show the "delete post" option for those who have permission in the Quick Edit form (also adds edit reason). (https://vborg.vbsupport.ru/showpost.php?p=537683&postcount=196) (by sv1cec)
*Show the "edit reason" field in the Quick Edit form. (https://vborg.vbsupport.ru/showpost.php?p=458898&postcount=31) (Requested by Convergys)
*Alternate Quickedit icon image (https://vborg.vbsupport.ru/showpost.php?p=481703&postcount=81) (by ryancooper)
*Another alternate Quickedit icon (https://vborg.vbsupport.ru/showpost.php?p=536446&postcount=184) (by sv1cec)
*Another alternate Quickedit icon (https://vborg.vbsupport.ru/showpost.php?p=577048&postcount=238) (by charlesk)
*Yet another alternate Quickedit icon (https://vborg.vbsupport.ru/showpost.php?p=551117&postcount=200) (by iguanairs)
*Give users the option to disable quick edit in the usercp (https://vborg.vbsupport.ru/showpost.php?p=555925&postcount=213) (by pco)



If you find this hack useful please click the install button. :)

Screenshot attached:

[MGM]

alright! thanks man! I love the Quick hacks, this is one step closer to getting em all back

/me clicks install

MGM out

[Delusional]

Could you possibly convert this hack to work on version 2.3.2?

[EvilLS1]

Could you possibly convert this hack to work on version 2.3.2?
The vBulletin 2 version can be found here:
https://vborg.vbsupport.ru/showthread.php?s=&threadid=54851

[BillaBongUSA]

Hey, awesome hack, but I think I found a bug... Whenever you use the Quick Edit to edit your post, it seems to subscribe you to the thread that you used it in.

Other than that, good work man. :D

[EvilLS1]

Hey, awesome hack, but I think I found a bug... Whenever you use the Quick Edit to edit your post, it seems to subscribe you to the thread that you used it in.

Other than that, good work man. :D
Try this:

In the showthread_quickedit template find:

<input type="hidden" name="poststarttime" value="$poststarttime" />


Below it add:

<input type="hidden" name="emailupdate" value="9999" />


That should fix it.

[BillaBongUSA]

Ah, thanks, that fixed it.

Nice job! :)

[Boofo]

Excellent! Works as advertised. Will it have the checkbox for the sig checked if you have a sig in the message already? Also, wouldn't it be wise to have this enabled for Admins on all the messages, too? ;)

[EvilLS1]

Thanks. :)


Will it have the checkbox for the sig checked if you have a sig in the message already?

Thats a good idea. I fixed it so that the sig checkbox will only show up if the person has a sig, and it will be checked by default. I updated the first post to include this.

For those who have already installed:
In your showthread_quickedit template find:

<input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" $checked[signature] />Sig


Replace it with:

<if condition="$bbuserinfo['signature']">
<label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="5" checked="checked" />Sig</label>
</if>




Also, wouldn't it be wise to have this enabled for Admins on all the messages, too?


Well, since the message text would be loaded twice for all posts, I figure its best to only show the Quick Edit option to the post author.

But if anyone wants the quick edit option availible to admins on all posts, just find this section of code (from the hack instructions):

if ($post['userid'] == $bbuserinfo['userid'])


And replace it with this:

if (($bbuserinfo['usergroupid'] ==6) or ($post['userid'] == $bbuserinfo['userid']))

[Boofo]

If you turn it on for Admin, too, should'nt that be $postinfo['signature'] so the admin won't put his sig in it if he edits it?

[hagi]

very nice hack. will be installing. :)

[MindTrix]

Gorgeous hack :) Ill be sure to try this out soon.

[DuffMan]

Does this work on Mozilla? I remember the VB2 version didn't.

[EvilLS1]

Thanks.


If you turn it on for Admin, too, should'nt that be $postinfo['signature'] so the admin won't put his sig in it if he edits it?

Thats only the conditional for showing the checkbox. So even if the admin checked it when editing someone elses post I think it would still show the poster's sig and not the admin's. But yeah, if you turn it on for admins in all posts I guess $postinfo[signature] would be the correct variable.


Does this work on Mozilla? I remember the VB2 version didn't.

Yes, I've tested this with Mozilla, IE, and Opera. Works fine with all of them. The VB2 version has also been updated to work with all browsers.

[Boofo]

I'm getting a javascript error (Object Expected) on this line:

<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post" onreset="vB_RESET(this);">

whenever I hit the reset button. Any ideas how to fix it? ;)

[EvilLS1]

Ah, I guess thats something that changed between gamma and RC1. Anyway, to fix it just remove onreset="vB_RESET(this);" from that section of code and it should get rid of the error. The reset function will still work.

I'll update the first post. Thanks for pointing it out Boofo.

[Boofo]

Ok, the signature part works best with bbuserinfo. The only thing is, it shows a checked sig box even if the post has no sig in it. It won't add one, but the box is still checked. If you delete a sig from someone other than yourself (enabled for Admins) it deletes it fine. Bring the message up again, the box is checked, save it and the person's sig who the message belongs to shows up again. The only thing we need to do is not have it show the sig box if there is no sig. ;)

[RixiuS]

I love you.

[Boofo]

Ah, I guess thats something that changed between gamma and RC1. Anyway, to fix it just remove onreset="vB_RESET(this);" from that section of code and it should get rid of the error. The reset function will still work.

I'll update the first post. Thanks for pointing it out Boofo.That took care of it. Thank you, sir. ;)

Also, they're still using the reset= function. It is in a few of the templates.

BTW: Are you good with javascript errors? If so, I need help with one. ;)

[EvilLS1]

BTW: Are you good with javascript errors? If so, I need help with one.


Well, I'm no javascript guru but I'd be happy to try and help you fix your error. Just PM me with the details. :)

[NuclioN]

What a nice addon :) Installed and working fine.

[Luciolle]

Yes very nice hack and pretty good used too !

Thanks alot !

[Mamochka]

greet idea!!

[tomshawk]

Installed and worked perfectly

Clicks install ;)

Excellent work

[BigJohnson]

Ok, the signature part works best with bbuserinfo. The only thing is, it shows a checked sig box even if the post has no sig in it. It won't add one, but the box is still checked. If you delete a sig from someone other than yourself (enabled for Admins) it deletes it fine. Bring the message up again, the box is checked, save it and the person's sig who the message belongs to shows up again. The only thing we need to do is not have it show the sig box if there is no sig. ;)
Hey bud check out this post. I think this is what solves that problem.

https://vborg.vbsupport.ru/showpost.php?p=455845&postcount=10

[Boofo]

Hey bud check out this post. I think this is what solves that problem.

https://vborg.vbsupport.ru/showpost.php?p=455845&postcount=10
Already did that. ;)

[xware]

a good hack, but in pm sent item the old sent pm template use this, I think this is a design bug, how to do?

Ok, i see your update version have solved this problem.Thanks.

[Convergys]

An idea for this as an addon, have the option for adding the edit reason...?

[gmarik]

this is really faster - thumbs up!
add more options and it will become even better

[EvilLS1]

Thank you. :)

An idea for this as an addon, have the option for adding the edit reason...?

Nice idea. To add the edit reason field, open your showthread_quickedit template and find:

<td><textarea name="message" class="bginput" style="width:455px; height:85px;" wrap="virtual" tabindex="1">$edittext</textarea><br>


Below it add:

<!-- edit reason field -->
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[reason_for_editing]:</div>
<div><input type="text" class="bginput" name="reason" value="$newpost[reason]" size="50" maxlength="200" tabindex="1" title="$vbphrase[optional]" /><input type="hidden" name="reason_exists" value="$edit[reason_exists]" /></div>
</div>
<!-- / edit reason field -->

[Brad]

I love this modification, however most of my users are on IE 6 and there seems to be a bug with that browser. When IE loads the threads the javascript forces the browser to scroll to the right, you have to scroll back to the left to read the posts. The quick edit box is causing this (it expands to the right of the icon in ie)

[EvilLS1]

I love this modification, however most of my users are on IE 6 and there seems to be a bug with that browser. When IE loads the threads the javascript forces the browser to scroll to the right, you have to scroll back to the left to read the posts. The quick edit box is causing this (it expands to the right of the icon in ie)
Hmm.. Thats strange.. I also use IE 6.0 and am not having that problem.. Perhaps it happens when they're viewing threads in a browser window thats not maximized and the hidden Quick Edit form is actually a little wider than the post itself?

If thats the case, here's a couple of things you could try which might solve the problem:

In your showthread_quickedit template find:

<a href="javascript:return false;" onClick="toggleT('e$post[postid]','s');return false;"><img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" /></a>


And replace it with:

<a href="javascript:return false;" onClick="toggleT('e$post[postid]','s');return false;"><img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" /></a><br>


The added line break should make the quick edit form drop below the icon and all the way to the left of the table.

You could also change the width of the quick edit form so that its smaller.

[AshAbed]

Awesome hack, this was my first time trying to install a hack and it was simple, works great :) thanks

[The Keeper]

This hack apparently causes a bug in the PM system, though I don't see quite how.

Have a look here: http://www.vbulletin.com/forum/bugs.php?do=view&bugid=1707

[Boofo]

Put this in the postbit templates in place of $quickedit

<if condition="$post['pmid']==''">
$quickedit
</if>

[The Keeper]

Just checked, that's already there. Still no luck.

[Boofo]

Just checked, that's already there. Still no luck.Are you using the multiple quote hack, by chance? And what version of vB3 are you running?

[EvilLS1]

The bug mentioned was due to the fact that the same postbit is also used for private messages.. You would only notice it if you sent a private message to yourself. The fix is exaclty as Boofo said.. The main file has been updated with it for several days now.

If you're using the Multi-Quote hack then thats the problem. Its not compatible with this one. What is the problem that you're having?

[The Keeper]

I'm not using multiquote hack, and if a user sends a PM to me, any user, I can't delete it. Same if I send a PM to a user, they can't delete it either.

[EvilLS1]

The Keeper,
In both of your postbit templates find:

$quickedit


And replace it with:

<if condition="$post['pmid']==""">
$quickedit
</if>


That will solve your problem. Make sure you do it in both the postbit and postbit_legacy templates.

[Boofo]

That should be single quotes. ;)

<if condition="$post['pmid']==''">
$quickedit
</if>

[Nmidia]

That should be single quotes. ;)

<if condition="$post['pmid']==''">
$quickedit
</if>
Having one slight problem with this. When I edit a post - the font colour changes:) The font has set to the background colour:) Any clues?

http://legionsofloki.com/Forum/showthread.php?t=202

[Nmidia]

Its the reason for edit box causing the issues. When i don't provde a reason its fine
if only I had read that bit about

<if condition="$post['pmid']==''">
$quickedit
</if>

would have saved me two posts:)


However, the text still does not show until the page is scrolled. Refreshing the page does not fix this. IE6

[The Keeper]

Ok I've now gone through all my templates on all my styles and made the change suggested and still the delete button doesn't work.

[EvilLS1]

Nmidia,
Does that happen even without the edit reason code added to the hack?

The Keeper,
When viewing a private message, do you see the quick edit icon in the postbit? How about if you send a PM to yourself? Thats very strange..

[The Keeper]

I don't see the quickedit icon in Private Messages, and I have made the suggested changes to prevent it being loaded by PMs, but still can't delete. Don't worry though, I'm going to wipe and start again when vB3 goes Gold. :)

[jaliam]

This is an excellent hack! Thank you so much.

[EvilLS1]

Glad ya like it. :)

[catocom2]

very nice!
All my forum members love this one. :D

[ZeroZone]

May I ask for an option "delete this post" in the quick edit?
Thank you very much

[EvilLS1]

May I ask for an option "delete this post" in the quick edit?
Thank you very much
In your showthread_quickedit template find:

<if condition="$bbuserinfo['signature']">
<label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="5" checked="checked" />Sig</label>
</if>


Below it add:

</form>
<if condition="$bbuserinfo['usergroupid']==6">
<form action="editpost.php" method="post" style="display:inline;">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="p" value="$postid" />
<input type="hidden" name="do" value="deletepost" />
<input type="submit" class="button" name="deletepost" value="Delete" id="rb_del_soft" tabindex="1" />
</form>
</if>


Find:

</div>
</form>


Replace it with:

</div>

[ZeroZone]

Thank u very much, great modification. Clicked install :D

[AN-net]

um having problems with the edits:
u say to find:
$show['reputationlink'] = iif($vboptions['reputationenable'] AND $bbuserinfo['userid'] AND $post['userid'], true, false);
break;
}

i have this in my file:
$show['reputationlink'] = iif($vboptions['reputationenable'] AND $bbuserinfo['userid'] AND $post['userid'] AND !($usergroupcache["$post[usergroupid]"]['genericoptions'] & ISBANNEDGROUP), true, false);
break;
}

[gmarik]

Any idea how to add quick edit to shoutbox shouts, for example the vbIndex integrated shout?

[EvilLS1]

AN-net,
Thats because the code has changed slightly since RC1. Add it below this code and it'll work fine.

$show['reputationlink'] = iif($vboptions['reputationenable'] AND $bbuserinfo['userid'] AND $post['userid'] AND !($usergroupcache["$post[usergroupid]"]['genericoptions'] & ISBANNEDGROUP), true, false);
break;
}


gmarik,
I don't use shoutbox so I don't know. Sorry.

[LordJMann]

Decided to spice this up a bit... Here is the new and improved quickedit template complete with phrase support!


<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">
<a href="#" onClick="toggleT('e$post[postid]','s');return false;"><img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" /></a>
<div id="e$post[postid]" style="VISIBILITY:hidden; z-index:1; position:absolute;">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="updatepost" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="posthash" value="$posthash" />
<input type="hidden" name="poststarttime" value="$poststarttime" />
<input type="hidden" name="emailupdate" value="9999" />
<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="500" align="center">
<tr>
<td class="tcat">
<strong>$vbphrase[edit_post]</strong>
</td>
</tr>
<tbody style="">
<tr valign="top">
<td class="panelsurround" align="center">
<div class="panel">
<div style="width:500px" align="left">
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[reason_for_editing]:</div>
<div><input type="text" class="bginput" name="reason" value="$newpost[reason]" size="50" maxlength="200" tabindex="1" title="$vbphrase[optional]" /><input type="hidden" name="reason_exists" value="$edit[reason_exists]" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[title]:</div>
<div><input type="text" class="bginput" name="title" value="$post[title]" size="50" maxlength="85" tabindex="1" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[message]:</div>
<div><textarea name="message" class="bginput" style="width:450px; height:125px;" wrap="virtual" tabindex="1">$edittext</textarea></div>
</div>
<fieldset class="fieldset">
<legend>$vbphrase[miscellaneous_options]</legend>
<div style="padding:3px">
<if condition="$bbuserinfo['signature'] != ''"><div><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked />$vbphrase[show_your_signature]</label></div></if>
<div><label for="cb_parseurl"><input type="checkbox" name="parseurl" value="1" id="cb_parseurl" tabindex="1" checked />$vbphrase[automatically_parse_links_in_text]</label></div>
<div><label for="cb_disablesmilies"><input type="checkbox" name="disablesmilies" value="1" id="cb_disablesmilies" tabindex="1" />$vbphrase[disable_smilies_in_text]</label></div>
</div>
</fieldset>
</div>
</div>
<div style="margin-top:6px">
<input type="submit" class="button" name="sbutton" value="Save Changes" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="Preview Changes" accesskey="p" tabindex="1" />
<input type="button" class="button" value="Hide" onClick="toggleT('e$post[postid]','h')">
</div>
</td>
</tr>
</tbody>
</table>
<br />
</div>
</form>



You'll find it very attractive :D

[Boofo]

Can we see an image of it?

[Boofo]

Excellent job! That looks really good. Too bad I can't get this hack to work for me. The multiple quote hack I have installed interferes with this one. :)

I have to ask, how do you get the square corners on the legend instead of the rounded ones?

[LordJMann]

Excellent job! That looks really good. Too bad I can't get this hack to work for me. The multiple quote hack I have installed interferes with this one. :)

I have to ask, how do you get the square corners on the legend instead of the rounded ones?
Mine have always been square... Can I see a picture?

[Boofo]

Here you go.

[EvilLS1]

LordJMann,
Looks nice. Added a link to your post in the first post of this thread.

[LordJMann]

Here you go.Do your CSS settings look like these:


/* ***** define margin and font-size for elements inside panels ***** */
.fieldset { margin-bottom: 6px; }
.fieldset, .fieldset td, .fieldset p, .fieldset li { font-size: 11px; }


Are their any extra options in the fieldset CSS configuration box in the styles page as well?


LordJMann,
Looks nice. Added a link to your post in the first post of this thread.
Thanks, glad I could help.

[Boofo]

No, it looks just like that. They are that way at vb.vom and here, too. I use IE, if that might be it.

[LordJMann]

No, it looks just like that. They are that way at vb.vom and here, too. I use IE, if that might be it.Well, it isn't IE... I'm not sure how they are square, they were always square on my board... Though I don't remember changing them... Odd...

[Boofo]

Do you see them round here, too?

[LordJMann]

Do you see them round here, too?Matter of fact I don't... Maybe it might be IE, are you running the latest version?

[The Watcher]

hello - how can i make the quickedit option availble to ...

:: members on thier posts
:: staff on ALL posts

Thanks - great hack thus far :)

[EvilLS1]

hello - how can i make the quickedit option availble to ...

:: members on thier posts
:: staff on ALL posts

Thanks - great hack thus far :)
Look at the end of this post:
https://vborg.vbsupport.ru/showpost.php?p=455845&postcount=10

:)

[raxafarian]

This hack will allow your users to edit their posts without having to load the editpost page..

How it works: In the bottom lefthand corner of all your posts will be a small Quick Edit icon (users will only see it in posts which belong to them).. When you click it a small text box will drop down below your post allowing you to edit it instantly in the thread itself.

This will save you a lot of time when fixing those spelling mistakes, typos, or broken links.

Very easy to install.. 2 file edits, 3 template edits, and 1 template to add.

Add Ons:
*Show the "edit reason" field in the Quick Edit form. (https://vborg.vbsupport.ru/showpost.php?p=458898&postcount=31) (Requested by Convergys)
*Alternate Quickedit template (https://vborg.vbsupport.ru/showpost.php?p=474283&postcount=57) (by LordJMann)

If you find this hack useful please click the install button. :)

Screenshot attached:
Just installed this on RC4.

I installed the LordJMann version of the showthread_quickreply template.


Everything works good with IE, but when I use Firefox, the reply box pops up and then I go straight to an error page:

Not Found
The requested URL /forums/java_script_:return false; was not found on this server.

Additionally, a 404 Not Found error was encountered while trying to use an ErrorDocument to handle the request.

Again....this is using Firefox ver. 0.8

[LordJMann]

raxafarian,

I think this is the problem...

Change this:


<a href="javascript:return false;" onClick="toggleT('e$post[postid]','s');return false;"><img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" /></a>


To this:


<a href="#" onClick="toggleT('e$post[postid]','s');return false;"><img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" /></a>


I have also updated my post... Let me know if that works.

[raxafarian]

that did it...

Thanks!

[LordJMann]

that did it...

Thanks!
Your welcome! :D

[Mr. HillBilly]

The quickedit icon shows up in announcements.... Anyway to fix this?

[Sasha_Goodman]

Installed it and it works great! This is the first hack I've considered worth installing...I know I'll have to worry about extra stuff when upgrading Vbulletin, but its worth it!

[MaDCaT75]

Is there a way so that mods and admins can see the quick edit button for ALL users?

[EvilLS1]

Is there a way so that mods and admins can see the quick edit button for ALL users?
https://vborg.vbsupport.ru/showpost.php?p=455845&postcount=10

Scroll to the bottom. ;)

[EvilLS1]

The quickedit icon shows up in announcements.... Anyway to fix this?

In your postbit and postbit_legacy templates find this:

<if condition="$post['pmid']==""">


And replace it with this:

<if condition="THIS_SCRIPT=='showthread'">

[ShutDown23]

Great hack. Will install tomarrow :)

[djohn]

Nice hack, just one question.
When you open the quick edit box, it automatically appears on the right hand side from the button. I have moved the button next to the quick reply button on the right, but now when I click the quick edit button, most of the popup is outside the screen. Is there a way to make it appear on on left hand side of the quick edit button?

Also, how can i delete the template created while installing that hack? I've named it wrongly, so i need to delete it now and create a new one.

[ryancooper]

If you are anal like me I have attached a image that goes with the default VB style.

Also add " class="inlineimg" " to the image tag in the showthread_quickedit to have it line up perfectly.

Thanks for a great hack!! :devious:

[catocom2]

cool ryancooper!
would you post that IP icon/button too?

[EvilLS1]

Nice hack, just one question.
When you open the quick edit box, it automatically appears on the right hand side from the button. I have moved the button next to the quick reply button on the right, but now when I click the quick edit button, most of the popup is outside the screen. Is there a way to make it appear on on left hand side of the quick edit button?

Also, how can i delete the template created while installing that hack? I've named it wrongly, so i need to delete it now and create a new one.
Yeah you can do that by adding something like this:

left:30%;


To this line of code in the showthread_quickedit template like so:

<div id="e$post[postid]" style="VISIBILITY:hidden; z-index:1; position:absolute; left:30%;">

You might have to adjust the percentage a bit so that it appears where you want it.

To remove the unused template just click edit templates, find the one you want to remove, highlight it and click revert. I don't use VB3 but I think thats how you do it.

ryancooper,
Your icon looks nice. :) Added a link to your post.

[Xcist]

Awesome hack. ^_^ Very useful and well made. Nice job. *Installed*

[EvilLS1]

Thank you. :)

[Morgalis]

On my site, if you use quick edit, it removes your signature

I searched the thread, but nothing jumped out at me.. can you point me in the right direction?

[Zelda-King]

I had this working fine on RC4 but for some reason it's not showing up on vB3 Gold... for me anyway.

[EvilLS1]

On my site, if you use quick edit, it removes your signature

I searched the thread, but nothing jumped out at me.. can you point me in the right direction?
Hmm.. What version are you using? Check your quickedit template and make sure it has the change described in this post:
https://vborg.vbsupport.ru/showpost.php?p=455845&postcount=10

Zelda-King,
Unfortunately my vbulletin membership has expired and I don't have a copy of Gold to check and see what code changes have been made.. Hopefully someone else who has vb3 gold can tell us what has changed.

[Zelda-King]

Well as I recall, the codes you refer to in your documentation are unchanged. The posbit templates aren't, however.

[admiralapril]

I'd like to install this, but still don't know if it works in Gold. What's the final word?

[Preds]

I'd like to install this, but still don't know if it works in Gold. What's the final word?
I've been wondering the same thing... anyone know if this works in Gold?

[Vivi Ornitier]

was lookin for this one, was a great hack for vb2. NIce job!

[EvilLS1]

was lookin for this one, was a great hack for vb2. NIce job!
Thanks Vivi. :)


I've been wondering the same thing... anyone know if this works in Gold?


Its a quick and easy hack to install.. Why not just give it a shot? If it doesn't work we can try to figure out what has changed in vb3 gold. :)

[GoTTi]

i dont understand how u made it lign up like that ryan....

If you are anal like me I have attached a image that goes with the default VB style.

Also add " class="inlineimg" " to the image tag in the showthread_quickedit to have it line up perfectly.

Thanks for a great hack!! :devious:

[ryancooper]

i dont understand how u made it lign up like that ryan....
replace <img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" />

with

<img src="$stylevar[imgdir_button]/quickedit_icon.gif" class="inlineimg" alt="Quick Edit" border="0" />

[Slave]

It works fine in Gold .. with a little bit of juggling ..

I've changed the install file with all the changes I made, including any reported problems above that weren't added to the .txt file ..

I've gone for "Admins able to edit anything" and "LordJMann's layout" btw .. and I've also created a quick edit gfx for the new gold style ..

I hope that helps peeps .. :) .. feel free to add/improve/tear to shreds .. :p

[EvilLS1]

Thanks for updating it Slave. I added a link to your post. :)

[kirupa]

Hey Evil!
I really liked using version 2 of this! I have your version installed for version 3, but I am getting the following javascript error message everytime somebody clicks on the QuickEdit button:

'document.all.e476314.style' is null or not an object

Do you have any suggestions as to what may be causing this? I am on vb3 gold.

Thanks!
Kirupa :nervous:

[EvilLS1]

Hey Evil!
I really liked using version 2 of this! I have your version installed for version 3, but I am getting the following javascript error message everytime somebody clicks on the QuickEdit button:

'document.all.e476314.style' is null or not an object

Do you have any suggestions as to what may be causing this? I am on vb3 gold.

Thanks!
Kirupa :nervous:
Hmmm.. What browser are you using? Also, did you install the updated version for Gold? This one:
https://vborg.vbsupport.ru/showpost.php?p=494963&postcount=96

[kirupa]

Hmm - I used the updated code from the URL you provided, and I get the same error. I am using IE6, but the error does not occur in mozilla or firefox.

I am not certain why IE6 is giving me that error though.

Cheers!
Kirupa ;)

[Zelda-King]

I'm having no trouble on Gold, but this uses Javascript. Perhaps you have a firewall blocking it?

[kirupa]

I do have scripting enabled in my IE, and I do see the QuickEdit window. But, as I mentioned earlier, I also see a script error. All of the other vb3 features that may use a script work without any major issues :)

[Zelda-King]

Well, like I said: I have it working fine on Gold, even on Internet Explorer so unless you're using IE5 or below I'd reckon either a) you've done something wrong and should reinstall, b) you downloaded a different version of the updated text than I did (if that was ever updated which I don't think it was), c) you have a hack clash, d) it's a matter related your your own computer and it works fine on others, or e) er... something I've missed. :D.

Hope you locate the problem. :)

[poetic]

Works great, although moderators for a forum should be able to use it too not just admins and the owner of the post.


// Quick Edit hack
if (($bbuserinfo['usergroupid'] == 6) or ($post['userid'] == $bbuserinfo['userid']))
{
$edittext = htmlspecialchars_uni($post['pagetext']);
eval('$quickedit = "' . fetch_template('showthread_quickedit') . '";');
}
else
{
$edittext="";
$quickedit="";
}
// End Quick Edit hack


Should be


// Quick Edit hack
if (($bbuserinfo['usergroupid'] == 6) or (can_moderate($foruminfo['forumid'])) or ($post['userid'] == $bbuserinfo['userid']))
{
$edittext = htmlspecialchars_uni($post['pagetext']);
eval('$quickedit = "' . fetch_template('showthread_quickedit') . '";');
}
else
{
$edittext="";
$quickedit="";
}
// End Quick Edit hack

[Host Directory]

Great hack.. works fine in vb3 gold.

I click install

[EvilLS1]

<font color="Yellow">Update:</font> Quick Edit now uses vB's standard vbmenu_popup to show the Quick Edit box. So no more worries about javascript errors or it not working in some browsers.

To upgrade, just replace your showthread_quickedit template with the new one and relocate the $quickedit variable in your postbit templates (see instructions).. You can also remove the javascript that you added to your showthread template.

[Loyalty4Life]

Thanks... Nice update!

[SemperFidelis]

Thanks... Nice update!
Ok
Im using :
- the updated set of instructions provided by Slave (https://vborg.vbsupport.ru/showpost.php?p=494963&postcount=95)
- with the slight revision to that provided by poetic (https://vborg.vbsupport.ru/showpost.php?p=499205&postcount=103)
In conjunction with :
Advanced Editing Options For Mods & Admins (https://vborg.vbsupport.ru/showthread.php?t=61412)

And all works fine
Except one thing

Whenever I use the quick edit, it is dropping the details of the original poster
ie
ends up being posted as guest

To get around this, I have to use the preview option, re-enter the original poster, then submit
And as you can gather, thats hardly a quick edit

Has anyone got these 2 fine hacks to play nicely together as I would really like to keep both.

TIA

[moonclamp]

*Installs*

I have noticed that if you go to edit the first post in a thread, the signature is removed from the post. This doesn't happen anywhere else

[zetetic]

Update: Quick Edit now uses vB's standard vbmenu_popup to show the Quick Edit box. So no more worries about javascript errors or it not working in some browsers.
This is a great hack, thanks EvilLS1.

Is it possible to make this change to the version of the quickedit template from Slave's post?

[EvilLS1]

This is a great hack, thanks EvilLS1.

Is it possible to make this change to the version of the quickedit template from Slave's post?
Yeah, you could copy things from his template and paste them into the new quick edit template. For example, if you want the edit reason added you would just paste this section of code into the new template:

<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[reason_for_editing]:</div>
<div><input type="text" class="bginput" name="reason" value="$newpost[reason]" size="50" maxlength="200" tabindex="1" title="$vbphrase[optional]" /><input type="hidden" name="reason_exists" value="$edit[reason_exists]" /></div>
</div>


If you want the misc options to appear at the bottom like his just paste in this section of code:

<fieldset class="fieldset">
<legend>$vbphrase[miscellaneous_options]</legend>
<div style="padding:3px">
<if condition="$bbuserinfo['signature'] != ''"><div><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked />$vbphrase[show_your_signature]</label></div></if>
<div><label for="cb_parseurl"><input type="checkbox" name="parseurl" value="1" id="cb_parseurl" tabindex="1" checked />$vbphrase[automatically_parse_links_in_text]</label></div>
<div><label for="cb_disablesmilies"><input type="checkbox" name="disablesmilies" value="1" id="cb_disablesmilies" tabindex="1" />$vbphrase[disable_smilies_in_text]</label></div>
</div>
</fieldset>


Just experiment with it a little and you'll get it to look how you want it. :)

[zetetic]

Cool, thanks. :)

So I can take the javascript stuff out of SHOWTHREAD that were part of his instructions, then?

[EvilLS1]

Cool, thanks. :)

So I can take the javascript stuff out of SHOWTHREAD that were part of his instructions, then?
Yep. The javascript in the showthread template is no longer needed. Use my updated instructions to install the hack, then just copy & paste the portions of his template to add in the misc options and edit reason. :)

[zetetic]

Great. Thanks again. :)

[Mr. HillBilly]

Whats the difference between the default version and slaves version?

[EvilLS1]

Whats the difference between the default version and slaves version?
The old version (in slave's post) didn't play nice with some browsers.. The new (default) version uses vB's vbmenu_popup to show the Quick Edit box so it should work with any browser.

[sketch42]

IMHO there are waaaaaaaaay to many versions of this hack in this thread...lol... which is the most recommended, and can this be made to be used by specific usergroups only???

[EvilLS1]

IMHO there are waaaaaaaaay to many versions of this hack in this thread...lol... which is the most recommended, and can this be made to be used by specific usergroups only???
Use the one in the first post of this thread. :) Its the most recent.

And yes, you can easily limit the hack to certain usergroups by using template conditionals around the $quickedit variable in the postbit template.

For example, lets say you want everyone except usergroup 8 to have access to this feature..
In the postbit template you would just replace this:

<if condition="THIS_SCRIPT=='showthread'">
$quickedit
</if>


With this:

<if condition="THIS_SCRIPT=='showthread' and $bbuserinfo[usergroupid]!=8">
$quickedit
</if>

[sketch42]

Use the one in the first post of this thread. :) Its the most recent.

And yes, you can easily limit the hack to certain usergroups by using template conditionals around the $quickedit variable in the postbit template.

For example, lets say you want everyone except usergroup 8 to have access to this feature..
In the postbit template you would just replace this:

<if condition="THIS_SCRIPT=='showthread'">
$quickedit
</if>


With this:

<if condition="THIS_SCRIPT=='showthread' and $bbuserinfo[usergroupid]!=8">
$quickedit
</if>


is in both postbit and postbit_legacy???

also what bout denying usergroups 1 2 3 and 4?

[sketch42]

is in both postbit and postbit_legacy???

also what bout denying usergroups 1 2 3 and 4?


i figured it out

must be this

<if condition="THIS_SCRIPT=='showthread' and $bbuserinfo[usergroupid]!=1 and $bbuserinfo[usergroupid]!=2 and $bbuserinfo[usergroupid]!=3 and $bbuserinfo[usergroupid]!=4">
$quickedit
</if>

ima click install in a min lol.... a couple things... i downloaded the zip file and the reason isnt there... also my icon doesnt show

[sketch42]

i figured it out

must be this

<if condition="THIS_SCRIPT=='showthread' and $bbuserinfo[usergroupid]!=1 and $bbuserinfo[usergroupid]!=2 and $bbuserinfo[usergroupid]!=3 and $bbuserinfo[usergroupid]!=4">
$quickedit
</if>

ima click install in a min lol.... a couple things... i downloaded the zip file and the reason isnt there... also my icon doesnt show
icons working

clickity click ... Install :)

[zetetic]

My post icons are disappearing after I quick edit. :(

[EvilLS1]

My post icons are disappearing after I quick edit. :(
In your showthread_quickedit template find:

<input type="hidden" name="parseurl" value="1" id="cb_parseurl" />


Below it add:

<input type="hidden" name="iconid" value="$post[iconid]" />


Thanks for pointing that out. I added it to the instructions. :)

[zetetic]

Cool, thanks! I was sure it was something I did. ;)

[edeab220]

This is a cool hack :D.

When I use this in firefox, the box height is fine, but the width is too long. I'm not sure if this was answered in this thread, but TIA :).

[PhoenixBB]

Nobody seems to have noticed that there is a huge problem with'unregistered' posts. I noticed this recently with the VB2x version when I allowed unregistered to post on the board. It puts the quick edit on their posts, which of course means any unregistered can edit the post even though it isn't theirs. Just installed this upgrade on my test board and the problem is still there.

I'm about to input this code:

if (($bbuserinfo['usergroupid'] == 6) or (can_moderate($foruminfo['forumid'])) or ($post['userid'] == $bbuserinfo['userid']))
{
$edittext = htmlspecialchars_uni($post['pagetext']);
eval('$quickedit = "' . fetch_template('showthread_quickedit') . '";');
}
else
{
$edittext="";
$quickedit="";
}


So how can I add it in that it excludes unregistered posts? Suppose I could just not allow the unregistered to post if necessary. No biggie I guess.

Also, is it possible to just use the hack for VB2 on VB3 instead of this upgraded one? I like the radio button on that, and I think the text next to it makes it easier to see what it does. Many old browsers don't have the 'alt' tags so it'll take a while for people to figure out what this new icon is for.

This is by far my most popular and used hack, but even newbies could figure it out immediately - the new version is not as easily identifiable IMO.

[sketch42]

Nobody seems to have noticed that there is a huge problem with'unregistered' posts. I noticed this recently with the VB2x version when I allowed unregistered to post on the board. It puts the quick edit on their posts, which of course means any unregistered can edit the post even though it isn't theirs. Just installed this upgrade on my test board and the problem is still there.

I'm about to input this code:

if (($bbuserinfo['usergroupid'] == 6) or (can_moderate($foruminfo['forumid'])) or ($post['userid'] == $bbuserinfo['userid']))
{
$edittext = htmlspecialchars_uni($post['pagetext']);
eval('$quickedit = "' . fetch_template('showthread_quickedit') . '";');
}
else
{
$edittext="";
$quickedit="";
}


So how can I add it in that it excludes unregistered posts? Suppose I could just not allow the unregistered to post if necessary. No biggie I guess.

Also, is it possible to just use the hack for VB2 on VB3 instead of this upgraded one? I like the radio button on that, and I think the text next to it makes it easier to see what it does. Many old browsers don't have the 'alt' tags so it'll take a while for people to figure out what this new icon is for.

This is by far my most popular and used hack, but even newbies could figure it out immediately - the new version is not as easily identifiable IMO.
shouldnt this work??? https://vborg.vbsupport.ru/showpost.php?p=519181&postcount=117
just prevent that usergroup from using it

[SaN-DeeP]

is it possible to hide the QuickEdit Button
once the edit time on those posts is over ??

Just want to hide the button, as even after users click on it, they are not able to edit post ;)
But better to hide it.

What ya say ?
Sandy...

[EvilLS1]

edeab220,
I don't have firefox at home, but I do at work. I'll check it out tomorrow.

PhoenixBB,
I think most people don't allow guests to post so thats probably why nobody has noticed.. Its really easy to fix though. You'll just need to disable quickedit completely for guests. You can do it like this:

In your postbit templates find this:

<if condition="THIS_SCRIPT=='showthread'">
$quickedit
</if>


And replace it with this:

<if condition="THIS_SCRIPT=='showthread' and $bbuserinfo[userid]>0">
$quickedit
</if>



Also, if you'd rather have the text "quick edit" instead of the icon, you should be able to do something like this in the showthread_quickedit template:

find:

<img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" />


replace it with:

<a href="#top">Quick Edit</a>

[EvilLS1]

is it possible to hide the QuickEdit Button
once the edit time on those posts is over ??

Just want to hide the button, as even after users click on it, they are not able to edit post ;)
But better to hide it.

What ya say ?
Sandy...
Try using this code in the postbit templates:

<if condition="THIS_SCRIPT=='showthread' and $post['editlink']">
$quickedit
</if>

[SaN-DeeP]

Try using this code in the postbit templates:

<if condition="THIS_SCRIPT=='showthread' and $post['editlink']">
$quickedit
</if>

simply awesome ;)
workED perfect :)

Mebbe u can also update ur post/files and include this tip ;)

Thnx.
Sandy...

[EvilLS1]

simply awesome ;)
workED perfect :)

Mebbe u can also update ur post/files and include this tip ;)

Thnx.
Sandy...
I'll add it in the next update. :)

[PhoenixBB]

In your postbit templates find this:

<if condition="THIS_SCRIPT=='showthread'">
$quickedit
</if>


And replace it with this:

<if condition="THIS_SCRIPT=='showthread' and $bbuserinfo[userid]>0">
$quickedit
</if>



Hmm, I only have

<if condition="$post['pmid']==""">
$quickedit
</if>


So , how would I combine the above instruction with the pmid one (is that the one that stops it appearing on PM's) while also including the the code as given to SaN-DeeP below, to remove it after the edit time is up. Would it be something like:

<if condition="$post['pmid']==""" >
<if condition="THIS_SCRIPT=='showthread' and $post['editlink']">
<if condition="THIS_SCRIPT=='showthread' and $bbuserinfo[userid]>0">
$quickedit
</if>
</if></if>

Or are there too many 'if' things in there?

The text link doesn't work alas. All I get when I click it is to be taken to the top post. No pop up box at all. :(

ETA: Got the text link working, thanks! I redownloaded the file and I figure I must have had an older one. So that is one part sorted. :D

[EvilLS1]

PhoenixBB,
The $post['pmid'] is no longer needed b/c THIS_SCRIPT=='showthread' keeps it from showing in PMs.

So just use this code:

<if condition="THIS_SCRIPT=='showthread' and $post['editlink'] and $bbuserinfo[userid]>0">
$quickedit
</if>

[PhoenixBB]

Thanks, works a treat!

I've got the text link at the bottom with the normal edit/quote buttons so it's unmissable now.

My members are gonna be very happy. I figure if we had a poll to only keep one hack it would have to be this one. Mucho thanks! :D

[EvilLS1]

Thanks, works a treat!

I've got the text link at the bottom with the normal edit/quote buttons so it's unmissable now.

My members are gonna be very happy. I figure if we had a poll to only keep one hack it would have to be this one. Mucho thanks! :D
You're welcome. :)

[EvilLS1]

This is a cool hack :D.

When I use this in firefox, the box height is fine, but the width is too long. I'm not sure if this was answered in this thread, but TIA :).

edeab220,

In your showthread_quickedit template find:

<div class="vbmenu_popup" id="quickedit_$post[postid]_menu" style="display:none">


Replace it with:

<div id="quickedit_$post[postid]_menu" style="display:none">


That should do it. :)

[edeab220]

edeab220,

In your showthread_quickedit template find:

<div class="vbmenu_popup" id="quickedit_$post[postid]_menu" style="display:none">


Replace it with:

<div id="quickedit_$post[postid]_menu" style="display:none">


That should do it. :)
Thank you :D.

[PhoenixBB]

Does anyone know how to fix this:

As mentioned in a previous post, this hack can sometimes subscribe you to the thread which is happening to me at the moment. I have used the
<input type="hidden" name="emailupdate" value="9999" />

However my board is set not to allow emails, so if anyone subscribes to threads they just go into UserCP. I just noticed my User CP was full of threads that I'd used this hack on. Interestingly when I used it a second time in the thread, the thread disappeared from the CP. So it subscribes me the first time, unsubscribes the second??

Tried this: <input type="hidden" name="subscriptionupdate" value="9999" />

but that didn't work either. People who want to subscribe manually usually do and clear them out when finished. If this is just subscribing threads willy nilly could get a bit crowded for people who rarely enter their CP.

Any ideas?

Thanx!

[PhoenixBB]

PhoenixBB,
Just find and remove this line from your showthread_quickedit template and it will no longer subscribe anyone automatically:


<input type="hidden" name="emailupdate" value="9999" />


Nope that doesn't work. :( I put that in originally to fix it as I thought that was the 'do not subscribe' option but it didn't work. With or without that line I get subscribed and it's putting the threads in my CP panel.

[EvilLS1]

PhoenixBB,
Are you sure that you have "do not subscribe" selected in your User CP under options for Default Thread Subscription Mode? The reason I ask is because I just checked again on my site and its not doing that. As long as that line of code is removed and you're using the exact template from the first post of this thread there's no reason it should add the subscription.

[zetetic]

Just found another little bug, Evil.

Quick editing posts produces this in the action column of the moderator log:

Post edited by 3 on at .

[sketch42]

is it possible to add bbcode buttons to the quick edit?

[EvilLS1]

Just found another little bug, Evil.

Quick editing posts produces this in the action column of the moderator log:

Post edited by 3 on at .

Do you by chance have it set so that mods can edit other user's posts with quick edit? If so, thats why. ;)

[EvilLS1]

is it possible to add bbcode buttons to the quick edit?

I think so. You'd just need to copy the necessary code from the editpost template and put it in the showthread_quickedit template. Should be really easy.

[zetetic]

Do you by chance have it set so that mods can edit other user's posts with quick edit? If so, thats why. ;)
No, but admins do so I guess that's where the problem was coming from. Is there a way I can fix it to record properly for admin edits?

[EvilLS1]

No, but admins do so I guess that's where the problem was coming from. Is there a way I can fix it to record properly for admin edits?

I'm not really sure as I don't use the version which allows admins to edit all posts.. But you could try adding this to the showthread_quickedit template:
<phrase 1="$bbuserinfo[username]" 2="$date" 3="$time">$vbphrase['post_edited_by_x_on_y_at_z']</phrase>

[PhoenixBB]

PhoenixBB,
Are you sure that you have "do not subscribe" selected in your User CP under options for Default Thread Subscription Mode? The reason I ask is because I just checked again on my site and its not doing that. As long as that line of code is removed and you're using the exact template from the first post of this thread there's no reason it should add the subscription.

Hi,

Actually I don't have those Options. Because I've turned off email on the board (got too many bounced mails, people forget to empty their boxes or give fake addies) I removed those parts from the templates. For the subscription folder it now just shows options to Move or Delete. If I'd left the email ones in I'd have been hassled to turn it on again.

The posting templates, including Quick Edit, have references to subscriptions totally removed, and if they want to subscribe to a threa/forum they do it via the links. I would have left the 'do not subscribe' in if there had also been a 'subscribe', but the other Options were relating to email, so just having 'do not subscribe' when posting would not have been helpful if they were thinking of subscribing. IYSWIM!

New Registrations are set to not automatically subscribe (via VB Options) so nowhere are there any Options to automatically subscribe if one hasn't used the option in Quick Links.

There are only a few of us registered on the test board and for everyone any thread they reply to or start shows up in their UserCP even though it shouldn't. In post 6 on this thread, someone had something similar and you suggested the email 'update 9999' thing would stop it. Tried that, no joy. You are saying now that to stop it you should have that line removed which confused me, as without it this was still happening. But either way it's still happening.

My only concern here is for the many people who never go into UserCP, so will never get to empty things, it could get really full in there, and they won't be able to differentiate between threads they have really subscribed to, via the Forum Tools, and ones they have no interest in even though they posted in them.

[EvilLS1]

PhoenixBB,
If you'll give me a link to your forum and set me up a test user account I'll check it out for you. It doesn't do that on either of my forums so I can't check it there.

[350Chevy]

Nice hack Evil! Clicking install.. :D

[EvilLS1]

Thanks 350. :)

[PhoenixBB]

PM'd ya!

[PhoenixBB]

PM'd ya!
Just thought I'd let you know, things are no longer subscribing. Everything seems peachy now. :D

[zetetic]

I'm not really sure as I don't use the version which allows admins to edit all posts.. But you could try adding this to the showthread_quickedit template:
<phrase 1="$bbuserinfo[username]" 2="$date" 3="$time">$vbphrase['post_edited_by_x_on_y_at_z']</phrase>
Hmm... I tried adding that in several different places in the template and get parsing errors no matter where I put it. What is it supposed to do exactly? I don't really know how the moderator log is updated but I can't see how that would do it either. :ermm:

[EvilLS1]

tmhall,
I was thinking maybe the phrase needed to be defined or something but I guess not. Seems like it should put the correct info in the modlog b/c even when using quick edit changes are still made through editpost.php. I wish I could tell you why its not doing that but I have no idea.

[EvilLS1]

Just thought I'd let you know, things are no longer subscribing. Everything seems peachy now. :D
Glad to hear that. :)

[Karthick]

Glad to hear that. :)
I tried to install this, but the button doesn't even appear. Tested in IE and FireFox.

Followed the instructions carefully twice.

[Karthick]

It works now...

/me clicks install

[Karthick]

It works now...

* Karthick clicks install
Is there any way to show for admin and mod every post that they are able to edit (other peoples too)

[Karthick]

Is there any way to show for admin and mod every post that they are able to edit (other peoples too)
In FireFox the box appears somewhere in the middle of the screen. Is there any way to make the corner of it touch the button, just like in IE?

[Karthick]

In FireFox the box appears somewhere in the middle of the screen. Is there any way to make the corner of it touch the button, just like in IE?
<if condition="$bbuserinfo['signature'] != ''"> is wrong. It only shows the signature box if the VIEWER has signature. It should show signature box if the poster has signature right? Got this trouble after alloying admin and mod to quickedit.

I just took out that conditional statement. The sig box is there all the time, but if it is checked when the user doesn't have signature, it still goes through, giving no errors.

Actually, changed to this code now: If there is a signature on the post, the box will be checked, if there is no signature it will be unchecked.

<if condition="!$post['signature']"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" /><span class="smallfont">Signature</span></label></if>
<if condition="$post['signature'] != ''"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked /><span class="smallfont">Signature</span></label></if>

[EvilLS1]

<if condition="$bbuserinfo['signature'] != ''"> is wrong. It only shows the signature box if the VIEWER has signature. It should show signature box if the poster has signature right? Got this trouble after alloying admin and mod to quickedit.


No, its not wrong. This hack was not designed to let admins and mods use quick edit for editing other people's posts. Thats just an add-on which was requested here. If the hack is used the way it was intended then <if condition="$bbuserinfo['signature'] != ''"> will work flawlessly. :)


In FireFox the box appears somewhere in the middle of the screen. Is there any way to make the corner of it touch the button, just like in IE?

I noticed that too but I have no idea why it does that in firefox.

[Karthick]

No, its not wrong. This hack was not designed to let admins and mods use quick edit for editing other people's posts. Thats just an add-on which was requested here. If the hack is used the way it was intended then <if condition="$bbuserinfo['signature'] != ''"> will work flawlessly. :)

I know. The code I gave above is for people that let admin/mod quick edit.

[sketch42]

I think so. You'd just need to copy the necessary code from the editpost template and put it in the showthread_quickedit template. Should be really easy.
bah i cant find it.. i tried copying this code

<if condition="$show['basic_bbcode']">
<td><div class="imagebutton"><a href="#" onclick="return vbcode('B', '')" accesskey="b"><img class="image" src="$stylevar[imgdir_editor]/bold.gif" alt="$vbphrase[bold]" width="21" height="20" border="0" /></a></div></td>
<td><div class="imagebutton"><a href="#" onclick="return vbcode('I', '')" accesskey="i"><img class="image" src="$stylevar[imgdir_editor]/italic.gif" alt="$vbphrase[italic]" width="21" height="20" border="0" /></a></div></td>
<td><div class="imagebutton"><a href="#" onclick="return vbcode('U', '')" accesskey="u"><img class="image" src="$stylevar[imgdir_editor]/underline.gif" alt="$vbphrase[underline]" width="21" height="20" border="0" /></a></div></td>
<td><img src="$stylevar[imgdir_editor]/separator.gif" alt="" width="6" height="20" border="0" /></td>
</if>

but that didnt work

[EvilLS1]

Try removing the <if > condition.
<if condition="$show['basic_bbcode']">
</if>

Then make sure the form name is the same for both the quick edit form and the edit post form.

[sketch42]

Try removing the <if > condition.
<if condition="$show['basic_bbcode']">
</if>

Then make sure the form name is the same for both the quick edit form and the edit post form.
no matter where i put the code the quick edit box gets all messed up.... should i put it at the very top of the quick edit template?

[EvilLS1]

no matter where i put the code the quick edit box gets all messed up.... should i put it at the very top of the quick edit template?

Sounds like misaligned table tags. No big deal. Tell ya what.. I should have some free time this weekend so I'll get it working on my test forum and then send you the code.

[sketch42]

Sounds like misaligned table tags. No big deal. Tell ya what.. I should have some free time this weekend so I'll get it working on my test forum and then send you the code.
:classic:

[zetetic]

Hey Evil,

I found the following blocks in the update post section of editpost.php. I think this might give a hint as to how to make quick edit update the moderator log properly, but I'm just guessing. :)

// if this is a mod edit, then log it
if ($bbuserinfo['userid'] != $postinfo['userid'] AND can_moderate($threadinfo['forumid'], 'caneditposts'))
{
$string = construct_phrase($vbphrase['post_edited_by_x_on_y_at_z'], $bbuserinfo['userid'], $date, $time);
$modlogsql[] = "($bbuserinfo[userid], " . TIMENOW . ", $threadinfo[forumid], $threadinfo[threadid], $postid, '" . addslashes($string) . "')";
}

Then a little below that:

// moderator log
if (!empty($modlogsql))
{
$DB_site->query("
INSERT INTO " . TABLE_PREFIX . "moderatorlog (userid, dateline, forumid, threadid, postid, action)
VALUES " . implode(', ', $modlogsql)
);
}

Reminder, what's getting logged now is:

Post edited by 2 on at .

[zetetic]

Just thought I'd let you know, things are no longer subscribing. Everything seems peachy now. :D
I'm still having this problem too. Did you nail it down to something specific, Evil?

[Cold Steel]

/me installs.

Another feature for my paying members.

[EvilLS1]

Tom,
Thanks, I'll tinker with that code this weekend and see if we can make it work.

As for the auto-subscribing problem that phoenixBB was having, it turned out to be something else not related to Quick Edit. Is it auto-subscribing your members?

[zetetic]

Tom,
Thanks, I'll tinker with that code this weekend and see if we can make it work.
Cool, thanks.

As for the auto-subscribing problem that phoenixBB was having, it turned out to be something else not related to Quick Edit. Is it auto-subscribing your members?
Yup. Here are the results of my latest tests across three user accounts:

1. When admin1 quickedits a post that isn't his, nothing happens.
2. When admin1 quickedits his own post, he is subscribed.
3. When admin2 quickedits her own post, she is subscribed.
4. When testuser1 quickedits his own post he is subscribed.

My current quickedit template:


<span id="quickedit_$post[postid]">
<img src="$stylevar[imgdir_button]/quickedit.gif" alt="Quick Edit" border="0" />
<script type="text/javascript"> vbmenu_register("quickedit_$post[postid]", true); </script>
</span>
<div class="vbmenu_popup" id="quickedit_$post[postid]_menu" style="display:none">
<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="updatepost" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="posthash" value="$posthash" />
<input type="hidden" name="poststarttime" value="$poststarttime" />
<input type="hidden" name="disablesmilies" value="0" />
<input type="hidden" name="parseurl" value="1" id="cb_parseurl" />
<input type="hidden" name="iconid" value="$post[iconid]" />
<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="center">
<tr>
<td class="tcat" align="left">
<strong>$vbphrase[edit_post]</strong>
</td>
</tr>
<tbody>
<tr valign="top">
<td class="panelsurround" align="center">
<div class="panel">
<div align="left">
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[reason_for_editing]:</div>
<div><input type="text" class="bginput" name="reason" value="$newpost[reason]" size="50" maxlength="200" tabindex="1" title="$vbphrase[optional]" /><input type="hidden" name="reason_exists" value="$edit[reason_exists]" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[title]:</div>
<div><input type="text" class="bginput" name="title" value="$post[title]" size="60" maxlength="85" tabindex="1" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[message]:</div>
<div><textarea name="message" class="bginput" style="width:433px; height:125px;" wrap="virtual" tabindex="1">$edittext</textarea></div>
</div>
<fieldset class="fieldset">
<legend>$vbphrase[miscellaneous_options]</legend>
<div style="padding:3px">
<if condition="$bbuserinfo['signature'] != ''"><div><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked />$vbphrase[show_your_signature]</label></div></if>
<div><label for="cb_parseurl"><input type="checkbox" name="parseurl" value="1" id="cb_parseurl" tabindex="1" checked />$vbphrase[automatically_parse_links_in_text]</label></div>
<div><label for="cb_disablesmilies"><input type="checkbox" name="disablesmilies" value="1" id="cb_disablesmilies" tabindex="1" />$vbphrase[disable_smilies_in_text]</label></div>
</div>
</fieldset>
</div>
</div>
<div style="margin-top:6px">
<input type="submit" class="button" name="sbutton" value="Save Changes" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="Preview Changes" accesskey="p" tabindex="1" />

<if condition="$bbuserinfo['signature'] != ''"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked /><span class="smallfont">Signature</span></label></if>
</div>
</td>
</tr>
</tbody>
</table>
</form>
</div>

[EvilLS1]

Tom,
Your template seems to be missing this:

<input type="hidden" name="emailupdate" value="9999" />


Put that back in there and it should no longer subscribe when editing.

[zetetic]

Tom,
Your template seems to be missing this:

<input type="hidden" name="emailupdate" value="9999" />


Put that back in there and it should no longer subscribe when editing.
Huh. I swear you said to take that out as a possible fix earlier in this thread, but I don't have time to go back and look. Anyway I'll go ahead and put it back in. ;)

What does it mean, btw?

[EvilLS1]

Huh. I swear you said to take that out as a possible fix earlier in this thread, but I don't have time to go back and look. Anyway I'll go ahead and put it back in. ;)

What does it mean, btw?
I did tell phoenixbb to take that out earlier, but I don't know what I was thinking. That needs to be in there if you don't want it to subscribe.


What does it mean, btw?

The hidden input of 9999 just sets it so that it doesnt subscribe. Any number other than 1 would probably work just as well.

[zetetic]

Ah, groovy. Thanks. :)

Edited to add: Well not any number. I tried zero and it didn't work. :ninja:

9999 works fine, though. Thanks. :)

[Deska]

This is nice hack.
Just want to know, how to make close pop up if user decide to cancel edit post?

Thank's a lot....

[EvilLS1]

This is nice hack.
Just want to know, how to make close pop up if user decide to cancel edit post?

Thank's a lot....
Just click anywhere on the page and the box will disappear. :)

[9mmPrincess]

i tried this hack and it didnt work and i dont know what i did wrong :(

[9mmPrincess]

nevermind, twas the ever popular misplaced comma, got it working now, great mod :)

[TTG]

Clicked install .. works well .. very useful hack https://vborg.vbsupport.ru/external/2005/01/2.gif

[sv1cec]

Clicking install, although in the first post I tried to edit (mine, I am the admin, and I have not installed any additional code) it erased the signature. After that it works OK, go figure.

No, the problem is still there. I just tried to edit another old post of mine, and it erased the signature. Can you PLEASE help?

Conditions: I am the admin of the forums, I've added no other code except the one of the file in Post #1, I tried to edit an old post of mine and it erased the signature (the Show Singature box was checked but greyed). Then I entered a new post, edit it and it didn't erase the signature (the Show Signature box was checked but not greyed). The I tried to edit another old post of mine, and it erased the signature (again Singature Box checked but grey).

I'll do some more investigation and I'll report back if I find something different.

It looks consistent, if I try to edit an old post, the Show Signature box comes out checked and greyed. In this case, the signature is deleted. The same thing happends (Show Signature greyed and checked), if the poster didn't have a signature when he entered the post. In this case, it does not enter the signature that the user now has.

I'll remove the "Quick Edit" icon from the postbit and postbit_legacy, until we can find a solution.

Rgds and Tnx

[EvilLS1]

sv1cec,
Very strange. It doesn't seem to be happening on my site. Not sure what could be causing it.

Try this and let me know if it still happens:

In the QE template find:

<if condition="$bbuserinfo['signature'] != ''"> <label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked /><span class="smallfont">Signature</span></label></if>


Replace it with:

<if condition="$bbuserinfo['signature'] != ''">
<input type="checkbox" name="signature" value="1" checked /><span class="smallfont">Signature</span></if>

[sv1cec]

sv1cec,
Very strange. It doesn't seem to be happening on my site. Not sure what could be causing it.

Try this and let me know if it still happens:

In the QE template find:

<if condition="$bbuserinfo['signature'] != ''"> <label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked /><span class="smallfont">Signature</span></label></if>


Replace it with:

<if condition="$bbuserinfo['signature'] != ''">
<input type="checkbox" name="signature" value="1" checked /><span class="smallfont">Signature</span></if>

THANK YOU SIR!

This seems to fix the problem. The admins post do not loose their signature now, and a user who had a post when he had no signature, can now edit, and the QE hack respects the new condition and adds the signature.

The final issue I have, has to do with the location of the window, which opens up for QE. Suppose I have a post and I hit the QE button. Then I cancel it. Then I hit QE again, and the window open a bit further to the left, than the first time. Cancel it again and hit QE again, and the window is almost 50% out of the screen. Something works incrementaly in the location of the window, as far as its horizontal positioning is concerned.

On the same issue, if the post's QE button, is too low on your screen, the QE window opens up below the button, so sometimes it hardly appears on the screen. I assume that if this is the case (QE button too far down), the window should open above it, instead of below it.

On another issue, could you please update the instructions on the following two issues:

- If one wants to give the user the ability to delete his post, what should one add to the showthread_quickedit template?
- If one wants to show the QE to people who can moderate and administrate, as well as the poster, what are the changes that need to be made? The ones descrined in post #9, seem to be outdated now. I also do not want to go with the method described in the early stages of this thread, using $bbuserinfo['usergroupid'] ==6 , I'd rather have can_moderate($forum[forumid]). In this case thought, there should be some changes in the signature handling, where $postinfo['signature'] should be used. I am not sure however, where these changes should occur. Any help?

Another issue, would it be possible to have a working "Cancel" button. The method of clicking outside the QE box is logical for programmers etc. but not so intuitive for end-users. Plus, sometimes clicking outside the box does not close it (if you click right next to the box, to its left or to its right) and you have to click again, above it or below it, to make it go.

Finally, if I may add my 2 Eurocents, I think that the QE button should be just before the Edit button. I think this is a more logical position than between the Quote and the Quick Reply buttons. I also took some time to make a QE button to match the other buttons in the standard vB installation. If you like it you may use it.

https://vborg.vbsupport.ru/external/2004/07/1.gif

Have I clicked install? I think I have.

Thank you for a nice addition to my forum.

[EvilLS1]

sv1cec,
Thank you for your suggestions. I will address a few of them now but others will have to wait until the next version as I don't have much time to work on hacks these days.


The final issue I have, has to do with the location of the window, which opens up for QE. Suppose I have a post and I hit the QE button. Then I cancel it. Then I hit QE again, and the window open a bit further to the left, than the first time. Cancel it again and hit QE again, and the window is almost 50% out of the screen. Something works incrementaly in the location of the window, as far as its horizontal positioning is concerned.

Yes I've noticed that too. It seems to be a browser specific problem (mozilla/firefox) and I can't figure out the solution for the life of me. I will figure it out before the next version is released.


On the same issue, if the post's QE button, is too low on your screen, the QE window opens up below the button, so sometimes it hardly appears on the screen. I assume that if this is the case (QE button too far down), the window should open above it, instead of below it.

This is by design. I wanted the window to open below the post so that the user can still see the original post while editing. Should be fairly easy to change though.


- If one wants to give the user the ability to delete his post, what should one add to the showthread_quickedit template?


Thats a good idea. Quick delete would be handy for those who have that privilege. I'll add that to the next version.


- If one wants to show the QE to people who can moderate and administrate, as well as the poster, what are the changes that need to be made? The ones descrined in post #9, seem to be outdated now. I also do not want to go with the method described in the early stages of this thread, using $bbuserinfo['usergroupid'] ==6 , I'd rather have can_moderate($forum[forumid]). In this case thought, there should be some changes in the signature handling, where $postinfo['signature'] should be used. I am not sure however, where these changes should occur. Any help?


IMO its not a good idea to allow mods/admins to quickedit all posts and here's why: With the way this hack works it must load the post text two times in posts where the viewer has the ability to quick edit. So if you set it so that admins can quickedit all posts the post text for every post within a thread will be loaded twice in his browser (once viewable and once hidden) which could slow down the load time a bit. Theres also a problem with the moderater log not showing some info for posts that were quick edited by mods & admins. This is why I didn't include that feature with the hack in the first place. If you still want to allow staff to edit all posts let me know and I'll post the code changes.


Another issue, would it be possible to have a working "Cancel" button. The method of clicking outside the QE box is logical for programmers etc. but not so intuitive for end-users. Plus, sometimes clicking outside the box does not close it (if you click right next to the box, to its left or to its right) and you have to click again, above it or below it, to make it go.

In the first version of QE there was a cancel button which closed the window. The newest version uses vB's standard vbmenu_popup to show the Quick Edit box. This is the same function that shows the little drop down box of links when you click on someones username within a post. It also works the same way so when you want to exit the box you just click somewhere on the page and it will disappear. If you'd rather use the first version it can be found here:
https://vborg.vbsupport.ru/showpost.php?p=494963&postcount=95
(also, the first version doesn't seem to have the problem with mozilla where the window opens further to the left every time its clicked, so you may like it better)


I also took some time to make a QE button to match the other buttons in the standard vB installation. If you like it you may use it.

https://vborg.vbsupport.ru/external/2004/07/1.gif


Thank you. I've added a link to your post in the first post of this thread so that people may use your image.

Cool site BTW. The 1911 is my favorite handgun of all time. I have a Colt Gold Cup Trophy and a Combat Commander. :)

[sv1cec]

EvilLS1, thanks for coming back to me, I wish all developers here were as prompt as you are. Also, thanks for the nice words on M1911.ORG, appreciated.

As far as the hack is concerned, please read my comments below:

sv1cec,
Thank you for your suggestions. I will address a few of them now but others will have to wait until the next version as I don't have much time to work on hacks these days.

Thank YOU, for taking the time to help us all.


Yes I've noticed that too. It seems to be a browser specific problem (mozilla/firefox) and I can't figure out the solution for the life of me. I will figure it out before the next version is released.

I guess I can live with it for the time being, I do not think anyone will be crazy enough to press QE and then cancel it so many times to have the window move out of the screen. What's wierd is that this does not happen if you "Save" the edited post. In this case, the window gets opened in the same position, every time. It shifts to the left, only if you cancel and re-edit.


This is by design. I wanted the window to open below the post so that the user can still see the original post while editing. Should be fairly easy to change though.

That, I would appreciate it. The way it works now, it's sometimes possible to not notice that the window has opened. It happened to me once, so I guess it can happen to others, who are used to leaving the buttons down on their screen while reading the posts, and hit one of them to edit or quickreply. If you can show me the code, I can ... test it. And since the new window shows the existing post text, it is not necessary to be able to see the post in the background. What I would suggest is to have the window open, right next to the button, with the button being about the middle of the windows height. In that way, the window will be apparent, no matter where the QE button was when it was pressed.

Thats a good idea. Quick delete would be handy for those who have that privilege. I'll add that to the next version.

I guess it shouldn't be too difficult, maybe we can copy the code from the standard Edit form. I'll give it a try tomorrow morning (late night for you) and I'll update you on my results.

IMO its not a good idea to allow mods/admins to quickedit all posts and here's why: With the way this hack works it must load the post text two times in posts where the viewer has the ability to quick edit. So if you set it so that admins can quickedit all posts the post text for every post within a thread will be loaded twice in his browser (once viewable and once hidden) which could slow down the load time a bit. Theres also a problem with the moderater log not showing some info for posts that were quick edited by mods & admins. This is why I didn't include that feature with the hack in the first place. If you still want to allow staff to edit all posts let me know and I'll post the code changes.

Oh no, I do not want that. I was not aware that the contents of the posts which are QE-table are loaded twice. If you do what I suggested, it will take twice as much time to load a page than before, so cancel that ... request Sir.


In the first version of QE there was a cancel button which closed the window. The newest version uses vB's standard vbmenu_popup to show the Quick Edit box. This is the same function that shows the little drop down box of links when you click on someones username within a post. It also works the same way so when you want to exit the box you just click somewhere on the page and it will disappear. If you'd rather use the first version it can be found here:
https://vborg.vbsupport.ru/showpost.php?p=494963&postcount=95
(also, the first version doesn't seem to have the problem with mozilla where the window opens further to the left every time its clicked, so you may like it better)

I tried that version and it's not as good as yours. When you click on the Edit Post text (or the button, that's irrelevant), the screen skips to the top of the page and you have to scroll down to find the new window. From the way this vB feature works, in the menu on the user name, and the window of QE, I assume you have missed something. I mean, in QE it seems as if the window is somehow occupying the whole width of the screen. If you click to the left or to the right of the window, the program thinks you are clicking in the window and it does not close. You have to click either above or below that screen area, to close the window. I'll try and figure out how the code for the little menu works and see if I can find anyway to solve that problem, and keep you posted. But, please, if you come up with something let me know. It's quite confusing for the end user. Also, that Gold version does not handle the signatures properly, while yours works fine for me.

Thank you. I've added a link to your post in the first post of this thread so that people may use your image.

I am honored, I haven't done anything worthwhile to be included there. If you want, I can give you the code I have come up for my pop-up window, which I think is more ... beautiful than yours (no pan intended), and does away with the preview button. If someone wants to have the full editing features, he can use the normal Edit button. The QE is just for quick work, so I decided that the Preview is not necessary.

Well, enough said, I'll work on this tomorrow early in the morning and post accordingly.

Again, many thanks for a great hack, appreciated.

[sv1cec]

EvilLS1,

After some experimentation, I have found the following solution for the shifting window problem.

In the showthread_quickedit template, find this:


<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="center">


Replace it with:


<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="left">


This seems to solve the problem in Netscape and works OK (as it worked) in IE. The only issue is that the background fill in the top bar of the window, does not completely cover whatever is behind it, so as a temporary fix (or permanent, I like it that way), I also did the following changes:

In the template, find this:


<td class="tcat" align="left">
<strong>$vbphrase[edit_post]</strong>


Replaced it with:


<td bgcolor="#3A5383" align="left">
<strong><font color="#ffffff">$vbphrase[edit_post]</FONT></strong>


With this change, the window does not shift to the left, and also, it closes if you click anywhere around it, not only above or below it, as it used to do before. Something with the width of the table is mixing things up, I guess.

Now, if only we could include the "Delete this post" option, that would be great.

Rgds

[EvilLS1]

sv1cec,
Nice job! I added your browser fix to the first post (with credit to you, of coarse).

As for the "delete this post" option, try this:

In functions_showthread.php find:

// End Quick Edit hack


Above it add:

if ($isfirstpost AND can_moderate($thread['forumid'], 'canmanagethreads'))
{
$show['deletepostoption'] = true;
}
else if (!$isfirstpost AND can_moderate($thread['forumid'], 'candeleteposts'))
{
$show['deletepostoption'] = true;
}
else if (((($forumperms & CANDELETEPOST) AND !$isfirstpost) OR (($forumperms & CANDELETETHREAD) AND $isfirstpost)) AND $bbuserinfo['userid'] == $post['userid'])
{
$show['deletepostoption'] = true;
}
else
{
$show['deletepostoption'] = false;
}


Now replace your showthread_quickedit template with this:

<span id="quickedit_$post[postid]">
<img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" />
<script type="text/javascript"> vbmenu_register("quickedit_$post[postid]", true); </script>
</span>
<div id="quickedit_$post[postid]_menu" style="display:none">
<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="left">
<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="updatepost" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="posthash" value="$posthash" />
<input type="hidden" name="poststarttime" value="$poststarttime" />
<input type="hidden" name="emailupdate" value="9999" />
<input type="hidden" name="disablesmilies" value="0" />
<input type="hidden" name="parseurl" value="1" id="cb_parseurl" />
<input type="hidden" name="iconid" value="$post[iconid]" />
<tr>
<td class="tcat" align="left">
<strong>$vbphrase[edit_post]</strong>
</td>
</tr>
<tbody>
<tr valign="top">
<td class="panelsurround" align="center">
<div class="panel">
<div align="left">
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[title]:</div>
<div><input type="text" class="bginput" name="title" value="$post[title]" size="60" maxlength="85" tabindex="1" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[message]:</div>
<div><textarea name="message" class="bginput" style="width:433px; height:125px;" wrap="virtual" tabindex="1">$edittext</textarea></div>
</div>
</div>
</div>
<div style="margin-top:6px">
<input type="submit" class="button" name="sbutton" value="Save Changes" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="Preview Changes" accesskey="p" tabindex="1" />

<if condition="$bbuserinfo['signature'] != ''"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked /><span class="smallfont">Signature</span></label></if>
</div>
</td>
</tr>
</tbody>
</form>
<if condition="$show['deletepostoption']">
<br />
<form action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="do" value="deletepost" />

<tr>
<td class="tcat" align="left">

$vbphrase[delete_this_message]
</td>
</tr>
<tbody id="collapseobj_editpost_delete" style="$vbcollapse[collapseobj_editpost_delete]">
<tr>
<td class="panelsurround" align="center">
<div class="panel">
<div style="width:65" align="$stylevar[left]">

<div class="fieldset">
<div>$vbphrase[delete_message_check_appropriate_option]</div>
<if condition="$show['firstpostnote']">
<div>$vbphrase[deleting_message_deletion_of_thread]</div>
</if>
</div>

<fieldset class="fieldset">
<legend>$vbphrase[delete_options]</legend>
<div style="padding:$stylevar[formspacer]px">
<div>
<label for="rb_del_leave"><input type="radio" name="deletepost" value="" id="rb_del_leave" tabindex="1" checked="checked" />$vbphrase[do_not_delete_message]</label>
</div>
<div>
<label for="rb_del_soft"><input type="radio" name="deletepost" value="delete" id="rb_del_soft" tabindex="1" />$vbphrase[delete_message]</label>
<if condition="$show['physicaldeleteoption'] AND $show['keepattachmentsoption']">(<label for="cb_keepattachments"><input type="checkbox" name="keepattachments" value="1" id="cb_keepattachments" tabindex="1" />$vbphrase[keep_attachments]</label>)</if>
</div>
<if condition="$show['physicaldeleteoption']">
<div>
<label for="rb_del_hard"><input type="radio" name="deletepost" value="remove" id="rb_del_hard" tabindex="1" />$vbphrase[physically_remove_message]</label>
</div>
</if>
</div>
</fieldset>

<div class="smallfont">
<div>$vbphrase[reason_for_deletion]:</div>
<input type="text" class="bginput" name="reason" size="50" tabindex="1" title="$vbphrase[optional]" />
</div>

</div>
</div>

<div style="margin-top:$stylevar[cellpadding]px">
<input type="submit" class="button" value="$vbphrase[delete_this_message]" tabindex="1" accesskey="s" />
</div>

</td>
</tr>
</tbody>
</form>
</if>
</table>
</div>


Keep in mind that I haven't had time to really test this so it might or might not work correctly. But it should be a good starting point for you if you wish to add this feature to your QE.

If you'd like, you can tinker with the code and get it looking and working perfectly and then post your own instructions for the add-on here and I'll add a link to your post so that others can add this feature if they want. Or you could even post it in the add-ons section in its own thread. :)

Later,
Dewayne

[EvilLS1]

If you want, I can give you the code I have come up for my pop-up window, which I think is more ... beautiful than yours (no pan intended), and does away with the preview button. If someone wants to have the full editing features, he can use the normal Edit button. The QE is just for quick work, so I decided that the Preview is not necessary.

If you want, you can post your version here and I'll link to it in the first post as an alternate QE template. :)

[sv1cec]

Dewayne,

Thanks for the input, appreciated.

It works OK, as long as the post you try to edit, is not the first one in a thread, which is all right for a normal user (they are not given permission to delete their threads).

If it is the first one, it does not even go in the delete form of the template, even though I am the admin, and I just posted that post (no time exceeded).

I think it has to do something with the conditionals in the functions_showthread.php.

Could you pleeeeease have a look???

Tnx

[EvilLS1]

John,
To make it function exactly as it does in editpost.php you'd need to add this bit of code to functions_showthread.php:

// find out if first post
$getpost = $DB_site->query_first("
SELECT postid
FROM " . TABLE_PREFIX . "post
WHERE threadid=$threadinfo[threadid]
ORDER BY dateline
LIMIT 1
");
if ($getpost['postid'] == $postid)
{
$isfirstpost = true;
}
else
{
$isfirstpost = false;
}


This will add a query to showthread though. Not worth it IMO.

Dewayne

[sv1cec]

John,
To make it function exactly as it does in editpost.php you'd need to add this bit of code to functions_showthread.php:

(code ommited)

This will add a query to showthread though. Not worth it IMO.

Dewayne

Dewayne,

Let me understand that. You mean that the existing conditionals cannot function, until the $isfirstpost is set by the code you gave me?

Well, the code does not work as it is, it produces the following error:

Database error in vBulletin 3.0.1:

Invalid SQL:
SELECT postid
FROM post
WHERE threadid=
ORDER BY dateline
LIMIT 1

mysql error: You have an error in your SQL syntax near 'ORDER BY dateline
LIMIT 1
' at line 5

mysql error number: 1064

I also tried to fool the hack, by inserting a $isfirstpost = true statement, just above the conditionals. The behaviour is still the same. For some reason, it never sets the $show['deletepostoption'] to true, even though the $isfirstpost is always true.

I am not sure what the problem is, but $isfirstpost doesn't seem to be the solution.

Rgds

[EvilLS1]

Change $threadinfo[threadid] to $thread[threadid] in the query and it should work.

[sv1cec]

Change $threadinfo[threadid] to $thread[threadid] in the query and it should work.

The query does not complain any more, but still it does not work as expected. In other words, if the post I try to edit is the first post (even though I am the admin), it does not show me the delete part of my QE.

I even added another IF, to check if the user ID is 1, if the user ID and the poster are the same and if the post is the first one. It still does not work. I am doomed! Here is the code from functions_showthread


// Quick Edit hack
if ($post['userid'] == $bbuserinfo['userid'])
{
$edittext = htmlspecialchars_uni($post['pagetext']);
eval('$quickedit = "' . fetch_template('showthread_quickedit') . '";');
}
else
{
$edittext="";
$quickedit="";
}
// find out if first post
$getpost = $DB_site->query_first("
SELECT postid
FROM " . TABLE_PREFIX . "post
WHERE threadid=$thread[threadid]
ORDER BY dateline
LIMIT 1
");
if ($getpost['postid'] == $postid)
{
$isfirstpost = true;
}
else
{
$isfirstpost = false;
}
if ($isfirstpost AND can_moderate($thread['forumid'], 'canmanagethreads'))
{
$show['deletepostoption'] = true;
}
else if (!$isfirstpost AND can_moderate($thread['forumid'], 'candeleteposts'))
{
$show['deletepostoption'] = true;
}
else if (((($forumperms & CANDELETEPOST) AND !$isfirstpost) OR (($forumperms & CANDELETETHREAD) AND $isfirstpost)) AND $bbuserinfo['userid'] == $post['userid'])
{
$show['deletepostoption'] = true;
}

// I ADDED THIS IF BELOW, IT STILL DOES NOT SHOW THE DELETE PART OF MY QE.

else if ($bbuserinfo['userid'] == 1 AND $bbuserinfo['userid'] == $post['userid'] AND $isfirstpost)
{
$show['deletepostoption'] = true;
}
else
{
$show['deletepostoption'] = false;
}
// End Quick Edit hack


As I said, I am no php expert, but a little further up in that file, there is this code:


$forumperms = fetch_permissions($thread['forumid']);
if (
!$thread['isdeleted'] AND (
can_moderate($thread['forumid'], 'caneditposts') OR
can_moderate($thread['forumid'], 'candeleteposts') OR
(
$thread['open'] AND
$post['userid'] == $bbuserinfo['userid'] AND
($forumperms & CANEDITPOST) AND
( $post['dateline'] >= (TIMENOW - ($vboptions['edittimelimit'] * 60)) OR
$vboptions['edittimelimit'] == 0
)
))


I think this code is used to decide if the "Edit" button should be shown. Wouldn't that be OK in our case?

I am not trying to be a smart-a**, just trying to help here, with my limited knowledge.

Again, I have to thank you for paying attention to my requests.

Rgds

P.S. (later this evening): No matter what I tried, I cannot make the QE show me the Delete post part, if the post is the first post in the thread. I guess this is beyong my abilities. You are my only solution.

Rgds

[EvilLS1]

John,
I have it working on my forum (even in the first post) using this code:

In functions_showthread.php find and delete the old code you added.

Now find this:

// Quick Edit hack


Below it add this:

$forumperms = fetch_permissions($thread['forumid']);

// find out if first post
$getpost = $DB_site->query_first("
SELECT postid
FROM " . TABLE_PREFIX . "post
WHERE threadid=$thread[threadid]
ORDER BY dateline
LIMIT 1
");
if ($getpost['postid'] == $post['postid'])
{
$isfirstpost = true;
}
else
{
$isfirstpost = false;
}



if ($isfirstpost AND can_moderate($thread['forumid'], 'canmanagethreads'))
{
$show['deletepostoption'] = true;
}
else if (!$isfirstpost AND can_moderate($thread['forumid'], 'candeleteposts'))
{
$show['deletepostoption'] = true;
}
else if (((($forumperms & CANDELETEPOST) AND !$isfirstpost) OR (($forumperms & CANDELETETHREAD) AND $isfirstpost)) AND $bbuserinfo['userid'] == $post['userid'])
{
$show['deletepostoption'] = true;
}
else
{
$show['deletepostoption'] = false;
}


Use this for the showthread_quickedit template:

<span id="quickedit_$post[postid]">
<img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" />
<script type="text/javascript"> vbmenu_register("quickedit_$post[postid]", true); </script>
</span>
<div id="quickedit_$post[postid]_menu" style="display:none">
<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="left">
<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="updatepost" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="posthash" value="$posthash" />
<input type="hidden" name="poststarttime" value="$poststarttime" />
<input type="hidden" name="emailupdate" value="9999" />
<input type="hidden" name="disablesmilies" value="0" />
<input type="hidden" name="parseurl" value="1" id="cb_parseurl" />
<input type="hidden" name="iconid" value="$post[iconid]" />
<tr>
<td class="tcat" align="left">
<strong>$vbphrase[edit_post]</strong>
</td>
</tr>
<tbody>
<tr valign="top">
<td class="panelsurround" align="center">
<div class="panel">
<div align="left">
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[title]:</div>
<div><input type="text" class="bginput" name="title" value="$post[title]" size="60" maxlength="85" tabindex="1" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[message]:</div>
<div><textarea name="message" class="bginput" style="width:433px; height:125px;" wrap="virtual" tabindex="1">$edittext</textarea></div>
</div>
</div>
</div>
<div style="margin-top:6px">
<input type="submit" class="button" name="sbutton" value="Save Changes" accesskey="s" tabindex="1" />
<input type="submit" class="button" name="preview" value="Preview Changes" accesskey="p" tabindex="1" />

<if condition="$bbuserinfo['signature'] != ''"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked /><span class="smallfont">Signature</span></label></if>
</div>
</td>
</tr>
</tbody>
</form>
<if condition="$show['deletepostoption']">
<br />
<form action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="do" value="deletepost" />

<tr>
<td class="tcat" align="left">

$vbphrase[delete_this_message]
</td>
</tr>
<tbody id="collapseobj_editpost_delete" style="$vbcollapse[collapseobj_editpost_delete]">
<tr>
<td class="panelsurround" align="center">
<div class="panel">
<div style="width:65" align="$stylevar[left]">

<div class="fieldset">
<div>$vbphrase[delete_message_check_appropriate_option]</div>
<if condition="$show['firstpostnote']">
<div>$vbphrase[deleting_message_deletion_of_thread]</div>
</if>
</div>

<fieldset class="fieldset">
<legend>$vbphrase[delete_options]</legend>
<div style="padding:$stylevar[formspacer]px">
<div>
<label for="rb_del_leave"><input type="radio" name="deletepost" value="" id="rb_del_leave" tabindex="1" checked="checked" />$vbphrase[do_not_delete_message]</label>
</div>
<div>
<label for="rb_del_soft"><input type="radio" name="deletepost" value="delete" id="rb_del_soft" tabindex="1" />$vbphrase[delete_message]</label>
<if condition="$show['physicaldeleteoption'] AND $show['keepattachmentsoption']">(<label for="cb_keepattachments"><input type="checkbox" name="keepattachments" value="1" id="cb_keepattachments" tabindex="1" />$vbphrase[keep_attachments]</label>)</if>
</div>
<if condition="$show['physicaldeleteoption']">
<div>
<label for="rb_del_hard"><input type="radio" name="deletepost" value="remove" id="rb_del_hard" tabindex="1" />$vbphrase[physically_remove_message]</label>
</div>
</if>
</div>
</fieldset>

<div class="smallfont">
<div>$vbphrase[reason_for_deletion]:</div>
<input type="text" class="bginput" name="reason" size="50" tabindex="1" title="$vbphrase[optional]" />
</div>

</div>
</div>

<div style="margin-top:$stylevar[cellpadding]px">
<input type="submit" class="button" value="$vbphrase[delete_this_message]" tabindex="1" accesskey="s" />
</div>

</td>
</tr>
</tbody>
</form>
</if>
</table>
</div>



As I said, I am no php expert, but a little further up in that file, there is this code:

I am not trying to be a smart-a**, just trying to help here, with my limited knowledge.


No worries. I'm no php guru either. I just tinker with the code until it does what I want. Great way to learn IMO. :)

[sv1cec]

Dewayne,

Great, that did it. One small problem, it breaks the PM system, when you try to view a PM. We need to have that part of the code, work only in showthreads and not in ... showPM (that doesn't exist obviously, just joking).

What happens is that when a user tries to see one of the PMs in his inbox, the query is run and he gets the following error:

Database error in vBulletin 3.0.1:

Invalid SQL:
SELECT postid
FROM post
WHERE threadid=
ORDER BY dateline
LIMIT 1

mysql error: You have an error in your SQL syntax near 'ORDER BY dateline
LIMIT 1
' at line 5

mysql error number: 1064

Date: Wednesday 28th of July 2004 02:19:04 AM
Script: http://forum.m1911.org/private.php?do=showpm&pmid=733
Referer: http://forum.m1911.org/private.php?
Username: John
IP Address:

Here is what I found:

Replace the QE code in includes/function_showthread.php, with the one below:


// Quick Edit hack
if (THIS_SCRIPT=='showthread' AND $post['editlink'] AND $bbuserinfo[userid]>0)
{
$forumperms = fetch_permissions($thread['forumid']);

// find out if first post
$getpost = $DB_site->query_first("
SELECT postid
FROM " . TABLE_PREFIX . "post
WHERE threadid=$thread[threadid]
ORDER BY dateline
LIMIT 1
");
if ($getpost['postid'] == $post['postid'])
{
$isfirstpost = true;
}
else
{
$isfirstpost = false;
}


if ($isfirstpost AND can_moderate($thread['forumid'], 'canmanagethreads'))
{
$show['deletepostoption'] = true;
}
else if (!$isfirstpost AND can_moderate($thread['forumid'], 'candeleteposts'))
{
$show['deletepostoption'] = true;
}
else if (((($forumperms & CANDELETEPOST) AND !$isfirstpost) OR (($forumperms & CANDELETETHREAD) AND $isfirstpost)) AND $bbuserinfo['userid'] == $post['userid'])
{
$show['deletepostoption'] = true;
}
else
{
$show['deletepostoption'] = false;
}

if ($post['userid'] == $bbuserinfo['userid'])
{
$edittext = htmlspecialchars_uni($post['pagetext']);
eval('$quickedit = "' . fetch_template('showthread_quickedit') . '";');
}
else
{
$edittext="";
$quickedit="";
}
}
// End Quick Edit hack


With this if in the beginning, it works fine.

Below is my version of the showthread_quickedit template. I've made it a bit cramped, so that it is indeed a QUICK edit. It includes the editing and the deleting function.


<span id="quickedit_$post[postid]">
<img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" />
<script type="text/javascript"> vbmenu_register("quickedit_$post[postid]", true); </script>
</span>
<div id="quickedit_$post[postid]_menu" style="display:none">
<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="updatepost" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="posthash" value="$posthash" />
<input type="hidden" name="poststarttime" value="$poststarttime" />
<input type="hidden" name="emailupdate" value="9999" />
<input type="hidden" name="disablesmilies" value="0" />
<input type="hidden" name="parseurl" value="1" id="cb_parseurl" />
<input type="hidden" name="iconid" value="$post[iconid]" />
<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="left" bgcolor="#D6DAE5">
<tr>
<td bgcolor="#3A5383" align="left">
<TABLE width="100%">
<TR>
<TD align="left"><font color="#ffffff">
$vbphrase[edit_post]</FONT>
</TD>
<TD align="right"><font color="#ffffff">
<div class="smallfont" align="right">Click anywhere outside this box, to cancel editing.</DIV></FONT>
</TD>
</TR>
</TABLE>
</td>
</tr>
<tbody>
<tr valign="top">
<td class="panelsurround" align="center">
<div class="panel">
<div align="left">
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[reason_for_editing]:</div>
<div><input type="text" class="bginput" name="reason" value="$newpost[reason]" size="50" maxlength="200" tabindex="1" title="$vbphrase[optional]" /><input type="hidden" name="reason_exists" value="$edit[reason_exists]" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>New $vbphrase[title]:</div>
<div><input type="text" class="bginput" name="title" value="$post[title]" size="50" maxlength="85" tabindex="1" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[message]:</div>
<div><textarea name="message" class="bginput" style="width:470px; height:125px;" wrap="virtual" tabindex="1">$edittext</textarea></div>
</div>
</div>
</div>
<TABLE width="100%">
<TR>
<TD ALIGN="LEFT">
<if condition="$bbuserinfo['signature'] != ''">
<input type="checkbox" name="signature" value="1" checked /><span class="smallfont">Signature</span></if>
</TD>
<TD ALIGN="RIGHT">
<input type="submit" class="button" name="sbutton" value="Save Changes" accesskey="s" tabindex="1" />
</TD>
</TR>
</TABLE>
</td>
</tr>
</tbody>
</form>
<if condition="$show['deletepostoption']">

<form action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="do" value="deletepost" />

<tr>
<td bgcolor="#3A5383" align="left">
<font color="#ffffff">$vbphrase[delete_this_message]</font>
</td>
</tr>
<tbody id="collapseobj_editpost_delete" style="$vbcollapse[collapseobj_editpost_delete]">
<tr>
<td class="panelsurround" align="center">
<div class="panel">
<div align="$stylevar[left]">
<div class="fieldset">
$vbphrase[delete_message_check_appropriate_option]&nbsp;

<if condition="$isfirstpost">
$vbphrase[deleting_message_deletion_of_thread]
</if>
</div>

<fieldset class="fieldset">
<legend>$vbphrase[delete_options]</legend>
<div style="padding:$stylevar[formspacer]px">
<div>
<label for="rb_del_leave"><input type="radio" name="deletepost" value="" id="rb_del_leave" tabindex="1" checked="checked" />$vbphrase[do_not_delete_message]</label>
</div>
<div>
<label for="rb_del_soft"><input type="radio" name="deletepost" value="delete" id="rb_del_soft" tabindex="1" />$vbphrase[delete_message]</label>
<if condition="$show['physicaldeleteoption'] AND $show['keepattachmentsoption']">(<label for="cb_keepattachments"><input type="checkbox" name="keepattachments" value="1" id="cb_keepattachments" tabindex="1" />$vbphrase[keep_attachments]</label>)</if>
</div>
<if condition="$show['physicaldeleteoption']">
<div>
<label for="rb_del_hard"><input type="radio" name="deletepost" value="remove" id="rb_del_hard" tabindex="1" />$vbphrase[physically_remove_message]</label>
</div>
</if>
</div>
</fieldset>

<div class="smallfont">
<div>$vbphrase[reason_for_deletion]:</div>
<input type="text" class="bginput" name="reason" size="50" tabindex="1" title="$vbphrase[optional]" />
</div>

</div>
</div>
<TABLE width="100%">
<TR>
<TD ALIGN="LEFT">
<div class="smallfont">Click anywhere outside this box, to cancel editing.</div>
</TD>
<TD ALIGN="RIGHT">
<input type="submit" class="button" value="$vbphrase[delete_this_message]" tabindex="1" accesskey="s" />
</TD>
</TR>
</TABLE>
</td>
</tr>
</tbody>
</form>
</if>
</table>
</div>


Maybe this helps some other folks here.

Rgds

[EvilLS1]

Nice job sv1cec ! I added a link to your post so that others can add your mod. :)

[Battle_Ring]

not sure if this has been asked, but can u make it where it shows on everypost for Moderators and Admins? so we can edit someones post quickly?

[sv1cec]

not sure if this has been asked, but can u make it where it shows on everypost for Moderators and Admins? so we can edit someones post quickly?

You could, but then you are slowing your system down a lot, because each post has to be read twice (or something like that).

Rgds

[Rich]

Hello,
I never add much to the site,but I read from here frequently. I too created a button that matches my site and figured I would add it here for anyone to use. Opposed to adding transparency to the outer edges of the buttons,I just filled the color with the color I am using on my site. It appears as if it came with the program.
To make this appear as mine does in the screen shot, just fill the outside color with the color of your forum,or add transparency.
Ok,I have finally added something. lol



http://img.photobucket.com/albums/0903/iguanairs/quickedit_icon.gif


http://img.photobucket.com/albums/0903/iguanairs/editbulletinorg.jpg

[EvilLS1]

Looks nice iguanairs. Added a link to your button in the first post. :)

[TruckMuddr]

Anyway to intergrate the WYSIWYG Editor?????? Be a nice addition :)

BTW, INSTALLED :)

[EvilLS1]

Anyway to intergrate the WYSIWYG Editor?????? Be a nice addition :)

BTW, INSTALLED :)

It may be possible but I'm not real familiar with how the WYSIWYG editor works b/c I don't use it (seems to slow the thread's load times down). Maybe someone else can help you figure a way to you integrate it?

[TruckMuddr]

Allright, Thanks for the reply. I'll look at the code and see what I can screw up

[pco]

Hello,
I have a problem with this hack which is with Opera latest version(754) and I didn't try any other. Linux or Windows Opera doesn't matter, neither works. Tried with different servers and Apache/php-config's under linux(Suse 7/8/9 and Redhat 7/9) no change. The problem: quick-editing with this hack by using Opera only works one time IOW as long as the URL still reads showthread?t=tid. After the first edit and if the URL is showthread.php?p=pid#pid then the next changes are posted fine(as one can find by manually refreshing) but the browser doesn't refresh the page by itself. Instead it just sits there showing the busy mouse pointer with the status line "completed reguest to <servername>" and that's it. There are no error messages in the apache log with debug on, there couldn't be as it POSTS fine like I said it's just that it doesn't refresh. So because of this I can't use it. I've tried everything of what was posted here as for changes, it doesn't make any difference as to this behaviour of Opera at all(IE 5.x,6.x and Firefox 0.6x-0.9x are fine BTW). Also tried fresh install of vb303, all the same. :( Did anyone come across this problem or has an idea why and how this could be happening as I don't know where to luck further since logs are empty and this is clearly because of something this hack is doing? TIA for looking into it.

PS. Apache 1.3.x or 2.0.x(latest, .31/.51) doesn't matter either, so the problem has to be related to this hack and not the server config in any way. :tired:

[PitchouneN64ngc]

It is possible to have an option to choose the thread subscription mode?

For example, you can have some members who want to subscribe and others members don't want.

Your modification in the post #6 is a subscription mode for all people, not for each preference of each member.

BTW, it's a very good hack ;)

[EvilLS1]

pco,
Your server type or settings shouldn't make any difference. Anytime you're dealing with javascript you're bound to run into problems with some browsers. Anyway, I'm at work right now but when I get home tonight I'll install the latest version of Opera and see whats going on. If I can reproduce the problem I'll try to find a way to fix it and post it here.

PitchouneN64ngc,
You could put a checkbox option in the quick edit form so that the user can decide if he wants to subscribe or not. You'd still have to have it checked or unchecked by default for all users b/c in order to check the users preferences for subscriptions I believe you'd have to add a query to showthread.php and that wouldn't really be worth it. But if you want to add the checkbox just do this:

In the showthread_quickedit template find this:

<if condition="$bbuserinfo['signature'] != ''"><label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" checked /><span class="smallfont">Signature</span></label></if>


Above it add this:

<input type="checkbox" name="emailupdate" value="1" checked /><span class="smallfont">Subscribe</span>

[pco]

Thank you! Also I see now there's the variable "is_opera" in clientscript/vbulletin_menu.js and vbulletin_global.js. Perhaps looking at what it does(different) if it's Opera will help to find a solution.

[EvilLS1]

pco,
I was able to reproduce the problem. I've been trying to figure out whats causing it for the past 2 hours but haven't had any luck. I'll look into it some more this weekend but I dunno if I can fix it or not. For now, a temporary solution would be to hide the quick edit icon from those who use Opera.

To disable it in opera open the postbit templates and find:

<if condition="THIS_SCRIPT=='showthread' and $post['editlink'] and $bbuserinfo[userid]>0">
$quickedit
</if>


Replace it with:

<if condition="THIS_SCRIPT=='showthread' and !is_browser('opera') and $post['editlink'] and $bbuserinfo[userid]>0">
$quickedit
</if>


I know thats not the solution you were hoping for but at least those who use other browsers can still quick edit until I figure out a fix.

[pco]

Thanks for confirmation and the temp fix. Although I won't use it for now where I intended to use it (on a bigger site) until there's a real solution as I don't want to withhold it from anyone. I hope you(or anyone else) can find a solution for it in the near future! :)

[PitchouneN64ngc]

Thanks for your modification with the email update feature ;)

[Overlord]

Just installed this hack.. very nice works like a charm, although some of my members on dialup are complaining of a 30 second to 60 second delay in thread loading times (doesn't seem to bother me) but is there any way to add a switch to this hack from the user cp? So members can either decide to have it on or off?

[pco]

Either radio buttons or a single checkbox in User Options, here's single checkbox:
In admincp make a new user profile field called say "Use Quick Edit" Type "Multiple Selection Checkbox", press continue. Enter description of your choice and in the field Options just add 1 Option called "No" (without the quotes). Edit the other field options as required ie. "field editable by user YES" but "not shown on memberlist" etc. Set the "Display page" to "Options: other", then press save and read what the field number is for this field, ie. field8. Now edit the postbit(_legacy) template(s) and change the line(s) starting with

<if condition="THIS_SCRIPT=='showthread' and $post['editlink'] and $bbuserinfo[userid]>0">
to this


<if condition="THIS_SCRIPT=='showthread' and !$post['field8'] and $post['editlink'] and $bbuserinfo[userid]>0">

Additionally put this around your showthread_quickedit template:


line 1:
<if condition="!$post['field8']">

last line:
</if>

Don't forget to change the 8 from above to your field number.

The Quick Edit will still be switched on now for everyone in their profiles by default. Those who want to have it off/not loaded anymore have to tick the "No" box in their UserCP Options to get rid of it. If you want to have it the other way round(Quick Edit off for everyone by default) then name the Quick Edit field Option "Yes" and not "No" and remove the exclamation marks:


!$post['field8']
becomes


$post['field8']

Good luck :)

[EvilLS1]

Overlord,
Unless you set it up so that admins can quick edit everyones posts this hack should have no real effect on load times. If you install it as intended the only extra things that must load in showthread is the little icon and the hidden text which is only loaded in posts that belong to the person who is viewing the thread (a small avatar would take longer to load than the text).

Quick Edit uses the same standard javascript functions which vbulletin uses to make all of the little drop down boxes (like when you click on someones username, search, thread tools, etc.) so no extra javascript is loaded. You do have to wait until the whole thread finishes loading before quick edit becomes functional, but this doesn't add to the load times.


pco,
Thats a nice addition. I'll add a link to your post in the add-ons section in the first post of this thread so that others can use it. :)

[pco]

EvilLS1, your nice hack deserves support :up: :) But please don't forget to look into the Opera problem if you can find some time. :) I didn't look any further into it yet as I'm very busy. The only other thing I did was saving a "t=tid" page and "p=pid" page to disk and doing a diff on them. What is different is the URL only it seems apart from some other unimportant/no difference making is_moz/is_ie check. Then one more thing I've noticed(ethereal) which is that somehow Opera doesn't seem to load vbulletin_global.js if "p=pid" so it is certainly as you say somehow related to JS. Therefore the question remains "what is it doing", and I'm no JS expert in any way. :rolleyes:

[EvilLS1]

I haven't had a chance to experiment with it anymore yet but I'll try again tomorrow night and let you know if I find a fix. No guarantee though, 'cause I'm no JS expert either.

[theArchitect]

*clicks install*.

Sensational hack. Something which will come in very handy.

But have noticed that in addition to Opera, it also doesn't work with Netscape on a Mac. Though for your records (if you don't already know) it does work on Safari.

This is a real bummer as I now have to switch back to Firefox. I only moved to Netscape last week as the install button on vB.org doesn't work with Firefox.

[theArchitect]

Also, while I think about it. Is there any way to get this working with moderator permissions?

At the moment I can still see my normal edit post button but I can't use the Quick Edit feature with posts I have not written.

[EvilLS1]

Yes that is possible, but its not a good idea IMO and here's why: With the way this hack works it must load the post text two times in posts where the viewer has the ability to quick edit. So if you set it so that admins can quickedit all posts the post text for every post within a thread will be loaded twice in his browser (once viewable and once hidden) which could slow down the load time a bit. Theres also a problem with the moderater log not showing some info for posts that were quick edited by mods & admins. This is why I didn't include that feature with the hack in the first place. If you still want to allow staff to edit all posts theres instructions for that add-on somewhere in the first few pages of this thread.

[theArchitect]

Yes that is possible, but its not a good idea IMO and here's why: With the way this hack works it must load the post text two times in posts where the viewer has the ability to quick edit. So if you set it so that admins can quickedit all posts the post text for every post within a thread will be loaded twice in his browser (once viewable and once hidden) which could slow down the load time a bit. Theres also a problem with the moderater log not showing some info for posts that were quick edited by mods & admins. This is why I didn't include that feature with the hack in the first place. If you still want to allow staff to edit all posts theres instructions for that add-on somewhere in the first few pages of this thread.
Thankyou. And a very good reason not to include it.

[theArchitect]

*clicks install*.

Sensational hack. Something which will come in very handy.

But have noticed that in addition to Opera, it also doesn't work with Netscape on a Mac. Though for your records (if you don't already know) it does work on Safari.

This is a real bummer as I now have to switch back to Firefox. I only moved to Netscape last week as the install button on vB.org doesn't work with Firefox.
Also the Quick Edit system has just come online in my Netscape browser *YA*.

So scratch that as a possible bug.

[Overlord]

Ok.. thanks guys. I have it set so that Super Mods can edit, as on our forums they have been able to edit normally and requested that they be able to again.. so load time is a little steeper. I'll add that switch though to compensate, I didn't realize it was that simple.

[silentwille]

Hello

It is possible to move the window of quick edit ??

If yes, thanks to give me the code

[kirupa]

Hey Evil!
Great hack. On our board @ http://www.kirupaforum.com, I have the Quick Edit installed with the changes you mentioned here: https://vborg.vbsupport.ru/showpost.php?p=555465&postcount=207

Yet, even when I uncheck the "Subscribe" field, I am still subscribed to that thread. Most of the members have that same problem also. Do you happen to have a suggestion on how I could resolve this issue?

Thanks!
Kirupa :nervous:

[EvilLS1]

Kirupa,
Make sure you deleted this line:

<input type="hidden" name="emailupdate" value="9999" />

[kirupa]

Thanks for the reply Evil! Yeah - I do have that line removed, and I even retried by copying your original code into the showthread_quickreply and making the changes you mention. It is weird, for regardless of whether Subscribe is checked or not, the editer is subscribed to the thread after quick-editing a post :surprised:

[EvilLS1]

Kirupa,
I know this will sound crazy, but put this line of code back in the template where it was to begin with:

<input type="hidden" name="emailupdate" value="9999" />


Then just keep the code for the checkbox exactly like you have it. Just tested it on my board, it works fine that way.

[kirupa]

Thanks a lot Evil! That works perfectly :banana:

[EvilLS1]

Y/W. Sorry for the mix up.

[kirupa]

Hey evil!
Just wondering, is there a way to have the sig checkbox in QuickEdit check to see if the user's post has a signature? In other words, if a user's post has a signature, pressing QuickEdit would have the Sig box checked.

If you can't do that without straining valuable brain processing power, don't worry about it. It's just a minor request several members had.

Cheers!
Kirupa :devious:

[EvilLS1]

Try this code:

<if condition="$bbuserinfo['signature'] != ''"> <label for="cb_signature"><input type="checkbox" name="signature" value="1" id="cb_signature" tabindex="1" <if condition="$post['signature'] != ''">checked</if> /><span class="smallfont">Signature</span></label></if>

[RsX]

there seems to be a problem with the editor now that u updated the template... When an admin tries to delete someone elses post it deletes the last post on the thread instead.. Could u maybe please post a complete template with these features if you can?

*Admin can edit all posts
*Delete button
*Reason for editing (not so important)

With the latest template?
Thanks alot in advance

[theArchitect]

there seems to be a problem with the editor now that u updated the template... When an admin tries to delete someone elses post it deletes the last post on the thread instead.. Could u maybe please post a complete template with these features if you can?

*Admin can edit all posts
*Delete button
*Reason for editing (not so important)

With the latest template?
Thanks alot in advance
I am having a slight problem. I have been using your quick edit feature for a month or so now and it has been working fine. But now when I use the quick edit feature instead of just updating the post it moves the post to the position of first post in the thread with no user details in the postbit.

If I then delete the post it deletes the whole thread.

I added the vB Journal & vB Stock system created by AN-Net. but surely this shouldn't effect this hack in this way.

HELP!!

[EvilLS1]

Are you using the instructions from the first post or have you added some other version posted within this thread? If you're using another version I'd suggest removing it and installing the original to see if that fixes it. Other than that the only thing I can tell you is that it has to be another hack conflicting with quick edit. You'd have to temporarily remove them to see which one is causing the problem. More specifically, any edits to functions_showthread.php, showthread.php, editpost.php, or changes to the postbit template.

[theArchitect]

Are you using the instructions from the first post or have you added some other version posted within this thread? If you're using another version I'd suggest removing it and installing the original to see if that fixes it. Other than that the only thing I can tell you is that it has to be another hack conflicting with quick edit. You'd have to temporarily remove them to see which one is causing the problem. More specifically, any edits to functions_showthread.php, showthread.php, editpost.php, or changes to the postbit template.
Thanks. I am just using the instructions from the first post. But you have supplied me with the info I needed, which was what files could be interfering with the hack.

Just out of interest. Is the problem likely to be because of a file change or could a DB change have caused this.

Sorry to be so vague, but I am stumbling around in the dark at the moment.

[EvilLS1]

Most likely just a file change.

[Revan]

I am having the same problem, but I dont have the time to tamper with the files back and forth... So if anyone else with this problem could come up with the solution it would be most appreciated :)

[charlesk]

Awesome hack, thank you.

As a newbie hacker, my feeble contribution is my rendition of a quick-edit button, which I think looks nice.

Charles

[EvilLS1]

Thanks charlesk. Your icon looks good. Added a link to it in the first post.

[charlesk]

Thanks EvilLS1. :)

Two questions.. I want to add the delete post option but when I open your link it seems to be talking about two different things, an error fix and the delete option. Could you clarify for me what I need to do? Again, I'm a newbie. :)

Also.. any chance of a tweak to this hack so that the QEdit box appears for admins on everyone's posts? Or would that make the files too big by duplicating everything?

Thanks. :)

Charles

[EvilLS1]

Charles,
The delete post option was posted by someone else (not me), but I believe the instructions you need to follow are posted just below where it says "Below is my version of the showthread_quickedit template".. You'd just need to replace your quickedit template with the one he posted.

IMHO its not a good idea to allow mods/admins to quickedit all posts and here's why: With the way this hack works it must load the post text two times in posts where the viewer has the ability to quick edit. So if you set it so that admins can quickedit all posts the post text for every post within a thread will be loaded twice in his browser (once viewable and once hidden) which could slow down the load time a bit. Theres also a problem with the moderater log not showing some info for posts that were quick edited by mods & admins. This is why I didn't include that feature with the hack in the first place. If you still want to allow staff to quick edit all posts the instructions are posted somewhere in the first few pages of this thread.

Dewayne

[charlesk]

The delete post option was posted by someone else (not me), but I believe the instructions you need to follow are posted just below where it says "Below is my version of the showthread_quickedit template".. You'd just need to replace your quickedit template with the one he posted.

The problem is that he changed other stuff too... there are hard-coded colors and stuff in there. I guess I can do a compare and figure out what I need to change.

IMHO its not a good idea to allow mods/admins to quickedit all posts and here's why...

I agree with your reasoning, and I don't have to edit others' posts very often anyway. Thanks again, Dewayne.

c

[charlesk]

EvilLS1: I'm confused about the Opera status of the hack. In the main post you say it doesn't work with Opera.. but then later on page 1 you write "Yes, I've tested this with Mozilla, IE, and Opera. Works fine with all of them. The VB2 version has also been updated to work with all browsers." I have a user on Opera who doesn't see the QEdit box and am wondering if there is a workaround.

Thanks. :) --c

[EvilLS1]

EvilLS1: I'm confused about the Opera status of the hack. In the main post you say it doesn't work with Opera.. but then later on page 1 you write "Yes, I've tested this with Mozilla, IE, and Opera. Works fine with all of them. The VB2 version has also been updated to work with all browsers." I have a user on Opera who doesn't see the QEdit box and am wondering if there is a workaround.

Thanks. :) --c


It doesn't work with Opera. There was two versions of this hack. The first version worked with opera but caused errors in other browsers.. This version doesn't work with opera but runs smoothly in Firefox and Internet Explorer. Those who use Opera simple won't see the quick edit icon.

[charlesk]

Okay thanks for the clarification, appreciate it. --c

[theArchitect]

Okay thanks for the clarification, appreciate it. --c
I have just tried to implement the Quick Edit System on another board and am getting

Parse error: parse error in /home/httpd/vhosts/amanteballo.com/httpdocs/forum/editpost.php on line 774

I can't immediatly think what could be causing this as I have implemented this hack on another board.

[EvilLS1]

I have just tried to implement the Quick Edit System on another board and am getting

Parse error: parse error in /home/httpd/vhosts/amanteballo.com/httpdocs/forum/editpost.php on line 774

I can't immediatly think what could be causing this as I have implemented this hack on another board.


That is very strange, as this hack doesn't even make changes to editpost.php. Whats on line 774?

[theArchitect]

That is very strange, as this hack doesn't even make changes to editpost.php. Whats on line 774?
Sorry, my bad. I had installed Xenon's Hidden Post Advanced hack incorrectly and it was messing with yours.

Sorry for troubling you.

[version2]

All right. What can I do to REALLY make sure that signatures do not get chopped off. SOmetimes the quickedit box comes up with the sig checkbox greyed out and when this happens it ALWAYS strips out the sig.

[EvilLS1]

All right. What can I do to REALLY make sure that signatures do not get chopped off. SOmetimes the quickedit box comes up with the sig checkbox greyed out and when this happens it ALWAYS strips out the sig.

Version2,
I wish I knew what to tell you in order to fix that but I honestly have no idea. Someone else mentioned having that problem earlier but I can't reproduce it on my own site I have no way to figure out whats causing it. I'll experiment with it some more on my test forum this weekend and try to reproduce it.. If I figure out something I'll let ya know.