PDA

View Full Version : Code / PHP boxes saga


Dean C
09-19-2003, 07:42 AM
Well i've seen some code in iframes and some codes not in iframes. But it doesn't solve the problem IMO. Not only is it hard to read but you have to copy and paste the code into a text editor before you can read the code.

Logician
09-19-2003, 10:51 AM
But at least whole thread display is not ruined by extending to right because of such codes.. :) Expecially Full Releases sections threads were affected very badly.

Dean C
09-19-2003, 11:29 AM
Well why not actually "wrap" the text instead of putting it in a frame?

assassingod
09-19-2003, 11:33 AM
Well why not actually "wrap" the text instead of putting it in a frame?
That would look ugly and I think someone requested it not to be wrapped.

It would be better if the iframe were bigger

Xenon
09-19-2003, 03:28 PM
wrapping isn't a solution, as it breaks the code sometimes.

bigger iframes: if we'd do that it'll break the main table again for smaller resolutions, for now i made it so it's combatible with 800x600 and above.

i'll try to make it more dynamical in future, as said it's not final yet

sabret00the
09-23-2003, 03:12 PM
can i just say i hate the iframe and i hate the white, especially when you been smoking and drinking and it's the middle of the night and you're looking thru threads and theirs some bright white thing to blind you :confused: :lol: but seriously can't we get the old ones back, ppl have been using vb for years, surely they've gotten used to the extended pages by now, why make everyone suffer for one or two picky ppl?

Xenon
09-23-2003, 07:29 PM
the old way isn't possible anymore as vb3 has changed the whole templates so postbits aren't in their own table anymore.

and as i've said several times now, and i don't want to say it just one time more from now on:
vb.org's vb3 style isn't final

sabret00the
09-23-2003, 07:55 PM
granted and i know that but i still felt i should give you my opinion as a vb dev might pop over and see it and fix it.

Erwin
09-24-2003, 04:35 AM
I find the iframe code tags quite a good idea really.

Xenon
09-24-2003, 05:33 PM
i have to agree with Erwin.
i wanted iframes in vb2, too, but always were to lazy to do :)

now in vb3, i was forced to do so :)

@sabre:
a) they won't "fix" it as they don't see it as a bug
b) vb.devs don't read that much on vb.org, talking to them on vb.com is the easier way

sabret00the
09-24-2003, 06:43 PM
pointed a couple to this this morning so we'll see what happens lol *crosses fingers*

EvilLS1
09-24-2003, 10:45 PM
I don't know if anyone else has mentioned this, but for some reason the new code boxes are causing spaces to be inserted in parts of the code.

Here's an example:
https://vborg.vbsupport.ru/showpost.php?p=353431&postcount=2

If you copy and paste Xenon's code you'll get a database error due to the space in lastpos ter and showsignatu re. I've checked another hack posted with code tags and found the same problem.

Also, since the vb3 upgrade showthread is loading very slow for me (IE 6). I guess its due to all posts being in one table? Sorry if this has already been noted.

Xenon
09-25-2003, 06:21 PM
@Evil: hmm seems like a vb3 bug:
http://www.vbulletin.com/forum/showthread.php?p=536469#post536469
as you found out, it's up to you to report it :)

EvilLS1
09-25-2003, 07:18 PM
Ok, I reported it @ vb.com. :)

EvilLS1
09-25-2003, 11:55 PM
reply @ bugtracker
http://www.vbulletin.com/forum/bugs.php?do=view&bugid=861

allan grossman
09-26-2003, 11:29 AM
I believe that this won't occur if you use spaces after each comma in that code, rather than stringing it all to one long string that will end up broken in pieces due to the wordwrap.

Good coding == having a space after the comma. Esp. / at least on longer lines of code such as these.

So I would say that this is nothing vB would have to try and fix...

Sorry, but I disagree. If it's broke, fix it ;)

Xenon
09-26-2003, 06:26 PM
hmm, if they don't fix it maybe i have to write a thing or two.....

but as my time is so limited these days i hope they'll fix it ;)

EvilLS1
09-26-2003, 08:12 PM
Good coding == having a space after the comma. Esp. / at least on longer lines of code such as these.


Maybe so, but the broken code that I posted as an example is from a vbulletin file. :D