Attachments per forum

[Boofo]

Can anyone please tell what I am doing wrong or missing in this query? I am trying to get the attachments count per forum and right now it shows the same count and bytes in every forum. Here is the code:

/** Count of Attachments Per Forum and Bytes **/
$attachs=$DB_site->query_first("SELECT forum.title AS forum, COUNT(attachment.attachmentid) AS count, SUM(LENGTH(attachment.filedata)) AS bytes
FROM attachment,post,thread,forum
WHERE attachment.attachmentid = post.attachmentid
AND post.threadid=thread.threadid
AND forum.forumid=thread.forumid
GROUP BY thread.forumid
ORDER BY count DESC");

$attachs['count'] = number_format($attachs['count']);
$attachs['bytes'] = number_format($attachs['bytes']);
/** Count of Attachments Per Forum and Bytes **/

[Chris M]

I think your query is wrong...

I'm not sure if it is right, but try:

$attachs=$DB_site->query_first("SELECT forum.title AS forum, COUNT(attachment.attachmentid) AS count, SUM(LENGTH(attachment.filedata)) AS bytes
FROM attachment
LEFT JOIN post ON post.attachmentid=attachment.attachmentid,
LEFT JOIN thread ON thread.threadid=post.threadid,
LEFT JOIN forum ON forum.forumid=thread.forumid,
WHERE attachment.attachmentid = post.attachmentid
AND post.threadid=thread.threadid
AND forum.forumid=thread.forumid
GROUP BY thread.forumid
ORDER BY count DESC");

:)

Satan

[Boofo]

After taking the commas out after the LEFT JOINs (gave db error), I get the same results that I was getting with the other code. It shows 51 attachments, which is what I have in one forum. It shows that one very forum.

[Boofo]

Ok, we've narrowed it down to this:

SELECT SUM(attach) AS count FROM thread WHERE attach > 0 AND forumid=$forumid

Can anyone please tell me how to get the total filezise in both bytes and KB from this query?

[filburt1]

Looking into now.

[Boofo]

That was quick. Thank you, sir. ;)

[filburt1]

I got it; however it takes 3.10 sec to execute. If you're going to use it I strongly suggest you make it cache itself daily or so.

SELECT COUNT(p.postid), SUM(LENGTH(a.filedata)), f.title
FROM post p, thread t, forum f, attachment a
WHERE a.attachmentid = p.attachmentid AND t.threadid = p.threadid
AND f.forumid = t.forumid AND p.attachmentid > 0
GROUP BY f.forumid;

I'm sure it can be done with JOINs, too, but I don't know how.

[filburt1]

BTW it's the SUM(LENGTH()) that's taking the most time. The query returns the number of posts with attachments, the cumulative filesize of all of those attachments, and the title of each forum, grouped by each forum.

[Boofo]

Using this shows the same attachments amount and file size in every forum. ;)

[filburt1]

Didn't for me (MySQL 4.0.12). It returned distinct forum titles and the other stats for them

[Boofo]

Ok, maybe I didn't call it right, then. Here is what I have now.

$attachs=$DB_site->query_first("SELECT COUNT(p.postid) as count, SUM(LENGTH(a.filedata)) as bytes, f.title
FROM post p, thread t, forum f, attachment a
WHERE a.attachmentid = p.attachmentid AND t.threadid = p.threadid
AND f.forumid = t.forumid AND p.attachmentid > 0
GROUP BY f.forumid");

and I am calling them like this:

$attachs['count'] = number_format($attachs['count']);
$attachs['bytes'] = number_format($attachs['bytes']);

Am I calling them wrong? And my host is using 3.54.xx version of MySQL if that makes any difference.

[filburt1]

It returns multiple rows, not one row (query() instead of query_first()).

[Boofo]

I get these errors at the top of the page when I run the following code:

Warning: Cannot use a scalar value as an array in /home/bear/public_html/forum/forumdisplay.php on line 738

Warning: Cannot use a scalar value as an array in /home/bear/public_html/forum/forumdisplay.php on line 739

$attachs=$DB_site->query("SELECT COUNT(p.postid) as count, SUM(LENGTH(a.filedata)) as bytes, f.title
FROM post p, thread t, forum f, attachment a
WHERE a.attachmentid = p.attachmentid AND t.threadid = p.threadid
AND f.forumid = t.forumid AND p.attachmentid > 0
GROUP BY f.forumid");

[filburt1]

Iterate through it using $DB_site->fetch_array()...have you extensively worked with MySQL through vB before?

[Boofo]

Not a whole lot, no. Simple queries, I can usually do. ;)

I must not be getting it right or understanding it, I guess. I am still getting errors. This time it is:

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/bear/public_html/forum/admin/db_mysql.php on line 149

[filburt1]

Iterate as such (just an example):

$result = $DB_site->query(...);
while ($bits = $DB_site->fetch_array($result))
{
// do stuff with $bits which is one row from the result
}

[Boofo]

We figured out what I was doing wrong with the original code in post #1. I forgot to add:

AND forum.forumid=$forumid

to the end of it. Now it returns the right info for each forum and runs fast.