[RELEASE] forumjump Optimization

This optimization just may help you out more than the forumdisplay did! Check it out...

edit global.php (the one in /forum, not the admin one)

find:


// ###################### Start makeforumjump #######################


Delete everything between that line and this line:


// ###################### Start countchar #######################


In it's place put this:


function makeforumjump()
{
// this generates the jump to box
global $DB_site,$forumid,$optionselected,$usecategories, $jumpforumid,$jumpforumtitle, $jumpforumbits,$curforumid;
global $hideprivateforums,$defaultselected, $forumjump,$bbuserid,$bbusergroupid;

if ($forumid!="")
{
$curforumid=$forumid;
}
else
{
if ($threadid!="")
{
$getforumid=$DB_site->query_first("SELECT forumid FROM thread WHERE threadid=$threadid");
$curforumid=$getforumid[forumid];
}
}


$forums=$DB_site->query("SELECT category.categoryid, category.title AS categorytitle,
forumid, forum.title AS forumtitle
FROM category
LEFT JOIN forum ON (category.categoryid = forum.categoryid)
WHERE category.displayorder<>0 AND forum.displayorder <> 0 AND active=1
ORDER BY category.displayorder, forum.displayorder");
$firstcat = 0;
while ($forum=$DB_site->fetch_array($forums))
{
$currentcat = $forum[categoryid];
if ($usecategories == 1)
{
$optionselected="";
if ($firstcat != $currentcat) // Print Category
{
$firstcat = $forum[categoryid];
// This creates our "blank line" in the dropdown
$jumpforumid="";
$jumpforumtitle="";
eval("\$jumpforumbits .= \"".gettemplate("jumpforumbit")."\";");
$jumpforumid="cat$forum[categoryid]";
$jumpforumtitle="Category: $forum[categorytitle]";
eval("\$jumpforumbits .= \"".gettemplate("jumpforumbit")."\";");
$jumpforumid="";
$jumpforumtitle="--------------------";
eval("\$jumpforumbits .= \"".gettemplate("jumpforumbit")."\";");
}
}

if ($hideprivateforums==1)
{
$getperms=getpermissions($bbuserid,$bbusergroupid, $forum[forumid]);
}
else
{
$getperms[canview]=1;
}
if ($getperms[canview]==1)
{
$jumpforumid=$forum[forumid];
$jumpforumtitle=" $forum[forumtitle]";
if ($curforumid==$jumpforumid)
{
$optionselected="selected";
$selectedone=1;
}
eval("\$jumpforumbits .= \"".gettemplate("jumpforumbit")."\";");
}
}
if ($selectedone!=1)
{
$defaultselected="selected";
}
eval("\$forumjump = \"".gettemplate("forumjump")."\";");
}


For the record the current forumjump retrieves a list of categories. Then for each record in that result set it runs a query of the forums that belong to that category. Have 50 categories, you have 51 queries. Now you would have 2. We still need to do something about that "getperms" function as it will run a query each time per forum. How about we retrieve that information along with the bbusername, bbpassword, bbuserid and have it available instead of constantly retrieveing it all the time. Just a thought.

[Edited by Ed Sullivan on 10-27-2000 at 05:45 PM]

cool.. the forumdisplay one really helped me out ALOT ... by any chance you know if any of the hacks would of changed it ?

I don't think any hacks would have changed this.

Also don't get upset at me not releasing the calendar hack if I'm spending time optimizing queries :)

[Edited by rangersfan on 10-26-2000 at 07:26 PM]

Rangersfan well done! :)

:( i added it on my test forum i got an error


Parse error: parse error, expecting `','' or `';'' in /path/to/global.php on line 550

Fatal error: Call to a member function on a non-object in /path/to/global.php on line 349

You know what? If I edit the post it is fine, but if you look where it says

curfor umid;

The forum has inserted a space from the damned wordwrap bug.

You can dl it here ->

http://www.hedgehogwheels.com/hacks/forumjump_optimization.txt

Wow this sounds great. I added it to my forums.

I look forward to more optimizations...if it keeps up maybe I won't need to buy Sybase or another databae solution.

Thanks rangersfan. Do you have any other optimizations in mind or planned?

thanks i downloaded the txt one you posted and it works great on my test and live vBs :D

Another one? :)

Cramed for time right now, but is this one similar to:
http://www.vbulletin.com/forum/showthread.php?threadid=2985

Or does it improve a different area. I'm assuming its different, since you had posted in the other thread before, but don't have the time to run through the code atm.

Keep 'em coming!

Oh it achieves the same but mine makes a hell of a lot more sense. I posted alot of questions about errors and such with his hack and he never responded.

In reality, someone on vbulletin.org asked for an optimization of forumjump and I had forgot fodder had made one.

[Edited by rangersfan on 10-26-2000 at 08:30 PM]

hehe i really love you sig rangersfan ;)

yeah I think that my sig with the links will not be needed anymore. :)

I installed this hack and am wandering around trying to figure out where this is called from. On what screens should I notice this happening? On the main screen when the forums and categories are loaded?

Just curious, and thanks for the extra effort, rangersfan!

It is the small pulldown menu that appears on forumdisplay and allows you to select a forum to "jump to".

Your three optimizations are great. I was just wondering if you know if they are to be included in 1.1.4 and 2.0 or did John redo the coding.

Knowing this will greatly help development along at SitePoint.

Originally posted by wluke
Your three optimizations are great. I was just wondering if you know if they are to be included in 1.1.4 and 2.0 or did John redo the coding.

Knowing this will greatly help development along at SitePoint.

I think its in 2.0

I have no clue, I have never had any communication with anybody at Jelsoft.

The 1.1.4 stable release is planned to have about a dozen known bug fixes along with many new optimizations, including those posted by rangersfan and Stallion, along with a few others.

Of course I am sure they will all make in into 2.0 as well.

-Chris

(blatant reply to bump my posts to 1000 )

For the record, I am copying rangersfan with his sig idea, and its not the other way around. :-)

Originally posted by rangersfan
The forum has inserted a space from the damned wordwrap bug.Actually, ironically, that's not the bug. Put spaces between your commas and you'll find it's fine. [I'll go do that real quick] FYI, John fixed the bug. 1.1.4 will have the fix.

Also, when I get around to it, I think I'll swipe rangersfan's sig too :) It makes sense, and gets rid of a lot of those "[request] WHERE IS IT?" threads.

Originally posted by Stallion
For the record, I am copying rangersfan with his sig idea, and its not the other way around. :-) who's copying who's sig :p

I had to remove the hack links to give more space to add all my new links soon.

Copying sigs hey??? :)

When using the code from forumjump_optimization.txt I get the following error:

Parse error: parse error, expecting `T_VARIABLE' or `'$'' in global.php on line 740

Any ideas?

Cold Steel that means you missed putting a $ on a variable. V1.1.4 has this optimization in it so why don't you just install it?

Thanks Freddie, I hadn't even noticed that 1.1.4 was out!

I think I'm going to wait for 2.0 before working on anything else.

BTW great site - my woman wanted to get a hedgehog for a looong time, and she really enjoyed looking at the photos on your site. :)

Thanks :)