Sig image size control

[Herman]

I wrote this hack so i could obviously do what the title says.

When installed it you get an option in vb option of max height and width.

If a user's sig is too big, then when you look at their sig it'll say sorry this image is too large. And if the link doesn't work, then it'll say sorry that image doesn't exist. Thnx.. Don't forget to back up the databases!

This new one gets rid of the queries.. but, you have to submit your vbulletin options after installing the hack in order for it to work.

Update again, this fixes smooties prob's with it images being set to unlimited

[Sinecure]

There seem to be a lot of signature limitation hacks :)
I'll install this on my test board. I want something simple, and not bloated with options, hopefully this does the job :)
Thanks :)

[Herman]

np

[Smoothie]

Followed instructions, set the limit in the vb options for sig width, height, added a test sig, bigger than the allowable limit, it still shows. :(

[Admin]

Nice work... haven't tested it but looks promising.

[Admin]

Originally posted by Smoothie
Followed instructions, set the limit in the vb options for sig width, height, added a test sig, bigger than the allowable limit, it still shows. :(
The hack doesn't work retroactively as far as I see.

[Smoothie]

Originally posted by FireFly

The hack doesn't work retroactively as far as I see. I added a new sig after the hack, and it still shows.

[Smoothie]

Ok, the one setting that needs to be changed for this to work is:
Under Posting Code allowances (vB code / HTML / etc):
Maximum images per post/signature: (This needs to be set to anything but zero.) :)

[Herman]

Okay it works, it just doesn't work until the user has to changes their profile.

[Smoothie]

It only works for me if I change the setting above. Is there a way around that?

[Herman]

Ok, the one setting that needs to be changed for this to work is:
Under Posting Code allowances (vB code / HTML / etc):
Maximum images per post/signature: (This needs to be set to 1.)
Works just fine for me.. I have images set to 10 per post/sig, and It only kills the images that are too big.. For instance, if I have it set to 100x500, (default), and I add two images in my sig, one that is 320x240, and one that is 64x64, the 64x64 one stays, but the 320x240 one gets the message that its too big...

[Smoothie]

Ah, ok. So this can be set to anything but 0 for it to work? Because at 0, it doesn't.

[Herman]

Ok, here is how it works.

1. You update your profile

2. Before the BBCODE processor, a special function catches all img tags.

3. The function, called size_check, checks to see if the file exists, if it does, it gets the max size and width out of the configuration of your board, and checks to see if the image width is bigger first in width, then in height:
if ($im_width > $max_sig_width)
{
return "Sorry, image size exceeds maximum width of ".$max_sig_width.".";
}

if ($im_height > $max_sig_height)
{
return "Sorry, image size exceeds maximum height of ".$max_sig_height.".";
}


4. It returns the image in BBCODE notation if it is ok, otherwise, it returns the message shown above.

5. The bbcode processes it like normal!


I wasn't sure about your question about setting it to 0.. I wasn't sure what that was refering to...

[Admin]

Just so you know: instead of using this:
$max_height = $DB_site->query_first("SELECT value FROM setting where varname=\"maxsigheight\"");
$max_width = $DB_site->query_first("SELECT value FROM setting where varname=\"maxsigwidth\"");
You can just use $maxsigwidth and $maxsigheight (globalize them in the function). BUT, you MUST Submit the vBulletin Options page in the Admin CP for this to work. :)

Anyway, I'll probably install this here later, looks good.

[Herman]

Yea... I was trying to figure that out.. but every single time I tried to global those variables, it wouldn't work. They would return NULL. I didn't know you had to submit the vbulletin options again...lol. I'll edit the post and submit a revision.

[Admin]

Well I installed this here, with some modifications, and it's working great. Great job Herman!

[Smoothie]

I wasn't sure about your question about setting it to 0.. I wasn't sure what that was refering to...In my admin cp, i had maximum images/sigs per post set to zero. So, users could post unlimited images with img tag. But, the hack won't work with it set to zero. Anything but zero, and it works fine. That's what my post was about, and why I couldn't get it to work the first time. Now it works great. Will you be updating the original file with Firefly's changes, and if we have this installed, what needs to be changed?

[Smoothie]

BTW, it would be really cool if you could control the amount of images in the signature, and in the posts separately. Like allow only one img tag in the sig, but a different amount in the posts.

[Herman]

I will update the original file in a sec here.. and I'll post again with changes.

[Herman]

Just download the new update, and replace the whole size_check function in members.php with the new one.

[Herman]

Hmm.. Smoothie.. you are right .. it does not work if that setting is set to 0. I'll look into that.



[edit]S, to fix the problem with it being set to 0, when you did this part of the hack:

find:

// check max images
if ($maximages!=0) {

add:
$signature = preg_replace("/\[img\](\r\n|\r|\n)*((http|https):\/\/([^;<>\*\(\)\"".iif($allowdynimg,"","\?\&")."]+)|[a-z0-9\/\\\._\- ]+)\[\/img\]/seiU", "\size_check('\\2')", $signature);


add the code *BEFORE* the lines you had to find. that will fix it. sorry



Also, I reupdated the hack in the first post.

[Herman]

Thanks FireFly :)

[Robouk5]

Firefly, would you mind posting the versiopn you installed with your modifications?

[Smoothie]

Excellent Herman! Thanks for the updates. :)

[Herman]

No problem! :)

[Boofo]

What do you mean by submit? :)

Originally posted by Herman


This new one gets rid of the queries.. but, you have to submit your vbulletin options after installing the hack in order for it to work.

[Herman]

Goto Admin CP, goto Vbulletin Options, then goto the button and hit the submit button to save your options. Thats it! :)

[LightBringer]

Is there anyway possible to limit flash movies within the signature as well?

[Larz]

Herman, in the admin-cp, the button you're referring to as "Submit" is called "Save Changes" in my vB, I think that's what's causing some confusion.

[Darren Evans]

So, this hack won't work unless all my users update their bios? It won't work on the fly when the hack is installed?

[Smoothie]

Originally posted by Darren Evans
So, this hack won't work unless all my users update their bios? It won't work on the fly when the hack is installed? That would be correct.

[Darren Evans]

Ok... can someone post a query that deletes all sig files so I don't have to go in and manually delete each one?

[Smoothie]

One thing you might try, turn off:
Allow vB IMG code in signatures in the admin cp, submit, then go back and turn it back on.

[Darren Evans]

Originally posted by Smoothie
One thing you might try, turn off:
Allow vB IMG code in signatures in the admin cp, submit, then go back and turn it back on.

Nope. That didn't work. :( Thanks for the reply, though.

[Herman]

update user set signature="";


and yes, it is possible to do it with Swf files, but I haven't written the code for that yet.

[LightBringer]

Herman, has there been any updates on the swf code for this hack?

[Herman]

Ok for SWF! Here it is.. I haven't completely put a lot of thought into this code b/c I was busy today, but it will do the job.

I designed this addition to be completely independant of the IMG sig control hack.. This hack addition will only affect swf's, so if you don't care about IMG and want swfs controled, only install this, however, you can install them both, and it wll control both.

find:

// check max images
if ($maximages!=0) {


add ABOVE

$signature = preg_replace("/(\[)(swf)(=)(['\"]?)([^\"']*)(\\4])(.*)(\[\/swf\])/seiU", "\swf_size_check('\\5','\\7')", $signature);


find at the very end of the file:

?>

add ABOVE:


function swf_size_check($image, $h_w) {


global $maxsigheight, $maxsigwidth;

//parse_all img tags

$image_xy=@getimagesize($image);

if ($image_xy==NULL)
{
return "Image not found";
}
else {
//ok, here we need to see if the user specified a size(i believe the swf will
//default to default size if no height width is specified, so lets get the
//dimensions of the swf..

$im_width=$image_xy[0];
$im_height=$image_xy[1];


//ok, did the user specify a height? lets see...

unset($params);
$params=explode(" ", $h_w);

foreach($params AS $param)
{
if (preg_match("/(height)(=)(['\"]?)([^\"']*)(\\3)/siU", $param))
{
$im_height=preg_replace("/(height)(=)(['\"]?)([^\"']*)(\\3)/seiU", "\intval('\\4')", $param);
}
if (preg_match("/(width)(=)(['\"]?)([^\"']*)(\\3)/siU", $param))
{
$im_width=preg_replace("/(width)(=)(['\"]?)([^\"']*)(\\3)/seiU", "\intval('\\4')", $param);
}
}


if ($im_width > $maxsigwidth)
{
return "Sorry, swf size exceeds maximum width of ".$maxsigwidth.".";
}

if ($im_height > $maxsigheight)
{
return "Sorry, swf size exceeds maximum height of ".$maxsigheight.".";
}

}


return "" . $h_w . "";
}



Keep in mind, that this is NOT fully tested, but I wrote it b/c of requests.

[Herman]

BTW, why does it parse the BBCODE in the [code] statements? This is very annoying.. In my above post, where the words appear italicized, there should be [i ] and [/i ] ending tags, for those interested.

[DarkDraco07]

i could really use this

[Kinox]

here is what i did

https://vborg.vbsupport.ru/attachment.php?s=&postid=266944

https://vborg.vbsupport.ru/showthread.php?s=&threadid=40402

[ZiRu$]

thx man i installed it

[Thunderpuck]

Excellent! I really needed this. Thanks!
:)

[rstark]

I thought I had this working well, installed it and tested it. I have the max images per post/signature set to 20, I set the max image height to 200 and width to 500 and saved the changes in the options screen. I tested it with a 640x480 image and sure enough, it said I exceeded the width.

I just had a new user register today, and put in a signature of 224x464. The height exceeds my limit in the option yet his signature still show up. So for some reason, it's not checking the height but it checks the width. Can someone verify that if you upload a picture that only exceeds the height limit, that this hack will work? Thanks.

Oh yeah, I just double checked the code from the installation of this hack and everything matches up properly.

[1freegaia]

Does it work with VB2.0.3 ?

thanks !

[Herman]

rstark, your problem may be that the HTML code is enabled, that will make him able to get a larger signature than usual, so, disable that and it ends.... And it should work with any version of vB.

[rstark]

Originally posted by Herman
rstark, your problem may be that the HTML code is enabled, that will make him able to get a larger signature than usual, so, disable that and it ends.... And it should work with any version of vB.
Well, I did have HTML code enabled, but I disabled it now. I looked at the user's signature and he is using the IMG tags and not html for the signature. Why would it only find the width of the signature in error but not the height? I've tried my own test on this.

[Herman]

is he using it as like a .txt file off of angelfire? If so then that may be the prob.

[rstark]

Originally posted by Herman
is he using it as like a .txt file off of angelfire? If so then that may be the prob.
No, his signature is plain text with the IMG codes.

[Herman]

Hmm, then ask him how he's doing it, or email me with the actual code of it.

[rstark]

Originally posted by Herman
Hmm, then ask him how he's doing it, or email me with the actual code of it.
I've tried my own test on this by creating an image that met the width requirement, but exceeded the height requirement and it allowed the image in the signature.

[L-Mane]

I am trying to uninstall this query and I cannot do so.

$db1="INSERT INTO setting (settinggroupid, title, varname, value, description, optioncode, displayorder) values ('4', 'Max Sig Height', 'maxsigheight','100','Made specially for Otakuboards, Its our very own <B>SIG KILLER</B>! Yay!!', '', '10')";
$db2="INSERT INTO setting (settinggroupid, title, varname, value, description, optioncode, displayorder) values ('4', 'Max Sig Width', 'maxsigwidth','500','Made specially for Otakuboards, Its our very own <B>SIG KILLER</B>! Yay!!', '', '11')";

$DB_site->query($db1);
$DB_site->query($db2);

How can I do this?

[Kinox]

$DB_site->query("ALTER TABLE setting DROP Max Sig Height");
$DB_site->query("ALTER TABLE setting DROP Max Sig Width");

[S1R1US]

hey do you know if it works for version 3.0.0 of vbulletin?

[Herman]

I'm not sure, I've never used vB3, how have u?

[Colon33]

Does this also block people WHO link there sigs to other websites? or just images they upload themselves? I am assuming it goes for ANY image file located in the SIG. Right?

[Herman]

Exactly

[k4is3r]

This will work with Vb 2.2.9 ???

I've installed it, but i get always "image not found"!!!

Any suggestions???
tnx :classic:

[Kriek]

Running into the same problem on 2.2.6.

Although it only seems to display Image not found when users update their profiles.

[Herman]

It may be the way the show their sig, are they using HTML or the natural vB code?

[k4is3r]

Today at 05:02 PM Herman said this in Post #59 (https://vborg.vbsupport.ru/showthread.php?postid=373089#post373089)
It may be the way the show their sig, are they using HTML or the natural vB code?


Natural vB coe :paranoid:

[TYorke]

What's the latest on this? My users are also getting the "Image Not Found" message.

Also, I'm not sure if I saw wrong or not but, I think v2.3.0 already comes equipped with the Max Sig Height and Max Sig Width fields.

[Boofo]

I'm not getting this to work at all. I have the image size set to 125 height and 450 width and I had a user upload an image that is 192 height and the image shows in his signature. Anyone have any ideas why this is happening? I am using 2.2.9, if it means anything.

[k4is3r]

Today at 04:50 PM Boofo said this in Post #62 (https://vborg.vbsupport.ru/showthread.php?postid=379688#post379688)
I'm not getting this to work at all. I have the image size set to 125 height and 450 width and I had a user upload an image that is 192 height and the image shows in his signature. Anyone have any ideas why this is happening? I am using 2.2.9, if it means anything.


The same thing...... :( on vb 2.2.9

[ryancooper]

Question.

OK i first set the max height to 60 and width to 100 to test.

TEsted and everythign works great, now I want to change the max height to 100 and width to 100 saved options and still get the error : Sorry, image size exceeds maximum height of 60.

I tried removing my sig, saving my profile then adding it again but it still is the same??

Nevermind I didn;t realize that it replaced the image with the text. :dead:

[Jing]

good hack :) installed with some slight modifications.

[Boofo]

04-25-03 at 11:31 PM Jing said this in Post #65 (https://vborg.vbsupport.ru/showthread.php?postid=387242#post387242)
good hack :) installed with some slight modifications.

Could you share the modifications? I can't seem to get it to work right. ;)

[k4is3r]

04-30-03 at 06:06 PM Boofo said this in Post #66 (https://vborg.vbsupport.ru/showthread.php?postid=389460#post389460)
Could you share the modifications? I can't seem to get it to work right. ;)


:cheeky:

[Boofo]

My sentiments exactly. I'll just un-install it and find one that works. ;)

[k4is3r]

05-04-03 at 06:49 PM Boofo said this in Post #68 (https://vborg.vbsupport.ru/showthread.php?postid=391272#post391272)
My sentiments exactly. I'll just un-install it and find one that works. ;)

Can you plz share the hack that finally works???

thank you in appreciate :classic:

[Nitesh]

This hack works sometimes and other times it displays image not found.

Has anyone fixed this or have an alternative?

[k4is3r]

Yesterday at 11:05 PM Nitesh said this in Post #70 (https://vborg.vbsupport.ru/showthread.php?postid=398649#post398649)
This hack works sometimes and other times it displays image not found.

Has anyone fixed this or have an alternative?

[Boofo]

It seems that support has been dropped for this hack.

[ZiRu$]

Thanks man I'm gonna re-install this

[monstergamer]

works great
********installed********

[Dez_U]

does thbis run on the latest version of VB?

thanks

[Marco van Herwaarden]

No, this hack is written for vB2 and will probably not run on vB3.

[Dez_U]

thanks Marco, just found one that looks cool

https://vborg.vbsupport.ru/showthread.php?t=79566&page=2&pp=15&highlight=signatures

:D