Prevent Doubleposting

[Xenon]

This is why i really want a Mini-Hack section here, please Chen ;)

What this hack does:
When a User posts to a thread where he already has the lastpost, no new post will be added. The lastpost of him will be edited and the new text is put after his first message.
This would not be done, if he has an attachment in his new post or the old post is older than 1 hour (you can change this timespan yourself :))

Known bugs: None :)

Hope someone can use it, i do :)

Believe this hack includes just 1!! codehack.

[darker1]

sweet. been looking for something like this.

[Chris M]

Sweet hack!!

Satan

[Xenon]

thanx you 2 :)

ups, have seen one line is double in the attachment, delete one of the eval lines *gg*

have corrected it here :)

[Chris M]

Ok thanks:)

Satan

[Link14716]

Cool...

*Runs to install*
;)

[MrLister]

This is great, I'll just modify it a bit to be different per forum.

[Xenon]

feel free to do so, and please post the modifications here, who know who can use them else :)

[Velocd]

Excellent hack Xenon, this is truly userful ;)

One request: Can you make it so when the user does double post, and his post is merged with the first post, that on the bottom it will state:

Last edited by ... on 06-22-02 at 01:27 PM

This would be more useful, because in some ways if a user wants to add-on to their original post by bypassing the "edited by", all they would have to do is double post. This stops them though.

[Logician]

very nice idea Xenon. :)

May I suggest an improvement? Maybe you can add another query to $action=="newreply" section to check if he is the last poster to the thread. If he is, he can be pre-warned in the screen he writes his message that his last message will be replaced with this one.

This will add an extra query to newreply.php but it can save the user from losing his last message in the thread especially when the hack is new in the board.

[BigJohnson]

Ya that seems like a great feature. Both of them.

[BigJohnson]

When someone double posts does it bring the post back to the top of the Forum Display?

[Velocd]

No, the post will stay in its original position.

[BigJohnson]

Well how can you make it so that it goes back to the top. Wouldnt that make more sense? Can you please tell me how that can be done. Because what if someone wants to bump a topic that is far away down the Forum Display? Thanks

[Velocd]

There is a bump hack somewhere as I recall...
find it, install it, use it ;)

[Lesane]

Nice hack Xenon. Little but usefull.

[Xenon]

@Velocd: Ok, will do so :)

@Logician: Sorry, you have missunderstood something:
The old post won't be deleted, it would just became longer :)

@BigJonson: That's why theres also a timestamp in it, if the lastpost has been a long time ago then a real new post is put to the end of the thread, so it became bumped

[Xenon]

Velocd: i have updated the installation file, now it should add an edited by message :)

[BigJohnson]

Nope the txt file is not updated. No chages were made.

[Xenon]

???
it is, have just looked in it and it is updated.

$editsql="";....

if this line is in it it is updated, and as i can see here it is

[Boofo]

How about adding an Edit Reason, too (Like Firefly's Edit Reason hack)? That way we will know that they added to the message instead of just editing it. :)

Originally posted by Xenon
Velocd: i have updated the installation file, now it should add an edited by message :)

[BigJohnson]

Ya can there be somewhere where it would say DOUBLE POSTING FEATURE and then under that it would show the message instead of just having a Break in the post and then the new edited message.

[BigJohnson]

Can you show the update. Maybe it has somehting to do with the cache. This is all i see

$lastpost = $DB_site->query_first("SELECT * FROM post WHERE threadid = '$threadid' ORDER BY postid DESC");
if($lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach])) {
$DB_site->query("INSERT INTO post (postid,threadid,title,username,userid,dateline,at tachmentid,pagetext,allowsmilie,showsignature,ipad dress,iconid,visible) VALUES (NULL,'$threadid','".addslashes(htmlspecialchars($title))."','".addslashes($postusername)."','$bbuserinfo[userid]','".time()."','$attachmentid','".addslashes($message)."','$allowsmilie','$signature','$ipaddress','$iconi d','$visible')");
} else {
$DB_site->query("UPDATE post SET pagetext='".addslashes($lastpost[pagetext]."\n\n".$message)."' WHERE postid=".$lastpost[postid]);
if ($visible) {
$goto="showthread.php?s=$session[sessionhash]&postid=".$lastpost[postid]."#post".$lastpost[postid];
} else {
$goto="forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]";
}
eval("standardredirect(\"".gettemplate("redirect_postthanks")."\",\"$goto\");");
exit;
}

[Xenon]

Normally you can simply add this for yourself.

I won't add it to the hack because it's no standart in vb, so who hasn't installed chens hack would get an error.

I haven't installed chens hack so i don't know exactly how it works, but as i think adding one line and changing one should be enough

[BigJohnson]

bump. we both posted at the same time hehe.

[Xenon]

@Big: hmm, must have something to do with the cache thats what i have in the attachment:
$lastpost = $DB_site->query_first("SELECT * FROM post WHERE threadid = '$threadid' ORDER BY postid DESC");
if($lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach])) {
$DB_site->query("INSERT INTO post (postid,threadid,title,username,userid,dateline,at tachmentid,pagetext,allowsmilie,showsignature,ipad dress,iconid,visible) VALUES (NULL,'$threadid','".addslashes(htmlspecialchars($title))."','".addslashes($postusername)."','$bbuserinfo[userid]','".time()."','$attachmentid','".addslashes($message)."','$allowsmilie','$signature','$ipaddress','$iconi d','$visible')");
} else {
$editedbysql="";
if ($showeditedby and $lastpost[dateline]<(time()-($noeditedbytime*60))) {
$editedbysql=",edituserid='$bbuserinfo[userid]',editdate='".time()."'";
}

$DB_site->query("UPDATE post SET pagetext='".addslashes($lastpost[pagetext]."\n\n".$message)."'".$editedbysql." WHERE postid=".$lastpost[postid]);
if ($visible) {
$goto="showthread.php?s=$session[sessionhash]&postid=".$lastpost[postid]."#post".$lastpost[postid];
} else {
$goto="forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]";
}
eval("standardredirect(\"".gettemplate("redirect_postthanks")."\",\"$goto\");");
exit;
}


Ya can there be somewhere where it would say DOUBLE POSTING FEATURE and then under that it would show the message instead of just having a Break in the post and then the new edited message.

UPDATE post SET pagetext='".addslashes($lastpost[pagetext]."\n\n".$message)

replace the \n\n with whatever you want

[BigJohnson]

O thanks so much worked amazingly well.

[Neo]

amazing someone finally made this hack Oo... i had this like 4 month ago funny. Nice job.

[Xenon]

:)
and i has also wondered why no one has made that already ;)

[X-Fan]

I'm not finding this:


(NULL,'$threadid','".addslashes(htmlspecialchars($title))."'


in newreply.php - I've got:


(NULL,'$threadid','".addslashes(htmlspecialchars($subject))."'


Where $title should be. Any suggestions?

[Xenon]

hmm, which version of vb are you using?

try just change the $title in $subject in my replacements and implement it.

[Link14716]

Nice hack..... Thanks ;)

[Smoothie]

I'm finding the same as X-Fan. We should change $subject to $title?

[Xenon]

no change the $title in my instructions into $subject :)

i think it should work, but i don't really know, here at my files its $title :)

[Smoothie]

To change the time that the post would be new "new" instead of added to, is this the line that needs to be changed?$lastpost[dateline])>3600

[X-Fan]

Well I don't really want to go installing a hack and changing a string value if noone is certain that it will work or not!

Can someone please check it first on a test board to make sure that changing $title to $subject works?

[Xenon]

@Smothie yes :)

@X-Fan: just make a backup of your newreply.php, if it doesn't work, you can upload your backup agin without any problems.

tell me what vb-version you use, because i couldn't find $subject in my newreply.php (except of the one which is used to send email to mods)

[X-Fan]

I'm using v2.2.5 if that helps any.

[Xenon]

arg, problems on this server now, can't acces to page 2 anymore....

hmm, i also use v2.2.5.
this is the part of the original file:

if ($attachmentid and !$foruminfo[moderateattach]) {
$DB_site->query("UPDATE thread SET attach = attach + 1 WHERE threadid = '$threadid'");
}
$DB_site->query("INSERT INTO post (postid,threadid,title,username,userid,dateline,at tachmentid,pagetext,allowsmilie,showsignature,ipad dress,iconid,visible) VALUES (NULL,'$threadid','".addslashes(htmlspecialchars($title))."','".addslashes($postusername)."','$bbuserinfo[userid]','".time()."','$attachmentid','".addslashes($message)."','$allowsmilie','$signature','$ipaddress','$iconi d','$visible')");
$postid=$DB_site->insert_id();

indexpost($postid,0);

if every $title is canged in $subject in your file, then it won' be a problem.
just replace evere $title in my hack with $subject. but i'm wondering why you have differen files then.

[X-Fan]

I've got that in my newreply.php as well. My board is a heavily-hacked one, so I'm wondering if it may be another hack that has changed that line?

[Xenon]

well it is possible, that another hack has changed that line

you have to compare the changes my hack does to the original file and try to include it into your file.

as i said, make a backup of your newreply.php, include the hack, if it doesn't work, use the backup again

[Smoothie]

I have the same code as X-Fan, using 2.2.2

[Xenon]

hmm *wondering*

try just to replace all $title with $subject in my instructions, but make a backup of your file before implementing it. :)

[Webmasta XT]

THis is a very cool hack, stops ppl from spamming, lol

[Xenon]

Have uploaded a new version.
Changes:
The added text will be included in the searchindex now.
Also the Dateline of the post and the lastpost time of the thread are updated after someone make such a doublepost, so it is counted as a new post, if a user has logged out between the original post and the addition :)

[deFunx]

Cool man, I like the hack...

[Mystislav]

Hmm, when I installed it, when you post it has a white screen with a error on line 288... and im on vb 2.2.6

[Xenon]

you must have made an mistake when installing my hack
it works perfect in vb2.2.6

use a backup of your file, and follow the instructions carefully...

[Mystislav]

Dayum... No matter what I do it still says a error is on line 288 or 289...++++.

[Xenon]

post 5 lines above and below line 288, perhaps i can see your fault

[Mystislav]

o.O...err ok I'll try.

--------


Heh, still did'nt work, well this is how it looks in the php file, can you see if its messed up there

$lastpost = $DB_site->query_first("SELECT * FROM post WHERE threadid = '$threadid' ORDER BY postid DESC");
if($lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach])){
$DB_site->query("INSERT INTO post

(postid,threadid,title,username,userid,dateline,at tachmentid,pagetext,allowsmilie,showsignature,ipad dress,iconid,visible) VALUES

(NULL,'$threadid','".addslashes(htmlspecialchars($title))."','".addslashes($postusername)."','$bbuserinfo[userid]','".time()."','$attachmentid','".addslashes($mess

age)."','$allowsmilie','$signature','$ipaddress','$iconi d','$visible')");
} else {
$editedbysql="";
if ($showeditedby and $lastpost[dateline]<(time()-($noeditedbytime*60))) {
$editedbysql=",edituserid='$bbuserinfo[userid]',editdate='".time()."'";
}
unindexpost($lastpost[postid],$lastpost[title],$lastpost[pagetext]);
$DB_site->query("UPDATE post SET dateline='".time()."',pagetext='".addslashes($lastpost[pagetext]."\n\n".$message)."' WHERE

postid=".$lastpost[postid]);
indexpost($lastpost[postid],0);
$DB_site->query("UPDATE thread SET lastpost='".time()."' WHERE threadid='$threadid'");
if ($visible) {
$goto="showthread.php?s=$session[sessionhash]&postid=".$lastpost[postid]."#post".$lastpost[postid];
} else {
$goto="forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]";
}
eval("standardredirect(\"".gettemplate("redirect_postthanks")."\",\"$goto\");");
exit;
}

[Xenon]

hmm, can't see whats wrong...

can you please highlight which of this line is the error producing line (as your errormsg says)

also please tell me the exact errormsg ;)

[Mystislav]

Ok, here is the message

Fatal error: Call to undefined function: unindexpost() in /home/sjmadho/public_html/board/newreply.php on line 288

and the exact newreply is in the attactments .. thanks alot.

[Xenon]

mystislav: edit your post, you are not allowed to post full vb-files here!!!

second: than the problem isn't my hack. you have to have made some mistakes some time ago, the function unindexpost() is defined in functions.php on every vb. If you don't have it, you have messed up your functions.php

[Mystislav]

Aight, so if I upload a new functions it should work?

[Boofo]

Xenon,

Is there any way to add color to the DOUBLE POST FEATURE part of this line?

$DB_site->query("UPDATE post SET dateline='".time()."',pagetext='".addslashes($lastpost[pagetext]."\n\nDOUBLE POSTING FEATURE\n\n".$message)."' WHERE postid=".$lastpost[postid]);
indexpost($lastpost[postid],0);

[Xenon]

@Mystislav: yes, then it should work.

@Boofo: You can use every vb-code in the textpassage between post1 and post2, so if you have enabled the color-bbcode on your board you should be able to do that:
$DB_site->query("UPDATE post SET dateline='".time()."',pagetext='".addslashes($lastpost[pagetext]."\n\nDOUBLE POSTING FEATURE\n\n".$message)."' WHERE postid=".$lastpost[postid]);

for example

[Boofo]

I had to replay to this message in order to see how you had the code (it was parsed here. The disable tags hack is great for this sort of thing!) :)

I was using <font color=\"yellow\"> and </font>. That's where I messed up. Thanks for the fix. :)

$DB_site->query("UPDATE post SET dateline='".time()."',pagetext='".addslashes($lastpost[pagetext]."\n\nDOUBLE POSTING FEATURE\n\n".$message)."' WHERE postid=".$lastpost[postid]);

Originally posted by Xenon

@Boofo: You can use every vb-code in the textpassage between post1 and post2, so if you have enabled the color-bbcode on your board you should be able to do that:

$DB_site->query("UPDATE post SET dateline='".time()."',pagetext='".addslashes($lastpost[pagetext]."\n\nDOUBLE POSTING FEATURE\n\n".$message)."' WHERE postid=".$lastpost[postid]);

for example

[Boofo]

I forgot to add in my last message (you see...they really need this here for this kind of thing. :) ).

Is there a way to have it say like:

DOUBLE POSTING FEATURE - (post subject here)

in case they enter a post subject in the added message?

And have it show:

DOUBLE POSTING FEATURE

by itself it they don't?

[Xenon]

ups, damn i forgot code is parsed in [/i]]-tags too ;)

yes, Having the Subejct is also possible:

[php]$DB_site->query("UPDATE post SET dateline='".time()."',pagetext='".addslashes($lastpost[pagetext]."\n\nDOUBLE POSTING FEATURE - ".$title."\n\n".$message)."' WHERE postid=".$lastpost[postid]);

[Boofo]

Xenon,

Thank you very much, sir. That works great! Now (this is the last thing, I swear. :) ), Is there a way to have the date and time of the first post stay the same so we know when the post started and have the date and time of each additional post in the DOUBLE POSTING Feature right after the subject title? That way we know when the first message was (by the original date and time staying in tact) and the new date and time for each addition after the subject line.

[Xenon]

*ggg* in my first version of the hack the time stayed the same after posting, its just altered tu bump a thread.
if you want to stay the time just remove this part:
dateline='".time()."',
from this line: $DB_site->query("UPDATE post SET dateline='".time()."',pagetext='".addslashes($lastpost[pagetext]."\n\n".$message)."' WHERE postid=".$lastpost[postid]);

and then: yes you can add the time after the subject, but you have a small problem: the timeoffset can't be variable anymore in this timestamp ;)

just add something like that:
$DB_site->query("UPDATE post SET dateline='".time()."',pagetext='".addslashes($lastpost[pagetext]."\n\nDOUBLE POSTING FEATURE - ".$title." posted at:".vbdate($dateformat,time())."\n\n".$message)."' WHERE postid=".$lastpost[postid]);

[Boofo]

I see what you mean about the time no longer working right when I add it to the middle of that line. I went back to the time changing in the main post and left it with just the title added. It doesn't do me any good if I can't pull the time out for each addition. Thanks, anyway, for trying. And thanks for putting up with all of my wacky ideas. :) You have a great hack here! Keep up the fantastic work! :)

[Parker Clack]

Xenon:

I made the following changes so that if the post is the same as the one that they just got through posting within the past hour then nothing new gets added to the thread or the post.

$lastpost = $DB_site->query_first("SELECT * FROM post WHERE threadid = '$threadid' ORDER BY postid DESC");
if($lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach]) || $lastpost[pagetext]!='".addslashes($message)."') {
$DB_site->query("INSERT INTO post (postid,threadid,title,username,userid,dateline,at tachmentid,pagetext,allowsmilie,showsignature,ipad dress,iconid,visible) VALUES (NULL,'$threadid','".addslashes(htmlspecialchars($title))."','".addslashes($postusername)."','$bbuserinfo[userid]','".time()."','$attachmentid','".addslashes($message)."','$allowsmilie','$signature','$ipaddress','$iconi d','$visible')");
} else {
if ($visible) {

$goto="showthread.php?s=$session[sessionhash]&postid=".$lastpost[postid]."#post".$lastpost[postid];
} else {

$goto="forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]";
}
eval("standardredirect(\"".gettemplate("redirect_postthanks")."\",\"$goto\");");
exit;
}

I also took out the edited by section because I didn't want the new post to show up at all.

--Parker

[Xenon]

you should put [php]-tag around your php-code ;)

but it's a good idea, i'll upload a new version, which doesn't update the old post if the message is the same as pagetext of the old one ;)

[Parker Clack]

Xenon:

Yeah I know. I forgot the phpcode. Sorry about that.

Thanks for including this with your great hack.

Parker

[Darth Cow]

One little issue... can you modify it so that it adds on a new post if that would make it go over the characters per post limit, instead of just editing the old one?

[Xenon]

ups, a feature i didn't use, so i've forgotten to add something for this ;)

find this line:if($lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach])) {

and replace it with:if(((strlen($message)+strlen($lastpost[pagetext])>$postmaxchars and $postmaxchars!=0) || $lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach])) {

[Boofo]

When I change the code you gave above, I get this error: :)

Parse error: parse error, unexpected '{' in /home/boofo/public_html/forum/newreply.php on line 399

[Xenon]

damn ")" and "}"s ;)

ad a ) just before }
should work then ;)

[Boofo]

Thank you, sir. Worked like a charm. :)

[Thewnagchung]

Warning: Unexpected character in input: '' (ASCII=16) state=1 in /home/videogam/public_html/forum/newreply.php on line 307

im getting this error, what should i do?

[Sadie Frost]

Thank you so much for this hack (from someone often called the Double-Posting Nazi) ;)

[Xenon]

Originally posted by Thewnagchung
Warning: Unexpected character in input: '' (ASCII=16) state=1 in /home/videogam/public_html/forum/newreply.php on line 307


im getting this error, what should i do?

have you done all steps correct? this error never occures to someone else

[LOD-squa]

I like it.

*clicks install*

[LOD-squa]

but I have a problem It won't work on my quick reply.

[Xenon]

hmm, as i know it works with fireflys quickreply, if you use anotherone, you have to add some similar lines of code to the quickreply section...

[LOD-squa]

lol I noticed I didn't upload newreply.php lol.

sorry for the trouble.

[Xenon]

loool

np :)

[LOD-squa]

I need suggestion. I want to install another hack but I don't know what could you suggest me something?

[Xenon]

you should tell me what you want to install too, maybe i can give a hint to you

[LOD-squa]

Umm right now I'm trying to fix a lil problem with the itemshop has soon has I do so I'll tell you :p.

[Boofo]

Xenon, is there a way to make this be able to turn it off and off in the Admin CP for site testing purposes on various hacks? An option, I mean. :)

[Xenon]

as you know everything is possible ;)

go to admin/settings.php and create new setting variablename: stopdoublepost
function to create: yesno

and then just before $lastpost[userid]!=$bbuserinfo[userid] || in newreply.php add this:
!$stopdoublepost ||

[Boofo]

Stefan, thanks for the help. This is the part that has been stumped, though. :)

go to admin/settings.php and create new setting variablename: stopdoublepost
function to create: yesno

[Silenced Soul]

nice hack man. very nice :nod:

[Boofo]

I found out why I couldn't figure out what you meant, Stefan. The file I needed to set the option in was "admin/setting.php". I was looking for "admin/settings.php". DOHHH!!!

I did what you instructed and it works like a charm. Thank you very much, sir. :)

Edit: I just noticed that on the first post if I check the "Send User to forums" checkbox (from Firefly's hack), it sends the user back to the forum display. If I check it on a double post (when Prevent Double Posting is enabled), it will not send the user back to the forum display. Instead it sends the user back to view the message. Is there a way to fix that so it will work with the Send User back to forum hack?

[Xenon]

@boofo: damn 's' ;)

yes it is possible, look at this:
if ($visible) {
$goto="showthread.php?s=$session[sessionhash]&postid=".$lastpost[postid]."#post".$lastpost[postid];
} else {
$goto="forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]";
}
and change it to:
$goto="forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]";

should work

[Boofo]

I'm sorry, my friend, now all it will do is send me back to the forum display no matter if the "send user back to forum" box is checked or not.

Edit: Fixed! :):):) (But only because of you, sir. :))

What I did was:

Replace:

if ($visible) {
$goto="showthread.php?s=$session[sessionhash]&postid=".$lastpost[postid]."#post".$lastpost[postid];
} else {
$goto="forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]";
}
with: if ($visible && !$sendtoforum) {
$goto="showthread.php?s=$session[sessionhash]&postid=".$lastpost[postid]."#post".$lastpost[postid];
} else {
$goto="forumdisplay.php?s=$session[sessionhash]&forumid=$threadinfo[forumid]";


Now it works according to if the box is checked or not and takes you where it should. :)

[Xenon]

ahh, sorry i didn't know the hack, i just thought you want everybody back to forumdisplay ;)

[Boofo]

No, don't be sorry. I want to thank you. If you hadn't shown me that piece of code (which I should have found myself, dummy me :)) then it never would have clicked with me the right way to do it. So, thank you again, my friend. :)

Originally posted by Xenon
ahh, sorry i didn't know the hack, i just thought you want everybody back to forumdisplay ;)

[Colon33]

Originally posted by Mystislav
Ok, here is the message

Fatal error: Call to undefined function: unindexpost() in /home/sjmadho/public_html/board/newreply.php on line 288

and the exact newreply is in the attactments .. thanks alot.

I am getting this exact error problem, and i looked in my functions.php file but where am i looking for an error? I had to change this line

$noshutdownfunc = 0; // #CHANGE ME IF YOU CAN'T USE register_shutdown_function

to this:

$noshutdownfunc = 1; // #CHANGE ME IF YOU CAN'T USE register_shutdown_function

because my thread views stopped working. Got any ideas where my functions.php file is messed up? Otherwise i dont know how to fix it... any assistance would be very helpful.

[Bloodfist]

For some reason, on my board "/" appear before " ' " in the second post.

[Bloodfist]

like 'this (test)

[Xenon]

yes, seems there was a addslashes function where it shouldn't be
corrected

[Boofo]

Stefan, can you let us know where that was at so we can correct it on what we already have installed? :)

Originally posted by Xenon
yes, seems there was a addslashes function where it shouldn't be
corrected

[Xenon]

no problem
it was addslashes($message) and it should just be $message in the update post line :)

[kikosho]

Xenon...I am sorry, I am definitely missing something, so can you please clarify for us dense board admins? :)

what php or template file needs to be edited so that I can remove the slashes from the double post actions? (and if possible, can you include which line it's on?) thanks.

[Xenon]

you have to edit newreply.php and change addslashes($message) into $message in the part of my hack..

[Colon33]

Does this fix that unindex error i am getting? I was told to upload a new functions.php.. did that, doesnt work, still unindex error

[Xenon]

nope the unindex error you posted seems to be another problem
my hack doesn't change this function.

as you can read in the message unindexpost function isn't declared for some reason.
have you upload an unhacked version of functions.php

if problem stays you should open a thread in support forum

[yzztik]

Originally posted by Xenon
you have to edit newreply.php and change addslashes($message) into $message in the part of my hack..

when I search for this it appears 4 times in this order:


if ($prevpost=$DB_site->query_first("SELECT attachmentid,postid,visible FROM post WHERE threadid='$threadid' AND username='".addslashes($postusername)."' AND userid='$bbuserinfo[userid]' AND title='".addslashes(htmlspecialchars($title))."' AND dateline>$datecut AND pagetext='".addslashes($message)."'")) {



$DB_site->query("UPDATE post SET title='".addslashes(htmlspecialchars($title))."',pagetext='".addslashes($message)."',allowsmilie='$allowsmilie',showsignature='$signa ture',iconid='$iconid',attachmentid='$attachmentid ' WHERE postid='$postid'");



$DB_site->query("INSERT INTO post (postid,threadid,title,username,userid,dateline,at tachmentid,pagetext,allowsmilie,showsignature,ipad dress,iconid,visible) VALUES (NULL,'$threadid','".addslashes(htmlspecialchars($title))."','".addslashes($postusername)."','$bbuserinfo[userid]','".time()."','$attachmentid','".addslashes($message)."','$allowsmilie','$signature','$ipaddress','$iconi d','$visible')");



$DB_site->query("UPDATE post SET pagetext='".addslashes($lastpost[pagetext]."\n\n".addslashes($message))."' WHERE postid=".$lastpost[postid]);


any idea which one I should change?

[Xenon]

the last one

[yzztik]

Thanks a lot! It worked great!

[yzztik]

How could I make certain usergroups like mods/super mods/admins excempt from this rule? Meaning so that members can't double post but they can. And could it be a toggle so they could choose to bypass it or not?

[Xenon]

the first thing is easy:
find if($lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach])) {

and just add the usergroupconditions:
if($bbuserinfo['usergroupid'] ==6 || $bbuserinfo['usergroupid'] ==7 || $bbuserinfo['usergroupid'] ==5 ||$lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach])) {

a toggle would also be possible (with a bit more work), but i don't see the effect there?
i mean if they want to add it to the last post mods should be able to edit ;)

[N9ne]

I love this hack, excellent work Xenon :)

[yzztik]

Originally posted by Xenon
as you know everything is possible ;)

go to admin/settings.php and create new setting variablename: stopdoublepost
function to create: yesno

and then just before $lastpost[userid]!=$bbuserinfo[userid] || in newreply.php add this:
!$stopdoublepost ||

I think I am missing something here ... how exactly do I create this variable? I don't see it :$

[Xenon]

you have to go to admin/settings.php

there you can set up a new vb-option called stopdoublepost.
just add yesno to the field function to create...

after that you'll have a new option in your vb-options within acp

[yzztik]

Ok, I am sorry to sound dumb, but how exactly do I do that? There are several sections in the file. Where and how do I add it? Does it go under "start add" or someplace else? And is it like the makeinputcode thing?

[Xenon]

admin/setting.php

Posting Code allowances (vB code / HTML / etc) [edit] [remove] [add setting]

click add setting

Title: Enable Doublepost checking
Variable Name: stopdoublepost
Value: 0
Code to generate option: yesno
Order: 1 (or something else)

[yzztik]

ok NOW I feel really dumb :$ I was opening the PHP file instead of going to the file on my browser. Dunno why I didnt think of trying that. So so sorry :(

[Xenon]

*gggg*

no problem :)

[partang2]

Works great on 2.2.9 with fireflys quickreply installed!

*Clicks install*

[N9ne]

Xenon, I have a question. How can I exempt one thread from the double post prevention?

if($bbuserinfo['usergroupid'] ==6 ||$lastpost[userid]!=$bbuserinfo[userid] || (time()-$lastpost[dateline])>3600 || ($attachmentid and !$foruminfo[moderateattach])) {

Is it something to do with this line? Do I just add || $threadid=2171 to it???

[Xenon]

yes right, but you should use $threadinfo['threadid'] == 2171 :)

[N9ne]

Ah ok, yesterday I decided to pick up my php book and learn each page from the start slowly step by step, so hopefully in a few months i'll be able to hack much bigger hacks :). Thanks for the code though.

[007]

Is there a way to make this say edited by "name" on "date"

you know, the standard edit text when someone posts?

Is it possible to make it do this after the same amount of time that my normal time is set ebfore having it diplay edited by?

I have it set to 2 minutes, so how would I do this?

I tried:else {
if($lastpost[pagetext]!=$message) {
$editedbysql="";
if ($showeditedby and $lastpost[dateline]<(time()-($noeditedbytime*1))) {
$editedbysql=",edituserid='$bbuserinfo[userid]',editdate='".time()."'";
}without any luck... Probably something stupid I didn't think of.. :ermm:

[Xenon]

have you applied th edited by thing i posted in the thread here already?

[007]

Originally posted by Xenon
Velocd: i have updated the installation file, now it should add an edited by message :)

??? I assumed this was in the installation file now. I looked around and am not seeing it. Can you maybe give me the post # of it? Thanks. :)

[Xenon]

oh right, it's in the install file *gg*
(sometimes i forgot what i've already included in the hacks ^^)

if ($showeditedby and $lastpost[dateline]<(time()-($noeditedbytime*60))) {
$editedbysql=",edituserid='$bbuserinfo[userid]',editdate='".time()."'";
}

it's in there, so it should show the edited by after 2 minutes with the original code...
be sure you have enabled the showedited by thing..

[Xenon]

oh, sorry, you were right :)

there was a little bug in it.

i've uploaded a new version, it should work now, also i've optimized the querie a bit, so i think it's good for everyone to install the new version :)

[Boofo]

How do we get the subject (title) back in the line now? ;) I have this but it doesn't seem to work.

$DB_site->query("UPDATE post SET dateline='" . time() . "'" . $editedbysql . ",pagetext='" . addslashes($lastpost[pagetext] . "\n\nDOUBLE POSTING FEATURE - ".$title."\n\n".$message)."' WHERE postid=" . $lastpost['postid']);

[Xenon]

yeah, it's right it would work normally..

that part hasn't changed in my update, just a part before ;)

[Boofo]

I tried it with title and $lastpost[title] and all I get is a black line where the title should be. I'm looking at the old code I had from 6 months ago for this and seeing if I can figure it out. ;)

[007]

Oh cool. Thanks Xenon.

I have a question though, I tried making the edited by part the same as it is in editpost.php, which would look like:
else {
$editedbysql="";

if ($showeditedby and $postinfo[dateline]<(time()-($noeditedbytime*60)) and !($getperms[ismoderator] and !$showeditedbyadmin)) {
$editedbysql=",edituserid='$bbuserinfo[userid]',editdate='".time()."'";
}Except that for some reason it still shows the "Edited by" if I have admins set to not show edited by. I tried it with:else {
$editedbysql="";
if ($bbuserinfo['usergroupid'] == 6) {
$editedbysql="";
}
if ($showeditedby and $lastpost['dateline'] < (time() - ($noeditedbytime * 60))) {
$editedbysql = ",edituserid='$bbuserinfo[userid]',editdate='" . time() . "'";
}and that did work (I think, I tested it really quickly), but I want it to work with the setting in vb options in Admin CP. How would I do this?

Thanks. :)

[Xenon]

use that 006:

else {
$editedbysql="";
if ($showeditedby and $lastpost['dateline'] < (time() - ($noeditedbytime * 60))and !($getperms[ismoderator] and !$showeditedbyadmin)) {
$editedbysql = ",edituserid='$bbuserinfo[userid]',editdate='" . time() . "'";
}

[007]

I tried that and it shows the "edited by" no matter what I have selected in Admin CP. It's weird. :(

I have no clue why. :ermm:

Any ideas?

[Xenon]

sorry, no idea, it should work...

have you tried it on a post where the edited by wasn't there already, because it won't delete it if it's already ther..

[007]

yeah I made two new posts and then waited two minutes, then replied to one with "Show Admin Edit" turned on, and one with it turned off, and it showed "edited" both times.

[Xenon]

hmm, no idea then, it should work normally...

[007]

lol

Well if you don't know then it must be REALLY weird... I thought that would work too... Oh well, I can just tell admins if they don't want it to show "edited by" to just actually edit the post instead of replying. That's alright I guess. ;)

Thanks anyway. :)

[Kars10]

Man this hack rules!!
Exactly what i?ve been looking for!!

Thanks Stefan!!

* Kars10 klicks install! ;)

[Lineman28645]

I love this hack. It pisses most the members off because they cant get more posts.

[TranceMaster]

works perfect man
thanks for another amazing hack
1 quick eustion
am i right in saying that if u want to change the amount of time given before a new post is made i just edit this line
if ($showeditedby and $lastpost['dateline'] < (time() - ($noeditedbytime * 60))) {
and change the 60 into whatever i want?

[sabret00the]

this is a great hack, should be a default in vB will have to install it later

[Xenon]

Today at 12:26 TranceMaster said this in Post #135 (https://vborg.vbsupport.ru/showthread.php?postid=367960#post367960)
works perfect man
thanks for another amazing hack
1 quick eustion
am i right in saying that if u want to change the amount of time given before a new post is made i just edit this line
if ($showeditedby and $lastpost['dateline'] < (time() - ($noeditedbytime * 60))) {
and change the 60 into whatever i want?


nope, you have to change the 3600 in this line: if($lastpost['userid'] != $bbuserinfo['userid'] OR (time() - $lastpost['dateline']) > 3600 OR ($attachmentid and !$foruminfo['moderateattach'])) {

[TranceMaster]

oooops
ok thanks for the help man :)

that 3600, is that seconds?
lets say i wanted to make it for 24 hours, would i just find out how many seconds are in 24 hours, and put it in?

[Xenon]

exactly ;)

or to make it easier to read just write 3600 * 24 ;)

[yxboom]

I think I may have found a bug. I have the post limit at 18000 characters. I have posts being ammended going beyond that. One guy kept reposting and reposting and it kept being ammended to the previous post so his single post has 42000 characters now.

[Xenon]

hmm, yeah i know that "bug".
but i wasn't sure if it would disturb or not... at least sometimes that could have been the reason for the "doublepost"

for a quickfix use this:

before:
$DB_site->query("UPDATE post SET dateline='" . time() . "'" . $editedbysql . ",pagetext='" . addslashes($lastpost[pagetext] . "\n\n" . $message) . "' WHERE postid=" . $lastpost['postid']);

add this:
$newmessage = $lastpost[pagetext] . "\n\n" . $message;
if (strlen($newmessage)>$postmaxchars and $postmaxchars!=0) {
eval("standarderror(\"".gettemplate("error_toolong")."\");");
}

[yxboom]

Thanks a lot for the hack and help. On my board the post limit has its reasons cause of too many people making too many points that by the time someone responds they have to deal with 30 points instead of a simple 2-3 point rebuttal so this helps significantly.

[jancarlo]

ok anche in vb 230 :)

bello script!!! :D

jancarlo



ok also in vb 230:)

beautiful script!!! :D

jancarlo

[sabret00the]

installed and works great, should really be default to vB, very awesome hack Xenon

and you're an admin now, add the mini section ;)

[Opie]

Can someone let me know how to exclude some forums from the hack? I only want it on a few.

Also a way to stop if from counting points(store hack) if it was a double post?

[Xenon]

for the storehack i can't help ya, because i don't use it.

i think all you have to do ist to put the add to storpoint part of newreply under the user post count update part.

to exclude forums:
change this:
if($lastpost['userid'] != $bbuserinfo['userid'] OR (time() - $lastpost['dateline']) > 3600 OR ($attachmentid and !$foruminfo['moderateattach'])) {

into this:
if(in_array($threadinfo['forumid'], array(x,y,z)) or $lastpost['userid'] != $bbuserinfo['userid'] OR (time() - $lastpost['dateline']) > 3600 OR ($attachmentid and !$foruminfo['moderateattach'])) {

and change x,y,z into the forumids you want to exclude

[Boofo]

Is the guy who wrote this (in the message above)

$threadinfor['forumid']

the same guy who got me on the nothing and anything words the other day? ;) :p

Is this a new variable in vb3? ;)

[Xenon]

:p

mine is just a typing, yours was sensechanging :p ;)

but yeah i try to convince the devs to add this as a new vb3 var ;)

[Boofo]

Today at 05:06 PM Xenon said this in Post #148 (https://vborg.vbsupport.ru/showthread.php?postid=379877#post379877)
:p

mine is just a typing, yours was sensechanging :p ;)

Yes, but I'm allowed to butcher the English language because it is my native language. ;)

but yeah i try to convince the devs to add this as a new vb3 var ;)

Great! Then you don't ever have to worry if it is misspelled again huh? ;)

[solent]

small easy and cool hacks by Xenon. this is vey cool as most of the users dunno what the edit button does and most of the times the reply 3-4 times with a newreply instead of editing.

[Hobbes]

i have one question....heh....i hope this thread is like....still loooked at!!!!

anyway....

the attachment is the Double Post Prevention Hack before I installed

Anime-loo 's Post Redirect Hack.

I was wondering what i would change in the code so that it will show

"Double Posting are we?"

between each post, instead of right after the text like it's doin now....if needed, i'll attach another screenshot of how it looks now....

I hooooppppe someone can answer this *dances*

[Hobbes]

:bunny: well...i'm bored....so i'll show ya how it looks now...


the attachment actually shows

(1) how it was [in the quote]

(2) how it is now [after i installed Anime loo's Post Redirect hack.

heeelp??

:bunny:

[Xenon]

hmm, i can't really see the sense for this, but all you have to change is this:

addslashes($lastpost[pagetext] . "\n\n" . $message)

the string \n\n produces two enters, but you can replace it with everything you want to be between the two posts.
if you left out the \n tags, it will lead to your problem.

if they're in, maybe you have to ask anime about his hack ;)

[Hobbes]

*dances*....

THANKS !!!!!!!! \n\n did the trick! w00t!

[Opie]

[i]04-09-03 at 07:23 AM Xenon said this in Post #146 (https://vborg.vbsupport.ru/showthread.php?postid=379588#post379588)

to exclude forums:
change this:
if($lastpost['userid'] != $bbuserinfo['userid'] OR (time() - $lastpost['dateline']) > 3600 OR ($attachmentid and !$foruminfo['moderateattach'])) {

into this:
if(in_array($threadinfo['forumid'], array(x,y,z)) or $lastpost['userid'] != $bbuserinfo['userid'] OR (time() - $lastpost['dateline']) > 3600 OR ($attachmentid and !$foruminfo['moderateattach'])) {

and change x,y,z into the forumids you want to exclude [/B]

When I do this I get this error:

Parse error: parse error, unexpected ',' in /home/opie/public_html/forums/newreply.php on line 296

I'm running 2.2.7 if that matters.

[Xenon]

if you have made everything right, there couldn't be such a parse error.

you should check your php syntax on mistakes you have made

[Opie]

if($threadinfo['forumid'], array(10,11,13)) or $lastpost['userid'] != $bbuserinfo['userid'] OR (time() - $lastpost['dateline']) > 3600 OR ($attachmentid and !$foruminfo['moderateattach'])) {


That's what I put and those are valid forum ids, but still the error... weird.

[Xenon]

whats wierd?

you clearly forgot half of the codechanges......
why haven't you put the word in_array in your code as i stated?

[Opie]

Sorry I don't know too much about php, so instead of array put "in_array" ?

I didn't see where you said put "in_array".

[DigitalDesktops]

use this code instead, it seems VB took out in_array :p lol:


if(in_array($threadinfo['forumid'], array(x,y,z)) or $lastpost['userid'] != $bbuserinfo['userid'] OR (time() - $lastpost['dateline']) > 3600 OR ($attachmentid and !$foruminfo['moderateattach'])) {

[Opie]

Thanks a lot, it worked.

[Xenon]

Today at 05:45 DigitalDesktops said this in Post #160 (https://vborg.vbsupport.ru/showthread.php?postid=389795#post389795)
use this code instead, it seems VB took out in_array :p lol:


can you proove that?
in_array is clearly visible in my post where the code is.

[Boofo]

It's there if you quote it but I don't see it in post 146 itself. Am I missing it, too? ;)

[Xenon]

it's also clearly visible in post 146!

[Boofo]

This is really weird then because this is what I see in Post # 146

if($threadinfo['forumid'], array(x,y,z)) or $lastpost['userid'] != $bbuserinfo['userid'] OR (time() - $lastpost['dateline']) > 3600 OR ($attachmentid and !$foruminfo['moderateattach'])) {

[Xenon]

hmm, i think i know what's the problem..

the highlight function names seems to work incorrectly here..

you should disable that option in your usercp.

i'll look into the code, but i don't find anything right now...

[Boofo]

I've noticed that happening in a few other places here lately. Just thought I would let you know in case it comes up again. ;)

[Xenon]

hmm wierd...

it should work now but i don't have changed something as far as i know???
i just moved the code from bbcodeparse2 into a own function and it showed up. *gg*

[Boofo]

Well, it seems to work now. That will fix a few things here as far as code goes. ;)

Maybe that's why the DISABLE tag hasn't been working very well? ;)

[Xenon]

hmm, the disable tag is parsed on another part....

hmm, no idea, at least it worx now ;)

btw. you haven't clicked on install yet :p

[Boofo]

I don't have this hack installed on 2.2.9 right now. I un-installed it when I couldn't get the time and date to show for the double post and haven't re-installed it yet. I clicked the install button just now, anyway, though. ;)

I know we went through this when I had 2.2.5 up and running, but I don't remember how we did it. I want to add an option in the Admin CP to turn it off if I need to do some testing on the site and be able to turn it back on again. maybe even have it be able to be disabled for Admins. Any ideas? ;)

[Xenon]

hmm, if we already worked it out, maybe you can find it again in the thread ;)

[Boofo]

Any way to get the date (if different from the original date) and time of each double post?

[Xenon]

not without changing the table structure...

[Merlin3649]

everything seems to be working without a hitch, just wanted to pitch in my 2 cents worth of affirmation :P

[Merlin3649]

oh, just for everyone's edification, if you run into a 1064 mysql error number after doing the hack, make sure you didn't remove the line

$postid=$DB_site->insert_id();

that's at the very end of the text you're told to replace in the .txt file. I did that by accident and it caused errors until I realized my mistake. The line in question is directly one line after the end of the php-to-be-replaced, so just don't highlight too far :P

[Hobbes]

Ok....

I'm not sure where to post this....buuutt...I have a dilemma!

Alright, I've installed this hack double post prevention and the remove redirects hack...

but here's my problem!!

Let's say I post on page 3....once I submit, I am redirected back to page 1....

If I go back to page 3 (after posting) and double post, I am redirected back to page 3.

this has become quite a nuisance....having to go back...

so i'm wondering...is this the remove redirects

or

the double post prevention thats causin this ackward weird silly thing

!!!????

Anyhelp would be greatly appreciated :)

[Xenon]

neither nor...

it's the normal procedure to be redirected to the posted post.
if it's not like that on your board, you've hacked it, and have to apply the same hack to the prevent doublepost hack :)

[Kriek]

Decided to alter 3600 to 86400 * 30 ;)

24 hours x 60 minutes per hour x 60 seconds per minute yield 86,400 seconds in a day.

86,400 seconds in a day x 30 yield 30-day timeout.

Naturally you could write 2592000 as well.

* Kriek spanks install

[Xenon]

not bad, doubleposting timeout for 30 days ^^

[Sam FT]

Hmmm may have to try this one out.

[tmapm]

I have [AddOn] Useful Additions For Quickreply (and normal reply page) -- https://vborg.vbsupport.ru/showthread.php?s=&threadid=47918&highlight=close+thread+checkbox+reply installed. My problem is when the double posting is prevented and merges the posts, it doesn't allow for the additions (except sticky) included in the Useful Additions For Quickreply to update. I was wondering if someone could take a look at the Useful Addition for Quickreply hack and help me out by rewriting / adding some queries in the Double Posting Hack. I've looked through the files and I haven't been able to figure it out. Any help is appreciated.

[RandyP3]

Hmm, this doesn't work on 2.3.3... I can't find the code needed to be replaced ;) Maybe you could work something out?

[Rampag33]

Great Hacc
Most likely my absolute favorite.

[Xenon]

@tsboard: sorry, i don't have any vb2 boards anymore, so i cannot update my hacks.

normally the changes between these version are just marginal, so, i'm sure, you could find the line slightly changed in 233 as well :)

[VirtualHogwarts]

/me click's install!

Wish it had Edit: then message but hey it's ok (IF SOEONE KNOWS HOW TO DO THIS PLEASE PM ME!)

- VH

btw this works fine on vB 2.3.3 the stuff is there just as he had it in the install file maybe u edited it urself sorry.

[Xenon]

VH, if you read the thread completly i'm sure you'll find the answer about Edit:, i'm quite sure i've posted something like that already :)

if not, just add something to the \n\n string :)

[DuffMan]

Great hack, I've been looking for something like this for ages! Incredibly simple to install and works flawlessly.

[Silverstangs]

Nice very nice, worked perfectly well on vb2.3.3 fully tested out and no issues.

Scott
Clicks install!

[Bambi]

We have the hack in the original post installed on our board (version 2.2.9). Anybody know what's going to happen with it when we upgrade to vb gold? Will it still be in place? Should it be removed before we upgrade? I didn't install it, the person who did is awol, and I really don't know much about php or hacks.

[Xenon]

when you upgrade to vb3 gold every vb2 hack will be useless and won't work anymore.

this special hack has been released by me for vb3 as well :)

[Bambi]

Thanks for the info! :)

[bozzy]

This hack does not work for vb3.0.0 yet. When will it be upgraded? Can somebody post an attachment of the corrected hack?

Thanks

[Xenon]

you may better install the vb3 version which is released since a long time now, instead of lookin into the supportthread of vb2's version ;)

[bozzy]

I couldn't find the thread for 3.0 version, this is the only one that came up in the search.

[Xenon]

just look into my profile, it's there :)