Keep attachments when previewing messages

[Admin]

This hack solves the problem of attachments not being carried on when you preview your message. The "Attach File" box empties itself and you must re-choose the file before posting the message.

So I've "fixed" this little problem. Now when you preview, the attachments is stored in the database, and in the preview screen you get the "Edit Attachment" box (you know that, you see it whenever you edit a post with an attachment). You can Keep, Update or Delete the attachment.

Orphaned attachments (people may preview posts with attachments but never post them) are removed in newthread.php and newreply.php, every 5 minutes.

That's all. The vbHacker file is attached to this post, and a regular text file version will be posted in a minute.
I will install the hack on this board in 5 or 10 minutes, so you can see what I'm talking about.

Enjoy! :bunny:

[Admin]

And the text file, as promised.

[Neo]

Very good addon :)

[Smoothie]

Nice!

[Smoothie]

I'm not finding this bit of code in newreply.php // sort attachement
if ($permissions[canpostattachment] and trim($attachment)!="none" and trim($attachment)!="" and trim($attachment_name)!="") {
$attachmentid=acceptupload($foruminfo[moderateattach]);
} else {
$attachmentid=0;
}Instead, I find this: // sort attachement
if (trim($attachment)!="none" and trim($attachment)!="" and trim($attachment_name)!="") {
$attachmentid=acceptupload($foruminfo[moderateattach]);
} else {
$attachmentid=0;
}And in newthread.php Ican't find this: // sort attachement
if ($permissions[canpostattachment] and trim($attachment)!="none" and trim($attachment)!="" and trim($attachment_name)!="") {
$attachmentid=acceptupload($foruminfo[moderateattach]);
if (!$foruminfo[moderateattach]) {
$attachcount = 1;
} else {
$attachcount = 0;
}
} else {
$attachmentid=0;
$attachcount=0;
}Instead, I find this: // sort attachement
if (trim($attachment)!="none" and trim($attachment)!="" and trim($attachment_name)!="") {
$attachmentid=acceptupload($foruminfo[moderateattach]);
if (!$foruminfo[moderateattach]) {
$attachcount = 1;
} else {
$attachcount = 0;
}
} else {
$attachmentid=0;
$attachcount=0;
}

[Boofo]

Excellent addition, Firefly! Will this also work with the preview private messages hack? :)

[Admin]

Smoothie; You are using an older version of vBulletin.

[Smoothie]

Thanks for reply FireFly. So, is there anyway to get this hack to work with the version I'm using?

[Admin]

Just replace what you have now with my code. You will also get a bug fixed while doing it.

[Smoothie]

FireFly, I replaced my code with yours, but it didn't work. When I try to post a new reply, or add a new thread, nothing happens.

[Admin]

Make sure you followed everything and made all changes.

[Smoothie]

I checked, and rechecked that all the code was changed in accordance with your instructions. When I hit reply, or new thread, it just hangs.

[Admin]

Email me your files if you want, and I'll take a look.

Upload the original files in the mean time, and make sure they work.

[Smoothie]

Ok, email sent. I uploaded the original files, and everything is working fine. Thanks for taking the time to help.

[JJR512]

Is this compatible with PPN's attachments as files (https://vborg.vbsupport.ru/showthread.php?s=&threadid=35193) hack?

[Admin]

No, I don't think so.

[CeleronXL]

What would I do with 2.2.6 as there is

if (is_array($HTTP_POST_FILES)) {
$attachment = $HTTP_POST_FILES['attachment']['tmp_name'];
$attachment_name = $HTTP_POST_FILES['attachment']['name'];
$attachment_size = $HTTP_POST_FILES['attachment']['size'];
in one part that is supposed to be replaced.....

[Bison]

Damn ... I installed this hack and now the only way I can get the attachments to show is when I edit the threads ... can anyone help with this? :(

[tkeil69575]

hi firefly,
i had this installed for a while and it was working as such, however it slowed down my newthread.php and newreply.php extremely. Load time with hack 26 seconds :confused:, without 0.07 seconds on average.

any ideas why that is so? maybe i did something wrong??? Dont think so though, otherwise I guess I would have gotten errormessages of some kind.

regards tina

P.s. Using 2.2.9

[jmke]

same problem occured here, had to remove it :-/

[Boofo]

You must have another hack messing with it then. I am running a very hacked up v2.2.9 and it runs as fast with it installed as it did before I installed it. No difference. :)

[BigJohnson]

This hack is amazing. IT works well. There is just one thing missing. Ok say you post an attachment and then you go edit that post with the attachment. You want to edit the attachment so you upload another and click preview. Now it doesn't keep the attachment you just wanted to change. You have to do it again. This is in the editpost.php and that file was never edited during this hack. Can someone addon this feature please. Thanks so much.