Improved Who's Online Display

[TWTCommish]

This hack is pretty straightforward: it provides more detail on the Who's Online? page. Here are some examples: Things like "Editing Buddy List" or "Editing Forum Options" are not accompanied by links. "Buddy List" links to the page to edit your own Buddy List, and so on with "Forum Options, "Ignore List," and a few others similar to that.

Instead of "Sending Email to Another Forum User" or "Viewing the Profile of a Forum Member," you'll be told which user it is in both cases, and their username will be a link to their profile.

Most significantly, IMO: no more vague "Sending Private Message" or "Reading Private Message" messages. Now you have the following:
-- Reading a Private Message
-- Reading a Private Message From You
-- Replying to a Private Message
-- Replying to Your Private Message
-- Sending a Private Message
-- Sending a Private Message to You

As you can see, this is much more useful, yet it still protects the basic privacy of each member. Cool, eh? :D

"Viewing the Results of a Poll" now links you to the results of that poll, and the word "Post" in "Editing Post" is a link to the post being edited.

The word "Attachment in "Viewing Attachmet in Thread Blah Blah Blah" is now a link to the specific attachment being viewed.That's it, basically. I'm using it on my site: http://www.movieforums.net/online.php

It is *HIGHLY* recommended that you use vBHacker (https://vborg.vbsupport.ru/showthread.php?threadid=36378) to install this hack, as it involves 14 code edits in one file (online.php)...automating that can save you a lot of time. :) Attached is an archive containing a vBHacker installation file, as well as a plain text instruction file. Enjoy.

[ZiRu$]

very nice.....does it work on 2.2.4?

[TWTCommish]

I think so. It should work on all 2.2.x versions...I don't think the online.php file has changed much over the last few versions.

[TheComputerGuy]

Thanks for this great Hack

[Velocd]

cool hack, although I personally I'm going to stick with my design, which is pop-up version of who's online (just goto my forums and click on who's online to see it).

good though :D

[Warlord]

Sounds cool.. I'll install it now and get back to you.. :)

[Warlord]

Ok, I get this error after installing it manually....

Fatal error: Call to a member function on a non-object in /home/virtual/site24/fst/var/www/html/vb/online.php on line 172

[Warlord]

ok.. this is wierd. Now the active users page works and I didn't do anything. But it doesn't have all the features you described.... I had someone view and reply to a PM I sent him and it simply said "Reading a Private Message" amd "Using Private Messenger" or something to that effect....

[DWZ]

Sounds like a great hack, will install once I can get vbHacker to work...

[Smoothie]

Originally posted by Warlord
Ok, I get this error after installing it manually....

Fatal error: Call to a member function on a non-object in /home/virtual/site24/fst/var/www/html/vb/online.php on line 172 Same here.

[TWTCommish]

Ok, you can fix the error by replacing this:

global $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $enableemail, $enablepms, $bbtitle, $usergroupdef, $numberguests;

with this:

global $DB_site, $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $enableemail, $enablepms, $bbtitle, $usergroupdef, $numberguests;

Warlord: are you sure you replaced all the bits of code?

[dawl]

works great here ! love it :-)

[ExcErr]

great hack, i think it's very usefull!
but, may be you can add features for Store(lesane hack)?
for example: Buying "Custom avatar" etc.......

[TWTCommish]

I don't know enough about his hack to do that offhand...working on a few other things I should probably focus on, too. :) But I don't think adding a few things like that by hand should be too hard.

[CeleronXL]

vBHacker couldn't find any of those parts of code to change.....

File edits
File edit number 1:
The code needed was not found in the online.php file.

File edit number 2:
The code needed was not found in the online.php file.

File edit number 3:
The code needed was not found in the online.php file.

File edit number 4:
The code needed was not found in the online.php file.

File edit number 5:
The code needed was not found in the online.php file.

File edit number 6:
The code needed was not found in the online.php file.

File edit number 7:
The code needed was not found in the online.php file.

File edit number 8:
The code needed was not found in the online.php file.

File edit number 9:
The code needed was not found in the online.php file.

File edit number 10:
The code needed was not found in the online.php file.

File edit number 11:
The code needed was not found in the online.php file.

File edit number 12:
The code needed was not found in the online.php file.

File edit number 13:
The code needed was not found in the online.php file.

File edit number 14:
The code needed was not found in the online.php file.

[TWTCommish]

That's odd. Can you send me your online.php file?

[-=dm=-]

Hi TWTCommish
thanx for a nice hack :)
is it possible to remove the private calender show up, on "whois online"?
cuz when our members ad some "private" events other member who are on the "whoisonline" are able to see the subject of the events:(
thanx

[TWTCommish]

I didn't add anything to the hack to allow people to view private events, so if vB doesn't display them by default, it should be okay. :)

[-=dm=-]

Hi
it display the subject of the private events, on whois online when user adds a private event.

[TWTCommish]

Does vB do that standard? I think it must...because I certainly didn't add that functionality in.

[-=dm=-]

I have never noticed it before :(
today I installed u r hack and I was longtime on the whoisonline and suddenly I saw a private event title.

[Warlord]

Ok, I have added $DB_site to that string of code and I'm not getting any errors.. I'll have to see if the extras work as people use the different features....

For now, I'm clicking on install ;)

[FleaBag]

Thanks for this hack Chris, installed manually in under 3 minutes on 2.2.5 and working brilliantly! :D

[Boofo]

I get an error in online.php in line 175 (or around there) when someone is writing or sending a private message. If they read it, it seems fine. The error starts on the line that begins with:


$pm = $DB_site->query_first("SELECT fromuserid FROM privatemessag

Any ideas?

[StealthAnime]

good hack, will install it right away :)

[TWTCommish]

Boofo: what error do you get?

[Boofo]

You'd have to ask me that. :) It gives me the error as I load the screen (or refresh it is how I first saw it). I call it the "white page error" where is tells me the line of code and file the error is in. The page won't re-load until they are out of it. I will try to catch it again and let you know.

[Boofo]

TWTCommish,

I finally got the error again tonight (this early AM actually). Here it is:

Fatal error: Call to a member function on a non-object in /home/virtual/site3/fst/var/www/html/forum/online.php on line 175

It happened right after they were "Reading a private message". Actually the message was from me (isn't it supposed to say "Reading your private maeesage"?). then I got the error and the page would not load. After about 5 refreshes, it re-loaded and then I had a box pop up for a new peivate message. The line in the error is the line that I told you about in my previous post about the error. Hope this helps! :)

[TWTCommish]

Ok, you can fix the error by replacing this:

global $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $enableemail, $enablepms, $bbtitle, $usergroupdef, $numberguests;

with this:

global $DB_site, $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $enableemail, $enablepms, $bbtitle, $usergroupdef, $numberguests;

[Boofo]

Ok, done! Will that also fix the problem of it not showing that they are Reading My Private Message (instead of just reading a private message) or just the error part? And are you going to update the install with this or do I need to copy it down somewhere? :)

[TWTCommish]

That should fix both parts; try it and see. :) As for the install; I'll try to get around to updating it soon. Sorry for the delays.

[Boofo]

Oh, by the way, I'm just curious...what did that fix actually do? Does it add another query? (I LOVE learning this stuff!) :)

[inetd]

good hack

[zeedy2k]

Im getting this: Fatal error: Call to a member function on a non-object in /home/httpd/hostchat/html/online.php on line 123 when running the vbhacker file.

Anyone know whats up?? heres whats on that line:
$user = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($userid[1]));

[zeedy2k]

fixed thanks to https://vborg.vbsupport.ru/showthread.php?postid=252446#post252446

Althought whats this?

Unknown Location: /updateindex.php?&fid=6&val=1

[Boofo]

It is still reading "Reading Private Message" instead of "Reading Boofo's Private Message" (or however it is supposed to read. :)

[TWTCommish]

Hmm. Odd. I'll register at your board later today and see if I can figure things out. :)

[Boofo]

The error is gone from what I can tell, though. :)

[Ian]

For the people that installed this hack right when it came out, do we need to change or update anything if it seems to be working fine?

[TWTCommish]

If it's working fine, then no, I guess you won't need to change anything. I think the only way it could work in spite of that bug, however, is if you've installed another hack within that file that made a similar change.

[FleaBag]

I just realised I was having exactly the same problem as Boofo. Though I couldn't find the line of code to fix mentioned... mine was the same but with " $onlineloc; " at the end? So I just added your fix and left $onlineloc; at the end.

[Boofo]

Mine had that on the end, too, probably from another hack. I also left it in. :)

[FWC]

Originally posted by TWTCommish
It is *HIGHLY* recommended that you use vBHacker (https://vborg.vbsupport.ru/showthread.php?threadid=36378) to install this hack, as it involves 14 code edits in one file (online.php)...automating that can save you a lot of time.I went the manual route. I already have so many hacks on WOL I wanted to see what I was changing. As a side benefit I didn't need to do the mod to the global list because it was already there. :cool:

[Boofo]

TWTCommish,

Did you get a chance to check out the board yet? It still seems to be saying the reading private message thing I wrote about a few posts up. And it did the error on not loading the page again on a refresh, but I didn't catch where it happened at this time, sorry. I'll keep an eye on it and see if I can catch it again. Let me know when you have checked it out. Thanks!

[Jeremy W.]

Well done Chris, I love it :D

[Kars10]

hello Guys!!
Ive installed the hack, and all seems to be perfect.
But If someone views the User cp of some other user, and i will klick on the user link in whos online, í get the message "sorry but this user is not registered.
All other links are allright. What can the problem be??
I hope that you understand my bad english. :nervous:

[TWTCommish]

I'm afraid I don't understand. The link titled "User CP" should lead to YOUR User CP...which means you need to be logged in to access it. :)

[Kars10]

Hello Chris, can i send you my code??
Than you can take a look ....
Please

[TWTCommish]

Surely. :) PM or email it over.

[Kars10]

hello Chris, you got Post.
I´ll send it to privacy@...

Thank you very much.

[TWTCommish]

I'm looking at the code now...what did you say the problem was? Which link is giving you trouble?

[Kars10]

...$userinfo[where] = "Schaut sich das Profil an von <a href=\"member.php?s=$session[sessionhash]&action=getinfo&userid=$user[userid]\">$user[username]</a>";


and here is the problem. It looks like: schaut sich das profil an von >>mr.x<<. If i click on mr.x ill get a message that this user are not registered.

[TWTCommish]

I'm not sure what's wrong, but to make sure the link works, replace this:

if ($user[username]) {
with this:

if (intval($user[userid])) {

[Kars10]

Thank you Chris. I will try it. :D

[FleaBag]

Running well on 2.2.6 apart from 1 issue with the profile userid, it doesn't put the number of the member in the hyperlink.

[TWTCommish]

Replace this...
$user = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($userid[1]));
...with this...
$user = $DB_site->query_first("SELECT userid, username FROM user WHERE userid = ".intval($userid[1]));

[FleaBag]

Thanks Chris. Nobody viewing profiles for me to check at the moment, but I'm sure it works! :)

[FleaBag]

It doesn't say the name of the person who's profile they are viewing at all now... I'm gonna check my online.php just to be sure everything is as it should be.

[FleaBag]

Right everything is as it should be, all the file edits are done. Did you deliberately remove that feature Chris? If so wouldn't it be better to have the member name without the link, if it isn't easy to do? I have no idea what I'm talking about by the way. :)

[TWTCommish]

The whole block of code should look like this:

case 'getinfo':
$userid = explode('userid=', $userinfo[location]);
$user = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($userid[1]));

if ($user[username] && $user[userid]) {
$userinfo[where] = "Viewing Profile of <a href=\"member.php?s=$session[sessionhash]&action=getinfo&userid=$user[userid]\">$user[username]</a>";
} else {
$userinfo[where] = "Viewing Profile of a Forum Member";
}

break;
Anyway, you can always test it without anyone else: just view a profile, and make the next page you go to be the Who's Online page. That's how I tested it. :)

[FleaBag]

That test usually works for me, but it doesn't seem to work with profiles. Anyway, it seems to suddenly have started working properly now. So thanks yet again! :)

[xug]

TWTCommish, could you look to this thread :

https://vborg.vbsupport.ru/showthread.php?postid=263760#post263760

I have installed that hack and it screws up online.php a little!

Could you look into this and create a solution so other and I know where the user is instead of showing the sig.php info!!

Thank you for your time!

[Mystislav]

Yo guys I'm getting some gay ass error:

Parse error: parse error, unexpected T_CASE in /home/sjmadho/public_html/board/online.php on line 188

[veedee]

Does this work for every user or can you set this new online.php page to show the extra info *only* for admins?

Cheers,

[Mystislav]

Can anyone help???????

[Boofo]

Can you post just the error line with the 5 lines above it and the 5 below it so we can see what the problem might be?

Originally posted by Mystislav
Can anyone help???????

[TWTCommish]

PM me your online.php file as an attachment and I'll have a look.

[GunsNetwork]

I have a very large online crowd and all I get is a blank screen

I am trying to use this great hack. I have a who is online for all the members to see, but I am trying to get this one to work just for my Admin's so we can see the guests and where they are mostly.

I would appreciate some help, please. I have the files needed for someone to look at.

I am confused with this one, I thought it would be an easy one.

Confused???

BowHunt

[TWTCommish]

I'm sorry, could you describe your problem a little more? What seems to be wrong?

[GunsNetwork]

This is my site is http://www.gunsnet.net

When you go there you will see the who is online on the main index and on each forum.

Here is what I am trying to do, I want a separte WOL for Admin's and Mod's to track the guest's and members so you know what forum they are in without having to go to each forum to find them.

here is my online.php as you will see a blank screen.
http://www.gunsnet.net/forums/online.php


I would appreciate some help on this.

[Tigga]

I've got it working on 2.2.7 for the most part. The only problem is whenever it shows "Viewing Profile of xxx", it doesn't properly link to the user's profile. It just links to /forum/member.php?s=&action=getinfo&userid=. Anyone else having this problem or know how to fix it?

[Bison]

Works OK now ... (Click Install) :D

Change the $user variable to this dude....

$user = $DB_site->query_first("SELECT userid, username FROM user WHERE userid = ".intval($userid[1]));


That was my problem too, but it works now! ;)

[Learner29]

looks interesting.....

[Kohhal]

Great hack Chris, exactly what I was looking for :D

I have one related problem maybe you can help me with, as detailed in this thread (https://vborg.vbsupport.ru/showthread.php?s=&threadid=44640).

Thanks,

G!

[FleaBag]

Installed on 2.2.8 in about 4 seconds! :D

[GunsNetwork]

Chris I get this message after redoing my online.php file.

Parse error: parse error, unexpected T_CASE in C:\Web\WebSites\GunsNet\Forums\online.php on line 135

I will send you my online php file

BowHunt

[Natch]

Has anyone else noticed that upgrading to 2.2.9 breaks the Who's Online for Viewing (this members) Profile ?

EDIT: // as in it was working fine afaik before the upgrade but now I seem to have the following error whenever I try to view a Profile and then look @ Who's Online ...

Fatal error: Call to a member function on a non-object in /my/home/directory/forums/online.php on line 122

Line 122 is from this hack and comprises case 'getinfo':
$userid = explode('userid=', $userinfo[location]);
/*122 */ $user = $DB_site->query_first("SELECT userid, username FROM user WHERE userid = ".intval($userid[1]));

if ($user[username] && $user[userid]) {
$userinfo[where] = "Viewing Profile of <a href=\"member.php?s=$session[sessionhash]&action=getinfo&userid=$user[userid]\">$user[username]</a>";
} else {
$userinfo[where] = "Viewing Profile of a Forum Member";
}

break;

Any ideas what's wrong ?

//EDIT: Apart from me not reading thru the thread properly LOL :( Sorry!

Great hack and thanks :D :D

[Slynderdale]

Some bug fixes:

find:

function show($userinfo) {
global $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $displayemails, $enablepms, $bbtitle, $usergroupdef, $numberguests;


If it doesnt have $DB_site in global then add it such as:

function show($userinfo) {
global $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $displayemails, $enablepms, $bbtitle, $usergroupdef, $numberguests,$DB_site;


then find:

case 'mail':
$user = explode('userid=', $userinfo[location]);
if (intval($user[1])) {
$user = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($user[1]));


and change it to:

case 'mail':
$user = explode('userid=', $userinfo[location]);
if (intval($user[1])) {
$user = $DB_site->query_first("SELECT username,userid FROM user WHERE userid = ".intval($user[1]));


now find:

case 'getinfo':
$userid = explode('userid=', $userinfo[location]);
$user = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($userid[1]));


and change it to:

case 'getinfo':
$userid = explode('userid=', $userinfo[location]);
$user = $DB_site->query_first("SELECT username,userid FROM user WHERE userid = ".intval($userid[1]));



Now every thing should work correctly.
Im also using vbulletin 2.2.9

[Boofo]

Does it make a difference what order the username and userid is on on the query statement? I have the following query in my online.php:

$user = $DB_site->query_first("SELECT userid, username FROM user WHERE userid = ".intval($userid[1]));

[Slynderdale]

Originally posted by Boofo
Does it make a difference what order the username and userid is on on the query statement? I have the following query in my online.php:

$user = $DB_site->query_first("SELECT userid, username FROM user WHERE userid = ".intval($userid[1]));

no it doesnt make a difference, i installed this hack on a vbulletin 2.2.9 and when i went to whos online i got quite a bit of errors that as i read through the thread, many others had encountered so i posted the changes i made to fix the errors i was getting.

[Boofo]

Yeah, I found out about the missing $DB_site in global totally by accident when I suddenly got a fatal error one time. I had been using the hack with no problems for about 2 months then all of a sudden, I got the error. There were two of us that were in the 2 spots to trigger it only that one time. It had never happened up until then. :)

[Herman]

I had the same problem as that other guy.

File edit number 1:
The code needed was not found in the online.php file.
File edit number 2:
The code needed was not found in the online.php file.
File edit number 3:
The code needed was not found in the online.php file.
File edit number 4:
The code needed was not found in the online.php file.
File edit number 5:
The code needed was not found in the online.php file.
File edit number 6:
The code needed was not found in the online.php file.
File edit number 7:
The code needed was not found in the online.php file.

File edit number 8:
The code needed was not found in the online.php file.

File edit number 9:
The code needed was not found in the online.php file.

File edit number 10:
The code needed was not found in the online.php file.

File edit number 11:
The code needed was not found in the online.php file.

File edit number 12:
The code needed was not found in the online.php file.

File edit number 13:
The code needed was not found in the online.php file.

File edit number 14:
The code needed was not found in the online.php file.

[cirisme]

I love this hack. :)

[Elentari]

Works like a dream with Slynderdales fixes :D Thanks!!

[FleaBag]

I was getting the same problem with viewing a profile and then the online.php file. I'll apply the fixes right away - thanks!

[Alien]

This working with 2.3.0 (with fixes) now too?

-Jason

[Intex]

Installed and works without any problems. Thx for the hack.

/me clicks install.

[kirupa]

Thanks! This hack is really great. After incorporating all the fixes that members posted, the Who's Online feature works like a charm :)

[desmondw]

Does this work for 2.3.0 ? Looks to be an awesome hack!

[Kriek]

Flawless via 2.3.0

/me clicks install

[Oblivion Knight]

This doesn't appear to be working correctly with 2.3.2.. :(
Even after applying the fixes by Slynderdale; Viewing profiles, pm's and such returns "Viewing Profile of a Forum Member" instead of stating who's profile a person is viewing..

[aquariumpros]

Some bug fixes:

find:

function show($userinfo) {
global $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $displayemails, $enablepms, $bbtitle, $usergroupdef, $numberguests;


If it doesnt have $DB_site in global then add it such as:

function show($userinfo) {
global $thread, $post, $forum, $event, $gotforum, $hideprivateforums, $bbuserinfo, $timeformat, $displayemails, $enablepms, $bbtitle, $usergroupdef, $numberguests,$DB_site;


then find:

case 'mail':
$user = explode('userid=', $userinfo[location]);
if (intval($user[1])) {
$user = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($user[1]));


and change it to:

case 'mail':
$user = explode('userid=', $userinfo[location]);
if (intval($user[1])) {
$user = $DB_site->query_first("SELECT username,userid FROM user WHERE userid = ".intval($user[1]));


now find:

case 'getinfo':
$userid = explode('userid=', $userinfo[location]);
$user = $DB_site->query_first("SELECT username FROM user WHERE userid = ".intval($userid[1]));


and change it to:

case 'getinfo':
$userid = explode('userid=', $userinfo[location]);
$user = $DB_site->query_first("SELECT username,userid FROM user WHERE userid = ".intval($userid[1]));



Now every thing should work correctly.
Im also using vbulletin 2.2.9
Great hack...

Thanks to TWTCommish for this - and to Slynderdale for the version 2.2.9 fix!!

:)

[walkingthepath]

TWTCommish: Have you updated the original attachment with all the bug fixes, or do I need to DL the original, and modify to fix all the bugs?? THX...

[NeveAddict]

Working great with VB 2.3.2
Thnx!

*clicks install*