Quick PM Reply Box

[Erwin]

Quick PM Reply Hack Version 2.4 - by Dr. Erwin Loh
-------------------------------------------------------------------

Inspired by Firefly, Neo, Vincent "MW" Chan


Version 2.4 for vBulletin 2.3.0 - 23rd of March 2003
-----------------------------------------------------------------

This is a simple hack that puts a "Quick PM Reply" box underneath a PM that you have received, with the username, subject and message in quotes already inserted. All you need to do is to just type the reply and click send. In the new version, you also have the option of deleting the original PM when you send the reply, as well as multiple options like saving the copy, and message tracking.

Upgrading from version 1.x - just make the 2nd PHP file changes, and copy and paste the the new template changes over the old one.


Version 2 additions:
--------------------------

Added options using checkboxes to:

1) Delete original: Delete original PM from PM box when you send reply
2) Automatically parse URLs.
3) Show Signature.
4) Save a copy: Also save a copy in the 'Sent Items' folder.
5) Request Read Receipt: Choose message tracking.

Version 2.1 - minor bug fix to make the icon change after a message is sent.
Version 2.2 - minor bug fix to make sure the delete tickbox works.
Version 2.3 - fixed a minor template issue
Version 2.4 - fixed the multiple RE: bug

NEW: Added minor addition to make cursor go automatically to the PM Quick Reply Box. :)

NOTE: To get the newest attachment, you need to clear your browser cache - otherwise you may download the previous version text file.

[Erwin]

This is a screenshot of what it would look like - this Quick PM Reply box will be located under the PM message that you have received and are reading.

The username, and subject will be automatically added. The PM message that you are reading will automatically be included in the textarea in quotes.

New version screenshot - you can now see the checkboxes that you can tick to automatically delete the original PM when you send the reply, or to enable URL, signature, save to sent folder or message tracking.

EDIT: This hack has been installed in vB.org. Just try it out here. :)

Screenshot:

[afterlab]

Good job, although I doubt i'll use it.

[Xanthine]

Same but good idea.

[BigJohnson]

nice hack

[MrLister]

good job

[Corbu]

very nice ! Thank you !

[Logician]

Good idea, nice job, it's great! :glasses:

[Floris]

We are looking into it!
When we might apply the Quick Reply Hack in the upcomming month(s), we will take this one under consideration too!

[John]

A fine hack :)

[John]

It'd be nice if it followed proper colour formatting though

[lordnet]

nice hack Erwin

thanks :)

LORD

[Erwin]

Originally posted by JohnWarwick
It'd be nice if it followed proper colour formatting though

For some reason vbulletin.org changed all my firstaltcolor and secondaltcolor variables to the ones that they use on this site.

I have updated the install text file with the generic variables - although I have uploaded the new file up, when I try to download it, the cache still shows the previous file.

Try to clear your cache and download the text file again. Make sure the file you download is quickpmreply2.txt (not quickpmreply.txt)

The color formatting should automatically reflect your own forum's style.

[TheCaver]

Thanks for the hack.

One minor issue, you have an extra <TR> in there.....near the top....

And a weird double border on the right hand side, which I haven't looked at just yet.....

I'll post the cleaned up HTML unless someone beats me to it.....wink wink.... :)

JC

[Erwin]

Thanks - I've removed the extra <tr> tag - no idea how it got there! :)

[kmistry]

thanks alot erwin, nice hack.

[freeshares1]

Erwin,

Great hack simple and takes about 2 mins to install.

phil

[Erwin]

Thanks for the compliments. :)

Btw, you can use this hack easily as a quick forwarding function as well - I have made it so that you can change the username of the recipient easily so that instead of a quick reply, you can do a quick forward too.

[David Bott]

Hummm...Bug? Every time I use the quick reply to send a PM I get a JavaScript error saying something along the lines of "Validate is not an object", in both IE6 and Netscape 4.x. I looked at the code and the problem is that the <form> tag has a line that reads...

onSubmit="return validate(this)"

but there isn't a function anywhere called validate.

If this line is unintentional, then I think simply removing it will get rid of the problem. If it's suppose to do something I would like to know what.

PLEASE ADVISE

[pHAZE_1]

great hack, thanks.. 1 question though why is the border so thick? its not a prob, im just curious

[Erwin]

I think that's meant to validate the length of the text box, but don't quote me on that. The function may be located elsewhere. I'm not getting any script errors for mine - it works fine, and no one else seem to have that problem... I'm at work at the moment, but I will check it out when I get home. Make sure you have script switched on in your browser - check your browser security settings.

[David Bott]

Sorry...this is an issue (thought not forum or hack stopping) for their is NO SCRIPT to call in the file that was modified. "validate(this)" is no where in the PM code thus the error is their and will be as mentioned above. It is not just me...it was reported by my users. (we see over 30,000 unique visitors a day.)

You could be right on the reason seeing the code was taken from the other Quick Reply hack.

[Erwin]

You missed out on the whole Javascript function that should be placed above the form tags. It is in the installation text file.

Please look at the installation text file again, and make sure you place the Javascript function before the form tags.

[Erwin]

I checked - for some reason the Javascript function was missing in the 2nd version of the installation text file.

I have fixed this now - sorry to those who installed the 2nd version. For those who have installed this already, just copy the Javascript function and paste it ABOVE the form tags. It should work fine now.

[Boofo]

It works great, thanks! The wife loves it! (You done good :)). I still have the double white line on the right. What do I need to take out and where? I just downloaded the file about 20 minutes ago.

[Erwin]

Mmm... it's to do with the table alignments... I did it and it works for my forums, but obviously not aligning correctly with others.

Try to play around with the tables in your templates, and see if you can make it look better. :)

[Boofo]

If I could do that then I wouldn't have bothered you with it. :) Can you make it like the Quick reply Box as far as the box itself goes? I noticed you have a border around the inside of the box, too. Is that supposed to be there?

[Boofo]

Is there any way to have it save a copy (to your sent folder) of the message you are replying to or forwarding (if you have it set to save a copy), when you use the quick pm reply box?

[Erwin]

Boofo:

Change this line:


<input type="hidden" name="savecopy" value="no">


to this:


<input type="hidden" name="savecopy" value="yes">



As for the table alignment, I will try to find time to fix it up for you - if you have a web editor, just plug the tables in there and change it to however you want it to look. :)

[Boofo]

I guess if I would have looked closer, I would have found that. :) Thanks! As far as table alignment goes, thanks and let me know when you have some time. :)

[Boofo]

Just found something interesting. If the message contains a quote box inside of a quote box, the whole message is not transferred to the Quick PM reply Box. It stops after the first [/quote], so there are two [quote] and one that ends it. :)

[Erwin]

I sent you a PM, Boofo, regarding the table alignment change. See if it works better.

[moosey]

very nice idea mate.. like it

cheers for your work

[Boofo]

Erwin,

After taking the box apart and reassembling it, I finally got it worked out. I just followed Firefly's Quick Reply Box hack and the box looks like it should now. Thanks for all of the help. If you want my code for the box, let me know. I added a few things to it that make it much easier to use, like the Verify User accepts PMs hack and the Find User Name feature along with a drop down box for the message icons.

By the way, how did you get the Automatic smilies and Fonts in the left side of your box? Can you post the code for that here? :)

[ZiRu$]

thanks I'll install it.....

[Erwin]

It's just a link to the "Reply PM" page. It's for my members who like using the automatic smilies etc.

[Boofo]

Great idea...would you mind sharing the code to put it in? :)

[JZarate]

thanks, works great!

[Erwin]

Originally posted by Boofo
Great idea...would you mind sharing the code to put it in? :)

It's just the URL to the private message reply page - here it is:


<smallfont><a href="private.php?s=$session[sessionhash]&action=newmessage">Click here for<br>
<b>Automatic Smilies</b><br>
and <b>Font Effects!</b><br>
</a></smallfont>

[Boofo]

Thanks. I guess I should have known that. DOH!!!

Is there any way to have it put the message recipient, subject and the quote into the reply (the regular one) after clicking on that link? That would be great to have it be able to transfer that information if a user wanted to do that. :)

[Jawelin]

Very very nice hack.

Something I always lack in the PM page was the 'delete original
on reply' flag.
Is it possible to add a checkbox to automatically delete the incoming message when submitting the quick-reply ?

Thank you very much
Bye

[Erwin]

I'll work on it - that shouldn't be too hard to do.

[Erwin]

Mmm... a simple template edit won't do that. The 2 action variables are different. One is dosend, the other is dodelete - this will take further hacking of private.php to combine the 2 variables.

[Jawelin]

Originally posted by Erwin
Mmm... a simple template edit won't do that. The 2 action variables are different. One is dosend, the other is dodelete - this will take further hacking of private.php to combine the 2 variables.

Yes, of course.
I asked to you as the original author of the hack... :D

I definetively think the following code :

$privatemessageid=verifyid("privatemessage",$privatemessageid);
$DB_site->query("DELETE FROM privatemessage
WHERE privatemessageid=$privatemessageid
AND userid=$bbuserinfo[userid]");

should be added somewhere in the "dosend" section of private.php, managed in an if-clause by a check-box variable in privmsg template...

I think this php mod should make it better called 'hack' ... instead of a template modification, with the addition of more than a row to the script...

:knockedout:

Thanks again.

[Jawelin]

Just an addon.
What will be the behavior of this quick reply about the message tracking and the outbox ?
I mean, are they managed as defaults or not ?

What about adding, beside 'delete' option, even the checkboxes for :
- Signature
- Save a copy
- Message tracking
(defaulted, as in QuickReplyBox hack, upon the user's preferences) ???

Thanks

[freakyshiat]

Originally posted by TheCaver

And a weird double border on the right hand side, which I haven't looked at just yet.....
JC
i am gettin that too, do u know what it is?

[Jawelin]

Originally posted by Fazle

i am gettin that too, do u know what it is?
Wrong colspan number; set it to '6' instead '5' ...
Bye

[Erwin]

Okay, Jawelin, I'll do it just for you... hang on while I add those things you suggested...

[Erwin]

Okay, the hack is updated.

Version 2 additions:
--------------------------

Added options using checkboxes to:

1) Delete original: Delete original PM from PM box when you send reply
2) Automatically parse URLs.
3) Show Signature.
4) Save a copy: Also save a copy in the 'Sent Items' folder.
5) Request Read Receipt: Choose message tracking.

Also fixed up the colspan issue, colors etc.

Refer to the 1st post for the updated text file, and the 2nd post for the updated screenshot.

[Boofo]

I ran into a problem. I had two instances of the specialcharacters line in private.php. If I put the code after one of them, I got an error if I chose to delete the message after sending. It said I didn't specify a message. If I put it under the other one, I didn't get the error, but the message was not deleted. Also, in your oicture (2nd post), There is a preview button under the box. I don't have that on mine. Would there be any way to add that? :)

Originally posted by Erwin
Okay, the hack is updated.


Version 2 additions:
--------------------------

Added options using checkboxes to:

1) Delete original: Delete original PM from PM box when you send reply
2) Automatically parse URLs.
3) Show Signature.
4) Save a copy: Also save a copy in the 'Sent Items' folder.
5) Request Read Receipt: Choose message tracking.

Also fixed up the colspan issue, colors etc.

Refer to the 1st post for the updated text file, and the 2nd post for the updated screenshot.

[Erwin]

Mmm...

Let me look into it now...

[Erwin]

It works fine on my forums... but my private.php is very modified...

[Boofo]

I can pm you my file if you need to look at it.

Originally posted by Erwin
It works fine on my forums... but my private.php is very modified...

[Boofo]

There was a similar problem with the Quick reply Box that would give you a forum specification error (errorid). Could that also be what is going on here? :)

[Erwin]

Okay, I've updated the text file.

Clear your browser cache (delete all files in your browser's temporary folder), and download the new text file.

The difference:

Find this code in private.php


if ($HTTP_POST_VARS['action']=="dosend") {


Underneath, add this:


if ($deleteorig=="yes") {
$privatemessageid=verifyid("privatemessage",$privatemessageid);
$DB_site->query("DELETE FROM privatemessage WHERE privatemessageid=$privatemessageid AND userid=$bbuserinfo[userid]");
}


You need to make sure you copy the WHOLE new template across as well. Not just the new checkboxes. This is because I have added this new line in the template HTML code:


<input type="hidden" name="privatemessageid" value="$privatemessageid">


You need this for the delete function to work.

This needs to be in between the form tags. Just use the WHOLE of the new template and replace the whole of your old one.

It should work now. :)

[Boofo]

That didn't chnage anything here. I still get the same error message when trying to delete a message when sending the reply. :)

[Erwin]

Did you copy the whole template across and replace the old template changes? Did you make sure you have the privatemessageid variable as hidden included?

Make sure you have this:


<input type="hidden" name="privatemessageid" value="$privatemessageid">


in your privatemsg template in the quick pm reply box form - use the template that I provided.

It does work - trust me. :) You just need to give the delete function the private message id.

[Boofo]

You caught me. No, I didn't copy the whole template. The reason is because the template didn't match vBulletins setup all the way and I had to play with it quite a while last time to get it to look right. If you want the code for my fixed box, let me know and I'll PM it to you. What happened was, in the first version of the quick pm reply box, that line you wanted me to add this time said <input type="hidden" name="previewmessageid" value="$privatemessageid"> instead of what it is now. Once I took that old line out and put the new one ine, then it worked fine. As you can see they look very close when you're going through the code. :) It works great here. Thanks!

BTW you had a preview button in your picture in the second post. Any way we can add that to this? :) Thanks again and sorry for the misunderstanding. (we don't need the old preview message id code in there right?)

Originally posted by Erwin
Did you copy the whole template across and replace the old template changes? Did you make sure you have the privatemessageid variable as hidden included?

Make sure you have this:


<input type="hidden" name="privatemessageid" value="$privatemessageid">


in your privatemsg template in the quick pm reply box form - use the template that I provided.

It does work - trust me. :) You just need to give the delete function the private message id.

[Erwin]

The previewmessageid is for the preview message - different kettle of fish.

The Preview PM hack is located here - just do a search for it. It works well with my hack too.

Glad to know the hack is working! :)

[Jawelin]

Originally posted by Erwin
Okay, Jawelin, I'll do it just for you... hang on while I add those things you suggested...
Thank you very much for this dedication... :D
I'll apply it to my files... Thanks again.

[Boofo]

That preview part I took out was in the same part where you had me add that second code. Wasn't that from the first release of your hack here? I already have the preview private message hack installed but I couldn't find one for the preview Quick PM reply.

Originally posted by Erwin
The previewmessageid is for the preview message - different kettle of fish.

The Preview PM hack is located here - just do a search for it. It works well with my hack too.

Glad to know the hack is working! :)

[Erwin]

Oh.... if you already have the Preview PM hack installed, then all you have to do to make that work with my hack is this:

In your privmsg template:

Find this:


<form action="private.php" method="post" enctype="multipart/form-data" name="vbform" onSubmit="return validate(this)">


Add this underneath:


<input type="hidden" name="prevmessageid" value="$privatemessageid">


Then find this:


<input type="submit" class="bginput" name="submit" value="Send Message" accesskey="s" tabindex="4">


Add this underneath:


<input type="submit" class="bginput" name="preview" value="Preview Message" accesskey="p" tabindex="4">


The preview function should work immediately. From what I can remember anyway.

[Erwin]

Remember, the above variables are to be between the form tags for my hack, not in the original privmsg template.

[Boofo]

Ok, that worked, I think. When it goes to preview the message, it throws it to the regular preview message, right? So you are no longer in the Quick PM reply message?

Originally posted by Erwin
Remember, the above variables are to be between the form tags for my hack, not in the original privmsg template.

[X-Fan]

Great hack! Works perfectly, and it's a real time-saver. Thanks Erwin!

[Erwin]

Originally posted by Boofo
Ok, that worked, I think. When it goes to preview the message, it throws it to the regular preview message, right? So you are no longer in the Quick PM reply message?



Yes. :)

[Boofo]

Great, thanks! BTW: Do you know why the me vbcode hack (by Firefly) doesn't work in the quote of a private message? If you quote that from someone in a private message, it still says /me and puts in my name in the reply. Any ideas on this one? :)

Originally posted by Erwin


Yes. :)

[Erwin]

To be honest, it should work, as long as you installed the private.php part of the /me hack.

[Boofo]

I just double checked everything and it is all there like it is supposed to be. I don't know why it is not working now in the private messages. :)

Originally posted by Erwin
To be honest, it should work, as long as you installed the private.php part of the /me hack.

[kmistry]

hey, i just downloaded 2.2.6 and i thought i might as well get the new pm reply while im at it. just wondering that thick border at the bottom, how do i get rid of it!

thx.

[Erwin]

Just experiment around with the table HTML code for the Quick PM Reply Box - I don't have a bottom border using the same code for my forums. Every forum has a different layout - modify the hack to make it suit yours. :)

[Bro_Joey_Gowdy]

Nice hack Erwin

:)

[Erwin]

Hi Joey, long time no see...

[Boofo]

Erwin,

Chen helped me start to get the /me vbcode hack working with regular private messages. I noticed that when I reply to a message with the quick pm reply box, it shows it as /me still. Is there a way to make it so it shows the person's name instead of /me in the quick pm box?

[Heineken77]

Hey :)

I was wondering, is it possible to remove extra quotes in the quick reply PM box as it was done in this hack (https://vborg.vbsupport.ru/showthread.php?s=&threadid=41074) for replying to PMs manually?

Also, remove the extra Re: Re: Re: ? :(

That would be sweet!
Sincerely,
Heineken

[Boofo]

Erwin,

Are you still supporting this?

[Erwin]

Boofo: I am still supporting it. :)

Heineken:

To remove the extra quotes, just install that hack. It works - I've tried it.

To remove the extra RE: RE: - that's easy - just go to your "privmsg" template (after you have installed the hack) and find:


value="RE: $message[title]"


And replace with:


value="$message[title]"


There you go!

[Erwin]

Originally posted by Boofo
Erwin,

Chen helped me start to get the /me vbcode hack working with regular private messages. I noticed that when I reply to a message with the quick pm reply box, it shows it as /me still. Is there a way to make it so it shows the person's name instead of /me in the quick pm box?

To be honest, Boofo, the /me code works for me using the Quick PM reply box with no problems - both in the Reply and in the Quoted area. That's why I didn't answer you - it works. If it doesn't, it's not this hack, it must be the way /me was installed on your site.

[Boofo]

I'm sorry, I guess i didn't explain it right. :)

It worksd fine for me except when it is quoted from someone else. Then it still shows the /me code instead of that person's name in the quote.

Originally posted by Erwin


To be honest, Boofo, the /me code works for me using the Quick PM reply box with no problems - both in the Reply and in the Quoted area. That's why I didn't answer you - it works. If it doesn't, it's not this hack, it must be the way /me was installed on your site.

[Boofo]

I must be doing something wrong then, because I have that hack installed and I still get more than the last quote if there is more than one (but only in the Quick Reply PM Box, the regular reply box works as it should).

The RE: RE: fix is working fine now. Thanks, Erwin. :)

Now, all we have to do is figure out the quote problem, for now, anyway. :) Is anyone else having the quote problem in the Quick PM Reply Box after the hack install?

Originally posted by Erwin
Heineken:

To remove the extra quotes, just install that hack. It works - I've tried it.

To remove the extra RE: RE: - that's easy - just go to your "privmsg" template (after you have installed the hack) and find:


value="RE: $message[title]"


And replace with:


value="$message[title]"


There you go!

[MalaK_3araby]

Thanks Erwin.

* Installed *

[Erwin]

Originally posted by Boofo
I'm sorry, I guess i didn't explain it right. :)

It worksd fine for me except when it is quoted from someone else. Then it still shows the /me code instead of that person's name in the quote.



Like I said, the /me code works for me in both the reply and the quoted section. If it doesn't work for you, then you didn't install the /me code or my hack properly. I didn't do anything extra for it to work.

[Erwin]

Originally posted by Boofo
I must be doing something wrong then, because I have that hack installed and I still get more than the last quote if there is more than one (but only in the Quick Reply PM Box, the regular reply box works as it should).

The RE: RE: fix is working fine now. Thanks, Erwin. :)

Now, all we have to do is figure out the quote problem, for now, anyway. :) Is anyone else having the quote problem in the Quick PM Reply Box after the hack install?



That's weird, because I installed the "remove quote hack" and it fixed up my quote problems. Did you install that hack properly - you need to place the variables in the right spot.

[Virix]

The Re: problem is because your hack just keeps adding Re: to the title, it does not strip the old one out:


In template privmsg:

Find:
<input type="text" class="bginput" name="title" value="RE: $message[title]" size="40" maxlength="85" tabindex="2">


Replace with:
<input type="text" class="bginput" name="title" value="$quicktitle" size="40" maxlength="85" tabindex="2">



In file private.php:

Find:
$touserinfo = getuserinfo($message[touserid]);


Under that add:

if (strtolower(substr($message[title],0,3))=="re:") {
$quicktitle=trim(substr($message[title],3));
}else{
$quicktitle=$message[title];
}

$quicktitle="Re: $quicktitle";


I got several complaints abou the Re:'s so I went though and fix it..

Hope this is what you want....

[Boofo]

How can you install it wrong? Herer is that section of code to prove it.

$message['message'] = preg_replace('#^/me(.*)$#im', "* $fromuserinfo[username]\\1",
$message['message']);
$message['message'] = trim(preg_replace('~\[quote\](.*)\[/quote\]~si', '', $message['message']));
eval("\$message[message] = \"".gettemplate("priv_reply",1,0)."\";");
} else {
$message = array();
}

Originally posted by Erwin


That's weird, because I installed the "remove quote hack" and it fixed up my quote problems. Did you install that hack properly - you need to place the variables in the right spot.

[Erwin]

There is no need to do anything to the private.php file for the /me hack to work with my hack. Nothing at all. Just remove all those things from the private.php if they are there. (Trust me, the /me code works for me.)

[Boofo]

But we need the code above to make it work in the Regular Reply for private messages, don't we? :)

[Erwin]

Like I said, it all works - just install the /me hack as normal, and then my hack as normal, no need to do anything else.

[Boofo]

Whatever. The reason I put the code in above is I couldn't get it to work in private messages (Quick reply or regular) until Firefly gave me that code to put in there. Then it started working in the regular replies. I don't use the Quick PM Reply Box much anyway, so UNINSTALL. The support isn't that good anyway. Anyone can say "I don't know, works good for me".

Originally posted by Erwin
Like I said, it all works - just install the /me hack as normal, and then my hack as normal, no need to do anything else.

[Erwin]

Originally posted by Boofo
Whatever. The reason I put the code in above is I couldn't get it to work in private messages (Quick reply or regular) until Firefly gave me that code to put in there. Then it started working in the regular replies. I don't use the Quick PM Reply Box much anyway, so UNINSTALL. The support isn't that good anyway. Anyone can say "I don't know, works good for me".



You haven't given me anything to work with. Your problem could be caused by a million things - another hack interfering with this one etc. I support this hack - I cannot be expected to support Firefly's hack to make it compatible with this one. Like I said, it IS compatible. You posted a piece of code but don't tell me where it is. It's not in my private.php. Where is that code from? What do you expect me to do? I don't have access to your PHP files or your templates?

Also, I work full-time as well - I posted this hack up as a gesture of thanks for the multiple hacks I have taken from here. Don't expect 24 hour instant support. :)

[Erwin]

Just for you, Boofo, I'll make an exception. PM me your private.php file, and your privmsg template as attachments, and I will fix it and PM them back to you. It's going to be interference from another hack. I had the /me hack running for a while, before I did up this hack, and they both work fine. Anyone else with this problem?

[Boofo]

I've given you as much to work with as I have available. I DID fix the quote problem though. I replaced the code for your hack in private.php with the following:

// Start of Quick PM Reply by Erwin
$pmquote = trim(preg_replace('~\[quote\](.*)\[/quote\]~si', '', $message['message']));
// End of Quick PM Reply by Erwin

and now there is only one quote in the quick pm box. As far as the RE fix, I followed Virix's code above and took care of that problem. I'll pm you the files if you still want to look at the me code problem.

Originally posted by Erwin


You haven't given me anything to work with. Your problem could be caused by a million things - another hack interfering with this one etc. I support this hack - I cannot be expected to support Firefly's hack to make it compatible with this one. Like I said, it IS compatible. You posted a piece of code but don't tell me where it is. It's not in my private.php. Where is that code from? What do you expect me to do? I don't have access to your PHP files or your templates?

Also, I work full-time as well - I posted this hack up as a gesture of thanks for the multiple hacks I have taken from here. Don't expect 24 hour instant support. :)

[Erwin]

The quote hack would fix my hack without needing to change any of the code in my hack, but anyway...

I have PMed you a modified copy of your private.php - it should fix the /me hack (I hope) - but I did take out that quote hack thing in the meantime.

If all goes well, both your /me hack and quote hack should work automatically. Like I said, my hack does NOT interfere with these hacks since it just copies the data that has already been changed - if not, you may need to move the $pmquote line after the message has been parsed into vBCode, but BEFORE it has been parsed into HTML.

Anyway, try out the private.php that I modified for you.

[Erwin]

Also, may I add, Boofo, that your private.php actually has MORE hacks than mine - :) - there is a high chance of conflict between them. I had to rationalize your $message[message] variables - you had multiple copies of these with different values.

[Boofo]

Well, I just tried it with the file you sent me. Now I have no subject line when I am replying with the quick reply box and the quotes are back again if there are multiple of them. :)

[Boofo]

This is what I mean with the me code. This is what shows up in the Quick PM Reply Box when I look at a message from anyone who has used this code. Instead of seeing their name in place of the me, I see this. For some reason it isn't being parsed like it is in the pm regular reply box

/me like this


and this is how it shows up in the regular pm reply box:


* Boofo like this

[Erwin]

Okay, I know it's not the private.php file, because your private.php file looks a bit more like mine now (I did an Araxis Merge compare) - you are just missing something essential that I have in another file that you don't. Let me look at it again. I'm going to work, and can only do this tonight. Please be patient.

[Boofo]

Thanks for taking the trouble and the time on this. I really appreciate it. No hurry, just when you get some time. Thanks again. :)

Originally posted by Erwin
Okay, I know it's not the private.php file, because your private.php file looks a bit more like mine now (I did an Araxis Merge compare) - you are just missing something essential that I have in another file that you don't. Let me look at it again. I'm going to work, and can only do this tonight. Please be patient.

[Erwin]

Boofo, did you install this bug fix? Make sure you do.

https://vborg.vbsupport.ru/showthread.php?s=&threadid=35894

I cannot find the reason why /me would not work for you. I looked at your private.php at length - no idea.

Sorry.

Also, I don't know why the quote hack would not work for you too.

For other members: both the /me hack and quote hack works for me. Do they work for you? Anyway, I am not responsible for this hack being compatible with other hacks - there are hundreds of hacks out there - I don't have time to figure it out for each individual.

[Boofo]

Yes, I installed that bug fix a long time ago before I installed the me hack. You said something about moving the quote hack in the file, too.

Right now, I am using the original private.php I sent you and the quote and RE hack work fine. I have an idea on the me hack, too. If it works, I'll let you know.

Originally posted by Erwin
Boofo, did you install this bug fix? Make sure you do.

https://vborg.vbsupport.ru/showthread.php?s=&threadid=35894

I cannot find the reason why /me would not work for you. I looked at your private.php at length - no idea.

Sorry.

Also, I don't know why the quote hack would not work for you too.

For other members: both the /me hack and quote hack works for me. Do they work for you? Anyway, I am not responsible for this hack being compatible with other hacks - there are hundreds of hacks out there - I don't have time to figure it out for each individual.

[Vile]

Awesome hack, worked like a charm:)

[2 X Viverridae]

Great hack - installed with no problems whatsoever.

Thanks a lot!

[threadcrapper]

I hit the install button on this one -- the users love it -- went in like a charm!

[Erwin]

Glad you like it. :)

[ULTIMATESSJ]

great hack

/me clicks on install

[Buddha]

installed.
thanks.

[yzztik]

I have a quick question ... when you reply to a PM with the quick reply box, it does not change icon next to the message saying it has been replied to. Any idea what code I can change/add to get it to do that? Thanks!

[Erwin]

Originally posted by yzztik
I have a quick question ... when you reply to a PM with the quick reply box, it does not change icon next to the message saying it has been replied to. Any idea what code I can change/add to get it to do that? Thanks!

It works.

The quick PM reply box uses the SAME code as the normal PM reply page. The icon automatically changes when you use the Quick PM Reply Box. I just tested it on my forum and it definitely works. So something is wrong with your private.php or you haven't installed the hack properly.

[yzztik]

Hmm ... thats not good :p Any idea of where I should start looking for what might be wrong? Can you maybe post the part of that page that controls this and see if I can find the error? :S I have seen this behavior at another board too so its not just mine. I wonder if there is an extra step I missed somewhere :S

[Erwin]

Originally posted by yzztik
Hmm ... thats not good :p Any idea of where I should start looking for what might be wrong? Can you maybe post the part of that page that controls this and see if I can find the error? :S I have seen this behavior at another board too so its not just mine. I wonder if there is an extra step I missed somewhere :S

Mmm... considering the code additions to private.php are:

1) 1 line for the copying of the PM message before it's parsed into HTML so that we can display the quote

2) 3-4 lines of an "if" section to delete the old PM if the delete box is ticked

Everything else uses the normal PM reply function in privatep.php so the only reason why it is not working for you is if you have accidentally deleted the section of code that changes the icon... my hack doesn't even go near it.

[yzztik]

Ok fair enough, I'll sift through it and see if I can find the error ... but if i had accidently deleted that part of the code, wouldnt it not work at all even when using the regular PM reply instead of the quick PM box? Cuz it works then ... thats whats so odd.

[Erwin]

Is this happening to anyone else using this hack? Or is this an isolated problem? Because this problem doesn't occur with my forums.

[yzztik]

Well, I know that it happens for sure in one other board that I frequent and I did not install that one though we have similar hacks *shrug*

I am curious to know if anyone else is having the problem ...

[JoergZ]

Great Hack Erwin ! :)

But I must say, I have the same error, that after a reply with the Quick-Box the icon of the original PM is not changed.

(vB Vers. 2.2.6)


J?rg



P.S. I found the error why the icon was not correct (the field "messageread" was not updated correct.

In the template modification of your hack the wrong line is:

<input type="hidden" name="privatemessageid" value="$privatemessageid">

It must be

<input type="hidden" name="prevmessageid" value="$privatemessageid">

After that change it works correct.


J?rg

[Erwin]

Ahhh... thanks Jorg. I have both lines in my forums - the line that I put in the hack is the line for the private message preview hack. That's why I never had this problem.

When I wrote the installation file, I deleted the standard line and kept the wrong line for this hack. :) I meant to delete that one, not the one that is standard.

I've fixed the installation text file, and sent an update to all who installed this so they know to fix it.

[TheEDIGuy]

Erwin, I just installed this hack, because my users have been requesting it. I think it'll be nice, and the install was problem-free.

However, when I check the box to delete the original PM, I always get this message:

No privatemessage specified. If you followed a valid link, please notify the webmaster

I haven't made any modifications to private.php or the privmsg template before this. I'm running vb 2.2.7. Any further info needed, please let me know.

Thanks!

John
http://www.fansofrealitytv.com
When your reality sucks, there's Reality TV!

[Mike11212]

great hack :)

[Erwin]

Okay, a minor bug fix.

It seems that you need BOTH lines in the template.

Make sure that you have BOTH of these lines in the template code that you add to "privmsg" - the first one is needed for the delete box to work, the second one for the icon to change to SENT when a message is replied to.


<input type="hidden" name="privatemessageid" value="$privatemessageid">
<input type="hidden" name="prevmessageid" value="$privatemessageid">


Sorry about this. :) I knew that the first line was there for a reason! :)

[Erwin]

Yeah, and I've updated the installation text file to version 2.2 to reflect this.

[Areku]

Once more, thanks for this great hack!

Works like a charm on vb 2.2.0!

Thanks!

[Erwin]

Areku, I got our original message in the email sent to me. Did you figure out how to make the delete message default? :)

[Areku]

Yes, it was dumbass easy, i thought it was php but it was a checked html thing instead ;)

[Pancreas Paul]

Nice man. THis worked perfectly, and so easy to instal with vbFTP :D ILL NEVER GO BACK TO PROGRAM BASED FTP :D

[Erwin]

Originally posted by Pancreas Paul
Nice man. THis worked perfectly, and so easy to instal with vbFTP :D ILL NEVER GO BACK TO PROGRAM BASED FTP :D

:) Thanks for the kind words. :)

[Devil-GOD]

nice hack Erwin

thanks

[Graphics]

Excellent! It works perfect for me! Great work Erwin!!! :D

[Erwin]

You're welcome. :D

[BigCheeze]

Works like a charm!! Thanks for another great hack Erwin!!!!

[-Sidekick-]

Okay, got a little request here if anyone could help me out. I just installed this hack. Though in the past I also installed another hack which makes it so when you reply to a PM only the last quote shows and it gets rid of the rest.

FYI: Hack = https://vborg.vbsupport.ru/showthread.php?s=&threadid=41074 (I used FireFly's version btw, not the thread starter's)

I was wondering how I could add that to the quick pm replier as well. Make it so only the last quote shows up in the quick pm reply box?

Someone help? =\

[XFLBret]

I too have a request, but it's so minor you may be annoyed by the request...

i think I installed everything correctly, but here's what's annoying me..

when I am on the privmsg page, the cursor is not in the quick reply box. i have to either tab a few times to get the cursor, or click in the qucik reply box with the mouse.

is there a way to make it so the cursor is waiting in the quick reply box and will accept typing right away?

[XFLBret]

hey erwin, i got your response, thank you, but I think i didn't express myself well with what i wanted...

even if i scroll down with the mouse, the cursor is not in the box initially until i click in the quick reply box with my mouse.

what I am trying to accomplish is to just have the cursor already blinking in there by default, as I am a keyboard guy. don't like using the mouse except when necessary :D you know how it is.....

[XFLBret]

oops, i tried following your instructions, and i don't have the word "code" in my privmsg template. did I do somehting wrong?

[Erwin]

Easy...

Replace

<body>

with

<BODY onLoad="document.forms.vbform.message.focus()">

[XFLBret]

I replaced both body entries with that and it works. it goes directly do the quick reply box now, but i guess that's all right.

[Erwin]

There should be only 1 <body> tag in each of your templates. :)

[wolfman]

Ok I made the body tag change and WOW it seems to cause the font color and the backgroung color to change drasticlly example my background on the rest of the forum is black and the font is a light grey. The change seems to make it white and black. Though it does make the cursor jump to the quick PM window though :)

[Erwin]

That's because it means that the <body> tag in your style is replaced with something else usually. To get around this, just add a <body> tag underneath this one - in other words, have just 1 <body> and then have the code as well.

If you just want to have 1 body tag, copy the body tag contents from your style, and paste it into the body tag in the template. But this is time consuming, as you would have to do this for each style that you have.

So in essence, I take back what I said - :) - to maintain your background colors, you need to have <body> still in your privmsg, as well as my additional one. :p

[wolfman]

Ah like this? I did it this way and it seems to work just fine and I am using the default theme


<body>
<BODY onLoad="document.forms.vbform.message.focus()">

[Erwin]

Yup - that works.
I was using that, but my members started complaining lots, so I took it out. :)

[zachb]

Hey Erwin, I updated the HTML code for the template a bit to make the tables look better. Here it is:

[edit: attached instead, the code tags messed up the topic page.]


Thanks a lot for this hack, I love it. :)

[Elentari]

Working Like a dream, and SO easy to install! Thanks!! :D

[Erwin]

Thanks for the kind words. :)

[Overgrow]

Awesome, doctor. Dunno why I didn't think of this before!

/me clicks install

[Overgrow]

>>to maintain your background colors, you need to have <body> still in your privmsg, as well as my additional one.

Or at the bottom of privmsg put

<script language="javascript">
<!--
document.forms.vbform.message.focus();
-->
</script>


Which is basically the same thing as onLoad since it's at the bottom of the page (assuming you're not loading iFrames or other including bits).

[Mr.Ahmed]

thanks :)

[HughJorgen]

Very nice hack Erwin, and my users love it.

Overgrow, kudos for that script addition, for two reasons: 1, I wanted the 'gotfocus' function without losing my colors (which is what Erwin's included script did) and 2, I was able to use the same code to 'getfocus' on my regular Showthread/QuickReply box.

[Zelda-King]

I've installed it. Tested it. Works fine, except that bit at the bottom for getting the cursor to go automatically to the Quick PM Reply Box makes my PM body background go white and my toplink buttons have odd colour edges.

[Erwin]

Update Version 2.3 - minor template mod

I realized that I forgot to do something simple when I released the hack - include the name of the PM sender and time of PM in the automatic quote section. :)

To update from 2.2 to 2.3 is easy:

In the "privmsg" template, find:




$pmquote




Replace with:




$fromuserinfo[username] wrote on $message[postdate] $message[posttime]:

$pmquote




Done! :)

[msimplay]

lol i wonder why these are not included in the default release by now :D
so useful things like this are

[Erwin]

Today at 03:56 AM msimplay said this in Post #149 (https://vborg.vbsupport.ru/showthread.php?postid=369304#post369304)
lol i wonder why these are not included in the default release by now :D
so useful things like this are

Yeah, I wonder myself. I overlooked something simple. :)

[Boofo]

I did the same thing a few weeks ago, but I also put the pm message number in there (just to see if I could do it). ;)

[Areku]

Is there any update solving the multiple Re: Re: Re: Re: Re: additions?

[Erwin]

03-21-03 at 07:56 PM Areku said this in Post #152 (https://vborg.vbsupport.ru/showthread.php?postid=370454#post370454)
Is there any update solving the multiple Re: Re: Re: Re: Re: additions?


Fixed. :)

Version 2.4 - Fixed the repeated "Re:" bug.

Now, if there is one "Re:" in the message title, no other "Re:" will be added to avoid the multiple "Re:" problem.

To update manually from 2.3 to 2.4, do this:

1. In private.php, find:


$pmquote = $message[message];


Change this to:


$pmquote = $message[message];
if (strtolower(substr($message[title],0,3))=="re:") {
$re = "";
} else {
$re = "Re:";
}


2. In privmsg template, find:


"RE: $message[title]"


Change this to:


"$re$message[title]"


Done! :)

[Boofo]

An easier way to do this would be:

$title = str_replace("Re: Re: ", "Re: ", $title);

[Erwin]

Use my method - it is not case sensitive, and it prevents the addition of extra re:'s - your method is case sensitive and just changes 2 re: to 1 re: - the 2 work in different ways.

[Boofo]

LOL at Erwin. That fix came from Xenon and it works EXACTLY like yours except for the case sensitivity (which is Re according to the php file anyway). It will replace 2 instances of Re with 1 Re which would stop the addition of any Re after that. You are using extra code that really isn't needed. ;)

[Erwin]

I am using code direct from other parts of private.php - it is just the way private.php is coded, so it is done that way for consistency. If your code works for you, fine. But if I decide to manually put in RE: or re: in the message title, your code won't work.

[Boofo]

True, but why would anyone manually put an re: in the title?

[Areku]

Today at 05:46 AM Erwin said this in Post #153 (https://vborg.vbsupport.ru/showthread.php?postid=371686#post371686)



Fixed. :)

Done! :)




tHANKS man! U rool ;)

[Boofo]

02-04-03 at 10:15 PM Overgrow said this in Post #144 (https://vborg.vbsupport.ru/showthread.php?postid=350556#post350556)
>>to maintain your background colors, you need to have <body> still in your privmsg, as well as my additional one.

Or at the bottom of privmsg put

<script language="javascript">
<!--
document.forms.vbform.message.focus();
-->
</script>


Which is basically the same thing as onLoad since it's at the bottom of the page (assuming you're not loading iFrames or other including bits).

Is there a way to have this focus BELOW the quote?

[Boofo]

02-04-03 at 10:15 PM Overgrow said this in Post #144 (https://vborg.vbsupport.ru/showthread.php?postid=350556#post350556)
>>to maintain your background colors, you need to have <body> still in your privmsg, as well as my additional one.

Or at the bottom of privmsg put

<script language="javascript">
<!--
document.forms.vbform.message.focus();
-->
</script>


Which is basically the same thing as onLoad since it's at the bottom of the page (assuming you're not loading iFrames or other including bits).

Is there a way to have this focus BELOW the quote?

[Boofo]

02-04-03 at 10:15 PM Overgrow said this in Post #144 (https://vborg.vbsupport.ru/showthread.php?postid=350556#post350556)
>>to maintain your background colors, you need to have <body> still in your privmsg, as well as my additional one.

Or at the bottom of privmsg put

<script language="javascript">
<!--
document.forms.vbform.message.focus();
-->
</script>


Which is basically the same thing as onLoad since it's at the bottom of the page (assuming you're not loading iFrames or other including bits).

Is there a way to have this focus BELOW the quote?

[Erwin]

Wow... triple-post!!! :)

Mmm... I'm sure there's a way, but I don't know how. Hopefully a JS master can advise.

[AlexanderT]

I am not sure but I think there is still that one <tr> too much (line 159 of v2.4). Also, in line 161, </normalfont> should come after </b>... nothing big. Great hack!

[drumsy]

Have you had any problems with the popup notification not opening private.php in a new window since installing it?

[Erwin]

Today at 10:27 AM drumsy said this in Post #165 (https://vborg.vbsupport.ru/showthread.php?postid=386190#post386190)
Have you had any problems with the popup notification not opening private.php in a new window since installing it?

No... still works here at vB.org and on my site. This hack doesn't affect the popup javascript.

[WEForums]

Works for me as well.

[Erwin]

04-18-03 at 11:24 AM AlexanderT said this in Post #164 (https://vborg.vbsupport.ru/showthread.php?postid=383625#post383625)
I am not sure but I think there is still that one <tr> too much (line 159 of v2.4). Also, in line 161, </normalfont> should come after </b>... nothing big. Great hack!

You're right! :) I've fixed it.

[sabret00the]

very cool, i requested this but didn't know it was made, exactly what i was after, thanks erwin

[:Judge:]

Okay I am not getting the whole quote in my box all I am getting is

[quote ]

User name wrote on May-01-2003 09:51 PM:

[/quote ]

and no comment.

Also is there a way to make the page scroll down just a little more? I did the curser add on and it takes it down a bit but it would look much better if it went down a little more.

Thanks.

[Erwin]

Did you make the changes to private.php as per the instructions? You must have either forgotten to put $pmquote in or you cut and pasted it in the wrong place.

[Keyser S?ze]

is there a simplier version of this? more like fireflys quick reply box?

i installed this and was very well done, easy install, but just seems like too much to me, all i really want is like the quick reply

:) thanks

[gmarik]

Nice nice nice.
How can I add a random smileys box there?

[jibious]

for $re = "Re:";

you should make it $re = "Re: ";

(add a space after Re:) just for cosmetic reasons. i don't think you really want Re:test instead of Re: test. just my opinion. :)

[gwhooooey]

05-18-03 at 04:49 PM gmarik said this in Post #173 (https://vborg.vbsupport.ru/showthread.php?postid=396721#post396721)
Nice nice nice.
How can I add a random smileys box there?

I'd like a smileys box as well :classic:

[gmarik]

Oh, I figured it out ORDER by rand() in the query.
I would love to have those 4 little vBcode icons as on vB3 (http://www.vbulletin.com/forum/showthread.php?postid=458009) as an option - is it possible on vB2?

[Set]

Hi all,
this is the Italian translate of the hack.

[EvilLS1]

Nice one Erwin!

[David Coutts]

Thanks so much, Erwin. Been looking for this for quite a while now, finally found it. Thanks!

[Aaron1]

Thanks for the work Erwin, installed it!

Now the only/last thing bugging me is when you PM a message back and forth, the number of quotes in a quote is getting huge. Would there be a way to control the amount of quotes in a PM perhaps?

After a couple of time a PM looks like this (sample):

this is quote
this is quote
this is quote
this is quote
this is quote