More Functions in Edit Post if you are an Admin

[Xenon]

Hi folks!

After my server has had problems last night, so the date was incorrect, an the posts had the dateline of October, I start programming this hack, to change a bit more of the Posting informations if you are an Admin of the board.

Now you can change
1. The Userid of this Post (don't know when, but perhaps you'll need it sometimes)
2. The Threadid of the Post (if you want to take this post to another thread)
3. Date and time postet
4. IP Address saved with the Post
5. can make post uneditable for original Author/Mods/Supermods (priority level system) or even editable to the author when timelimit is over...

If you like it Please click on install Button
Screenshot (https://vborg.vbsupport.ru/showpost.php?s=&postid=210895)

vB3 Version of this hack can be found here (https://vborg.vbsupport.ru/showthread.php?s=&threadid=61412)

[TheComputerGuy]

nice

[Mystics]

Thx! I have adjusted it a little bit, so that you don't have to duplicate the whole template editpost, you only have to insert $admineditpost into that template (I made changes in editpost.php for that, you can find it at Step 1.3 in my file).

I have attached my changed instructions!

@Xenon
Nochmals danke f?r den Hack, bei Fragen zu meinen ?nderungen, wende dich an mich :)

Bye,
Mystics

[Xenon]

Thx, have updated my Attachment too :)

@Mystics: Hab alle Anderungen gesehn, h?tt ich selber auch draufkommen k?nnen :), so ists nat?rlich um ein St?ck praktischer, danke nochmals

Screenshot Version 2.20:

[Xenon]

Have correctet a little bug.
The line which edited the date has had a little bug which changes into a wrong day whe the day is greater 9

[Jawelin]

Yeah!! Infact I got lost!! ;)
Great hack but..... !!!

I tried to edit some posts and had the date/time switched before about 9 days and 18hrs !!!! Even without touchin' the date/time field... :)

A post made today (CET date format) :

14-01-2002 15.40 went to 04-01-2002 21.40 !!!!!
(note: I'm six hours behind my server' time...)

Hope your 'patch' fixes it... Doesn't it ?
Thanks a lot.

[Jawelin]

:( :rolleyes:

Bug is only partially fixed.
I applied your new release as of 12jan, but there's still a problem with the time synchro. I think - as said - the local area time.

The example above, for instance, now becomes :
14-01-2002 21.40 !!!

Infact, cause the substr( ..., 1,2 ) instead of substr( ..., 0, 2 ), before I had the date moved to 4 instead of 14 .... (24... etc...)
But it doesn't manage the time zone info, I think.

Infact I made a correction on the time of edit setting it to 09.40 and, as output, I got the message dated :
14-01-2002 15.40

.... :)

Hope this helps you to fix completely the problem...
Thanks again for your work.

Bye

[Xenon]

i see to correct it just add the line

$datzeit=$datzeit+4*3600;

right after

$datzeit=mktime(substr($datzeit,11,2), substr($datzeit,14,2), 0, substr($datzeit,3,2), substr($datzeit,0,2), substr($datzeit,6,4));

and change the 4 to your timeoffset.

[Jawelin]

Ok. May thanks... ;)
I think you mean the offset behind the server time, not any other absolute like GMT, do you ?

I'd prefer to use a variable environment, for example useing the $timeoffset variable adding the $bbuser[timezoneoffset] ... :)
But haven't any idea how to make the global variable be seen in editpost.php... ;)

Thanks a lot.
Again

Bye

[Xenon]

Originally posted by Jawelin

But haven't any idea how to make the global variable be seen in editpost.php... ;)


That was also my problem, thats why i use the absolute change ;)
the offset you have to set, should be like the one you set in your vb options ;)

[Jawelin]

Originally posted by Xenon

the offset you have to set, should be like the one you set in your vb options ;)

Almost...
Actually I have GMT -5 for Server' time (EST) and GMT +1 for mine and almost users (CET)... :)
So I should make the sum of abs...

By now a fixed '6' should work great !
Thanks.

[Jawelin]

Originally posted by Xenon
i see to correct it just add the line

$datzeit=$datzeit+4*3600;

right after

$datzeit=mktime(substr($datzeit,11,2), substr($datzeit,14,2), 0, substr($datzeit,3,2), substr($datzeit,0,2), substr($datzeit,6,4));

and change the 4 to your timeoffset.

Just a small correction... I tried myself :)
If my server is in a timezone 'on the left' of mine (as said, I'm on +1, the server is on -5), I should SUBTRACT 6 and not add it... :)

$datzeit is the time string displayed on my page, adjusted to my time... If the server time is six hours 'after' mine, I should resave the edited post with the server time...

my case: ---> $datzeit = $datzeit - 6 * 3600;

Thanks again for your help.
Bye

[Shenlong]

hey good hack

but can someone tell me the time for

Eastern Time (U.S.A.)

PM/AM Clock

What should I replace it with?

[Jawelin]

It' a RELATIVE value: where are you ?
:supwink:

[Jawelin]

Lookin' at vbdate() function source, I found out how to parametrize the admin's offset behind the server:

simply, the users of this hack - with your bugfix - should replace the code

$datzeit=mktime(substr($datzeit,11,2), substr($datzeit,14,2), 0, substr($datzeit,3,2), substr($datzeit,0,2), substr($datzeit,6,4));
$datzeit=$datzeit+4*3600;


$datzeit=mktime(substr($datzeit,11,2), substr($datzeit,14,2), 0, substr($datzeit,3,2), substr($datzeit,0,2), substr($datzeit,6,4));
$offset=3600*($bbuserinfo['timezoneoffset']-$timeoffset); // Seconds offset behind the server/post time
$datzeit=$datzeit-$offset; // Traslated new post time
That upgrade reverses, just before saving it, the traslation made at reading time from the post(server) time to the user time. Actually it acts as vbdate() with an inverse traslation.

This way there shouldn't be neither the import of global variables $bbuserinfo and $timeoffset, like functions.php has, as at the top of editpost.php there's a full global variables import.

That is !!
Bye
:stoned:

[Shenlong]

Originally posted by Jawelin
It' a RELATIVE value: where are you ?
:supwink:

Was that to me? I just want to know what timestamp is:

EST (U.S.A.) because im not good with doing the m-y-d thing, thats all

[Jawelin]

Originally posted by Shenlong
hey good hack
but can someone tell me the time for
Eastern Time (U.S.A.)
PM/AM Clock
What should I replace it with?

Excuse, but HOW COULD WE UNDERSTAND something different from such a question ?
:greedy:

Hwr my solution is not for you... aren't absolutely interested in, I guess..

[Lucky]

I'm sure this may come in handy!

Thanx!

[Shenlong]

Originally posted by Jawelin


Excuse, but HOW COULD WE UNDERSTAND something different from such a question ?
:greedy:

Hwr my solution is not for you... aren't absolutely interested in, I guess..

dude, lol what are u smoking? i dont understand u.

i just am wondering what to put in for the EST U.S.A. time instead of the german time

[Jawelin]

Originally posted by Shenlong


Was that to me? I just want to know what timestamp is:

EST (U.S.A.) because im not good with doing the m-y-d thing, thats all
I was right!!! ;)
Well.
Your server is EST (GMT -5). You are in Germany (GMT +1).
You definetively can use the hack's default $format : d.m.Y .... with all the substrings as the authod did...

Very simple, then... You have to correct the output time with a '-6 hours', just like me.
Any case, you can use along everyone the upgrade in Post#15.

:up: :up:

[SirSteve]

I'd like JUST the time/date stamp change part. Also, is there an English version?

[Xenon]

Thers no english version, but it isnt hard to make the changes into the english date-time format

just the date/time change
you must change following things in my Hack:

don't use Step 1.4

in step 1.5
change

$DB_site->query("UPDATE post SET ipaddress='".addslashes($ipadd)."',dateline='$datzeit',userid='$userid',threadid='$ pthreadid',title='".addslashes(htmlspecialchars($title))."',pagetext='".addslashes($message)."',allowsmilie='$allowsmilie',showsignature='$signa ture',iconid='$iconid'$editedbysql$attachmentsql WHERE postid='$postid'");


to


$DB_site->query("UPDATE post SET dateline='$datzeit',title='".addslashes(htmlspecialchars($title))."',pagetext='".addslashes($message)."',allowsmilie='$allowsmilie',showsignature='$signa ture',iconid='$iconid'$editedbysql$attachmentsql WHERE postid='$postid'");


and the admineditpost template has only this part:

<tr>
<td bgcolor="{secondaltcolor}" nowrap><normalfont><b>Date and Time:</b></normalfont></td>
<td bgcolor="{secondaltcolor}"><normalfont><input type="text" class="bginput" name="datzeit" value="$datzeit" size="40" maxlength="85"></normalfont></td>
</tr>


for englisch time format you have to change

$datzeit=mktime(substr($datzeit,11,2), substr($datzeit,14,2), 0, substr($datzeit,3,2), substr($datzeit,0,2), substr($datzeit,6,4));

into

$datzeit=mktime(substr($datzeit,11,2), substr($datzeit,14,2), 0, substr($datzeit,0,2), substr($datzeit,3,2), substr($datzeit,6,4));

i think and of course the line
$datzeit=vbdate("d.m.Y H:i",$postinfo[dateline]);
into
$datzeit=vbdate("m-d-Y H:i",$postinfo[dateline]);

this should be all you need i think

[SirSteve]

Thanks! :)

[Logician]

Nice hacks thanks :)

A reminder to people who use this hack: If you edit user id or thread id, dont forget to update the counters.

[JBMoney]

Has anyone tried this in 2.2.5 and gotten it to work?

I've installed it and everything looks right, but when I try to edit the time... nothing happens. No change in the post at all.

Any thoughts?

[JBMoney]

Nevermind, I think I see a pattern.

[mashby]

I just installed this hack. It was easy to install and answered my prayers [link (https://vborg.vbsupport.ru/showthread.php?s=&threadid=37943)]

[Xenon]

:)
you're welcome

[Boofo]

Ok, guys, I'm totally confused here. I'm one of them dumb Americans (although I do have some German Ancestory.) :)

Xenon: Why don't we use Step 1.4 if we are in the USA?

Jawelin: If my server is in the UK and I am in the USA, you offset fix will automatically set the time at my offset according to what I have in my time options, right? So i don't have to manually set it?

Sorry for the questions guys, but I want to make sure I get it right before I mess anything up. :)

[Xenon]

you have missunderstood something boofo: the don't use 1.4 was for SirSteve because he just wanted to add the datetime functions and nothing else ;)

th only thing you have to change as an american user are these lines:
$datzeit=vbdate("d.m.Y H:i",$postinfo[dateline]);
$datzeit=mktime(substr($datzeit,11,2), substr($datzeit,14,2), 0, substr($datzeit,3,2), substr($datzeit,0,2), substr($datzeit,6,4));
it's because you use other date/time formats as we do in german :)

[Boofo]

Ok, I put 1.4 part back in. But what does this mean?

$userid=0;
$username="Gast";

And what about Jawelin's auto date part? Will that work for me?

[Xenon]

in english you have to change "Gast" to "guest" ;)
because you can change the Authorid of the post, and when you choose 0, it must have a new Username, i took guest ;)

yes Jawelin's auto date part should work for ya

[Boofo]

Thank you very much. I just installed it and think I will leave the name as "Gast". That way I can have more of a German flair to the site (think that will work? :)). Thanks again! :)

[Boofo]

I ran into a major problem here. This is the date I got on a message I edited that I had just added a few minutes before.

Dec 31, 1969, 11:59 pm

Any ideas where I went wrong? :)

[Xenon]

hehe intresting idea to get a german flair in it ;) ^^

huh before 1970? very funny ;)
can you paste the two line of your editpost.php which handles the dates, so perhaps i can tell you whats wrong

[Boofo]

I hope these are the lines you wanted. :)

$datzeit=mktime(substr($datzeit,11,2), substr($datzeit,14,2), 0, substr($datzeit,0,2), substr($datzeit,3,2), substr($datzeit,6,4));
$offset=3600*($bbuserinfo['timezoneoffset']-$timeoffset); // Seconds offset behind the server/post time
$datzeit=$datzeit-$offset;

[Xenon]

seems to be correct

can you also print your exact time-format?
i mean how does this line look in your format: $datzeit=vbdate("d.m.Y H:i",$postinfo[dateline]);

* Xenon is thinking of writing a new version easier to optimize ;)

[Boofo]

I just changed it to match the time layout I use on the board. Here it is:

$datzeit=vbdate("M j, Y, g:i a",$postinfo[dateline]);

Originally posted by Xenon
seems to be correct

can you also print your exact time-format?
i mean how does this line look in your format: $datzeit=vbdate("d.m.Y H:i",$postinfo[dateline]);

* Xenon is thinking of writing a new version easier to optimize ;)

[Xenon]

Ok, there's the problem ;)
by now you can just use numeric time/date formats
so for Time you must use something like H:i instead of g:i a
and some sort of d.m.Y instead of M j, Y.
it must be sure the ammount of bytes in the timestring can't change with another date ;)....
its the way mktime() works...

[Boofo]

So, what should I put in there then? And can it be fixed to work with the date like I have it? :)

Originally posted by Xenon
Ok, there's the problem ;)
by now you can just use numeric time/date formats
so for Time you must use something like H:i instead of g:i a
and some sort of d.m.Y instead of M j, Y.
it must be sure the ammount of bytes in the timestring can't change with another date ;)....
its the way mktime() works...

[Xenon]

you should use the original format i used in the hack ;), at least till i upload a new version ;)
i think i'll update the hack next days, so changes of dateformat would be easier...

but to fix it so it'll work with your format would be very very hard, i'd nearly say impossible, because the php-function mktime() doesn't work with string variables (for months)
i have to look if i'll find a way ;)

[Boofo]

Ok, I went back to using:

$datzeit=vbdate("m-d-Y H:i",$postinfo[dateline]);


for now. If you can come up with a fix for it, it would be GREAT! :)

[Xenon]

new version is nearly finished and it'll have one extra function, you'll love it ;)

[Boofo]

I pretty much like most of your hacks, so loving the new function is a given. :) But will it have the date option fixed? And also, since you are working on it, how about putting the uers's name after the ID numberr so we can see who's number matched to what name? :)

Originally posted by Xenon
new version is nearly finished and it'll have one extra function, you'll love it ;)

[Xenon]

Boofo: too late, new version is released now ;)
It's not compatible with your dateformat, but it's very easy to change it into american format now ;)

you just have to edit template admineditpost ;)

Putinng the username after the id, is very easy but not so usefull, because if you change the userid, the name wouldn't change in editscreen ;)


New feature: You can make post uneditable for the original normal user :)

[Boofo]

I didn't mean to make it so the username was editable. It would just be nice to have a name to match the id number. :)

I like the new feature! ;) But can it be made so if the Admin makes it not to be edited, that NO ONE can edit it unless it is the Admin, not even Mods? And how do you make the numbers go to the right of the box if there is only one in it. Like a 6 for the month. It goes to the left with no 0. It would look better on the right. :)

[Xenon]

yes i thought though, too but it's the way editpost.php handles admins/mods: it just looks for mods and defines all admins as mods....

perhaps i'll make it only admineditable next time ;)

i know it would look better, but i think thats an html code problem and i don't know html very well ;)

for username: try to put an $postinfo[username] into your Admineditpost template after the enterfield for userid ;)

[Chris M]

Originally posted by Xenon
Boofo: too late, new version is released now ;)
It's not compatible with your dateformat, but it's very easy to change it into american format now ;)

you just have to edit template admineditpost ;)

Putinng the username after the id, is very easy but not so usefull, because if you change the userid, the name wouldn't change in editscreen ;)


New feature: You can make post uneditable for the original normal user :)

Way to go Xenon!!!

I see you added the "cant edit if admin selects" function:)

Satan

[Xenon]

hehe satan i do what i can ;)

boofo what about a sort of edit priority?
i.e. Editably by: Admins, Supermods, Mods, originial poster
and all users *ggg*

[Chris M]

I thought that only Admins could edit that at the moment...

I tested a Mod account, and they cannot access that or any of the functions...

Satan

[sKunk]

One question, is the time issue that was debated for 4 pages fully fixed in this new release?

Thanks :)

[Xenon]

@sKunk: yes it is completly fixed in this new release!

@Satan: Yes, just Admins got this higher functions, but if you selected editable == no mods could edit the posts

@All: Version 2.20 released five Minutes ago. It has a sort of Priority edit function in it instead of the normal editabal/not editable by users

hope you'll love it

[Chris M]

Cool!

Installing that now:)

Satan

[Chris M]

Erm...I think you forgot to add the :

error_editpriority

to the templatesused...

Satan

[Xenon]

yes i thought so too, but none of the errortemplates is in templatesused so i didn't put it into ;)

[Chris M]

Oh right...

It works great thanks:)

Really great update:)

Satan

[Boofo]

Excellent work, Xenon! Almost perfect. :) Is there any way to make it so if I wanted the Author to be able to edit it and the admin or supermod, but not the mod, can it be done? :) Also, would it be hard to pull the host name out for the IP address if there is one? :) (Sorry...:))

[Chris M]

Hmmm...

Aha!

Xenon - Maybe you could make it checkboxes instead of Radio buttons...That way you can tick who you want to be able to edit it...

Satan

[Boofo]

That should be able to be done with radio buttons too. :) They actually look better.

Originally posted by hellsatan
Hmmm...

Aha!

Xenon - Maybe you could make it checkboxes instead of Radio buttons...That way you can tick who you want to be able to edit it...

Satan

[Chris M]

But isnt the point of Radio buttons to select one or the other?:confused:

Satan

[Boofo]

I've seen them used both ways. They do that alot with on-line quizzes and surveys. :)

Originally posted by hellsatan
But isnt the point of Radio buttons to select one or the other?:confused:

Satan

[Xenon]

Boofo: i won't include that, because i think such wishes are personall wishes not used by many others, but i can tell you how to do it k?

template admineditpost
after | <input type="radio" name="editable" $editable[0] value="0">Admins
add this:
| <input type="radio" name="editable" $editable[4] value="4">Author/Supermods/Admins

then in editpost.php
find:} else if($postinfo[editable]==2 and !ismoderator($threadinfo[forumid],"caneditposts")) {
$editpriority="Moderator/Supermod/Admin";
eval("standarderror(\"".gettemplate("error_editpriority")."\");");
exit;
}

add this clause after the }:
else if($postinfo[editable]==4 and $postinfo[userid]!=$bbuserinfo[userid] and $getperms[cancontrolpanel]!=1 and $getperms[ismoderator]!=1) {
$editpriority="Author/Supermod/Admin";
eval("standarderror(\"".gettemplate("error_editpriority")."\");");
exit;
}

then replace in this line: for($i=0;$i<4;$i++) $editable[$i]=iif($postinfo[editable]==$i,"CHECKED","");

the $i<4 with $i<5

that should do the trick



hmm, ip-decoding?
i'll see what i can do, i have no idea how that works, i'll look into it ;)

[Xenon]

have to say i found a very small bug.
It just occurs if you allow guest posting...

to correct it replace this line: if (!isset($userid) or $userid=="" or $userid==0) {

with this one: if ((!isset($userid) or $userid=="" or $userid==0) and $bbuserinfo[usergroupid]==6 and $postinfo[userid]!=0) {


Also i'm thinking of a funny enhancement: Make a Post editable by all Members and make it editable by guests *gg*
Editable by all members could perhaps be usefull for clanboards in a announcement thread or something like that, the other ist just to play jokes on users ;)

are there some feature you want have included in this hack?
because i think this was the final version all other things aren't needet anymore?

[Boofo]

That could be kindof dangerous on a board, even as a joke. :) I like the hack just the way it is now. :)

Originally posted by Xenon
Also i'm thinking of a funny enhancement: Make a Post editable by all Members and make it editable by guests *gg*
Editable by all members could perhaps be usefull for clanboards in a announcement thread or something like that, the other ist just to play jokes on users ;)

are there some feature you want have included in this hack?
because i think this was the final version all other things aren't needet anymore? [/B]

[Chris M]

I think that would be funny lol, but dangerous as Boofo said...

I can just think of one more thing :

Edit the user's Signature, and save it as their signature (either for that post, or throughout the site)

Satan

[Boofo]

Thank you, sir. That's why I like installing your hacks, you're one of the few authors who will go that extra mile to make your hacks personalized. :) Great job! ;)

Boofo: i won't include that, because i think such wishes are personall wishes not used by many others, but i can tell you how to do it k?

[Chris M]

Yep!

I installed it too!:)

Must have more hacks...Must have more hacks...:D

Satan

[Xenon]

satan you're addictive to hack right? ;)

@boofo: you're welcome

ok then that was the final version i think
@satan: hmm, that wouldn't affect the post-table but the usertable, so i think it shouldn't be in the editpost.php ;)

[Boofo]

Xenon,

You're going to strangle me here in a minute, but it seems that no matter which radio button I pick now, it gets set at the Admin radio button for editing after I re-save the message. :) I followed your instruction on the add-on and double-checked everything. Sorry. :)

[Xenon]

* Xenon strangles boofo ;)

you were right, i made a little mistake in the template change i told you.

recheck it now, i've edited it ;)
you must replace one little 0 with a 4 ;)

[Boofo]

This is the change you were talking about? The value variable? That is the only change, right? :ducks: :) Thank you, again, sir. :)

| <input type="radio" name="editable" $editable[4] value="4">Author/Supermods/Admins

[Boofo]

Oh-oh, I'm in trouble now. It still keeps defaulting to just Admin being able to edit it no matter what I pick. :)

Edit: If I leave it alone and don't change it, it will stay on Author. It will only always default to Admin if I change it from Author. Any ideas how to fix this, sir? :)

[Xenon]

sure you apllied all the changes correct?
i don't see the possibility to get that weird bug..

recheck that you surely have this line:for($i=0;$i<5;$i++) $editable[$i]=iif($postinfo[editable]==$i,"CHECKED","");

if not please post your admineditpost template, will see if i can find an error

[Boofo]

Here's the line I have for that. there is a small difference, bit it should cause it to act wierd should it?

for($i=0;$i<5;$i++) $editable[$i]=iif($postinfo[editable]==$i,"CHECKED","");

The only difference I see is you have the bold tags around the 5. That wasn't in the code you gave me. :)

Originally posted by Xenon
sure you apllied all the changes correct?
i don't see the possibility to get that weird bug..

recheck that you surely have this line:for($i=0;$i<5;$i++) $editable[$i]=iif($postinfo[editable]==$i,"CHECKED","");

if not please post your admineditpost template, will see if i can find an error

[Boofo]

And here's my admineditpost template, as you requested. :)

<tr>
<td bgcolor="#1C5780" nowrap><normalfont><b>Thread ID:</b></normalfont></td>
<td bgcolor="#1C5780"><normalfont><input type="text" class="bginput" name="pthreadid" value="$postinfo[threadid]" size="40" maxlength="85"></normalfont></td>
</tr>
<tr>
<td bgcolor="#13486D" nowrap><normalfont><b>Author ID:</b></normalfont></td>
<td bgcolor="#13486D"><normalfont><input type="text" class="bginput" name="userid" value="$postinfo[userid]" size="20" maxlength="85"> $postinfo[username] </normalfont></td>
</tr>
<tr>
<td bgcolor="#13486D" nowrap><normalfont><b>Editable by (and higher):</b></normalfont></td>
<td bgcolor="#13486D"><normalfont><input type="radio" name="editable" $editable[1] value="1">Author | <input type="radio" name="editable" $editable[2] value="2">Moderators |<input type="radio" name="editable" $editable[3] value="3">Supermods | <input type="radio" name="editable" $editable[0] value="0">Admins | <input type="radio" name="editable" $editable[4] value="4">Author/Supermods/Admins</normalfont></td>
</tr>

<tr>
<td bgcolor="#1C5780" nowrap><normalfont><b>Date/Time:</b></normalfont></td>
<td bgcolor="#1C5780"><normalfont>
<input type="text" class="bginput" name="datetime[mon]" value="$datetime[mon]" size="1" maxlength="2">.<input type="text" class="bginput" name="datetime[mday]" value="$datetime[mday]" size="1" maxlength="2">.<input type="text" class="bginput" name="datetime[year]" value="$datetime[year]" size="3" maxlength="4"> - <input type="text" class="bginput" name="datetime[hours]" value="$datetime[hours]" size="1" maxlength="2">:<input type="text" class="bginput" name="datetime[minutes]" value="$datetime[minutes]" size="1" maxlength="2">

</normalfont></td>
</tr>
<tr>
<td bgcolor="#13486D" nowrap><normalfont><b>IP Address:</b></normalfont></td>
<td bgcolor="#13486D"><normalfont><input type="text" class="bginput" name="ipadd" value="$postinfo[ipaddress]" size="40" maxlength="85"></normalfont></td>
</tr>

[Xenon]

damn, boldtags should have been parsed not shown as tags *gg*

hmm, i don't see a bug in this code, it should work perfectly....

[Boofo]

I just took out the code for the extra option you wrote for me and it still defaults to Admin, no matter what I pick. So it wasn't that extra code. Is anyone else experiencing this?

Originally posted by Xenon
damn, boldtags should have been parsed not shown as tags *gg*

hmm, i don't see a bug in this code, it should work perfectly....

[Xenon]

sure you have installed everything correct?

i'd say restart with an unhacked editpost.php and install it again
this shouldn't happen and it doesn't happen on my board and my testboard...

[Chris M]

It must be that Boofo didnt do something, or did something wrong...

It works fine at my boards:) - And I followed Xenon's instructions, just as you did/should have done Boofo...

Satan

[Boofo]

hellsatan: For your information, sport, I did it EXACTLY as per the instructions and never had a problem with the hack until this final version. Everything else in it works great. I wasn't something I did or didn't do. Maybe I have another hack messing with it, I don't know.

Xenon: I could do it with a fresh editpost, but then any other hack I have installed concerning the editpost.php would not work and I have installed too many hacks to remmeber which ones deal with that file. Is there any way to go back to the hack before you added that part since it won't work for me? If you want to look at my editpost.php, I would be more than happy to pm it to you. You might see something I don't see. :)

Originally posted by hellsatan
It must be that Boofo didnt do something, or did something wrong...

It works fine at my boards:) - And I followed Xenon's instructions, just as you did/should have done Boofo...

Satan

[Xenon]

it's not allowed to send full vb-files don't forget that ;)

as you said every post would be only admin-editable, you must recheck all the queries if they are exactly what i said...

and default value at post.editable must be 1
recheck that also with phpmyadmin

[Chris M]

Did you back it up before making that change?

Satan

[MarkyBuzz]

Hi Xenon Install has been clicked - thanX for a brilliant hack.

I just wish I new about this one when I copied and pasted all indivdual posts from Postnuke Xforum over to VB which took two days - it looked a little suspiciously like I had made posts and members up due to the irregularity of time and date - now I can go and put the date and times into each post again! Jeez - another 2 days :D

Well Done!

[Boofo]

Thanks again, Xenon for clearing this up for me. This hack rocks! :)

[ladyfyre]

i have a question here......
will this hack allow (and if it won't, could you tell me how to make it) an author to edit a post beyond the boardwide edit time limit if you set the author edit option?

We use the time limit to keep users from causing chaos (we had several who would incite flamewars, then go back and edit what they said so it made others look like the instigators), but occasionally, we run into issues where we need edits made, and it would be MUCH easier if the mods could let the authors do it, rather than having them email the edits to the staff and the staff doing it.

Please help me out on this.......If it takes a lot of work, I will be happy to pay you for it...PPN can verify i am good for the money :)

[Xenon]

For now this function isn't included, but it should be easy to include it.

perhaps i can post a solution later this day, but now i haven't time to do it ;)

no money needed ;)

[ladyfyre]

You will DEFINITELY hit my list of PHP heros if you work this out Xenon :)

Btw.....i have a number of your hacks installed on my site, and have gained a lot from following your work :)

(ok...so yeah, i am kissing butt here....but it never hurts right??)

*grinz*
Seriously though....i do enjoy your hacks.....keep up the outstanding work :)

[Xenon]

Thanks for the nice words ;)

ok, here you are:
open hacked editpost.php

find this:
if ($postinfo[dateline]<(time()-($edittimelimit*60)) and $edittimelimit!=0) {

replace it with:
if ($postinfo[dateline]<(time()-($edittimelimit*60)) and $edittimelimit!=0 and $postinfo[editable]!=4) {


then find this:
for($i=0;$i<4;$i++) $editable[$i]=iif($postinfo[editable]==$i,"CHECKED","");

change it to:
for($i=0;$i<5;$i++) $editable[$i]=iif($postinfo[editable]==$i,"CHECKED","");



then in template admineditpost:
find
<input type="radio" name="editable" $editable[1] value="1">Author |

before it add:
<input type="radio" name="editable" $editable[4] value="4">Author (no timelimit)|

i think this should be all

[ladyfyre]

hmmm.....i appreciate it bunches Xenon....just one problem :(

i am getting this error when i click the edit post link:

Parse error: parse error, expecting `T_STRING' or `T_VARIABLE' or `T_NUM_STRING' in /var/www/html/editpost.php(208) : eval()'d code on line 11

could this be getting hosed by another hack??? or am i more clueless than i thought ???



Sorry...forgot to add....my line 208 is this:


eval("\$admineditpost = \"".gettemplate("admineditpost")."\";");

[Xenon]

yes tested it myself and also get this error, seems there are no -1 allowed, i'll edit my post above and change it so it'll work :)

[ladyfyre]

ok....cool then maybe i am not totally hopeless after all!!!!

Thanks again for the help on this!

[Boofo]

Xenon,

How could I add this to the one you did for me a while back? :)

[ladyfyre]

you sooooo rock :)

[ladyfyre]

uh oh :(

Xenon...sorry to be a pain, but i just ran a full test with a standard registered member who was the author of the post, and it still gave them the 60 minute time limit error msg :(

[Xenon]

@ladyfyre: you must have done something wrong, have tested it on my local board and it works as it should.
be sure you have this line in your template:<input type="radio" name="editable" $editable[4] value="4">Author (no timelimit)|


@boofo: very easy: just change all 4 to 5 and all 5 to a 6 in the instructions i gave ladyfyre

[matthew tucker]

Thanks Xenon this is a useful hack - I have clicked install ;-)

No, how can I edit the THREAD starter and THREAD date? Could you add that function?

The reason is I have a number of single-post threads I am uploading for historical reasons and want the original dates on them at top level. I can easily change post dates with your hack, but not thread dates - unless I'm missing something!

thanks

[Xenon]

well, after you editet the first posts' dates go to your Admincp, there go to update counters and there you find update threads :)

it will update the threadposter and the creation date :)

[Automated]

What query should i run to un edit the SQL table as i have uninstalled this hack.

Thanks
Matthew

[Xenon]

i think it's
ALTER TABLE post DELETE editable

but you shoul do this via PHPMyAdmin, it's more save ;)

[sbywebs]

Hiya,

Everything works great except one thing ...
On the forum home page, the last post time does not update. Even in the actual forum, it does once you update counters => update threads.

Any solutions?

[Xenon]

well, yes, you are right here.
the point is, it's possible with one or two extraqueries, but it happens just if you edit the last post in a forum, or edit one into the last post, so it's rarely needet to update the forum, and so it think it's not neccesary.

if you really need a solution, i can give you the code of course :)

[sbywebs]

that would be great, please do! :) I need it for my system log forum.

[Xenon]

ok, in editpost.php just before this:
eval("standardredirect(\"".gettemplate("redirect_editthanks")."\",\"showthread.php?s=$session[sessionhash]&postid=$postid#post$postid\");");
you should add this:
if($bbuserinfo['usergroupid'] == 6 and $foruminfo['lastpost'] < $datetime) {
$DB_site->query("UPDATE forum SET lastpost='".$datetime."',lastposter='".addslashes($postusername)."' WHERE forumid IN ($foruminfo[parentlist])");
}

it should work.
the other method would be tu run the upgrade script automatically if this doesn't work, but that would mean som queries again ;)

[sbywebs]

Nope it doesnt :(

Yesterday 07:32 PM
by JB

is what it says at the home page of the forums (www.xaviasupport.com) even though i edited it to say 8 PM, and i updated all counters :(

[Xenon]

hmm, i will look into this problem deeper within the days :)

for now i've uploaded a new version, which has the edittimelimit modification included which was in this thread already, and also optimized the code a (very) little bit.

[subu1]

hoffe es nimmt mir jetzt keiner krum das ich hier in deutsch reinschreibe, aber ich versuche krampfhaft durch zusteigen, mist mein english *heul*

Wollte nur kurz fragen was muß ich machen das die Moderatoren auch in diesen Deinen Hack Genuß kommen.

sorry for my german post, but my english ist not the best

grüße/greetz subu1

[Xenon]

einfach jedes $bbuserinfo[usergroupid]==6 durch in_array($bbuserinfo['usergroupid'], array(5,6,7)) ersetzen :)

[Boofo]

Today at 11:50 AM Xenon said this in Post #107 (https://vborg.vbsupport.ru/showthread.php?postid=380641#post380641)
einfach jedes $bbuserinfo[usergroupid]==6 durch in_array($bbuserinfo['usergroupid'], array(5,6,7)) ersetzen :)

Which means? ;)

[Dean C]

subu1 swore in german lol!

[Xenon]

boofo it means replace $bbuserinfo... with in_array...

[Boofo]

Oh, ok. Thanks. ;)

[nhlrat]

This hack seems to exist, just obtained site so didn't install it ourselves, however when an admin tries to edit from the edit icon in the post it says edit successful but actually deletes the post. Could this be something to do with this hack or just another problem? Thanks for the help.

[Xenon]

nope normally impossible with my hack, that's another problem.

[nhlrat]

Ok, thanks for your response!!!

[Sharg]

Hello,
I just installed the hack, and it seems to work great, congratulation.

I wish to know if this hacks alter the vb database in a way that may interfer with upgrade to vb3.0.
I guess not, since it only create a new distinct table, but can you confirm ?

Thanks,
Sharg

[Xenon]

i haven't seen the vb3 DB scheme yet (it's even not fully finished right now)
Normally it shouldn't make any problems, but i can't proove it, as long as vb3 isn't out ;)

[Sharg]

I don't know why but when I change the date of my single post threads, it will still show the previous unmodified date in vbhome lite is if I had not changed the date....

Do you know how to fix this ?

Thanks,
Sharg

[Xenon]

the hack just changes the dateline of the post.
vbhome reads the dateline from the threadtable.

[Jacko]

excellent hack, clicks INSTALL.

works a treat :chinese:

[Sharg]

Yesterday at 11:53 PM Xenon said this in Post #118 (https://vborg.vbsupport.ru/showthread.php?postid=385732#post385732)
the hack just changes the dateline of the post.
vbhome reads the dateline from the threadtable.

And there is no way for the hack to update threadtable too ?

Thanks
Sharg

[Xenon]

nope, currently not, and i don't have much time these days for releasing new versions.

it's on my plan of the vb3 version, but for now you have to update threadcounters if you want to change the dateline of a thread

[Sharg]

Thanks for your answer.
Well, In fact I tried to update all counters (except search index reindex) and still vbhome did show the non modified date.

Cordially,
Sharg

[Boofo]

Yesterday at 11:45 AM Xenon said this in Post #121 (https://vborg.vbsupport.ru/showthread.php?postid=385997#post385997)
nope, currently not, and i don't have much time these days for releasing new versions.

it's on my plan of the vb3 version, but for now you have to update threadcounters if you want to change the dateline of a thread

This seems to work fine:

Add:

updatethreadcount($threadinfo[threadid]);
updateforumcount($threadinfo[forumid]);

Right above:

eval("standardredirect(\"".gettemplate("redirect_editthanks")."\",\"showthread.php?s=$session[sessionhash]&postid=$postid#post$postid\");");

My question is, will this add any extra queries or server load?

[Boofo]

Yesterday at 11:51 AM Sharg said this in Post #122 (https://vborg.vbsupport.ru/showthread.php?postid=386000#post386000)
Thanks for your answer.
Well, In fact I tried to update all counters (except search index reindex) and still vbhome did show the non modified date.

Cordially,
Sharg

What version of vbHome Lite are you using? I use 3.8 and had the same problem but just fixed it. ;)

[Xenon]

Boofo: yes, because the forum and the thread tables have to be updated, it will add queries :)

so make sure they're just called if you've done an admin edit ;)

[Boofo]

Today at 07:30 AM Xenon said this in Post #125 (https://vborg.vbsupport.ru/showthread.php?postid=386912#post386912)
Boofo: yes, because the forum and the thread tables have to be updated, it will add queries :)

so make sure they're just called if you've done an admin edit ;)

It will only add 2 queries, right?

And where do I need to put them to only do it after an Admin edit? Right now I have them below:

//Admin Edit Hack
if ($bbuserinfo[usergroupid] == 6) {
$datetime=mktime($datetime[hours],$datetime[minutes],0,$datetime[mon],$datetime[mday],$datetime[year])-3600*($bbuserinfo['timezoneoffset']-$timeoffset);
$adminsql .= "ipaddress='".addslashes($ipadd)."',dateline='$datetime',editable='$editable',userid ='$userid',threadid='$pthreadid',";
}
$DB_site->query("UPDATE post SET " . $adminsql . "title='".addslashes(htmlspecialchars($title))."',pagetext='".addslashes($message)."',allowsmilie='$allowsmilie',showsignature='$signa ture',showimage='$showimage',iconid='$iconid'$edit edbysql$attachmentsql WHERE postid='$postid'");

[Xenon]

it will add 4 queries per function so in sum 8 queries in total

the position is right, but you should put it into an if block so it will just be executed if you're an admin :)

[Boofo]

Today at 07:51 AM Xenon said this in Post #127 (https://vborg.vbsupport.ru/showthread.php?postid=386919#post386919)
it will add 4 queries per function so in sum 8 queries in total

the position is right, but you should put it into an if block so it will just be executed if you're an admin :)

Like this?

if ($bbuserinfo[usergroupid] == 6) {
updatethreadcount($threadinfo[threadid]);
updateforumcount($threadinfo[forumid]);
}

I didn't know that each of those functions added 4 queries. How come so many?

Also, is there a way to make a checkbox that when ticked will update the post with the current date and time that you are editing the post (like a newreply or newthread) and if not ticked, will just update it as normal (like if you manually change the date or time)?

[nhlrat]

04-19-03 at 01:35 PM Xenon said this in Post #113 (https://vborg.vbsupport.ru/showthread.php?postid=384148#post384148)
nope normally impossible with my hack, that's another problem.

Any experts care to help a newbie and shed some light on this file of mine? I'm guessing it's something pretty simple, but don't have enough knowledge yet. Thanks guys!

[Xenon]

@nhl: as it's not a problem with my hack you should start an sepearat thread if you have such problems!

@boofo: correctly that was what i meant ;)
look into functions.php to see why so many queries are needed ;)
also yes it would be possible to add a checkbox for that, but i don't have any time to work on this these days...

[nhlrat]

Today at 05:31 PM Xenon said this in Post #130 (https://vborg.vbsupport.ru/showthread.php?postid=387453#post387453)
@nhl: as it's not a problem with my hack you should start an sepearat thread if you have such problems!

Ok thanks just didn't know where to go for the help.

[padblaz]

i've just d/l it
i'm gonna install later in the evening
thanks for this hack ;)

[Aaron1]

first of all great hack!

But just a Q to make this all available to Mods & Supermods:
is this piece of code properly modified to give them access aswell?


//Admin Edit Hack by Xenon
$adminsql = "";
if ((!isset($userid) or $userid=="" or $userid==0) and in_array($bbuserinfo['usergroupid'], array(5,6,7)) and $postinfo[userid]!=0) {
$userid=0;
$adminsql .= "username='Guest',";
}
$userid=intval($userid);

if (!isset($pthreadid) or $pthreadid=="" or $pthreadid==0) {
$pthreadid=0;
$action="deletepost";
}
$pthreadid=intval($pthreadid);

if (!isset($ipadd) or trim($ipadd)=="") {
$ipadd="";
}


I asked because this own't work :(

[Xenon]

yes it seems to be right.
but it's not the only part to change you know, do you?

[Aaron1]

Aha, that should be the reason i presume. Thanks for pointing that out Xenon!
But where should i apply the same modifications aswell?

Sorry for this extra addition request towards your already (IMO almost perfect) hack

[Xenon]

the most important part to change the bbuserinfo into the in_array version is here:
// Admin Edit Hack by Xenon
if ($bbuserinfo[usergroupid] == 6) {
eval("\$admineditpost = \"".gettemplate("admineditpost")."\";");
} else {
$admineditpost = "";
}

and of course here:
if ($bbuserinfo[usergroupid] == 6) {
$datetime=mktime($datetime[hours],$datetime[minutes],0,$datetime[mon],$datetime[mday],$datetime[year])-3600*($bbuserinfo['timezoneoffset']-$timeoffset);
$adminsql .= "ipaddress='".addslashes($ipadd)."',dateline='$datetime',editable='$editable',userid ='$userid',threadid='$pthreadid',";
}

and no problem, for my vb3 version of this hack, it was already planned to add moderator functions to editpost, too :)

[Aaron1]

Thanks Xenon! Hmm it doesn't seem to work somehow, no extra 'edit post' options for moderators nor Super Moderators.
No errors either, works for admin's though...

Here are the actual code i used:

//Admin Edit Hack by Xenon
$adminsql = "";
if ((!isset($userid) or $userid=="" or $userid==0) and in_array($bbuserinfo['usergroupid'], array(5,6,7)) and $postinfo[userid]!=0) {
$userid=0;
$adminsql .= "username='Guest',";
}
$userid=intval($userid);

if (!isset($pthreadid) or $pthreadid=="" or $pthreadid==0) {
$pthreadid=0;
$action="deletepost";
}
$pthreadid=intval($pthreadid);

if (!isset($ipadd) or trim($ipadd)=="") {
$ipadd="";
}


And ofcourse this one:

//Admin Edit Hack
if (in_array($bbuserinfo['usergroupid'], array(5,6,7))) {
$datetime=mktime($datetime[hours],$datetime[minutes],0,$datetime[mon],$datetime[mday],$datetime[year])-3600*($bbuserinfo['timezoneoffset']-$timeoffset);
$adminsql .= "ipaddress='".addslashes($ipadd)."',dateline='$datetime',editable='$editable',userid ='$userid',threadid='$pthreadid',";
}

[Xenon]

you have forgotten the first one where the extra template is loaded :)

[Aaron1]

Yes you are right! Thanks!
I am not worthy!* ;-)

*Takes of his hat and bows his head for Xenon

[Thoki]

Thanks for this great Idea to code this!
Installed.

@Aaron1:
Can you please post the complete moification you did?

Thanks at all
Thoki.

[TeH Z0mB1E]

help me please, when i set it so that only mods/super mods/admins can edit posts and save it, it reverts back to author/mods/super mods/admins. i dont think ive got this line of code either :

for($i=0;$i<5;$i++) $editable[$i]=iif($postinfo[editable]==$i,"CHECKED","");

at least i dont think ive got it, ive looked in editpost.php and the adminedit template.
where is it supposed to be?

[Xenon]

if this line isn't in your editpost.php you haven't followed the install file correctly.

do so and the hack will work.

[TeH Z0mB1E]

that lines not in the install file, at least not in mine.... where abouts in editpost.php is this line supposed to be?

if i PM you my editpost.pm file can you have a look at it please?

[Xenon]

it's very visible in the install file:
Step 2: File changes
---------------------
open file editpost.php

the particular line you mentioned is line 85 in install file.


and no i don'T do private requests right now

[TeH Z0mB1E]

ok i do have that line, but im still getting the problem on my forums, can you suggest something please? ive tried re-installing the hack but the error still comes up, help.

[Xenon]

hmm, are you sure you have made everything correct now?

it sounds like it doesn't save the changes to the post

be sure
$DB_site->query("UPDATE post SET " . $adminsql . "title='".addslashes(htmlspecialchars($title))."',pagetext='".addslashes($message)."',allowsmilie='$allowsmilie',showsignature='$signa ture',iconid='$iconid'$editedbysql$attachmentsql WHERE postid='$postid'");

is in your editpost.
and i mean the " . $adminsql . " part of it.

if that's not, then i don't know what else could it be.

[TeH Z0mB1E]

its there, could it be a template problem?

<tr>
<td bgcolor="{secondaltcolor}" nowrap><normalfont><b>Thread ID:</b></normalfont></td>
<td bgcolor="{secondaltcolor}"><normalfont><input type="text" class="bginput" name="pthreadid" value="$postinfo[threadid]" size="40" maxlength="85"></normalfont></td>
</tr>
<tr>
<td bgcolor="{firstaltcolor}" nowrap><normalfont><b>Author ID:</b></normalfont></td>
<td bgcolor="{firstaltcolor}"><normalfont><input type="text" class="bginput" name="userid" value="$postinfo[userid]" size="20" maxlength="85"> $postinfo[username] </normalfont></td>
</tr>
<tr>
<td bgcolor="{firstaltcolor}" nowrap><normalfont><b>Editable by (and higher):</b></normalfont></td>
<td bgcolor="{firstaltcolor}"><normalfont><input type="radio" name="editable" $editable[4] value="4">Author (no timelimit)| <input type="radio" name="editable" $editable[1] value="1">Author | <input type="radio" name="editable" $editable[2] value="2">Moderators |<input type="radio" name="editable" $editable[3] value="3">Supermods | <input type="radio" name="editable" $editable[0] value="0">Admins</normalfont></td>
</tr>

<tr>
<td bgcolor="{secondaltcolor}" nowrap><normalfont><b>Date/Time:</b></normalfont></td>
<td bgcolor="{secondaltcolor}"><normalfont>
<input type="text" class="bginput" name="datetime[mday]" value="$datetime[mday]" size="1" maxlength="2">.<input type="text" class="bginput" name="datetime[mon]" value="$datetime[mon]" size="1" maxlength="2">.<input type="text" class="bginput" name="datetime[year]" value="$datetime[year]" size="3" maxlength="4"> - <input type="text" class="bginput" name="datetime[hours]" value="$datetime[hours]" size="1" maxlength="2">:<input type="text" class="bginput" name="datetime[minutes]" value="$datetime[minutes]" size="1" maxlength="2">

</normalfont></td>
</tr>
<tr>
<td bgcolor="{firstaltcolor}" nowrap><normalfont><b>IP Address:</b></normalfont></td>
<td bgcolor="{firstaltcolor}"><normalfont><input type="text" class="bginput" name="ipadd" value="$postinfo[ipaddress]" size="40" maxlength="85"></normalfont></td>
</tr>


there is my admineditpost template. one of my other admins just pointed this out to me, but my forums is vB 2.3.2 is this hack compatible?

[Xenon]

the template seems like it should, so it shouldn't be a template problem.

i hope you can fix it yourself, as i cannot reproduce it, and therefore also cannot fix it.