Admin Attachment

[Ambex Net]

Can someone make a hack so admins bypass the limit of file size. Like they can upload a file that is greater than the set limit.

[Admin]

In functions.php, replace this:
if ($maxattachsize!=0 and $filesize>$maxattachsize) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if ($filesize!=$attachment_size) {
with this:
if ($maxattachsize!=0 and $filesize>$maxattachsize and $bbuserinfo[usergroupid]!=6) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if ($filesize!=$attachment_size and $bbuserinfo[usergroupid]!=6) {

[Ambex Net]

THANKS!!! Do you also know how to do this with avatars? Like admins can use any size for avatar instead of the set size?

[Admin]

Sure, in member.php replace this:
if ($imginfo[0]>$avatarmaxdimension or $imginfo[1]>$avatarmaxdimension) {
with this:
if (($imginfo[0]>$avatarmaxdimension or $imginfo[1]>$avatarmaxdimension) and $bbuserinfo[usergroupid]!=6) {

[DarkReaper]

Idea: Why not go all-out with this and make a hack where the admins/supermods/given usergroups can bypass all the limits, or only select ones?

And then release it as a full hack in the releases forum :)

[snakes1100]

Anybody, would this be correct if i wanted to also allow mods to bypass the limit also?

if ($maxattachsize!=0 and $filesize>$maxattachsize and $bbuserinfo[usergroupid]!=6) and $bbuserinfo[usergroupid]!=5) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if ($filesize!=$attachment_size and $bbuserinfo[usergroupid]!=6) and $bbuserinfo[usergroupid]!=5) {

[heretic]

if ($filesize!=$attachment_size && $bbuserinfo[usergroupid]!=6 || $bbuserinfo[usergroupid]!=5) {

[snakes1100]

Nope that isn't it heretic, all i get is this:

Parse error: parse error in /home/dssgrou/public_html/forums/admin/functions.php on line 1436

Fatal error: Call to undefined function: vbsetcookie() in /home/dssgrou/public_html/forums/admin/sessions.php on line 181

Anybody else?

[heretic]

if ($maxattachsize!=0 && $filesize>$maxattachsize && $bbuserinfo[usergroupid]!=6 || $bbuserinfo[usergroupid]!=5) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if ($filesize!=$attachment_size && $bbuserinfo[usergroupid]!=6) || $bbuserinfo[usergroupid]!=5) {



for one, you have a ) in the wrong spot on the first line, second, you were trying to say "if the file is greater than 0, larger than the max size, and the person is a mod AND admin, then..."


fixed that, dunno if it'd work

[snakes1100]

No that was jsut a typo on my part.

I still get this from that code above if i add it:

Parse error: parse error in /home/dssgrou/public_html/forums/admin/functions.php on line 1669

Warning: Cannot add header information - headers already sent by (output started at /home/dssgrou/public_html/forums/admin/functions.php:1669) in /home/dssgrou/public_html/forums/admin/functions.php on line 1545

Fatal error: Call to undefined function: makelogincode() in /home/dssgrou/public_html/forums/global.php on line 337

[yasunari]

deleted.

[Chris M]

Satan

[snakes1100]

Anybody?

[Chris M]

Anybody what?

If you are trying to make it for all staff, change the "and" to "&&"...

That should make it work...

if (($maxattachsize!=0 and $filesize>$maxattachsize and $bbuserinfo[usergroupid]!=6) && ($bbuserinfo[usergroupid]!=5)) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if (($filesize!=$attachment_size and $bbuserinfo[usergroupid]!=6) && ($bbuserinfo[usergroupid]!=5)) {

I just noticed something else...

You didnt close the brackets, which made the parse error...

Satan

[Chris M]

Ok...

Maybe not...

Try :

if (($maxattachsize!=0 and $filesize>$maxattachsize and ($bbuserinfo[usergroupid]!=6) && ($bbuserinfo[usergroupid]!=5)) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if (($filesize!=$attachment_size and ($bbuserinfo[usergroupid]!=6) && ($bbuserinfo[usergroupid]!=5)) {

Satan

[Admin]

[QUOTE]Originally posted by hellsatan
If you are trying to make it for all staff, change the "and" to "&&"...

[Chris M]

I thought it was that...Then I was wrong...Thanks for clearing it up...

Then I noticed that there were stray ")" on the end of codes, and that there were no "(" to start!

I am not sure if that works or not, but I think it should...

Satan

[snakes1100]

Ill try when i get home thanx satan...

[Chris M]

Np...

@FireFly - I have indentified a problem...

When Moderators and Users try and add attachments, it will not allow them to...Even when they are within the restrictions...

I am only using the Basic code you first mentioned, as I dont want Mods over-working the board...

Satan

[snakes1100]

@satan
Im running the basic line that firefly wrote, it runs fine and all users can upload.

[Chris M]

Hmmm...

Confusing...

What version of vB are you using?

Satan

[snakes1100]

Im running 2.2.5

Your latest code didnt work either, still get the same parse errors.

[Chris M]

Hmmm...

I am also running 2.2.5...

Try this :

if (($maxattachsize!=0 and $filesize>$maxattachsize and ($bbuserinfo[usergroupid]!=6) OR ($bbuserinfo[usergroupid]!=5)) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if (($filesize!=$attachment_size and ($bbuserinfo[usergroupid]!=6) OR ($bbuserinfo[usergroupid]!=5)) {

It probably wont work, but give it a try...

Strange...Maybe our vB just doesnt like many hacks...

Satan

[snakes1100]

satan, still getting the same parse error...

[Chris M]

Hmmm...

I am not sure where to go from here...

if (($maxattachsize!=0 and $filesize>$maxattachsize and ($bbuserinfo[userid]==1) && ($bbuserinfo[userid]==2)) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if (($filesize!=$attachment_size and ($bbuserinfo[userid]==1) && ($bbuserinfo[userid]==2)) {

That should make it work for the UserID, but I am not sure about the Usergroup...

If it does, let me know...

That way you can give some Mods and Admins access, and not allow others...

Maybe I will come up with something soon...

Satan

[snakes1100]

ooooops! :dead:

[Chris M]

Hmmm...

I thought not...

Sorry FireFly...Nice attempt, but it aint workin...

Any clues as to where you went wrong?

Satan

[snakes1100]

uhh ohh, found out what the problem was and fix'd it.

The original code by firefly is working OK, it was a error on my part after editing the file late last night. I have no ftp access at work, so i couldn't ck it out. I knew i had it working originaly.

@satan, sorry for the mix up bud and appreciate all your help so far.

[Chris M]

Hey...

I do my best...

I am going to wait for FireFly to make an excuse now...:D

Satan

[heretic]

ok, for one thing show more than just this code. because every example there's anopen bracket- show all of the hack, and the affected block

[snakes1100]

the affected block code you asked for.

this is from my functions.php, this also has the member must have a certain amount of posts to upload hack in it(in bold).

###################### Start acceptupload #######################
function acceptupload($moderate=0) {
global $DB_site,$attachment,$attachment_size,$attachment_ name;
global $attachextensions,$maxattachsize,$bbuserinfo,$maxa ttachwidth, $maxattachheight;
global $safeupload,$tmppath, $allowduplicates, $allowimgsizefailure;

$attachment_name = strtolower($attachment_name);
$extension=getextension($attachment_name);

if (strpos(" $attachextensions "," $extension ")==0) {
// invalid extension
eval("standarderror(\"".gettemplate("error_attachbadtype")."\");");
exit;
}


if (is_uploaded_file($attachment)) {
if ($safeupload) {
$path = "$tmppath/$attachment_name";
move_uploaded_file($attachment, "$path");
$attachment = $path;
}

$filesize=filesize($attachment);
if ($maxattachsize!=0 and $filesize>$maxattachsize and $bbuserinfo[usergroupid]!=5) {
// too big!
eval("standarderror(\"".gettemplate("error_attachtoobig")."\");");
exit;
}
if ($filesize!=$attachment_size and $bbuserinfo[usergroupid]!=5) {
// security error
eval("standarderror(\"".gettemplate("error_attacherror")."\");");
exit;
}
if (strstr($attachment,"..")!="") {
//security error
eval("standarderror(\"".gettemplate("error_attacherror")."\");");
exit;
}
if ($bbuserinfo["posts"] < 200) {
//No Posting Attachments
eval("standarderror(\"You don't have enough posts to post attachments.\");");
exit;
}
if ($extension=="gif" or $extension=="jpg" or $extension=="jpeg" or $extension=="jpe" or $extension=="png" or $extension=="swf") { // Picture file
if ($imginfo=@getimagesize($attachment)) {
if (($maxattachwidth>0 and $imginfo[0]>$maxattachwidth) or ($maxattachheight>0 and $imginfo[1]>$maxattachheight)) {
eval("standarderror(\"".gettemplate("error_attachbaddimensions")."\");");
}
if (!$imginfo[2]) {
eval("standarderror(\"".gettemplate("error_avatarnotimage")."\");");
}
} elseif (!$allowimgsizefailure) {
eval("standarderror(\"".gettemplate("error_avatarnotimage")."\");");
}
}

// read file
$filenum = fopen($attachment,"rb");
$filestuff = fread($filenum,$filesize);
fclose($filenum);
unlink($attachment);
$visible = iif($moderate,0,1);
// add to db
if (!$allowduplicates) {
if ($result=$DB_site->query_first("SELECT attachmentid
FROM attachment
WHERE userid = '$bbuserinfo[userid]'
AND filedata = '".addslashes($filestuff)."'")) {
$threadresult=$DB_site->query_first("SELECT post.threadid as threadid,thread.title as title FROM post
LEFT JOIN thread ON (thread.threadid = post.threadid)
WHERE post.attachmentid=$result[attachmentid]");
$threadresult['title'] = htmlspecialchars($threadresult['title']);
eval("standarderror(\"".gettemplate("error_attachexists")."\");");
exit;
}
}
$DB_site->query("INSERT INTO attachment (attachmentid,userid,dateline,filename,filedata,vi sible) VALUES (NULL,$bbuserinfo[userid],".time().",'".addslashes($attachment_name)."','".addslashes($filestuff)."','$visible')");
$attachmentid=$DB_site->insert_id();
}
return $attachmentid;
}

[snakes1100]

Anybody?

[Chris M]

Whoa...

Thats alot of php...

I shall sift through it, see if I find anything...

Satan

[snakes1100]

Anybody?

Just need to add an additional usergroup to allow them to bypass the file size limit...

[snakes1100]

help firefly.... :bunny:

[eoc_Jason]

I know this is an old thread, but that guys question never got answered because everyone had a logic error.. lol, I've encountered this before, it's kinda a mind-bender, anyhow, here's the proper line of code:

if ($maxattachsize!=0 and $filesize>$maxattachsize and ($bbuserinfo[usergroupid]!=6 and $bbuserinfo[usergroupid]!=5) {

It's not OR between the groups, it's AND.. :) Sit down and think about it...

[Davey]

Actually, eoc_Jason; I believe it would be (PLEASE TRY THE TOP ONE FIRST, IF NOT THEN THE SECOND ONE):
// For admins:
if ($maxattachsize!=0 and $filesize>$maxattachsize and $bbuserinfo[usergroupid]!=6) {

// For admins/supermods:
if ($maxattachsize!=0 and $filesize>$maxattachsize and $bbuserinfo[usergroupid]!=6 or $bbuserinfo[usergroupid]!=5) {

// For admins/supermods/mods:
if ($maxattachsize!=0 and $filesize>$maxattachsize and $bbuserinfo[usergroupid]!=6 or $bbuserinfo[usergroupid]!=5 or $bbuserinfo[usergroupid]!=7) {
If this is wrong (and this is for the attachment size), then it will probably be the following one:
// For admins:
if ($maxattachsize!=0 and $filesize>$maxattachsize and ($bbuserinfo[usergroupid]!=6)) {

// For admins/supermods:
if ($maxattachsize!=0 and $filesize>$maxattachsize and ($bbuserinfo[usergroupid]!=6 or $bbuserinfo[usergroupid]!=5)) {

// For admins/supermods/mods:
if ($maxattachsize!=0 and $filesize>$maxattachsize and ($bbuserinfo[usergroupid]!=6 or $bbuserinfo[usergroupid]!=5 or $bbuserinfo[usergroupid]!=7)) {
Thanks.

Dave.