Starred Posts

[MarkFL]

Overview:

This product is designed to give your users the ability to create/manage a list of starred/favorite posts so they can easily locate them in the future. Some users may have limited time when browsing your site, and wish to earmark posts to which they will want to reply later when they have more time. This product will allow them to tag these posts and easily find them later.

Upon installing the product a new table is added to your database to store the data pertaining to the user lists, and a new column is added to your user table to store the number of posts in each user's list.

Users with permission to use the system will see a star icon in the postbits just above the signature and to the far right that allows them to add the posts to their list. Once a post has been added, a checkmark appears next to the star icon to indicate that that post is already on their list, and if this is clicked the post is removed from the list. The icons have tooltips to indicate what will happen upon clicking them, as do all buttons and checkboxes used by the system.

https://vborg.vbsupport.ru/attachment.php?attachmentid=155217&stc=1&d=1469081947

In the search results and forum thread listings, an icon is shown to users to indicate which threads have posts in their starred list, and the icon has a tooltip indicates how many posts in the thread are in the user's starred list.

https://vborg.vbsupport.ru/attachment.php?attachmentid=155231&stc=1&d=1469213989

Under the "Quick Links" menu, users who have permission to use the system, will find a link titled "My Starred Posts" which will take them to a custom page which displays their starred posts and allow for posts to be removed. Each post has detailed information regarding the post, with links to the forum, thread and to the post itself. There are controls that allow the user to select posts for removal from the list, and to expand the post content so they can review the entire post(s) right there and to reply to the post with a quote. Post content can be expanded/collapsed one a per post basis, or all at once. Each postbit can be collapsed as well.

https://vborg.vbsupport.ru/attachment.php?attachmentid=155229&stc=1&d=1469166372

Users who have a limit imposed on the number of posts in their list will be shown additional information in the redirect messages that tell them how many additional posts they can add to their list. Once a user has added the maximum number of posts in their list, they will no longer see the star icon in the postbits with threads to add posts...they will only see the icon fro removing posts from their list.

In the product settings, you may select the usergroups that have permission to use the system, set a limit to the number of posts a user may have in their list, excempt usergroups from this limit, give limits based on usergroups, and set the persistence of user lists so that users who are inactive for longer than the number of days you have set will have their list removed from the database via a daily cron job. You may also set the maximum height of the elements containing the list of posts, and the post content within each list postbit.

https://vborg.vbsupport.ru/attachment.php?attachmentid=155630&stc=1&d=1483361196

This product is fully phrased, and stylevars are used so that the CSS for the custom page can be customized per style.

Updates:

Version 1.1:


Added reply button.
Online location processed.


Version 1.2:


Fixed issue with postbit star icon not displaying.
Added icon to threadbits to show users which threads haev posts in the starred list.


Version 1.3:


Fixed Reply Button height inconsistency issue.
Added StyleVar for position control of collapse button.
Fixed issue causing PHP deprecation warning.
Added support for displaying inline attached images in post content.
Added support for BBCode For Username HTML Markup [v1.2.1] (https://vborg.vbsupport.ru/showthread.php?t=320113).
Added support for Abbreviations/Acronyms (MathJax Compatible) [v1.3] (https://vborg.vbsupport.ru/showthread.php?t=320619).


Version 1.3.1:


Fixed Thread/Post authors in postbits.


Version 1.4:


Deleted posts removed from the lists of all users.
Posts moved to areas where users do not have permission to view are removed from the lists of those users.
User lists are updated when posts/threads are merged.
Unapproved posts and posts within unapproved threads are removed from the lists of users who are not moderators of the forum in which the affected posts reside.
Stylevar added for the margins of the postbit icon.


Version 1.5:


Usernames escaped to avoid db errors.
Postbit icon now appears at the lower right of the post content element when using legacy postbit, regardless of the post length.
Postbit icon CSS moved to template.


Version 1.6:


Added setting to allow for limits per usergroup.


Version 1.6.1:


Guests shown no permission message if trying to access the external script.


Version 1.6.2:


Users not part of the allowed usergroups shown no permission message if trying to access the external script.


Compatibility:

Tested and working on VB 4.2.x and may work on all 4.x versions of vBulletin.

Backup/Warning:

This product does alter your database, however it is always good practice to make regular backups and you should make a backup before installing ANY new mod.

As always, products are USE AT YOUR OWN RISK. I will provide support and do my best to help but no absolute guarantee is offered.

To Install:


Download and extract the attached .zip file.
Upload the files from the "upload" folder to your root folder on your server.
Follow AdminCP -> Plugins & Products -> Manage Products -> Add/Import Product.
Click on "Choose File" and browse to the product .xml file that was packaged in the .zip file.
Click "Import."
You MUST enable the product in the settings before it will function.
Configure the remaining settings to your liking. Each setting has a detailed explanation of its use.


Special acknowledgement goes to the administrators of Christianity Haven (http://www.christianityhaven.com/forum.php) for the general idea of this product and for their feedback and testing through all phases of development. :up:

Support for this product can be found here:


MHB - Starred Posts (http://mathhelpboards.com/vbulletin-products-61/starred-posts-21785.html)
TAZ - Starred Posts (https://theadminzone.com/threads/starred-posts.145026/)

[thenicehorizon]

great job
thank you very much

[Alan_SP]

Nice idea. :up:

[mikez006]

for some reason only 1 member has the star next to his posts/threads. it doesn't show up for anyone else.

I have it enabled for all usergroups.

[MarkFL]

for some reason only 1 member has the star next to his posts/threads. it doesn't show up for anyone else.

I have it enabled for all usergroups.

I've personally installed this on 3 separate vB 4.2.x sites, and that hasn't been an issue at all on them.

I would have to come to your site with an admin account to troubleshoot...if interested, send the credentials to such an account on your site, along with a link to your site, to me by PM and I can look into this tonight.

[RichieBoy67]

This is an outstanding idea Mark! I am going to check it out right now!

[RichieBoy67]

Works great but i really need to do the css so it will work with my theme.. I also changed the phrase and the nav to "My Favorites List"..

Awesome Mark! Thanks

####I see you added stylevars! Really nice Mark! The first 5 star rating is from me. :)

[MarkFL]

Works great but i really need to do the css so it will work with my theme.. I also changed the phrase and the nav to "My Favorites List"..

Awesome Mark! Thanks

####I see you added stylevars! Really nice Mark! The first 5 star rating is from me. :)

Thank you! I do appreciate your kind words. :D

[Stratis]

for some reason only 1 member has the star next to his posts/threads. it doesn't show up for anyone else.

I have it enabled for all usergroups.

Some thing like this is for me to, with the difference... if one thread has 10 posts it shows it only in 2-4 posts, same to all other threads. All posts don't show the icon.

Very nice idea, thanks

[MarkFL]

I have discovered there is a conflict with the "Show First Post Only" product of mine...are you running that mod by chance?

[MarkFL]

Update - Version 1.1:


Added reply button.
Online location processed.

[Techno Cowboy]

Awesome...works nicely & the added stylevars needed to work with my different themes, makes for a perfect addon!

Awesome Work Mark ...Thanks!

Installed & Rated....:up:

[MrD]

Hi Mark,
i have followed Problems.

Expand and Expand all are not Working in VB4.2.3 PL1.
The left Pointing Pointer are bigger then the left, see Att.

[MarkFL]

Hi Mark,
i have followed Problems.

Expand and Expand all are not Working in VB4.2.3 PL1.
The left Pointing Pointer are bigger then the left, see Att.


What browser are you using?

[ArcadeSyndicate]

really nice addon, but the idea itself isn't new, there already is something similar from dragonbyte availiable around here...

https://vborg.vbsupport.ru/showthread.php?t=258738

if you are looking for additional features, take a look at the bookmarks addon for xenforo, where you can choose between private and public. with the public bookmarks you can create a list of recomented posts for other users. also you can add a little comment to each bookmark.

https://xenforo.com/community/resources/bookmarks.272/

[MrD]

Hi Mark,
What browser are you using?
i Use Firefox and Safari. Both in actually Versions.

[MarkFL]

To everyone who has reported the star icon is not appearing in all postbits, I have resolved the issue and am working on an added feature as well, and so an update will be coming very soon. :)

[MarkFL]

Update - Version 1.2:


Fixed issue with postbit star icon not displaying.
Added icon to threadbits to show users which threads haev posts in the starred list.

[jjohns12]

I get the following error on the top of the My Stared Posts page

Warning: Only variables should be passed by reference in ..../mystarpost.php on line 74

Can you help me out with this?

Thanks

[MarkFL]

I get the following error on the top of the My Stared Posts page

Warning: Only variables should be passed by reference in ..../mystarpost.php on line 74

Can you help me out with this?

Thanks

What vB and PHP versions are you running?

[jjohns12]

What vB and PHP versions are you running?

PHP Version 5.4.35

vBulletin version 4.2.2 Patch Level 5

[MarkFL]

PHP Version 5.4.35

vBulletin version 4.2.2 Patch Level 5

After reviewing that line of code, I have no idea why your site (and no others I know of) is throwing that warning. :(

[mikez006]

got it working, thanks MarkFL.

My main concern now is having redundant systems. This is similar to the "thread subscription" feature, but much better, only it doesn't include notifications.

I think having both would be confusing to members who want to keep track of their threads. They need to both star the thread and subscribe to it if they still want to get notified.

I would like to disable thread subscriptions completely and use this exclusively, but that would require notifications to be added so the same options are present.

I would like to suggests email notifications and control panel notifications be added as options.

[MarkFL]

got it working, thanks MarkFL.

My main concern now is having redundant systems. This is similar to the "thread subscription" feature, but much better, only it doesn't include notifications.

I think having both would be confusing to members who want to keep track of their threads. They need to both star the thread and subscribe to it if they still want to get notified.

I would like to disable thread subscriptions completely and use this exclusively, but that would require notifications to be added so the same options are present.

I would like to suggests email notifications and control panel notifications be added as options.

I see this product as being complementary to the thread subscription feature. Thread subscriptions allow you to keep track of entire discussions, with notifications of replies while this product allows you to bookmark individual posts, where you are solely interested in returning to that post at some point in the future mainly to reply after having time to think about how you wish to reply.

When I was first approached about this idea by one of the admins at Christianity Haven, my reaction was that the thread subscription feature built into vBulletin already does this, but after more discussion I realized she had something else in mind, and once I realized what that was, I thought it to be a great idea, and began coding. :)

[DSemen]

Beautiful and very useful product! But, unfortunately, in my version 4.1.3 does not work. It is possible to adapt to the version 4.1.3?

[MarkFL]

Beautiful and very useful product! But, unfortunately, in my version 4.1.3 does not work. It is possible to adapt to the version 4.1.3?

I don't have access to vB 4.1.x...I would highly recommend updating your vB. :)

[MarkFL]

Update - Version 1.3:


Fixed Reply Button height inconsistency issue.
Added StyleVar for position control of collapse button.
Fixed issue causing PHP deprecation warning.
Added support for displaying inline attached images in post content.
Added support for BBCode For Username HTML Markup [v1.2.1] (https://vborg.vbsupport.ru/showthread.php?t=320113).
Added support for Abbreviations/Acronyms (MathJax Compatible) [v1.3] (https://vborg.vbsupport.ru/showthread.php?t=320619).

[mikez006]

I see this product as being complementary to the thread subscription feature. Thread subscriptions allow you to keep track of entire discussions, with notifications of replies while this product allows you to bookmark individual posts, where you are solely interested in returning to that post at some point in the future mainly to reply after having time to think about how you wish to reply.

When I was first approached about this idea by one of the admins at Christianity Haven, my reaction was that the thread subscription feature built into vBulletin already does this, but after more discussion I realized she had something else in mind, and once I realized what that was, I thought it to be a great idea, and began coding. :)

My site is a marketplace forum, so sellers like to keep track of their own threads. I know many sellers would love this addon, but they also want notifications so they can reply to customers right away.

Having to go to two separate pages to accomplish this is just clunky to me, it would be more streamlined if they could star, setup and keep track of notifications on the same page.

It might not be useful to other sites, but for marketplace forums, it would be an awesome addition to make everything simpler and more user friendly. I can make a donation to have this functionality added, just message me your Paypal email and a price :)

[babyv0x]

Thanks MarkFL for useful product .

i test version 1.3 on vBulletin 4.2.2 Patch Level 4

I get error when go to quick link/My starred posts

Strict Standards: Only variables should be passed by reference in ................/mystarpost.php on line 172

Strict Standards: Only variables should be passed by reference in ................/mystarpost.php on line 173

Strict Standards: Only variables should be passed by reference in ................/mystarpost.php on line 172

Strict Standards: Only variables should be passed by reference in ................/mystarpost.php on line 173

Strict Standards: Only variables should be passed by reference in ................/mystarpost.php on line 172

Strict Standards: Only variables should be passed by reference in ................/mystarpost.php on line 173
.....

[MarkFL]

Thanks MarkFL for useful product .

i test version 1.3 on vBulletin 4.2.2 Patch Level 4

I get error when go to quick link/My starred posts

Strict Standards: Only variables should be passed by reference in ................/mystarpost.php on line 172

Strict Standards: Only variables should be passed by reference in ................/mystarpost.php on line 173...

Okay, try the latest update:

Update - Version 1.3.1:


Fixed Thread/Post authors in postbits.


Note: Make sure you upload the new copy of mystarpost.php. ;)

[babyv0x]

I add the posts to the list, then another admin remove this post (Physically remove)

when i go to My starred posts, i see
https://vborg.vbsupport.ru/attachment.php?attachmentid=155256&stc=1&d=1469551318

When i remove this post from list, i get error
Database error in vBulletin 4.2.2:

Invalid SQL:

DELETE FROM starposts
WHERE postid IN ()
AND userid = 1;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')
AND userid = 1' at line 2
Error Number : 1064
Request Date : Tuesday, July 26th 2016 @ 06:25:36 PM
Error Date : Tuesday, July 26th 2016 @ 06:25:37 PM
Script : http://xxxxxxxx/starpost.php?do=selected
Referrer : http://xxxxxxxxx/mystarpost.php
IP Address : xxxxxxxxxxxxxxxxxxxx
Username : xxxxxxxxxxxxxxxxx
Classname : vB_Database
MySQL Version : xxxxxxx

[MarkFL]

Yes, code needs to be added to handle when posts have been deleted, or moved to areas in which the user doesn't have permission to view the post. I will do that soon, as time permits. :)

[MarkFL]

Update - Version 1.4:


Deleted posts removed from the lists of all users.
Posts moved to areas where users do not have permission to view are removed from the lists of those users.
User lists are updated when posts/threads are merged.
Unapproved posts and posts within unapproved threads are removed from the lists of users who are not moderators of the forum in which the affected posts reside.
Stylevar added for the margins of the postbit icon.

[Stratis]

Mark i want to ask...
What about bbcodes and attached files ?
I don't see the attach file xxx.zip that the real post has in to it.
I don't see content in users defined bbcodes.(made by others or me)

I see the [HIDE-POSTS] nothing in side here[/HIDE-POSTS]
Its ok to see nothing inside, but it supposed to see the image that says to hit thank you button to see content. or not to see at all the bbcode code.

Thanks, all other is ok

[MarkFL]

It's not intended to show attachments (except inline attachments).

The spoiler BBCode I use works fine...which one are you using?

[Stratis]

Yes, I see it to, actually I see all standard bbcodes, I test them one by one and don't see two of them made by me, that's why in previous post I said users defined bbcodes. All made by some one but they are standard for me :)
I have others made by me that I can see. The [HIDE-POSTS] is from here (modification)


Its not a big deal...


for the attachment, ok, as you say.

[MarkFL]

Yes, I see it to, actually I see all standard bbcodes, I test them one by one and don't see two of them made by me, that's why in previous post I said users defined bbcodes. All made by some one but they are standard for me :)
I have others made by me that I can see. The [HIDE-POSTS] is from here (modification)


Its not a big deal...


for the attachment, ok, as you say.

Without a link to the modification you are using for the [HIDE-POSTS] tags, it's hard to say, but there may be additional processing that needs to be done. For example, my UserName Markup BBCode ([UNM]) is like that, and I had to add code to this product to support it.

[Stratis]

https://vborg.vbsupport.ru/showthread.php?t=282328 :)

[MarkFL]

https://vborg.vbsupport.ru/showthread.php?t=282328 :)

OKay, I would assume, given the fact that that product has additional files that need to be uploaded, that this BBCode requires additional external processing to work correctly. :)

[MarkFL]

Update - Version 1.5:


Usernames escaped to avoid db errors.
Postbit icon now appears at the lower right of the post content element when using legacy postbit, regardless of the post length.
Postbit icon CSS moved to template.

[Snowhog]

Installed. A nice 'New Years' addition to our Forum. :up:

[Snowhog]

As written, this MOD allows selection of Usergroups who can use it, and to select Usergroups who are exempt from the limit. I would like it if I were able to have more control.

I'd like to be able to set limits 'by Usergroup'. Why? We implemented Paid Subscriptions several years back but don't have any incentives for them. This MOD, with that ability, would make a nice 'incentive', allowing us to establish higher limits based on the Paid Subscription level.

[MarkFL]

As written, this MOD allows selection of Usergroups who can use it, and to select Usergroups who are exempt from the limit. I would like it if I were able to have more control.

I'd like to be able to set limits 'by Usergroup'. Why? We implemented Paid Subscriptions several years back but don't have any incentives for them. This MOD, with that ability, would make a nice 'incentive', allowing us to establish higher limits based on the Paid Subscription level.

I'll add that to my to-do list. :)

[MarkFL]

Update - Version 1.6:


Added setting to allow for limits per usergroup.

[I.G.O.T.A.]

Installed on vB 4.2.3 Patch Level 2 and working correctly.

Very nice. ;)

[Snowhog]

I would like very much to be able to 'tag' users so posts they make are automatically included in my Starred Posts. Can that be put on your wish list?

[MarkFL]

I would like very much to be able to 'tag' users so posts they make are automatically included in my Starred Posts. Can that be put on your wish list?

That isn't really part of the intended purpose of this product, which is to be able to bookmark posts as you read them. You can already search for posts by username. :)

[Snowhog]

I do understand that, but I think you may understand my wish. Your MOD, as written, requires that you actually click on a post and then mark it as a Starred Post; you are already 'reading' it when you click on it.

I know that I, and others, would love to be able to tag users we want to track, and this MOD, if it were modified to do so, would be perfect for this. It would put posts made by those tagged users in to our Starred Posts. In my way of seeing things, this would be way more useful.

Just my 2-cent observation.

[Snowhog]

...DragonByte Tech's Thread / Post Bookmarking MOD. At least that MOD no longer works at here.

The button and icon (Thread / Post) are present, as well as the clickable entries for them in the user's Settings. But, while in a thread, clicking on either button does not result in the Thread and/or Post being added.

It's an assumption on my part that these two MODs are in conflict, with your's 'breaking' his. Can you confirm? For the moment I've disabled DB Tech's MOD.

[MarkFL]

I don't have that product installed, and I am swamped with other issues right now. :)

[Snowhog]

Totally understand. It isn't a big deal.

[MarkFL]

Totally understand. It isn't a big deal.

When I get some time, I will install DBTech's product on my local dev site and see if I can resolve the conflict. :)

[Snowhog]

That would be great. Thank you.

[DSemen]

Help me please. DB Error. Very good and useful mod, for a long time can someone tell me how to make it work on 4.1.3
Database error in vBulletin 4.1.3:

Invalid SQL:

SELECT starposts.dateline AS stardateline, post.*, thread.title AS threadtitle, thread.postusername as postusername, thread.postuserid AS postuserid, thread.dateline AS threaddateline, thread.replycount AS replycount, thread.views AS views, thread.postercount AS threadpostercount, thread.lastpost AS threadlastpost, forum.forumid AS forumid, forum.title AS forumtitle, forum.description AS forumdescription, forum.parentlist AS forumparents
FROM starposts AS starposts
LEFT JOIN post AS post
ON post.postid = starposts.postid
LEFT JOIN thread AS thread
ON thread.threadid = post.threadid
LEFT JOIN forum AS forum
ON forum.forumid = thread.forumid
WHERE starposts.userid = 1
ORDER BY starposts.dateline ASC;

MySQL Error : Unknown column 'thread.postercount' in 'field list'
Error Number : 1054
Request Date : Friday, March 31st 2017 @ 09:35:00 PM
Error Date : Friday, March 31st 2017 @ 09:35:00 PM
Script : http://forum.mysite.net/mystarpost.php

[MarkFL]

Help me please. DB Error. Very good and useful mod, for a long time can someone tell me how to make it work on 4.1.3

I don't have access to vB 4.1.x to test, but that column is a part of the thread table by default in vB 4.2.x.

After a quick check, I see it is not present in vB 3.8.11, so perhaps it was added in vB 4.2.x.

The quickest solution here would be for you to update to vB 4.2.4 (or vB 4.2.5 if you want to upgrade to PHP 7.x) ;)

[DSemen]

Unfortunately it will not be possible to update. Many mods require a serious alteration. I already tried several times to update myself and it always ended in failure. I ask you, I am ready to pay, help me.

[MarkFL]

Unfortunately it will not be possible to update. Many mods require a serious alteration. I already tried several times to update myself and it always ended in failure. I ask you, I am ready to pay, help me.

Locate the following code in the file "mystarpost.php":

$posts = $vbulletin->db->query_read("
SELECT starposts.dateline AS stardateline, post.*, thread.title AS threadtitle, thread.postusername as postusername, thread.postuserid AS postuserid, thread.dateline AS threaddateline, thread.replycount AS replycount, thread.views AS views, thread.postercount AS threadpostercount, thread.lastpost AS threadlastpost, forum.forumid AS forumid, forum.title AS forumtitle, forum.description AS forumdescription, forum.parentlist AS forumparents
FROM " . TABLE_PREFIX . "starposts AS starposts
LEFT JOIN " . TABLE_PREFIX . "post AS post
ON post.postid = starposts.postid
LEFT JOIN " . TABLE_PREFIX . "thread AS thread
ON thread.threadid = post.threadid
LEFT JOIN " . TABLE_PREFIX . "forum AS forum
ON forum.forumid = thread.forumid
WHERE starposts.userid = " . $vbulletin->userinfo['userid'] . "
ORDER BY starposts.dateline ASC
");

Change if to read:

$posts = $vbulletin->db->query_read("
SELECT starposts.dateline AS stardateline, post.*, thread.title AS threadtitle, thread.postusername as postusername, thread.postuserid AS postuserid, thread.dateline AS threaddateline, thread.replycount AS replycount, thread.views AS views, thread.lastpost AS threadlastpost, forum.forumid AS forumid, forum.title AS forumtitle, forum.description AS forumdescription, forum.parentlist AS forumparents
FROM " . TABLE_PREFIX . "starposts AS starposts
LEFT JOIN " . TABLE_PREFIX . "post AS post
ON post.postid = starposts.postid
LEFT JOIN " . TABLE_PREFIX . "thread AS thread
ON thread.threadid = post.threadid
LEFT JOIN " . TABLE_PREFIX . "forum AS forum
ON forum.forumid = thread.forumid
WHERE starposts.userid = " . $vbulletin->userinfo['userid'] . "
ORDER BY starposts.dateline ASC
");

Now, in the template "markfl_starpost_postbit", locate the line:

<tr><td>Poster Count</td><td>{vb:raw post.threadpostercount}</td><tr>

And remove it.

Let me know if this works. :)

[DSemen]

DB error has disappeared. But nowhere is there a reference to mystarpost.php
Also, when clicking on a link that is also not found anywhere (enter in the address bar) on the starpost.php forum posts:
vBulletin Message
DSe, you do not have permission to access this page. This could be due to one of several reasons:

Your user account may not have sufficient privileges to access this page. Are you trying to edit someone else's post, access administrative features or some other privileged system?
If you are trying to post, the administrator may have disabled your account, or it may be awaiting activation.

"Go To Post" - Does not lead to a message, but leads to the first page

[MarkFL]

The file "mystarpost.php" is accessed via the navbar, under "Quick Links." It could be that vB 4.1.x is incompatible with this...this is one of many reasons I marked this product for vB 4.2.x.

I'm sorry, but I just don't have the time to rewrite this product for vB 4.1.x. There are simply too few people still using it to make it worth the effort for me. vB 4.1.x is obsolete, and I would recommend anyone still using it to upgrade.

[DSemen]

Adding to the navigation bar is not a problem at all, I'll do it myself. The problem remains that by clicking the transfer is done not to the selected post, but to the first message in the topic.

[MarkFL]

...The problem remains that by clicking the transfer is done not to the selected post, but to the first message in the topic.

What are you clicking?

[DSemen]

What are you clicking?
https://vborg.vbsupport.ru/external/2017/03/1.jpg

[MarkFL]

On those links, I get a URL of the format:

...showthread.php?1104-My-New-Thread?p=2572&viewfull=1#post2572

What format are you getting?

[DSemen]

Link in the address bar
/showthread.php?t=1105?p=454239&viewfull=1#post454239

[MarkFL]

Link in the address bar
/showthread.php?t=1105?p=454239&viewfull=1#post454239

Okay, go to that post, and let me know what the link format is for that post...as if you were going to manually link to that post.

[DSemen]

Link leads to the post
/showthread.php?t=13&p=466900&viewfull=1#post466900
The link leads to the first post, when I click in mystarpost.php
/showthread.php?t=13?p=466900&viewfull=1#post466900
The problem here
13?p=466900&viewfull

[MarkFL]

Please go to the post that should be linked to, and let me know what the format of the link to that post is...

[DSemen]

Sorry, made a mistake when translating into English. I will repeat the new post

Link leads to the post
/showthread.php?t=13&p=466900&viewfull=1#post466900
The link leads to the first post, when I click in mystarpost.php
/showthread.php?t=13?p=466900&viewfull=1#post466900
The problem here
13?p=466900&viewfull

It is necessary that there should be

13&p=466900&viewfull

[MarkFL]

Okay, in the file "mystarpost.php" locate the line (should be line #177):

$post['link'] = fetch_seo_url('thread', $post) . '?p=' . $post['postid'] . '&viewfull=1#post' . $post['postid'];

And change that to:

$post['link'] = fetch_seo_url('thread', $post) . '&p=' . $post['postid'] . '&viewfull=1#post' . $post['postid'];

[DSemen]

Thank you very much!

[MarkFL]

Thank you very much!

If all is good now, please consider marking the product as installed. :)

[DSemen]

I can not understand why a guest can go to the page mystarpost.php when he is not even registered on the forum

[MarkFL]

Update - Version 1.6.1:


Guests shown no permission message if trying to access the external script.


I can not understand why a guest can go to the page mystarpost.php when he is not even registered on the forum

If you update to version 1.6.1 you'll have to redo the hacks to the external script. :)

[DSemen]

Thank you very much! Thank you for giving so much time to my problem.
How can I ban this mod for some user groups?
What would forbidden groups displayed the page as well as guests.

[MarkFL]

Update - Version 1.6.2:


Users not part of the allowed usergroups shown no permission message if trying to access the external script.


Thank you very much! Thank you for giving so much time to my problem.
How can I ban this mod for some user groups?
What would forbidden groups displayed the page as well as guests.

There is a setting that allows you to set which usergroups are allowed to use this product. Now they will get a no permission page if they manually enter the url to the script. :)

[DSemen]

True, they can not do this by reference. But they can go to /mystarpost.php

https://vborg.vbsupport.ru/external/2017/04/9.jpg

And when they click on "Remove" there is a database error

[MarkFL]

With version 1.6.2, they will get the no permission page if they are not a member of one or more of the allowed usergroups. Users who are allowed but don't have any posts in their list cannot remove anything, because they are unable to select anything.

[DSemen]

What do I need to do with version 1.6.2?

[MarkFL]

What do I need to do with version 1.6.2?

If you want to show users not in the allowed groups the no permission page, then you need to update to this version, and apply the hacks to the external script mentioned before.

[djbaxter]

We just had a member asking for some sort of bookmarking threads feature and I came here to do a search and there it was! :)

Working perfectly out of the box on vB 4.2.4

[IggyP]

installed and thank you...

my only thought was the the quick links can be easily overlooked for some....if it was in profile section with tags, quotes, likes etc....would be a better order....

not sure how difficult but just an idea

[djbaxter]

I was experiencing intermittent very slow posting and double posting after transfer to a new VPS.

We were able to identify some problem plugins in investigating this and it turns out this was one of them.

From the host tech support:

It looks like there's a specific query being ran that's really slowing down your server.


SELECT * FROM `filedata`;
# Time: 171007 13:22:30
# User@Host: ###### @ localhost []
# Thread_id: 318579 Schema: ##### QC_hit: No
# Query_time: 7.152743 Lock_time: 0.000120 Rows_sent: 31 Rows_examined: 558
# Rows_affected: 0
SET timestamp=1507396950;
SELECT post.pagetext AS preview,
thread.threadid, thread.title AS threadtitle, thread.forumid, thread.pollid, thread.open, thread.postusername, thread.$
thread.dateline, thread.notes, thread.visible, thread.sticky, thread.votetotal, thread.attach, thread.lastpost, thread$
thread.prefixid, thread.taglist, thread.hiddencount, thread.deletedcount, user.userid,
user.membergroupids, user.infractiongroupids, user.usergroupid, user.homepage, user.options AS useroptions, IF(userlis$
user.lastactivity, user.lastvisit, IF(user.options & 512, 1, 0) AS invisible


, (SELECT COUNT(*) FROM starposts AS starposts WHERE starposts.userid = 0 AND starposts.threadid = thread.threadid) $
FROM thread AS thread
LEFT JOIN user AS user ON (user.userid = thread.lastposterid)
LEFT JOIN userlist AS userlist ON (userlist.relationid = user.userid AND userlist.type = 'buddy' AND userlist.userid$


LEFT JOIN post AS post ON(post.postid = thread.firstpostid)

WHERE thread.threadid IN (0,32490,26504,31904,31744,31657,31635,31567,27852 ,31374,31276,27962,31157,30175,29848,29692,29680,2 9$
ORDER BY thread.sticky DESC, lastpost DESC;

The reason it's taking so long, is that it's using LEFT JOIN commands that will take information from a previous query, and use it into that specific query which can really slow your server down.

[MarkFL]

In that particular query, my product is not adding any LEFT JOIN commands. If the problems began after moving to a new host, I would think that's where the issue really is, although host techs, from what I've read at least, are notorious for trying to lay blame on scripts. I have run this product on multiple sites with no slowdown issues. :)

[djbaxter]

So the LEFT JOIN parts are from something else? Meaning the part they quoted was from more than one database query?

And yes, the issues began after downsizing from a dedicated server to a VPS.

[MarkFL]

Yes, my product's contribution to that query can be found in the plugin hooked at "forumdisplay_query" which reads:

global $vbulletin;

if ($vbulletin->options['markfl_starpost_active'])
{
$hook_query_fields .= ', (SELECT COUNT(*) FROM ' . TABLE_PREFIX . 'starposts AS starposts WHERE starposts.userid = ' . $vbulletin->userinfo['userid'] . ' AND starposts.threadid = thread.threadid) AS starcount';
}

The rest of the query (assuming no other products are adding to that query) can be found in the core vB script "forumdisplay.php" here:

($hook = vBulletinHook::fetch_hook('forumdisplay_query')) ? eval($hook) : false;

$threads = $db->query_read_slave("
SELECT $votequery $previewfield
thread.threadid, thread.title AS threadtitle, thread.forumid, thread.pollid, thread.open, thread.postusername, thread.postuserid, thread.iconid AS threadiconid,
thread.dateline, thread.notes, thread.visible, thread.sticky, thread.votetotal, thread.attach, $tachy_columns,
thread.prefixid, thread.taglist, thread.hiddencount, thread.deletedcount, user.userid,
user.membergroupids, user.infractiongroupids, user.usergroupid, user.homepage, user.options AS useroptions, IF(userlist.friend = 'yes', 1, 0) AS isfriend,
user.lastactivity, user.lastvisit, IF(user.options & " . $vbulletin->bf_misc_useroptions['invisible'] . ", 1, 0) AS invisible
" . ($fetchavatar ? "
,avatar2.avatarpath AS api_avatarpath, NOT ISNULL(customavatar2.userid) AS api_hascustomavatar, customavatar2.dateline AS api_avatardateline, customavatar2.width AS api_avwidth, customavatar2.height AS api_avheight,
user2.adminoptions AS api_adminoptions, user2.userid AS api_userid, user2.usergroupid AS api_usergroupid, user2.membergroupids AS api_membergroupids, user2.infractiongroupids AS api_infractiongroupids, user2.avatarrevision AS api_avatarrevision
" : "") . "
" . (($vbulletin->options['threadsubscribed'] AND $vbulletin->userinfo['userid']) ? ", NOT ISNULL(subscribethread.subscribethreadid) AS issubscribed" : "") . "
" . ($deljoin ? ", deletionlog.userid AS del_userid, deletionlog.username AS del_username, deletionlog.reason AS del_reason" : "") . "
" . (($vbulletin->userinfo['userid']) ? ", threadread.readtime AS threadread" : "") . "
" . ($redirectjoin ? ", threadredirect.expires" : "") . "
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
LEFT JOIN " . TABLE_PREFIX . "user AS user ON (user.userid = thread.lastposterid)
LEFT JOIN " . TABLE_PREFIX . "userlist AS userlist ON (userlist.relationid = user.userid AND userlist.type = 'buddy' AND userlist.userid = " . $vbulletin->userinfo['userid'] . ")
" . ($fetchavatar ? "
LEFT JOIN " . TABLE_PREFIX . "user AS user2 ON (thread.postuserid = user2.userid)
LEFT JOIN " . TABLE_PREFIX . "avatar AS avatar2 ON(avatar2.avatarid = user2.avatarid)
LEFT JOIN " . TABLE_PREFIX . "customavatar AS customavatar2 ON(customavatar2.userid = user2.userid)
" : "") . "
$deljoin
" . (($vbulletin->options['threadsubscribed'] AND $vbulletin->userinfo['userid']) ? " LEFT JOIN " . TABLE_PREFIX . "subscribethread AS subscribethread ON(subscribethread.threadid = thread.threadid AND subscribethread.userid = " . $vbulletin->userinfo['userid'] . " AND canview = 1)" : "") . "
" . (($vbulletin->userinfo['userid']) ? " LEFT JOIN " . TABLE_PREFIX . "threadread AS threadread ON (threadread.threadid = thread.threadid AND threadread.userid = " . $vbulletin->userinfo['userid'] . ")" : "") . "
$previewjoin
$tachyjoin
$redirectjoin
$hook_query_joins
WHERE thread.threadid IN (0$ids) $hook_query_where
ORDER BY thread.sticky DESC, $sqlsortfield $sqlsortorder" . (!empty($sqlsortfield2) ? ", $sqlsortfield2 $sqlsortorder" : '') . "
");

[MarkFL]

It does appear that this plugin does not need to run except when a registered user is browsing the site, so I will update this product at the designated support sites. :)

[djbaxter]

Thank you, MarkFL.

[Mike-D]

Excellent work :up:

That's what I've been looking for a long time. Keep it up, Mark ;)