Another 4.2.2 upgrade test

[Disco_Dave]

Hi Guys

Getting this error after the upgrade:

Warning: Assigning the return value of new by reference is deprecated in ..../christeris/classifieds/includes/functions.php on line 1166

All plugins are disabled via config.

Dave

[ozzy47]

That is a issue with Christos classifieds mod.

[Disco_Dave]

Yeah I know I've asked on his site also. Would it just be best to delete his files, to see if I can get in?

I've removed all parts of his mod.....but still getting this error:

Warning: require_once(./christeris/classifieds/includes/functions.php) [function.require-once]: failed to open stream: No such file or directory in ..../includes/block/html.php(95) : eval()'d code on line 3

Fatal error: require_once() [function.require]: Failed opening required './christeris/classifieds/includes/functions.php' (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home3/nirc/public_html/disco/includes/block/html.php(95) : eval()'d code on line 3

[ozzy47]

That means it can't find that file since you removed it.

[Disco_Dave]

I've got in, but it's still throwing up this error, know and again. For the most part everything seems to be working. I don't think I'll be in a rush to move to this version.

Thanks Ozzy!

[da_judge]

4.2.2 has broken all over the world, great if you have 0 plugins... advice.. dont use it

here is example

http://www.dragonbyte-tech.com/product/22-advanced-post-thanks-like

[pityocamptes]

I'm thinking the same thing. Not going to upgrade...

[CarlitoBrigante]

These warnings were likely there also before the vBulletin upgrade, but there is a 4.2.2 change in the error handler which will force php to display errors even if you have set them to off in your php.ini.

--------------- Added 1381359117 at 1381359117 ---------------

The fix is listed at vbulletin.com: http://www.vbulletin.com/forum/forum/vbulletin-announcements/vbulletin-announcements_aa/4000121-vbulletin-4-2-2-full-has-been-released

[da_judge]

So instead of fixiing errors... just hide them lool...

in settings lol

This option should only be used if you are running php 5.3.0 or greater and your plugin code is generating deprecated or strict errors. Where possible, you should fix the plugin code rather than rely on this option.

thats really bad... you should fix the plugin code rather than rely on this option.

Thats what head developer suggested hahahha mental

php.ini btw some run Nginx ;) stays broken... lucky i found a fix for nginx

[Paul M]

thats really bad... you should fix the plugin code rather than rely on this option.

Thats what head developer suggested hahahha mental
Would you like to explain (a) why "its really bad", and (b) what is "mental" ?

[da_judge]

You suggested hide errors... how is that good.. just asking

http://www.vbulletin.com/forum/forum/vbulletin-announcements/vbulletin-announcements_aa/4000121-vbulletin-4-2-2-full-has-been-released

its bad to hide errors... not saying your fault... and as im from London... its what we say.. its mental... nothing personal.. but Nginx craps out big time with update ;)

No offence intended Paul

[Paul M]

I suggested "Where possible, you should fix the plugin code". ;)

Thats not always practical or possible, so hiding them is the only alternative.

vBulletin has been hiding them for a long while due to the fact the old error handler (which dates from php 4 days) didnt do anything with them. All 4.2.2 does is expose them.

[da_judge]

question is then m8... why hide errors.. it be better to show rather than hide

and your fixes fails on nginx.. plugins which i know are not yor fault.....

[Paul M]

question is then m8... why hide errors.. it be better to show rather than hide
You are free to show them on your forum if you wish, most admins however would prefer not to display them.

On a production site, display_errors should be turned off at source (php.ini).

As noted in the standard php.ini file

;;;;;;;;;;;;;;;;;;;
; Quick Reference ;
;;;;;;;;;;;;;;;;;;;
; The following are all the settings which are different in either the production
; or development versions of the INIs with respect to PHP's default behavior.
; Please see the actual settings later in the document for more details as to why
; we recommend these changes in PHP's behavior.

; allow_call_time_pass_reference
; Default Value: On
; Development Value: Off
; Production Value: Off

; display_errors
; Default Value: On
; Development Value: On
; Production Value: Off

[CarlitoBrigante]

Paul, there is no reason to be so dismissive. I have a problem on many servers with display_errors set to off and errors still being shown by vBulletin 4.2.2 through its new error handler. Why this is happening, I did not have time to look into, as I have so many forums to upgrade I do not have time to submit a bug report. I am not paid to look into vBulletin's core code, but I might take some time to do so.

For the others: those warnings, as I said in my previous post, should not be ignored. The reality is that many plugins you could have downloaded also from vBulletin.org will cause those warnings in many vBulletin installations - just, up to this moment, you might have not noticed them. This is because many plugins are using old code or are coded following old PHP standards.

When you set display_errors to off, you should always have log_errors set to on and check routinely for errors popping up there, including warnings, and fix plugins when possible.

On production websites, you should basically NEVER show this kind of error information to the public, as it might expose vulnerabilities or other information about your server you do not want to disclose (like path structure).

Sorry for the fast post, I did not have time to re-read it for spelling errors as I have still 4 forums piled up for an upgrade today.

[meaters]

Thanks for the info Carlito.

Broken templates are also a big problem after this upgrade.

[da_judge]

Yer i understand that m8.. but im running Nginx.. php.ini doesn't work the same with nginx :)

i managed to fix anyway

cheers

--------------- Added 1381433711 at 1381433711 ---------------

Thanks for the info Carlito.

Broken templates are also a big problem after this upgrade.

you tried rebuilding templates in maintenance

Admincp > Maintenance > Rebuild Styles

:)