Bug when quoting members with "[" or "]" in their nicknames

[chefy]

We will use for this example a random member: [Dx] (https://vborg.vbsupport.ru/member.php?u=11747). So imagine that you're quoting a post from [Dx] then the quote code should look like this:

;123456]something posted by [Dx]

However it's being parsed as this:

https://vborg.vbsupport.ru/attachment.php?attachmentid=140208&stc=1&d=1343662839

Breaking the quote tag.

Please fix this at vB.org and also share with us the instructions so we all the users of vB 3.x will be able to apply the fix in our own forums.

[chefy]

I can confirm that this bug is also present in vB 4.2

[Ziki]

Nice catch :)

Also install quote notifications on vb.org!

[Paul M]

The fix is not to allow [ or ] in usernames.

Its bound to clash with any BB code, not just quote, and would be very difficult to do anything about.

[Simon Lloyd]

If you must allow daft characters in the usernames you'll have to work out a way of encapsulating it in [noparse]

[DivisionByZero]

i got sick of names like |< () R |\| and other crap a LONG time ago and disabled all but letters, numbers, underscores and dashes.

[Sarteck]

I don't think it's too unreasonable to consider utilizing a method where square brackets would be acceptable in a BB Code's option, myself.

For example, enclosing the option in quotes or double-quotes to represent literal brackets rather than to-be-parsed brackets.

"]Lorem Ispum

This actually works, btw, already, when quote does not have a second parameter delimited by a semi-colon.

"]Lorem Ispum

The problem only exists when the second parameter exists. E.G.



";2353120]The fix is not to allow [ or ] in usernames.

yields
";2353120]The fix is not to allow [ or ] in usernames.






[/QUOTE][/QUOTE][/QUOTE]Anyways, to sum it up.... I disagree with the statement that the "fix" is to not allow brackets in usernames. I think the "fix" would be to fix the problem. ;)




--------------- Added 1343906114 at 1343906114 ---------------





My Rambling

Ah. Seems that if the entire option is enclosed with quotes, everything goes smoothly.

E.G.:
;2353596"]My Rambling



;2353596"]My Rambling

:3


So, just have the Quote thingamabob enclose the stuff in quotes, yeah?

--------------- Added 1343910448 at 1343910448 ---------------

---------------

Aaaaaand, problem solved on vB4 if you change the newpost_quote template.

{vb:raw pagetext}
to
{vb:raw pagetext}


I don't know if vB3 (for vB.org) would have the same solution or not.

[Paul M]

vb.org doesnt allow such usernames, so its not an issue.

[chefy]

But could you share a fix like the one posted by Starteck for vB 3.8 users please?

[BirdOPrey5]

vBulletin 3.x has a newpost_quote template too.

You could try changing it from:

{$pagetext}

to

{$pagetext}

No idea if it will work.

I agree with Paul the better option is not to allow such usernames- unable to predict what else they may break in the future.

[Paul M]

But could you share a fix like the one posted by Starteck for vB 3.8 users please?
We cannot share what we do not have. :cool:

[vbenhancer]

We cannot share what we do not have. :cool:

i think he mean we find a solution for his own personal situation... basically, Shefi, you can post a unpaid request for this situation... maybe someone will get you a fix!

[Ziki]

We cannot share what we do not have. :cool:

What about quote notifications? I think it would be nice if every member had an option in his usercp to choose whether he wants to be notified via PM or e-mail if he's been quoted here by another member ;)

[Paul M]

Not sure how that is related to usernames, bbcode or my comment :confused:

[Ziki]

Well since we were talking about quoting and stuff....and I didn't feel like starting a new thread if I was to get shot down right away :D so is it a no or a yes?

[Paul M]

Its a No.

[Ziki]

Aw come on, why not? How many users need to second this idea so it get's considered?

[Simon Lloyd]

There's already a mod "who has quoted me" why not ask in that thread? :)

[Ziki]

There's already a mod "who has quoted me" why not ask in that thread? :)

I want it installed on vb.org not developed :)

[Simon Lloyd]

Ah!!! :)

[Paul M]

How many users need to second this idea so it get's considered?
The question isnt relevant. Features dont get installed based on "votes".

[vbenhancer]

The question isnt relevant. Features dont get installed based on "votes".

i vote on that!

[Ziki]

The question isnt relevant. Features dont get installed based on "votes".

Yes I understand, but please at least give us a valid reason why this can't be implemented.

Edit: Oh right, I see now, how handy.

Staff decisions are final. Ultimately, staff has complete discretion over what is and is not acceptable on the site.