PDA

View Full Version : Show Thread Enhancements - OS/Browser Display in Postbits


nhawk
03-29-2012, 10:00 PM
No longer available on vB.org.

nhawk
03-30-2012, 05:08 PM
Any requests for new operating systems or browser types, or requests for corrections should include a complete useragent string from your server logs.

Any request without that will not be added or corrected.

SAMPLE USERAGENT:
Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.142 Safari/535.19

Nirjonadda
03-30-2012, 05:31 PM
Installed working on 4.1.10......you can try to add this Postbit: Display Location?

nhawk
03-30-2012, 05:33 PM
Installed working on 4.1.10......you can try to add this Postbit: Display Location?

I don't understand what you mean by 'Display Location'.

Do you mean where the member is located, or where the icons should be displayed in the postbit?

Nirjonadda
03-30-2012, 05:42 PM
yes....where the icons should be displayed in the postbit?

nhawk
03-30-2012, 06:02 PM
yes....where the icons should be displayed in the postbit?

There aren't many places that they can go, but I'll have a look at it.

wally07
03-30-2012, 07:12 PM
installed, 5 star'ed and nominated for MOTM :)

home9000
03-30-2012, 08:13 PM
Can we have this Hack for 3.8 ?

nhawk
03-30-2012, 08:14 PM
Can we have this Hack for 3.8 ?

Other than bug fixes, I am no longer coding for vB 3.x.

Krusty1231
03-30-2012, 08:18 PM
Did not work until I made a post after install. Just in case no one see's any changes immediately after install.

Any change I can get this centered?

Installed and Voted.

Thanks for this.

nhawk
03-30-2012, 08:35 PM
Did not work until I made a post after install. Just in case no one see's any changes immediately after install.

Any change I can get this centered?

Installed and Voted.

Thanks for this.

That is correct. Only new posts will get the OS and Browser information. There's no way to go back in history to get the OS and Browser for old posts.

I'll look into centering with the next release. But, that may be a while depending on what feedback is received here.

Trevor Matthews
03-30-2012, 08:53 PM
Excellent.
Rated 5 and nominated.
Many thanks.

Taurus1
03-30-2012, 11:04 PM
Works great on 4.1.10. Thank you very much. I would also like to be able to move it to a different place in the postbit. And also have the option to center it. That would be awesome!

iask
03-31-2012, 05:03 AM
Nice work ;)
nominated for MOTM

erosolmi
03-31-2012, 06:21 AM
Installed and nominated MOTM

Skyrider
03-31-2012, 07:33 AM
Would be nice to have the code to manually place the (where it'll display) in the template. But other than that.. installed!

Kraxell
03-31-2012, 08:14 AM
Maybe the coder can make a variable for manual template-adding.

Does this mod make a high traffic or loadtime?

nhawk
03-31-2012, 09:57 AM
Maybe the coder can make a variable for manual template-adding.

Does this mod make a high traffic or loadtime?

This mod adds one write query when a post is made. Other than that, no added queries are made. So, there is no significant increase in load time.

UKCE_Hitman
03-31-2012, 10:33 AM
thanks works great..Installed

rhody401
03-31-2012, 10:47 AM
Great idea!

It didn't work for me though, in 4.1.11

I am using postbit.legacy

Do I need to make changes to the template, too? All I did was upload the icons folder and install the xml

Are administrators perhaps exempt from displaying?

nhawk
03-31-2012, 10:56 AM
Great idea!

It didn't work for me though, in 4.1.11

I am using postbit.legacy

Do I need to make changes to the template, too? All I did was upload the icons folder and install the xml

Are administrators perhaps exempt from displaying?

It should work with postbit.legacy (considering that's what is shown in the screenshot, and the screenshot is from vB 4.1.11). :)

Did you make a post after installing? There's no way for old posts to get the OS and Browser that was used when they were made.

rhody401
03-31-2012, 11:09 AM
Thanks for the quick reply!

Yes I made multiple posts, and before doing so I went into the settings option and set everything to YES.

rhody401
03-31-2012, 11:11 AM
I also tried posting with css sprites on and off.

nhawk
03-31-2012, 11:13 AM
I also tried posting with css sprites on and off.

If you are willing to let me look at it, send me a PM with a temporary admin password with the URL to your site. Something must be different about your settings or styles.

Doctor Death
03-31-2012, 11:30 AM
This works great and instantly on my 4.1.11.

For those who wondered, it works well with eTiKeT™ 2011 Posbit_legacy - Postbit mod.

The one thing it doesnt do is retain the background from the above mod... it is white instead of transparent. If you would like to look at this I can provide temporary credentials into my site.

Not to be the good-idea guy, but if you could add an option to "box it", another to center it, and another to put a title on it (like the MY SOCIAL NETWORKING mod). I do like the idea also of being able to place it somewhere else in the postbit.

Thanks for a great mod.

nhawk
03-31-2012, 11:39 AM
This works great and instantly on my 4.1.11.

For those who wondered, it works well with eTiKeT? 2011 Posbit_legacy - Postbit mod.

The one thing it doesnt do is retain the background from the above mod... it is white instead of transparent. If you would like to look at this I can provide temporary credentials into my site.

Not to be the good-idea guy, but if you could add an option to "box it", another to center it, and another to put a title on it (like the MY SOCIAL NETWORKING mod). I do like the idea also of being able to place it somewhere else in the postbit.

Thanks for a great mod.If you could let me take a look I'd appreciate it because the images used in this mod do have a transparent background and shouldn't display as white.

rhody401
03-31-2012, 11:50 AM
I have a modification to the .htaccess file (from do_not_upload folder), and am using mod rewrite friendly URLs.

example: http://www.mydomain.com/threads/425-New-Feature-Browser-and-operating-system-on-posts?p=2510#post2510

The site is also installed in the root, not in a sub folder. ex: www.mydomain.com not www.mydomain.com/forum/

www.mydomain.com/images/osbrowsericons/ is the true path (vs www.mydomain.com/threads/images/osbrowsericons/ virtual path)

I bet it has something to do with finding the full path, or assuming it to be the same as the rewritten url.

If you want to take a look, i'm fine with that, but I just wanted to run the above by you first; as a possibility.

General comment: The UNKNOWN LOCATION errors in the whos online problem I was having previously were due to it looking in the virtual path, rather than the actual. I fixed that one by changing the FAVICON variable to have the full path instead of just the filename. I guess it reads the "base path" as the virtual.

nhawk
03-31-2012, 11:59 AM
I have a modification to the .htaccess file (from do_not_upload folder), and am using mod rewrite friendly URLs.

example: http://www.mydomain.com/threads/425-New-Feature-Browser-and-operating-system-on-posts?p=2510#post2510

The site is also installed in the root, not in a sub folder. ex: www.mydomain.com not www.mydomain.com/forum/

www.mydomain.com/images/osbrowsericons/ is the true path (vs www.mydomain.com/threads/images/osbrowsericons/ virtual path)

I bet it has something to do with finding the full path, or assuming it to be the same as the rewritten url.

If you want to take a look, i'm fine with that, but I just wanted to run the above by you first; as a possibility.

General comment: The UNKNOWN LOCATION errors in the whos online problem I was having previously were due to it looking in the virtual path, rather than the actual. I fixed that one by changing the FAVICON variable to have the full path instead of just the filename. I guess it reads the "base path" as the virtual.

Did someone tell you to upload that file?

In any case, that might be the problem and I would have to look at your site to see exactly what is going on.

rhody401
03-31-2012, 01:12 PM
Thank you for taking a look. I really appreciate it!

Robru
03-31-2012, 03:58 PM
Very nice for SysOps :) Thanks!

nhawk
03-31-2012, 04:05 PM
For everyone's benefit, rhody401's problem is fixed.

Since it doesn't seem to be a common problem, I will wait until sometime next week to release an update. I may or may not include some of the suggestions with that update. It all depends on the time I have available to include them.

rhody401
03-31-2012, 04:07 PM
The level of support you provided to troubleshoot this was nothing short of award worthy! :)

Thank you for the plugin, and for being such a nice person/providing extensive assistance with it :up:.

Rhody

wally07
03-31-2012, 04:19 PM
hello nhawk,

How do I go about looking at my server logs to find the string to a certain browser? A small group of my users are using Pale Moon (http://www.palemoon.org/) (an optimized Firefox-based browser.)

Thanks in advance.

edit:
I should mention that the Pale Moon users are showing up as Firefox users.

nhawk
03-31-2012, 04:34 PM
hello nhawk,

How do I go about looking at my server logs to find the string to a certain browser? A small group of my users are using Pale Moon (http://www.palemoon.org/) (an optimized Firefox-based browser.)

Thanks in advance.

edit:
I should mention that the Pale Moon users are showing up as Firefox users.

Server access logs could be located in the /var/log/httpd or /var/log/access folders on your server. It all depends on your server configuration.

As an alternate, while someone that uses that browser is online go to the 'Who's Online' and change 'User Agent' to 'Yes'. Then click Display.

If the complete useragent is shown, that will do for my purposes.

ptceuro
03-31-2012, 05:07 PM
wow, thats an awesome tutorial, thanks so much!!

faisaly.com
03-31-2012, 08:19 PM
Working on vb4.1.3 after installing and making a new post... I will try to do a maintenance and see if it posts the OS display to older posts made...Thanks for this mod....

CharlieDelta
03-31-2012, 10:24 PM
Excellent mod. Excellent support.
5 star rated!

Doctor Death
04-01-2012, 01:45 AM
Nominated Mod of the Month. Really nice to see a developer who is in tune with users.

HHelp1
04-01-2012, 03:34 AM
Is there any way i can put those icons under the postbit? I dont want it in middle postbit like this https://vborg.vbsupport.ru/ i want those display under my postbit. Thanks a lot!

nhawk
04-01-2012, 09:21 AM
Working on vb4.1.3 after installing and making a new post... I will try to do a maintenance and see if it posts the OS display to older posts made...Thanks for this mod....

It will not put the information in old posts. There is no way to obtain the OS and Browser used when the old posts were made.

nhawk
04-01-2012, 09:22 AM
Is there any way i can put those icons under the postbit? I dont want it in middle postbit like this http://screensnapr.com/e/rgbJB1.jpg i want those display under my postbit. Thanks a lot!

Umm, how to say this?

It DOES put it at the bottom of the postbits. It's the other mods that you are running that are adding things AFTER postbits.

You could try going to ACP->Plugins & Products->Plugin Manager, locate the 'Put OS/Browser in Postbit' plugin and change it's execution order to 6 or 7. That may or may not work. However I lean more to the may not side.

MrBeastlymfe
04-01-2012, 01:18 PM
I made new post and they still aren't showing up?

nhawk
04-01-2012, 01:28 PM
I made new post and they still aren't showing up?

If you uploaded the files and installed the XML and turned on the options in ACP->Settings->Options->OS/Browser Display Settings, go to ACP->Plugins & Products->Plugin Manager. Locate the 'Put OS/Browser in Postbit' plugin and add this as the very first line in the plugin...

global $vbulletin;

Adrijan
04-01-2012, 08:19 PM
If you uploaded the files and installed the XML and turned on the options in ACP->Settings->Options->OS/Browser Display Settings, go to ACP->Plugins & Products->Plugin Manager. Locate the 'Put OS/Browser in Postbit' plugin and add this as the very first line in the plugin...

global $vbulletin;

Works after add this line ... vB 4.1.3

Thanks a lot !

P.S. Good luck @ MOTM April ... I voted 4 this mod.

nhawk
04-02-2012, 05:37 PM
Updated today to account for some systems not displaying icons and added most requests from users.

Nirjonadda
04-02-2012, 06:33 PM
Now Excellent Work...Thanks for updated

faisaly.com
04-02-2012, 06:59 PM
Make sure users that have v1.00 installed overwrite the image folder via forum root... or they may experience some strange looking icons ...

nhawk
04-02-2012, 09:36 PM
Make sure users that have v1.00 installed overwrite the image folder via forum root... or they may experience some strange looking icons ...

That's why the install/upgrade instructions say to upload the contents of the upload folder. :D

New Joe
04-03-2012, 04:06 AM
@nhawk, when i set the option like so> Above IM Links
In some cases it shows at the bottom of the Postbit (as this is how I want it to) but in other cases it shows to thr right of the users av.
Very strange, any ideas?

clutchthese
04-03-2012, 07:28 AM
installed n nominated!

New Joe
04-03-2012, 08:09 AM
I sorted out my problem and nominated the mod.

Just one thing nhawk, I think Vista/ Server 2008 should be read as Windows 7.

clutchthese
04-03-2012, 08:30 AM
@nhawk, when i set the option like so> Above IM Links
In some cases it shows at the bottom of the Postbit (as this is how I want it to) but in other cases it shows to thr right of the users av.
Very strange, any ideas?

What did you do to fix this?

New Joe
04-03-2012, 08:44 AM
I didn't really fix it as such, I wanted it at the bottom of the postbit so after the above way had strange results I just changed the setting to this one> Below Post Count
Which put it at the bottom of the postbit and worked and showed fine for every member who posted.

nhawk
04-03-2012, 10:04 AM
Above IM links appears to be in the same place as Below Post Count but it is slightly lower. Especially if there are no other mods adding to the area below the post count.

If your style is showing the icons out of postition, temporarily switch to the vB default style and check it. If it shows OK there, then it's your style or another plugin for the postbit area that isn't handling the postbit area correctly.

Window 7 shows as Windows 7/ Server 2008 R2.

If you have a version of Window 7 that is showing as Vista, please post the complete user agent for that system.

BANDiT600
04-03-2012, 11:47 AM
I installed it right now on 4.1.11 and it don't work. Sorry, everything's fine!

steeler7
04-03-2012, 12:57 PM
I installed this on 4.1.11 PL1 and it's not working/showing up. I am using eTiKeT's postbit style ---> https://vborg.vbsupport.ru/showthread.php?t=236953 perhaps there's a compatibility issue?

lodos0677
04-03-2012, 01:05 PM
Very beatuful. + 1

nhawk
04-03-2012, 02:06 PM
I installed this on 4.1.11 PL1 and it's not working/showing up. I am using eTiKeT's postbit style ---> https://vborg.vbsupport.ru/showthread.php?t=236953 perhaps there's a compatibility issue?

Strange, Doctor Death says it works with that. See this post...
https://vborg.vbsupport.ru/showpost.php?p=2315343&postcount=25

EDIT: Wait, the one you are using is older than Doctor Death's.

I see no reason it shouldn't work. The hooks are all in place for it to work in that mod.

Have you made a new post to see if it works? Old posts do not receive the icons, only new posts will.

sweetpotato
04-03-2012, 03:23 PM
I use Postbit Tabs, so how to search OS/Browser Display template to put in the Tab?
Thanks,

nhawk
04-03-2012, 03:50 PM
I use Postbit Tabs, so how to search OS/Browser Display template to put in the Tab?
Thanks,

If you're using DBTech's postbit tabs, create a new view with this code...
<img class="{vb:raw $post.osb_sysicon}" src="clear.gif" alt="{vb:raw $post.osb_system}" /> <img class="{vb:raw $post.osb_icon}" src="clear.gif" alt="{vb:raw $post.osb_browser}" />

And then disable the 'Put OS/Browser in Postbit' plugin.

You will be limited to using the 'Sprite' system doing this. So make sure that is enabled (it is by default) if you disabled it.

sweetpotato
04-03-2012, 04:14 PM
Just followed your instruction and have OS/Browser display in Tab.

Thank you for very nice mod. I will rate and nominate it.

steeler7
04-03-2012, 06:22 PM
Strange, Doctor Death says it works with that. See this post...
https://vborg.vbsupport.ru/showpost.php?p=2315343&postcount=25

EDIT: Wait, the one you are using is older than Doctor Death's.

I see no reason it shouldn't work. The hooks are all in place for it to work in that mod.

Have you made a new post to see if it works? Old posts do not receive the icons, only new posts will.

It's fixed.. accidentally actually by trying to fix an issue with the Everywhere Sidebar Mod. Basically, when I went into Options>>Styles & Settings and selected "store Css stylesheets as files" to No and it is working now

nhawk
04-03-2012, 06:30 PM
It's fixed.. accidentally actually by trying to fix an issue with the Everywhere Sidebar Mod. Basically, when I went into Options>>Styles & Settings and selected "store Css stylesheets as files" to No and it is working now

That usually means that vBulletin isn't able to write to the clientscript/vbulletin.css folder (and any folders in there too).

Robru
04-03-2012, 07:31 PM
V1.0.1 messed up the images in Windows 8 with IE10 :)

nhawk
04-03-2012, 07:44 PM
V1.0.1 messed up the images in Windows 8 with IE10 :)

Upload all of the files to your server. AND install the XML with 'allow overwrite' set to 'Yes'.

That combination is displaying fine on my site..
http://snogssite.com/showthread.php?349-Browser-and-OS-info-in-postbits&p=1276&viewfull=1#post1276

bosanci28
04-03-2012, 08:41 PM
not working for me in 4.1.11
not showing.

thanks

nhawk
04-03-2012, 09:00 PM
not working for me in 4.1.11
not showing.

thanks

Did you turn it on in ACP->Settings->Options->OS/Browser Display Settings? Did you make a new post? Old posts do not get icons, only new posts do.

My site runs 4.1.11 as others using the mod do, and it works there without a problem.

All screenshots by me in this thread are from vB 4.1.11 or 4.1.11 pl-1

ellovo
04-03-2012, 09:07 PM
Thanks. working good on 4.1.10

bosanci28
04-03-2012, 09:10 PM
Did you turn it on in ACP->Settings->Options->OS/Browser Display Settings? Did you make a new post? Old posts do not get icons, only new posts do.

My site runs 4.1.11 as others using the mod do, and it works there without a problem.

All screenshots by me in this thread are from vB 4.1.11 or 4.1.11 pl-1

works,now.
made new post.

thanks!!!!

Robru
04-03-2012, 09:39 PM
Upload all of the files to your server. AND install the XML with 'allow overwrite' set to 'Yes'.

That combination is displaying fine on my site..
http://snogssite.com/showthread.php?349-Browser-and-OS-info-in-postbits&p=1276&viewfull=1#post1276Thanks, this is the solution for my problem! ;)

Robert8
04-04-2012, 01:07 AM
Excellent. Works perfect on 4.1.11.
Rated 5 and nominated.
Many thanks!!!.

BaanFarsang
04-04-2012, 11:48 AM
Not work on 4.1.12

nhawk
04-04-2012, 11:50 AM
Not work on 4.1.12

Did you turn it on in ACP->Settings->Options->OS/Browser Display Settings? Did you make a new post? Old posts do not get icons, only new posts do.

EDIT: This DOES work with 4.1.12 Beta 1. See attached screenshot.

New Joe
04-04-2012, 12:45 PM
Not work on 4.1.12

I find it really silly using vb 4.1.12 Beta on a live site anyway.

SeeLand
04-04-2012, 07:31 PM
It's working with vbulletin 4.1.3?
Someone test?

nhawk
04-04-2012, 07:33 PM
It's working with vbulletin 4.1.3?
Someone test?

In the description in the first post...
Known Working with vB 4.1.3, 4.1.5, 4.1.10 and 4.1.11

Doctor Death
04-04-2012, 09:40 PM
Updated to the new version on 4.1.11 PL 1 with Eticket's post bit enhancement.... Works and looks great and checked all position options out which also works fine.

Thanks again to Nhawk for a nice, tight mod. Nominated.

steeler7
04-06-2012, 12:06 AM
That usually means that vBulletin isn't able to write to the clientscript/vbulletin.css folder (and any folders in there too).

While it is displaying the icons, it's displaying multiple icons and vertically. shouldn't it only show for instance a firefox icon once and if there's another browser then show that one next to it horizontally not vertically?

it seems like it is showing an icon every time someone logs in and off making the postbit very long and filled with icons stacked on top of each other

nhawk
04-06-2012, 10:08 AM
While it is displaying the icons, it's displaying multiple icons and vertically. shouldn't it only show for instance a firefox icon once and if there's another browser then show that one next to it horizontally not vertically?

it seems like it is showing an icon every time someone logs in and off making the postbit very long and filled with icons stacked on top of each other

This is a problem with your style or another mod. It isn't handling the postbit area correctly.

There are only 2 icons for each post. OS and Broswer type.

X-or
04-13-2012, 11:40 AM
I suppose it won't work on vB3. And yes I have seen the vB3 version but it doesn't seem to have anywhere as much features.

nhawk
04-13-2012, 12:17 PM
I suppose it won't work on vB3. And yes I have seen the vB3 version but it doesn't seem to have anywhere as much features.

No, this isn't the same as the vB3 version and it won't work with vB3.

dmandem
04-13-2012, 09:49 PM
Great mod, thanks!

Working on 4.1.12 incase anybody is thinking of installing.

Mr_Running
04-18-2012, 05:55 PM
I confirm, working on 4.1.12 :)

In regards to Usergroup Options

It works with Primary Usergroup

It would be great if it worked with Additional Usergroups
Can not view when I am in Additional Usergroup.

Skyrider
04-20-2012, 06:37 AM
Is there anyway to hide the version of both browser & OS but still show what browser/OS they are using? Multiple people mentioned they prefer not to have their version to be shown for security risks/issues.

I confirm, working on 4.1.12 :)

In regards to Usergroup Options

It works with Primary Usergroup

It would be great if it worked with Additional Usergroups
Can not view when I am in Additional Usergroup.
Same issue here.

nhawk
04-20-2012, 10:22 AM
I'll see what I can do for hiding the versions and usergroups later today.

nhawk
04-20-2012, 01:10 PM
Update posted.

NOTE: If you are upgrading from version 1.0.0 or 1.0.1 to 1.0.2 or higher the usergroup options have changed. You MUST go into ACP->Settings->Options->OS/Browser Display Settings and select which usergroups CAN view the OS/Browser icons.

Skyrider
04-20-2012, 02:07 PM
Awesome, thank you! Though I just remember that it would be nice if admins (or specific group) can view the versions :p.

Mr_Running
04-20-2012, 02:25 PM
Does this change at all in version 1.0.2?
Edit: Never-mind I didn't remember that it displays on new post only. :o

If you're using DBTech's postbit tabs, create a new view with this code...
<img class="{vb:raw $post.osb_sysicon}" src="clear.gif" alt="{vb:raw $post.osb_system}" /> <img class="{vb:raw $post.osb_icon}" src="clear.gif" alt="{vb:raw $post.osb_browser}" />

And then disable the 'Put OS/Browser in Postbit' plugin.

You will be limited to using the 'Sprite' system doing this. So make sure that is enabled (it is by default) if you disabled it.

Note: I believe the ReadMe needs a date change 2011 ;) to 2012
* History (Changelog) *
------------------------------
1.0.2 - (April 20, 2011)
1.0.1 - (April 2, 2011)
March 30, 2011
1.0.0 - Initial Release

nhawk
04-20-2012, 02:58 PM
LOL.. It's 2012??!!!??

I'll correct that in the next release. :D

If you're using DBTech's posbit tabs, the view should be changed to this..
<vb:if condition="$vboptions[osb_hide]">
<img class="{vb:raw $post.osb_sysicon}" src="clear.gif" alt="" /> <img class="{vb:raw $post.osb_icon}" src="clear.gif" alt="" />
<vb:else />
<img class="{vb:raw $post.osb_sysicon}" src="clear.gif" alt="{vb:raw $post.osb_system}" /> <img class="{vb:raw $post.osb_icon}" src="clear.gif" alt="{vb:raw $post.osb_browser}" />
</vb:if>

faisaly.com
04-20-2012, 07:50 PM
Just goes to show some members do actually read the info....HAH!

Merenguista
04-20-2012, 08:36 PM
It does'nt work for me in 4.1.12 :(

Skyrider
04-21-2012, 09:22 AM
is there anyway that this can have it's own hook so I can custom place it in the template? I'd like to post it at the bottom left of the postbit.

nhawk
04-21-2012, 10:46 AM
It does'nt work for me in 4.1.12 :(

It works fine in 4.1.12..

https://vborg.vbsupport.ru/showpost.php?p=2319875&postcount=82
https://vborg.vbsupport.ru/showpost.php?p=2321349&postcount=83

As a matter of fact, the last update was done with 4.1.12.

Remember, the icons only show for new posts. There is no way to get the OS/Browser for old posts.

nhawk
04-21-2012, 10:53 AM
is there anyway that this can have it's own hook so I can custom place it in the template? I'd like to post it at the bottom left of the postbit.

I can put something like this in the next release. But, be aware that if I do this you will be responsible for proper HTML for the hook. In other words, you'll need to wrap the images in the proper <DIV>, <LI>, etc. that suits where you put it in your template.

rhody401
04-21-2012, 12:21 PM
I'm putting 1.03 in now on my 4.1.12 The previous 1.01 worked fine and I had it set up to only show the results to moderators.

I notice when people use Forum Runner, it just has ? ? Is this something that would benefit from being iconized, too, and does it pass anything meaningful along?

Thanks for the great add-on!
Rhody

nhawk
04-21-2012, 01:26 PM
I'm putting 1.03 in now on my 4.1.12 The previous 1.01 worked fine and I had it set up to only show the results to moderators.

I notice when people use Forum Runner, it just has ? ? Is this something that would benefit from being iconized, too, and does it pass anything meaningful along?

Thanks for the great add-on!
Rhody

Make sure you double check your settings. Before it was where you entered who was NOT able to see the icons. Now you need to select who CAN see the icons.

I'm not sure about forum runner. If you can get the useragent for someone using forumrunner and send it to me I can look into it.

rhody401
04-21-2012, 01:41 PM
I just checked the POST table, for users that are using Forum Runner. It is reporting them as "Unknown" "Unknown", so maybe this isnt even possible?

Your add on shows them with question marks.

I did exactly as you said (reversing the permissions), and it's working like a champ.

nhawk
04-21-2012, 03:06 PM
I just checked the POST table, for users that are using Forum Runner. It is reporting them as "Unknown" "Unknown", so maybe this isnt even possible?

Your add on shows them with question marks.

I did exactly as you said (reversing the permissions), and it's working like a champ.
The question mark icon and the 'Unknown' is the default if the system can't identify the OS and Browser.

If you can catch someone on your site using Forum Runner or arrange for them to be on your site at a certain time, do a who's online and set User Agent to 'Yes'. Then click display. That will give you the information I need to see if the icon can be included.

Merenguista
04-21-2012, 09:35 PM
It works fine in 4.1.12..

https://vborg.vbsupport.ru/showpost.php?p=2319875&postcount=82
https://vborg.vbsupport.ru/showpost.php?p=2321349&postcount=83

As a matter of fact, the last update was done with 4.1.12.

Remember, the icons only show for new posts. There is no way to get the OS/Browser for old posts.

You are right .. Now it's workin fine in 4.1.12 ..

rhody401
04-22-2012, 10:58 AM
The question mark icon and the 'Unknown' is the default if the system can't identify the OS and Browser.

If you can catch someone on your site using Forum Runner or arrange for them to be on your site at a certain time, do a who's online and set User Agent to 'Yes'. Then click display. That will give you the information I need to see if the icon can be included.

I just did it myself, to gather the info for ya:

Location:
Browsing via Forum Runner

Ip Address:
xx.xx.xx.xx
Forum Runner for Android

nhawk
04-22-2012, 01:59 PM
I just did it myself, to gather the info for ya:

That's all it says?

Nothing more like this?
Mozilla/5.0 (Windows NT 6.1) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.162 Safari/535

That's easy to add if that's the case.

It will be included in the next release.

rhody401
04-23-2012, 01:10 PM
That's all she wrote!

Thanks
-R

Alan_SP
04-25-2012, 09:15 AM
Are you sure you set UA to show? You need to specify that you want UA shown.

scottct1
04-25-2012, 05:01 PM
I installed this today on my vBulletin 4.1.11 system.

I have it showing both the OS and the Browser. If I point the the browser it shows the browser version fine, however when I point to the OS icon it shows "User Info Left" in the pop up box.

If I go into settings and have the graphics shown in a different area then it shows the info for that area but not the OS version.

How do I fix this show it shows the version of the OS they are using?

nhawk
04-25-2012, 06:11 PM
I installed this today on my vBulletin 4.1.11 system.

I have it showing both the OS and the Browser. If I point the the browser it shows the browser version fine, however when I point to the OS icon it shows "User Info Left" in the pop up box.

If I go into settings and have the graphics shown in a different area then it shows the info for that area but not the OS version.

How do I fix this show it shows the version of the OS they are using?

For now set 'Use CSS Sprites' to 'Yes'.

I'll release the fix for people not using sprites tomorrow.

scottct1
04-25-2012, 07:04 PM
For now set 'Use CSS Sprites' to 'Yes'.

I'll release the fix for people not using sprites tomorrow.

If I set CSS Sprites to Yes then the images do not show. (I am on a NGINX system instead of Apache)

scottct1
04-25-2012, 07:12 PM
If I set CSS Sprites to Yes then the images do not show. (I am on a NGINX system instead of Apache)

Nevermind? I figured they are working now with Sprites on... I had to clear XCACHE to get the Sprites to show. :)

Gn_Snake
04-26-2012, 06:32 PM
Hi,
i have installed this new version but i see nothing in postbit.
I use Vb4.1.12

nhawk
04-26-2012, 08:16 PM
Hi,
i have installed this new version but i see nothing in postbit.
I use Vb4.1.12

Did you do this and if this wasn't an upgrade make a new post?

NOTE 1: If you are upgrading from version 1.0.0 or 1.0.1 to 1.0.2 or higher the usergroup options have changed. You MUST go into ACP->Settings->Options->OS/Browser Display Settings and select which usergroups CAN view the OS/Browser icons.

NOTE 2: The icons only display in new posts. There is no way to get the OS/Browser used for old posts.

Gn_Snake
04-27-2012, 10:51 AM
I made a new post and I have enabled the user group to view, but nothing.

The previous version worked....

???
Thanks

nhawk
04-27-2012, 02:37 PM
I made a new post and I have enabled the user group to view, but nothing.

The previous version worked....

???
Thanks

Try changing 'Use CSS Sprites' to 'No' to see if that works.

If it does, then your server cache needs to be cleared.

If it doesn't and you want me to look at it, send me a temporary username and password for your admin.

Gn_Snake
04-28-2012, 12:30 PM
Yeah now Work!!...but how do i clean the cache of the server?

nhawk
04-28-2012, 07:24 PM
Yeah now Work!!...but how do i clean the cache of the server?

It all depends on what caching system you're using. The only cache system I use is xcache and that has an admin panel where you can clear the cache.

The absolute easiest way to do this would be to set the system back to use sprites and then re-boot or restart the server.

tidus78
05-01-2012, 08:51 AM
Uh don't works for my 4.1.2...

Tried suggestions over but nothing,I have a custom postbit legacy is this the problem?

nhawk
05-01-2012, 09:57 AM
Uh don't works for my 4.1.2...

Tried suggestions over but nothing,I have a custom postbit legacy is this the problem?

It could be the problem. If it doesn't include the proper posbit hooks this will not work.

Megaboost
05-01-2012, 06:37 PM
Works Great with 4.1.12 but would be nice to have a header above Images. Superb Hack! Voted for MOTM. Awesome!

adambloch
05-01-2012, 11:18 PM
I get a little problem when the I install the XML... It takes ages for it to install and when it has there is no OS in the settings... I'm on 4.1.10 pl1. It does let me unistall it and that seems to take forever..

Many thanks

Adam

hiepsi@
05-02-2012, 09:33 AM
4.1.9 no work :( plz help

hiepsi@
05-02-2012, 09:50 AM
working . :D
-> install
-> new post
-> working .

nhawk
05-02-2012, 10:04 AM
I get a little problem when the I install the XML... It takes ages for it to install and when it has there is no OS in the settings... I'm on 4.1.10 pl1. It does let me unistall it and that seems to take forever..

Many thanks

Adam

It does work with vB 4.1.10.

I don't understand what you mean by there is no OS in the settings.

Boots
05-02-2012, 01:17 PM
It's too bad Android posts don't show up as Android instead of Linux.

nhawk
05-04-2012, 09:27 PM
It's too bad Android posts don't show up as Android instead of Linux.

If you want that added, I'll need the useragent string from 'Who's Online'. Once I have that I can add it.

rhody401
05-04-2012, 11:08 PM
Last week you added ForumRunner support, and I showed you the USER AGENT at the time.

It stopped working, and now the user agent seems to have a different look:

ForumRFree 1.5.12 rv:40 (iPhone; iPhone OS 4.3.5; en_AU)

The user is on the paid version, from an iPad.

I just wanted to give you the updated info, for future consideration.

Thanks

Boots
05-07-2012, 12:38 PM
If you want that added, I'll need the useragent string from 'Who's Online'. Once I have that I can add it.

Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76I) AppleWebKit/535.19 (KHTML, like Gecko

That's Android 4.0.4 (Ice Cream Sandwich)

nhawk
05-07-2012, 09:32 PM
Mozilla/5.0 (Linux; Android 4.0.4; Galaxy Nexus Build/IMM76I) AppleWebKit/535.19 (KHTML, like Gecko

That's Android 4.0.4 (Ice Cream Sandwich)

Linux is the correct OS icon using that useragent. If you want it narrowed down, it would be a 'Mobile' icon with a Galaxy Nexus operating system and version.

The browser would be Android. ;)

Boots
05-09-2012, 11:44 AM
Android is a Linux based O/S but most people would identify it as Android. Mobile users on my forum would love to see the little Android icon next to posts they make from their Android phones :)

EliasAlucard
05-09-2012, 05:11 PM
I'm working on my own OS/Browser postbit display plugin, and it shows Android as Android (with the specific version icons, such as Froyo, Honeycomb, ICS etc.), Ubuntu as Ubuntu and so on. I'll upload it when I'm finished with it. This plugin is for vBulletin 3.8 though, not sure if it'll work with 4.x but we'll see if I can add support for vB4.

EliasAlucard
05-10-2012, 10:12 AM
By the way nhawk, do you mind if I fork this plugin and code my own version and upload it as a separate plugin? I have some disagreements on a few issues such as icon size. Also, I'll add a lot more icons for various browsers and operating systems. The plugin I'm working on now is an update/modification of the plugin Fighter1405 worked on for vB3.8 but this plugin of yours is very good with the exception of some issues I'd like to see changed.

Also, you've coded it far more complicated than it needs to be.

nhawk
05-10-2012, 12:04 PM
By the way nhawk, do you mind if I fork this plugin and code my own version and upload it as a separate plugin? I have some disagreements on a few issues such as icon size. Also, I'll add a lot more icons for various browsers and operating systems. The plugin I'm working on now is an update/modification of the plugin Fighter1405 worked on for vB3.8 but this plugin of yours is very good with the exception of some issues I'd like to see changed.

Also, you've coded it far more complicated than it needs to be.

I would prefer you didn't.

And I feel it's as complicated as it needs to be for what it does. If you disagree with that, use PMs and we'll discuss it.

Also, the system does identify Ubuntu, etc.

ejup2009
05-10-2012, 01:37 PM
Excelente hack muy vistoso y ofrece informaci?n detallada sobre el explorador..

Saludos cordiales:)

EliasAlucard
05-10-2012, 01:59 PM
I would prefer you didn't.

And I feel it's as complicated as it needs to be for what it does. If you disagree with that, use PMs and we'll discuss it.

Also, the system does identify Ubuntu, etc.Well, if we may not come to agreement, I may just install it and use my own modification of it on my forum. I'm using vB3.8.7 now though, so I'm not using your plugin.

You've done a good job in adding more browser and OS support, but it's still quite incomplete (hey, I don't blame ya, I've learned myself that this takes quite some time).

We can take it here rather than PM. For one, I don't understand why you've grouped together Windows 7 and Server 2008 R2? They are clearly distinguishable by user agent string (6.1 and 6.0) and so it's possible to separate them in the postbit information. You also don't have a specific icon for Windows 7; you're using the Vista icon.

Personally, I think the icons should be sized at least 20 on the height and 24 as a max.

I wouldn't really need to modify your plugin though. I guess all I need is to add browser/OS version support for Fighter1405's old vB3.8 plugin, in the alt text. Do I need $tmp_array, $useragent and $client_data for that?

nhawk
05-10-2012, 02:06 PM
Windows 7 and Vista do have the same logo from Microsoft. They never changed it.

So far as icon size, they are sized at 19. But if you like 20, I can't please everyone. ;)

I can't help with Fighter1405's plugin since I've never seen it and I don't know a thing about it.

datoneer
05-10-2012, 02:16 PM
Installed and nominated

EliasAlucard
05-10-2012, 02:16 PM
Windows 7 and Vista do have the same logo from Microsoft. They never changed it.

So far as icon size, they are sized at 19. But if you like 20, I can't please everyone. ;)

I can't help with Fighter1405's plugin since I've never seen it and I don't know a thing about it.Well, there are Windows 7 icons like this one:

http://www.pconline.se/wp-content/uploads/2011/07/windows7.jpg

Here's Fighter's plugin:

https://vborg.vbsupport.ru/showthread.php?t=219687

nhawk
05-10-2012, 02:22 PM
Well, there are Windows 7 icons like this one:

http://www.pconline.se/wp-content/uploads/2011/07/windows7.jpg

Here's Fighter's plugin:

https://vborg.vbsupport.ru/showthread.php?t=219687

Well, the ones I user are the ones shown on most Microsoft packaging.

And if you didn't know it the Server 2008 version numbers are the same for Windows 7 and Vista.

Windows7/Server 2008 = 6.1
Vista/Server 2008 = 6.0

And the newest is Windows 8 = 6.2

I have no intention of using my time to decode someone else add-on. If you want to change it you are on your own.

EliasAlucard
05-10-2012, 02:32 PM
Well, the ones I user are the ones shown on most Microsoft packaging.Yeah, but still, it would be like using a win2k icon for winxp if you know what I mean.

And if you didn't know it the Server 2008 version numbers are the same for Windows 7 and Vista.

Windows7/Server 2008 = 6.1
Vista/Server 2008 = 6.0

And the newest is Windows 8 = 6.2Yes, but most forum posters don't actually use Windows Server 2008 R2 so it's kind of redundant to even have that as the alt text.

I have no intention of using my time to decode someone else add-on. If you want to change it you are on your own.I can understand that. Looks like I'll be playing around with your plugin then :p

Also, you lack iOS icons and so on. I've currently done a good job with updating Fighter's plugin, but it's for vB3.8 only so I'm not sure if it's worth working any more on it.

nhawk
05-10-2012, 02:41 PM
Also, you lack iOS icons and so on.


1.0.6 - (May 10, 2012)
Add - iPhone/iPad iPhone OS


Hmmm :D

EliasAlucard
05-10-2012, 03:21 PM
Hmmm :DThat's good, although I've added icons for every Android version ;)

By the way, I was thinking... is it possible that you could add some statistics counter or something? In admincp or something that shows how many posts were made with this OS and that browser, something like that, would be nice.

Robru
05-10-2012, 04:44 PM
Thank you for this update! :)

wally07
06-23-2012, 08:57 PM
thanks for the update! :D

New Joe
07-26-2012, 03:05 PM
Strange bug which sometimes happens.
I tick the users who I want to be able to see this mod and it all works fine.
Then for some un known reason they all get set back to being un-ticked.
This has happened a few times, but one now and again.

any ideas?

nhawk
07-26-2012, 03:13 PM
Strange bug which sometimes happens.
I tick the users who I want to be able to see this mod and it all works fine.
Then for some un known reason they all get set back to being un-ticked.
This has happened a few times, but one now and again.

any ideas?

I haven't seen this on my site and nobody else has reported this.

Is it possible that someone else is resetting the usergroups without telling you?

10giay.com
07-27-2012, 07:21 AM
don't work vb 4.2.0 :(

New Joe
07-27-2012, 09:12 AM
don't work vb 4.2.0 :(

Yes it does :D

DirtRider
07-27-2012, 10:33 AM
Installed it but it will not allow me to save any of the selected Usergroups

DaveTaylor
07-27-2012, 12:20 PM
Yes it does :D

Doesn't seem to for me on 4.2.0

DirtRider
07-27-2012, 04:59 PM
Ok I got my story sorted out. I am using the Advanced Product Management and when I used this I could not save it. However if I go through the normal way Options/OS/Browser Display Settings it works 100%

nhawk
07-27-2012, 07:16 PM
Doesn't seem to for me on 4.2.0
It does work on 4.2.0. My site uses this and it is running 4.2.0.

Are you making a new post? The mod can't display the OS and Browser for old posts because that info wasn't collected when the old posts were made.

Did you upload all of the files to the proper locations?

Did you turn the mod on in ACP->Settings->Options->OS/Browser Display Settings?

Did you set the usergroups that can see the OS and Browser types? At least one usergroup for both OS and Browser must be selected.

nhawk
07-27-2012, 07:33 PM
Ok I got my story sorted out. I am using the Advanced Product Management and when I used this I could not save it. However if I go through the normal way Options/OS/Browser Display Settings it works 100%

Advanced Product Management will not work with most of my mods that set usergroups using checkboxes or radio buttons.

DirtRider
07-28-2012, 01:08 PM
nhawk on your forum it shows the Blackberry icon but when I installed it I see the ? unknown icon. Also nothing for Tapatalk at all just a blank.

nhawk
07-28-2012, 01:48 PM
nhawk on your forum it shows the Blackberry icon but when I installed it I see the ? unknown icon. Also nothing for Tapatalk at all just a blank.

I'm running the next version that hasn't been released yet.

The next time the person that isn't showing tapatalk is on, go to Who's Online and set 'User Agent' to 'Yes'. Then send me the useragent that isn't showing on your site.

EliasAlucard
08-03-2012, 08:51 AM
Okay, I've installed vB 4.2 now, a few issues:

Android isn't supported when using Firefox; only the Firefox icon is shown, and the reason for that is because Firefox doesn't show the version number of Android. Here's the UA:

Mozilla/5.0 (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0.1

Using Konqueror:

Mozilla/5.0 (X11; Linux x86_64) KHTML/4.8.4 (like Gecko) Konqueror/4.8

It shows Konqueror as 4.8.4 but isn't that the KHTML version?

When using Chromium, it shows the Chrome icon. It's possible to show the Chromium, I've done this with my plugin (https://vborg.vbsupport.ru/showthread.php?t=285373). Here's the UA for Chromium:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/12.04 Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/535.19

Moreover, the Chrome icon is the old and outdated Chrome icon (http://en.wikipedia.org/wiki/File:Chrome_Logo.svg), in my opinion, it would look better if you used the updated 2011 Chrome icon (http://en.wikipedia.org/wiki/File:Google_Chrome_2011_computer_icon.svg). And the 2011 Chromium icon.

And then there's this bug that keeps deselecting all usergroups in admincp, so basically no one can see the icons. Not sure what's causing this. Maybe installation of new plugins or something. Shouldn't be like that though, because it's a pain in the ass to select all usergroups.

If you need to identify a user agent string, you should use this site:

http://id.furud.net/

And its database is most helpful:

http://id.furud.net/showdb.php

I would also prefer if you resized the icons to 24 pixels in height, it looks better than 19. You can use my icons, I even have customised versions of Android for each major release (ICS, Honeycomb, CyanogenMod etc.) and I also have more icons than you.

nhawk
08-03-2012, 10:13 AM
Okay, I've installed vB 4.2 now, a few issues:

Android isn't supported when using Firefox; only the Firefox icon is shown, and the reason for that is because Firefox doesn't show the version number of Android. Here's the UA:

Mozilla/5.0 (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0.1

Using Konqueror:

Mozilla/5.0 (X11; Linux x86_64) KHTML/4.8.4 (like Gecko) Konqueror/4.8

It shows Konqueror as 4.8.4 but isn't that the KHTML version?

When using Chromium, it shows the Chrome icon. It's possible to show the Chromium, I've done this with my plugin (https://vborg.vbsupport.ru/showthread.php?t=285373). Here's the UA for Chromium:

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/535.19 (KHTML, like Gecko) Ubuntu/12.04 Chromium/18.0.1025.168 Chrome/18.0.1025.168 Safari/535.19

Moreover, the Chrome icon is the old and outdated Chrome icon (http://en.wikipedia.org/wiki/File:Chrome_Logo.svg), in my opinion, it would look better if you used the updated 2011 Chrome icon (http://en.wikipedia.org/wiki/File:Google_Chrome_2011_computer_icon.svg). And the 2011 Chromium icon.

And then there's this bug that keeps deselecting all usergroups in admincp, so basically no one can see the icons. Not sure what's causing this. Maybe installation of new plugins or something. Shouldn't be like that though, because it's a pain in the ass to select all usergroups.

If you need to identify a user agent string, you should use this site:

http://id.furud.net/

And its database is most helpful:

http://id.furud.net/showdb.php

I would also prefer if you resized the icons to 24 pixels in height, it looks better than 19. You can use my icons, I even have customised versions of Android for each major release (ICS, Honeycomb, CyanogenMod etc.) and I also have more icons than you.

I'll look into the Android/Firefox combination for the next release.

KHTML is the heart of Konqueror so the versioning is correct.

I'll look into Chromium for the next release.

The Chrome icon IS the new one. Look closely at it.

I've always known where to check useragents, but I am not going to run through the thousands of useragents to accomodate obscure rarely used ones. If someone reports one that is in use and not displayed, I do my best to add it.

I have no intention of increasing the size of the icons. If you want to change them on your site, that's up to you.

And I'm going to try to be nice about this. Please stop referring to 'Your' plugin in this thread, it is off topic and irrelevant to vB 4.x in this thread. In my opinion it is not your plugin, but that's up to the people at vB.org to decide. And also, please stop attempting to educate me. I have been doing this type of work since the inception of the internet. If I don't already know something, I ask.

What that boils down to in your case is... if you don't like it, uninstall it.

EliasAlucard
08-03-2012, 10:54 AM
I'll look into the Android/Firefox combination for the next release.Great.

KHTML is the heart of Konqueror so the versioning is correct.Ok, I stand corrected then.

I'll look into Chromium for the next release.Great.

The Chrome icon IS the new one. Look closely at it.No it's not. It is as a matter of fact, the old Chrome icon. How could you possibly not have noticed this?

I've always known where to check useragents, but I am not going to run through the thousands of useragents to accomodate obscure rarely used ones. If someone reports one that is in use and not displayed, I do my best to add it.I think you should. I've added support for various obscure browsers. On most forums, they're not needed because most people use the major browsers and operating systems, but on software forums for example, such obscure browsers are more common. I understand the extra work may not seem like it's worth it, but still, such plugins are all about perfection.

I have no intention of increasing the size of the icons. If you want to change them on your site, that's up to you.I could do it easily, were it not for the browser-icon-sprites.png, this makes every icon a pain in the ass to change. Is it possible to ditch the browser-icon-sprites.png? It's not used in the other plugins of this kind.

And I'm going to try to be nice about this. Please stop referring to 'Your' plugin in this thread.Why? Is there a rule here that one cannot discuss other similar plugins? I'm not promoting my plugin, I think yours is better but it does need some improvements.

In my opinion it is not your plugin, but that's up to the people at vB.org to decide. And also, please stop attempting to educate me. I have been doing this type of work since the inception of the internet. If I don't already know something, I ask.What's with the attitude? I can play this game too: this isn't your plugin either, and you should also stop taking credit for it, because you've stolen most of the source code directly from Web Browser Identifier v0.9 (http://id.furud.net/files/php_web_browser_identifier.v0.9.zip), which is licensed under the GPL, and so you're violating the GPL, yet you're acting like this plugin is all copyrighted. I have no problem acknowledging that I've modified Fighter's plugin and improved upon it a little, but most of these browser/os postbit icons share the same GPL source code. This one for example has much code in common with yours:

http://custom.simplemachines.org/mods/index.php?mod=1515

I also think I should educate you, since you didn't even notice it was the old Chrome icon you were using, which means your perception is less than impeccable.

Listen, I'm trying to help out here, and I don't like your condescending attitude. There are some things you don't know, such as the fact that you're using the old Chrome icon.

What that boils down to in your case is... if you don't like it, uninstall it.No, I like it fine. Somehow you seem to think it doesn't need improvement, or you're simply not intellectually mature enough to understand constructive criticism (this is a common problem amongst many developers though, especially Linux developers).

nhawk
08-03-2012, 11:18 AM
Ok, that's the end of this mod on vB.org.

LouiseWilson
08-03-2012, 11:23 AM
Ok, that's the end of this mod on vB.org.

I wouldn't let 1 person discourage you, you have done some good work for vb mods :), just ignore and move on in my opinion.

EliasAlucard
08-03-2012, 11:26 AM
Ok, that's the end of this mod on vB.org.That's good, I think you did the right thing in removing it, because you're simply not doing a good job. I'll improve upon "your" stolen GPL source code and modify it properly, and I'll upload it later when it's done, and of course I'll add the GPL license which you didn't. If you can't handle criticism then don't bother uploading plugins in the first place.

I wouldn't let 1 person discourage you, you have done some good work for vb mods :), just ignore and move on in my opinion.I'm not discouraging him. I was even trying to help him out, give him friendly advice, even recommended him using the icons I had spent time on resizing. I don't see how that's discouraging anything. The problem is that he has a childish and hostile mentality to any one giving him suggestions on what could be done to improve things. He could have just added two different sizes in icons, for example.

Also, it's quite pointless to remove the plugin from vbulletin.org especially when it has been downloaded 403 times, which means that someone will upload it somewhere else, if not here, then on rapidshare or similar sites. I think nhawk is behaving like a control freak over this. It's just a plugin for crying out loud.

nhawk
08-03-2012, 11:39 AM
That's good, I think you did the right thing in removing it, because you're simply not doing a good job. I'll improve upon "your" stolen GPL source code and modify it properly, and I'll upload it later when it's done, and of course I'll add the GPL license which you didn't. If you can't handle criticism then don't bother uploading plugins in the first place.

I never claimed it was all mine. As a matter of fact...
http://snogssite.com/showthread.php?349-Browser-and-OS-info-in-postbits

I don't mind suggestions, but in my opinion the level you took it to should have been done via a private discussion.

If you don't understand what the sprites are for, try looking into them. They are a good thing.

But, it's no sweat off my back. Either way, have fun.

EliasAlucard
08-03-2012, 12:03 PM
I never claimed it was all mine. As a matter of fact...
http://snogssite.com/showthread.php?349-Browser-and-OS-info-in-postbitsIf it's not all yours, then why did you act so proprietary over it when I suggested that I fork it?

I don't mind suggestions, but in my opinion the level you took it to should have been done via a private discussion.I don't see the need for that, it's better discussed here so that everyone can see.

If you don't understand what the sprites are for, try looking into them. They are a good thing.Are the sprites really needed? Like I said, the Simple Machines version doesn't use the CSS sprites, and it's working just fine.

But, it's no sweat off my back. Either way, have fun.I still think your behaviour is immature and childish. It's like, 'don't tell me what to do, don't talk to me that way, or else I'll take it down!!!!!', which is lame, and your 'don't educate me' reeks of a big ego who can't handle friendly suggestions. Chill dude, I'm just giving my two cents so that you can improve a good plugin.

nhawk
08-03-2012, 12:26 PM
Discussions are one thing, but the way you present information is like your way is the best and/or the only good way. That is not conducive to friendly discussions. And is what has resulted in me pulling this mod from vB.org. I've been around too long to put up with someone telling me that their way is better without presenting it in a civil manner and accepting my decision on if something happens or doesn't happen. Remember, the coder always has the final say no matter how much you disagree with them.

So far as sprites go, just about every page speed test around recomends using them. vBulletin itself uses them for a few things. Look into them, they are a good thing.

rhody401
08-03-2012, 02:19 PM
hang in there, nhawk. Don't be discouraged by the bratty teenager.