Question about ntegrating Google DFP asynchronous tags

[twiforum]

I'm trying to integrate DFP Google publisher asynchronous tags on our installation; which requires the following header code:

<script type='text/javascript'>
var googletag = googletag || {};
googletag.cmd = googletag.cmd || [];
(function() {
var gads = document.createElement('script');
gads.async = true;
gads.type = 'text/javascript';
var useSSL = 'https:' == document.location.protocol;
gads.src = (useSSL ? 'https:' : 'http:') +
'//www.googletagservices.com/tag/js/gpt.js';
var node = document.getElementsByTagName('script')[0];
node.parentNode.insertBefore(gads, node);
})();
</script>

<script type='text/javascript'>
googletag.cmd.push(function() {
googletag.defineSlot('/1013431/TWILike_Forum_160', [160, 600], 'div-gpt-ad-1325472136197-0').addService(googletag.pubads());
googletag.defineSlot('/1013431/TWILike_Forum_300', [300, 250], 'div-gpt-ad-1325472136197-1').addService(googletag.pubads());
googletag.defineSlot('/1013431/TWILike_Forum_728', [728, 90], 'div-gpt-ad-1325472136197-2').addService(googletag.pubads());
googletag.pubads().enableSingleRequest();
googletag.enableServices();
});
</script>

I've tried adding this code to headerinclude at the end. The first block of javascript shows up in the page source when added, but the second block doesn't show up and I get an "unclosed curly brace expression" error.

I've tried enclosed the entire code block in <vb:literal> tags. I've tried enclosing first one block and then the other. But nothing I can do will get that second block to show up.

Any advice/suggestions would be greatly appreciated...

[del Drago]

I'm having the same issue. Any help would be appreciated.

Thanks.

--------------- Added 1325956848 at 1325956848 ---------------

Okay, I think that I figured out the issue. Perhaps this will help someone else.

First, to avoid the "unclosed curly brace expression" error, the code added to the header must be enclosed in <vb:literal> tags as such:


<vb:literal>

</vb:literal>


Now for me, the reason that the second ad wasn't showing was because I had generated new tag codes after inserting the first ad.

Apparently every time that you generate tags, all of the header codes change. So... if you should generate new tags for any reason, you need to go into the headerinclude template and completely replace the header code from before.

I hope that this is helpful to someone.

[xlguy]

Is there a similar way of getting this to work on 3.8? Is there a literal tag, or any easy way of creating the same effect?

[BirdOPrey5]

Is there a similar way of getting this to work on 3.8? Is there a literal tag, or any easy way of creating the same effect?

Try escaping each single quote...

Basically use a text editor and do a find/replace

find: '
replace: \'

paste the new code into the template and try again.

[xlguy]

Hi, thanks for that but unfortunately it's not that simple (I did try after your suggestion).

I think it's to do with the {} or perhaps the fact this code uses function names?

In headerinclude I'm putting:

<script type='text/javascript'>
var googletag = googletag || {};
googletag.cmd = googletag.cmd || [];
(function() {
var gads = document.createElement('script');
gads.async = true;
gads.type = 'text/javascript';
var useSSL = 'https:' == document.location.protocol;
gads.src = (useSSL ? 'https:' : 'http:') +
'//www.googletagservices.com/tag/js/gpt.js';
var node = document.getElementsByTagName('script')[0];
node.parentNode.insertBefore(gads, node);
})();
</script>

<script type='text/javascript'>
googletag.cmd.push(function() {
googletag.defineSlot('/100XX/160sky', [160, 600], 'div-gpt-ad-XX-0').addService(googletag.pubads());
googletag.defineSlot('/100XX/728-90-inpost', [728, 90], 'div-gpt-ad-XX-1').addService(googletag.pubads());
googletag.defineSlot('/100XX/728x90', [728, 90], 'div-gpt-ad-XX-2').addService(googletag.pubads());
googletag.defineSlot('/100XX/468banner', [468, 60], 'div-gpt-ad-XX-3').addService(googletag.pubads());
googletag.pubads().enableSingleRequest();
googletag.enableServices();
});
</script>

In my templates, to call an ad (for example) 160sky, I put:

<div id='div-gpt-ad-XXXX-0' style='width:160px; height:600px;'>
<script type='text/javascript'>
googletag.cmd.push(function() { googletag.display('div-gpt-ad-XX-0'); });
</script>
</div>

Any ideas? Thanks

[BirdOPrey5]

Maybe just put the javascript in an external file and call it the usual way?

http://www.tizag.com/javascriptT/javascriptexternal.php

[brandondrury]

I got it to work by moving all the DFP code to an external .js file. I had to remove the "<script>" and "</script" tags.

Brandon