Advance edit strips br tags in 4.1.9

[paulket]

Whenever the advance edit option is used, all of the br tags in a post are being stripped (the separation between paragraphs is lost). I'm using vBulletin 4.1.9 and I have tried disabling all of my plugins but the problem still persists.

Any help in getting this fixed would really be appreciated.

[Lynne]

This is a known bug - search WYSIWYG in Jira. There is a .diff file in the report if you are able to use those.

[paulket]

Lynne, in Jira I found http://tracker.vbulletin.com/browse/VBIV-13639 and downloaded the .diff file. How would I know what should be changed in the clientscript/vbulletin_quick_edit.js file? There are no instructions to do this on Jira.

[Lynne]

You would use the .diff file to make the changes or read the diff file via a text editor and make the changes manually (- means remove the line + means add the line). You may do a search to find instructions on how to do this (on a PC) over on vbulletin.com

[paulket]

OMG, why can't they just make the corrected files available to overwrite the bad files?!?! I read what is needed to use the .diff file and while I'm not an absolute newbie to adding mods and making template edits, etc., this is way over my head and a ridiculous way of fixing a problem.

I hope it is fixed in 4.1.10 and that a stable version of 4.1.10 will be released soon.

[Lynne]

They've been providing .diff files as a way to fix a bug reported file for years now.

How to use Patch files (*.diff) for patching your vBulletin installation (https://www.vbulletin.com/forum/showthread.php/239778-How-to-use-Patch-files-%28*-diff%29-for-patching-your-vBulletin-installation)

[HMBeaty]

I hope it is fixed in 4.1.10
Since it's marked as "Approved on Staging" for 4.1.10, it should be fixed ;)

[paulket]

They've been providing .diff files as a way to fix a bug reported file for years now.

How to use Patch files (*.diff) for patching your vBulletin installation (https://www.vbulletin.com/forum/showthread.php/239778-How-to-use-Patch-files-%28*-diff%29-for-patching-your-vBulletin-installation)

Lynne, I found that explanation and it is ridiculous for vBulletin to expect their customers to do all of that to fix their broken product.

To do it manually the .diff file say to change the following in clientscript/vbulletin_quick_edit.js

- form.add_variable('message', vB_Editor[vB_QuickEditor.editorid].get_editor_contents());

to
+ form.add_variable('message', vB_Editor[vB_QuickEditor.editorid].getRawData());

Minus the - and + of course.

form.add_variable('message', vB_Editor[vB_QuickEditor.editorid].get_editor_contents()); Doesn't even exist in clientscript/vbulletin_quick_edit.js :confused:

[kh99]

I think they probably mean this:

A.add_variable("message",vB_Editor[vB_QuickEditor.editorid].get_editor_contents());


I guess the variable names get changed to one letter in the distribution to cut down the file size. (but I don't know why the diff would have 'form').

[HMBeaty]

In the same file (/clientscript/vbulletin_quick_edit.js), try changing this:
A.add_variable("message",vB_Editor[vB_QuickEditor.editorid].get_editor_contents());To this:
A.add_variable("message",vB_Editor[vB_QuickEditor.editorid].getRawData());*This has not been tested*

EDIT: Kevin posted as I was going through the file lol

[paulket]

In the same file (/clientscript/vbulletin_quick_edit.js), try changing this:
A.add_variable("message",vB_Editor[vB_QuickEditor.editorid].get_editor_contents());To this:
A.add_variable("message",vB_Editor[vB_QuickEditor.editorid].getRawData());

That fixed it! Thank you Lynne, kh99 and HMBeaty! ... That was so frustrating and such an easy fix... once what I should have figured out on my own was explained to me :o