PDA

View Full Version : Forum Display Enhancements - All Topic - Master Forums - Shows threads from multiple forums in one forum


BirdOPrey5
07-03-2010, 10:00 PM
This a complete and total upgrade to version 2.0!

New Version: 2.2

NOTE: VB 4.2.0(and over) Users DO NOT do the Manual File Edit on forumdisplay.php in the directions.

1 manual file edit is required to fix a bug where the thread count may be wrong in the master forum. Details in instructions in zip file.

You can now specify an * to denote "all forums" when creating a master forum. See instructions for details.

In addition this mod will be able to auto edit your templates if you run the standard threadbit template, otherwise there are instructions in the zip file for manual template edits if needed.

New in 2.2: Show or hide sticky threads from slave forums on the master forum.

What does this mod do? - Basically this is only the most awesomest mod ever for vBulletin. You can now view threads from other forums in "Master Forums" you designate.

For example on my site "Off Topic" is my "Master Forum" and virtually all other forums are assigned to the Master Forum offering user's the ability to browse 1 forum while seeing threads from many others.

New in version 2.0: You can now have multiple master forums.

See the screen shots for an example.

All instructions are included in the zip file.

As pointed out by phpdesk you must have at least 1 thread in your master forum for this to work.

I have tested this on VB 4.0.8 and am sure it will work on all 4.0/4.1 versions to date. There is a separate version for VB 3.x (https://vborg.vbsupport.ru/showthread.php?t=245414).

You can mostly ignore all posts in this thread up to post #25. Old posts are no longer relevant to this new version. (Note: post #7 is still relevant if you have only 1 master forum.)

------------------------------------------------------

Please "Mark as Installed" if you use this. :)
Donations always appreciated. :up:
Nominate MOTM if you LOVE it! ;)

BirdOPrey5
07-03-2010, 11:55 PM
I made an optional update to this mod...
This will give users the option of turning this mod off if they would rather not see all the forums you've chosen in a 'master' forum. Install this ONLY if you want to give users a choice.

First in Admin CP go to the menu on the left and choose "Add New User Profile Field" under "User Profile Fields."

Choose "Single Selection Radio Box" from the drop down menu...

On the next screen set the following...

Title: All Topic
Description: Use this setting to enable or disable the 'All Topics' system. [or whatever description you want obviously]
Options:
Yes
No
Field Required: Yes, at registration and...
Private/Field Searchable.../Display on... All "No"
Display Page: Options: Thread Viewing
Leave all other settings to default and hit "Save" to create the profile field.

Inform users the option now exists... The code below is designed so even if a user doesn't make a selection it is enabled by default so they only need to change it to 'opt out.'

Now we'll make the forumdisplay.php edits mentioned in the top post of this thread. Make those same edits except change all the IF statements to the one below:

if (($foruminfo[forumid] == 2) && ($vbulletin->userinfo['field5'] != "No"))

Replace the number 2 of course with the forumid of your "master" forum... Replace 'field5' with the profile field name that was auto created when added the profile field above. Go to "User Profile Field Manager" to see the name the field was given.

And that's that, you now have an "All Topics" system that can be turned on or off by each member.

BirdOPrey5
07-04-2010, 01:08 AM
One more mod I suggest if you use this is to modify your "Quick Navigation" menu to add a quick link back to your master forum, perhaps on top of your menu... to do this modify your forumjump template and add a standard html link to your master forum... Just put it wherever works best for your site and style.

Trek
07-04-2010, 05:00 AM
Kinda cool. =) I'm looking for something that allows for each user to select which ones they want. But I think that's a 3.8 mod that I haven't seen for 4.0 yet.

Anyway, nice work, I can see how this could be useful to many. =)

BirdOPrey5
07-04-2010, 05:05 AM
Thanks... working on a couple additional options for this that I have for 3.8 but going nuts on the new template variables in vb4, never saw them before today.

BirdOPrey5
07-04-2010, 03:54 PM
Thanks to the guy who rated this 1 star... :rolleyes:

sticky
07-05-2010, 05:01 AM
This would be a dream mod for me if it was possible to select the threads individually to mirror across multiple forums and not just selecting an entire forum as master.

BirdOPrey5
07-05-2010, 05:08 AM
Yeah, unfortunately that would require a database modification and new interface to use it, and it currently beyond my abilities but if I ever figure it out I will post a link here. If someone else with that knowledge wants to use this as a foundation they are welcomed to do so.

TyPenn613
07-06-2010, 02:08 AM
I apologize if this is me asking for too much, and I'm not too tech savvy to have any idea what it would take.

Can you run multiple versions of this at the same time? For instance, I run a sports site where team boards are grouped together by sport, conference/division, etc. I'd love to find a way where I could set up regional boards. As in, all the forums in the New York area are fed into one, all Chicago area into another, etc. Is this possible?

As if I'm not asking enough, I assume there is no way that a user can create a thread in the Master forum, and select it to be placed on one of the secondary forums is there?

Great work on this mod nonetheless. It's tagged and I'll likely use it.

BirdOPrey5
07-06-2010, 04:25 AM
What you ask can be done... you can have multiple 'master forums' - so a master forum for NY, one for Chicago, etc... what you can't do is filter so that some posts from one forum go to master forum "A" and other posts go to master forum "B" - but if you just need multiple master forums do the following mod to the code... I shied away from sharing this because I didn't want to make it too daunting looking for most users who only need 1 master forum.

To have multiple master forums simply add an "elseif" statement below the if { } code and above the else { } code... for example in the first edit add to the middle:

elseif ($foruminfo[forumid] == 7) {
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > $lastread AND open <> 10, 1, 0)) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid IN (7, 8, 9, 10)
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
}


This would make the entire code for the first edit look like:


//Edit added if-else statement
if ($foruminfo[forumid] == 2) {
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > $lastread AND open <> 10, 1, 0)) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid IN (2, 3, 4, 5)
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
}
elseif ($foruminfo[forumid] == 7) {
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > $lastread AND open <> 10, 1, 0)) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid IN (7, 8, 9, 10)
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
}
else {
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > $lastread AND open <> 10, 1, 0)) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
}


In this case you'd change the number 7 to your second master forum id, and 7,8,9,10 to your secondary forum id's (and your master).

You can add as many elseif { } statements as you need for various master forums, and you can even have secondary forums be shared between multiple master forums so forumid '10' for example can be a secondary forum of master forum 2 and 7, there is no problem doing this.

Once you make this elseif{} addition for the first edit you need to make similar edits for the second (optional) and third (required) edits. Just copy the entire 'if' statement for each starting with "if" and ending with "}" then copy and paste it below the if statement, change it from "if" to "elseif" and set the forum id numbers as needed.

It sounds more complicated then it is but can get messy quick if you have a lot of master forums... on the plus side conditionals are very efficient as coding goes and there should be no noticeable decrease in performance no matter how many you realistically have.

Let me know if I can be of further help... and if this isn't what you needed maybe it can at least help someone else. ;)

Ark del KAOS
07-07-2010, 11:38 AM
Bird, I don't know enough English to be able to say how much I love U...

....shit, I was trying to make this around 4 months, and only got errors.

TT_________TT

Seriously, with only this I'm going to make you a shrine with candles and all....

BUT...if you can help me with an improvement...pff, I'm going to make the fuk'n shrine in the feedback forum of my community XD
I have one forum who contain the "multiforum" threads.
From this forum I want to load some threads in some other forums.
It's like a "official threads forum" about games, but then I want to show a game for the 360 and the PS3 into de x30 forum and the PS3 one.
How do I select this? With a prefix.

Can I filter the threads depending of the thread prefix it have?
Like (select all the threads from forumid 1 or (forum2 with prefix3))

BirdOPrey5
07-07-2010, 12:06 PM
Bird, I don't know enough English to be able to say how much I love U...

....shit, I was trying to make this around 4 months, and only got errors.

TT_________TT


Seriously, with only this I'm going to make you a shrine with candles and all....

BUT...if you can help me with an improvement...pff, I'm going to make the fuk'n shrine in the feedback forum of my community XD
I have one forum who contain the "multiforum" threads.
From this forum I want to load some threads in some other forums.
It's like a "official threads forum" about games, but then I want to show a game for the 360 and the PS3 into de x30 forum and the PS3 one.
How do I select this? With a prefix.

Can I filter the threads depending of the thread prefix it have?
Like (select all the threads from forumid 1 or (forum2 with prefix3))

LOL you're very welcome... I had been looking for this for years myself and am surprised no one figured it out sooner despite multiple requests from me and others...

As for your thread prefix situation I don't know the answer off hand... let me play with some things and see what I can come up with.

Ark del KAOS
07-07-2010, 03:26 PM
LOL you're very welcome... I had been looking for this for years myself and am surprised no one figured it out sooner despite multiple requests from me and others...

As for your thread prefix situation I don't know the answer off hand... let me play with some things and see what I can come up with.
That's exactly the same thing I think about when I started searching for some kind of official addon.
And, well, the solution of adding some "if" magic to the php code who make the list its the first thing I think about...but I'm more the designer guy than the developer one, and every one told me it can't be so easy XD
So I started to try some basics with the code, but I wasn't doing any progress with it.

This is a option so useful I don't know how anyone do it earlier ^ ^

TyPenn613
07-08-2010, 11:15 AM
Bird, that's totally awesome! Thank you very much. I'm a bit behind with getting around to undertaking that plan, but once I get to it, I will be sure to give this a try and let you know how things go. Great work!

Ark del KAOS
07-08-2010, 04:50 PM
Hey crack!
To filter them by prefix, I only need to chage this ;):
WHERE forumid IN (117, 95)
AND sticky = 0
AND prefixid IN ('ps3x360', 'ps3x360wii', 'X360', 'x360wii', 'x360win')
$prefix_filter
Very simple with your base work ^ ^

halkum
07-08-2010, 08:52 PM
This is beyond awesome Bird:)

Been trying to make an add-on but having no luck.

Is there a way to prefix the forum ID's?
i.e. say forumid 7 is Gaming, foruid 8 is Offtopic. Both show in the forum but no separation. Would there be a way to auto-add prefixing of 'gaming' and 'offtopic' respectively to the threads based on the forum they came from?

My Forum's 4.0.4PL1

halkum
07-08-2010, 09:19 PM
One other thing I noticed, any idea why the Thread/Replies count on the main forum.php page doesn't update to show how many threads are inside? Or the latest thread? -- I tried rebuilding the threads, and forums counts but neither worked.

Forum's 4.0.4Pl1

BirdOPrey5
07-08-2010, 09:42 PM
This is beyond awesome Bird:)

Been trying to make an add-on but having no luck.

Is there a way to prefix the forum ID's?
i.e. say forumid 7 is Gaming, foruid 8 is Offtopic. Both show in the forum but no separation. Would there be a way to auto-add prefixing of 'gaming' and 'offtopic' respectively to the threads based on the forum they came from?

My Forum's 4.0.4PL1

You can look in the 3.8.x version thread here:https://vborg.vbsupport.ru/showthread.php?t=245414
I have a way for prefixing threads from other forums, on my forum I actually use a mini-version of each forum's status icon so it's definitely possible, unfortunately 4.0.x doesn't use the same variable names in the templates so the code doesn't work on vb4 and I don't have regular access to a 4.0 forum to play around with it, I'm on 3.8. I've got a question open in the vb4 programming section if anyone knows the 'new' ways to access those variables I'll post the code here but so far no answers,

Basically if someone could translate this to vb4 we'd be in business:
<if condition="($foruminfo[forumid] == 1) AND ($thread[forumid] != 1)">[X]</if>


One other thing I noticed, any idea why the Thread/Replies count on the main forum.php page doesn't update to show how many threads are inside? Or the latest thread? -- I tried rebuilding the threads, and forums counts but neither worked.

Forum's 4.0.4Pl1

Yeah this is because the 'real' thread is still in whatever forum it originated in so the statistics don't update- this way the same thread doesn't get counted twice. I imagine similar file edits could be the code where it tallies the number of posts and last post but again I'm sorry I don't have a working 4.0.x forum to play with, I just had temporary access to make sure the original code worked before I posted here.

halkum
07-08-2010, 10:04 PM
That's great. Not a problem, figured I'd ask! Thanks for the response. I'll check with a developer on how to translate that to vb4+ if he knows. :)

Also 'Marked as Installed'.

TurkYasam
07-23-2010, 10:15 PM
This is exactly what I want and need.. Thank you sooooooo much man.. :)
I hope we can have a admin panel controling thing for future instead of manuel editing..Whoever is going to develop this with few more extra feature, $50 bucks
I can donate..If noone has donate other than me another $50 bucks I can give..

Again, thank you sooo much BirdOPrey5..

BirdOPrey5
07-23-2010, 10:30 PM
No problem... you are welcome.

I'm working on my first 'real' mod with admin cp options and all now... If I can make this as a product I will, but in the mean time if someone else can they are free to do so and release it on their own. However my preliminary investigation so far seems that the edits needed can't be done automatically...

bigrover
10-13-2010, 01:20 AM
This looks like what I need to summarize public and private forums. What happens when a reply is posted? I assume if the user selects reply to post in the master forum it will go to the master forum. But what about a reply to a specific post? Will that go to the original forum the post came from?

BirdOPrey5
10-13-2010, 01:34 AM
If someone posts a new thread it will be created in the master forum assuming the user is viewing the master forum when they click "new thread."

If they are replying to an existing thread the post will be posted to that same thread no matter which forum that thread is from.

neverstop
10-15-2010, 03:08 PM
This is a great idea for a mod.

I have a feature suggestion if you decide to expand on this mod:

Have a UserCP section where users can choose (via checkbox maybe? or multiple select box?) which forums they want to show in the "master" forum. Maybe have it stored in $bbuserinfo (??) and add it to the WHERE forumid IN line.

Cheers, cool mod.

BirdOPrey5
10-15-2010, 04:04 PM
I've thought about using custom profile fields to choose which forums are included but as is I can't figure out how to do this code via the plugin system the resulting manual edits would probably be too complicated to follow- but there's no reason using $bbuserinfo[fieldX] in a conditional to choose which forums are part of the WHERE clause wouldn't work.

BirdOPrey5
12-22-2010, 12:10 PM
Major Upgrade On This Mod!

Totally new version is now a product file you can install, no file edits needed!

If you used the old version revert your forumdisplay.php file back to it's original condition before installing.

cyberchief
12-22-2010, 05:51 PM
AWESOME! Exactly what I was looking for!!!

phpdesk
01-16-2011, 07:29 AM
Nice mod! One quick note,

the Master forum must contain at least one personal thread for the external threads to show up in the list as well,
otherwise it will just display There are no posts in this forum message.

BirdOPrey5
01-16-2011, 02:20 PM
Nice mod! One quick note,

the Master forum must contain at least one personal thread for the external threads to show up in the list as well,
otherwise it will just display There are no posts in this forum message.

Good to know, thanks. :up:

TyPenn613
02-12-2011, 07:40 PM
Hey Bird,

This is probably wishful thinking, but if it's possible, it would be very helpful to me. Is there any way a thread icon can be set for a given forum? Essentially, so when it shows in the master forum, the icon an quickly identify the forum it's from. I'm trying to incorporate logos into my boards, and it would be a nice way to members to quickly find what they are looking for.

BirdOPrey5
02-12-2011, 10:23 PM
I do believe that is possible, in fact it is exactly what I do on my vb 3.8 forum with this mod installed...

You need a collection of icons that have file names like 2.png, 3.png, 4.png, etc... basically ForumID#.png for each forum id you have...in this example in your misc images directory but you could make it anywhere you want.

Then manually edit the threadbit template... Find a suitable location and add the code:

<img src="images/misc/{vb raw thread.forumid}.png" border="0" />


I'm not able to test it right now but I think it should work.

You can add a conditional too so if the $thread[forumid] equals $forum[forumid] you don't show any icon at all. (Because the thread is from the same forum you are viewing).

COL NIL SATIS
02-13-2011, 03:09 PM
tagged,will install later ..many thanks

Jennifer2010
04-19-2011, 08:55 PM
I'm having a weird issue with this mod.

Running on 4.1.2 patch 1

Threads displayed in master forum will only display as many threads as there are in the master forum. In other words, if there's 50 threads in the master forum, and 200 in a sub forum, it will still only show 50 threads in the master forum. It will still show sub-forum threads, but it will remove threads based on what I believe to be the last time they had activity. The missing threads from one of my sub-forums we're the oldest ones. I replied to them and then they would show up again in the master forum, which the total thread count stayed the same - so I assumed other threads were then gone missing.

Would really appreciate some help. Maybe I'm doing something wrong? :(

Thank you!

BirdOPrey5
04-19-2011, 11:07 PM
I see the issue, it is indeed a bug. I will work on a fix and post back soon.

Alan_SP
04-19-2011, 11:33 PM
Is it possible to designate one master forum to hold all forums? Something like:

76|all
or
76|0

And does this respect usergroup permissions to view certain forums, i.e. if forum is invisible to this usergroup, would thread from this forum also be invisible?

BirdOPrey5
04-20-2011, 01:02 AM
Version 2.1 Released

Full instructions in .zip file...

But basically there is now a required manual file edit- there is no way around this in order to get the thread count correct for master forums.

As Jennifer2010 pointed out the master forum would only count as many threads as were originally in the forum. This is especially an issue when the master forum contains very few threads and the slave forums contain many more threads. No page numbers (or not enough) will be produced.

The fix requires deleting 1 line from your forumdisplay.php file.

At approximately line 761 you will find this code:

($hook = vBulletinHook::fetch_hook('forumdisplay_query_thre adscount')) ? eval($hook) : false;

# Include visible IN (0,1,2) in order to hit upon the 4 column index
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads,
(
SELECT COUNT(*) AS newthread
FROM " . TABLE_PREFIX . "thread AS thread
WHERE forumid = $foruminfo[forumid]
AND lastpost > $lastread
AND open <> 10
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$totalthreads = $threadscount['threads'];
$newthreads = $threadscount['newthread'];


You must delete the 1st instance of: $hook_query_where

So your final code should look like:

($hook = vBulletinHook::fetch_hook('forumdisplay_query_thre adscount')) ? eval($hook) : false;

# Include visible IN (0,1,2) in order to hit upon the 4 column index
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads,
(
SELECT COUNT(*) AS newthread
FROM " . TABLE_PREFIX . "thread AS thread
WHERE forumid = $foruminfo[forumid]
AND lastpost > $lastread
AND open <> 10
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut

) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$totalthreads = $threadscount['threads'];
$newthreads = $threadscount['newthread'];


Save the file and replace your forumdisplay.php file with this one.

Then import/install the new product .xml file version 2.1.

NOTE- You MUST DELETE the entire line, you cannot "comment it out."

Also New in 2.1

You can now use an * to specify "ALL" forums be included in your master forum, such as:
2|*
Would make a master forum in forum id #2 that contains threads from EVERY forum on your site.

BirdOPrey5
04-20-2011, 01:07 AM
Is it possible to designate one master forum to hold all forums? Something like:

76|all
or
76|0

And does this respect usergroup permissions to view certain forums, i.e. if forum is invisible to this usergroup, would thread from this forum also be invisible?

I have added the "all" feature to the latest version 2.1. You would use * to do all forums, so from your example:

76|*

As for usergroup permissions, users will see the thread title for every thread in every forum, but they will get a permission denied error if they try to view a thread from a forum they don't have permission to view.

Jennifer2010
04-20-2011, 09:14 AM
Wow, awesome job on the super quick update! Thank you so much!

Installed now and works great :)

Some bugs to note though:

- On top of all of my forums above my header in the upper left, the forum #'s are displayed and pushes the header down.
https://vborg.vbsupport.ru/external/2011/04/23.jpg

- There also seems to be an intermediary blank white page with the forum #'s in the same place before going into a forum, which loads for 1 or 2 seconds before it hits the actual forum

Thank you!

BirdOPrey5
04-20-2011, 11:21 AM
Oh whoops. :o That's what I get for updating the software on 0 hours sleep. That's likely responsible for both issues.

I left a debug line of code in there. I have commented it out and re-uploaded the file. Same version number, please re-import the new version above OR you can manually delete the 1 line....

In the plugin All Topic Forumdisplay Thread Count find the line:

echo $alltopics ;

and erase it.

Jennifer2010
04-20-2011, 11:39 AM
That worked like a charm! Thank you so much for your hard work!

Alan_SP
04-20-2011, 12:14 PM
As for usergroup permissions, users will see the thread title for every thread in every forum, but they will get a permission denied error if they try to view a thread from a forum they don't have permission to view.

Thank you for adding option to include all forums, but this is a bit of a problem, because I don't want users to know for threads in special forums, like moderators' and admins' forums. Could you code some kind of operator that would say that I want mentioned forums excluded from all forums?

I have over 300 forums, and I need to exclude just few of them and want every other included in master forum (some kind of making it What's new forum). Is it possible?

EDIT: If you could program it to respect usergroup permissions, it would be excellent.

BirdOPrey5
04-20-2011, 01:16 PM
I have no plans to have it respect usergroup permissions for thread titles at this time. I really don't even know how to start that and more importantly, it's not a feature I conceivably would ever need myself.

However to specify just forums to exclude is an easy change.

In the TWO plugins, All Topic Forumdisplay Thread Count and All Topic Forumdisplay Threadid change the line:
$hook_query_where = "*/ WHERE forumid IN ($alltopics) AND sticky = 0 $prefix_filter $visiblethreads $globalignore $limitothers $datecut";

to

$hook_query_where = "*/ WHERE forumid NOT IN ($alltopics) AND sticky = 0 $prefix_filter $visiblethreads $globalignore $limitothers $datecut";

Basically adding the word "NOT" to the code.

Now when you specify a master forum the numbers after it will be EXCLUDED instead of INCLUDED in the master forum,
for example:
2|11,20,58

Will make 2 a master forum that includes threads from EVERY forum except 11, 20, and 58.

Alan_SP
04-20-2011, 02:13 PM
Excellent. Just to ask you, if I want to make this available in one mod, but with both including and excluding forums. how can this be made? So I could make some master forums that include forums, and have some that exclude certain forums?

Or it should be made with two mods, based on the same code, but different plugins' names? In case of two mods, could variable names be the same, just plugin names different?

Alan_SP
04-20-2011, 02:31 PM
For example, if it could be used + or - sign for including, or excluding forums instead having | sign.

So we would have something like this:

5+5,3,6,7,8
10-5,3,6,7,8

In this example forum 5 would show 5,3,6,7 and 8 forums and forum 10 would show every other forum. It would be great, and this way everything would be covered, even usergruop permissions we could manually control without problems.

BirdOPrey5
04-20-2011, 02:57 PM
As it's programmed now you can either include forums or exclude forums, you can't do both. Also making a copy of the mod probably wouldn't work either because they will both try to use the same hooks at the same time.

I will only support the mod as it is written. You are free to customize it if you understand PHP and MySQL but I can't/won't support those changes.

Alan_SP
04-20-2011, 03:19 PM
I don't understand it very well, but I'm looking at variables.

I think if I rename variables (not to conflict them) I probably could make this in two mods, one for including and one for excluding mods.

This is what I would rename:

alltopic_enable
alltopic_master
alltopics
alltop
masters
assforums

I think that just adding e in front of this variables (seraching and replacing) would make this two two mods (including and excluding) different enough. Do you think it is enough?

BirdOPrey5
04-20-2011, 03:26 PM
As I said above I don't think it will work because two mods are still going to need to try and access the same hook at the same time.

But as I also said, feel free to experiment.

Alan_SP
04-20-2011, 03:38 PM
Well, I'll try and see if it could work on my test site. If it works, I'll post here. :)

Alan_SP
04-21-2011, 07:40 PM
However to specify just forums to exclude is an easy change.

In the TWO plugins, All Topic Forumdisplay Thread Count and All Topic Forumdisplay Threadid change the line:
$hook_query_where = "*/ WHERE forumid IN ($alltopics) AND sticky = 0 $prefix_filter $visiblethreads $globalignore $limitothers $datecut";

to

$hook_query_where = "*/ WHERE forumid NOT IN ($alltopics) AND sticky = 0 $prefix_filter $visiblethreads $globalignore $limitothers $datecut";

Basically adding the word "NOT" to the code.

I just tried to modify mod to enable both including and excluding type of master forums, but I found out the main problem at the moment is in this code. For some reason, when I have this NOT added, every forum becomes Master forum showing all threads. Not only specified, but every.

Do you maybe know how to make excluding type of Master forum?

BirdOPrey5
04-21-2011, 11:57 PM
Yeah I see now it was more work than just changing the word to "NOT".

I am uploading a working "reversed" all topic in this post. In this version of All Topic you exclude forums from the master forum only. Forums not mentioned in all-topic settings work as normal.

Edited- Removed debug output from product file.

Alan_SP
04-22-2011, 06:38 AM
Yes, that's it. :up:

Now it works excellent. I merged both options (for including and excluding), removed your debugging info (appeared on top of page in excluding forums), removed option for including all forums in excluding part and I hope that everything will work as intended. :)

I tested it on my server and now everything works as far as I can tell. I had strange bug, but really strange bug when sometimes excluding forums became including ones after reinstall and where reinstalling product again helped. :eek: I'm not sure why, but I changed plugin execution order for excluding forums plugins to 6 and tried 3 times to reinstall mod and it worked all 3 times fine. If someone would have problems, just try to reinstall.

I attached modified version and BirdOPrey5 I hope you'll to use it too (and support it). :) This is really excellent mod. :up:

Only suggestion is if names of forums in threadbit could become links to these forums? This may be very useful, especially if users would like to open new threads in appropriate forums.

Cybertims
04-22-2011, 07:25 AM
Database error in vBulletin 4.1.3 Beta 1:

Invalid SQL:

SELECT COUNT(*) AS threads,
(
SELECT COUNT(*) AS newthread
FROM thread AS thread
WHERE forumid = 12
AND lastpost > 1303460427
AND open <> 10
AND sticky = 0

AND visible IN (0,1,2)



*/ WHERE forumid > 0 AND sticky = 0 AND visible IN (0,1,2)
) AS newthread

FROM thread AS thread

/*
WHERE forumid = 12
AND sticky = 0

AND visible IN (0,1,2)



*/ WHERE forumid > 0 AND sticky = 0 AND visible IN (0,1,2);

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '*/ WHERE forumid > 0 AND sticky = 0 AND visible IN (0,1,2)
) AS newthre' at line 14
Error Number : 1064
Request Date : Friday, April 22nd 2011 @ 10:21:32 AM
Error Date : Friday, April 22nd 2011 @ 10:21:32 AM
Script : *****/forumdisplay.php/12-Master-Forum
Referrer : ******/index.php
IP Address : *****
Username : ****
Classname : vB_Database
MySQL Version : 5.0.91-log

I continually get this error above as soon as I turn on the product. I have created a forum called master forum which has ID of 12, I add 12|* and always get the above error when trying to view the new forum section.

Cheers

BirdOPrey5
04-22-2011, 10:13 AM
Oh, the Master Forum needs at least 1 normal thread in it for this to work. Make a new thread before enabling the product.

Cybertims
04-22-2011, 01:08 PM
Oh, the Master Forum needs at least 1 normal thread in it for this to work. Make a new thread before enabling the product.It does have 1 normal thread in it already.

BirdOPrey5
04-22-2011, 01:43 PM
It looks like maybe you didn't make the file edit as explained in the instructions.

You must edit forumdisplay.php, find the code below and delete the line in red and then save and re-upload the file.


($hook = vBulletinHook::fetch_hook('forumdisplay_query_thre adscount')) ? eval($hook) : false;

# Include visible IN (0,1,2) in order to hit upon the 4 column index
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads,
(
SELECT COUNT(*) AS newthread
FROM " . TABLE_PREFIX . "thread AS thread
WHERE forumid = $foruminfo[forumid]
AND lastpost > $lastread
AND open <> 10
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$totalthreads = $threadscount['threads'];
$newthreads = $threadscount['newthread'];

Alan_SP
04-22-2011, 10:30 PM
Oh, the Master Forum needs at least 1 normal thread in it for this to work. Make a new thread before enabling the product.

When I tested merging including and excluding options I used only empty forums for Master forums. And it worked without any problems (well, with new code for excluding it does). So I think that you don't have to have any threads in Master forums.

Only problem is you don't see on forum display (index page) that Master forums has any threads. They show only their own threads. At least it looks like that for me...

BirdOPrey5
04-23-2011, 11:01 AM
When I tested merging including and excluding options I used only empty forums for Master forums. And it worked without any problems (well, with new code for excluding it does). So I think that you don't have to have any threads in Master forums.

Only problem is you don't see on forum display (index page) that Master forums has any threads. They show only their own threads. At least it looks like that for me...

That is true, forumdisplay won't show threads from the slave forums, only the master. I have no plans to changing this anytime soon, it would require more plugins and probably more file edits.

Alan_SP
04-23-2011, 06:45 PM
This is not problem for me. :) I'll write in forum description that there's no information about actual Master forums content and that they look inside themselves.

Master forums are excellent idea and very useful. :up:

BirdOPrey5
04-23-2011, 07:04 PM
Noted that for some reason vBulletin used a different version of forumdiplay.php on VB 4.0.7. You DO NOT need to do the manual file edit on 4.0.7, it will just work. I know you MUST do the file edit on 4.0.8 and above and 4.0.4, not sure about 4.0.5/6.

vbandroid
06-04-2011, 07:43 PM
That is true, forumdisplay won't show threads from the slave forums, only the master. I have no plans to changing this anytime soon, it would require more plugins and probably more file edits.

This is a great mod! Thanks. I was wondering if its possible to have some sort of work around for this? perhaps add a condition code to the master board, like if forum id=X, then pull stats from a,b,c. That we can manually add. I'm not very good at this but would this be possible?

vbandroid
06-04-2011, 09:39 PM
also this doesn't import stick threads from the slave forums, is their a way around this?

BirdOPrey5
06-04-2011, 10:27 PM
This is a great mod! Thanks. I was wondering if its possible to have some sort of work around for this? perhaps add a condition code to the master board, like if forum id=X, then pull stats from a,b,c. That we can manually add. I'm not very good at this but would this be possible?

No, not going to happen with this mod unfortunately.

also this doesn't import stick threads from the slave forums, is their a way around this?

This on the other hand is possible... In fact the first time I did this mod I had it show slave stickies too but then people didn't like all the stickies being shown so I took them out.

I will work on adding an option so you can choose to work with stickies or not.

Alan_SP
06-05-2011, 12:05 AM
About sticky threads, if you can make them normal (not sticky) in master forum? Is it possible?

BirdOPrey5
06-05-2011, 12:38 AM
About sticky threads, if you can make them normal (not sticky) in master forum? Is it possible?

Interesting proposal... I will have to research this.

vbandroid
06-05-2011, 04:02 PM
Thanks for getting back to us bird of prey, again fantastic mod.

BirdOPrey5
06-06-2011, 12:43 AM
Updated to 2.2. You can now choose whether to show stickies from slave forums or not. If yes they will also be sticky threads in your master forum. I wasn't able to implement the suggestion to show them as normal threads- will keep trying for that though.

Nik S
06-07-2011, 03:15 AM
I really like this mod. Thanks!

Would it be possible for threads in the master forum to link to their sub forums?

BirdOPrey5
06-07-2011, 09:16 AM
I really like this mod. Thanks!

Would it be possible for threads in the master forum to link to their sub forums?

Are you talking about where it gives the name of the forum the thread is really in? Yes that can be done... I will make it an option in the next version but in the mean time if you want to do this do the following:

Got to Admin CP -> Plugin Manager
Edit the All Topic in Threadbit Plugin
Erase all the PHP code and replace it with the following:

if ($vbulletin->options['alltopic_enable'] AND $vbulletin->options['alltopic_tempen'])
{
require_once(DIR . '/includes/adminfunctions_template.php');

$find = trim(preg_replace('#^\$final_rendered = \'(.*)\';$#s', '\\1', compile_template('{vb:rawphrase started_by_x_y_z_a, {vb:link member, {vb:raw thread}, null, \'postuserid\', \'postusername\'}, {vb:raw thread.postusername}, {vb:raw thread.startdate}, {vb:raw thread.starttime}, {vb:stylevar dirmark}}')));

if ($vbulletin->options['alltopic_ss'])
{

$replace = trim(preg_replace('#^\$final_rendered = \'(.*)\';$#s', '\\1', compile_template('{vb:rawphrase started_by_x_y_z_a, {vb:link member, {vb:raw thread}, null, \'postuserid\', \'postusername\'}, {vb:raw thread.postusername}, {vb:raw thread.startdate}, {vb:raw thread.starttime}, {vb:stylevar dirmark}}<vb:if condition="($thread[\'forumid\'] != $forbopid)">&nbsp;-&nbsp;<a href="forumdisplay.php?f={vb:raw thread.forumid}">{vb:raw thread.forumtitle}</a></vb:if>')));
}
else
{
$replace = trim(preg_replace('#^\$final_rendered = \'(.*)\';$#s', '\\1', compile_template('{vb:rawphrase started_by_x_y_z_a, {vb:link member, {vb:raw thread}, null, \'postuserid\', \'postusername\'}, {vb:raw thread.postusername}, {vb:raw thread.startdate}, {vb:raw thread.starttime}, {vb:stylevar dirmark}}<vb:if condition="!$thread[\'sticky\'] AND ($thread[\'forumid\'] != $forbopid)">&nbsp;-&nbsp;<a href="forumdisplay.php?f={vb:raw thread.forumid}">{vb:raw thread.forumtitle}</a></vb:if>')));
}
$vbulletin->templatecache['threadbit'] = str_replace($find, $replace, $vbulletin->templatecache['threadbit']);
}

Save the Plugin.

Forum names will now be linked. :)

Gripi
06-07-2011, 10:38 AM
installed.. thanks alot for this great mod

Alan_SP
06-07-2011, 02:31 PM
Excellent, this linking to forum names. :up:

I added this change to combined including and excluding master forums (attached).

BirdOPray5, if you manage to make sticky threads into normal threads, please also do excluding variant of this mod.

Nik S
06-16-2011, 04:44 PM
Forum names will now be linked. :)

Works great, thanks! :up:

8thos
06-18-2011, 04:11 AM
Wow...

8thos
06-18-2011, 05:23 AM
Version 2.1 Released

Full instructions in .zip file...

But basically there is now a required manual file edit- there is no way around this in order to get the thread count correct for master forums.

As Jennifer2010 pointed out the master forum would only count as many threads as were originally in the forum. This is especially an issue when the master forum contains very few threads and the slave forums contain many more threads. No page numbers (or not enough) will be produced.

The fix requires deleting 1 line from your forumdisplay.php file.

At approximately line 761 you will find this code:

($hook = vBulletinHook::fetch_hook('forumdisplay_query_thre adscount')) ? eval($hook) : false;

# Include visible IN (0,1,2) in order to hit upon the 4 column index
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads,
(
SELECT COUNT(*) AS newthread
FROM " . TABLE_PREFIX . "thread AS thread
WHERE forumid = $foruminfo[forumid]
AND lastpost > $lastread
AND open <> 10
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$totalthreads = $threadscount['threads'];
$newthreads = $threadscount['newthread'];


You must delete the 1st instance of: $hook_query_where

So your final code should look like:

($hook = vBulletinHook::fetch_hook('forumdisplay_query_thre adscount')) ? eval($hook) : false;

# Include visible IN (0,1,2) in order to hit upon the 4 column index
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads,
(
SELECT COUNT(*) AS newthread
FROM " . TABLE_PREFIX . "thread AS thread
WHERE forumid = $foruminfo[forumid]
AND lastpost > $lastread
AND open <> 10
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut

) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$totalthreads = $threadscount['threads'];
$newthreads = $threadscount['newthread'];


Save the file and replace your forumdisplay.php file with this one.

Then import/install the new product .xml file version 2.1.

NOTE- You MUST DELETE the entire line, you cannot "comment it out."

Also New in 2.1

You can now use an * to specify "ALL" forums be included in your master forum, such as:
2|*
Would make a master forum in forum id #2 that contains threads from EVERY forum on your site.

I am running vb4.1.4. This edit killed my forum display. I added the code back and it's fine.

Is there something different with 4.1.4 that's preventing this modification from working?

8thos
06-18-2011, 05:46 AM
Okay nevermind, that was because I used Alan SP's version.

I disabled and uninstalled his version.

I used the one in the first post. Running fine now.

kkk333
07-05-2011, 09:13 PM
thank you for this amazing mod
but does it cause extra queries ? extra load ? because I want use it in big forum

BirdOPrey5
07-06-2011, 12:40 AM
There are no extra queries- it modifies an existing query. There shouldn't be any noticeable extra load.

vbandroid
07-09-2011, 02:29 PM
Hey BirdOfPrey, any update on whether you can use prefix instead of forum id to pull threads from forums? or only to a certain prefix from the specified forums?

BirdOPrey5
07-09-2011, 11:55 PM
Hey BirdOfPrey, any update on whether you can use prefix instead of forum id to pull threads from forums? or only to a certain prefix from the specified forums?

The more I think about it the less I think I could or should integrate that into this mod. It might be possible as a separate mod but not a priority right now.

NovoCiv
07-20-2011, 02:53 PM
I'm on 4.0.5 still and the forumdisplay.php edit isn't possible. The original appears as:
($hook = vBulletinHook::fetch_hook('forumdisplay_query_thre adscount')) ? eval($hook) : false;

# Include visible IN (0,1,2) in order to hit upon the 4 column index
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads, SUM(IF(thread.lastpost > $lastread AND open <> 10, 1, 0)) AS newthread
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$totalthreads = $threadscount['threads'];
$newthreads = $threadscount['newthread'];

Removing the $hook_query_where causes database errors. I tried replacing the entire section with the "this is what your code should look like" and the forums run fine until I enable the product. When enabled, it causes this error on forumdisplay:

vBulletin Message
Unable to add cookies, header already sent.
File: /home/novoci5/public_html/forums/vb/exception/templatefatalerror.php
Line: 67

Is there a way to make this work without upgrading?

BirdOPrey5
07-20-2011, 04:06 PM
In 4.0.5 try just using the original forumdisplay.php without any edits at all.

RollaJedi
07-20-2011, 04:14 PM
any way to make this a widget for the 'home' page possibly?

NovoCiv
07-20-2011, 07:23 PM
In 4.0.5 try just using the original forumdisplay.php without any edits at all.

When I do this it also gives the cookie error.

BirdOPrey5
07-21-2011, 08:54 AM
any way to make this a widget for the 'home' page possibly?

I've never tried making a widget before but I'd imagine there has to be a "recent threads" widget that would do basically the same thing, no?

When I do this it also gives the cookie error.

I just verified 4.0.5 and if you use the original forumdisplay.php with no edits it should work fine. My guess is you "undid" the edits instead of used the original forumdisplay.php without any edits.

You can get it from your original vbulletin zip file or worst case you can download a new copy from the member's area.

Sometime text editors (like notepad) can mess up the files you try to edit with them.

That's my guess as to why you get the cookie error- it's usually the result of a blank line or other blank character at the top of the file.

NovoCiv
07-23-2011, 04:17 AM
I discovered the error was because of the template edit option. Disabling the option and manually editing the templates worked. Now the product works as desired. Thanks and 5 stars :)

Kraxell
07-23-2011, 06:36 AM
Hello,

is it possible to choose other forums by myself? Maybe a friend-board installed this hack too and i get this hack to work with my and friend-board?

BirdOPrey5
07-24-2011, 12:44 PM
I discovered the error was because of the template edit option. Disabling the option and manually editing the templates worked. Now the product works as desired. Thanks and 5 stars :)

Great news! :up:

Hello,

is it possible to choose other forums by myself? Maybe a friend-board installed this hack too and i get this hack to work with my and friend-board?

I don't really understand the question. This mod will in no way ever be able to help you see forums on another totally different forum.

Try the vBNetwork (https://vborg.vbsupport.ru/showthread.php?t=245942) mod to share forums with a friend.

Kraxell
07-24-2011, 08:22 PM
Ah ok, i though it have other functions :)

Bjoern28
08-09-2011, 07:25 AM
Hi,

have installed that great MOD :) Thanks for this..

But a question..

I created a Master Forum that holds some of my other Forums. So all is fine.. :)

Masterforum
-offtopic
-new Members

so the posts of offtopic and new members are displayed in the masterforum

when i go now to off topic and create a new thread... or answer to an existing thread..

and go now to the Forumdisplay where all my forums are displayed.. ^^ i see not in the Masterforum that there are new threads in offtopic... i see this when i go IN the Masterofurm. But i want to see it also in the forum display..

do you know what i mean?

It would also be great if the Masterforum displays in the forumdisplay the number of threads and posts from all the forums it holds.

And th next question i have.. it is not possible to post new threads in a Master Forum...
Of course i can post a thread.. but it is not visible in the threaddisplay...

BirdOPrey5
08-09-2011, 10:35 AM
Hi,

have installed that great MOD :) Thanks for this..



You're welcome. :up:



But a question..

I created a Master Forum that holds some of my other Forums. So all is fine.. :)

Masterforum
-offtopic
-new Members

so the posts of offtopic and new members are displayed in the masterforum

when i go now to off topic and create a new thread... or answer to an existing thread..

and go now to the Forumdisplay where all my forums are displayed.. ^^ i see not in the Masterforum that there are new threads in offtopic... i see this when i go IN the Masterofurm. But i want to see it also in the forum display..

do you know what i mean?

It would also be great if the Masterforum displays in the forumdisplay the number of threads and posts from all the forums it holds.

And th next question i have.. it is not possible to post new threads in a Master Forum...
Of course i can post a thread.. but it is not visible in the threaddisplay...

I understand what you mean but I do not intend to add any of these features. It works how I intended it to work.

Bjoern28
08-09-2011, 10:53 AM
hmm is it possible to add the feature that i can see in the forumdisplay that in the master forum (offtopic) are new threads?

BirdOPrey5
08-09-2011, 12:17 PM
hmm is it possible to add the feature that i can see in the forumdisplay that in the master forum (offtopic) are new threads?

I suppose anything is possible, it would mean new queries on forumdisplay. It's not something I will do though- you would have to find someone else willing to code it that way.

0ptima
08-09-2011, 09:17 PM
I;d like to see this mod in action. please post/pm me a link where I could see this.

BirdOPrey5
08-10-2011, 03:34 PM
I have the 3.8 version in action on my forum, but you need to register to see it in action-

Specifically it's my "off topic" forum which is my master-forum:
http://www.juot.net/forums/forumdisplay.php?f=2

I also added a custom image to distinguish each forum from the main off-topic forum, instead of the text saying the source forum name.

If anyone else is using the 4.x version and wants to post a link, feel free.

rootzwiki
08-17-2011, 08:55 PM
Great mod, however i've noticed that when viewing my forum with a program such as Forum Runner or Tapatalk that the master forums do not show threads from the slave forums.

Are there any modifications i could do on my side to get this working in app? or is that all up to the app developer.

BirdOPrey5
08-17-2011, 09:40 PM
It would require modification of their files- so it's not something I'm going to attempt. I really don't know where to start with either of them.

Cybertims
08-18-2011, 08:40 AM
Is this supposed to show the total number of threads and posts on Forumhome since for me it is only showing 1 Thread and 1 Post, this is the 1 thread I created in there to make it all work.

Cheers

BirdOPrey5
08-18-2011, 11:20 AM
no, it doesn't affect forumhome.

Cybertims
08-18-2011, 01:37 PM
no, it doesn't affect forumhome.Ahh, it is deceiving though when members see there is only 1 thread and 1 post in the Master Forum, until you click in there and see the list. Would it not be a good idea to have it calculate the total threads and posts in the entire Master or maybe remove the number of threads and posts from the Master Forum altogether?

Cheers for the Mod

BirdOPrey5
08-18-2011, 01:47 PM
Ahh, it is deceiving though when members see there is only 1 thread and 1 post in the Master Forum, until you click in there and see the list. Would it not be a good idea to have it calculate the total threads and posts in the entire Master or maybe remove the number of threads and posts from the Master Forum altogether?

Cheers for the Mod

My master forum has thousands of threads anyway so it was never really an issue for me. Perhaps something in the forum description explaining there are more threads than it appears.

This has been discussed a number of times and I can understand why people would want this but the fact is it would be a far more complicated and resource intensive mod to do those extra calculations. It's not something I plan on adding.

Cybertims
08-19-2011, 05:07 PM
My master forum has thousands of threads anyway so it was never really an issue for me. Perhaps something in the forum description explaining there are more threads than it appears.

This has been discussed a number of times and I can understand why people would want this but the fact is it would be a far more complicated and resource intensive mod to do those extra calculations. It's not something I plan on adding.I just added some code to show this instead.....

http://www.monthehoops.co.uk

BirdOPrey5
08-19-2011, 05:40 PM
I just added some code to show this instead.....

http://www.monthehoops.co.uk

I like it!

Conehead555
08-20-2011, 10:18 PM
....

BirdOPrey5
08-20-2011, 10:28 PM
Wrecked my forum, no check boxes next to threads now.

Probably an incompatibility with a custom style...

If you still have it installed simply turn off the automatic template edit in the settings: Enable Threadbit Template Edit -> No.

That will fix your issue- you will have to make the template edit manually if you want to see the name of the source forums.

Conehead555
08-20-2011, 10:34 PM
.....

BirdOPrey5
08-20-2011, 10:39 PM
This mod doesn't make ANY changes to the database or your files... Just disable or uninstall the entire mod then.

BTW what version of vBulletin are you using?

Conehead555
08-20-2011, 11:43 PM
My mistake, duh. Installed - 5 stars - great mod! :)

Sarab
09-12-2011, 06:16 PM
Hello,

I tried installing it and do as I should in the editing but when I enable it and open the master forum I get database error, I'm using vb 4.1.5, so is their a solution?

BirdOPrey5
09-12-2011, 06:29 PM
I have this running on a 4.1.5 forum without issue. If you are getting a database error it is most likely because of a mistake when making the file edit. If you post the exact database error I might be better able to diagnose the problem.

shuangddr
09-12-2011, 11:52 PM
my god.
thank you,i am looking for this

Sarab
09-13-2011, 09:50 AM
I have this running on a 4.1.5 forum without issue. If you are getting a database error it is most likely because of a mistake when making the file edit. If you post the exact database error I might be better able to diagnose the problem.
I thought so but can't find where I went wrong =\

But somehow I tried today and it worked XD

Thank you for this great mod I wanted it for years now, really thank you =)

BirdOPrey5
09-13-2011, 11:04 AM
my god.
thank you,i am looking for this

Thanks. Please "Mark as Installed" if you are using this.

I thought so but can't find where I went wrong =\

But somehow I tried today and it worked XD

Thank you for this great mod I wanted it for years now, really thank you =)

Great to hear. Please "Mark as Installed" in the top post. :up:

8thos
10-10-2011, 06:18 PM
This is the most important modification on my site. I always make sure this mod is working first after upgrades.

vbresults
10-18-2011, 11:40 AM
Hey BOP,

I was looking for a way to do this for my product site and found your mod. I was sort of confused by the code so I ended up writing my own plugins, but seeing as this mod came from 3.x, the code might just be a little out of date. Anyway, below is how I did it. It requires three plugins and does not need a post in the master forum; it also displays the post counts correctly etc.

hook: forumdisplay_start

if (in_array($foruminfo['forumid'], $masterForums)) {
// *Tell* the forum it will contain threads! >=)
$foruminfo['cancontainthreads'] = true;
}


hook: forumdisplay_query_threadscount


if (in_array($foruminfo['forumid'], $masterForums)) {
$childForums = implode(', ', $foruminfo['childlist']);

// Add an OR IN(children) condition and the default thread count query ones.
$hook_query_where .= "OR forumid IN($childForums)
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut";
}


hook: forumdisplay_query_threadid

if (in_array($foruminfo['forumid'], $masterForums)) {
$childForums = implode(', ', $foruminfo['childlist']);

// Same deal for the thread id query.
$hook_query_where .= "OR forumid IN($childForums)
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut";
}


Here (http://lancerforhire.com/forums/forumdisplay.php?15) it is in action. Hope you found this useful!

BirdOPrey5
10-18-2011, 03:08 PM
Very cool way of doing thins, Lancer. :up:

8thos
10-18-2011, 04:07 PM
I'll pay for this on xenforo.

8thos
10-18-2011, 04:09 PM
I don't see the all topics mod in that link @ Lancer.

vbresults
10-18-2011, 05:32 PM
I'll pay for this on xenforo.

I've added it to my list. Whatever happened to getting that live topic mod? :p

I don't see the all topics mod in that link @ Lancer.

All topics mod?

BirdOPrey5
10-18-2011, 05:46 PM
I apreciate Lancer's code and I understand your desire for an All Topic mod for XenForo Octavius, but please keep discussion of XenForo mods on XenForo's or Lancer's own forum thanks.

This thread is for discussion of this vBulletin modification.

shuangddr
11-05-2011, 03:16 PM
I want to show threads also from user's subscribed forums,can you add this features?

BirdOPrey5
11-06-2011, 10:04 AM
I would have to look into it- it would be a pretty significant change.

Wakey
11-13-2011, 02:02 PM
When I click a thread on the master forum the breadcrumb is showing as

Forum > Slave Forum > Slave Thread

Should it be like this or should it be

Forum > Master Forum > Slave Thread

When visiting a Slave Thread from the Master forum I would really like the breadcrumb to show its on the master forum rather than slave forum. If its not designed to allow this then does anyone have any idea of what I would need to change to sort this (or if it's supposed to be working like I want what am I dong wrong)

Alan_SP
11-18-2011, 12:29 AM
Correct is: Forum > Slave Forum > Slave Thread

Because thread is in slave forum, not master. Master forum is just place where you can see all threads from selected forums, but not where they really are.

BirdOPrey5
11-19-2011, 06:09 PM
When I click a thread on the master forum the breadcrumb is showing as

Forum > Slave Forum > Slave Thread

Should it be like this or should it be

Forum > Master Forum > Slave Thread


When visiting a Slave Thread from the Master forum I would really like the breadcrumb to show its on the master forum rather than slave forum. If its not designed to allow this then does anyone have any idea of what I would need to change to sort this (or if it's supposed to be working like I want what am I dong wrong)

That's how it works, you're not doing anything wrong. The "Master" forum is more of a virtual forum, most threads usually do not really belong in it.

Wakey
11-24-2011, 12:24 AM
That's how it works, you're not doing anything wrong. The "Master" forum is more of a virtual forum, most threads usually do not really belong in it.

Let's say I wanted it to show the other way if a user has clicked the link from the master forum, anyone any idea how I would do this?

BirdOPrey5
11-25-2011, 06:54 PM
No.

swatirajawat
12-01-2011, 08:52 AM
hi
i want to add widget for user where they can subscribe for newsletter, only 2 fields for email and name so that they can get newsletters on subscribing here.
i have searched for newsletter and i got 2 mods community newsletter and newsletter manager but i did not get any widget mod for what i need how can i make it.
help me please.
.thank you.

BirdOPrey5
12-02-2011, 06:29 PM
That doesn't seem to have anything to do with this mod. Please make a thread in an appropriate forum.

taffy056
12-03-2011, 03:54 PM
The file forumdisplay.php is different to the one you are showing in 4.1.8 , when I take out the "$hook_query_where" as advised, it throws a database error, is there a fix for that ? thanks

qpurser
12-03-2011, 03:59 PM
I was hoping to get this great mod working in my 4.1.5 but ran into an issue.
I followed the instructions from the readme.txt.
Below is the error I got and also how my forumdisplay.php looks.
What could be wrong?
Thanks for any help

Database error:
Database error in vBulletin 4.1.5:

Invalid SQL:

SELECT COUNT(*) AS threads

FROM thread AS thread

/*
WHERE thread.forumid = 198
AND sticky = 0

AND visible IN (0,1,2);

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '/*
WHERE thread.forumid = 198
AND sticky = 0

AND visible IN (0,1,2)' at line 9
Error Number : 1064
Request Date : Saturday, December 3rd 2011 @ 10:53:10 AM
Error Date : Saturday, December 3rd 2011 @ 10:53:10 AM

and my forumdisplay.php:

$hook_query_fields = $hook_query_joins = $hook_query_where = '';
($hook = vBulletinHook::fetch_hook('forumdisplay_query_thre adscount')) ? eval($hook) : false;

# Include visible IN (0,1,2) in order to hit upon the 4 column index
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE thread.forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut

");
$totalthreads = $threadscount['threads'];

$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS newthread
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE thread.forumid = $foruminfo[forumid]
AND thread.lastpost > $lastread
AND open <> 10
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$newthreads = $threadscount['newthread'];

BirdOPrey5
12-05-2011, 10:16 AM
If your forumdisplay.php looks different try it without making any file edits.

qpurser
12-05-2011, 11:41 AM
If your forumdisplay.php looks different try it without making any file edits.

Thank you so much for the help.
I followed your suggestion and didn't edit the forumdisplay file.
Works great now

BirdOPrey5
12-05-2011, 02:27 PM
Great. Please mark as installed. :up:

taffy056
12-05-2011, 11:52 PM
If your forumdisplay.php looks different try it without making any file edits.

yeah thanks that works, can I ask without sounding stupid, why have the file edit if it works without it ?

BirdOPrey5
12-06-2011, 07:43 PM
yeah thanks that works, can I ask without sounding stupid, why have the file edit if it works without it ?

Different versions of 4.x have different versions of forumdisplay.php. In VB 3.8 they had the old version that didn't need the file edit. Then they changed to a "new" version that needed a file edit. Then they changed back for 1 release to the old version. Then they changed again to "new" version and there were several releases that needed the edit- I thought they were done making changes. Apparently not, as of 4.1.7 or so they are back to the old version again.

Diana Notacat
03-17-2012, 04:43 PM
I seem to have a problem in 4.1.11

Where I DO edit forumdisplay.php I have the same problem as this post (https://vborg.vbsupport.ru/showpost.php?p=2274346&postcount=129).

But when I DON'T edit I get this error:

Invalid SQL:

SELECT attachment.attachmentid, attachment.dateline
FROM attachment AS attachment

WHERE attachment.contentid =

LIMIT 1;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LIMIT 1' at line 6
Error Number : 1064

Help is very much appreciate! :D

BirdOPrey5
03-17-2012, 08:59 PM
You definitely do not need a file edit on 4.1.11

I am running it fine on 4.1.11.

That error isn't even with a query used by this mod- I suggest restoring your forumdisplay.php file from a backup or the original vBulletin download zip, because it should work with the default file.

Diana Notacat
03-18-2012, 12:45 PM
Thank you for the quick response!

I tested it on on a default test forum, and you are correct. So I had to go through all my modifications to find out which one it was clashing with.

Apparently it can't work if you have the Chiplove.9xpro - Thread Thumbnails 2.2.9 (https://vborg.vbsupport.ru/showthread.php?t=270794) mod installed.

I'll see if I can find a way to work around it.

BirdOPrey5
03-18-2012, 01:29 PM
Thanks for the updated. I actually just tried that mod on my test forum (which is still 4.1.10) to see if I could troubleshoot, but I can't recreate the database error. I tried making sure there were attachments in threads and tried the various options for the 9xpro mod, but just can't get the database error to appear.

From your original error I see the line is from a query in the 9xpro mod:
WHERE attachment.contentid = ".$thread['firstpostid']."

So for some reason $thread['firstpostid'] is empty...

$thread is getting passed into the function but I wonder if a possible fix would be to simply make $thread global in the function instead. I had hope to test this but without getting the error I can't really confirm.

cagbaazee
03-21-2012, 08:30 PM
Hi, i am just new to this mod.. You mean that i can get other threads from other forums site and it automatically post here, or it is manual. What about username and password from other forums to be access and post the thread here in my master forum. Do reply asap. Thanks

BirdOPrey5
03-21-2012, 11:06 PM
Hi...
No, not from other domains...

From multiple forums on your OWN forum....

Like here- you could get "vBulletin.org Site Feedback" and "Community Lounge" and "Community Reviews" to all show in the "vBulletin Pre-Sales" forum if you wanted.

Sorry for the confusion.

cagbaazee
03-22-2012, 02:53 AM
Hi.. No problem.. But yr Image say that we can get it from other forums. Anyway, if u hv these type of mod which can import threads from other forums, that would be very wonderful.

BirdOPrey5
03-22-2012, 11:32 AM
Yeah it's because "forum" can refer to both an entire site- or specific forums on the site.

This mod, vBNetwork, allows you to share forums with other sites: https://vborg.vbsupport.ru/showthread.php?t=245942

I've seen sites use it, it needs a little work but it's a great start. Of course it needs the other forum admin's to install it too- importing data from another forum without permission wouldn't be ethical.

shuangddr
04-23-2012, 03:30 PM
hi,how to make other forum title clickable?

BirdOPrey5
04-24-2012, 11:55 AM
I haven't tested this but edit the plugin "All Topic in Threadbit."

Find the code:
{vb:raw thread.forumtitle}

There are 2 instances of it.

Replace BOTH with this:

<a href="forumdisplay.php?f={vb:raw thread.forumid}">{vb:raw thread.forumtitle}</a>

ProFifaLeagues
06-10-2012, 10:30 PM
Bop Would this work for 4.2??
If So are the Edits still needed as well sir?

Jennifer2010
06-10-2012, 10:41 PM
Bop Would this work for 4.2??
If So are the Edits still needed as well sir?

I upgraded to 4.2 and it's working fine for me

BirdOPrey5
06-11-2012, 10:37 AM
It will work on 4.2.0 with NO FILE EDITS! :up:

ProFifaLeagues
06-11-2012, 10:57 AM
It will work on 4.2.0 with NO FILE EDITS! :up:



Worked A1 thanks Joe,Very handy to have this one mate.

Akyeame Kwame
06-17-2012, 11:13 AM
Hello, I'm getting this error. I originally tried the file edits then came to the end page and saw that file edits. Both ways gave me the same DB error. Any idea what may be causing it?

I'm using my open forum ID 855 like this

855|*
I'd like all the forums to display.

Database error in vBulletin 4.1.11:

Invalid SQL:

SELECT COUNT(*) AS threads,
(
SELECT COUNT(*) AS newthread
FROM thread AS thread
WHERE forumid = 855
AND lastpost > 1339934749
AND open <> 10
AND sticky = 0

AND visible IN (0,1,2)



*/ WHERE forumid > 0 AND (sticky = 0 OR sticky = 1) AND visible IN (0,1,2)
) AS newthread

FROM thread AS thread

/*
WHERE forumid = 855
AND sticky = 0

AND visible IN (0,1,2)



*/ WHERE forumid > 0 AND (sticky = 0 OR sticky = 1) AND visible IN (0,1,2);

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '*/ WHERE forumid > 0 AND (sticky = 0 OR sticky = 1) AND visible IN (0,1,2) ' at line 14
Error Number : 1064
Request Date : Sunday, June 17th 2012 @ 08:09:49 AM
Error Date : Sunday, June 17th 2012 @ 08:09:50 AM
Script : http://www.**********.com/forums/forumdisplay.php?f=855
Referrer : http://www.************.com/forums/forum.php
Classname : vB_Database
MySQL Version : 5.1.61

BirdOPrey5
06-17-2012, 01:27 PM
4.1.11 shouldn't need any file edits. Restore your original forumdisplay.php file.

Datenpapst
06-17-2012, 04:41 PM
Is it possible to add forums from other servers/other boards?

BirdOPrey5
06-18-2012, 12:47 PM
No not with this mod.

Check out this one for sharing boards across different forums (domains): https://vborg.vbsupport.ru/showthread.php?t=245942

BrettJC
08-05-2012, 01:06 AM
Is it possible to color threads based on there original forumid, so if I have 3 forums and 1 master forum can I have all treads from forum 1 show blue and all threads from forum 2 show red etc

thenoob2012
08-05-2012, 08:42 AM
Just installed your mod and it is exactly what I was looking for. I only have one question and it is how do I get it to update thread count. No matter how many threads are posted in master forum it only says there is one and the one it is referring to is the one I actually made in the master forum.

Is there anyway to fix this. I am running the newest VB forum. Thanks is advance.

BirdOPrey5
08-05-2012, 01:49 PM
Is it possible to color threads based on there original forumid, so if I have 3 forums and 1 master forum can I have all treads from forum 1 show blue and all threads from forum 2 show red etc

Possible but not something I have coded. If you are interested in trying yourself you'd start in the plugin called All Topic in Threadbit and add a custom edit for when the thread[forumid] matches the forum[forumid].

Just installed your mod and it is exactly what I was looking for. I only have one question and it is how do I get it to update thread count. No matter how many threads are posted in master forum it only says there is one and the one it is referring to is the one I actually made in the master forum.

Is there anyway to fix this. I am running the newest VB forum. Thanks is advance.

Again possible but complicates the mod much more by needing changes to even more queries and it is simply not something I have attempted at this point.

If you read through this thread it was discussed before, a long time ago- I forget if anyone posted a solution or not.



This mod is probably due for an overhaul... I will look into a fresh rebuild of this mod and see which features I can add. No promises of how soon though.

BrettJC
08-06-2012, 04:51 AM
Thanks Joe, I will see what I can do, i will post here if i get it working.

thenoob2012
08-06-2012, 08:31 PM
Thanks for getting back with me.

vbresults
10-22-2012, 08:32 PM
This mod is probably due for an overhaul... I will look into a fresh rebuild of this mod and see which features I can add. No promises of how soon though.

hook: forumdisplay_start

if (in_array($foruminfo['forumid'], $masterForums)) {
// *Tell* the forum it will contain threads! >=)
$foruminfo['cancontainthreads'] = true;
}


hook: forumdisplay_query_threadscount


if (in_array($foruminfo['forumid'], $masterForums)) {
$childForums = implode(', ', $foruminfo['childlist']);

// Add an OR IN(children) condition and the default thread count query ones.
$hook_query_where .= "OR forumid IN($childForums)
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut";
}


hook: forumdisplay_query_threadid

if (in_array($foruminfo['forumid'], $masterForums)) {
$childForums = implode(', ', $foruminfo['childlist']);

// Same deal for the thread id query.
$hook_query_where .= "OR forumid IN($childForums)
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut";
}


;-)

Harpo
11-12-2012, 11:04 AM
Hi I'm interested in this mod. I have not installed it yet...I was wondering How to do this.

I want to make the Master forum Thread listing as my "Index" So my members can browse the listings of threads collected.

Maybe have the Master Forum Thread listing located in my NAV menu. of course members can choose "forum" too from the NAV. to see the normal view.... If I'm making any sense. :P

Would this be possible with this mod?

Harpo
11-12-2012, 10:50 PM
Hi again, Just installed it and followed the instructions. I made my master forum and set it up in my ACP. now when I try to enter the master forum I get the following Database error.

Database error in vBulletin 4.2.0:

Invalid SQL:

SELECT COUNT(*) AS threads

FROM thread AS thread

/*
WHERE thread.forumid = 35
AND sticky = 0

AND visible IN (0,1,2);

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '/*
WHERE thread.forumid = 35
AND sticky = 0

AND visible IN (0,1,2)' at line 9

My masterforum ID is 35. Any idea what went wrong?

m3rl1n
12-20-2012, 04:38 PM
Joe how can i get sub forum category icons displaying on the master forum? Tried everything.

BirdOPrey5
12-20-2012, 04:56 PM
Hi again, Just installed it and followed the instructions. I made my master forum and set it up in my ACP. now when I try to enter the master forum I get the following Database error.

Database error in vBulletin 4.2.0:



My masterforum ID is 35. Any idea what went wrong?


Not sure if you're still having the issue but if so what version of VB are you using? You probably do NOT need to make the file edit. Restore the original forumdisplay.php file.

Joe how can i get sub forum category icons displaying on the master forum? Tried everything.

I don't understand the question... What are category icons? Screenshot?

m3rl1n
12-20-2012, 05:14 PM
Joe all i get is the default status icon see attached image even though in forum display on forums it shows my custom icons for each sub forum but in the master forum created doesn't appear to inherit these icons from forum display along with thread titles etc.

Great product but why goto all the work of creating forum and sub forum icons if master forum display won't show them :-( Great for it to show the sub forum or forum icon instead of thread status icon. Or even the option to choose to use thread status icons or use forum icons.

BirdOPrey5
12-20-2012, 05:37 PM
Are those these icons? (on forumdisplay.php?)

If so how are you setting custom ones per forum?

In forum manager the only option I see for custom icons is for custom status icons.

m3rl1n
12-20-2012, 05:40 PM
setting the icon under Style Options

Prefix for Forum Status Images (This prefix will be used on status image filenames for a forum, it can only contain A-Z, 0-9, -, _, . and /)

Just add the location of the icon on a forum by forum basis. They show on for display but master forums doesn't show them.

BirdOPrey5
12-20-2012, 05:42 PM
Right but in that case it's the same icon used everywhere on the site, right? Unless you have a specific style set for each forum?

m3rl1n
12-20-2012, 06:40 PM
yes, its same icon used for everything within that forum subforum

BirdOPrey5
12-20-2012, 07:08 PM
But is it a style being used for that forum/sub-forum or some other way you set it unique by forum? This mod isn't going to look at custom styles to pull the icons from that style if that is what you are asking- sorry- that was never something it was intended to do.

m3rl1n
12-20-2012, 07:19 PM
Same using default style, i have set icons in default and in a custom style and master forums doesn't pull from either or any just shows default thread status icon.

As suggested above if at all possible maybe an option in master forums to tell it too use forum or sub forum icons.

Maybe its just not possible but had to ask.

BirdOPrey5
12-20-2012, 10:46 PM
On vBulletin.com you posted this:

Sorry joe you did but he was vague. Once master forums is set up and you have all your threads listing under your delegated master form ID ( working and is great) it only displays the default VB status icon, at a loss to get it too display the custom icon i have set for each forum under forum manager that is set for each forum/category. Possible to have the ability for it to display forum/category icons rather than default status icon. Product addon or even code work around.

Emphasis mine because this is what I am confused about. Maybe I am missing something or maybe the icons I posted earlier were NOT what you are talking about. In Forum Manager the only option I see is for STATUS ICON PREFIX. A Status Icon is the image next to the forum on forum.php. That is different then the icons I circled in the image above which are the icons displayed next to each thread on forumdisplay.php.

What is confusing me is it looks like you are asking for custom images next to each thread when there is no native VB setting I know of for custom thread icons (per forum), only forum icons.

If you wanted the custom forum status icon I understand that being unique but no where in vBulletin does that icon ever show up next to a thread.

m3rl1n
12-21-2012, 10:44 AM
Joe think little confusion on both parts maybe mainly caused by me, I know vb has never displayed the icons try keep it simple as confusion maybe as before my fault. Think basically i was asking "if" it was possible for the threads showing on master forum to show the forum icons from the forum the threads originate from?

Once again sorry for the confusion.

Eagle Eyes
02-21-2013, 09:24 AM
How do i make the forum name clickable to that forum below the thread name in forumdisplay?

BirdOPrey5
03-03-2013, 12:02 PM
Joe think little confusion on both parts maybe mainly caused by me, I know vb has never displayed the icons try keep it simple as confusion maybe as before my fault. Think basically i was asking "if" it was possible for the threads showing on master forum to show the forum icons from the forum the threads originate from?

Once again sorry for the confusion.

If it is, I am not sure how. I don't think it would be easy.

How do i make the forum name clickable to that forum below the thread name in forumdisplay?

Edit the All Topic In Threadbit Plugin.

Find the 2 instances of: {vb:raw thread.forumtitle}

Change them BOTH to:


<a href=\'forumdisplay.php?{vb:raw session.sessionurl}f={vb:raw thread.forumid}\'>{vb:raw thread.forumtitle}</a>


That should do it.

Baghira
03-03-2013, 06:10 PM
Some problems here... After activating the mod (i did the template modification as instructed) I get an Error when visiting the masterforum


Datenbankfehler in vBulletin 4.2.0:

Invalid SQL:

SELECT COUNT(*) AS threads

FROM thread AS thread

/*
WHERE thread.forumid = 17
AND sticky = 0

AND visible IN (0,1,2);

MySQL-Fehler : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '/*
WHERE thread.forumid = 17
AND sticky = 0

AND visible IN (0,1,2)' at line 9
Fehler-Nr. : 1064
Fehler-Zeit : Sunday, 03.03.2013 @ 20:08:17
Datum : Sunday, 03.03.2013 @ 20:08:17
Skript : URL of the Masterforum
Referrer : Forum URL
IP-Adresse : My IP
Benutzername : MyName
Klassenname : vB_Database
MySQL-Version : 5.1.63-0+squeeze1

BirdOPrey5
03-03-2013, 07:36 PM
In 4.2.0 you do not do the file edit. Restore forumdisplay.php back to the original.

Baghira
03-03-2013, 08:03 PM
I did it.

The MySQL Error is not shown any more. Will test tomorrow, if items are collected by master

Thanks ;)

UPDATE

WORKS on 4.2 PL3! Great Mod! Love it. Thank you very much!

planetMitch
03-14-2013, 02:28 AM
I just wanted to pop in and give a big shoutout to BirdOfPrey5!

Good golly man this is perfect for my needs!

THANK YOU!

mikesafl
05-02-2013, 03:10 PM
Thank you so much for this I love this mod. This goes perfect with the type of forum im running. I only have one question because i didnt see it in the settings, how do i turn off where replies show on the masterforum. All i would like is the threads to show up not when someone replies to the thread

BirdOPrey5
05-03-2013, 10:38 AM
I don't understand how you mean to turn off replies? As a thread it gets bumped to the top when there is a new reply, that can't be changed. But viewing the actual replies takes place in the thread itself.

Burnt
05-05-2013, 05:13 PM
I'm running 4.2.0 PL3 and when I installed this and setup one main forum to catch 3 other forums.. If I post anything in that master forum those posts don't show up only the ones that are grabbed.. I didn't edit anything other than tell what was the master and the other forums. I turned off all other plugins to see if it was having problems with anything else but even with all turned off nothing shows up. Any suggestions?

EDIT

I'm guessing I have to turn on that forum as well to show its posts in the master forum as that does work... Question I have is there any way to separate that? I'd like to have the grabbed posts all on top then have it split and start with all the posts from that master forum separated

BirdOPrey5
05-06-2013, 12:16 AM
There is no way to separate the posts, sorry- they come in like they were all in the same forum.

Naijasite
06-01-2013, 09:44 AM
won't it look like duplicate thread since the thread has already been posted in another category ?
Does it has any benefit or effect on SEO?

BirdOPrey5
06-01-2013, 10:11 AM
If only 1 thread exists, only 1 thread gets listed on any page.

I can't imagine it hurting SEO because the thread maintains its original URL no matter what forum it is listed in, so no duplicate content issues- just multiple links to the same page from different pages.

Morrus
06-06-2013, 10:13 AM
The direction to 4.2.0 users in the OP - does that also apply to 4.2.1 users?

BirdOPrey5
06-06-2013, 06:40 PM
Yes, 4.2.1 is pretty similar to 4.2.0.

b65ran
06-06-2013, 10:40 PM
do we have a 4.x.x version for this one ?

BirdOPrey5
06-07-2013, 12:11 AM
This is the 4.x.x version.

Morrus
06-07-2013, 12:12 AM
Yes, 4.2.1 is pretty similar to 4.2.0.

Excellent!

JMEWLS`
07-11-2013, 12:49 AM
Is it possible to show the last post of the threads in the forumhome?

BirdOPrey5
07-11-2013, 12:59 AM
Not a feature of this mod, not sure how you would do it.

JMEWLS`
07-11-2013, 01:08 AM
Not a feature of this mod, not sure how you would do it.
No worries, still a fantastic mod none the less buddy.

NukedLT
03-16-2014, 01:32 PM
Would it be at all possible to show stickied subforum threads as normal threads in the master when stickies are disabled in the mod?

BirdOPrey5
03-16-2014, 04:16 PM
Would it be at all possible to show stickied subforum threads as normal threads in the master when stickies are disabled in the mod?

Almost everything is possible, but even after a fresh look at the code it just isn't going to happen with this mod as it is written. The query that would need to be editing to alter that isn't one this mod even touches right now and I'm not 100% it could be done without manual file editing.

Jennifer2010
04-08-2014, 09:40 PM
I've been using this for a long time with great success and appreciate it a lot - THANK YOU!

I have one problem, though. I edited our threadbit template to customize the meta display and when I do so, it removes the "Native forum" display which displays the forum the thread was posted in, in the thread meta under the title.

Is there a way I can manually insert the code into my threadbit to fix this?

Thank you!

UPDATE: I spoke too soon. Just read the instructions file which it includes. Thanks so much! You're the best!

microscopes
07-26-2014, 11:28 PM
Has anyone figured out the database error?

With and without the forumdisplay.php edit I get the error.

My forumdisplay.php

($hook = vBulletinHook::fetch_hook('forumdisplay_query_thre adscount')) ? eval($hook) : false;

# Include visible IN (0,1,2) in order to hit upon the 4 column index
$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS threads
$hook_query_fields
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE thread.forumid = $foruminfo[forumid]
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$totalthreads = $threadscount['threads'];

$threadscount = $db->query_first_slave("
SELECT COUNT(*) AS newthread
FROM " . TABLE_PREFIX . "thread AS thread
$tachyjoin
$hook_query_joins
WHERE thread.forumid = $foruminfo[forumid]
AND thread.lastpost > $lastread
AND open <> 10
AND sticky = 0
$prefix_filter
$visiblethreads
$globalignore
$limitothers
$datecut
$hook_query_where
");
$newthreads = $threadscount['newthread'];

// set defaults
sanitize_pageresults($totalthreads, $pagenumber, $perpage, 200, $vbulletin->options['maxthreads']);

// get number of sticky threads for the first page
// on the first page there will be the sticky threads PLUS the $perpage other normal threads
// not quite a bug, but a deliberate feature!
if ($pagenumber == 1 OR $vbulletin->options['showstickies'])
{
$stickies = $db->query_read_slave("
SELECT thread.threadid, lastpost, open
FROM " . TABLE_PREFIX . "thread AS thread
WHERE forumid = $foruminfo[forumid]
AND sticky = 1
$prefix_filter
$visiblethreads
$limitothers
$globalignore
");
while ($thissticky = $db->fetch_array($stickies))
{
$stickycount++;
if ($thissticky['lastpost'] >= $lastread AND $thissticky['open'] <> 10)
{
$newthreads++;
}
$stickyids .= ",$thissticky[threadid]";
}
$db->free_result($stickies);
unset($thissticky, $stickies);

BirdOPrey5
07-27-2014, 10:58 AM
What version of vBulletin?

microscopes
07-27-2014, 02:04 PM
What version of vBulletin?

4.2.2

I sent you a PM with more info including a snippet of my forumdisplay.php -- maybe you can see the issue?

BuffaloRange.com is my forum

microscopes
07-28-2014, 12:56 AM
It's not any of the mods either I don't think

alfieb
07-29-2014, 09:44 AM
Love the concept, but it didn't work for me.

It would pull the threads from the slave forum to the master forum, and they could be seen on both, but it wouldn't show any native threads from the master forum. Hopefully there's a solution, but in the meantime I have to disable the mod.

ForceHSS
07-29-2014, 05:08 PM
4.2.2

I sent you a PM with more info, including a snippet of my forumdisplay.php -- maybe you can see the issue?

BuffaloRange.com is my forum
On line 790 of forumdisplay.php delete line $hook_query_where
is this what you did?

microscopes
07-29-2014, 05:17 PM
On line 790 of forumdisplay.php delete line $hook_query_where
is this what you did?

I deleted it and I tried it and it didnt work -- then I put it back in, tried it, and it didn't work.

Not sure whats going on.

ForceHSS
07-29-2014, 05:21 PM
what program a you using to edit the file with

microscopes
07-29-2014, 06:55 PM
It appears the original coder doesnt want to support this.

I'll pay someone to fix this issue if they can.

microscopes
07-29-2014, 07:22 PM
Edit: Got it to work

BirdOPrey5
07-29-2014, 07:42 PM
Love the concept, but it didn't work for me.

It would pull the threads from the slave forum to the master forum, and they could be seen on both, but it wouldn't show any native threads from the master forum. Hopefully there's a solution, but in the meantime I have to disable the mod.

You have to put the master forum in the list of slave forums...

If "2" is the master forum you need:

2|2,3,4,5,6...

NOT

2|3,4,5,6...

BirdOPrey5
07-29-2014, 07:53 PM
FYI, I just installed this mod on a virtually fresh 4.2.2 forum. It works fine without any file edits.

Just download the original forumdisplay.php file... don't make any changes to the file.

Make sure you have commas between the forumid numbers in the mod settings if you are getting a database error.

Also - Please "Mark as Installed" if you are using this mod. Thank You.

microscopes
07-29-2014, 07:59 PM
Anyone ever figure out a way to update the thread count? Looks pretty silly showing 1 thread LOL.

pjkcards
10-21-2014, 06:48 AM
I'm running 4.2.2 and thread and post count is messed up. Anyone have a solution?

BirdOPrey5
10-23-2014, 11:00 AM
When you say messed up- it is not supposed to change when using this mod. It will only show the threads and posts of the threads and posts native to the forum you are looking at- it is not supposed to add the posts from the other threads you happen to see.

pjkcards
10-27-2014, 10:26 AM
When you say messed up- it is not supposed to change when using this mod. It will only show the threads and posts of the threads and posts native to the forum you are looking at- it is not supposed to add the posts from the other threads you happen to see.
Sorry I wasn't clear. When I created the master forum and included all subforums on the entire site, when I look at the master forum on the forum home, it shows post count as 0 and thread count as 0. But when I click on the master forum, it shows all the threads. That was what I meant. Is there a way to fix those counts so they don't show 0?

Thanks.

BirdOPrey5
10-30-2014, 01:48 PM
The only way not to show zero as the post count in the master forum would be to create some threads/posts that were native to the Master Forum, and don't appear in any other forum.

What you want to do you might be better off using a "Link" forum and making the link URL and the link to the "New Posts" page but setup to exclude whatever forumids you don't want.

Something like-

search.php?do=getdaily&days=10&exclude=11,15,23,81

Where the 11,15,23 and 81 are forumids of forums you don't want listed.

10 is the number of days back you want to show posts from.

pjkcards
11-04-2014, 04:57 AM
The only way not to show zero as the post count in the master forum would be to create some threads/posts that were native to the Master Forum, and don't appear in any other forum.

What you want to do you might be better off using a "Link" forum and making the link URL and the link to the "New Posts" page but setup to exclude whatever forumids you don't want.

Something like-

search.php?do=getdaily&days=10&exclude=11,15,23,81

Where the 11,15,23 and 81 are forumids of forums you don't want listed.

10 is the number of days back you want to show posts from.
Doesn't new posts rely on what you read/unread? I thought the idea of the master forum was for having all the posts in the forum show up, regardless of whether it was read or not.

BirdOPrey5
11-04-2014, 08:09 AM
That search string is "getdaily" which is the Today's Post link expanded to 10 days- that should show old and new posts. The one you are talking about would be "getnew" that should only show threads with new posts.

Sarab
04-01-2015, 11:24 PM
Hello =D

I have this error:

Database error in vBulletin 4.2.2:

Invalid SQL:

SELECT COUNT(*) AS threads,
(
SELECT COUNT(*) AS newthread
FROM thread AS thread
WHERE forumid = 185
AND lastpost > 1427937256
AND open <> 10
AND sticky = 0

AND visible IN (0,1,2)



*/ WHERE forumid IN (186) AND sticky = 0 AND visible IN (0,1,2)
) AS newthread

FROM thread AS thread

/*
WHERE forumid = 185
AND sticky = 0

AND visible IN (0,1,2)



*/ WHERE forumid IN (186) AND sticky = 0 AND visible IN (0,1,2);

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '*/ WHERE forumid IN (186) AND sticky = 0 AND visible IN (0,1,2)
) AS new' at line 14

vbulletin version is 4.2.2 without forumdisplay.php edit, how to fix it =")?

BirdOPrey5
04-03-2015, 02:30 PM
Upload the fresh forumdisplay php. file from the VB 4.2.2 download package.

For some reason it looks like the query hooks are backwards.

jagtpf
06-17-2015, 05:15 AM
Upgraded vB to 4.2.3 from 3.8.7 - this product works as expected.

One out of the box thought - would it be possible to use this excellent product to show threads with no replies!

In vB 3.8.7 we had a link dedicated to search for all uncommented threads - that no longer works. and I'm trying to find alternatives.....

Morrus
06-19-2015, 07:14 AM
I'm with pjkcards - it would be wonderful not to have it appear on the forum home as an empty forum. If the #threads/replies can't be changed, is there any way to simply hide them on master forums only? I've had several people tell me they never click on the master forum because from the forumhome it looks like there's nothing there.

BGObsession
08-10-2017, 06:09 PM
Love this mod. Appears to be working great on 4.2.5/php 7. I actually have no desire to have a 'Master Forum' but was able to create two master forums (one for all threads, the other for just RSS news feed threads) and then set the Forum's active status to 'No'.

I then created a 'View All Threads' and 'View All News' link for my sub-nav bar. great way for members to be able to see all of the most recent threads without having to go forum to forum if they prefer not to. Great work BOP5!

jagtpf
08-06-2018, 04:12 AM
Absolutely love this mod. I'm probably not going to get an answer, or even a solution - but if the display options could provide threads in a random order it would be awesome!

BirdOPrey5
08-06-2018, 08:21 AM
A random option for thread display would seem like its own separate mod, it wouldn't be part of this since this mod doesn't alter how threads are displayed. But thank you for the kind words about the mod though.

jagtpf
08-06-2018, 08:38 AM
A random option for thread display would seem like its own separate mod, it wouldn't be part of this since this mod doesn't alter how threads are displayed. But thank you for the kind words about the mod though.

Many thanks - It does display according to rating and age of threads - so it was just a hope of possibility :D

But yes, it's a great add-on :up::up::up:

microscopes
08-09-2018, 05:56 PM
A random option for thread display would seem like its own separate mod, it wouldn't be part of this since this mod doesn't alter how threads are displayed. But thank you for the kind words about the mod though.

Any idea why a "last post" time would be hours ago and not current on the forum list page?

BirdOPrey5
08-11-2018, 10:25 AM
The last post time you are seeing (if it's on the forumdisplay or forum index page) is the last post that was natively posted to that forum, not any of the other threads from other forums that are also visible when you open/list that forum.

Sorry if that is hard to follow but the threads aren't really in your "master forum" so they don't register as being in there until you actually open the forum for viewing.

scottkoz20
08-11-2018, 11:41 AM
this is awesome - not sure why I never found this before

I have a minor ask, is there a way to make the Forum that the post is coming from clickable?

babyv0x
04-30-2021, 01:41 AM
work on 4.2.5! Great Mod! Thank you very much!