PDA

View Full Version : Profile Enhancements - ragtek Referrer Tab


ragtek
06-07-2010, 10:00 PM
Thid add-on adds a Tab to the userprofile where you can see all referred Users.


Installation:

Upload the ragtek Folder into your forum directory.

Install the xml file

changehistory:
1.0.5 =>
phrase fixed
add-on is now activated

djbaxter
06-08-2010, 07:55 AM
When installed, priduct is disabled by default. Unexpected. It looked like it wasn't doing aything. I went to uninstall it and discovered it wasn't enabled.

djbaxter
06-08-2010, 08:01 AM
Cosmetic bug:

<phrase name="referrerTab" date="1275564286" username="ragtek" version="1.0.2"><![CDATA[referred Users]]>

Should be:

<phrase name="referrerTab" date="1275564286" username="ragtek" version="1.0.2"><![CDATA[Referred Users]]>

ragtek
06-08-2010, 08:12 AM
Cosmetic bug:

<phrase name="referrerTab" date="1275564286" username="ragtek" version="1.0.2"><![CDATA[referred Users]]>

Should be:

<phrase name="referrerTab" date="1275564286" username="ragtek" version="1.0.2"><![CDATA[Referred Users]]>

thx

Boofo
06-08-2010, 02:54 PM
There is also a template eval in member_complete.php that needs to be updated for vb 4.

Why not just add the plugin files code to the XML instead of using separate files for them?

ragtek
06-08-2010, 04:07 PM
There is also a template eval in member_complete.php that needs to be updated for vb 4.

Why not just add the plugin files code to the XML instead of using separate files for them?

What's wrong with the eval? It's working.

And i have the seperate files because of my build/development add-on.

Boofo
06-08-2010, 04:16 PM
vb 4 doesn't use eval anymore. It uses vB_Template::create now. Whether the eval is working or not is immaterial. The correct way to do it for vb 4 is the vB_Template::create. This was all I was trying to point out.

ragtek
06-08-2010, 04:31 PM
Ah, youre right.
It seems that i was completly confused^^
thx

Boofo
06-08-2010, 04:42 PM
And you could throw that right in a plugin and save having to use a separate file for that.

ragtek
06-08-2010, 04:54 PM
No i cant because of my build tool;)

And how should i remove the eval? There is no template!

Just check the blog Add-on, it's doing it the same way!Member Profile: Add Blog Links to standard MEMBERINFO display And if the vb developer do it this way, why i shouldn't do it too?

Boofo
06-08-2010, 05:33 PM
Okay, well, it's your product so however you choose to do it is for you to decide. I was just tying to offer some help is all.

ragtek
06-08-2010, 05:37 PM
Yea and thx for this, but as you see, you was wrong.
I don't have a template at the member_complete plugin, so i'm not making anything wrong.

And atm my build-addon isn't finished, so i have to use the plugins this way (with includes)... There's no other way;)

Boofo
06-08-2010, 06:23 PM
You show me anywhere in vb 4 where they are still using the eval statement and only then will I admit I was wrong.

ragtek
06-08-2010, 06:45 PM
You show me anywhere in vb 4 where they are still using the eval statement and only then will I admit I was wrong.

In the suite you can check the blog plugin and find the eval;)
How else would you make this?

Boofo
06-08-2010, 08:06 PM
I would do the whole hack different and get away from the separate files. But since you need the files for your setup, there's not much else you can do, I guess. Like you said, if it works...

ragtek
06-08-2010, 08:14 PM
And what's with the eval?*g* Am i right or not?

Yea, the big part of the files will go away, when my development/builder tool is finished, but until then i have to make it this way (i need them because of the PHP-IDE & SVN Support ;) )

Boofo
06-08-2010, 09:02 PM
Well, as the blogs are still being worked on, IIRC, that eval won't be there long, as I'm sure it was overlkooked when they started replacing the evals. But yes, you are right, if that is what you want to hear for a single eval in the whole scheme of things.

ragtek
06-09-2010, 02:50 AM
Thx, that's very good for my egohttp://ragtek.org/smil/badteeth.gif

Boofo
06-09-2010, 03:53 AM
I gathered that from out posts. ;)

Also, I will PM you when I get it done on my end, but I did manage to find a way to do it all in a plugin. ;)

ragtek
06-09-2010, 06:06 AM
And why do you think it's better to do it in an plugin instead of an file and including it?

If you use an php Opcache, my method is better, because eval'd code can't be optimized, the file can;) So it could be better for the performance.

And for me as Developer it's easier because i can work with an IDE and use SVN and export the whole add-on path /ragtek/addonid to the SVN Server...
Also it's easier for debugging.

But when my developer/add-onbuilder is finished, it will put the code into the plugin directly instead of the seperate files.

You're right that only a pluginfile is user friendlier than my method, but mine has much more benefits;)

Boofo
06-09-2010, 06:33 AM
Both ways have their advantages. But with the user coding level here on the org, plugins are a lot less hassle to support.

ragtek
06-15-2010, 04:04 AM
It's really funny that somebody who have no clue from coding (http://www.vbulletin.com/forum/showthread.php?353963-db-gt-fetch_array-question) is saying how i should code my add-ons:D

Thx for trying, but .....


Why should files be less hassle to support then plugins? It's the same....... For me it's easier because i can use the ide and version control software
Also it's easier for CI and could have better performance with php opcaches...

Marco van Herwaarden
06-15-2010, 04:29 AM
Both please stop attacking eachother.

djbaxter
06-15-2010, 12:40 PM
The com business does not need to be brought over here. That was my point.

And the rest of us don't want to hear the two of you bicker about it. Take it to PMs if you wish. You've already had posts deleted by a moderator. Let it go.