PDA

View Full Version : New Posting Features - Merge Double Post


Vitaly
06-05-2010, 10:00 PM
vb 3.8 version here (https://vborg.vbsupport.ru/showthread.php?t=233878)

This mod join consecutive posts of the same member to single one. That prevents nasty "bumps".

That's a complete rewrite of "Double Post Prevention Plus", that was announced here (https://vborg.vbsupport.ru/showpost.php?p=1756333&postcount=78). Besides some new features, merge algorythm changed too. It doesn't creates dummy posts anymore. Code is reuseable at last.

Well, what this mod do:
The main - it merge consecuent posts of the same user to single one
Yes, it cares about attachments
Yes, it cares about AJAX posting
Yes, it cares about social groups, if you wish
It can add splitter with RELATIVE time. Users from different time zones will not be confused
Relative time can be translated via addon for languages with complex semantics (russian translation included).It just works :)

How to install:
Upload files from appropriate directory
Import product XML
If you use russian language - import translation addon from "./lang" dir. You should not do it for other languages.
Go to ACP ant set necessary product options (see screenshot).
Check ACP -> Message Posting and Editing Options -> Time to Wait Before Starting to Display 'Last Edited by...' . Set it to 10-15 minutes. Before that time delimitor will not be added, as useless.If you used my "Doublepost Prevention Plus" mod before, please, remember settings and uninstall it first.

This mod is developped here http://github.com/rcdesign/vb-merge_doubleposts . Patches are welcome.

history

2.9
- fixed post date - now stays intact.
- some ajax tweeks

2.8
- fixed VaultWiki compatibility

2.7
- port to vb4

KURTZ
06-06-2010, 09:43 AM
hi, what's the difference between your and PM's hack?

Vitaly
06-06-2010, 10:00 AM
Attachments, one pass, relative time in delimiter. Better design, lol :)

But PM provides better support. His modes where converted to vb4 much earlier, than my ones.

KURTZ
06-06-2010, 10:23 AM
Attachments, one pass, relative time in delimiter. Better design, lol :)

But PM provides better support. His modes where converted to vb4 much earlier, than my ones.

thanks for the reply mate :)

Cedric_FP
06-06-2010, 11:39 AM
Would it be possible to only merge the post if the message contains certain text?

That is, if a post does NOT contain certain text it is not counted as a double post?

Vitaly
06-06-2010, 01:15 PM
Only if you modify code or write addon.

Webbstre
06-11-2010, 11:25 PM
Just installed this, and it works great! I like the merging and it perfectly handles the double post problem.

Webbstre
06-13-2010, 01:52 AM
Ok, after a day of using this I came across a major problem. Something in this mod conflicts with my Vaultwiki add-on. First (http://www.vaultwiki.org/issues/1674/), it makes it so the "Last Post" link on the forum home leads to a search page instead of the real page. Second (http://www.vaultwiki.org/issues/1673/), it makes it so I cannot create new wiki articles.

The author of VaultWiki said this was the problem:

This is not a VaultWiki bug. The mod you are using "Merge Double Posts" was setting $post['postid'] to a NULL value at hook newpost_complete.

Please report this to the mod creator. The post ID is already set in the file above...

if ($type == 'thread')
{
$post['threadid'] = $id;
$threadinfo =& $dataman->thread;
$post['postid'] = $dataman->fetch_field('firstpostid');
}
else
{
$post['postid'] = $id;
}


If you could release a fix for this I would be very grateful. I really like your mod, but I paid to use VaultWiki and it's a bit more essential to my site.

Vitaly
06-13-2010, 02:23 AM
Thanks for report. I'll check, what can be done.

Boofo
06-13-2010, 02:56 AM
Would you really need the Ignore forums AND Enabled Forums? Wouldn't just one setting actually do both? Whatever is enabled is all the would show. No need to ignore anything then. What would happen if you had the same forumid set for both options?

Vitaly
06-13-2010, 03:15 AM
This was requested in 3.8 version by different people. Some people asked for "enable" setting, other for "ignore". Of cause, there are no reasons to use both. I don't use any at my site.

Boofo
06-13-2010, 03:28 AM
This was requested in 3.8 version by different people. Some people asked for "enable" setting, other for "ignore". Of cause, there are no reasons to use both. I don't use any at my site.

Well, it does sound kind of confusing, you must admit. But you are the one who is going to have to do the support for it when someone enters the same forumid into both settings and can't figure out why it won't work. ;)

Vitaly
06-13-2010, 04:27 AM
I think, that if one enter same IDs on both settings, this problem should be solved by medical intrussion. For other cases, existing of both settings is a bit strange, but doesn't make a problem. Many mods have the same setting pairs, to fit different situations.

By default, mod goes with 100% working config, and best idea is to leave it intact.

Boofo
06-13-2010, 05:48 AM
Well, I have never seen a mod that had both settings as they are basically the same thing in reverse. But it is your mod to do with as you please.

Vitaly
06-14-2010, 08:14 AM
Ok, after a day of using this I came across a major problem. Something in this mod conflicts with my Vaultwiki add-on...

Hope, it's fixed in 2.8. Thanks again for bug report.

Webbstre
06-14-2010, 10:15 AM
It appears to have worked! Thank you!!

a7lameza.com
06-20-2010, 07:45 PM
thank you

blacksurgeon
06-22-2010, 12:33 AM
Hi,

seems like I found a little glitch in your addon.

If you do a double post and a quote is inside this post, then you get a duplicate.
I added a screenshot.
The quote was added by clicking the link "Quote" nearby a posting.

Vitaly
06-22-2010, 05:53 AM
Don't see correlations. Is it 100% reproduceable every time, at your forum, or happened only once?

blacksurgeon
06-22-2010, 07:38 PM
Hi,

sorry... I deactivated your addon and well... I got a duplicate also.

However, thanks for your fast reply!

Keep up the good work.

KTP
06-22-2010, 07:50 PM
installed, my board is bad for users posting the same thing twice and not being their fault.
hopefully this will help our issue.

ZexTasy
06-22-2010, 11:16 PM
@Boofo:

If you have 50 forums on your site, you want doublepost to work in all except 2 forums, then you use the ignore ... you can simply enter the two forum ids ...

If you have 50 forums on your site, you want doublepost to work in just two forums, then you use the enable, you can simply enter the forum ids ....

So it just depends where you want to put the exception and then it is actually very easy to use in both cases ... good choice Vitaly! (Y)

Braddock
07-05-2010, 08:45 AM
Hi!
I got some problem with bump Post.
The Date of the post is bumped to the new time but in vb New Threads the post is only listed with the first time of the postig.

karlm
07-06-2010, 01:22 AM
Great Idea!!!! Thank you, Sir.

bahisbudur
07-13-2010, 11:40 AM
hello,

i installed hack and it works good but i have an problem.

i've written a post.
somebody written a post after me.
when i wrote after somebody in merge time, script adds somebody's post with quote.

i don't want to adding previous posts with quote.

what can i do about this problem -for me-?

sorry for bad english :)

Vitaly
07-13-2010, 03:20 PM
May be, auto quoted text can be switched off from ACP. I think, this is not affiliated to this mod - check if you get the same result when mod is off.

bahisbudur
07-16-2010, 10:52 AM
May be, auto quoted text can be switched off from ACP. I think, this is not affiliated to this mod - check if you get the same result when mod is off.

without using acp, which codes i need to delete for auto quote?

Braddock
07-23-2010, 07:53 AM
Hi!
I got some problem with bump Post.
The Date of the post is bumped to the new time but in vb New Threads the post is only listed with the first time of the postig.

Sry for selfquote but an answer would be nice. :)

Vitaly
07-23-2010, 09:36 AM
It's by design. Second post time is shown in separator, if you use it. IMHO, result is good: thread is bumped, and you can see all timestamps.

Braddock
07-26-2010, 11:01 AM
Ok,
i think my explenation isn't very good.
All Timestamps are changed when a second post is merged, but when i am searching for new posts, the merged post is not shown.
I hope i can make clear what my problem is. English is not my prefered language! :)

Vitaly
07-26-2010, 11:32 AM
Hm. I'll check that problem in 2-4 weeks, ok? No time at all right now. Hope, this bug is not so critical.

Recorded it in bug tracker.

Braddock
07-27-2010, 07:17 AM
That would be great! Thx

Deib
08-24-2010, 11:58 AM
Okay so I am having this problem and it only seems to happen to me. Where the merged posts prints the same data twice.
So if I say,
Hi, how are you.

The merged post will show as

Hi, how are you.

Hi, how are you.

It only seems to happen to me the admin and not any of the other users on the board.
What is up with that? LOL

Vitaly
08-24-2010, 12:22 PM
No ideas. Probably, conflict with some other mod.

lubbie
08-30-2010, 01:18 PM
Installed, and working. Only the delimeter is not set

If i try to use the VaultWiki Fix from http://github.com/rcdesign/vb-merge_doubleposts i get an error: Mismatched tag in row 62

Popa Andrei
08-31-2010, 07:42 PM
if i make the merged thread to bump will it affect something?

bkm_mahdi
09-09-2010, 07:49 AM
hi...
After the mergerŲŒedit by...
No message

Popa Andrei
09-13-2010, 11:08 AM
and the bump doesent work on merged threads.

Vitaly
09-16-2010, 05:24 PM
Please, speak english.

1. I support only UTF-8, sorry. You can try to find some convertor in google and convert encoding yourself.

2. Separator works in both cases. But it's skipped automatically, if time between posts is small. See decription in first post.

YuriB
09-16-2010, 07:29 PM
Please, speak english.
Excuse me.

1. I support only UTF-8, sorry. You can try to find some convertor in google and convert encoding yourself.
2. Separator works in both cases. But it's skipped automatically, if time between posts is small. See decription in first post.
And thank you...

YankForum
10-18-2010, 01:41 PM
installed and nominated
just 1 question : is it having bad influence on server loads ?
-------------------------------------
EDIT: am i allowed to ask 1 more question ? :D
is it possible to make it work in AJAX ? when double post added it shows both posts in the same post ?
anyway Tnx 4 sharing :)

YankForum
11-16-2010, 04:41 AM
it would be nice to be able to disable it for thread starter , just like vbulletin.org

LuisManson
01-11-2011, 08:01 PM
it would be great an option to compare and just ignore the double post if its exactlry the same text, since there is a bug in vb related to this which is not fixed...

G37Sam
01-30-2011, 07:29 PM
Okay so I am having this problem and it only seems to happen to me. Where the merged posts prints the same data twice.
So if I say,
Hi, how are you.

The merged post will show as

Hi, how are you.

Hi, how are you.

It only seems to happen to me the admin and not any of the other users on the board.
What is up with that? LOL

+1

I am getting the error mentioned as well.

Once the thread is refreshed it gives me this statement in a white page for a few seconds..

Parse error: syntax error, unexpected '[' in /hermes/bosweb/web178/b1784/ipw.gtzuae/public_html/includes/class_core.php(4010) : eval()'d code on line 19

The thread then shows and everything is normal

juanrimore
01-30-2011, 11:46 PM
Good!

But in 4.1.1 the message between merged posts doesn't appear.

thanks!

Wordplay
04-02-2011, 09:51 AM
i had to uninstall, running 4.1.2 and it made every quick reply post into a double post.

Hannigan
07-26-2011, 01:38 PM
I'm having the same problem as Deib

Okay so I am having this problem and it only seems to happen to me. Where the merged posts prints the same data twice.
So if I say,
Hi, how are you.

The merged post will show as

Hi, how are you.

Hi, how are you.

It only seems to happen to me the admin and not any of the other users on the board.
What is up with that? LOL

too_cool_3
11-10-2011, 12:35 AM
Any fix for this yet? Does this work properly for vB 4.1.7?

If anyone is looking for an alternative that is only compatible with vBulletin 4.1.4 onwards and does the exact same thing see this thread: https://vborg.vbsupport.ru/showthread.php?t=233234

Froberg
01-11-2012, 12:38 PM
It prevented posts entirely on my 4.1.8 installation :(

New Joe
02-28-2012, 03:22 PM
Best to try this one out, as it is better supported, there are a few bugs but on the whole it works fine.
https://vborg.vbsupport.ru/showthread.php?p=2304287#post2304287

unfv
05-24-2012, 02:10 AM
uninstalling, 4.2.0 version has included this feature

ostap
10-17-2012, 12:15 AM
Hi ...

Installed it on 4.1.12...

Kinda worsks :)

Posts just accumulate ....each new one has same index ....and accumulated content...
after checking DB - there is just one record - so ..it does works...(after refreshing the page - there is just 1 post)

I guess while user still on the page that ajax thingy simply adds parts to the existing page...without refreshing it... -

Any chance you could fix that for 4.1.12 ? or is there quick work around without diving into deep...