Cel Photo Popup - Insert pictures from vB Albums, Attachs, Photopost, vBGallery

[cellarius]

For your information: I'm currently working on a new version, that will fix the button issue in standard editor mode an will also add an optional button at the bottom next to the autosave restore button.

Some issues remain, and I'll go back through the posts for bugs to look at, but if you have unreported issues, now would be a good time to tell me ;)

[Moncha]

Be glad to beta it for you.. I for one like it

[ehpoole]

I've found several issues with Cel_PhotoPopup version 4.1.002 on vBulletin v4.1.10. Basically class methods/variables are being called without first attaching them to the $this-> instance.

In cel_pp_class_photopost.php, On or about Line 192 (very near end of file):

Was: $img['med'] = $img['orig'];
Fixed: $this->img['med'] = $this->img['orig'];

In cel_pp_class.php, On or about Line 109 (part of function set_choice_by_get()):

Was: $get_album = FALSE;
Fixed: $this->get_album = FALSE;

While I could locate the cause of the above issues and correct them, there is another issue that I have had to make a real hack of a fix for because I can not identify what is causing the page to generate an Error 500 (Server Error) unless at least a single byte is printed by a certain point in photo_popup.php. Around line 204 I had to add the following line of code: echo chr(0); in order to prevent the Server Error 500. With that single null byte printed to the browser HTTP headers are sent and everything works as it should (save for the preceding code fixes), but without nothing is *ever* sent to the browser and the server throws a 500 Server Error and PHP logs the error as "premature end of script headers".

I can not locate anything site specific (like Apache or PHP configurations) that would cause a timeout to occur if headers were not sent in under 1-2 seconds (about the longest possible wait) but it nonetheless behaves a lot like a timeout condition and it is 100% repeatable with absolute certainty -- if at least one byte is not sent to the browser (to trigger PHP sending the headers) by a certain point in the PHP code a 500 Server Error will occur each and every time.

Despite my best efforts, I have not been able to figure out why this hack is necessary to make things work.

If these issues have already been reported and fixed, please accept my apologies. I wanted to report my findings so as to ensure that you were aware of the issues I found so that the fixes could be incorporated into the next official release.

Thank you for your time and efforts in this regard.

[cellarius]

Thanks for your reports; I have corrected the two code bugs you reported. Regarding the server error, however, I have never witnessed this myself or had any reports on it. I really don't have an idea either what could cause this or what I could to to try to reproduce it...

[cellarius]

Damn, have that @!$?& button under the editor working in IE and FF, but Chrome won't show it. Boy, do I hate Javascript... ;)

[cellarius]

New Version: 4.1.004

Highlights:
This version fixes several bugs, among them the greyed out button in code mode)
the much requested, better visible text-button is back. It can be turned on and off via a new AdminCP setting, same for the old toolbar icons. See:136500

if you are on vB 4.1.10, remove your setting for the seperator - this is obsolete. CKE no longer trims the whitespace Photo Popup inserts by default.Full list of changes (the leading number refers to posts in this thread):
#225 [added] suggestion for button under the editor (tested with FF 10, IE 9, Chrome 17)
#--- [added] AdminCP settings for toolbar and new bottom-button
#--- [added] code of major plugins moved to file system for better overall performance
#211 [fixed] Added getBaseUrl() to window.open in plugin.js in order to provide for multi-directory installations (provided in #214)
#215 [fixed] bug when using MySQLi in photo_popup.php, line 322 (fix provided by snoopytas in #215)
#224 [fixed] editor button no longer greyed out/inactive in code mode
#253 [fixed] code bugs
#229 [can't reproduce] dropdown to choose albums not working (tested in 4.1.10)
#205 [not a bug] inserting image leads to black font color go white, caused by the placeholder between images (see ##207, 208, 209, also functionality obsolete)
#246 [not a bug] dark text in dropdowns, bad for black bg (the background and text colors in the dropdowns do follow the "input_"-style variables correctly in 4.1.10)
#212 [ok] Check compatibility with PhotoPost 8 (tested with vB 4.1.10 and PP 8.0 Gold)
#--- [obsolete] Add seperator between images feature obsolete, may be removed in future versions

[Hostboard]

New install VB 4.1.10 & 4.1.004 Using IE9 I am not getting a button image but rather just a grey block as reported in prior posts. The grey is clickable and the modification works. Would just like to see a button :)

Thanx!!!

[cellarius]

Huh, that shouldn't be the case, of course ;)
I'll look into it over the weekend.

[cellarius]

Had a quick look: I see the icon on IE9, just as in any other browser:

136537

Please make sure you have uploaded the icon file correctly. If you use a custom style that uses a custom folder for images, make sure to upload the icon image file to a subfolder named cel in the directory the style uses for buttons. Probably [customstyleimages]/buttons/cel/cel_photo_popup.png.

[Hostboard]

You right, I'm wrong... Completely forgot about custom style... Still did not get it to show but it is just a matter of figuring out the proper directory structure, the one given did not work.

Also, do you have a mouse over tool tip for the camera image? I can mouse over all the buttons and get a small note but not on yours.

[Hostboard]

I am getting a TMS error:


There are 1 Template-Modifications that were not desinged for the currently installed vBulletin version. To make sure that vBulletin and your installed Products are working correctly, you must check and maybe modify those Template-Modifications.


It is stemming from editor_smiliebox

Also I can get the image in the editor with the default skin, custom skins that use custom images but the skin I am trying to use (PixlePremium) is using the default images and location. Weird... Any ideas?

[cellarius]

Regarding the TMS error: That may be because I may still be using an older version of TMS on my dev board. You should be able to ignore that.

Regarding the button path problem - the addon looks for the image in the folder cel inside the folder that is defined in the buttons image path in stylevars of that style. You should be able to use a tool like firebug to check where the editor is looking for the file.

[Mark.B]

My problem is the opposite way round, I can see the button image in IE9 but not Chrome or Firefox.

Checked and double checked the image locations, it's definitely there but does not show up. Got me baffled.

Firebug doesn't seem to work on editor elements so I can't test that way.

I even tried hardcoding the full URL into plugin.js, but despite this numerous cache clearing and refreshing just won't make it show up.

[cellarius]

Hi Mark,
sorry to hear that. If hardcoding it into plugin.js does not work, I'm out of ideas... it does work for me on all listed browsers. If IE shows it, I can't imagine it to be a path issue anyway.

BTW: Firebug does indeed not work on the buttons that come out of the box, but it does work on the added button. Since it shows up in IE, try the Dev Tools that come with it; I can see the path just fine there.

Anyone care to PN me with test access data so I can have a look at an editor?

[cellarius]

Also, do you have a mouse over tool tip for the camera image? I can mouse over all the buttons and get a small note but not on yours.
It's supposed to be there, but there's a bug :(
Will be fixed in the next release.

If you want to have it fixed right now, add the following line at the end of /includes/cel/cel_pp_plugin_editor_construct.php:
$this->config['vbulletin']['phrase']['cel_pp_my_photos'] = $this->vbphrase['cel_pp_my_photos'];

The tooltip will be the same text as the button below the editor.

[Mark.B]

Hi Mark,
sorry to hear that. If hardcoding it into plugin.js does not work, I'm out of ideas... it does work for me on all listed browsers. If IE shows it, I can't imagine it to be a path issue anyway.

BTW: Firebug does indeed not work on the buttons that come out of the box, but it does work on the added button. Since it shows up in IE, try the Dev Tools that come with it; I can see the path just fine there.

Anyone care to PN me with test access data so I can have a look at an editor?
I can't make the right click context menu appear at all on any editor buttons, not even the added one, so I am unable to get Firefug to do its work.

As you say, can't be the path anyhow.

It's a weird one. I'm sure I'll get to the bottom of it eventually.

[Mark.B]

In IE8 the button is also missing, along with the following JS error....


Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.2; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727; .NET CLR 3.0.04506.648; .NET CLR 3.5.21022; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; InfoPath.3)
Timestamp: Sun, 19 Feb 2012 17:45:50 UTC


Message: 'CKEDITOR.currentInstance.name' is null or not an object
Line: 23
Char: 5
Code: 0
URI: http://www.bowlandcentral.com/forum/clientscript/ckeplugins/cel_pp/plugin.js?t=B8DJ5M3

[AusPhotography]

We upgraded to latest version and integrated images from our Photo competition system.
We are NOT getting the IE8 issue, we use Competitions, Albums, Attachments, vBgallery

We also run Marco's editor enhancement and have multiple skins.

We really like the button at the bottom of the editor window!! Thanks!

Kym

[marcellhernande]

Awesome! I loved it! It makes posting easier! Thank you!

[lachgas]

Small Problem.

Debug information

Version: 4.1.001

Photo Popup Settings (from AdminCP)
num_of_cols: 3 [3]
num_of_rows: 3 [3]
num_total: 9
widht: 600
heigth: 680
products: albums attachments
insert_options_allowed: link_thumb_2_orig link_thumb_2_gallery link_med_2_orig link_med_2_gallery thumb med orig thumb_2_gallery_link_below med_2_gallery_link_below orig_2_gallery_link_below
allow_albums: 0
code_usergroups: 0

Code (this is what is inside the table cells)
<a href="#" onclick="thumbpaste('<img src=\'http://www.saab-cars.de/attachment.php?attachmentid=74702&thumb=1\' style=\'border: 0\' />','https://vborg.vbsupport.ru/external/2012/03/35.jpg');event.returnValue=false;return false;"><img src="http://www.saab-cars.de/attachment.php?attachmentid=74702&thumb=1" style="border: 0" title=""/></a>

Images query:
SELECT att.attachmentid, att.contentid FROM attachment as att WHERE (att.userid = 10872 ) AND att.contenttypeid = '8' ORDER BY att.attachmentid DESC LIMIT 0, 9

Albums query (only if not coming from cache):

Pagination query:
SELECT COUNT('attachmentid') AS fotos FROM attachment as att WHERE (att.userid = 10872 ) AND att.contenttypeid = '8'

Link to Original
http://www.saab-cars.de/attachment.php?attachmentid=74702

Link to Thumb
http://www.saab-cars.de/attachment.php?attachmentid=74702&thumb=1

Used product: albums

Albums possible: 1

Cookie
Read Cookie: albums,,thumb,0
Set Cookie: albums,,thumb,0
Cache Cookie:

Table building (rows and columns)
[td ][td][td][td][tr][td][td][td][tr][td][td][td]


Preview is Ok, when we save, we have only the code no pictures.

[cellarius]

This is most likely caused by the imageresizer Addon you are obviously using.

[BWJ]

Thanks for a nice mod. I have noticed a little problem:

Vbulletin version 4.1.11
Chrome and Firefox: seems to work perfectly
IE8: editor doesn't show up

[lachgas]

Thank `s Cellarius

[ehpoole]

Thanks for your reports; I have corrected the two code bugs you reported. Regarding the server error, however, I have never witnessed this myself or had any reports on it. I really don't have an idea either what could cause this or what I could to to try to reproduce it...

I apologize for the delay in getting back to you, I've been meaning to find the time to write this up for the past several weeks and you know how that goes once you start putting something off!

Anyhow, a few days after my original post I was able to find some time to continue debugging the photo_popup.php code and was able to determine that the cause of our "500 Internal Server Error" was caused by -- and please forgive me for my bluntness -- very inappropriate use of Cookies to spare a simple SQL Query. Basically, photo_popup.php was attempting to define a nearly 12KB cookie (approx 100 albums or 4KB unserialized), which grossly exceeds the standard HTTP Header buffer in Apache (8KB) and is a major violation of both the Cookie Specifications (http://www.ietf.org/rfc/rfc2965.txt) as well as the spirit of what cookies were intended for.

Per the Cookie Specifications (RFC2965) (http://www.ietf.org/rfc/rfc2965.txt) a site is only guaranteed support for a maximum of 20 cookies. The absolute maximum size for any cookie is 4KB (including data, expiration, and cookie name). Most importantly the absolute maximum storage available for ALL cookies for a given site is 4KB (i.e. one could do a single cookie of 4KB or 20 cookies of 204 bytes, or some combination that remains within these limits). As you are no doubt aware, vBulletin and its various Addons define a number of cookies, the exact number of which will vary from site to site, so in designing Addon components we must play nice and be respectful of the other cookies. Just as importantly from a design standpoint should be the recognition that ALL COOKIES must be transmitted by the browser to the web server with EACH and every request (even in Keep-Alive sessions). Given that the act of retrieving a single vBulletin page can easily entail many dozens of hits (HTML, CSS, images, buttons, etc), that quickly adds up to a lot of wasted bandwidth if we push our cookies to anywhere near 4KB (50 hits multiplied by 4KB is 200KB of bandwidth consumed just in cookies alone!). This is why cookies were never meant to exceed a few dozen to a couple hundred bytes at the absolute maximum.

Add to this issue that Web Servers have absolute maximums set on their HTTP Header buffers (8KB in Apache and 16KB in IIS), more than adequate for acceptable headers, we must be all the more respectful of the Cookie Specifications. Web Browsers also have their own limits (and only promise to abide by the Cookie Specifications) and have very undefined behaviors once the total cookies exceeds 20 or the total bytes exceeds 4KB -- some browsers will stop sending cookies altogether, some will begin deleting cookies to free up space, and others still will only transmit the portion below 4KB whenever the threshold exceeds 20 cookies or 4KB!

Any how, the simplest interim fix is to change line 220 (in Cel_PP 4.1.004) from:

vbsetcookie('photo_popup_albums', $cache_cookie, FALSE);
to
vbsetcookie('photo_popup_albums', '', FALSE);
you can also comment out line 218 since serializing $cache_cookie becomes irrelevant if we are not sending the cookie (well, we are but we're clearing it). This interim fix will prevent the web server from choking on an out-of-spec cookie and allow otherwise normal and expected behavior on the site. It will also reduce wasted bandwidth since the cookie will no longer be retransmitted to the web server for each and every hit requested by the user's browser.

In fairness, if you are concerned with regard to the cost of the SQL Query (much of which I would expect to be Indexed any how) the more appropriate strategy would be to create your own caching table (e.g. cellpp_cache) on the SQL server to store the aggregated information for the user(s). The cost of not only setting a large cookie (and possibly blowing up the web server) and the constant retransmission of such large cookies by the browser (to the server) on each and every request is, IMHO, far more costly than any SQL query the cookie may have been intended to spare the server.

For what it's worth, as a developer you are in good company in making this oversight. Before my retirement I spent quite a few years as a freelancer fixing web applications and by far one of the most common issues was developer failure to consider the upper and lower limits of their variable/storage types -- especially with regard to languages, such as C and SQL, where variables are rigidly typecast. Your issue with the out-of-spec cookie is very much the same sort of issue.

I really hope I have not been too harsh, but I feel strongly that if you make the changes I have suggested and keep storage limits in mind with future implementations you will have a much more superior product.

Lest I forget, our recent issues aside, we are very grateful for your work in developing Cel_PhotoPopup as our users very much appreciate the ease with which it allows them to insert photos from their albums.

If you have any questions or concerns with regard to any of my comments, please feel free to ask.

PS - I would also mention the missing "My Photo" toolbar text in plugin.js due to an unregistered variable, but I believe you mentioned already addressing that issue in an earlier post.

[Noerenberg]

reading before posting.

everthing is fine.

thanks for th great mod

[ChimeraRS]

Thanks for a nice mod. I have noticed a little problem:

Vbulletin version 4.1.11
Chrome and Firefox: seems to work perfectly
IE8: editor doesn't show up

Same problem here - any idea what might be causing it?

[Front Range 4x4]

Installed in 4.1.12 Patch Level 1, my members love it, thanks Cellarius!

Nominated

I have some attachments not showing up but can live with that for now. Benefits far outweigh this small issue.

[trackpads]

Again, thanks for the hard work on this!

[Hostboard]

I am getting a TMS error:


There are 1 Template-Modifications that were not designed for the currently installed vBulletin version. To make sure that vBulletin and your installed Products are working correctly, you must check and maybe modify those Template-Modifications.
It is stemming from editor_smiliebox


Regarding the TMS error: That may be because I may still be using an older version of TMS on my dev board. You should be able to ignore that.

I actually took some time to look at this and it seems it is the text within the template editor_smiliebox that your searching for is incorrect.

The search for text should be:

<vb:if condition="$show['moresmilieslink']">
<div class="moresmilies">[<a href="javascript://" onclick="vB_Editor['{vb:raw editorid}'].open_smilie_window(); return false" title="{vb:rawphrase showing_x_smilies_of_y_total, {vb:raw vboptions.smtotal}, {vb:raw totalsmilies}}">{vb:rawphrase more}</a>]</div>
</vb:if>


Once I corrected this, the text in the simile box appeared and is working as it was designed.

[Front Range 4x4]

Installed in 4.1.12 Patch Level 1, my members love it, thanks Cellarius!

Nominated

I have some attachments not showing up but can live with that for now. Benefits far outweigh this small issue.

Okay, the thumbnails not showing is a forum wide issue so it does bother me. Obviously it's not caused by this great mod but figured I'd ask if anyone knows a solution. Yes, rebuilding thumbnails works but requires rebuilding them all which starts at the beginning and it's the latest thumbnails that don't show up.

Does anyone have a better way to fix this?

[tbworld]

This is the top modification used on my board and by me. We love its integration into photopost and vbgallery. I haven't noticed the thumbnail problem, but I will check and see if I made any patches. I have made some minor patches to it along time ago. Still the greatest thing out there. Thanks Cellarius! (These guys never get the credit they deserve) :)

[Front Range 4x4]

I did state that "Obviously it's not caused by this great mod" but hoped someone would have an answer anyway. Maybe I shouldn't have posted it here.

My users and myself love this too!

[Ricsca]

Thanks

[AusPhotography]

Please add a module for Dbtech's Gallery :D

[AusPhotography]

Please add a module for Dbtech's Gallery :D
Here is a simple add on...
1. Add this to the product file in the <phrasetype name="GLOBAL" fieldname="global"> block
<phrase name="cel_pp_dbtech" date="1233344754" username="cellarius" version="2.2"><![CDATA[DBtech Gallery]]></phrase>

2. Upload the attachments to ./includes/cel and ./includes/cel/cel_pp_config as appropriate.

3. Re-import the product file, then edit the option and enable 'dbtech'

Enjoy! :D

cellarius - you (and anyone else) are free to use this code I wrote. No warranty or guarantee etc.

Kym

[ChimeraRS]

For people still having issues with this mod breaking IE 7 posting, I fixed it by going to Plugins and Products, Plugin Manager and disabling "Add CKEditor Configuration" in the Cel mod. It doesn't appear to have any adverse effects but it fixes the IE 7 "missing post box" problem.

[tpearl5]

Does anyone have any idea why the insert code would look like this?


<a href="#" onclick="thumbpaste('<img src=\'\' style=\'border: 0\' />','https://vborg.vbsupport.ru/');event.returnValue=false;return false;">

This suddently started happening on my site - I suspect there is a plugin that is interfering with the insert of the image url.

[tpearl5]

bump, anyone?

[tpearl5]

nevermind, I actually just realized that I only had an option for medium, and there is no 'med' option for regular attachments. That's why I was getting the blank insert code above.

[tommythejoat]

When I open the popup in the editor and select attachments, I see a drop down with all my attachment sub-folders listed but if I try to search or list the contents of any of them the result is mostly empty and what does show is not in the proper category.

I don't see any setting to address this but I have not looked at the code.

I ran a query to see if the identifiers were in the database with this result. It loks like I should be seeing lots of images to choose from.


SQL query:
SELECT count(`filedataid`) count,
min(`filedataid`) Lo,
max(`filedataid`) Hi,
`categoryid`
FROM `attachmentcategoryuser`
WHERE `userid` = me
group by categoryid LIMIT 0, 30 ;
Rows: 24
count Lo Hi categoryid
1269 153 174971 0
12 115122 137322 1
6 112866 116874 2
3 127463 127465 6
63 128128 128190 7
21 135567 135806 9
18 138488 138505 11
8 139374 139381 12
7 139610 139616 13
13 139779 139791 14
14 139813 139826 15
13 140048 140060 16
17 140411 140428 17
5 140826 140830 18
7 146336 146342 20
4 146708 149977 21
4 118857 148660 22
21 148860 154965 23
9 162544 162552 67
29 164775 165197 68
8 165910 165917 69
11 167796 167806 70
4 167887 167890 71
3 168602 168604 72

[tommythejoat]

I have been working to get this integrated with vBGallery. I finally got to the point where I had to start reading code because of lots of database error messages. It seems like the vbgallery class file is nothing like the vbgallery for 4.2 that I have installed. i.e. there is no permissions table for example and it uses Scandal's sc_ prefix for the 3 tables it does use for gallery, gallery_search and gallery_stats.

Is there another mod besides this one called vBGallery? https://vborg.vbsupport.ru/showthread.php?t=284213&highlight=vbgallery

[cellarius]

Yes. There is vBGallery. Why this guy would name his addon the same as a gallery that has been around for a decade or so really beats me.

http://www.photopost.com/why-vbgallery.html

[tommythejoat]

Thanks for the clarification. I searched this site for vBGallery and Scandal's was the only one that showed up so there was no apparent name conflict.

I see that Photopost comes in two commercial flavors bundled together in the license. That. explains the two variants in your settings.

I will take a look at the pp vBGallery demo and try to decide if I would rather use it or create the config and class files for Scandal's vBGallery. I presume you would have no objection to me doing that. I have already spent about 12 hours learning that product.

[angeryamerican]

Has anyone implemented this on 4.2.1 This looks terrific, but I don't want to experiment.

[tbworld]

Has anyone implemented this on 4.2.1 This looks terrific, but I don't want to experiment.

I run v4.2.0, I am slowly upgrading to v4.2.1 (we use alternate core code). I actively use this mod on my daughters 'small' board, and it works well. I do not see why there would be a problem with this mod in v4.2.1. The upgrades in v4.2.1 should not affect this mod.

Never run new code on your production system without thorough testing. When you do release it to the production system, test it with select groups before putting it out there in the wild.

For the record cel's code is pretty solid.

[tommythejoat]

Photo Popup works fine for vBulletin Albums and Attachments. I could not get Photoplog to install so I could test it.

I did modify the code to use the categories in attachments. As built it does not list by category in the attachments although it does show the category list.

Here is a screen shot with my mod for attachments:

[AusPhotography]

Has anyone implemented this on 4.2.1 This looks terrific, but I don't want to experiment.

Yes, it works well. We have added the DBtech Gallery as well.

Kym

[tommythejoat]

What would it take to add the ability to choose attachment format in the photo popup view along with thumbnail, original, etc.

The main feature missing is the ability to size attachments when inserting into posts as one can with the attachment manager.

Attachments and albums are integrated in the Scandal vBGallery and attachment images can be inserted with Photo Popup, but they go in as image references and cannot then be edited.

The user interface is much nicer for Photo Popup than it is for the Attachment Manager. I would really like to have the ability to insert all the images from albums and attachments in the attachment format.

[Zoul]

hello

is that this plugin works with PhotoPlogPro_2.1.6 for VB 4.2.1?

thank you

[jjohns12]

Has any one run across this I have installed this mod on VB 4.2.2 and receive this when clicking editor icon or my photos button.

Photo Popup Error #2: missing config file

The class file includes/cel/cel_pp_class_albums and/or the configuration file cel/cel_pp_config/cel_pp_config_albums for this product is missing. Please consult installation instructions for this mod.

Can anyone help me out with this or where to look to fix this?

Thanks

[ozzy47]

Are you sure you uploaded all the files from the mod to the proper places?

Did you follow all the installation instructions?

Installation


Extract the archive.
Choose the products you want to use and rename the configuration files in _UPLOAD/includes/cel/cel_pp_config from .php_new to .php
If you're using Photopost Pro, you need to fill in some crucial information into the config file. Please see the config file for more information.
Upload the contents of folder "_UPLOAD" to your forum root. Note how the folder structure mirrors the folder structure in your forum root, so every file will be in the right place.
Now the Photo Popup and your chosen product configuration files will be present with default settings on your server. Later on, you may want to make adjustments there.
Install the product file at AdminCP->Plugins & Products->Manage Addons.
Template edits?
If you are using new editor, you're done.
If you are using old Editor and Template Modification System (TMS), you're done.
If none of the above two conditions apply to you, do the template modifications explained in _DOCS/OLD_EDITOR_ONLY-template_edits.txt manually for the editors you want the popup accessible from.

[jjohns12]

Did you follow all the installation instructions?

DOOOOOO No! I did read them just didnt click in!

Works now forgot to rename file!

Now just have to figure out to get DBtech Gallery working with it and i am set.

Thank you as always you are a great help! :)

[ozzy47]

Not a problem, glad to help. :)

[jjohns12]

This mod is great thanks for your hard work and thank you to ozzy47 for making me read! and Kym for the DBtech Gallery Addon. Nice! :) My users will love this!

[ozzy47]

UMMM, kym made vBgallery, not DragonByte Gallery. :)

[jjohns12]

UMMM, kym made vBgallery, not DragonByte Gallery. :)

The way it seems is he wrote the addon for this mod to work with DB Gallery see post 285 correct me if i am wrong. I was just thanking him for posting a addon for this mod.

https://vborg.vbsupport.ru/showpost.php?p=2379282&postcount=285

I love DB Gallary DragonByte Tech Wrote it I use tons of mods from them.

:confused: Sorry if I confused anyone with my earlier post

[ozzy47]

Ahhh, ok gotcha. :)

[gsmlover4u]

any update for vb5

[ozzy47]

any update for vb5

I doubt it, the developer is not going to do it.

Please note that there will be no further updates to my addons, especially they will not be upgraded for vB5. I'm leaving vB, since IB choose to go the banana-way yet again.

[cellarius]

any update for vb5
As ozzy said: Sorry, no.

[inigo]

Great mod,

I am looking for increasing the utility of this mod.

The idea is to create a category in vbgallery, and let the users upload their photos to it. So then select them from your mod.

Is it any addon that allow to do this from the forum editor?

I press the new icon, and it appears vbgallery upload images box. Directly to the category selected, and afetr uploading this mod appears and let the user select the photos,

Thanks in advance for any help,

Best regards,

[RichieBoy67]

Is this compatible with 4.2.2?

[AusPhotography]

The way it seems is he wrote the addon for this mod to work with DB Gallery see post 285 correct me if i am wrong. I was just thanking him for posting a addon for this mod.

https://vborg.vbsupport.ru/showpost.php?p=2379282&postcount=285

I love DB Gallary DragonByte Tech Wrote it I use tons of mods from them.

:confused: Sorry if I confused anyone with my earlier post

We changed Galleries, I wrote one for each, the link above is for DBtech

[420]

We use the My Photos button below editor, when editing a post and using this button to add image. The image is added to the quick reply box instead of the post edit box.

Has anyone come across this bug and is there a fix?

[K4GAP]

Rather than read all the pages of comments, does this work with the default gallery already in vb? And most importantly, does it work with 4.2.2 ?

[cellarius]

There is no default gallery in vB4. There are the albums, and the first post states in the very first sentence that it works with albums.

[K4GAP]

Is this compatible with 4.2.2?

Have you tried this on 4.2.2 ? and did it work?

[Zoul]

Hello
I'm the procedure to the letter.
I set everything right.

if I enter
admincp / settings / Option / Cel Photo Popup / Products
I leave:
* albums
* attachments
everything works perfectly

if I add:
* vbgallery

knowing that I have the pro version 1.3.2 this bug.:

Database error in vBulletin 4.2.1:

Invalid SQL:

SELECT varname, value
FROM ppgal_setting
WHERE
varname IN ('gallery_fileurl', 'gallery_url', 'gallery_insafemode', 'gallery_saveoriginal');

MySQL Error: Table 'forum.ppgal_setting' does not exist
Error Number: 1146

Can you help me?

Ty

[AusPhotography]

Which Gallery do you installed on your site?

There are two version from PhotoPost.

[Zoul]

I'm sorry for the delays in reply to atttente

I installed vBGallery (pro, the last)

[Hent]

when members upload new photos they're not showing up in the popup... anything to do to fix this?

[asabet]

This was working great for me before. Now not working. I don't know if it's because I upgraded to vB 4.2.2 or possibly because of installing Opcache and memcached. But when members click the link to go to their photos, it shows blank pages instead of their Photopost photos.

Like this:

https://vborg.vbsupport.ru/external/2015/02/25.png

[AusPhotography]

Works for us on 4.2.2pl4 / PHP 5.4 / Xcache

[asabet]

Good to know. Are you using Photopost?

[AusPhotography]

No we dropped Photopost and now use DBtech Gallery

[asabet]

I don't know if it's something I'm doing wrong, but I can't get this addon to work with 4.2.2PL4 and Photopost Pro.

[tommythejoat]

The tool is working with our 4.2.2 but there is no tool tip for the button in the toolbox for the editor.

The instructions for fixing the tool tip appears to be for a non-CKEditor implementation.

Help!

Previous fix does work and text is controlled by the phrase.

[smirkley]

Trying a few things to get the ckeditor to display the button.

[smirkley]

For anyone else having issues on this cool add-on;


First, if using TMS, the error shows up in the updated template.
The fix is posted here, as the Search for Text box needs to have the code in it instead of what the product installer put in it. Refer to the following link:
https://vborg.vbsupport.ru/showpost.php?p=2335940&postcount=279

Now, I didnt really like the output formatting located right under the smilies area, so I modified the replacement code. Be sure to change the TMS to Replace the text instead of the original Insert Text Below. Insert the following code into the bottom code box in the TMS editor for that template:
<vb:if condition="$show['moresmilieslink']">
<div class="moresmilies">[<a href="javascript://" onclick="vB_Editor['{vb:raw editorid}'].open_smilie_window(); return false" title="{vb:rawphrase showing_x_smilies_of_y_total, {vb:raw vboptions.smtotal}, {vb:raw totalsmilies}}">More Smilies</a>]</div>
</vb:if>
<br /><br />
<div class="moresmilies">[<a href="#" onclick="window.open(getBaseUrl() + 'photo_popup.php?{vb:raw session.sessionurl}e={vb:raw editorid}','fotos','scrollbars=yes,resizable=yes,w idth={vb:raw vboptions.cel_pp_width},height={vb:raw vboptions.cel_pp_heigth}'); return false" title="{vb:rawphrase cel_pp_insertlink}">{vb:rawphrase cel_pp_my_photos}</a>]</div>
Yes, I know I replaced a phrased text for one unphrased statement, but it works without having to change anything else. You can phrase it if you want to.


Second, The tooltip on the button doesnt show. The fix for this is clearly posted here:
https://vborg.vbsupport.ru/showpost.php?p=2301227&postcount=265


Third, the tool icon doesnt show. This is a bit more difficult and my fix may not necessarily be your fix, and for me required some hardcoding of the image url into the js file. I am using vb4.2.0pl3 at this moment, and this should fix this issue for those using a reasonable close version as I.

Now, on some of my image source stylevars, I am using subdomains that help to increase page rendering speed in browsers. But this is not the only issue for me.

Open up and view in your favorite editor the following file:
\cel_pp_4-1-004\_UPLOAD\clientscript\ckeplugins\cel_pp\plugin. js

Look for this code:
icon: BBURL + '/' + IMGDIR_BUTTON + '/cel/cel_photo_popup.png',

The first thing I noticed is that the editor icons are fetched from the images/editor/ directory, not the images/buttons/ directory. At least in my setup and vb version.

So I moved the /cel/cel_photo_popup.png from the images/buttons/ directory and put in into the images/editor/ directory.

But that isn't everything, at least for me.

Since, as I stated, use a subdomain to serve these images, I had to remove the BBURL and hardcode the actual url into the js file. I tried using some other ways, but since it didnt work, this is how I resolved it. I changed the above code shown, to the code below. It works. Just be sure to put your proper domain or subdomain into the xxx's.
icon: 'http://xxx.xxxxxxxx.com/cel/cel_photo_popup.png',

Now, if you are not using a subdomain for image fetching it may look more like this:
icon: 'http://www.xxxxxxxxx.com/images/editor/cel/cel_photo_popup.png',

If I could find the proper replacement for the IMGDIR_BUTTON as in IMAGE_EDITOR (which wouldnt work for me), then that may provide a better universal solution for everyone, but if you are using a subdomain as I said, then you will have to get rid of the BBURL + '/' + anyways to make it work, otherwise it will append your root domain into the image source.


Hope this helps some of you.

Awsome mod Sven !!!

[markoroots]

Hi @Cellarius, really useful plugin. Thanks. But please is it possible to use all the VB users albums, instead of those personal?
It is also important to add a search box.
And also is it possible to use also this Gallery plugin: https://vborg.vbsupport.ru/showthread.php?t=319444 ??


Thanks in advance.

[scribble]

After we've moved our board to a more modern server than before, we've encountered a similar problem to what asabet mentioned (https://vborg.vbsupport.ru/showthread.php?p=2536719#post2536719) above: The total image count and the pagination seemed correct, but there were not images to click on in the popup.

I poke around a bit in the code, and seems that the result set for the main database query did not get processed correctly. The SQL query itself delivered the correct results. But when photo_popup.php tried to construct the imagebits, it went wrong.

$resultcount = $cel_pp_prod->db->num_rows($cel_pp_prod->mysql_result_main);

returned 0, even though the db result set had 9 rows.

Similarly, some lines further down,

while ($array = $db->fetch_array($cel_pp_prod->mysql_result_main))
...

seemed to exit without any passes of the loop, because $db->fetch_array() didn't find any records in the result set either.

After I switched both functions to the "normal" PHP 5.x versions, mysql_num_rows() and mysql_fetch_array() respectively, the images appeared in the popup as they should.

I'm not really sure why this hotfix worked (and your mileage may vary, so use it on your own risk :p). We modernized our hosting stack quite a bit, Nginx replacing Apache, newer MySQL and PHP versions etc., so I can only guess what's exactly the cause. But maybe my observations can help others or the author of the mod to further enhance it :)

Yours,

scribble