Get rid of "Notice" messages after changing index.php

[jonty]

After altering index.php to enable scores to be saved, we had an issue with 'notice' messages appearing at the top of the index.php page.
From what i can make out, this is just a warning that variables havent been set or don't exist.
The reason some sites get it and others dont, is that you can turn this off in php.ini if you have access.

I didn't really want to mess about with the .ini file, so I've set a few checks in the script for index.php.

Works for us, hope it works for you too.
This is replacement code for the code in the "INFO - vbadvanced or another Portal.txt" document

// ibProArcade
if(isset($POST['module']) && $_POST['module'] == "pnFlashGames")
{
require_once('./global.php');

switch($_POST['func'])
{
case "storeScore":
$_GET['act'] = "Arcade";
$_GET['module'] = "arcade";
$_GET['do'] = "pnFStoreScore";
break;

case "saveGame":
$_GET['do'] = "pnFSaveGame";
break;

case "loadGame":
$_GET['do'] = "pnFLoadGame";
break;

case "loadGameScores":
$gid = $vbulletin->input->clean_gpc('p', 'gid', TYPE_INT);
$uid= $vbulletin->userinfo['userid'];
$game = $db->query_first("SELECT * FROM " . TABLE_PREFIX . "games_scores WHERE mid=$uid AND gid = $gid ORDER BY score DESC LIMIT 0,1");
$scores = $game[score];

if($scores != false)
{
//Return true
print "&opSuccess=true&gameScores=$scores&endvar=1"; //send endvar to keep opSuccess separate from all other output from PostNuke
}
else
{
print "&opSuccess=false&error=Error&endvar=1";
}
break;
}
}

if(isset($_GET['act']))
{
$act = $_GET['act'];
}
if(isset($_GET['act']) && isset($_GET['autocom']))
{
$autocom = $_GET['autocom'];
}
if(isset($_GET['act']) && isset($_GET['showuser']))
{
$showuser= $_GET['showuser'];
}

if((isset($act) && $act == "Arcade") || (isset($autocom) && $autocom=="arcade")) {
include "arcade.php";
exit();
}
if(!empty($showuser) && $showuser >= 1) {
$u = $showuser;
$_GET[u] = $showuser;
include "member.php";
exit();
}

// end of ibProArcade

There's probably a neater way of doing it, but it works for us :D

[TriAxis]

Well this helped quite a bit. I am getting this same situation.

Once I put your code in place only one "Notice: Undefined variable:" remained.

It is the one referencing this line.

if($act == "Arcade" || $autocom=="arcade") {

Otherwise this is the best fix so far for the notification at the top of the index file and the score posting page.

Any ideas about that one line?

Thank you for your efforts!

[jonty]

Well this helped quite a bit. I am getting this same situation.

Once I put your code in place only one "Notice: Undefined variable:" remained.

It is the one referencing this line.

if($act == "Arcade" || $autocom=="arcade") {

Otherwise this is the best fix so far for the notification at the top of the index file and the score posting page.

Any ideas about that one line?

Thank you for your efforts!
You're welcome :up:
I cant replicate that error on our test system, but changing the line to
if((isset($act) && $act == "Arcade") || (isset($autocom) && $autocom=="arcade")) {

might do the trick
(I'm not sure if php processes the whole conditional (in which case it might fail) or if it just process the first part (in which case it should work).

Alternatively changing the 3 if statement before
if(isset($_GET['act']))
{
$act = $_GET['act'];
}
if(isset($_GET['act']) && isset($_GET['autocom']))
{
$autocom = $_GET['autocom'];
}
if(isset($_GET['act']) && isset($_GET['showuser']))
{
$showuser= $_GET['showuser'];
}


to

if(isset($_GET['act'])) {$act = $_GET['act'];} else {$act="";}
if(isset($_GET['act']) && isset($_GET['autocom'])) {$autocom = $_GET['autocom'];} else {$autocom="";}
if(isset($_GET['act']) && isset($_GET['showuser'])) {$showuser= $_GET['showuser'];} else {$showuser="";}

[TriAxis]

You're welcome :up:
I cant replicate that error on our test system, but changing the line to
if((isset($act) && $act == "Arcade") || (isset($autocom) && $autocom=="arcade")) {

might do the trick


Yes! This worked! You are a gentleman and a scholar!




if(isset($_GET['act'])) {$act = $_GET['act'];} else {$act="";}
if(isset($_GET['act']) && isset($_GET['autocom'])) {$autocom = $_GET['autocom'];} else {$autocom="";}
if(isset($_GET['act']) && isset($_GET['showuser'])) {$showuser= $_GET['showuser'];} else {$showuser="";}


I did do this code replacement trying to fix the problem below with no luck.

What is interesting is that the error messages have disappeared and I don't get the security token error...but... the only games on my arcade that save their score are the ones that come with the mod. Every other game I have loaded... 52 at the moment... will play and seem to work, but when you finish the game and submit the score, the screen just stays blank and the screen never changes.

I will investigate this new issue and see what I can find.

But again... thank you very much for your work. :up:

[jonty]

Yes! This worked! You are a gentleman and a scholar!




I did do this code replacement trying to fix the problem below with no luck.

What is interesting is that the error messages have disappeared and I don't get the security token error...but... the only games on my arcade that save their score are the ones that come with the mod. Every other game I have loaded... 52 at the moment... will play and seem to work, but when you finish the game and submit the score, the screen just stays blank and the screen never changes.

I will investigate this new issue and see what I can find.

But again... thank you very much for your work. :up:

i got that and discovered it was the v32 versions of the games that froze, but the v2 games were ok.

I'll amend the first script with the changes that worked. :up: