Super Speedy UserCP

[Birched]

TIME TO INSTALL: 10 seconds (requires editing of one file in one place)

This simple code modification increases my usercp.php loading speed by 6x. I think it will be most useful in cases where there are many subscribed forums.

It is listed as a modification for version 3.8.3 (which I am currently working with), but this mod works as far back as 3.0.1 (the 'find' text might be slightly different, but the function name and the text you replace is the same).
EDIT: Tested up to 3.8.4.

It works because the php function is_array() is excruciatingly slow, and an empty array gives the same return value as an empty variable.

This code would likely break if someone introduced a location in the code where the $lastpostarray variable was set to something (i.e. not nothing) that was not an array.

There are lots of these checks in the vBulletin code. It's likely that further speed increases could be achieved by changing more of them -- just remember that there is an unlikely circumstance (see previous paragraph) where it would cause problems. If you find other locations with significant effects, please post them in a reply!

##### IN FILE

functions_forumlist.php

##### FIND

function construct_forum_bit($parentid, $depth = 0, $subsonly = 0)
{
global $vbulletin, $stylevar, $vbphrase, $show;
global $imodcache, $lastpostarray, $counters, $inforum;

// this function takes the constant MAXFORUMDEPTH as its guide for how
// deep to recurse down forum lists. if MAXFORUMDEPTH is not defined,
// it will assume a depth of 2.

// call fetch_last_post_array() first to get last post info for forums
if (!is_array($lastpostarray))

##### REPLACE

if (!is_array($lastpostarray))

##### WITH

if (!$lastpostarray)

#####

And that's it! Enjoy, and I hope it helps!

[erel34]

thanks

[down.low]

One mistake:

##### REPLACE

if (!is_array($lastpostarray))

##### WITH

if (!i$lastpostarray)

#####

if (!i$lastpostarray)

should be the following:

if ($lastpostarray)

[Birched]

Thanks - fixed.

EDIT: To be clear -- there used to be a typo with an 'i'. The correct replacement is what is stated in the original post, and not what is stated in the post before this one.

i.e. the following is correct:

##### REPLACE

if (!is_array($lastpostarray))

##### WITH

if (!$lastpostarray)

#####

[Kolbi]

Are there other comments about the lower loading time?

[relaxiha]

If you put together the best images is to be determined

[Kolbi]

If you put together the best images is to be determined
???
Wrong thread?

[gearspro]

Thanks i wouldnt say 6x quicker but it is faster :)

Didnt work the 1st time :( tryed again then it worked, must of done something wrong.

[Birched]

Based on microstats, I went from 32 seconds to 5 seconds with this one change (caching was turned off at the time). I saw a similar improvement when I did this with older boards. It will definitely depend on the number of times the code loops through that call -- so if you have more subscribed forums, or forums with more content, it will help more.

Others are definitely invited to post their measurements here. I'd be interested in how much it helps in other situations.

[hotwheels]

Wow that is pretty kewl..........I would have to say it is atleast 6x faster.

thanks a bunch.

[jambo_1969]

It is a bit quicker, HOWEVER, it zero's all the stats from the main forum.php page - so it looks like there are no posts and no views.

[Birched]

That doesn't happen for me at all -- check your braces (it sounds like you may have corrupted the surrounding function?), and if that doesn't fix it, then post in your change here for me to look at (or pm it.)

[unp]

One mistake:


if (!i$lastpostarray)

should be the following:

if ($lastpostarray)

Thanks - fixed.

Its still ' if (!$lastpostarray)' in the frst post.
So what should it be ?

[jambo_1969]

Its still ' if (!$lastpostarray)' in the frst post.
So what should it be ?

I'm assuming the one in the OP, as I put the amended one from the later post in, and it zero'ed all post/view counts on forum home.

[unp]

I get and error with if (!$lastpostarray)


Parse error: syntax error, unexpected T_VARIABLE in /home/unp/public_html/includes/functions_forumlist.php on line 156


With if ($lastpostarray) All post/view are Zero on forumhome.

[Birched]

Its still ' if (!$lastpostarray)' in the frst post.
So what should it be ?

The error was the letter 'i' that used to be there (look more closely.)

[Birched]

I get and error with if (!$lastpostarray)


Parse error: syntax error, unexpected T_VARIABLE in /home/unp/public_html/includes/functions_forumlist.php on line 156


With if ($lastpostarray) All post/view are Zero on forumhome.

Please post your modified code. That is what you'd get with a typo.

[unp]

I tried again and it worked.I must have done something wrong the first time.

[TWTCommish]

I assume this only speeds up the UserCP if the user has subscribed to forums? I ask because very few of my users use that feature.

[Birched]

I assume this only speeds up the UserCP if the user has subscribed to forums? I ask because very few of my users use that feature.

That's what it looks like. It's easy to try, though.

[merkaz]

Amazing .

good job . thanks

[NLP-er]

Rated, installed :)

Small things can make big difference ;)

[GhoHan]

Nice idea ... good installed

[testebr]

You already reported this 'issue' on vb.com board?

[nomoreturn]

Thanks works great on 3.8.4

[Birched]

You already reported this 'issue' on vb.com board?

The problem has been mentioned previously both there (vbulletin.com) and here (vbulletin.org) (earlier by others, more recently by myself). The vbulletin coders would have to make a "substance over style" decision to implement this change in the core code, at least in the specific manner in which I've implemented it. I don't think that's very likely, but who knows? The issue has been around for a long time....

[WebkinzCoast]

I assume this only speeds up the UserCP if the user has subscribed to forums? I ask because very few of my users use that feature.

Actually, it sped up mine by a good five seconds and I have no subscribed forums.

[WebkinzCoast]

Working great over here!

[mahz]

Cool. I have a large forum with a lot of heavy subscribed-threads usage. I already marked Installed and rated (I love simple code optimizations), but I like numbers/metrics and would like to see if it changes anything and by what margin.

What's a good way to see page load times? I'm a total noob. :o

How do I turn off caching, too, so I can get more realistic numbers?

Thanks!

[New Joe]

Works fine and fast.

[ChiNa]

Somebody said that he made a mistake,,, Now can anyone follow up to what is right 1 or 2?

Options1: if (!i$lastpostarray)

Option2: if ($lastpostarray)

Thank you in advance...

[Birched]

I am using it as written in the OP.

EDIT: to be clear: the typo a few years back was that I had an extra 'i' in the code. You want to use the text in the original post, which is not option 1 or option 2 in your post, but:

Option 3: if (!$lastpostarray)

[ChiNa]

Ohh Ok, U actually have edited your post then, bcoz that was what I did use too.. if (!$lastpostarray)

One last question, is it ok to use on a vBulletin 3.8.6 or 3.8.7.. I mean I wont get later any affect on my other pages or maybe errors...

Thanks for the tip

[Birched]

Should be fine for 3.8.x. Definitely works for 3.8.6.

[ChiNa]

Thanks, Birched, What about the 3.8.7, its Same as 3.8.6, Am sure it will work out too.. Coz almost the optiones and files are same, Thanks a lot for your time mate... Appreciated.

[tehPARADOX]

Thanks.

[career]

can't see difference when enable it.
Pls, could you suggest how to test it.

thanks

[lazytown]

Any idea if this issue affects 4.2?

[xlguy]

Have just tried this on 3.8.7 PL2 :)

[blind-eddie]

Have just tried this on 3.8.7 PL2 :)

Yes, don't use this edit.
It shows forum home to have zero post & sets all forums to private, But, your results may differ.

[Birched]

Yes, don't use this edit.
It shows forum home to have zero post & sets all forums to private, But, your results may differ.

What? Is is possible you have misplaced a semicolon somewhere?

EDIT: Also, you'll note that people who didn't use the exact code in the original post have had a similar problem in the past.