MySmilies vB (v3.8.0)

[Eric]

Please click Mark as Installed if you are using this hack, and Nominate For MOTM or Support Developer if you enjoy this hack and would like to support it's development.
.

Please read the entire thread before posting your problem, chances are it's been fixed.

Those who have "Mark As Installed" will receive priority support


NOTE: I have marked this hack as Re-usable Code - This means that code from this hack may be used in other hacks, which can ONLY be released on official vB sites that use Jelsoft's verification system to verify your vBulletin license status, and as long as Kentaurus, Mosh, and I (SecondV) are credited in your hack.

This is a port of Mosh's MySmilies VB for v3.7.x to work with vBulletin v3.8.0.
Mosh's was a port of Kentaurus's MySmilies VB for v3.6.x (version 1.03) to work with vBulletin v3.7.0.


vBulletin Version Compatibility & Permission Info

This hack was tested on vB 3.8.x - but it should work on vB 3.7.0 and later.

Permission for me to port his hack is granted here:

Info for hackers:
You may modify, improve, upgrade, redistribute this hack, include it
in another hack or yours or translate it provided you do it free of
charge and you distribute it in www.vbulletin.org at least, there is no
need to pm me asking for permission
Some portions of the code are (c) Jelsoft Enterprises Ltd.

And here:
NOTE: I have marked this hack as Re-usable Code - This means that code from this hack may be used in other hacks, which can ONLY be released on official vB sites that use Jelsoft's verification system to verify your vBulletin license status, and as long as Kentaurus and I are credited in your hack.



What Does This Hack Do?

This hack puts the control of the smilies on the users. It lets any user (that you give permission to) upload or modify the smilies that he can use.

These are not the smilies that vb uses, these are user-customized smilies. The smilies that you already have in place are preserved and are still used. But users may upload their own smilies for their use, and they are kept separate from the standard forum smilies.

For users:

Users can keep a library of their own smilies (they can upload them from their computer or web)
Users enter their replacement text, for example, :iamhappy: would be changed to their own user happy smilie
The custom smilies are parsed in any post, signature, or pm
If they have enabled the WYSIWYG editor, smilies are shown there


For administrators:

Usergroup control of who may upload custom smilies
Usergroup control of the size (width, height, size in bytes) of the smilie
Smilie quota, both for max number of smilies and max number of bytes or hard disk space
The administrator can choose where to save the smilies (the directory, default: mysmiliesvb)
Auto-template Injection - if the appropriate template hooks are available, you will not need to make any template edits at all, if edits needed you only need to paste a single variable where you need it




Installation Instructions

See the included Installation Instructions.txt file in the sv_mysmiliesvb.zip zip file.

ADDITIONAL NOTE:
A limitation exists with the fix that rectifies the problem of attachments showing when also posting them inline within the same post; when applied, all attachments will need to be displayed inline, if they have not been, then the ones that have not been posted inline will be hidden along with the ones that have been posted inline. Read Post #106 for more information on this. -- I'm working on this



Uninstall Instructions


Delete mysmiliesvb.php from your forum's root directory.
Delete the mysmiliesvb directory from your forum's root directory.
Delete class_dm_mysmiliesvb.php from your forum's /includes directory.
Delete bitfield_mysmiliesvb.xml from your forum's /includes/xml directory.
Delete delete.gif from your forum's /images/misc directory (if more than one style remember to delete it from all misc directories).
Optional Step: This step is only if the auto template injection does not work, and you did the optional template edits.

In the USERCP_SHELL template, find and delete:
$mysmilie_usercp
In the navbar template, find and delete:
$mysmilie_navbar
Uninstall the product in vB using the AdminCP Product Manager.




To Do List

Features are being done in the order that they appear on the list.

Admin Control Panel utility to view/delete one, some or all custom smilies
Add custom user smilies to the misc.php?do=showsmilies page and to the "More Smilies" popup.




Version History
v3.8.005 - June 23rd, 2011
-- Fixed: "Warning: Invalid argument supplied for foreach()" errors.
-- Changed: how the smilie datastore cache is generated/accessed.
-- Added: Option to pull all user smilies for the editor or just the current user id's smilies.

v3.8.004 - January 15th, 2010
-- Changed: query() calls were being used instead of query_read()
-- Changed: Smilies are now built and added to datastore cache
-- Changed: Since smilies are stored in the datastore, smilies are no longer queried/parsed by userid.
-- Fixed: Custom smilies not parsed when quoted by other users.
-- Added: /includes/functions_mysmiliesvb.php - build_mysmilies_datastore() function.

v3.8.003 - August 5th, 2009
-- Fixed: Ok, should finally be fixed on upgrade - no more parse errors.
-- Fixed: Those upgrading from Mosh's version should be fine now.

v3.8.002 - August 4th, 2009
-- Fixed: errors when upgrading from previous versions of MySMilies should be fixed.

v3.8.001 - August 4th, 2009
-- Initial v3.8.0 release - mod taken over by Eric Sizemore (SecondV)
-- Fixed: standard_error calls were not using eval() as they should be
-- Fixed: Some queries were not using TABLE_PREFIX
-- Fixed: Even though phrases were in place, some parts of the mod used hardcoded langauge strings.
-- Fixed: Some errors in templates, missing ending tags, etc.
-- Fixed: Upload - the upload source didn't appear to be detected properly.
-- Changed: "maxversion" in the product XML increased.
-- Changed: "hard delete" option no longer on by default.
-- Changed: The "mysmiliesvb" table was altered to have KEY's on the "userid" and "dateline" columns. Hopefully this will increase performance/smilie lookups.



Thanks

My thanks go out to Kentaurus (who originally created this fantastic hack), Mosh who updated the hack to v3.7, and Paul M who gave permission to use some of his install code.



Show Your Appreciation

Although not required, if you have enjoyed the benefits of this hack, and would like to show your appreciation for my efforts, then please feel free to click on the Support Developer link and donate any amount you feel is appropriate. This would go a long way in encouraging me to continue to develop this project, as I'm currently unemployed.

----

Because of the limitations on screenshots in place by vBulletin.org (can only upload 10) - you can view the screenshots here:

... coming again soon ...

[Eric]

reserved...

[Hostboard]

First install...w00t...

Been running the older version and seem to be ok. Will be upgrading tonight to this one since it officialy is released for 3.8 Are there directions on how to upgrade?

Thank you

[Eric]

Really, just follow the normal install instructions - but when you import the product XML - just set it to Allow Overwrite.

[am-fs]

Will this verison work with MGC Chatbox Evo?
https://vborg.vbsupport.ru/showthread.php?t=168992

Error on Upgrade

Database error in vBulletin 3.8.1:

Invalid SQL:
ALTER TABLE usergroup ADD mysmiliesvb_permissions INT DEFAULT 1 NOT NULL;

MySQL Error : Duplicate column name 'mysmiliesvb_permissions'
Error Number : 1060
Request Date : Tuesday, August 4th 2009 @ 05:51:18 PM
Error Date : Tuesday, August 4th 2009 @ 05:51:18 PM
Script : http://localhost/forum/admincp/plugin.php?do=productimport
Referrer : http://localhost/forum/admincp/plugin.php?do=productadd
IP Address : 127.0.0.1
Username : am-fs
Classname : vB_Database
MySQL Version : 5.1.30-community

[goxy63]

This is great
Thanks a lot

Hope it will work with my other mods

Small question, smiley shortcuts created by user will be good only for him of course, and as usual all generic smileys will keep their shortcuts?
User will be refused to use reserved generic shortcuts?

Cheers

[Eric]

Looking into this error - as far as MGC Chatbox, honestly I'm not sure if it will or not.

Will this verison work with MGC Chatbox Evo?
https://vborg.vbsupport.ru/showthread.php?t=168992

Error on Upgrade

Database error in vBulletin 3.8.1:

Invalid SQL:
ALTER TABLE usergroup ADD mysmiliesvb_permissions INT DEFAULT 1 NOT NULL;

MySQL Error : Duplicate column name 'mysmiliesvb_permissions'
Error Number : 1060
Request Date : Tuesday, August 4th 2009 @ 05:51:18 PM
Error Date : Tuesday, August 4th 2009 @ 05:51:18 PM
Script : http://localhost/forum/admincp/plugin.php?do=productimport
Referrer : http://localhost/forum/admincp/plugin.php?do=productadd
IP Address : 127.0.0.1
Username : am-fs
Classname : vB_Database
MySQL Version : 5.1.30-community

yes, yes
This is great
Thanks a lot

Hope it will work with my other mods

Small question, smiley shortcuts created by user will be good only for him of course, and as usual all generic smileys will keep their shortcuts?
User will be refused to use reserved generic shortcuts?

Cheers

[Eric]

v3.8.002 - August 4th, 2009
-- Fixed: errors when upgrading from previous versions of MySMilies should be fixed.

[alfaowner]

Will this show custom smilies on blogs and other addons? The old version didnt.

[trotskid]

Thansk for the update!

It's necessary to full uninstall the old version or just import the product?

[Eric]

Will this show custom smilies on blogs and other addons? The old version didnt.
It should show the smilies for anything that uses the bbcode parser and the editor (either standard or wysiwyg) - I do not have the Blog product, so I can't confirm that for you.

Thansk for the update!

It's necessary to full uninstall the old version or just import the product?
Re-upload the files, and re-import the product with "Allow Overwrite" set to yes, and that should take care of it. There are no major changes as far as the database table for MySmilies - everything should be fine. :)

But, if you're a 'safety freak' like I am, hehe, make a backup of your current MySmilies database table, and files before doing so.

[Oblivion Knight]

I get a parse error on both the install and uninstall of this product..

Parse error: syntax error, unexpected '{' in /xxx/xxx/xxx/forums/admincp/plugin.php(1575) : eval()'d code on line 11

[Eric]

I get a parse error on both the install and uninstall of this product..

Parse error: syntax error, unexpected '{' in /xxx/xxx/xxx/forums/admincp/plugin.php(1575) : eval()'d code on line 11

Ahh, can't believe I missed that -- download the new zip file, re-import the product file with Allow Overwrite = yes - and you shouldn't get this errors.

[trotskid]

Re-upload the files, and re-import the product with "Allow Overwrite" set to yes, and that should take care of it. There are no major changes as far as the database table for MySmilies - everything should be fine. :)

Thanks, but when I configure the usergroups appears a MySQL error:


MySQL Error : Unknown column 'mysmiliesvb_permissions' in 'field list'
Error Number : 1054

Also when re-import the product appears two MySmiles on the Installed products list because the previous version (3.7.005) has another filename (ms_mysmiliesvb.xml).

v3.8.3

[Eric]

Thanks, but when I configure the usergrups appears a MySQL error:


MySQL Error : Unknown column 'mysmiliesvb_permissions' in 'field list'
Error Number : 1054

Also when re-import the product appears two MySmiles on the Installed products list because the previous version (3.7.005) has another filename (ms_mysmiliesvb.xml).

v3.8.3

Hmm. Try disabling (don't uninstall it!) the one with 'ms_mysmiliesvb' - then re-import mine with allow overwrite.

[trotskid]

Hmm. Try disabling (don't uninstall it!) the one with 'ms_mysmiliesvb' - then re-import mine with allow overwrite.

Ops, to late :D

[Eric]

Ops, to late :D

Did you uninstall Mosh's version? That's what I meant. Although I believe I've come up with a way to do an upgrade from Mosh's to mine, cleanly. Working on it now...

[Eric]

v3.8.003 - August 5th, 2009
-- Fixed: Ok, should finally be fixed on upgrade - no more parse errors.
-- Fixed: Those upgrading from Mosh's version should be fine now.

[trotskid]

Well, now I uninstalled Mosh's version to reinstall it again, but I'll wait to your upgrade.

Many thanks :up:

[trotskid]

When I install the product now appears this error:

MySQL Error : Table 'db274165488.vbmysmiliesvb' doesn't exist
Error Number : 1146

edit: this is not an upgrade from Mosh's version.

[Eric]

When I install the product now appears this error:

MySQL Error : Table 'db274165488.vbmysmiliesvb' doesn't exist
Error Number : 1146

edit: this is not an upgrade from Mosh's version, it?s directly from your version.

Ugh, I hate my IDE - it removed code it shouldn't have, one sec...

[Eric]

Ok, one more try :\ Should be all ironed out now.

[trotskid]

Now works perfect! ;)

I've realised a backup of the mysmiliesvb folder but doesn't appear the smilies in "My Smilies". What can I do?

[Eric]

Now works perfect! ;)

I've realised a backup of the mysmiliesvb folder but doesn't appear the smilies in "My Smilies". What can I do?
No backup of the database? That's why I originally said not to uninstall the ms_ version of the product, only to disable it, because when you choose "Uninstall", it deletes the mysmiliesvb table.

[trotskid]

Ok no problem. This addon is recent in my forum and few users have upload smilies.. :)

Greetings

PS: Great addon. Installed and nominated :)

[Oblivion Knight]

Thanks for the quick fix.. :)

The product seemed to install ok even with the error, but to be on the safe side I uninstalled and reported it. Now reinstalled, and seems to be flawless - great idea, even better integration.

One small thing, any chance of getting custom smilies listed on the popup? :D

[Eric]

Ok no problem. This addon is recent in my forum and few users have upload smilies.. :)

Greetings

PS: Great addon. Installed and nominated :)
Thanks :)

Thanks for the quick fix.. :)

The product seemed to install ok even with the error, but to be on the safe side I uninstalled and reported it. Now reinstalled, and seems to be flawless - great idea, even better integration.

One small thing, any chance of getting custom smilies listed on the popup? :D
Glad to see it's working for you.

As far as popup - you mean in the editor? or the "More Smilies" link ?

[Oblivion Knight]

As far as popup - you mean in the editor? or the "More Smilies" link ?"More Smilies" link. I disabled the plugin that added it to the smilies box display on the editors, since it looks disjointed if you're using a smilie set with the same size, to then go and add custom smilies that are bigger.

It looks fine on the dropdown though, and would like to emulate this on the popup.. :)

[Eric]

"More Smilies" link. I disabled the plugin that added it to the smilies box display on the editors, since it looks disjointed if you're using a smilie set with the same size, to then go and add custom smilies that are bigger.

It looks fine on the dropdown though, and would like to emulate this on the popup.. :)

Ah, I see - I'll add this to my todo list, would be a nice feature. :)

[Oblivion Knight]

Seems I was somewhat premature in saying that it was working flawlessly.

If there's any attachments in a thread, I'm getting this error for each one of them:
Parse error: syntax error, unexpected ',' in /xxx/xxx/xxx/forums/includes/class_postbit.php(432) : eval()'d code on line 3

Makes no difference whether or not I used the admincp "fix" option.

[Eric]

Zip updated.

Oblivion, or others who downloaded this before August 5th, 9:57 AM EST:

Edit the postbit_attachment plugin, replace it with:


if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $this->registry->options['mysmiliesvb_option_fix_attach_inline'])
{
if (strpos(strtolower($post['pagetext']), '[attach]', 0) !== false)
{
$show['attachments'] = false;
}
}

[Sayid]

Installed + Nominated

I was waiting for the update .

thanks man :D

[Oblivion Knight]

Zip updated.You sir, are a star! Top class support.

Looking forward to the popup integration, but take your time.. ;)

[Eric]

No problem :) Been a rough road, with all the problems that needed ironing out. But it should be fine now.

Thanks for the nomination.

Installed + Nominated

I was waiting for the update .

thanks man :D

[Eric]

You sir, are a star! Top class support.

Looking forward to the popup integration, but take your time.. ;)
hehe, thanks :)

I plan on updating this soon - but may give it a couple days. It's been a rough morning with all the fixes :P lol.

[goxy63]

Installed yesterday, didnt have time to check it out good...updated and works just fine

OMG AWESOME MOD

Nominated, rated

Thank you
:respect:

[mike2902]

I uploaded the files and went to my AdminCP to import the product and my admin CP formatting has been totally changed. What happened? The only file overwritten was the delete.gif How do I get my AdminCP back?






http://www.amirhashemi.com/images/y0rq2u3d3t5yhce04yxg.jpg (http://www.amirhashemi.com/)

[Eric]

This can't be from this hack - nothing AdminCP wise was touched, except for a couple vB Options. And if the v3.7 version worked for you without that happening, so should my v3.8 version.

I uploaded the files and went to my AdminCP to import the product and my admin CP formatting has been totally changed. What happened? The only file overwritten was the delete.gif How do I get my AdminCP back?

[mike2902]

This can't be from this hack - nothing AdminCP wise was touched, except for a couple vB Options. And if the v3.7 version worked for you without that happening, so should my v3.8 version.


Well I dont know. Admincp was fine. I uploaded the files and now its not fine.

[Eric]

Well I dont know. Admincp was fine. I uploaded the files and now its not fine.
what site? because I guarantee that didn't happen because of this hack.

[mike2902]

what site? because I guarantee that didn't happen because of this hack.

www.hangin-out.net


the site itself if fine...just the Admin CP is jacked up

[Eric]

www.hangin-out.net


the site itself if fine...just the Admin CP is jacked up
did you delete your cpstyles directory for some reason?

'The requested URL /cpstyles/ was not found on this server.'

[mike2902]

did you delete your cpstyles directory for some reason?

'The requested URL /cpstyles/ was not found on this server.'

not to my knowledge

[Eric]

not to my knowledge
well that's your problem, and it wasn't because of this hack ;)

[mike2902]

well that's your problem, and it wasn't because of this hack ;)

I would agree it wouldnt be the hack. Well then how could I get a copy of that folder and where does it go?

[Eric]

I would agree it wouldnt be the hack. Well then how could I get a copy of that folder and where does it go?
It comes with your vBulletin download - go to the vB members area, download the 3.8.3 archive - then upload the 'cpstyles' folder to your forum root

[goxy63]

Iam having small issue here

On my homepage Iam using this hack under vba module
https://vborg.vbsupport.ru/showthread.php?t=210126
Dion Dev Shoutbox v2.0 (uses AJAX)

When logged out within shoutbox it shows only :smiley:
Also other users dont see my smileys in mentioned shoutbox, only user who placed them is able to see them
Any suggestions

[Eric]

I do not support any third-party mods -however, when I get a chance - I'll check into it.

[choccyclaire]

It doesn't work for moving smileys? (gifs)?

EDIT: NVM dodgy smiley lol.

Thanks. :)

[Hostboard]

Tried to upload a .png file and got:
This PNG image has the incorrect file extension.

Also might want to make mention someplace on the users screen the format's accpeted as well as file sizes as defined in the ACP so users know what their limitations are.

[Eric]

Tried to upload a .png file and got:
This PNG image has the incorrect file extension.

That's determined by vB's upload system, not this hack.

Also might want to make mention someplace on the users screen the format's accpeted as well as file sizes as defined in the ACP so users know what their limitations are.
Uses vBulletin's allowed extensions, but will add this to my todo list.

[Reycer]

Looking into this error - as far as MGC Chatbox, honestly I'm not sure if it will or not.



yes, yes


It works fine. I have MGC Chatbox, and the smilies show up.

I installed this last night and it's working GREAT! Thank you for this. Definatly nominated as this is one less stress relief on my part....lol

Spoke to soon. I can see the smilies that I have uploaded but others cannot. They just see something like :smiley: while I'm seeing the actual smilie.

[goxy63]

quote Posted by Hostboard
Also might want to make mention someplace on the users screen the format's accpeted as well as file sizes as defined in the ACP so users know what their limitations are.
end of quote
Well for my users I mentioned that with help of "phrase menager" adding info about filesizes and how many smilies they can upload....just abowe "browse" button when user should upload one

But wouldnt hurt to see this automated :)

Regarding to my issue (sorryz to be pain in but)

I think its cause vba not this mod...but with my poor knowledge I just dont know how to make these smilies show up anywhere within vba modules :(

smilies there dont show up as they are following wrong link for some reason
http://www.#####.com/forums/admincp/mysmiliesvb/mysmilie_1.gif

my vba is not in same directory as forums

[Eric]

It works fine. I have MGC Chatbox, and the smilies show up.

I installed this last night and it's working GREAT! Thank you for this. Definatly nominated as this is one less stress relief on my part....lol

Spoke to soon. I can see the smilies that I have uploaded but others cannot. They just see something like :smiley: while I'm seeing the actual smilie.
Just to make sure it's not a bug with MySmilies - does this happen on the forum anywhere? Or just the shoutbox?

[trotskid]

Hi. I've seen that the smilies doesn't appear in the quote box. There is a fix for this?

Greets

[Oblivion Knight]

Hi. I've seen that the smilies doesn't appear in the quote box. There is a fix for this?

GreetsAh yes, that could be quite annoying..

The only "obvious" fix I can think of is to use [img] tags for custom smilies in quotes? Is that possible?

[Eric]

Hi. I've seen that the smilies doesn't appear in the quote box. There is a fix for this?

Greets

Ah yes, that could be quite annoying..

The only "obvious" fix I can think of is to use [img] tags for custom smilies in quotes? Is that possible?

Looking into it now.

EDIT: Just tested this on my forum - works fine? :\

[goxy63]

My quote box is also just fine

@SecondV
Do you use vba, if u do than....when and if you have time can you just have a quick look at my forums (mentioned problem above)?

Anyways thanks

[Megatr0n]

SecondV, great plugin.

I have managed to get this to show under my UserCP but doesn't show when accessing the private.php page.

If you do not mind can you gimme specific instructions how I can get the link to show in UserCP even when someone has accessed their PM inbox? Thanks, much appreciated! :)

[trotskid]

Hi. I've seen that the smilies doesn't appear in the quote box. There is a fix for this?

Greets

False alarm. Now it seems to work :)

[Eric]

My quote box is also just fine

@SecondV
Do you use vba, if u do than....when and if you have time can you just have a quick look at my forums (mentioned problem above)?

Anyways thanks
I do not use vBa - but let me see what I can do.

SecondV, great plugin.

I have managed to get this to show under my UserCP but doesn't show when accessing the private.php page.

If you do not mind can you gimme specific instructions how I can get the link to show in UserCP even when someone has accessed their PM inbox? Thanks, much appreciated! :)
I'm not entirely sure what you're asking.

False alarm. Now it seems to work :)
Good. :)

[Megatr0n]

I do not use vBa - but let me see what I can do.


I'm not entirely sure what you're asking.


Good. :)

When someone accessing their PMs they can view the links inside the UserCP.

On my forum all the links are there except for the My Smilies one for your plugin. So, how do I get it to show on the private.php page.

I hope that makes better sense.

[Eric]

When someone accessing their PMs they can view the links inside the UserCP.

On my forum all the links are there except for the My Smilies one for your plugin. So, how do I get it to show on the private.php page.

I hope that makes better sense.

The link to My Smilies will not show up unless the usergroup has the permissions to use My Smilies. AdminCP -> Usergroups -> Usergroup Manager -> Edit Usergroup:
https://vborg.vbsupport.ru/external/2009/08/26.png

[Megatr0n]

The link to My Smilies will not show up unless the usergroup has the permissions to use My Smilies. AdminCP -> Usergroups -> Usergroup Manager -> Edit Usergroup:
http://www.domainportfolio.us/support/mysmiliesvb_ss/mysmiliesvb_usergroupperms.png

I've done that and it does show for all my users when they access their UserCP.

However, no one can see it when they're accessing their private message inbox, which would be this URL:

http://www.yourforum.com/forum/private.php

Try it on your board and see if you can still see the link on the left.

[Oblivion Knight]

False alarm. Now it seems to work :)Not a false alarm for me, custom smilies other than a user's own, aren't working when quoted - just the replacement text is being displayed.

[trotskid]

Yes, you right Oblivion Knight.

Not a false alarm for me, custom smilies other than a user's own, aren't working when quoted - just the replacement text is being displayed.

[nascartr]

Not a false alarm for me, custom smilies other than a user's own, aren't working when quoted - just the replacement text is being displayed.


Same here. I am using a custom quote box though?

[Oblivion Knight]

Same here. I am using a custom quote box though?Makes no difference, mine is default.. :)

[nascartr]

Makes no difference, mine is default.. :)

Ok, just making sure! :D

[Sador]

About the showing in quotes stuff... it shows the smiley when you quote your own post with your own custom smiley, but it doesn't show when someone else quotes it, because they don't have the smiley so the text doesn't get parsed.

It would be nice if that could be fixed. Also, right now custom smileys are shown in the html box with all the other smileys. This looks kinda bad, so I disabled that, but it doesn't show in 'more smileys' either. Is there some way that could be fixed as well?

Otherwise, great mod, thanks a lot. :)

[Eric]

About the showing in quotes stuff... it shows the smiley when you quote your own post with your own custom smiley, but it doesn't show when someone else quotes it, because they don't have the smiley so the text doesn't get parsed.

It would be nice if that could be fixed. Also, right now custom smileys are shown in the html box with all the other smileys. This looks kinda bad, so I disabled that, but it doesn't show in 'more smileys' either. Is there some way that could be fixed as well?

Otherwise, great mod, thanks a lot. :)
As stated earlier in this thread about "More Smilies", that will be in the next release.

Ok, just making sure! :D

Makes no difference, mine is default.. :)

Same here. I am using a custom quote box though?

Yes, you right Oblivion Knight.
As for the Quote issue - I'm looking into it, I'm not sure if it's going to be that easy of a fix.

[Eric]

I've done that and it does show for all my users when they access their UserCP.

However, no one can see it when they're accessing their private message inbox, which would be this URL:

http://www.yourforum.com/forum/private.php

Try it on your board and see if you can still see the link on the left.
Not sure what to tell you, as it works on my board just fine. But give me some time, I'll try to see if I can find any possible causes.

[Megatr0n]

Not sure what to tell you, as it works on my board just fine. But give me some time, I'll try to see if I can find any possible causes.

Hi Eric,

Sounds good. I look forward to a hopeful solution! :)

[Sweeks]

Works perfectly, thanks!

[Oblivion Knight]

Regarding the quote box bug..

It can be fixed by removing this from the query on the bbcode_parse_complete plugin:
WHERE userid='{$GLOBALS['mysmiliesvb_userid']}'..But it's not at all recommended if you have a large board with many users who make use of custom smilies. I've done it because I have a small board, with not so many users and have limited the smilies per user to 20.

Perhaps somehow grabbing the quoted user's userid and adding it to the query is a possibility?

I was looking at some code from an old "Who Quoted Me? (https://vborg.vbsupport.ru/showthread.php?t=103768)" plugin. While it would need reworking for use here, I think it could be a possibility..

[Eric]

Try this for me?

Change the query in that plugin to:


if (isset($GLOBALS['postinfo']['userid']) AND $GLOBALS['postinfo']['userid'] > 0)
{
$smilies_where = "userid IN('{$GLOBALS['postinfo']['userid']}', '{$GLOBALS['mysmiliesvb_userid']}')";
}
else
{
$smilies_where = "userid = '{$GLOBALS['mysmiliesvb_userid']}'";
}

$smilies = $this->registry->db->query_read_slave("
SELECT *
FROM " . TABLE_PREFIX . "mysmiliesvb
WHERE $smilies_where
");


And see if that works for you.
Regarding the quote box bug..

It can be fixed by removing this from the query on the bbcode_parse_complete plugin:
WHERE userid='{$GLOBALS['mysmiliesvb_userid']}'..But it's not at all recommended if you have a large board with many users who make use of custom smilies. I've done it because I have a small board, with not so many users and have limited the smilies per user to 20.

Perhaps somehow grabbing the quoted user's userid and adding it to the query is a possibility?

I was looking at some code from an old "Who Quoted Me? (https://vborg.vbsupport.ru/showthread.php?t=103768)" plugin. While it would need reworking for use here, I think it could be a possibility..

[Oblivion Knight]

Unfortunately, it didn't work.. :(

I've a horrible feeling that an additional query may be needed, unless it can be done with joins?


Of course, another fault with my current "solution" is that all users can use anyone's custom smilies, using the replacement.

[Eric]

What's weird is when debugging, it works just fine - when posting as another (test) user, without the debugging code in place, it doesn't parse the smilie. :|

[Eric]

MySmilies vB will not support parsing smilies in a quoted users post, unfortunately. I've tried several things without success, maybe I'm over thinking it.

Aside from that, thinking about it - any work around for it would potentially cause several queries per post, and that's not good.

[Oblivion Knight]

MySmilies vB will not support parsing smilies in a quoted users post, unfortunately. I've tried several things without success, maybe I'm over thinking it.

Aside from that, thinking about it - any work around for it would potentially cause several queries per post, and that's not good.I noticed that when I changed the query (forgot to post), so quickly reverted it.. ;)


--EDIT--
I've had to uninstall this, it's causing a couple of nasty conflicts - executing additional queries. On v3arcade; for a game's high scores, it was running an extra query for every score on a page.

[Eric]

I noticed that when I changed the query (forgot to post), so quickly reverted it.. ;)


--EDIT--
I've had to uninstall this, it's causing a couple of nasty conflicts - executing additional queries. On v3arcade; for a game's high scores, it was running an extra query for every score on a page.

Hmm, I'll look into disabling it, when it comes across v3arcade - so that way you can reinstall ;)

[Saviour]

Sorry...great mod, but had to uninstall due to mysmilies not parsing in quotes. I'll keep my eye on it, though.

Look forward to an update with a fix. If no fix, well...at least you tried.

[Eric]

So 3 uninstalls apparently because of the quote issue - Oh well :\ As I said, there may be a way to do it, but you could easily create 2 queries or more PER post in a thread.

[Megatr0n]

Eric, if you do find a way around it why not make it an optional choice? And, let people by enabling that feature they'll be weighting more strain on the server.

[Eric]

New version should be released within a week or so. It'll have the ability to place a users custom smilies in the "More Smilies" popup.

Eric, if you do find a way around it why not make it an optional choice? And, let people by enabling that feature they'll be weighting more strain on the server.
We'll see.

[Megatr0n]

Hi Eic,

I hope you've also addressed that minor bug (if you can call it a bug) with the link not showing in UserCP when a user is on private.php page.

[goxy63]

Tagged and unistalled
Hope that we will see working version for vb4 with quote option

Thanks for this awesome hack but... :(

[Eric]

Sorry folks, it may be a while before any updates are released, due to some things going on in my life atm...

[Sador]

Take your time. :) And good luck with those things.

[unicorn2433]

This is a great mod... question though. Since I have installed this mod I get this after some of the smilies... even smilies from default vbulletin page:

:( " class="inlineimg" />

it appears immediately after the smile just like the above example.

I have the fix inline attachments thing set to yes as well. But that does not fix this issue.

[sexy_kuta]

having some trouble. if someone can help me with this i know this is a newb question..

when I downloaded the installation the mysmiliesvb is not correct it keeps showing up as an html file

this can't be right? because when i upload it to my forum directory it just shows as an html file

heres a picture of the file

... this is step two of the process

"mysmiliesvb directory => To your FORUM ROOT directory"

[elroger]

When I log in from the homepage of vbadvanced gives me a 404 because it will http://www.gigaforo.com/mysmiliesvb.php?
but the actual path is http://www.gigaforo.com/forum/mysmiliesvb.php?

How can I correct it?

[Alibass]

Using 3.8.4 here, sweet mod. Installed, thanks. :D

[kalisekj]

Awesome Mod! Works Fine In MGC Chatbox & VB 3.8.2 . I do notice that some or many animated gifs lose their animation for some reason? Any ideas? If I upload the smiley through Admincp add smiley it stays animated.

[Alibass]

You have exceeded the w=x h=x and size of file. Increase your settings and animation will work.

[kalisekj]

Thank You very Much That has resolved the Issue! WooHoo!

[Prettyeyes4you]

Have seen the earlier versions of this on other forums but it wouldn't work on ours. Thanks for updating this for 3.8.4. Have installed it on our test to check issues with our programs but everything looks cool so far.

Appreciate your work:up:

[elroger]

I have a conflict with vS-Hide Hack Resurrection:
At the time when the pulse "THANK" in the post (ajax function on in vS-Hide Hack Resurrection)

http://www.gigaforo.com//forum/images/roger/my%20smilies.jpg

then smilies from MySmilies are converted to text:

http://www.gigaforo.com//forum/images/roger/error.jpg


What can I do?

Refresh or press F5 is not a solution.

Thank you very much for your help, greetings from Spain.

[elroger]

Another thing that happens to me is that I would remove my smilies from the publisher but not the button, see:

http://www.gigaforo.com//forum/images/roger/smilies.jpg

How can I do?

Again, thank you very much friends

[angelpie]

sweet im gonna mark this one for when i have time to upload but sounds cool!

[WildSoftCat]

Works fine :)

The simple way to fix "qoute problem" is creating random string (i've 12 chars, it's enough) for replacement text, so users don't enter own replacements + remove userid selection during parsing.

[elroger]

Where can I create a random string?, Sorry but I do not know how.

Thanks for your response

[Eric]

Works fine :)

The simple way to fix "qoute problem" is creating random string (i've 12 chars, it's enough) for replacement text, so users don't enter own replacements + remove userid selection during parsing.
you have this working with quotes? ie: someone not using their own smilies quoting someone's post that is using a custom smiley?

[WildSoftCat]

you have this working with quotes? ie: someone not using their own smilies quoting someone's post that is using a custom smiley?
Yes, of course :)

Look in attach, changed lines in php marked with text "wildcat"
Replacement text removed from templates, userid selection removed from parse plugin

Yet one point. I change userid field to zero during deleting instead of deleting record, so if user delete his smilie it's stiill apears in posts.

[WildSoftCat]

Where can I create a random string?, Sorry but I do not know how.

Thanks for your response
Please look in attached files from previos post

[elroger]

Thank you very much!, Works perfectly.

I just want to resolve this:

https://vborg.vbsupport.ru/showpost.php?p=1918533&postcount=99

Thanks for everything.

[mrpaint]

Yes, of course :)

Look in attach, changed lines in php marked with text "wildcat"
Replacement text removed from templates, userid selection removed from parse plugin

Yet one point. I change userid field to zero during deleting instead of deleting record, so if user delete his smilie it's stiill apears in posts.
This workaround is useful but parsing smilies without knowing posting userid is not a good way to do it since other members can "Quote" the post, grab the random string and use it in their own posts. Hmm, is it safe? :D

[WildSoftCat]

This workaround is useful but parsing smilies without knowing posting userid is not a good way to do it since other members can "Quote" the post, grab the random string and use it in their own posts. Hmm, is it safe? :D
I think this kind of smilies isn't protected by copyright lows:cool:, so it's safe to use. You can also add infraction type "Usage of stolen smilie":D

[BBF]

does it work with vb4?

[shoppingtelly]

Have just upgraded but now am unable to see bit in usergroups to let them use it, any ideas what I have dione wrong?

Thanks

[choccyclaire]

does it work with vb4?

No.

[Eric]

I think this kind of smilies isn't protected by copyright lows:cool:, so it's safe to use. You can also add infraction type "Usage of stolen smilie":D
I don't think that's what they meant. Doing a query for ALL custom smilies can have performance issues, which can grow exponentially. # smilies x # posts x # smilies in post

does it work with vb4?
No, and I'm not sure yet if I'll try to upgrade it.

Have just upgraded but now am unable to see bit in usergroups to let them use it, any ideas what I have dione wrong?

Thanks
Try rebuilding your bitfields, yourforum.com/admincp/index.php?do=buildbitfields

[shoppingtelly]

still not after rebuilding bitfields, expect its me.

[BostWick-x]

I just briefly looked through this thread, so sorry if I missed a possible solution.

I'm using Cyb - ChatBox and the smilies only show for the user who posted the message. So for example if one of my smilies was :cake: and I posted that in the chatbox, I would be able to see the smiley that I had set for that shortcut, but everybody else would just see :cake:

Is there any fix for this that I may have missed?

[Tettinntil]

still not after rebuilding bitfields, expect its me.
I got the same problem - I installed the 'sv_mysmiliesvb', did not get any edit possibility in usergroups. Rebuilt bitfields as suggested above - still does not work...

[Eric]

I hate to ask this, but out of curiousity - those having problems with the 'bitfields' - did you upload the /includes/xml/bitfield_mysmiliesvb.xml file?

EDIT:

Btw, I am working on a new version. I have an idea for the quoted smilies situation. I'm thinking of creating a hook that will add all smilies to the datastore, and then instead of parsing a post for smilies based on userid, just parse it for all - If I'm thinking correctly, the datastore should eliminate the potential performance issues I was worried about.

[Tettinntil]

I hate to ask this, but out of curiousity - those having problems with the 'bitfields' - did you upload the /includes/xml/bitfield_mysmiliesvb.xml file?This is the file /upload/includes/xml/bitfield_mysmiliesvb.xml? When I try uploadig (using Manage Products -> Import , I get the error message 'Invalid File Specified'...

[Eric]

This is the file /upload/includes/xml/bitfield_mysmiliesvb.xml? When I try uploadig (using Manage Products -> Import , I get the error message 'Invalid File Specified'...

You don't upload it via the Product Manager - you do so through your FTP program, along with the other files in the 'upload' folder

[Tettinntil]

You don't upload it via the Product Manager - you do so through your FTP program, along with the other files in the 'upload' folder
:cool:

Sorry, this is all brand new to me... Thanks a lot - I am waiting for ftp now and will try again. (Maybe stupid question, but was this the first step the installation instructions?https://vborg.vbsupport.ru/external/2010/01/19.gif)

[Eric]

Updated to 3.8.004:

v3.8.004 - January 15th, 2010
-- Changed: query() calls were being used instead of query_read()
-- Changed: Smilies are now built and added to datastore cache
-- Changed: Since smilies are stored in the datastore, smilies are no longer queried/parsed by userid.
-- Fixed: Custom smilies not parsed when quoted by other users.
-- Added: /includes/functions_mysmiliesvb.php - build_mysmilies_datastore() function.

[mrpaint]

Updated to 3.8.004:

v3.8.004 - January 15th, 2010
...
-- Fixed: Custom smilies not parsed when quoted by other users.
...

You mean smilies are now being parsed in quotes?

[Eric]

You mean smilies are now being parsed in quotes?

Yes.

[mrpaint]

Yes.
Very cool. Thank you

[Jman423]

Thank you for updating this. I will be updating my installation shortly.

[choccyclaire]

Thanks for the update. :D

[choccyclaire]

I receive this db error when trying to upgrade. (I have uploaded and overwritten all other files)

Database error in vBulletin 3.8.4:

Invalid SQL:
ALTER TABLE mysmiliesvb ADD KEY userid (userid);

MySQL Error : Duplicate key name 'userid'
Error Number : 1061
Request Date : Friday, January 15th 2010 @ 07:26:08 PM
Error Date : Friday, January 15th 2010 @ 07:26:08 PM
Script : http://www.xxx/admincp/plugin.php?do=productimport
Referrer : http://www.xxx/admincp/plugin.php?do=productadd
IP Address : xxx
Username : xxx
Classname : vB_Database
MySQL Version : 5.0.87-community-log

[Megatr0n]

Great upgrade but why do the user's personal smilies now appear under the custom row of smilies?

Any way of avoiding this?

[Eric]

Great upgrade but why do the user's personal smilies now appear under the custom row of smilies?

Any way of avoiding this?
Screenshot?

As the changelog states, when parsing/pulling smilies, it no longer checks by userid. So it now parses smilies that have been quoted/etc. One downside to this (if you see it that way), is that if another user knows the smiley code, they can use the smiley (which IMHO, should be the way this mod works - why not let a user add a smilie that they can use, but others can as well if they like it? ;) )

I receive this db error when trying to upgrade. (I have uploaded and overwritten all other files)

Database error in vBulletin 3.8.4:

Invalid SQL:
ALTER TABLE mysmiliesvb ADD KEY userid (userid);

MySQL Error : Duplicate key name 'userid'
Error Number : 1061
Request Date : Friday, January 15th 2010 @ 07:26:08 PM
Error Date : Friday, January 15th 2010 @ 07:26:08 PM
Script : http://www.xxx/admincp/plugin.php?do=productimport
Referrer : http://www.xxx/admincp/plugin.php?do=productadd
IP Address : xxx
Username : xxx
Classname : vB_Database
MySQL Version : 5.0.87-community-log

What version of the mod were you using before the upgrade? The only reason that code should run during install is if you're using a version prior to 3.8.001, in which case, there should not be a KEY on userid for the mysmiliesvb table.

[Megatr0n]

See attachment.

It sort of stretches our editor and I don't like it doing that.

Anyway arounnd this?

[choccyclaire]

What version of the mod were you using before the upgrade? The only reason that code should run during install is if you're using a version prior to 3.8.001, in which case, there should not be a KEY on userid for the mysmiliesvb table.

Yes, I have that version. Is there a solution for me? :confused:

[nascartr]

Yeah, I now see everyone's smilies as well. That's not too bad I guess...

[Eric]

See attachment.

It sort of stretches our editor and I don't like it doing that.

Anyway arounnd this?

Yeah, I now see everyone's smilies as well. That's not too bad I guess...
In the next version, I will add an admin option to where you can choose if all user smilies are added to the editor, or just the current userid's smilies.

If you'd like to try that, could you test this for me?

In the editor_toolbar_start hook, titled "Setup The Smilies For The HTML Box", try replacing:


foreach ($vbulletin->sv_mysmiliesvb AS $smilie)
{
//while ($i++ < $vbulletin->options['smtotal'])
//{
$mysmilieurl = $vbulletin->options['mysmiliesvb_option_smiliesurl'] . "/mysmilie_{$smilie['mysmiliesvbid']}.gif";
$smiliehtml = "<img src=\"$mysmilieurl\" id=\"{$editorid}_smilie_9999{$smilie['mysmiliesvbid']}\" alt=\"{$smilie['smilietext']}\" title=\"{$smilie['smilietext']}\" border=\"0\" />";

eval('$bits[] = "' . fetch_template('editor_smilie') . '";');

if (sizeof($bits) == $vbulletin->options['smcolumns'])
{
$smiliecells = implode('', $bits);
eval('$smiliebits .= "' . fetch_template('editor_smiliebox_row') . '";');
$bits = array();
}
//}
}


With:


foreach ($vbulletin->sv_mysmiliesvb AS $smilie)
{
if ($smilie['userid'] != $vbulletin->userinfo['userid'])
{
continue;
}

//while ($i++ < $vbulletin->options['smtotal'])
//{
$mysmilieurl = $vbulletin->options['mysmiliesvb_option_smiliesurl'] . "/mysmilie_{$smilie['mysmiliesvbid']}.gif";
$smiliehtml = "<img src=\"$mysmilieurl\" id=\"{$editorid}_smilie_9999{$smilie['mysmiliesvbid']}\" alt=\"{$smilie['smilietext']}\" title=\"{$smilie['smilietext']}\" border=\"0\" />";

eval('$bits[] = "' . fetch_template('editor_smilie') . '";');

if (sizeof($bits) == $vbulletin->options['smcolumns'])
{
$smiliecells = implode('', $bits);
eval('$smiliebits .= "' . fetch_template('editor_smiliebox_row') . '";');
$bits = array();
}
//}
}

[Eric]

Yes, I have that version. Is there a solution for me? :confused:

So you are using version 3.8.001 atm, or an older one? Ok, try this product xml file that I have attached and see if that works for you.

[choccyclaire]

^ Thanks, that product worked perfectly. :)

Your previous post with regards to getting rid of the custom smilies in the editor. It does get rid of them but causes an error line at the top:

Parse error: syntax error, unexpected $end in /home/xxx/public_html/includes/functions_editor.php(521) : eval()'d code on line 79

[Eric]

^ Thanks, that product worked perfectly. :)

Your previous post with regards to getting rid of the custom smilies in the editor. It does get rid of them but causes an error line at the top:

Parse error: syntax error, unexpected $end in /home/xxx/public_html/includes/functions_editor.php(521) : eval()'d code on line 79

Could you post what your full plugin code looks like? There shouldn't be any errors..

[choccyclaire]

Sorry, somehow I had an extra } in the code. Works now!

For the next version, do you think you could make it so that the users custom smilies are placed in a new fieldset labelled my custom smilies? Not sure if this is achievable but would be great to keep them semi separate.

[Megatr0n]

In the next version, I will add an admin option to where you can choose if all user smilies are added to the editor, or just the current userid's smilies.

If you'd like to try that, could you test this for me?

In the editor_toolbar_start hook, titled "Setup The Smilies For The HTML Box", try replacing:


foreach ($vbulletin->sv_mysmiliesvb AS $smilie)
{
//while ($i++ < $vbulletin->options['smtotal'])
//{
$mysmilieurl = $vbulletin->options['mysmiliesvb_option_smiliesurl'] . "/mysmilie_{$smilie['mysmiliesvbid']}.gif";
$smiliehtml = "<img src=\"$mysmilieurl\" id=\"{$editorid}_smilie_9999{$smilie['mysmiliesvbid']}\" alt=\"{$smilie['smilietext']}\" title=\"{$smilie['smilietext']}\" border=\"0\" />";

eval('$bits[] = "' . fetch_template('editor_smilie') . '";');

if (sizeof($bits) == $vbulletin->options['smcolumns'])
{
$smiliecells = implode('', $bits);
eval('$smiliebits .= "' . fetch_template('editor_smiliebox_row') . '";');
$bits = array();
}
//}
}


With:


foreach ($vbulletin->sv_mysmiliesvb AS $smilie)
{
if ($smilie['userid'] != $vbulletin->userinfo['userid'])
{
continue;
}

//while ($i++ < $vbulletin->options['smtotal'])
//{
$mysmilieurl = $vbulletin->options['mysmiliesvb_option_smiliesurl'] . "/mysmilie_{$smilie['mysmiliesvbid']}.gif";
$smiliehtml = "<img src=\"$mysmilieurl\" id=\"{$editorid}_smilie_9999{$smilie['mysmiliesvbid']}\" alt=\"{$smilie['smilietext']}\" title=\"{$smilie['smilietext']}\" border=\"0\" />";

eval('$bits[] = "' . fetch_template('editor_smilie') . '";');

if (sizeof($bits) == $vbulletin->options['smcolumns'])
{
$smiliecells = implode('', $bits);
eval('$smiliebits .= "' . fetch_template('editor_smiliebox_row') . '";');
$bits = array();
}
//}
}



It works. :)

[nascartr]

In the next version, I will add an admin option to where you can choose if all user smilies are added to the editor, or just the current userid's smilies.

If you'd like to try that, could you test this for me?

In the editor_toolbar_start hook, titled "Setup The Smilies For The HTML Box", try replacing:


foreach ($vbulletin->sv_mysmiliesvb AS $smilie)
{
//while ($i++ < $vbulletin->options['smtotal'])
//{
$mysmilieurl = $vbulletin->options['mysmiliesvb_option_smiliesurl'] . "/mysmilie_{$smilie['mysmiliesvbid']}.gif";
$smiliehtml = "<img src=\"$mysmilieurl\" id=\"{$editorid}_smilie_9999{$smilie['mysmiliesvbid']}\" alt=\"{$smilie['smilietext']}\" title=\"{$smilie['smilietext']}\" border=\"0\" />";

eval('$bits[] = "' . fetch_template('editor_smilie') . '";');

if (sizeof($bits) == $vbulletin->options['smcolumns'])
{
$smiliecells = implode('', $bits);
eval('$smiliebits .= "' . fetch_template('editor_smiliebox_row') . '";');
$bits = array();
}
//}
}
With:


foreach ($vbulletin->sv_mysmiliesvb AS $smilie)
{
if ($smilie['userid'] != $vbulletin->userinfo['userid'])
{
continue;
}

//while ($i++ < $vbulletin->options['smtotal'])
//{
$mysmilieurl = $vbulletin->options['mysmiliesvb_option_smiliesurl'] . "/mysmilie_{$smilie['mysmiliesvbid']}.gif";
$smiliehtml = "<img src=\"$mysmilieurl\" id=\"{$editorid}_smilie_9999{$smilie['mysmiliesvbid']}\" alt=\"{$smilie['smilietext']}\" title=\"{$smilie['smilietext']}\" border=\"0\" />";

eval('$bits[] = "' . fetch_template('editor_smilie') . '";');

if (sizeof($bits) == $vbulletin->options['smcolumns'])
{
$smiliecells = implode('', $bits);
eval('$smiliebits .= "' . fetch_template('editor_smiliebox_row') . '";');
$bits = array();
}
//}
}



My members actually like the availability of using each others smilies so an option would be great just in case we ever want to hide them again.

Guess this way it's like a group effort in adding smilies to the selection.

[choccyclaire]

The update unfortunately conflicts with the Yet Another Awards System. :(

When you go to the YAAS pages in the admincp or modcp, you have errors at the top of the pages:

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

[Eric]

The update unfortunately conflicts with the Yet Another Awards System. :(

When you go to the YAAS pages in the admincp or modcp, you have errors at the top of the pages:

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

hmm, in the 'bbcode_parse_complete' hook titled "Substitute The Replacement Text For The Image" try replacing:


if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'])


with:

if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'] AND !empty($this->registry->sv_mysmiliesvb))

[Lord.Khalid]

Thanks for the update, it works just fine but I didn't like the idea of showing hundred of smiles in the editor so I tried the admin controls option and it solved the issue : )

Anyway I notice that there is some kind of confusion especially with smiles which have similar replacement texts as it shows other smiles other than the user’s.

Thanks again, and keep the good work.
Khalid

[choccyclaire]

hmm, in the 'bbcode_parse_complete' hook titled "Substitute The Replacement Text For The Image" try replacing:


if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'])


with:

if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'] AND !empty($this->registry->sv_mysmiliesvb))


Didn't fix it yet. I know it is that particular plugin though coz when disabled, the errors disappear.

[drsli]

I don?t have the YAAS-addon, but I got a similar error like above. I changed the plugin accordingly and the error is gone! :)

Thank you very much for this awesome addon and the further development! :)

[choccyclaire]

I'm using the previous version of that particular plugin for now and all seems to be working okay apart from quoting.

(I am not much of a coder) Why did you need to change this plugin? What differs to make the mod more effective.

Old code:

if (!isset($GLOBALS['mysmiliesvb_userid']) OR empty($GLOBALS['mysmiliesvb_userid']))
{
// Just in case... just depending on $GLOBALS['mysmiliesvb_userid'] without this
// check didn't work for me on previews when editing signature.
$GLOBALS['mysmiliesvb_userid'] = $this->registry->userinfo['userid'];
}

if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'])
{
$smiliesurlbase = $this->registry->options['mysmiliesvb_option_smiliesurl'];
$smilies = $this->registry->db->query("
SELECT *
FROM " . TABLE_PREFIX . "mysmiliesvb
WHERE userid='{$GLOBALS['mysmiliesvb_userid']}'
");

while ($smilie = $this->registry->db->fetch_array($smilies))
{
if (empty($smilie['smilietext_parsed']))
{
continue;
}

eval('$smilie[\'image\'] = "' . fetch_template('mysmilies_imagebit') . '";');

$text = preg_replace("@" . $smilie['smilietext_parsed'] . "@isU", $smilie['image'], $text);
$this->cached['text'] = $text;
}
}

New code:

if (!isset($GLOBALS['mysmiliesvb_userid']) OR empty($GLOBALS['mysmiliesvb_userid']))
{
// Just in case... just depending on $GLOBALS['mysmiliesvb_userid'] without this
// check didn't work for me on previews when editing signature.
$GLOBALS['mysmiliesvb_userid'] = $this->registry->userinfo['userid'];
}

if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'] AND !empty($this->registry->sv_mysmiliesvb))
{
$smiliesurlbase = $this->registry->options['mysmiliesvb_option_smiliesurl'];

foreach ($this->registry->sv_mysmiliesvb AS $smilie)
{
eval('$smilie[\'image\'] = "' . fetch_template('mysmilies_imagebit') . '";');

$text = preg_replace("@" . $smilie['smilietext_parsed'] . "@isU", $smilie['image'], $text);
$this->cached['text'] = $text;
}
}

I see mention of the database in the old version. Does that mean I will create more queries by altering this?

[Eric]

The change was because of the quoting - the new plugin allows the smilies to work in quotes when quoted by another user.

I'm using the previous version of that particular plugin for now and all seems to be working okay apart from quoting.

(I am not much of a coder) Why did you need to change this plugin? What differs to make the mod more effective.

Old code:

if (!isset($GLOBALS['mysmiliesvb_userid']) OR empty($GLOBALS['mysmiliesvb_userid']))
{
// Just in case... just depending on $GLOBALS['mysmiliesvb_userid'] without this
// check didn't work for me on previews when editing signature.
$GLOBALS['mysmiliesvb_userid'] = $this->registry->userinfo['userid'];
}

if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'])
{
$smiliesurlbase = $this->registry->options['mysmiliesvb_option_smiliesurl'];
$smilies = $this->registry->db->query("
SELECT *
FROM " . TABLE_PREFIX . "mysmiliesvb
WHERE userid='{$GLOBALS['mysmiliesvb_userid']}'
");

while ($smilie = $this->registry->db->fetch_array($smilies))
{
if (empty($smilie['smilietext_parsed']))
{
continue;
}

eval('$smilie[\'image\'] = "' . fetch_template('mysmilies_imagebit') . '";');

$text = preg_replace("@" . $smilie['smilietext_parsed'] . "@isU", $smilie['image'], $text);
$this->cached['text'] = $text;
}
}

New code:

if (!isset($GLOBALS['mysmiliesvb_userid']) OR empty($GLOBALS['mysmiliesvb_userid']))
{
// Just in case... just depending on $GLOBALS['mysmiliesvb_userid'] without this
// check didn't work for me on previews when editing signature.
$GLOBALS['mysmiliesvb_userid'] = $this->registry->userinfo['userid'];
}

if ($this->registry->options['mysmiliesvb_option_masterswitch'] AND $GLOBALS['mysmiliesvb_userid'] AND !empty($this->registry->sv_mysmiliesvb))
{
$smiliesurlbase = $this->registry->options['mysmiliesvb_option_smiliesurl'];

foreach ($this->registry->sv_mysmiliesvb AS $smilie)
{
eval('$smilie[\'image\'] = "' . fetch_template('mysmilies_imagebit') . '";');

$text = preg_replace("@" . $smilie['smilietext_parsed'] . "@isU", $smilie['image'], $text);
$this->cached['text'] = $text;
}
}

I see mention of the database in the old version. Does that mean I will create more queries by altering this?

[Hostboard]

Can you make an ACP option to make the user smilies publicly available to use for private use only. I have many forums that are adult oriented and blocked from those underage and the smilies now are now globaly available and not really something that should be viewable for some.

Thanx

[FitgirlWorld]

thanks for a great mod.. installing it now. If eveything works right will click mark as installed ! whoo hoo!

[Eric]

Working on a vBulletin 4 version ...

[Megatr0n]

SecondV - can you please check your PM and get back to me, please! :)

[choccyclaire]

That invalid argument error I posted a few posts ago appears on other pages too, like:

http://www.xxx.com/register.php?do=requestemail

This is after I applied the fix you suggested.

[Fungsten]

It works. :)

Works for me too!

[Steelersfan]

Working on a vBulletin 4 version ...


Any timetable on when this will be out?

[Eric]

I'm not naive, this doesn't come as a surprise... but, someone here on vBulletin.org has taken this mod and released it at ******.****, not cool.

I won't be working on this mod anymore, for a while.

[Fungsten]

I'm not naive, this doesn't come as a surprise... but, someone here on vBulletin.org has taken this mod and released it at vbteam.info, not cool.

I won't be working on this mod anymore, for a while.

Sorry it happened! Do something about it! But we love this mod! You have to update it to 4.0. Please?

[Oyabun]

Sorry it happened! Do something about it! But we love this mod! You have to update it to 4.0. Please?

Yeah, please update it :(

[Brew]

I'm not naive, this doesn't come as a surprise... but, someone here on vBulletin.org has taken this mod and released it at *****.***, not cool.

I won't be working on this mod anymore, for a while.

Please don't let one moron spoil it all for everyone else!

I, for one and probably just about everyone here, appreciate the work you do on your mods.

Please....keep em coming and updated! I'm dying to get this for vB 4.0.+

PS...also please censor out that URL. I've never heard of it till now and it's acting like an advert for those people.

Cheers!

[Fungsten]

Please don't let one moron spoil it all for everyone else!

I, for one and probably just about everyone here, appreciate the work you do on your mods.

Please....keep em coming and updated! I'm dying to get this for vB 4.0.+

PS...also please censor out that URL. I've never heard of it till now and it's acting like an advert for those people.

Cheers!

Ditto again!

[Oyabun]

Or could anybody else update it?
I'd do it, but I don't have the knowledge for this._.

[Eric]

It may be a while before a vBulletin4 compatible version will be available. Apparently I'll have to do more than just update templates on this one - some hooks have moved, and it may even require file edits - I don't know yet.

[Oyabun]

It may be a while before a vBulletin4 compatible version will be available. Apparently I'll have to do more than just update templates on this one - some hooks have moved, and it may even require file edits - I don't know yet.

Well I'm sorry, I didn't know that. But it would be just awesome. I'd give you a donation for it.
My users love this mod. It's great. Please keep up the work =)!

[Fungsten]

Well I'm sorry, I didn't know that. But it would be just awesome. I'd give you a donation for it.
My users love this mod. It's great. Please keep up the work =)!

I'll give him a donation too!

[Saviour]

Followed directions included in your zip file to the letter...and get the following warning error:
Warning: Invalid argument supplied for foreach() in [path]/mysmiliesvb.php on line 306

I'm running vbulletin 3.8.5 along with vba 3.2.2. I used your latest release for this mod and when I clicked the link for MySmilies in the User Control Panel, I got the warning message.

Is there something I missed?

This is the line of code on line 306 of the mysmiliesvb.php file:
foreach ($vbulletin->sv_mysmiliesvb AS $smilie)

[Saviour]

Uninstalled...sorry.

[matthewhotdude]

Since installing getting these errors


Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: session_start() [function.session-start]: Cannot send session cache limiter - headers already sent (output started at [path]/includes/class_core.php:3277) in [path]/musicajax.php on line 15

[ehd]

Is there a way to administrate all the smileys uploaded? How can I delete faulty ones except from the database?

[Bounce]

I'll give him a donation too!

ditto for a vb4 version, some of my my users will even donate :cool:

[Shanti Nanda]

<font color="DarkOrchid">I know is dificult, but it will be great if someone update it to 4vB :'D</font>

[Eric]

Sorry guys, I won't be updating this to vBulletin 4; nor will I be continuing this mod on 3.8. It's marked as re-usable, so whoever wishes to take it on... feel free.

[RobbieZ]

Sorry guys, I won't be updating this to vBulletin 4; nor will I be continuing this mod on 3.8. It's marked as re-usable, so whoever wishes to take it on... feel free.

Shame

[Brew]

Will someone please take this mod over and update to vb 4.+ ?

Thanks!

[BirdOPrey5]

Has anyone tried using this in conjunction with the "Favorite Smilies" mod? Curious if any incompatibilities between the two.

[Lustikus]

please update to 4.0.x :-)

[adwade]

Just wanted to say this MOD is working fine, on v3.8.6PL1 :D The IMPORT PRODUCT (w/ALLOW OVERWRITE selected) found my old, existing installation of MySmilies VB (https://vborg.vbsupport.ru/showthread.php?t=135336) (Mod Version: 1.00, by Kentaurus) (https://vborg.vbsupport.ru/member.php?u=3031) and automatically adjusted things for it.

However at first, I could not see ANY My Smilies Menu on the UserCP page?! :confused:

The problem was, 'I' didn't READ far enough down into the Installation Instructions.txt file... :o
Step 4. Permissions setup
=========================

1. Open http://YOUR_FORUMS_URL/admincp/index.php?do=buildbitfields
2. In your admin control panel go to Usergroups => Usergroup Manager
3. Edit the Usergroups that you want to use smilies, by changing the "Can use custom smilies? (MySmilies VB)" to "Yes".
NOTE: From MySmiles VB v3.7.005 and above, Usergroups do NOT have permissions as default, and they will need to be set again.Notice it says "Usergroups do NOT have permissions as default"...something I completely overlooked. :o So just guess what (doesn't) happen, when you don't go and set up the Usergroups Pemissions for this MOD like you're supposed to? ;)
Answer: "Nothing!" ha, ha

Thanxx SecondV, SWEET MOD!

[Skedoozy]

Nothing like this for 4.x?!?!

[SBlueman]

I got this error when I tried to set my smilies:

Your submission could not be processed because a security token was missing.

If this occurred unexpectedly, please inform the administrator and describe the action you performed before you received this error.

[Replicators]

Hell i think it would be cool if we could use a points system with this, need to pay some creds in order to upload your own smiley.

[Eric]

Good news :) I'm 80% finished with a version for vB 4. It'll have to wait until vB 4 w/CKEDITOR is out though, won't be compatible with previous releases.

[ShawneyJ]

Since installing getting these errors


Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12

Warning: Invalid argument supplied for foreach() in [path]/includes/class_bbcode.php(451) : eval()'d code on line 12



same damn it.

[angeljs]

Good news :) I'm 80% finished with a version for vB 4. It'll have to wait until vB 4 w/CKEDITOR is out though, won't be compatible with previous releases.
Can't wait for this! So glad it's finally being done for vB4 :D

[Eric]

vB4: https://vborg.vbsupport.ru/showthread.php?t=264257

I am going to do some bug fixes on the 3.8 version soon.

[ShawneyJ]

I am going to do some bug fixes on the 3.8 version soon.

sweet, thanks mate, this would be orsm ;)

[Eric]

v3.8.005 - June 23rd, 2011
-- Fixed: "Warning: Invalid argument supplied for foreach()" errors.
-- Changed: how the smilie datastore cache is generated/accessed.
-- Added: Option to pull all user smilies for the editor or just the current user id's smilies.

[drsli]

Many thanks for the update. Works now and installed! :)

[nascartr]

Nevermind, figured it out.

[prandah]

hello, i have install it
my question
where i moderate / chect smilies for member ?

[xorex]

Eric (https://vborg.vbsupport.ru/member.php?u=142777) thanks for this release. installed !

Maybe you can make easy fix to the next release for "Maximum number of smilies a user can have" setting when "Can use custom smilies? (MySmilies vB)" set to "Yes"?

if this option is "0" user have not permission to view upload links from UserCP. quick links and other upload links. I think he really no needed if "Maximum number of smilies a user can have" set to "0" on usergroups permissions. but he can use smilies from editor other users smilies who can upload.

Regards

[ravenscape]

I ran into a problem with this add on when working on a new feature for my forum.

For each style template you have, whoever first views a post that isn't already in the postparsed table causes a record to be inserted into the postparsed table. If that person has showimages turned on, then the parsed post will show the image to other users who use that style template no matter whether they have showimages turned on or not. Same thing in reverse if the first person has showimages turned off.

It's an easy fix, fortunately, but it was very difficult to track down.

In the bbcode_parse_complete plug-in, remove or comment out the following line:

$this->cached['text'] = $text;

and change the hook to bbcode_parse_complete_precache

then delete all records from the postparsed table. The table will be rebuilt properly as your users click on threads and view posts.

[ChiNa]

thanks mate for the amazing addon, I will check this out befor installing,,

[beekay]

anyone have any idea how to make the smilies float like the regular smilies do?

the mysmilies seem to be placed on top of the line of text instead of in the middle so they look a little off compared to my regular ones

great hack btw

[mito22]

No version for VB5?