PDA

View Full Version : Forum Home Enhancements - [YUI] Tabbed Forum Home


bobster65
12-02-2008, 10:00 PM
Tabbed Forum Home v2.0.0 Beta 1 - YUI Based Tabs

Pulled back and will be re-released at a later date

bobster65
12-03-2008, 12:46 AM
Installing v2.0.x is much simpler than any previous version of TFH to install, first, you want to remove the following files and revert changes from previous versions to the templates. Note: You may want to keep the tab's data for reference later.

Step 1: Make Reverts

The first step is to revert your forum to not include any tabs, this will be a clean slate for TFH and improve the quality of the installation instructions. Listed below is template edits, file edits, and uploaded files for you to remove and change back to the original. For full reverts needed, please look at the install docs for version 1.0x located in the download package.
1.0x
FORUMHOME - template edits
index.php - file edits; the easiest way to revert this is to download the vBulletin package that corresponds to your version and upload index.php overwriting your changes.
/forum_root/tabs/* - added files, remove directory and files within.
/index_tab.php - An edited copy of index.php if is still there, remove it.
/index_*.php - the backup file the install docs instructed you to change, you may either remove this or rename it back to index.php. This may not correspond to your current version, so your best bet would be the step described in #2.
1.5.0 Beta
clientscript/tabs/ajaxtabs.css - added file, delete.
clientscript/tabs/ajaxtabs.js - added file, delete.
clientscript/tabs/loading.gif - added file, delete.
/tabforumhome.php - added file, delete.
FORUMHOME - template edits, see install doc for v1.5.0 for full changes.
forumhome_forumbit_level1_post - template edits, see install doc for v1.5.0 for full changes.
forumhome_forumbit_level1_nopost - template edits, see install doc for v1.5.0 for full changes.
FORUMHOMETAB - remove the template; clicking [Revert] on the custom template should remove this

Now that you have reverted changes from previous versions, the installation of v2.0 comes next.

Step 2: File Uploads

You want to upload the following files to your server into the corresponding directory on your server. These files are found in the "UPLOAD" folder of the package. Note: The Uploads folder has a syntax of sorting files into sub-folders. These folders correspond to the default names for folders in a vBulletin installation. The files directly found within the "UPLOAD" folder signify the forum root.

Upload the following files:
/tabindex.php
/tab_blog.php - Note: This is used by the default vBulletin Blog Module. This requires vBulletin Blog to be installed and activated to work.
/tab_blog_entry.php - Note: This is not used by the default vBulletin Blog Module. This requires vBulletin Blog to be installed and activated to work. To set the blog module to use this file, use the "Edit Module Functionality" to set the file name to this file.
/tab_pt.php - Note: This file is not currently being shipped with Beta 1 - it will ship with Beta 2! This file will be used for the default Project Tools module and requires vBulletin Project Tools to be installed and activated to work.
/clientscript/yui/tabview/* - Upload the directory tabview and all files inside of it.
/clientscript/yui/elements/* - Upload the directory elements and all files inside of it.
/clientscript/yui/fonts/* - Upload the directory fonts and all files inside of it.
/clientscript/yui/utilities/* - Upload the directory utilities and all files inside of it.
/includes/xml/cpnav_tfh.xml
/admincp/tfh.php
/admincp/tfh_fixes.php
/admincp/tfh_impex.php
/admincp/tfh_modules.php

Step 3: Product Import

To do the bulk of the installation, all you need to do is import the file called product_bobster_tfh.xml by following entering the ACP and following this set of links:

ACP -> Plugins & Products -> Manage Products -> [Add/Import Product]

Once you import the product, it will add a template called "FORUMHOMETAB" to all your styles. This template includes the default template data located within the FORUMHOME template's <!-- main --> comments.

Step 4: Template Edits

Template: FORUMHOME

Find:
</head>

Add Before that line:
<!-- Tabbed Forum Home Header Code -->
<!-- Dependencies -->
<!-- TFH Skin CSS for TabView -->
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/tabview.css" />
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/skin-tfh.css" />

<!-- JavaScript Dependencies for Tabview: -->
<script type="text/javascript" src="clientscript/yui/utilities/utilities.js"></script>
<script type="text/javascript" src="clientscript/yui/element/element-beta-min.js"></script>

<!-- Source file for TabView -->
<script type="text/javascript" src="clientscript/yui/tabview/tabview-min.js"></script>

<!-- Source file for Dispatcher -->
<script type="text/javascript" src="clientscript/yui/tabview/dispatcher.js"></script>

<!-- /Tabbed Forum Home Header Code -->


If you have a custom FORUMHOME template, follow Option 2 instead of Option 1.

OPTION 1:
Find:
<!-- main -->
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr align="center">
<td class="thead">&nbsp;</td>
<td class="thead" width="100%" align="$stylevar[left]">$vbphrase[forum]</td>
<td class="thead">$vbphrase[last_post]</td>
<td class="thead">$vbphrase[threads]</td>
<td class="thead">$vbphrase[posts]</td>
<if condition="$vboptions['showmoderatorcolumn']">
<td class="thead">$vbphrase[moderator]</td>
</if>
</tr>
</thead>
$forumbits
<tbody>
<tr>
<td class="tfoot" align="center" colspan="<if condition="$vboptions['showmoderatorcolumn']">6<else />5</if>"><div class="smallfont"><strong>
<a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow">$vbphrase[mark_forums_read]</a>
<if condition="$vboptions['forumleaders']">&nbsp; &nbsp;
<a href="showgroups.php$session[sessionurl_q]">$vbphrase[view_forum_leaders]</a></if>
</strong></div></td>
</tr>
</tbody>
</table>
$forumhome_markread_script
<!-- /main -->

Replace with:
<!-- main -->

<!-- Tabbed Forum Home -->
<div id="forumhome_container">
</div>

<script type="text/javascript">
$tfh
</script>
<!-- /Tabbed Forum Home -->

<!-- /main -->

OPTION 2 - This is for boards with custom FORUMHOME templates.
Find (This is the default template, yours will vary.):
<!-- main -->
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr align="center">
<td class="thead">&nbsp;</td>
<td class="thead" width="100%" align="$stylevar[left]">$vbphrase[forum]</td>
<td class="thead">$vbphrase[last_post]</td>
<td class="thead">$vbphrase[threads]</td>
<td class="thead">$vbphrase[posts]</td>
<if condition="$vboptions['showmoderatorcolumn']">
<td class="thead">$vbphrase[moderator]</td>
</if>
</tr>
</thead>
$forumbits
<tbody>
<tr>
<td class="tfoot" align="center" colspan="<if condition="$vboptions['showmoderatorcolumn']">6<else />5</if>"><div class="smallfont"><strong>
<a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow">$vbphrase[mark_forums_read]</a>
<if condition="$vboptions['forumleaders']">&nbsp; &nbsp;
<a href="showgroups.php$session[sessionurl_q]">$vbphrase[view_forum_leaders]</a></if>
</strong></div></td>
</tr>
</tbody>
</table>
$forumhome_markread_script
<!-- /main -->

Copy your custom modifications and replace the contents of the template "FORUMHOMETAB" with your custom modifications - nothing will be lost from TFH as the template FORUMHOMETAB is just a copy of the default code within <!-- main --> and <!-- /main -->.

After you have copied your code, replace the code you copied above (in the FORUMHOME template) with:
<!-- main -->

<!-- Tabbed Forum Home -->
<div id="forumhome_container">
</div>

<script type="text/javascript">
$tfh
</script>
<!-- /Tabbed Forum Home -->

<!-- /main -->

Template: forumhome_forumbit_level1_nopost, forumhome_forumbit_level1_post

Add this code to the beginning of the template:
<if condition="(THIS_SCRIPT == 'indexTAB' AND in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all',$GLOBALS[tabcats])) OR THIS_SCRIPT == 'forumdisplay'">

Add this code to the end of the template:
</if>

Template: forumhome_forumbit_level1_nopost

Find:
<a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('forumbit_$forumid')"><img id="collapseimg_forumbit_$forumid" src="$stylevar[imgdir_button]/collapse_tcat{$collapseimg_forumid}.gif" alt="" border="0" /></a>

Replace with:
<a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('forumbit_$forumid$GLOBALS[tabID]')"><img id="collapseimg_forumbit_$forumid$GLOBALS[tabID]" src="$stylevar[imgdir_button]/collapse_tcat{$collapseimg_forumid}.gif" alt="" border="0" /></a>

Find:
<tbody id="collapseobj_forumbit_$forumid" style="{$collapseobj_forumid}">

Replace with:
<tbody id="collapseobj_forumbit_$forumid$GLOBALS[tabID]" style="{$collapseobj_forumid}">

bobster65
12-03-2008, 12:46 AM
Step 5: Adding Tabs & Modules

Now that you have completed the file uploads, template edits, and product import, you are ready to add tabs and modules.

Adding A Tab

To add a tab, refresh your ACP and you should see a "Tabs" group in your ACP. Expand this group and click on "Manage Tabs. Click on "[Add Tab]", and fill out the form.

The "Tab Name" is what will be displayed within the tab. "Forums" is the forums you want displayed in the tab. Separate items using a comma (",") and no spaces! "Limit tabs to..." is the usergroup permission set up, usage is explained on the form. "Cache Data" tells YUI if it should fetch the data once and cache it so it doesn't reload the data every time a user clicks on the tab.

Clicking "Add Tab" will add the tab to your forum home listing.

Adding a Module

To add a module you click on the "Manage Modules" link in the "Tabs" group. Click on the "Add Module" and fill out the form, it is basically the same as tabs except for the fact that you must specify a file name. The "Enable Module" option will specify whether or not you want the module to display. Disabled modules are not deleted, they just will not show on the forum home with the rest of your tabs.

bobster65
12-03-2008, 12:47 AM
Additional Features Info - Coming Soon

bobster65
12-03-2008, 12:47 AM
Enhancements/Modifications/Integration with other Mods - Coming Soon!

bobster65
12-03-2008, 12:48 AM
Add on Content Modules - Coming Soon!

King Kovifor
12-03-2008, 12:49 AM
Man is it nice to say this is released!

Also, our bug tracker is now public. You may view the current bugs in 2.0 (that we know of!) by clicking this link:

http://www.smnlikdat.org/project.php?do=issuelist&projectid=2&issuetypeid=bug

ArnyVee
12-03-2008, 12:51 AM
Woo Hoo! :D

Okay, now gotta get to work on this ;)

rob01
12-03-2008, 01:03 AM
Warning: require_once(includes/class_yui.php) [function.require-once]: failed to open stream: No such file or directory in C:\wamp\www\vb\index.php(565) : eval()'d code on line 1

Fatal error: require_once() [function.require]: Failed opening required 'includes/class_yui.php' (include_path='.;C:\php5\pear') in C:\wamp\www\vb\index.php(565) : eval()'d code on line 1


you know about this error? :S

bobster65
12-03-2008, 01:07 AM
Warning: require_once(includes/class_yui.php) [function.require-once]: failed to open stream: No such file or directory in C:\wamp\www\vb\index.php(565) : eval()'d code on line 1

Fatal error: require_once() [function.require]: Failed opening required 'includes/class_yui.php' (include_path='.;C:\php5\pear') in C:\wamp\www\vb\index.php(565) : eval()'d code on line 1


you know about this error?

its not an error.. KK forgot to add that file when he created the ZIP file.. hang tight and I'll grab the file and repack the zip and upload it.

King Kovifor
12-03-2008, 01:08 AM
Oh crap, I just knew I was forgetting something, I had class_yui.php on the server due to it being used by an internal mod!!!!

bobster65
12-03-2008, 01:44 AM
ok, ZIP File has been updated with the missing file.... sorry about that!

glorify
12-03-2008, 01:50 AM
Great work Bobbo and double K :)

King Kovifor
12-03-2008, 01:51 AM
ok, ZIP File has been updated with the missing file.... sorry about that!

Make that sorry times about 25 from me. I even went through a test install!

rob01
12-03-2008, 01:56 AM
now i get this error -> Content Encoding Error :S

ArnyVee
12-03-2008, 01:57 AM
I'm still working on this, but it's thrown my style for a loop :(

I have a custom style, but I found the code within OPTION 1 to change, so went that route. I might need some help :)

King Kovifor
12-03-2008, 02:03 AM
Arny, Option 2 is the option for you.

Rob, can you provide more details as to where you received the error, what you were doing when you got the error and a screenshot if possible. This will help us, help you!

ArnyVee
12-03-2008, 02:11 AM
When I attempt to edit forumhome_forumbit_level1_nopost I get....

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3716) : eval()'d code on line 1

Why am I stopped here? Any ideas?

CHIPIT
12-03-2008, 02:15 AM
Hmm, while the mod still seems to be functioning fine, when applying the conditional to forumhome_forumbit_level1_nopost and forumhome_forumbit_level1_post, PHP throws out the following error Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1and the All Forums module doesn't seem to be displaying..

King Kovifor
12-03-2008, 02:21 AM
Hmm, while the mod still seems to be functioning fine, when applying the conditional to forumhome_forumbit_level1_nopost and forumhome_forumbit_level1_post, PHP throws out the following error Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1and the All Forums module doesn't seem to be displaying..

Did you enable it and give it a few seconds to load? Our test forum has it working fine. And would you mind throwing that error in the bug tracker? I will look into it tomorrow. Which is weird as I have these applied to two different forums and is working fine.

King Kovifor
12-03-2008, 02:23 AM
When I attempt to edit forumhome_forumbit_level1_nopost I get....

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3716) : eval()'d code on line 1

Why am I stopped here? Any ideas?

Hm, same template, two different line numbers. Can you tell me your vBulletin version?

CHIPIT
12-03-2008, 02:25 AM
Did you enable it and give it a few seconds to load? Our test forum has it working fine. And would you mind throwing that error in the bug tracker? I will look into it tomorrow. Which is weird as I have these applied to two different forums and is working fine.
Yeah I did, but perhaps it's possible the two issues are related and a problem in the conditional prevents the all forums module from displaying? My forumbit templates are highly customized but I don't see how that would affect the conditional.. I'll go post it in the tracker..

Hm, same template, two different line numbers. Can you tell me your vBulletin version?
vB 3.8.0 Beta 4 for me, and I believe I was getting the same error, but the error I posted is on the actual forumhome, and the error ArnyVee posted was from the template manager.

ArnyVee
12-03-2008, 02:27 AM
Hm, same template, two different line numbers. Can you tell me your vBulletin version?

My version is 3.7.1 PL 1.

Now, after I went through and did all the edits, the top of my style has this code multiple times....


Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

King Kovifor
12-03-2008, 02:29 AM
Thanks, I am on one of the most useful devices I have ever bought from Apple and they fail to have copy and paste. Keep track of the issue, I may request some speciic info like vBulletin version, your customized template and so forth.

ArnyVee
12-03-2008, 02:31 AM
KK, I can't turn my forums back on with this the way it is. Should I just go back and uninstall things and then try again when we fix that?

King Kovifor
12-03-2008, 02:31 AM
My version is 3.7.1 PL 1.

Now, after I went through and did all the edits, the top of my style has this code multiple times....


Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Hm. Maybe the if conditional is bad on anything before 3.7.4. I will take a required look tomorrow.

I hate to say it, but yes. I get home around 3:30 eastern us time and will do my he and look into this! Hopefully this doesn't take long to resolve.

ArnyVee
12-03-2008, 03:33 AM
KK, I just upgraded to 3.7.4, but I get the same message at the top of the forum home. Just an FYI

AWJunkies
12-03-2008, 03:37 AM
So glad it is now YUI :)

You can group YUI files for faster load and one single call just FYI with YUI website. Would be nice to see an option for this rather then local files which is slower. I understand having them local on server but just like vB gives the option to grab from YUI directly or files on server would be nice to see this option. As calling from YUI and grouping is faster and always up to date and to change versions you just change the 2.6.0 to whatever instead of doing complete overhaul of mod with new files to upload.


http://yui.yahooapis.com/combo?2.6.0/build/yahoo-dom-event/yahoo-dom-event.js&2.6.0/build/connection/connection-min.js

http://yui.yahooapis.com/combo?2.6.0/build/datasource/datasource-min.js&2.6.0/build/element/element-beta-min.js&2.6.0/build/datatable/datatable-min.js&2.6.0/build/tabview/tabview-min.js&2.6.0/build/paginator/paginator-min.js

This makes it a single remote call and compressed and still can be cached.

About to load and test 2.0.0 very excited about YUI thought I was going to have to code one YUI for sites but now you did it thank you saves me a lot of time.

http://developer.yahoo.com/yui/articles/hosting/

King Kovifor
12-03-2008, 03:43 AM
ArnyVee, I believe I have narrowed it down to a specific problem, and plan on looking at possible changes tomorrow. The issue chipit posted will include a patch file soon (if I can figure svn diff out).

Awj, I know about that, but for some reason the tfh only seems to work in the specific order we have. And we don't use only YUI files for the tabs. ;)

AWJunkies
12-03-2008, 03:56 AM
I got ya Just the header file you have is 4 files and 2 css styles all which can be grouped to a single call. Will show you real easy I already did it to your mod and works perfect already got it installed and working fine so far diving more in in a second. Helps a LOT to have TMS as I just had to turn off the template edits from TMS to install new one was very easy and very nice recommend that to everyone.

Ok back to testing I go will let you know if anything comes up.

GREAT WORK AGAIN BY THE WAY MUCH APPRECIATED!

Also another not big deal is your using old YUI files 2.5.2 is old and some systems where beta at this time 2.6.0 is latest AGAIN not a big issue.

ArnyVee
12-03-2008, 04:07 AM
ArnyVee, I believe I have narrowed it down to a specific problem, and plan on looking at possible changes tomorrow. The issue chipit posted will include a patch file soon (if I can figure svn diff out).

Sounds good.

I've gone back and took out the edits that I did with the mod. Unfortunately, I didn't save my template beforehand, so now I have to backtrack and do some diggin' to see how it originally displayed. That's what I get for not backing up! :(

I'll keep an eye out for the fix tomorrow. Thanks!

Morsolo
12-03-2008, 04:13 AM
now i get this error -> Content Encoding Error :S

You using the GreenFox skin? Or a vBStyles.com skin of any sort?
I'm getting the same error to, I've been trying to fix, can't get any results yet....

rob01
12-03-2008, 04:39 AM
King Kovifor thanks, well i upload all the files and install the product

but when i try to open http://localhost/vb/index.php (my vb demo)

i get this error


Content Encoding Error













The page you are trying to view cannot be shown because it uses an invalid or unsupported form of compression.







The page you are trying to view cannot be shown because it uses an invalid or unsupported form of compression.

* Please contact the website owners to inform them of this problem.

ndut
12-03-2008, 05:05 AM
will try later, thank you

ArnyVee
12-03-2008, 05:11 AM
Bob/KK, I already mentioned it to Bree...but, there were some issues with the page going way wide due to Cyb's Sub Forum mod. Bree is working on a fix, but just an FYI. :D

Morsolo
12-03-2008, 05:13 AM
Ok, I have reverted my site 'till just before mod installation and it appears something in the includes/class_yui.php is causing the Encoding Error.

AWJunkies
12-03-2008, 05:14 AM
Bob/KK, I already mentioned it to Bree...but, there were some issues with the page going way wide due to Cyb's Sub Forum mod. Bree is working on a fix, but just an FYI. :D

All you do is follow directions it tells you within there mod and 0 issues tells you exactly what to do go to those to plugins in CYB mod and add the OR statement. Works perfect.

My issue I am having is the tabs are not showing JUST X forum id but showing ALL no matter what I do which is very strange. I went back to full your js everything and same issue so has nothing to do with my doing different js calls.

Anyone else getting this issue? No errors just shows all forums no matter what Id's I put. I followed pictures to the T as examples still no go.

if you do within plugin:
print_r($content);

It is showing correct forums and info example:
tID=1&tabcat[]=1&
tID=2&tabcat[]=1&tabcat[]=47&

if you do within plugin:
print_r($GLOBALS[tabcats]);

It is showing correct forums and info example:
Array ( [0] => 1 )
Array ( [0] => 1 , [1] => 47)

If you put a direct URL in:
http://www.yourdomain.com/tabindex.php?tID=1&tabcat[]=1

It still shows all forums :)

Anyone else getting this?

All the edits are complete the if statements are there for the check.

Morsolo
12-03-2008, 05:39 AM
~SNIP~

My issue I am having is the tabs are not showing JUST X forum id but showing ALL no matter what I do which is very strange. I went back to full your js everything and same issue so has nothing to do with my doing different js calls.

Anyone else getting this issue? No errors just shows all forums no matter what Id's I put. I followed pictures to the T as examples still no go.

Yes, for some reason, the Encoding Error just vanished and now I can view the forums, but I am getting that issue.
It isn't showing "X" Forums, it is showing all of them. And I am getting no spacing between each category, for example it should look like:
CATEGORY
-- FORUM

CATEGORY
-- FORUM
But it is going:
CATEGORY
-- FORUM
CATEGORY
-- FORUM

AWJunkies
12-03-2008, 05:52 AM
Yes, for some reason, the Encoding Error just vanished and now I can view the forums, but I am getting that issue.
It isn't showing "X" Forums, it is showing all of them. And I am getting no spacing between each category, for example it should look like:

But it is going:

I just noticed that as well the forums spacing is gone it is all smooshed together. testing on 5 different styles FYI

It has to do with if statement:
<if condition="(THIS_SCRIPT == 'indexTAB' AND in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all',$GLOBALS[tabcats])) OR THIS_SCRIPT == 'forumdisplay'">

if you make it:
<if condition="(THIS_SCRIPT == 'indexTAB' AND in_array($forum['forumid'], $GLOBALS[tabcats]))">

It works for the direct forum add tab BUT not the modules.

Real weird got it working on one style now but still all the others messed up and NOT working with modules just tabs with forums.

Socceradicto
12-03-2008, 07:15 AM
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

SteamyLightning
12-03-2008, 08:20 AM
Tried to edit the level1 templates:

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3763) : eval()'d code on line 1

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

And when I tried all the edits, I get this error:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Repeated several times.

rapidphim
12-03-2008, 08:34 AM
Bob, can you upgrade this one for 3.8.x?

s810car
12-03-2008, 09:24 AM
Excellent been waiting for this :D

Since its still in Beta, i'll fire up the home server and check it out see how it runs on 3.7.2

Doom Stone
12-03-2008, 09:30 AM
Was a long time coming but it's worth it, thanks a lot for the work on this guys.

Mesohu
12-03-2008, 10:11 AM
Can I install it or I must wait for the fix ?

lowey
12-03-2008, 11:13 AM
With me the following error occurred when attempting to evaluate the forumhome_forumbit_level1_nopost and forumhome_forumbit_level1_post templates:

Warnung: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3772) : eval()'d code (Zeile 1)

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.


After ignoring the warnings, I get the following output when trying to access FORUMHOME:

Warnung: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code (Zeile 1)


I'm using vBulletin 3.7.4 Patch Level 1. :(

Mesohu
12-03-2008, 11:29 AM
lowey , I think that we must wait for the thix.

ArnyVee
12-03-2008, 11:38 AM
I would wait. I know that KingK stated last night that he'd be working on it throughout the morning hours :)

So, hopefully we'll hear something soon. :D

SteamyLightning
12-03-2008, 11:53 AM
lowey , I think that we must wait for the thix.
You can run it without the fix, as it still works.

I'm in the exact same boat as lowey (pretty much the same errors), and I just turned off error reporting for functions_forumlist, and used it as normal. It's not ideal, but it works.

ThomasR
12-03-2008, 02:09 PM
I also have the same error message on editing the two forumhome_forumbit_level1_nopost and forumhome_forumbit_level1_post
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3729) : eval()'d code on line 1
On a fresh & clean install of the 3.7.3 PL1 (the version I have on my production server.
Anyway, it's working and it's cool! Waiting for the fix and congratulation again for this nice plugin!

But I have a question about the modules:
- will it be possible to have a product content inside a tab (like Flashchat, or a shoutbox?)
- will it be possible to display parts of VB stuff like all the albums lists or last album content uploads?
- will it be possible to have a custom HTML/php page with our own content (like a special announcement for a contest, etc...)
- will it be hard for non professional coders to create such modules?

Thanks again!

Megatr0n
12-03-2008, 02:18 PM
Question:

Will this be updated to be compatible with 3.8 when it goes Gold?

bobster65
12-03-2008, 02:36 PM
I also have the same error message on editing the two forumhome_forumbit_level1_nopost and forumhome_forumbit_level1_post
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3729) : eval()'d code on line 1
On a fresh & clean install of the 3.7.3 PL1 (the version I have on my production server.
Anyway, it's working and it's cool! Waiting for the fix and congratulation again for this nice plugin!

But I have a question about the modules:
- will it be possible to have a product content inside a tab (like Flashchat, or a shoutbox?)
- will it be possible to display parts of VB stuff like all the albums lists or last album content uploads?
- will it be possible to have a custom HTML/php page with our own content (like a special announcement for a contest, etc...)
- will it be hard for non professional coders to create such modules?

Thanks again!

Hopefully KK is on it (fixing the error) ... not sure why everyone is getting it.. We have it installed on multiple sites and have never seen it, so maybe there is something wrong with the template edits in the instructions.. at any rate, we'll get it fixed asap..

to answer your Modules Questions...

- will it be possible to have a product content inside a tab (like Flashchat, or a shoutbox?)

Yes, however a content module will have to be created to do this. In the 2 cases you mentioned, there are multiple ways to pull this off. We will be releasing more info on Modules soon.

- will it be possible to display parts of VB stuff like all the albums lists or last album content uploads?

Yes, I already have released multiple content modules with my AJAX Tabs Modification and they all work just fine with this modification. I will be adding released content modules in post 5 of this thread soon (you can always download them from the AJAX Tabs Mod in the mean time). Released Content files include recent threads, news, albums, Blogs etc...

- will it be possible to have a custom HTML/php page with our own content (like a special announcement for a contest, etc...)

Yes, this is really easy.. just create your custom HTML or PHP file and upload it as a module. Can't get any easier than that.

- will it be hard for non professional coders to create such modules?

yes and no .. just depends on your level of expertise. As I mentioned above, you can do something as simple as a basic HTML file or as complex as you want via php. We plan to release as many different types of Content Modules and we also encourage members to release their own.

s810car
12-03-2008, 02:37 PM
I think the 2nd arguement thing was missing a parenthesis, i got it to save by putting brackets like so (took out the quotes in forumid as well, which may or may not be correct)
<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum[forumid], $GLOBALS[tabcats]) OR in_array('all', $GLOBALS[tabcats]))) OR (THIS_SCRIPT == 'forumdisplay')">

Doesn't mean it worked though :( still got the encoding error

bobster65
12-03-2008, 02:37 PM
Question:

Will this be updated to be compatible with 3.8 when it goes Gold?

We have it installed and running on 3.8.0 beta 3 right now ( http://www.smnlikdat.org/forum.php)

Tianuc
12-03-2008, 03:22 PM
I think the 2nd arguement thing was missing a parenthesis, i got it to save by putting brackets like so (took out the quotes in forumid as well, which may or may not be correct)
<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum[forumid], $GLOBALS[tabcats]) OR in_array('all', $GLOBALS[tabcats]))) OR (THIS_SCRIPT == 'forumdisplay')">

Doesn't mean it worked though :( still got the encoding error

Thank you, the template does not prompt an error. IE there is an error.

Error:Dispacher: Script Execution Error ([object Error])
https://vborg.vbsupport.ru/external/2008/12/107.jpg

SPARKS MAN
12-03-2008, 03:46 PM
Thanks
its very good idea I'll try it
Mark as install

s810car
12-03-2008, 04:42 PM
Ok, I have reverted my site 'till just before mod installation and it appears something in the includes/class_yui.php is causing the Encoding Error.

Since you mentioned that, i checked the file I got and it has one line around line 36 saying
$tabID =
and then empty space that line, I assume there's something to be there?

Megatr0n
12-03-2008, 04:57 PM
We have it installed and running on 3.8.0 beta 3 right now ( http://www.smnlikdat.org/forum.php)

OK, but Beta and RC versions can change accordingly. So, if there are changes in the final version which, would prevent this version of the hack functioning properly. Will, you update the hack?

ThomasR
12-03-2008, 06:06 PM
Bobster65: Thank you very much for these answers and the time you devote for us. I will check the other modules for the previous version and try to upload an html page (no header / footer, just html content I guess :)

Edit:
I just tried to upload a XML file with just this content as a module, and as you may guess, it's not working :)
<div align="center">This is a<strong> HTML</strong> test!
</div>

Edit2:
I checked an existing module and edited to:
<?xml version="1.0" encoding="ISO-8859-1"?>

<modules>
<module>
<name>test html</name>
<file><div align="center">This is a<strong> HTML</strong> test!</div></file>
<cache>false</cache>
</module>
</modules>
Without <file></file>, I have a database error on the import process :) Witht these tags, I can import the module, I have the tab, but an empty content.
Can you post a short sample, if you have the time (not a priority at all for me!) Thanks!

Hugo Holbling
12-03-2008, 07:13 PM
I get the same error and will wait to see if someone smarter than me can figure it out but I just wanted to say thanks to Bob and KK for their hard work on this. :)

King Kovifor
12-03-2008, 07:15 PM
I think the 2nd arguement thing was missing a parenthesis, i got it to save by putting brackets like so (took out the quotes in forumid as well, which may or may not be correct)
<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum[forumid], $GLOBALS[tabcats]) OR in_array('all', $GLOBALS[tabcats]))) OR (THIS_SCRIPT == 'forumdisplay')">

Doesn't mean it worked though :( still got the encoding error

I am working on a fix for this now. I may need some help testing it.

Since you mentioned that, i checked the file I got and it has one line around line 36 saying
$tabID =
and then empty space that line, I assume there's something to be there?

You may remove that, tabID isn't set through PHP and I'm not sure how it got in there. :)

Bobster65: Thank you very much for these answers and the time you devote for us. I will check the other modules for the previous version and try to upload an html page (no header / footer, just html content I guess :)

Edit:
I just tried to upload a XML file with just this content as a module, and as you may guess, it's not working :)
<div align="center">This is a<strong> HTML</strong> test!
</div>

Edit2:
I checked an existing module and edited to:
<?xml version="1.0" encoding="ISO-8859-1"?>

<modules>
<module>
<name>test html</name>
<file><div align="center">This is a<strong> HTML</strong> test!</div></file>
<cache>false</cache>
</module>
</modules>
Without <file></file>, I have a database error on the import process :) Witht these tags, I can import the module, I have the tab, but an empty content.
Can you post a short sample, if you have the time (not a priority at all for me!) Thanks!

Adding a module does not require an xml file. Click on "Add Module" in the ACP back end and fill out the form.

NAZIA
12-03-2008, 07:17 PM
You have done. Awesome.
I will Do it soon at my board...

Thanks for this full New Version...Now Its look like namepros.com tabs...

King Kovifor
12-03-2008, 07:31 PM
My version is 3.7.1 PL 1.

Now, after I went through and did all the edits, the top of my style has this code multiple times....


Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

To anyone having this problem, please try the fix described here:

http://www.smnlikdat.org/project.php?issueid=16#note36

ThomasR
12-03-2008, 08:03 PM
Adding a module does not require an xml file. Click on "Add Module" in the ACP back end and fill out the form.
Ok, found it, just have to upload an html file in the root of the forum and then, give the relative link to this file.

Now, I found something else, I don't know if it's a bug or not:

On my forum, I have a root style, in which I do all the template modifications for the plugins and I use a child style in which I do all the cosmetics edits (css changes, different icons, etc).

The problem is that the tabs are using the default style colors and not the style child look and feel when I select this child style. I guess that I can tweak that from the templates, but it would be better if it use the selected template CSS. I can post a screen capture if you want.

About the bug, I still have it after doing your fix above:


Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3729) : eval()'d code on line 1

and I have tghis error in order to the tabs content in my forum:
Fatal error: Cannot re-assign $this in /home/forums/www/tabindex.php on line 122

If you need the link (http://forums.polyloop.com/index.php?styleid=1) to my test forum.

King Kovifor
12-03-2008, 08:13 PM
Change this to $useless and see if that works. If the fix doesn't work, I will need to go back and try to make some changes...

ThomasR
12-03-2008, 08:22 PM
the fatal error in the tab content changed to :
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1
Top forum and tab content display the same error.

Time to sleep for me, will checking in 7-8 hours :)

sweetguy2004
12-03-2008, 08:27 PM
I have tried to install this but facing this problems

1. In my forumhome template i found only this

<!-- main -->
$forumbits
$forumhome_markread_script
<!-- /main -->

2. when i add this code in
<if condition="(THIS_SCRIPT == 'indexTAB' AND in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all',$GLOBALS[tabcats])) OR THIS_SCRIPT == 'forumdisplay'">

forumhome_forumbit_level1_nopost & forumhome_forumbit_level1_post

I get this error

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3716) : eval()'d code on line 1

& if i purposely edited the templates ignoring errors i got this error on homepage

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()d code on line 1

I am using vBulletin 3.7.2 Patch Level 1 with miner skinz

Please help

King Kovifor
12-03-2008, 08:52 PM
I have tried to install this but facing this problems

1. In my forumhome template i found only this

<!-- main -->
$forumbits
$forumhome_markread_script
<!-- /main -->

2. when i add this code in
<if condition="(THIS_SCRIPT == 'indexTAB' AND in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all',$GLOBALS[tabcats])) OR THIS_SCRIPT == 'forumdisplay'">

forumhome_forumbit_level1_nopost & forumhome_forumbit_level1_post

I get this error

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3716) : eval()'d code on line 1

& if i purposely edited the templates ignoring errors i got this error on homepage

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()d code on line 1

I am using vBulletin 3.7.2 Patch Level 1 with miner skinz

Please help

I'm working on a fix for another bug that should fix this.

King Kovifor
12-03-2008, 08:57 PM
the fatal error in the tab content changed to :
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1
Top forum and tab content display the same error.

Time to sleep for me, will checking in 7-8 hours :)

I've updated the fix, try that?

sweetguy2004
12-03-2008, 09:07 PM
I have uploaded & replaced all files & product also but still the same...

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3716) : eval()'d code on line 1

& can you tell me wat to so if i don't have

<!-- main -->
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%" align="center">
<thead>
<tr align="center">
<td class="thead">&nbsp;</td>
<td class="thead" width="100%" align="$stylevar[left]">$vbphrase[forum]</td>
<td class="thead">$vbphrase[last_post]</td>
<td class="thead">$vbphrase[threads]</td>
<td class="thead">$vbphrase[posts]</td>
<if condition="$vboptions['showmoderatorcolumn']">
<td class="thead">$vbphrase[moderator]</td>
</if>
</tr>
</thead>
$forumbits
<tbody>
<tr>
<td class="tfoot" align="center" colspan="<if condition="$vboptions['showmoderatorcolumn']">6<else />5</if>"><div class="smallfont"><strong>
<a href="forumdisplay.php?$session[sessionurl]do=markread" rel="nofollow">$vbphrase[mark_forums_read]</a>
<if condition="$vboptions['forumleaders']">&nbsp; &nbsp;
<a href="showgroups.php$session[sessionurl_q]">$vbphrase[view_forum_leaders]</a></if>
</strong></div></td>
</tr>
</tbody>
</table>
$forumhome_markread_script
<!-- /main -->

I have only this much

<!-- main -->
$forumbits
$forumhome_markread_script
<!-- /main -->

Thanks for quick reply & help

ThomasR
12-03-2008, 09:10 PM
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3729) : eval()'d code on line 1
when I save the two templates

and still the error in the tabs:
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

s810car
12-03-2008, 09:15 PM
still getting the errors even with the fix, gonna uninstall and try clean again

Edit: just to mes around, i uninstalled the product but left ALL template modifications in as well as the file includes My forum showed up again, however the forums were missing (obviously due to the if condition being false) Don't know if that info's any help or not, but i have been having both the encoding errors and the bad argument bug.

This was normal index.php btw. I tried tabindex.php and got the bad argument error still


Update: installed clean again, same errors :( I have the encoding error when i load index, and the bad argument error loading tabindex

AWJunkies
12-03-2008, 09:25 PM
This fix link still no work for me. I got one style to work but again modules a no go.

King Kovifor
12-03-2008, 10:35 PM
Hm. Would anyone be objecting to me using their site as a testing ground to poke around and make changes - as our servers are not getting either of these errors!

s810car
12-03-2008, 10:57 PM
i wish i could but i only have my production site, and the test server which happens to be WAMP on my home comp lol, ill try to get a mirror of my site up in a subdirectory, but i couldnt do that until tomorrow, I hope someone else can help this first

King Kovifor
12-03-2008, 11:12 PM
i wish i could but i only have my production site, and the test server which happens to be WAMP on my home comp lol, ill try to get a mirror of my site up in a subdirectory, but i couldnt do that until tomorrow, I hope someone else can help this first

The one thing I cannot figure out is why only some sites are getting this, and ours is not (2-3 servers depending on Bob's home set up).

Does anybody know if PHP is set to display errors?

bobster65
12-03-2008, 11:40 PM
The one thing I cannot figure out is why only some sites are getting this, and ours is not (2-3 servers depending on Bob's home set up).

Does anybody know if PHP is set to display errors?

I have it up and running on multiple configurations.. ie, php5 and php4, mysql5 and mysql4, vb 3.6x, 3.7x and 3.8 RC1

Linux Box (Ubuntu, apache2, php5, mysql5) ... vb 3.6x, 3.7x and 3.8 RC1

Linux Box, (Redhat, apache2, php5, mysql5) ... vb 3.6x, 3.7x and 3.8 RC1

Linux Box, (Ubuntu, apache, php4, mysql4) ... vB 3.6x, 3.7x

Windows Box, apache2, php5, mysql5 ... vb 3.6x, 3.7x and 3.8 RC1

Window Box, apache, php4, mysql4 ... vb 3.6x, 3.7x

All work fine.. no errors

TomasDR
12-03-2008, 11:42 PM
Three questions:
1. With Cache Data does it cache the forums, or forums & threads? Our forums are pretty much set, the last sub-forum added was over a year ago. of course if it caches the last thread, etc. I will pass on turning it on.

2. With adding a module, I am having a problem with one file I have, the content came up but weird, no css and no header/footer.
These files I made using this thread: How to create your own vBulletin-powered page! (https://vborg.vbsupport.ru/showthread.php?t=62164)

The template uses javascript and that's the only difference I see. Other ones where it's pure html or pulling images work fine.

$stylevar[htmldoctype]
<html dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<body>
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%"
align="center">
<tr>
<td class="tcat" align="center">Spanish Word of the Day</td>
</tr>
<tr>
<td class="alt1"><script language="javascript" src="http://www.donquijote.org/ext/cont/free_pdd.js.asp"> </script> <br><center><a href="http://www.donquijote.org" target="_NEW">Learn Spanish with don Quijote </a></center>
</td>
</tr>
<tr>
<td class="tcat" align="center">Spanish Lesson of the Week</td>
</tr>
<tr>
<td class="alt2"><script language="javascript" src="http://www.donquijote.org/ext/cont/free_lesson.js.asp"> </script> <br><center><a href="http://www.donquijote.org" TARGET="_new">Learn Spanish with don Quijote </a></center>
</td>
</tr>
</table>
</body>
</html>


3. Finally is there anyway to keep the tabs when people look at subforums?

s810car
12-03-2008, 11:46 PM
heres one better, my php info from my test server, but just as a note, the php.ini file is still very untouched since I have just set my server back up last weekend, so my production server is probably a little different, I can get that if you need it. Sorry about the formatting, i just did a quick copy paste, hope you can read it

King Kovifor
12-03-2008, 11:54 PM
Three questions:
1. With Cache Data does it cache the forums, or forums & threads? Our forums are pretty much set, the last sub-forum added was over a year ago. of course if it caches the last thread, etc. I will pass on turning it on.

2. With adding a module, I am having a problem with one file I have, the content came up but weird, no css and no header/footer.
These files I made using this thread: How to create your own vBulletin-powered page! (https://vborg.vbsupport.ru/showthread.php?t=62164)

The template uses javascript and that's the only difference I see. Other ones where it's pure html or pulling images work fine.

$stylevar[htmldoctype]
<html dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<body>
<table class="tborder" cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%"
align="center">
<tr>
<td class="tcat" align="center">Spanish Word of the Day</td>
</tr>
<tr>
<td class="alt1"><script language="javascript" src="http://www.donquijote.org/ext/cont/free_pdd.js.asp"> </script> <br><center><a href="http://www.donquijote.org" target="_NEW">Learn Spanish with don Quijote </a></center>
</td>
</tr>
<tr>
<td class="tcat" align="center">Spanish Lesson of the Week</td>
</tr>
<tr>
<td class="alt2"><script language="javascript" src="http://www.donquijote.org/ext/cont/free_lesson.js.asp"> </script> <br><center><a href="http://www.donquijote.org" TARGET="_new">Learn Spanish with don Quijote </a></center>
</td>
</tr>
</table>
</body>
</html>


3. Finally is there anyway to keep the tabs when people look at subforums?

1. It just caches the data it loads on that page. So it doesn't query your server every time for the updated info.

2. Can you post your module file?

3. Not at this time.

heres one better, my php info from my test server, but just as a note, the php.ini file is still very untouched since I have just set my server back up last weekend, so my production server is probably a little different, I can get that if you need it. Sorry about the formatting, i just did a quick copy paste, hope you can read it

You have display_errors set to On. So that may be why you are seeing it. I'm going to get my php.ini file and see what it looks like.

TomasDR
12-03-2008, 11:58 PM
Here's the file.

<?php
// ######################## SET PHP ENVIRONMENT ###########################
error_reporting(E_ALL & ~E_NOTICE);
// ##################### DEFINE IMPORTANT CONSTANTS #######################
// change the line below to the actual filename without ".php" extention.
// the reason for using actual filename without extention as a value of this constant is to ensure uniqueness of the value throughout every PHP file of any given vBulletin installation.
define('NO_REGISTER_GLOBALS', 1);
define('THIS_SCRIPT', 'spanish');
// #################### PRE-CACHE TEMPLATES AND DATA ######################
// get special phrase groups
$phrasegroups = array();
// get special data templates from the datastore
$specialtemplates = array();
// pre-cache templates used by all actions
$globaltemplates = array(
// change the lines below to the list of actual templates used in the script
'spanish_template1',
);
// pre-cache templates used by specific actions
$actiontemplates = array();
// ########################## REQUIRE BACK-END ############################
require_once('./global.php');
require_once('./includes/functions_forumdisplay.php');
// #################### HARD CODE JAVASCRIPT PATHS ########################
$headinclude = str_replace('clientscript', $vbulletin->options['bburl'] . '/clientscript', $headinclude);
// ################################################## ######################
// ######################### START MAIN SCRIPT ############################
// ################################################## ######################
$navbits = array();
// change the line below to contain whatever you want to show in the navbar (title of your custom page)
$navbits[$parent] = 'Spanish Lesson';
$navbits = construct_navbits($navbits);
// change the line below to contain the name of the actual main output template used in your script
eval('print_output("' . fetch_template('spanish_template1') . '");');
?>

s810car
12-04-2008, 12:04 AM
tried to turn display errors off, still had issues, but let me know if you have some other config that may help

King Kovifor
12-04-2008, 12:27 AM
OK, I was able to reproduce the Content Encoding Error (or Bree was) and we know it has something to do with class_yui.php - as was stated earlier in the thread - and I need to figure out why it is working that way.

s810car, turning the errors off gives you the content encoding error still or is it still saying Warning: at the beginning of everything?

CHIPIT
12-04-2008, 01:20 AM
I can confirm I have display errors turned on in php.ini, however an error still occurs when submitting the edited template... as others have said the fix isn't working, though with s810car's modified conditional

<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all', $GLOBALS[tabcats]))) OR (THIS_SCRIPT == 'forumdisplay')">
no errors. The parenthesis are what made it work, the quotes around forumid didn't make a difference. The All Forums module still won't display, though that may just be an error on my end since I haven't heard anyone else mention that.

s810car
12-04-2008, 01:36 AM
i get both, I get encoding errors visiting index.php, and the warnings on tabindex.php, or when i edit that conditional. I can play with the conditional to make it not error during save, but it doesnt fix it and still errors visiting tabindex

as far as the modifying chipit mentions, I wonder if its the order of the conditionals as well, or that should it be $GLOBALS[tabcats] or $tabcategories?

CHIPIT
12-04-2008, 01:58 AM
http://www.smnlikdat.org/project.php?issueid=16#note38

I modified the new conditional with $tabcategories to include your parenthesis fix <if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum['forumid'], $tabcategories) OR in_array('all', $tabcategories))) OR (THIS_SCRIPT == 'forumdisplay')">and like you said, no more errors in the template manager or forums page, but tabindex.php returns the error with the patch.

s810car
12-04-2008, 02:11 AM
im gonna be getting my production server settings files (php.ini etc.) see if I have better luck using my live setting, if i do at least I could have a source to compare to, ill update once i try it out

TomasDR
12-04-2008, 02:27 AM
2. Can you post your module file?


Sorry I was on the phone and running out the door, I read "Template".:D

Here's the php file.

All the extra pages I have are pretty much a cookie cutter copy of the thread I posted in my original post. The only difference with my spanish.php file is that there is javascript in the Template. The other Templates are all html.

rob01
12-04-2008, 03:26 AM
nvm understod wrong


i have a question

if i cant find this : <a style="float:$stylevar[right]" href="#top" onclick="return toggle_collapse('forumbit_$forumid')"><img id="collapseimg_forumbit_$forumid" src="$stylevar[imgdir_button]/collapse_tcat{$collapseimg_forumid}.gif" alt="" border="0" /></a>


and i have this errors:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1


Database error in vBulletin 3.7.4:

Invalid SQL:

SELECT
user.username, (user.options & 512) AS invisible, user.usergroupid,
session.userid, session.inforum, session.lastactivity, session.useragent,
IF(displaygroupid=0, user.usergroupid, displaygroupid) AS displaygroupid
FROM vbb_session AS session
LEFT JOIN vbb_user AS user ON(user.userid = session.userid)
WHERE session.lastactivity >;

MySQL Error : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 7
Error Number : 1064
Request Date : Thursday, December 4th 2008 @ 12:33:13 AM
Error Date : Thursday, December 4th 2008 @ 12:33:13 AM
Script : bbs/tabindex.php?tID=1&tabcat[]=128&
Referrer : bbs/index.php
IP Address :
Username :
Classname : vB_Database
MySQL Version : 5.0.51a-community


because of:

vbb_adminlog Check Error: Found 8704 keys of 8705
vbb_adminlog Check Error: Corrupt

any idea? :S

CHIPIT
12-04-2008, 03:47 AM
thanks CHIPIT, but still i think it might cause this error

I didn't say it addresses the issue, the patch fixes one bug while causing another, however using <if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum['forumid'], $tabcategories) OR in_array('all', $tabcategories))) OR (THIS_SCRIPT == 'forumdisplay')"> as the forumbit conditional seems to temporarily fix things, only issue is that won't fix the all forums module.

ThomasR
12-04-2008, 04:43 AM
KK: I will send you by pm in a couple of hours the admin access to my forum and an FTP access if you want.

Nova99
12-04-2008, 07:08 AM
It doesn't look like SE spiders can follow the forum links in forumhome with this mod.
Any way to get a non-Ajaxed version showing up for spiders and visitors without Javascript enabled??

try top run this link:
http://www.smnlikdat.org/forum.php

in these tools:
http://www.seochat.com/seo-tools/spider-simulator/
http://www.webconfs.com/search-engine-spider-simulator.php

abdobasha2004
12-04-2008, 08:48 AM
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3729) : eval()'d code on line 1

؟؟؟؟

abdobasha2004
12-04-2008, 08:55 AM
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

when open forum index
plz help

AWJunkies
12-04-2008, 09:20 AM
when open forum index
plz help

That it cause of the if statement. Revert and take out the if statement and all will be fine.

abdobasha2004
12-04-2008, 09:27 AM
I just noticed that as well the forums spacing is gone it is all smooshed together. testing on 5 different styles FYI

It has to do with if statement:
<if condition="(THIS_SCRIPT == 'indexTAB' AND in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all',$GLOBALS[tabcats])) OR THIS_SCRIPT == 'forumdisplay'">

if you make it:
<if condition="(THIS_SCRIPT == 'indexTAB' AND in_array($forum['forumid'], $GLOBALS[tabcats]))">

this solved all my problems
:)thanx

but how to edit colors of tabs?

AWJunkies
12-04-2008, 09:31 AM
IE error:
Webpage Script Errors

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322; .NET CLR 2.0.50727)
Timestamp: Thu, 4 Dec 2008 11:31:10 UTC


Message: Dispacher: Script Execution Error ([object Error])
Line: 247
Char: 3
Code: 0
URI: http://www.yourdomain.com/clientscript/yui/tabview/dispatcher.js

abdobasha2004
12-04-2008, 09:34 AM
another 2 problems

1- No number of visitors viewing each forum
2- Not crawlable by search engines !

Morsolo
12-04-2008, 09:38 AM
this solved all my problems
:)thanx

but how to edit colors of tabs?

That didn't solve my problems :(

To edit the tab colours go to your clientscript/yui/tabview/assets folder and edit the skin-tfh.css file.

AWJunkies
12-04-2008, 10:33 AM
Ok guys I have a fix works perfect now modules and if statement all fixed etc one sec will post it all.

ArnyVee
12-04-2008, 10:39 AM
Ooo....share with us AWJunkies! :D

AWJunkies
12-04-2008, 11:00 AM
HERE IS A FIX ENJOY

Step #1
Ok do not or revert whatever patch king posted on his link to his site the trying of passing variable to template which you can not do in this case and circumstances. Basically you should have everything installed how they said to do and the files in zip without changing a thing.

Step #2
Now the correct IF statement to enter is below. So change the if statement they have and where to add it to the below one.

NEW CORRECT IF STATEMENT:

<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum['forumid'], $_REQUEST['tabcat']) OR in_array('all', $_REQUEST['tabcat']))) OR (THIS_SCRIPT == 'forumdisplay')">


Step #3
Fix for All forums module: For some reason they put -1 instead of all for the tabcat value. So to fix is real easy. There was no check within IF statement for -1 but there was for all.

Module File info BEFORE:

tabindex.php?tabcat[]=-1

Module File info AFTER:

tabindex.php?tabcat[]=all


Step #4
Fix for data arrays within modules must be URL strict not safe.

Example before:

tabindex.php?tabcat[]=1&amp;amp;tabcat[]=47&amp;amp;tabcat[]=58&amp;amp;tabcat[]=70&amp;amp;tabcat[]=78&amp;amp;langid=1

Example after:

tabindex.php?tabcat[]=1&tabcat[]=47&tabcat[]=58&tabcat[]=70&tabcat[]=78&langid=1


OPEN:
tfh_modules.php (admincp file)

FIND TWO INSTANCES OF:

'file' => TYPE_NOHTML,

REPLACE WITH:

'file' => TYPE_HTML,


Step #5 (OPTIONAL)
Also highly recommended for up to date YUI libraries and much quicker load and single batch calls follow the below instructions. Basically replace the add js code into header that is posted in instructions with the below.

FORUM HOME TEMPLATE CHANGE:

<!-- Tabbed Forum Home Header Code -->
<!-- Dependencies -->
<!-- TFH Skin CSS for TabView -->
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/tabview.css" />
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/skin-tfh.css" />

<!-- JavaScript Dependencies for Tabview: -->
<script type="text/javascript" src="clientscript/yui/utilities/utilities.js"></script>
<script type="text/javascript" src="clientscript/yui/element/element-beta-min.js"></script>

<!-- Source file for TabView -->
<script type="text/javascript" src="clientscript/yui/tabview/tabview-min.js"></script>

<!-- Source file for Dispatcher -->
<script type="text/javascript" src="clientscript/yui/tabview/dispatcher.js"></script>

<!-- /Tabbed Forum Home Header Code -->



REPLACE WITH:

<!-- Tabbed Forum Home Header Code -->
<!-- Dependencies -->
<!-- TFH Skin CSS for TabView -->
<link rel="stylesheet" type="text/css" href="http://yui.yahooapis.com/2.6.0/build/tabview/assets/skins/sam/tabview.css">
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/skin-tfh.css" />

<script type="text/javascript" src="http://yui.yahooapis.com/combo?2.6.0/build/utilities/utilities.js&2.6.0/build/element/element-beta-min.js&2.6.0/build/tabview/tabview-min.js"></script>

<!-- Source file for Dispatcher -->
<script type="text/javascript" src="clientscript/yui/tabview/dispatcher.js"></script>

<!-- /Tabbed Forum Home Header Code -->


HERE IS A FIX ENJOY

sweetguy2004
12-04-2008, 11:02 AM
1- No number of visitors viewing each forum
2- Not crawlable by search engines !

when this problem will be solved this things are important but before this i will have to install it on my forum m also getting this error

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

AWJunkies
12-04-2008, 11:10 AM
1- No number of visitors viewing each forum
2- Not crawlable by search engines !

when this problem will be solved this things are important but before this i will have to install it on my forum m also getting this error

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Try the fixes I posted above your post

sweetguy2004
12-04-2008, 11:12 AM
but if i remove if statement will this mod will work?

also i want to know which tab vb.org useis it ajax or simple
& it there any tabb mod which is stable have
1- No number of visitors viewing each forum
2- Not crawlable by search engines !

SteamyLightning
12-04-2008, 12:59 PM
but if i remove if statement will this mod will work?

also i want to know which tab vb.org useis it ajax or simple
& it there any tabb mod which is stable have
1- No number of visitors viewing each forum
2- Not crawlable by search engines !
You're not removing the if statement. You're amending the if statement with one that contains parentheses.

And yes, the no number of visitors for each forum is something that they should look into. I reported that bug back in 1.5.

AWJunkies
12-04-2008, 01:01 PM
You're not removing the if statement. You're amending the if statement with one that contains parentheses.

And yes, the no number of visitors for each forum is something that they should look into. I reported that bug back in 1.5.

Just want to make CLEAR MY IF STATEMENT IS COMPLETELY DIFFERENT. So please look at it and read that post.

sweetguy2004
12-04-2008, 01:10 PM
Just want to make CLEAR MY IF STATEMENT IS COMPLETELY DIFFERENT. So please look at it and read that post.

Thanks junkies atleast its work fine i was trying it from 6 months good work

lowey
12-04-2008, 02:32 PM
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3729) : eval()'d code on line 1
when I save the two templates

and still the error in the tabs:
Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Still the same here after applying the fix. :(

murekhalir
12-04-2008, 03:55 PM
Are you guys sure this is the correct insturctions?

when i put this code in lvl1 nopost i get an error.



Template: forumhome_forumbit_level1_nopost, forumhome_forumbit_level1_post

Add this code to the beginning of the template:
HTML Code:

<if condition="(THIS_SCRIPT == 'indexTAB' AND in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all',$GLOBALS[tabcats])) OR THIS_SCRIPT == 'forumdisplay'">

GeekStep
12-04-2008, 04:06 PM
I get this error aswell :S

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3763) : eval()'d code on line 1

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

Hugo Holbling
12-04-2008, 05:24 PM
Maybe I'm missing something but is it possible to edit the display order of the tabs? At the moment they are displaying in the order I created them, followed by the enabled modules; ideally "All Forums" would be first and the display orders could be changed.

rob01
12-04-2008, 05:33 PM
hello i have a question, i apply the fixes and all is working well , but if i click over a tab i wont be able to see the forum the tab is calling any idea?

sweetguy2004
12-04-2008, 05:44 PM
This things are not working on it any solution?

forumhome_forumbit_level2_post [Custom Style]

<div class="forum_info">
$vbphrase[posts]: $forum[replycount] |
$vbphrase[threads]: $forum[threadcount]
<if condition="$show['browsers']"><span class="smallfont">| <phrase 1="$forum[browsers]">$vbphrase[x_viewing]</phrase></span></if>
</div>

& in my forum it looks like this

https://vborg.vbsupport.ru/external/2008/12/100.jpg

from where to edit this templates

King Kovifor
12-04-2008, 06:18 PM
I can confirm I have display errors turned on in php.ini, however an error still occurs when submitting the edited template... as others have said the fix isn't working, though with s810car's modified conditional

<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum['forumid'], $GLOBALS[tabcats]) OR in_array('all', $GLOBALS[tabcats]))) OR (THIS_SCRIPT == 'forumdisplay')">
no errors. The parenthesis are what made it work, the quotes around forumid didn't make a difference. The All Forums module still won't display, though that may just be an error on my end since I haven't heard anyone else mention that.

If you can confirm this works, I will make the change now.

HERE IS A FIX ENJOY

Step #1
Ok do not or revert whatever patch king posted on his link to his site the trying of passing variable to template which you can not do in this case and circumstances. Basically you should have everything installed how they said to do and the files in zip without changing a thing.

Step #2
Now the correct IF statement to enter is below. So change the if statement they have and where to add it to the below one.

NEW CORRECT IF STATEMENT:

<if condition="(THIS_SCRIPT == 'indexTAB' AND (in_array($forum['forumid'], $_REQUEST['tabcat']) OR in_array('all', $_REQUEST['tabcat']))) OR (THIS_SCRIPT == 'forumdisplay')">


Step #3
Fix for All forums module: For some reason they put -1 instead of all for the tabcat value. So to fix is real easy. There was no check within IF statement for -1 but there was for all.

Module File info BEFORE:

tabindex.php?tabcat[]=-1

Module File info AFTER:

tabindex.php?tabcat[]=all


Step #4
Fix for data arrays within modules must be URL strict not safe.

Example before:

tabindex.php?tabcat[]=1&amp;amp;tabcat[]=47&amp;amp;tabcat[]=58&amp;amp;tabcat[]=70&amp;amp;tabcat[]=78&amp;amp;langid=1

Example after:

tabindex.php?tabcat[]=1&tabcat[]=47&tabcat[]=58&tabcat[]=70&tabcat[]=78&langid=1


OPEN:
tfh_modules.php (admincp file)

FIND TWO INSTANCES OF:

'file' => TYPE_NOHTML,

REPLACE WITH:

'file' => TYPE_HTML,


Step #5 (OPTIONAL)
Also highly recommended for up to date YUI libraries and much quicker load and single batch calls follow the below instructions. Basically replace the add js code into header that is posted in instructions with the below.

FORUM HOME TEMPLATE CHANGE:

<!-- Tabbed Forum Home Header Code -->
<!-- Dependencies -->
<!-- TFH Skin CSS for TabView -->
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/tabview.css" />
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/skin-tfh.css" />

<!-- JavaScript Dependencies for Tabview: -->
<script type="text/javascript" src="clientscript/yui/utilities/utilities.js"></script>
<script type="text/javascript" src="clientscript/yui/element/element-beta-min.js"></script>

<!-- Source file for TabView -->
<script type="text/javascript" src="clientscript/yui/tabview/tabview-min.js"></script>

<!-- Source file for Dispatcher -->
<script type="text/javascript" src="clientscript/yui/tabview/dispatcher.js"></script>

<!-- /Tabbed Forum Home Header Code -->



REPLACE WITH:

<!-- Tabbed Forum Home Header Code -->
<!-- Dependencies -->
<!-- TFH Skin CSS for TabView -->
<link rel="stylesheet" type="text/css" href="http://yui.yahooapis.com/2.6.0/build/tabview/assets/skins/sam/tabview.css">
<link rel="stylesheet" type="text/css" href="clientscript/yui/tabview/assets/skin-tfh.css" />

<script type="text/javascript" src="http://yui.yahooapis.com/combo?2.6.0/build/utilities/utilities.js&2.6.0/build/element/element-beta-min.js&2.6.0/build/tabview/tabview-min.js"></script>

<!-- Source file for Dispatcher -->
<script type="text/javascript" src="clientscript/yui/tabview/dispatcher.js"></script>

<!-- /Tabbed Forum Home Header Code -->


HERE IS A FIX ENJOY

Thanks, after a quick look, they all seem to be correct coding. The 'all' was fixed in the module, but the install codes I wrote before the fix wasn't changed. I am going to make the change now. Upgrade to 2.6.0 for YUI was planned for 2.0.0 Beta 2.

but if i remove if statement will this mod will work?

also i want to know which tab vb.org useis it ajax or simple
& it there any tabb mod which is stable have
1- No number of visitors viewing each forum
2- Not crawlable by search engines !

vBulletin.org does not use TFH - theirs are custom.

Maybe I'm missing something but is it possible to edit the display order of the tabs? At the moment they are displaying in the order I created them, followed by the enabled modules; ideally "All Forums" would be first and the display orders could be changed.

This is a planned feature for beta 2 or 3.

sweetguy2004
12-04-2008, 06:42 PM
Hi King well u got my pm, I have almost installed it but have some problems can you please reply to my last post. Thanks

rob01
12-04-2008, 07:08 PM
how i make the forums to get displayed? :S all seems to work fine, but the tabs dosnt display nothing

any idea?

:S

AWJunkies
12-04-2008, 07:51 PM
Everyone who is having issues STOP looking through thread and trying to fix the mod through all the posts with 10 different IF statements and solutions they all DO NOT WORK. Please update thread as soon as you can king and others look here:

https://vborg.vbsupport.ru/showpost.php?p=1678366&postcount=102

Hugo Holbling
12-04-2008, 08:02 PM
The fix in post 102 worked great for me and I look forward to seeing the next beta release. :)

For rob01, one thing to note is that in order to make the tabs display forums, I had to use the category id rather than the forum id; the former displayed fine but the latter gave a tab with only the thead and tfoot of the main forum content.

rob01
12-04-2008, 08:28 PM
it works in IE (sometimes), for a certain time and then it dosnt work again :S , but in firefox it dosnt work , i think is firefox the one causing the erros and the projects tools dosnt seem to work either :(

and if you click the tabs .. they seem to stop working

:S

my site is tustan.net :S

King Kovifor
12-04-2008, 08:53 PM
Everyone who is having issues STOP looking through thread and trying to fix the mod through all the posts with 10 different IF statements and solutions they all DO NOT WORK. Please update thread as soon as you can king and others look here:

https://vborg.vbsupport.ru/showpost.php?p=1678366&postcount=102

I've got a viewing tonight and tomorrow, so I probably won't get around to being able to spend time updating this until Saturday.

AWJunkies
12-04-2008, 09:18 PM
Not a problem just wanted to notify users so they don't keep talking about and repeating the same non fix stuff when there is a fix.

Also remember you DO have issue with IE and the js file I posted few posts back. I can't fix that one it has to do with your code directly and not the js itself.

rob01
12-04-2008, 11:40 PM
Not a problem just wanted to notify users so they don't keep talking about and repeating the same non fix stuff when there is a fix.

Also remember you DO have issue with IE and the js file I posted few posts back. I can't fix that one it has to do with your code directly and not the js itself.

yeah it seems to work now, but it just work in IE right?


other question how you fix the forumhome space? , lets say if you click over all forums, the website will expand so it could show all forums , but if you show other, the website size will remain as biger as before (when you click all forums) right?

King Kovifor
12-05-2008, 12:50 AM
Not a problem just wanted to notify users so they don't keep talking about and repeating the same non fix stuff when there is a fix.

Also remember you DO have issue with IE and the js file I posted few posts back. I can't fix that one it has to do with your code directly and not the js itself.

I must have missed that, would mind reminding me of the problem (coming home to 3 pages of new posts is easy to miss a few posts...) or just link me to the post and I can look into fixing it.

AWJunkies
12-05-2008, 03:50 AM
I must have missed that, would mind reminding me of the problem (coming home to 3 pages of new posts is easy to miss a few posts...) or just link me to the post and I can look into fixing it.

https://vborg.vbsupport.ru/showpost.php?p=1678336&postcount=97

Post # 97

It does NOT effect it loading and working in IE but does throw error. Presume your caching of forums wont work cause it uses this.

Also this mod does not work with:
Spider Display 1.0.0

Working on fix as I need this. Will have one soon and the space between forums.

I see a temp fix for some styles not showing the spacing between forums as the:
<div class="spacer"></div>

Is not creating the space and a <br /> is needed.

So in forumhome_forumbit_level1_nopost:
in the instructions it says to add a </if> at the end you need to add a <br /> as well

<br />
<div class="spacer"></div>
</if>

or

<br />
</if>

murekhalir
12-05-2008, 05:10 AM
All you do is follow directions it tells you within there mod and 0 issues tells you exactly what to do go to those to plugins in CYB mod and add the OR statement. Works perfect.

My issue I am having is the tabs are not showing JUST X forum id but showing ALL no matter what I do which is very strange. I went back to full your js everything and same issue so has nothing to do with my doing different js calls.

Anyone else getting this issue? No errors just shows all forums no matter what Id's I put. I followed pictures to the T as examples still no go.




forgive me for my ignorance...

if i got this error:

Plugins (Search In): Cyb - Sub-Forum Manager - CT and Cyb - Sub-Forum Manager 1
Find:
(THIS_SCRIPT=='index' OR THIS_SCRIPT=='forumdisplay'))
Replace With:
(THIS_SCRIPT=='index' OR THIS_SCRIPT=='forumdisplay' OR THIS_SCRIPT=='indexTAB'))




Where would i go and look to modify the plugins?

s810car
12-05-2008, 05:18 AM
dang my server going through a move and I wanted to try some more today, gonna try the fix posted asap and comment

Morsolo
12-05-2008, 07:42 AM
I am amazed to see how long this took and how much work you guys put in to this, but the amount it simply doesn't work...

I have stumbled upon a rather large bug, common navbar templates like this:
<!-- network locator -->
<div class="vbmenu_popup" id="networklocator_menu" style="display:none" align="$stylevar[left]">
<table width="200px" cellpadding="4" cellspacing="1" border="0">
<tr><td class="thead">Main</td></tr>
<tr><td class="vbmenu_option"><a href="http://www.m-network.net/index.php">Homepage</a></td></tr>
<tr><td class="vbmenu_option"><a href="http://www.m-network.net/forum/index.php">Forum</a></td></tr>
<tr><td class="thead">Locations</td></tr>
<tr><td class="vbmenu_option"><a href="">Coming Soon...</a></td></tr>
</table>
</div>
<!-- / network locator -->
Creates dropdown menu for use within the navbar or header when this is called:
<td id="networklocator" width="78" height="34" class="css_nav"><a href="$show[nojs_link]#networklocator">.Network</a> <script type="text/javascript"> vbmenu_register("networklocator", 1); </script></td>
All these drop downs, custom and default, do not work now, does anyone else get this problem? I am 100% sure it is this mod and they were working, I installed this and they weren't...

EDIT:
I've just received numerous complaints that this mod is breaking anything and everything Javascript, the WWYSIG Editor is broken to now.

Aren
12-05-2008, 08:52 AM
EDIT:
I've just received numerous complaints that this mod is breaking anything and everything Javascript, the WWYSIG Editor is broken to now.

I've tried both on FF and IE and the WYSIWYG editor is working fine, both in quick reply and in advanced reply mode.

SteamyLightning
12-05-2008, 09:22 AM
forgive me for my ignorance...

Where would i go and look to modify the plugins?

Go to the Plugin Manager, scroll down to Cyb - Subforum Manager, and then edit the Cyb - "Sub-Forum Manager - CT" and "Cyb - Sub-Forum Manager 1" templates.

AWJunkies
12-05-2008, 11:28 AM
*Fixed issue*
Product : Spider Display
Plugin: Forum Home Complete

Find (first line):
if (($vbulletin->options['displayloggedin'] == 1 OR $vbulletin->options['displayloggedin'] == 2 OR ($vbulletin->options['displayloggedin'] > 2 AND $vbulletin->userinfo['userid'])) AND !$show['search_engine'])

Replace with (added another conditional):
if (($vbulletin->options['displayloggedin'] == 1 OR $vbulletin->options['displayloggedin'] == 2 OR ($vbulletin->options['displayloggedin'] > 2 AND $vbulletin->userinfo['userid'])) AND !$show['search_engine'] AND THIS_SCRIPT!='indexTAB')

So may want to add this to your search for conflicting mods searcher thing.
*Fixed issue*

AWJunkies
12-05-2008, 11:33 AM
another 2 problems

1- No number of visitors viewing each forum
2- Not crawlable by search engines !

I am watching my crawlers google and yahoo right now on other tabs so they are able to view the tabs. I have english tab and a french tab so there is no other way to see those forums other then clicking or them viewing the tabs themself. No way for them to have direct links to them either. I just created them :) .

So please some other people confirm this for me as it is working for me.

SteamyLightning
12-05-2008, 01:09 PM
*Fixed issue*
Product : Spider Display
Plugin: Forum Home Complete

Find (first line):
if (($vbulletin->options['displayloggedin'] == 1 OR $vbulletin->options['displayloggedin'] == 2 OR ($vbulletin->options['displayloggedin'] > 2 AND $vbulletin->userinfo['userid'])) AND !$show['search_engine'])

Replace with (added another conditional):
if (($vbulletin->options['displayloggedin'] == 1 OR $vbulletin->options['displayloggedin'] == 2 OR ($vbulletin->options['displayloggedin'] > 2 AND $vbulletin->userinfo['userid'])) AND !$show['search_engine'] AND THIS_SCRIPT!='indexTAB')

So may want to add this to your search for conflicting mods searcher thing.
*Fixed issue*
I don't think this is the bug/omission that he was referring to. It's certainly not the one that I'm referring to. It's actually the default vBulletin feature that allows you to see how many people are browsing a forum from the forumhome. For example...

Main Forum (2 viewing)

The "(2 viewing)" part doesn't show up on the tabs, and it would be nice if that was fixed.

bobster65
12-05-2008, 01:47 PM
I don't think this is the bug/omission that he was referring to. It's certainly not the one that I'm referring to. It's actually the default vBulletin feature that allows you to see how many people are browsing a forum from the forumhome. For example...

Main Forum (2 viewing)

The "(2 viewing)" part doesn't show up on the tabs, and it would be nice if that was fixed.

That is one thing I am trying to figure out myself. Its working fine on all 6 of my Dev Servers and 2 of my production servers... Not sure yet why its not working for others...

ArnyVee
12-05-2008, 02:52 PM
Well, I'm going to wait it out a few more days until the majority of the bugs are ironed out. But, I'm DEFINITELY all over this one as soon as it's more stable!

Thanks to everyone pitching in and trying to find solutions to some of the issues out there! :D

Bram H
12-05-2008, 06:16 PM
If somebody has a working demo out, could that be posted here?

King Kovifor
12-05-2008, 06:45 PM
I am amazed to see how long this took and how much work you guys put in to this, but the amount it simply doesn't work...

I have stumbled upon a rather large bug, common navbar templates like this:
<!-- network locator -->
<div class="vbmenu_popup" id="networklocator_menu" style="display:none" align="$stylevar[left]">
<table width="200px" cellpadding="4" cellspacing="1" border="0">
<tr><td class="thead">Main</td></tr>
<tr><td class="vbmenu_option"><a href="http://www.m-network.net/index.php">Homepage</a></td></tr>
<tr><td class="vbmenu_option"><a href="http://www.m-network.net/forum/index.php">Forum</a></td></tr>
<tr><td class="thead">Locations</td></tr>
<tr><td class="vbmenu_option"><a href="">Coming Soon...</a></td></tr>
</table>
</div>
<!-- / network locator -->
Creates dropdown menu for use within the navbar or header when this is called:
<td id="networklocator" width="78" height="34" class="css_nav"><a href="$show[nojs_link]#networklocator">.Network</a> <script type="text/javascript"> vbmenu_register("networklocator", 1); </script></td>
All these drop downs, custom and default, do not work now, does anyone else get this problem? I am 100% sure it is this mod and they were working, I installed this and they weren't...

EDIT:
I've just received numerous complaints that this mod is breaking anything and everything Javascript, the WWYSIG Editor is broken to now.

Working with the exact copy that was sent here, we have all JavaScript features working.

King Kovifor
12-05-2008, 06:46 PM
If somebody has a working demo out, could that be posted here?

There is one at SmnLikDat.org.

King Kovifor
12-05-2008, 06:47 PM
https://vborg.vbsupport.ru/showpost.php?p=1678336&postcount=97

Post # 97

It does NOT effect it loading and working in IE but does throw error. Presume your caching of forums wont work cause it uses this.

Also this mod does not work with:
Spider Display 1.0.0

Working on fix as I need this. Will have one soon and the space between forums.

I see a temp fix for some styles not showing the spacing between forums as the:
<div class="spacer"></div>

Is not creating the space and a <br /> is needed.

So in forumhome_forumbit_level1_nopost:
in the instructions it says to add a </if> at the end you need to add a <br /> as well

<br />
<div class="spacer"></div>
</if>

or

<br />
</if>

The problem in dispatcher.js isn't actually our code.

AWJunkies
12-05-2008, 07:17 PM
The problem in dispatcher.js isn't actually our code.

I know it is not I will fix it for you. I am out all day today but have solution tomorrow.

Here is the site working on so people can see it in action as another reference.
Forum Coding (http://www.forumcoding.com/)

Noticed for some reason the Spiders hack goes to negative guests sometimes so here is solution.
Just adding a conditional to it.

Same plugin as other post
FIND:

$numberguest = $numberguest - $nspiders;
$vbphrase['x_members_and_y_guests'] .= ' and '.$nspiders.' Spiders';

REPLACE:
$numberguest = $numberguest - $nspiders;
if ($numberguest<0){$numberguest=0;}
$vbphrase['x_members_and_y_guests'] .= ' and '.$nspiders.' Spiders';

King Kovifor
12-05-2008, 07:21 PM
I know it is not I will fix it for you. I am out all day today but have solution tomorrow.

You really don't need to go around fixing all our mistakes, but we appreciate it. I can report it to the original authors and attempt for a fix, but the JavaScript talent in my brain is far inferior to the PHP talent.

AWJunkies
12-05-2008, 07:45 PM
You really don't need to go around fixing all our mistakes, but we appreciate it. I can report it to the original authors and attempt for a fix, but the JavaScript talent in my brain is far inferior to the PHP talent.

I am an expert so not a big deal and I need the mod and it working correctly for my sites so to share is no big deal to me. Second it is not the js file issue it is code itself will explain when I show you fix. Well I am out for rest of today will post up tomorrow have a nice day everyone.

King Kovifor
12-05-2008, 07:53 PM
I am an expert so not a big deal and I need the mod and it working correctly for my sites so to share is no big deal to me. Second it is not the js file issue it is code itself will explain when I show you fix. Well I am out for rest of today will post up tomorrow have a nice day everyone.

Understood.

Morsolo
12-05-2008, 10:11 PM
Ok guys, I just downloaded vBulletin 3.8.0.RC1 and I just completely replaced everything in the clientscript directory and now the javascript stuff works.
I don't know why this is, because I never even touched that directory except for the Tab Modification upload and no one else has permissions to my FTP...

Either way, the mod still doesn't work...

Aakek
12-05-2008, 10:13 PM
Any plans on being able to reorder tabs?

rob01
12-05-2008, 10:29 PM
AWJunkies where is all this modifications located? :S

this ->
Same plugin as other post
FIND:
Code:

$numberguest = $numberguest - $nspiders;
$vbphrase['x_members_and_y_guests'] .= ' and '.$nspiders.' Spiders';

REPLACE:
Code:

$numberguest = $numberguest - $nspiders;
if ($numberguest<0){$numberguest=0;}
$vbphrase['x_members_and_y_guests'] .= ' and '.$nspiders.' Spiders

King Kovifor
12-06-2008, 12:36 AM
Ok guys, I just downloaded vBulletin 3.8.0.RC1 and I just completely replaced everything in the clientscript directory and now the javascript stuff works.
I don't know why this is, because I never even touched that directory except for the Tab Modification upload and no one else has permissions to my FTP...

Either way, the mod still doesn't work...

You need to explain your problems if you would like us to help or fix them.

Any plans on being able to reorder tabs?

That is a planned feature for either b2 or b3.

Morsolo
12-06-2008, 02:13 AM
If you bothered to read my post on the last page, I did explain my problems...

QFT: lolnoob
Yes, for some reason, the Encoding Error just vanished and now I can view the forums, but I am getting that issue.
It isn't showing "X" Forums, it is showing all of them. And I am getting no spacing between each category, for example it should look like:
CATEGORY
-- FORUM

CATEGORY
-- FORUM
But it is going:
CATEGORY
-- FORUM
CATEGORY
-- FORUM

King Kovifor
12-06-2008, 02:26 AM
If you bothered to read my post on the last page, I did explain my problems...

QFT: lolnoob

I'll give you a link that was posted maybe 4 or 5 posts after yours (maybe more):

https://vborg.vbsupport.ru/showpost.php?p=1678366&postcount=102

hotwheels
12-06-2008, 02:37 AM
So you are using this newer version awjunkines? I tried this with the other ajax version and it still doesn't work correctly.....I know it is not I will fix it for you. I am out all day today but have solution tomorrow.

Here is the site working on so people can see it in action as another reference.
Forum Coding (http://www.forumcoding.com/)

Noticed for some reason the Spiders hack goes to negative guests sometimes so here is solution.
Just adding a conditional to it.

Same plugin as other post
FIND:

$numberguest = $numberguest - $nspiders;
$vbphrase['x_members_and_y_guests'] .= ' and '.$nspiders.' Spiders';

REPLACE:
$numberguest = $numberguest - $nspiders;
if ($numberguest<0){$numberguest=0;}
$vbphrase['x_members_and_y_guests'] .= ' and '.$nspiders.' Spiders';

Morsolo
12-06-2008, 02:45 AM
I'll give you a link that was posted maybe 4 or 5 posts after yours (maybe more):

https://vborg.vbsupport.ru/showpost.php?p=1678366&postcount=102

Hence what I have been saying, it still doesn't work!

Mesohu
12-06-2008, 07:22 AM
When you will release a fixed version of YUI Tabbed Forum Home ?

AWJunkies
12-06-2008, 10:30 AM
AWJunkies where is all this modifications located? :S

this ->
Same plugin as other post
FIND:
Code:

$numberguest = $numberguest - $nspiders;
$vbphrase['x_members_and_y_guests'] .= ' and '.$nspiders.' Spiders';

REPLACE:
Code:

$numberguest = $numberguest - $nspiders;
if ($numberguest<0){$numberguest=0;}
$vbphrase['x_members_and_y_guests'] .= ' and '.$nspiders.' Spiders

That is a Spiders Display mod on this site (vB org) both this mod and other together was killing the tabs so had to get a solution fast to it. So the above is a fix for it.

AWJunkies
12-06-2008, 10:31 AM
So you are using this newer version awjunkines? I tried this with the other ajax version and it still doesn't work correctly.....

I have not messed with old 1.5 ajax tabs. Just this one which is tabs 2.0 YUI

AWJunkies
12-06-2008, 10:33 AM
If you bothered to read my post on the last page, I did explain my problems...

QFT: lolnoob

I already posted a solution for you:

I see a temp fix for some styles not showing the spacing between forums as the:
<div class="spacer"></div>

Is not creating the space and a <br /> is needed.

So in forumhome_forumbit_level1_nopost:
in the instructions it says to add a </if> at the end you need to add a <br /> as well

<br />
<div class="spacer"></div>
</if>

or

<br />
</if>

was a few pages back :)

AWJunkies
12-06-2008, 10:34 AM
Hence what I have been saying, it still doesn't work!

It does work :) So didn't follow my fix completely and standard instructions.

Please state exact issue so I can help you. Just saying it doesn't work doesn't help us find root of issue.

Forum Lover
12-06-2008, 10:57 AM
Is it ok now? Cause newbie like me wanna give a try to install it in my board. :p I'll try follow the instructions. Thats it, right?

Big Barry
12-06-2008, 01:14 PM
Don't know if this is just me or what but when I put the IF condition around forumhome_forumbit_level1_nopost, forumhome_forumbit_level1_post I was getting these errors:

forumhome_forumbit_level1_nopost

The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3772) : eval()'d code on line 1

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

forumhome_forumbit_level1_post
The following error occurred when attempting to evaluate this template:

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/adminfunctions_template.php(3772) : eval()'d code on line 1

This is likely caused by a malformed conditional statement. It is highly recommended that you fix this error before continuing, but you may continue as-is if you wish.

and then above the forum, this appears:


Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Warning: in_array() [function.in-array]: Wrong datatype for second argument in [path]/includes/functions_forumlist.php(395) : eval()'d code on line 1

Any ideas?

Many thanks

Big Barry
12-06-2008, 01:50 PM
I just used the search function and found it :D Many thanks for this mod and to AWJunkies for the fix :D

ArnyVee
12-06-2008, 01:51 PM
Big Barry, as you noticed, the temporary fix is on page 7 post #102 :D

Edited: Noticed you posted as I was posting. But, I put the info for those looking for the temporary fix.

MarsNIIT
12-06-2008, 03:46 PM
Can i use this mod with Forum Display???

I have sub forum with orther style, i need this mod use with Forum Display.

Thanks.

King Kovifor
12-06-2008, 05:47 PM
Can i use this mod with Forum Display???

I have sub forum with orther style, i need this mod use with Forum Display.

Thanks.

This mod is designed for the forum home.

King Kovifor
12-06-2008, 06:50 PM
Morsolo, I happened to check your site (to see these JS errors) and am delighted to have found that closed message. But this one stuck me as false:

We have made this decision for numerous reasons, the top of which is possible exploits and security vulnerabilities.

If we have any security vulnerabilities, please report them as private issues in our tracker as soon as possible - this way we can get it fixed as soon as possible.

bobster65
12-06-2008, 09:07 PM
Please remember this is BETA 1 and not to install on a production site. We released the beta version for members to mess around with.

Beta 2 will not be released here. From now on, all Beta releases will be available only at smnlikdat.org to those that belong to the beta testing group.

The next release here will have been through multiple beta and RC phases tested by members..

Morsolo
12-06-2008, 09:40 PM
Morsolo, I happened to check your site (to see these JS errors) and am delighted to have found that closed message. But this one stuck me as false:

We have made this decision for numerous reasons, the top of which is possible exploits and security vulnerabilities.

If we have any security vulnerabilities, please report them as private issues in our tracker as soon as possible - this way we can get it fixed as soon as possible.

As it states, "...numerous reasons..." my mate - who is a bit of a hack - forever tells me that jS is easily exploitable, so as a safety measure I closed it off.
I fixed up all the Java errors by re-uploading the /clientscripts/ directory as I said earlier, and I have since re-opened the forum.
And I'm happy you went and visited, it was probably the most traffic the site got all day :)

Please remember this is BETA 1 and not to install on a production site. We released the beta version for members to mess around with.

Beta 2 will not be released here. From now on, all Beta releases will be available only at smnlikdat.org to those that belong to the beta testing group.

The next release here will have been through multiple beta and RC phases tested by members..

*Raises Eyebrow*

...'Nuff said.