PDA

View Full Version : New Posting Features - QHSF Private Thread


Moya
08-12-2008, 10:00 PM
Private Threads

This hack has been ported to vBulletin 3.7.2 from the vBulletin 3.5.4 version with permission granted by:

Hi Eikinskjaldi,

Are you going to release this for 3.7.x? I have it works under 3.7.x. If you don't plan to release it, can I release it?
Hi there,

Feel free to release it :)

This hack starts from this thread Completely Private Thread (https://vborg.vbsupport.ru/showthread.php?t=62037&highlight=private+threads) and this thread vBPrivate Thread (https://vborg.vbsupport.ru/showthread.php?t=109096)

This private thread mod allow administrators allow a certain forum to have this feature on or off.

With this modification members can create threads that are useful for private conversations. Here are the basic options
Allow Selected Users To View and Prevent Others from viewing.
Allow Selected Usergroup To View and Prevent Others from viewing.
Prevent Selected Users From viewing.Hack Overview:
Products: 1
2 Queries
15 Phrases
More than 15 Plugins :D
File Edits: 1
File Uploaded: 2
Template Added: 4
Estimated Install time: Under 5 minutesvbadvanced cmps support: (3.0.x)

Block Content From Private Thread From Displaying In News Module
Block Content From Private Thread From Previewing In Recent Thread ModuleNote : To make the message of a private thread less offensive, I use the invalid thread link

Install Instruction:

Upload :
functions_privatethread.php to your includes folder
hooks_privatethread.xml to your includes/xml folder Edit :
Open archive/index.phpFind

else
{
$globalignore = '';
}

add under



($hook = vBulletinHook::fetch_hook('privatethread_archivein dex')) ? eval($hook) : false;
Install the product using your Plugin & Products System
Edit your forum information to turn private thread option on/off

Bug Fixed :

VBPhrase Tranlation:



Please post your comments, suggestions, ideas for this product. I will read all posts.

Make sure you click INSTALL (https://vborg.vbsupport.ru/vborg_miscactions.php?do=installhack&threadid=187992)!
You will be contacted when a new version is released.

Moya
08-13-2008, 05:49 AM
Reserved for future information / planned features

RedeemedWarrior
08-13-2008, 05:54 AM
this sounds good :D

where are the files ;)

Moya
08-13-2008, 05:59 AM
:D I am a slow snail :D. I haven't work with releasing mod for awhile :D

Vegetrunks
08-13-2008, 07:03 AM
Good, I will try it.

KURTZ
08-13-2008, 10:08 AM
2 questions:

1) admins and mods are affected by this hack?
2) the name of the usergroups must be write only by name or also by the ID?

thx

*tagged

Barakat
08-13-2008, 12:00 PM
so long moya ..... thanks

Moya
08-13-2008, 02:25 PM
Kurtz,

1) Currently, this mod is set to allow Admins the privilege, not mods
2) It uses the usergroup title

xorex
08-13-2008, 04:11 PM
Help ! :eek:



Warning: include_once(./includes/functions_privatethread.php) [function.include-once]: failed to open stream: No such file or directory in [path]\forumdisplay.php(955) : eval()'d code on line 187

Warning: include_once() [function.include]: Failed opening './includes/functions_privatethread.php' for inclusion (include_path='.;C:\1\php\pear\') in [path]\forumdisplay.php(955) : eval()'d code on line 187

Fatal error: Call to undefined function private_thread_not_allowed() in C:*****\forumdisplay.php(955) : eval()'d code on line 188

Moya
08-13-2008, 04:15 PM
Hi xorex,

Did you upload the file called function_privatethread.php to your includes directory?

xorex
08-13-2008, 04:26 PM
HI Moya

Ooops !! :D upload functions_privatethread.php in forum root and it work fine :)

Thanx work fine @! :up::up:

+ russian translate attached update first post please ! ;)

Moya
08-13-2008, 04:39 PM
I can't upload anymore. The system is saying that I have reached maximum 10 files

xorex
08-13-2008, 04:43 PM
...... i have error in thread of forum where this hack disabled



Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in C:\******\showthread.php(2157) : eval()'d code on line 377



ideas ?

Moya
08-13-2008, 04:46 PM
Hmmm I don't have that error on my site. I will check it again tonight.

xorex
08-13-2008, 04:56 PM
I tried to load this hack on a pure test forum a mistake also exists

RedeemedWarrior
08-13-2008, 05:17 PM
Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in [pathtoforum]/showthread.php(2153) : eval()'d code on line 74

Moya
08-13-2008, 06:16 PM
Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in [pathtoforum]/showthread.php(2153) : eval()'d code on line 74

Do you have the product enabled? I created and viewed a thread here without any problem

http://www.christfirstrpg.co.uk/forums/showthread.php?p=47711#post47711

Moya
08-13-2008, 07:09 PM
I found the problem. I forgot to close the if statement in the template.

Please download and reinstall

bw1
08-13-2008, 10:21 PM
I am blind.
Where?s the on/off switch?

___________
FOUND :)

soletrader
08-13-2008, 11:37 PM
When a user without access visits the post link a message appears: Invalid Thread specified. If you followed a valid link, please notify the administrator

Is there anyway to change this message specific for this hack? This message seems as if the thread does not exist. Thanks

soletrader
08-14-2008, 12:47 AM
Also, would it be possible to disable the selection of usergroups? It will also make sense if members can uninvite themselves from threads as well.

Lionel
08-14-2008, 12:52 AM
Does this take the archives into consideration?

Moya
08-14-2008, 02:32 AM
soletrader (https://vborg.vbsupport.ru/member.php?u=154192),
I change the message to regular notification and add the archive option.

Lionel,

It is now :D

soletrader
08-14-2008, 02:47 AM
Thanks Lionel. I would be interested in seeing an option for the thread starter to add/remove users even after the thread is created since the edit limit by default is only 30 min. Thanks

Lionel
08-14-2008, 03:46 AM
2 problems.

1-installing it gave me a class_bitfield_builder.php error
2-it is not inserting anything in TABLE_PREFIX . "thread (so the checkbox always remain at first option) and for admin in showthread, it displays a line for an empty table

Moya
08-14-2008, 04:23 AM
Hi Lionel,

This hack doesn't use any bitfield. I don't know why you get that error. For your second error, I think it is because the product didn't finish installing.

RedeemedWarrior
08-14-2008, 04:47 AM
I had disabled it when you had made the thread :)

The glitch stopped with the new Xml file :)

not tested it yet though

Lionel
08-14-2008, 11:27 AM
Hi Lionel,

This hack doesn't use any bitfield. I don't know why you get that error. For your second error, I think it is because the product didn't finish installing.

hummm I installed it 4 times.
I know it does not use bitfields. That is getting me puzzled also.

Moya
08-14-2008, 03:08 PM
Do you have the list of hacks that are currently installed on your board?

Lionel
08-14-2008, 03:16 PM
I managed to get it to work. I fixed the line in showthread by closing all the <table within each if condition. instead of table on top and at the end ... so of course if you get nothing then you get a thin line for table, at least in FF

Only that bitfields error .... but hey it works. Thanks.

soletrader
08-15-2008, 03:54 AM
Is there anyway to exclude private threads from showing up in unread posts?

Moya
08-15-2008, 04:09 AM
I haven't thought of that. I will work on it

Megatr0n
08-22-2008, 08:26 PM
Moya, another error when selecting "Find All Posts" on a users profile:

Database error in vBulletin 3.7.2:

Invalid SQL:

SELECT post.postid, post.title AS posttitle, post.dateline AS postdateline,
post.iconid AS posticonid, post.pagetext, post.visible, post.attach,
IF(post.userid = 0, post.username, user.username) AS username,
thread.threadid, thread.title AS threadtitle, thread.iconid AS threadiconid, thread.replycount,
IF(thread.views=0, thread.replycount+1, thread.views) as views, thread.firstpostid, thread.prefixid, thread.taglist,
thread.pollid, thread.sticky, thread.open, thread.lastpost, thread.forumid, thread.visible AS thread_visible,
user.userid
,pdeletionlog.userid AS pdel_userid, pdeletionlog.username AS pdel_username, pdeletionlog.reason AS pdel_reason
,tdeletionlog.userid AS tdel_userid, tdeletionlog.username AS tdel_username, tdeletionlog.reason AS tdel_reason
, threadread.readtime AS threadread
,thread.vbbux_cost,thread.vbplaza_titleflags,threa d.vbplaza_titletextcolor,threa d.vbplaza_titleglowcolor,thread.vbplaza_titleshado wcolor,thread.vbplaza_titlefon ttype,thread.vbplaza_titlebordercolor,thread

Rene Kriest
09-05-2008, 07:08 PM
Your addon sounds pretty neat. Before I'll give it a try I have a question:

Can the thread starter later change his options so that you can add and remove members who can read or are not permitted to read the thread?

viper357
10-22-2008, 11:49 AM
Will this work on 3.6.11?

4x4 Mecca
11-09-2008, 09:16 PM
If I use this with the live post feed hack http://www.4x4mecca.com/forum/vaispy.php it shows the content of the post there. I know this other hack has nothing to do with you, but do you have any suggestions on how to get it not to show up there?

Rene Kriest
11-15-2008, 03:29 PM
I am blind.
Where?s the on/off switch?

___________
FOUND :)

Well, I am still blind. Anyone may help with the switch?

Well I finally got it, too:
Go to your Admin Panel/Forum Rights/

rob01
11-24-2008, 02:32 AM
Database error in vBulletin 3.7.4:

Invalid SQL:

SELECT post.postid, post.pagetext, IFNULL( user.username , post.username ) AS
username, dateline
FROM vbb_post AS post
LEFT JOIN vbb_user AS user ON (user.userid = post.userid)
WHERE threadid = 36
AND visible = 1
and privatethread <> 1
ORDER BY dateline ASC
LIMIT 0,250;

MySQL Error : Unknown column 'privatethread' in 'where clause'
Error Number : 1054
Request Date : Sunday, November 23rd 2008 @ 05:46:40 PM
Error Date : Sunday, November 23rd 2008 @ 05:46:40 PM
Script : http://tustan.net/bbs/archive/index.php/t-36.html
Referrer :
IP Address : @@@@@@@@@
Username :
Classname : vB_Database
MySQL Version :




someone gets this error?

Rene Kriest
11-24-2008, 07:28 AM
@rob01

Yep, I did. Just remove the PHP code that comes together with this add-on from archive/index.php. That's all.

Have a look at your error message which states Script: http: //tustan.net/bbs/archive/index.php/t-36.html

btotw
01-09-2009, 05:38 PM
How can I disable certain usergroups from being able to start a private thread?

Thank you

home9000
01-09-2009, 05:44 PM
is it working in 3.6.5

btotw
01-09-2009, 06:32 PM
is it working in 3.6.5
Wast that to me? If so, can you tell me how to access this function?

btotw
01-17-2009, 03:30 PM
How can I disable certain usergroups from being able to start a private thread?

Thank you

Anyone...?

btotw
01-23-2009, 05:02 PM
Figured it out.

I wish the threads themselves were invisible though...hmm...

gmerin
01-24-2009, 02:01 PM
i notice it makes the threads only appear to be private because the posts within the faux private threads are available via search for all posts by user. Apparently the mod should really be titled Not Quite Private Threads

Rene Kriest
01-24-2009, 03:56 PM
i notice it makes the threads only appear to be private because the posts within the faux private threads are available via search for all posts by user. Apparently the mod should really be titled Not Quite Private Threads
Pls consider this: there is a difference between using the search function as admin and as normal user or even guest. Different rights mean different (search) results. :)

I believe that you did what I did before with this addon: I did him wrong because I forgot that admins won't be excluded from those threads for security purpose. I had the same complaints before I checked normal user rights instead of my admin account (dumb, I know :D).

Log out and re-check via guest or normal user account and get back here. The only thing I receive is "This is a private thread" when doing a search then but no content insecurity after all.

Rene Kriest
01-24-2009, 03:58 PM
BTW: addon works smooth with vb 3.8

gmerin
01-24-2009, 06:57 PM
Pls consider this: there is a difference between using the search function as admin and as normal user or even guest. Different rights mean different (search) results. :)

I believe that you did what I did before with this addon: I did him wrong because I forgot that admins won't be excluded from those threads for security purpose. I had the same complaints before I checked normal user rights instead of my admin account (dumb, I know :D).

Log out and re-check via guest or normal user account and get back here. The only thing I receive is "This is a private thread" when doing a search then but no content insecurity after all.

I wouldn't have posted without first trying both as an admin and as a regular user, plus I had several of my regular users point out to me that while the thread is private when they attempt to access it, when they go to a user's profile page and select show all posts by user the posts from the supposedly private thread show up.

Go to the creator of a private thread that your regular user account should not be able to read. Go to Statistics, then do Show All Posts by <creator of the private thread>. In addition to all the non-private thread posts, the private thread posts are fully displayed.

In order to prevent this I currently have to disable the Forum Search for my users (as the Private Threads is more important to them), but I shouldn't have to.

gmerin
01-24-2009, 07:05 PM
BTW: addon works smooth with vb 3.8

would you please try the procedure I described in the earlier post to see if this is a basic deficiency of the mod or a difference between v3.7x and v3.8?

btotw
01-24-2009, 07:44 PM
i notice it makes the threads only appear to be private because the posts within the faux private threads are available via search for all posts by user. Apparently the mod should really be titled Not Quite Private Threads

I kinda agree. To me, its not even "Not Quite Private Threads." Its more like "Deny Post Viewing For Certain Users or Groups."

@The author: Dont get me wrong, the hack itself is excellent...I simply feel that its misnamed.

For example, a private message cant be seen by anyone at all except for those whom its intended for. Thus i think that a private THREAD should be 100% invisible if you arent part of the usergroup(s)/ person(s) who are allowed to see it...

It should be like ts not even there. If I start a private thread as an admin, I should be able to see it...but if I log in as a regualr user, it should be as it it doesnt exist at ALL...

Again, just my two cents. Its partially there by disallowing the viewing of the conversation in question. If it were to be taken to that last step? It'd be killer...

gmerin
01-25-2009, 05:41 PM
I kinda agree. To me, its not even "Not Quite Private Threads." Its more like "Deny Post Viewing For Certain Users or Groups."

@The author: Dont get me wrong, the hack itself is excellent...I simply feel that its misnamed.

For example, a private message cant be seen by anyone at all except for those whom its intended for. Thus i think that a private THREAD should be 100% invisible if you arent part of the usergroup(s)/ person(s) who are allowed to see it...

It should be like ts not even there. If I start a private thread as an admin, I should be able to see it...but if I log in as a regualr user, it should be as it it doesnt exist at ALL...

Again, just my two cents. Its partially there by disallowing the viewing of the conversation in question. If it were to be taken to that last step? It'd be killer...

and if the denied users or groups really want to see what they're begin denied they only have to go to the thread creator's public profile and look at all posts by user to read everything in the thread. it's kind of like when children make something invisible by covering their eyes ;)

other than that little issue, the hack is beautiful and my users value it so much that they are willing to lose the searching facilities of VB in order to maintain the security of the hack.

Rene Kriest
01-26-2009, 08:44 PM
Hello folks!

I am finally back after some testing and I also had a look at the source code of this addon aswell.

To make it short:

This addon is save only under certain additional conditions which need to be set by an admin

The addon has no flawsKinda paradoxical, or? But read on! :)

Here are now the results of my investigations regarding the so-called security flaws

The "search postings" issue is a flaw but not of the addon but of the cache.
You need to rebuild your search index cache to make the addon work 100%. After rebuilding there will be a message in the search posting preview "This is message from private thread". Technically the addon is flawless - the problem is the forum search cache.

How to fix that issue

Rebuild your cache often via cron
Allow the addon only in certain forums which aren't searchable
Allow the addon only in certain forums which are restricted to certain usergroups only, but take care: then the problem applies to the members of the usergroup itself if you do not alter the search rules to the forum
Turn of "posting preview" or reduce the number of letters (standard: 200, to be found in search.php)
Use a spoiler to at least 200 letters for each postingMy suggestions
Use the addon only in forums where the search function is put off or at least restricted to titles only.

Rebuildung your Search Index Cache somehow sucks, because of the time gaps and the huge server load it creates.

murekhalir
01-28-2009, 04:42 AM
So does this mod still work.

Does it really create thread privacy or are there loopholes?

gmerin
01-29-2009, 12:01 PM
So does this mod still work.

Does it really create thread privacy or are there loopholes?

If I'm reading Rene correctly the mod does create fully private threads if you limit it to forums that are not searchable, and if you rebuild your search cache often.

Unfortunately constantly rebuilding the search cache is not realistic due to the time and server resources required.

So this leaves us with the option of shutting off the search function on the board or limiting the mod to forums which have the search function disabled.

I have no problem with exchanging the search functionality for the private threads.

I am indifferent as to where the fault lies: I prefer to fix the flaws than to affix the blame. Whether you want to say the mod is flawed or the caching algorithm of VB is flawed, is immaterial to me.

I do believe the limitations and implicit requirements should be noted prominently in the mod's documentation so that admins are forewarned, rather than finding out about it after one of your members realizes that she posted info about her adulterous affairs in a private thread that wasn't all that private...

Phornixx
02-06-2009, 10:37 PM
Can't find the ON/OFF Switch!!!

What does Admin Panel/Forum Rights/?

There is no such option in the Admin CP

Thanks!

gmerin
02-06-2009, 11:49 PM
Can't find the ON/OFF Switch!!!

What does Admin Panel/Forum Rights/?

There is no such option in the Admin CP

Thanks!

go into the Admin CP -> Forums & Moderators -> Forum Manager

expand the forums and permission each in the Enable / Disable Private Thread Option towards the bottom.

btotw
02-22-2009, 07:37 PM
and if the denied users or groups really want to see what they're begin denied they only have to go to the thread creator's public profile and look at all posts by user to read everything in the thread. it's kind of like when children make something invisible by covering their eyes ;)

other than that little issue, the hack is beautiful and my users value it so much that they are willing to lose the searching facilities of VB in order to maintain the security of the hack.
I understand your point.

Understand mine.

My point is that the hack is GREAT. But it should be called "Private POSTS" instead of "Private Thread" :)

Birched
08-09-2009, 05:25 PM
There is a plugin that is disabled by default:
Private Threads: Get Private/Restricted Users showthread_complete
What does that one do? Why is it disabled?

Also -- do you know how the mod interacts with mysql fulltext search? Does it still have the same problems?

Also -- is it still set up for admin only to be able to 'private' things?

It's an excellent mod -- I used the older version (long ago) and found them useful for our boards. Thanks for putting it together (it's BIG!) and thanks for supporting it.

One comment: I am running a huge board with many forums. It would be great if the admin controls had a setting that would propagate through child forums.

Birched
09-16-2009, 12:44 PM
BUG: Edit (AJAX) of the first post of a thread results in the loss of the private flag for the thread.

buro9
12-29-2009, 05:31 PM
A question, does this work with VB4?

Has anyone tested it?

HybridIllusions
01-26-2010, 09:06 AM
Just curious, does this mod let the ability of "only the specified users can post to the thread, but everyone (with forum access permission) can still view it"?

Basically, I see full private as being something more left to PMing, so I wanna use this to let members control who can post to their thread, but still allow everyone else to view the thread.

unforgotten
05-02-2011, 06:02 AM
Is there a way to make the first post visible to all and only the replies to make them private?

Tyran1
04-18-2012, 05:19 AM
German Product ...

pkuczaj
04-03-2013, 04:24 PM
Has there been any activity in this mod? I would like to use Tapatalk on my board, but the security of the private threads is being violated. I need to figure out what I need to do in the tapatalk search.php so that the private threads are respected.

spielo1312
05-27-2014, 07:41 AM
Is it possible for 4.22 to work?

spielo1312
09-06-2014, 03:55 AM
Is it possible for 4.22 to work?

is still my question, if some coder here he will bring it to work for 4.22 i will pay for it.

pm me

regards

pkuczaj
09-07-2014, 02:27 AM
If the code is available for review I would be willing to do the work on this.

spielo1312
09-22-2014, 11:18 AM
If the code is available for review I would be willing to do the work on this.


Last Activity: 03 Aug 2009 17:13 so i think this developer is no more intrested, can somebody work for 4.22?

Thanks

tbworld
09-23-2014, 12:55 AM
This code is not marked reusable. It cannot be updated by a third party unless given permission from the original author. :)

spielo1312
09-23-2014, 05:59 AM
This code is not marked reusable. It cannot be updated by a third party unless given permission from the original author. :)

I Now and this is the problem with vbulletin, the autor of this mod is no more here, this website is also down, this autor will not come back and now a good mod will by die! it?s a pity

ozzy47
09-23-2014, 09:07 AM
I Now and this is the problem with vbulletin, the autor of this mod is no more here, this website is also down, this autor will not come back and now a good mod will by die! it?s a pity

It's not a problem with vBulletin, it is copyright laws. The code belongs to the person who wrote it, not vBulletin.