Charset and MySQLi

[Talaturen]

Hello.

I wonder if anyone has tried the MySQLi code, I doubt anyone has got it to work without modifications because it looks completely wrong. I guess the author of this modification only replaced 'mysql' with 'mysqli' when adding mysqli support and if you try the code you'll end up with a bunch of errors. It would be cool if this could be fixed, shouldn't be too hard. I could probably fix it myself but then I'll have to re-patch my fixes every update which I don't think I will have the time to.

The other issue I'm having is charset related, I'm using charset latin1 and this arcade modificaiton is ignoring that which is messing up some usernames and perhaps comments too (not checked but I guess it's using same database methods..). Now that I'm using MySQL because I don't have the time to fix all the errors in the MySQLi file I fixed this by adding: mysql_set_charset("latin1"); in the connection part. Of course that line may cause trouble for others but some method like the vBulletin core could be used:

if (!empty($charset))
{
if (function_exists('mysql_set_charset'))
mysql_set_charset($charset);
else
$this->query("SET NAMES $charset");
}


Thanks,
Talaturen.

[Talaturen]

-- bump --

[MrZeropage]

as stated in the release-history, mysqli-implementation is very basic and still unstable/buggy

As I don't have/use mySQLi it is somehow hard to develop ;)

so if you do all adaptions to the dbclass_mysqli I would integrate it of course

[Talaturen]

I've been quite busy lately but I'll see if I can get some free time to rewrite the MySQLi database class. What about the charset issue, has it been fixed for the next release?

[MrZeropage]

no, nothing done about charset.

I would be thankful for your fixes :)