PDA

View Full Version : Add-On Releases - Wowhead Item tooltips for World of Warcraft


sweede
11-29-2007, 10:00 PM
Please see https://vborg.vbsupport.ru/showthread.php?t=183035 for updated version

Ninok
11-30-2007, 08:19 PM
Can you edit the XML to reflect that it will work on 3.6.5? I had to edit it for min = 3.6.5 and max = 3.6.8.

It works completely on 3.6.5 fyi =D

sweede
11-30-2007, 08:27 PM
It will probably work with anything 3.6.x

i'll update it here in a few.

Ninok
11-30-2007, 08:30 PM
It will probably work with anything 3.6.x

i'll update it here in a few.

I'm pretty sure it does, just get that error about it requiring 3.6.8, easy fix =D

Ninok
11-30-2007, 11:02 PM
EDIT: I did not see 2.6 released.

I'm getting this error on some of my pages now.....

Fatal error: Cannot instantiate non-existent class: vb_xml_parser in /html/forum/global.php(356) : eval()'d code on line 103

freebase69
11-30-2007, 11:17 PM
Worked like a charm! Awesome.

DDolphins
12-01-2007, 12:43 AM
Installed and works perfectly. Thank you

Newfarm
12-02-2007, 07:58 PM
Awesome, works just as well as I hoped when I wrote that "I wish if someone could just.." post in the other thread. Great work!

sweede
12-02-2007, 10:25 PM
I'm also working to get it where if you post a wowhead URL , instead of making the URL clickable, it grabs the item name from the URL and create the item link accordingly

i.e.
http://www.wowhead.com/?item=18609
turns into
Anathema

I have it working on my forums currently but i had to modify another addon entirely to get it to work.

Radek125
12-03-2007, 03:55 AM
I have curl enabled and am getting the following error.

Fatal error: Call to undefined function curl_init() in /usr/home/guild/public_html/forumold/global.php(360) : eval()'d code on line 319

Any ideas?

gitemstats links for hyjal and bt are currently broken @ http://www.afraidyet.net - kinda wierd :/

sweede
12-03-2007, 01:20 PM
Removed the need for CURL , if you aren't having issues, there is no reason to update.

ChiliVB
12-04-2007, 12:47 PM
Many thanks for coming up with this mod for Wowhead integration!

I've installed and noticed something I was hoping I could tweak in the itemname appearance in post.

In my installation the Items names are underlining. I looked at the example on your site and this is not occurring. It did not occur with my previous installation of gItemstats or the original Itemstats product.

I looked thru the plugins your xml install but I don't see what would be causing the name to be underlined. Could you point me to the code so I can tweak that please.

Example attached.

72937

Newfarm
12-04-2007, 02:53 PM
Are all your links underlined? ;) As far as I know this just inherits these properties from whatever style that is in use. If I test with a style on my board that has default underlining of links, these links are underlined. If I'm using the style that's actually in use, with no link underlining unless hoovering, I don't get any underlines.

Shorter version;

You need to set up the CSS for your style.

sweede
12-04-2007, 04:01 PM
I've installed and noticed something I was hoping I could tweak in the itemname appearance in post.


It is because that your style underlines URL links and the example i have doesnt.

however, the new version allows you to set text-decoration: none; in the item URL (along with bod) in your admin options.

also my product update should fix a bug in vbulletin
http://www.vbulletin.com/forum/project.php?issueid=23842

jaykresge
12-04-2007, 04:21 PM
So far,I'm liking this mod. However, like gItemStats, the WYSIWYG editor can mess up the links, though not as badly.

I've found a way around it, thanks to the WoWhead js, simply create an item BBCode. Problem is, I'm not sure what to include in the replacement field. Any ideas?

Thanks again for making these changes to the mod.

ChiliVB
12-04-2007, 04:22 PM
Sweede, Thanks for the quick response and adding the option to disable text decoration for item links.

I updated to your new version and its working like a charm.

jaykresge
12-04-2007, 04:32 PM
What I'm trying to do right now is two things.

1. Create a Custom BB Code, so that you can use the WYSIWYG editor, without it messing up the item tag. I want it to recognize the item tag.

2. Instead of typing item and /item, you simply type the name of the item, highlight it, and click the WoWHead button, which warps the item tags around the item name.

However, I'm having a hard time figuring out what to put in the "replace" section. I'll keep trying, but if you have any input, feel free to add it in :)

Radek125
12-05-2007, 05:48 PM
Since we're on the same WoW server Az I've been following your site for a while. What DKP setup you guys using? I notice the item history linking modules you had on the main page for a while showing item history and various changes you've been making to your site over the last few weeks. We use EQDKP plus modded but I noticed you were using one with vbphrases involved. (Just recently) Is this custom or something you've found and have been working on yourself? I could incorperate EQDKP plus loot history on our main page but it looks like you have setup a much easier way of doing this. New RS site looks nice =) I'm not running VBadvanced, so our setup is a little different.

WoWHead item stats is much cleaner code than gitemstats was, thank you for this mod.

Installed.

http://www.afraidyet.net

-Radek

sweede
12-05-2007, 07:36 PM
Since we're on the same WoW server Az I've been following your site for a while. What DKP setup you guys using? I notice the item history linking modules you had on the main page for a while showing item history and various changes you've been making to your site over the last few weeks. We use EQDKP plus modded but I noticed you were using one with vbphrases involved. (Just recently) Is this custom or something you've found and have been working on yourself? I could incorperate EQDKP plus loot history on our main page but it looks like you have setup a much easier way of doing this. New RS site looks nice =) I'm not running VBadvanced, so our setup is a little different.

WoWHead item stats is much cleaner code than gitemstats was, thank you for this mod.

Installed.

http://www.afraidyet.net

-Radek


we use loot council, but i'm writing an attendance tracker based on a modified version of NRT (http://rabbit.nihilum.eu/nrt.html).

I have quite a bit of re-writing to do though.

atomhead
12-08-2007, 01:11 AM
This is awesome and so easy to install. Only problem is the item link is using my template's default color not purple or whatever the item quality is. Any ideas?

http://www.tlbguild.org/forums/showthread.php?t=5

sweede
12-08-2007, 01:54 PM
This is awesome and so easy to install. Only problem is the item link is using my template's default color not purple or whatever the item quality is. Any ideas?

http://www.tlbguild.org/forums/showthread.php?t=5

They work fine until you edit a post and save it, then it changes the "item" tag into a URL tag. What it does then is that it looses the class attribute from the URL link.

The way around this is NOT to use the WYSIWYG Editor controls.

in the Admin CP, go to vbulletin options -> Message Posting Interface Options and change the three options under "Enable Clickable Message Formatting Controls" to "Enable Standard Controls"

Now, since some of your users may have the wrong option checked, you can mass update them if you set an option in the config.php file.

$config['SpecialUsers']['canrunqueries'] = '1'; or whatever your user id is.

then go to
Maintenance -> Execute SQL Query and from the drop down list select "Show Standard Editor Toolbar"

sergiod06
12-18-2007, 07:38 PM
I have vbAdvanced, is it possible that the Name work on custom html pages?

Wayne Luke
12-18-2007, 11:04 PM
This should add information about the bbcode to misc.php?do=bbcode.

sweede
12-19-2007, 04:17 AM
This should add information about the bbcode to misc.php?do=bbcode.


Is there an easy way of doing that ? There doesnt seem to be a lot of documentation on adding stuff through the built in API of vBulletin (or even that there IS an API for vBulletin!).

Edit: I added the info about the bbcode to the location listed. It's Q&D but thats why plugins and hook locations were created right :)


sergiod06 , not for custom HTML pages. I'm sure that there is a way to search & replace items via plugin hooks but there isnt much reason to do that. if you need to add item links, the proper format for the item mouseover can be found at wowhead.com

<a class="q5" href="http://www.wowhead.com/?item=19019">Thunderfury, Blessed Blade of the Windseeker</a>

q5 is legendary
q4 is epic
q3 is rare
q2 is uncommon
q1 is common
q0 is junk

sergiod06
12-19-2007, 02:35 PM
Yes, i've done a custom BBCode page, however the html that is perfect on html page, is messed up on the bbcode page :P

sweede
12-19-2007, 03:35 PM
I have vbAdvanced, is it possible that the Name work on custom html pages?

Now that i think about it, there may be a way to run the bbcode processor over an HTML based template w/bbcode in it using the parse_templates hook or something horribly inefficient like that


Now when you say "Custom HTML page" , do you mean
Vba- >Add Page- > Page type of ??

Template Page or HTML File page ?

xxxsaint
12-19-2007, 04:06 PM
how can I add a button so that when I type in the item name , I can highlight it and click that button , making it wrap the [ item ] tags around it ?

sweede
12-19-2007, 07:11 PM
That's on my list of things to do, i'll try to figure it out for an update tomorrow.

Danoxth
12-19-2007, 07:21 PM
Installed this yesterday and it worked fine on the test server.

Just gone onto the "live edition" of the forum and sadly does not work any longer. It's on a fresh install of vBulletin and is one of the first mods i've gone to add.

When importing the product I get this error appear briefly:

Parse error: syntax error, unexpected $end in D:\wamp\www\forum\admincp\plugin.php(1970) : eval()'d code on line 4The product then continues to install as normal but sadly no longer functions. Using the item code [ item] <Item name here> [ /item] causes the item name to become underlined and changed into a link to the WoWhead page for that item.

Using just the WoWhead address for the item just stays as the url e.g.: http://www.wowhead.com/?item=33491

Any suggestions?

sweede
12-24-2007, 01:57 PM
Parse error: syntax error, unexpected $end in D:\wamp\www\forum\admincp\plugin.php(1970) : eval()'d code on line 4The product then continues to install as normal but sadly no longer functions. Using the item code [ item] <Item name here> [ /item] causes the item name to become underlined and changed into a link to the WoWhead page for that item.
Any suggestions?

Uninstall the product completly.
Download the latest 0.3.1a version and add the product again.

sergiod06
12-31-2007, 04:44 PM
Now that i think about it, there may be a way to run the bbcode processor over an HTML based template w/bbcode in it using the parse_templates hook or something horribly inefficient like that


Now when you say "Custom HTML page" , do you mean
Vba- >Add Page- > Page type of ??

Template Page or HTML File page ?

Yes, I put in HTML File page.

sweede
12-31-2007, 06:33 PM
Also, im updating the plugin . xml file to include the above plugin and an option to enable/disable the specific hook if you do not use VbAdvanced CMPS

sweede
01-01-2008, 04:41 PM
Also, im updating the plugin . xml file to include the above plugin and an option to enable/disable the specific hook if you do not use VbAdvanced CMPS

My plugin didnt work as intended. there was to many issues elsewhere to make it work using the hooks supplied by vbadvanced CMPS.

You instead can enable this for HTML Included pages only by adding

require_once(DIR . '/includes/class_bbcode.php');
$tmp_parser =& new vB_BbCodeParser($vbulletin);
$home[$modid]['content'] = $tmp_parser->do_parse($home[$modid]['content'], 1,0,1,1,0,0);


at line 321 of the /includes/vba_cmps_include_top.php file.

You still will have issues with any javascript included in the HTML file though.

comicus
01-03-2008, 12:06 AM
I've been using gitem stats for awhile, but was excited to see this one. Am i completely misunderstanding something or do your users have to know the wowhead item number in order to make this work? With gitem stats you just used name and it would give you a mouseover tooltip/link. with this, it appears that you have to include the actual wowhead item number when trying to create the link. is that right? if so...is there any way to make this mimic gitem in that regard? i'd hate to expect my users to go and look the item number up everytime they want to post something.

any assistance would be appreciated. Thanks. =)

Newfarm
01-03-2008, 04:02 AM
This works with Spiteblade :)

sweede
01-03-2008, 05:41 AM
What it does is similar to how the itemstats works.

you post an item with the item tag, foo

The first thing it does is it looks up the name foo , in the database (the database stores the item name, the item quality and the item ID). It reads the item ID and quality and writes the URL.

If it cannot find the item name there, it checks wowhead to see if the site exists. The URL to a wowhead item is pretty simple, http://www.wowhead.com/?item=[ItemName]&xml , for example http://www.wowhead.com/?item=Nightseye&xml

I just read the item ID from the xml and write the URL to match whats required by the wowhead javascript http://www.wowhead.com/?powered

sweede
01-03-2008, 06:06 AM
i'd hate to expect my users to go and look the item number up everytime they want to post something.

any assistance would be appreciated. Thanks. =)


I've found that my users would rather post the item link

http://www.wowhead.com/?item=33585

when trying to list their "wish" lists and whatnot...

so, i updated the plugin

comicus
01-03-2008, 10:57 AM
This works with Spiteblade :)

strange. not for me it doesn't. it creates a link....and if you click on it, it works. however, there is no mouseover tooltip. maybe i'm doing something wrong. there aren't really any instructions. do i have to do anything other than import the product? any thoughts? (yes, i just installed the newest version). thanks.

sweede
01-03-2008, 11:19 AM
Install the Updated XML file (0.3.5a)
Due to this bug, http://www.vbulletin.com/forum/project.php?issueid=24174

The product name of my template was changed from what it should be to vbulletin and when i exported the product last, the template wasnt included in the export.

comicus
01-03-2008, 11:23 AM
sweede. you just made my day! love it! thank you! =)

Wayne Luke
01-03-2008, 03:28 PM
This causes an Operation Aborted error in Internet Explorer 7 if you mouse over the link before the entire page (including images) is finished loading. Any way to prevent the tooltip from popping up if the page is still loading?

At first I thought it was because I was using an older version of 0.29 but I just upgraded to 0.35a and it still occurs.

sweede
01-03-2008, 08:39 PM
I don't think there would be anything you could do. It sounds like it may be a problem with either loading the script from another website and the browser security settings. But im no java expert by anymeans.

I also can't reproduce this on my site in any way.

Maybe have the javascript included after the page footer?

BlackRabbit1971
01-11-2008, 10:51 PM
Anychance of having an option setting to set link clicks to open a new page or have the same page change, please?

sweede
01-11-2008, 11:02 PM
you know, i never really click those links, so i never thought of doing that.

i don't have time to add that in today , but i'll get it tomorrow.

BlackRabbit1971
01-12-2008, 11:29 PM
Thanks man :)

sweede
01-15-2008, 02:10 PM
Thanks man :)

Updated. Default is to open in new window, uses the target="_blank" method , which i dont think is xhtml proper. i'm to lazy to look up how to do it XHTML proper :p

BlackRabbit1971
01-15-2008, 05:23 PM
Yeah ya right, hmmm just not doing it on mines... I'll look for the xhtml for it see if I can play with it.. bit weird though..

sweede
01-15-2008, 06:22 PM
Yeah ya right, hmmm just not doing it on mines... I'll look for the xhtml for it see if I can play with it.. bit weird though..

clear your post cache so that it rebuilds posts.

BlackRabbit1971
01-17-2008, 04:52 PM
I take it you mean me to "Rebuild Post Cache" from the Maintenance>>Update Counters section? If you did, that didn't work either, very weird.

Mother_Dee
01-21-2008, 02:36 AM
My issue appears to be only when I'm trying to post a new thread with a WoWhead link (not using BBcode):

PHP Fatal error: Call to undefined function print_log() in /forum/includes/functions_newpost.php(175) : eval()'d code on line 64

and I seem to have narrowed the issue down to the "Wowhead URL TO Item code" which takes its code from another hack that seems to conflict with other functions on occasion (Ajax chatboxes being one.) I'll look at it more after some much needed sleep.

(Edit: At this point just disabling that plugin portion seems to do the trick. I'd still rather find the conflict and resolve but at this point not having a whitepage when someone tries to post a WoWHead hyperlink will have to do. ^.^)

sweede
01-21-2008, 02:44 AM
My issue appears to be only when I'm trying to post a new thread with a WoWhead link (not using BBcode):

PHP Fatal error: Call to undefined function print_log() in /forum/includes/functions_newpost.php(175) : eval()'d code on line 64

and I seem to have narrowed the issue down to the "Wowhead URL TO Item code" which takes its code from another hack that seems to conflict with other functions on occasion (Ajax chatboxes being one.) I'll look at it more after some much needed sleep.

(Edit: At this point just disabling that plugin portion seems to do the trick. I'd still rather find the conflict and resolve but at this point not having a whitepage when someone tries to post a WoWHead hyperlink will have to do. ^.^)


Fixed, use the 0.3.6a file.

mikeylikesitz
01-21-2008, 06:19 PM
I am also having members get the IE aborted error with this plug in, one was trying to look at a specific thread that was not in the wow section that had the tool tips, the other was trying to view the forum main page. I have only installed the .36a version, im going to try and troubleshoot to see where things go wrong.

sweede
01-21-2008, 06:29 PM
I am also having members get the IE aborted error with this plug in, one was trying to look at a specific thread that was not in the wow section that had the tool tips, the other was trying to view the forum main page. I have only installed the .36a version, im going to try and troubleshoot to see where things go wrong.

http://www.wowhead.com/?forums&topic=7708&p=80943

I include the wowhead.js script at the end of the </head> tag.

try this,
In your Admin CP, go to Plugins & Products -> Plugin Manager -> find "Wowhead setup" and edit that.

The 2nd line


$vbulletin->templatecache["headinclude"] = $vbulletin->templatecache["headinclude"].$vbulletin->templatecache["wowhead_headerinclude"];


Change that too

$vbulletin->templatecache["headinclude"] = $vbulletin->templatecache["wowhead_headerinclude"].$vbulletin->templatecache["headinclude"];

mikeylikesitz
01-21-2008, 09:18 PM
ok thank you. I will try it and see if the members report anything.

mikeylikesitz
01-21-2008, 11:33 PM
ok i edited and had the same issue. I started to troubleshoot some and came a little further. As that posting you listed, the forum home doesnt have the "<base href=" in it yet the forums themseves do which causes the issue not to pop up on loading the forum page but it does pop up when someone goes into a forum to read a thread. Not sure how to move the code so that the js script is loaded before that line in the forums themselves.

nkodengar
01-22-2008, 12:51 PM
Great mod, is it possible to change the colour of item links so common items will be readable on the default vB style?

sweede
01-22-2008, 04:04 PM
ok i edited and had the same issue. I started to troubleshoot some and came a little further. As that posting you listed, the forum home doesnt have the "<base href=" in it yet the forums themseves do which causes the issue not to pop up on loading the forum page but it does pop up when someone goes into a forum to read a thread. Not sure how to move the code so that the js script is loaded before that line in the forums themselves.

PM me a link to your forums so i can see where you're talking bout?

sweede
01-22-2008, 04:06 PM
Great mod, is it possible to change the colour of item links so common items will be readable on the default vB style?


The style comes from wowhead.com , but you can override it by adding a CSS style after the javascript include. I'm upgrading my forums atm but when i am finished i'll poke around and add a way to override the default colors.

sweede
01-23-2008, 04:54 PM
Great mod, is it possible to change the colour of item links so common items will be readable on the default vB style?

See attached Image

Caerydd
01-24-2008, 11:38 AM
Just a quick notification that this version of item tooltips (I have also installed gItemstats in the past) works perfectly with vbadvanced.

sweede
01-24-2008, 01:18 PM
Sorry guys, seems i left the debuging functions in there yet again, please use the 0.3.7a version.

Caerydd
01-24-2008, 03:15 PM
Your changelog says 0.3.6a , fyi. And thanks for the quick fix :)

sweede
01-24-2008, 04:00 PM
ya, quick edit too :p

I noticed an issue with the Warglaives of Azzinoth (we had the off hand drop last night w00t1). since there are two different items but they both have the same name, you can't link both the Mainhand and Offhand

you either have to use item IDs
31323 or the URL link. To use the wowhead URL link, you have to change 1 line of code.

In the "Wowhead URL TO Item code" Plugin, find the line
$name = $xmlobj->parseddata[item][name];
and change it to
$name = $xmlobj->parseddata[item][id];

Caerydd
01-24-2008, 04:55 PM
Not really an issue for my guild yet >> Still on t4/t5 stuff, but thanks for the info and congratulations! ^^ I'm sure there's others out there using this that will

nkodengar
01-25-2008, 12:09 PM
Awesome, thanks :)

BennehSmK
01-26-2008, 06:01 PM
Alright,

I have just installed AME and when updating the posts to convert to ame it appears to have disabled all the wowhead links, the text now just reads Name of Item.

If I edit and save the post the wowhead links start to work again.

Is tehre a quick way of going through all posts and edit then save them, if I have to go through by hand it will take me ages :(

I used Rebuild Post cache after manually correcting a few (edit/save) and it set those back to :(

CremeEgg
01-29-2008, 06:27 PM
A couple of quick questions:

1. Why does rebuilding the post cache break all the item links?
2. Would it be possible to add the [item] tags to the editor? I saw a bit about it on the wowhead forums page you linked, but didn't want to add it incase it conflicted with this mod.

sweede
01-29-2008, 06:35 PM
A couple of quick questions:

1. Why does rebuilding the post cache break all the item links?
2. Would it be possible to add the [item] tags to the editor? I saw a bit about it on the wowhead forums page you linked, but didn't want to add it incase it conflicted with this mod.

I'm going to have to do some good testing to see why rebuilding post cache removes item links and i don't have a test board setup atm, but i'll get that done today.

As for the item tag to the editor, that'll be added shortly. i'll have to stea.. i mean, borrow a wowhead icon for it. The main reason i havent done this in the past is because I didnt want to have to add any additional files. Just a simple XML upload and that was it.

CremeEgg
01-29-2008, 08:11 PM
I'm going to have to do some good testing to see why rebuilding post cache removes item links and i don't have a test board setup atm, but i'll get that done today.

As for the item tag to the editor, that'll be added shortly. i'll have to stea.. i mean, borrow a wowhead icon for it. The main reason i havent done this in the past is because I didnt want to have to add any additional files. Just a simple XML upload and that was it.

Cool stuff!

I really have to thank you for doing this, I've been pulling my hair out for a couple of weeks with the old generic ItemStats 1.5.5 and a wowhead update I found on the eqdkp forums. Not a single item would work correctly or add to the db and images wouldn't show, it was just a mess.

Removed all that crap, uploaded this and ta-da, all working again! So major Kudos to you dude. I'm sure people won't mind uploading just one image, and its a nice touch for the not so savvy users on our forums.

sweede
01-29-2008, 08:22 PM
Cool stuff!
I'm sure people won't mind uploading just one image

It wasnt as hard as i thought, but i'm sure that if one of the vbb guys looks at my plugin they'd be like "OMG This is how you do it!!!" and then write like, a single line that takes care of what it took me 40 lines.

Anyways, expect an update later today or early tomorrow.

mikeylikesitz
01-29-2008, 08:29 PM
any word on the IE issue, i wasnt too worried about it at first but i ended up with 25-30 members complaining at me about not being able to get to the site because of the operation aborted error. I really like this mod and want to use it but i cant until i get it figured out.

sweede
01-29-2008, 08:42 PM
any word on the IE issue, i wasnt too worried about it at first but i ended up with 25-30 members complaining at me about not being able to get to the site because of the operation aborted error. I really like this mod and want to use it but i cant until i get it figured out.

I had made a post ealier about what i found on wowhead.com

Looking at the code on your site, http://www.gamersvault.net , I noticed that you have
<base href="http://www.gamersvault.net/forum/" /> Immediatly after the opening <head> tag.

Downloaded the latest version 0.3.7a , install it and then check the source code for your site. It should look like
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html dir="ltr" lang="en">
<head>
<!-- WoWHead Mouseover-Tooltips -->
<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>
<!-- /WoWHead Mouseover-Tooltips -->
.. bunch of other stuff ...
<base href="http://www.gamersvault.net/forum/" />
.....

mikeylikesitz
01-29-2008, 11:14 PM
Ill try the new version and report back. As a note, i havent had an issue with my IE 7 on vista. I would rather they all use firefox but i cant make them change.

sweede
01-30-2008, 12:40 AM
When i view your source (visiting your testing item links page), i see

<head>
<base href="http://www.gamersvault.net/forum/" />
<!-- WoWHead Mouseover-Tooltips -->
<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>


When i visit a thread w/ on my forum

<head>
<!-- WoWHead Mouseover-Tooltips -->
<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>
<!-- /WoWHead Mouseover-Tooltips -->



I think the template is SHOWTHREAD,

for example, my template is
$stylevar[htmldoctype]
<html xmlns="http://www.w3.org/1999/xhtml" dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>

$headinclude
...............


you have the base tag before the headerinclude, which is causing the problem.

sweede
01-30-2008, 12:48 AM
I plan on adding support for spells ( http://www.wowhead.com/?spell=20201 ) tomorrow
Arcanite Rod, etc

mikeylikesitz
01-30-2008, 04:37 AM
i think i narrowed it down, it seems to be a vbSEO confliction


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html dir="ltr" lang="en">
<head>
<!-- WoWHead Mouseover-Tooltips -->
<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>
<!-- /WoWHead Mouseover-Tooltips -->
is with the vbSEO product disabled


<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html dir="ltr" lang="en">
<head>
<base href="http://www.gamersvault.net/forum/" />
<!-- WoWHead Mouseover-Tooltips -->
<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>
<!-- /WoWHead Mouseover-Tooltips -->is with the vbSEO product enabled.

Both were taken from the same thread as i noticed it wasnt an issue on my dev server which does not have vbseo enabled.

Caerydd
01-30-2008, 07:45 AM
Spell support :O Genius!

CremeEgg
01-30-2008, 09:56 AM
I plan on adding support for spells ( http://www.wowhead.com/?spell=20201 ) tomorrow
Arcanite Rod, etc

Sounds ace, I noticed that it already works with http links to spells, but yeah would be great to see it with spell tags too.

Don't forget to add it to the editor :p

Evolution06
01-30-2008, 07:43 PM
How come I get this error code while uploading the product to 3.6.8?

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/rdarena/public_html/forums/admincp/plugin.php(1970) : eval()'d code on line 4

sweede
01-30-2008, 11:24 PM
How come I get this error code while uploading the product to 3.6.8?

Parse error: syntax error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in /home/rdarena/public_html/forums/admincp/plugin.php(1970) : eval()'d code on line 4


hmm..

It's to bad that it couldnt give me more information about whats going on here but i think i have an idea.

Expect a minor update tonight.

Evolution06
02-01-2008, 04:26 PM
Did you have time to do the update? Just wondering I mean it seems to work fine but I hate uploading stuff when it gives me a error.

sweede
02-01-2008, 09:41 PM
Ya, i havent had time to get it updated. having work ftw .

I noticed a slight issue before i do the next update and i want to get the VBSEO thing figured out.

Right now when you enter an item and make a new post, all is well. However if you go to Edit that post later, the item name (Belt of Blasting ) has changed to the itemid instead ( 42423 )

While the item mouseover itself is not effected in any way, it's something that isnt needed if you're trying to update say, a list of loot received in raids.

Saturday morning (i swear!) , i'm going to update it so that it changes Belt of Blasting to Belt of Blasting . This way you won't run into an issue in the event you want to link a Warglaive (or any item that has duplicate name)

sweede
02-04-2008, 04:49 AM
i think i narrowed it down, it seems to be a vbSEO confliction

Both were taken from the same thread as i noticed it wasnt an issue on my dev server which does not have vbseo enabled.

VBSeo uses supplied methods of adding the base tag to the template cache. I'll ask on the vbseo forums if its possible to get around the issue.


Sounds ace, I noticed that it already works with http links to spells, but yeah would be great to see it with spell tags too.

Don't forget to add it to the editor :p

Added the item link to the editor (type a name, highlight it and hit the wowhead icon). Support for spells won't be available at this time because wowhead doesnt supply a XML feed for spells, just items. I may build a database of spells w/spell IDs though, but it wont happen right now.

Did you have time to do the update? Just wondering I mean it seems to work fine but I hate uploading stuff when it gives me a error.

I removed the part that i think was giving the error. it was install code that removed plugin that i added via database, which isnt really needed.

CremeEgg
02-04-2008, 06:52 AM
Awesome stuff! Thanks again.

Wayne Luke
02-04-2008, 11:15 PM
hmm..

It's to bad that it couldnt give me more information about whats going on here but i think i have an idea.

Expect a minor update tonight.
I don't know if you got that error fixed but unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING simply means you have an unclosed string somewhere.

sweede
02-04-2008, 11:34 PM
I don't know if you got that error fixed but unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING simply means you have an unclosed string somewhere.

Ya, but the question was where. While the issue was easy to find, it isnt obvious as to what module or hook the error is happening in. you have to review source code to find that the eval call thats throwing the error is part of the plugin install routines, etc.

Of course, there isnt anything you can do about it in vbulletin. I don't think php has (or can) added that type of error handeling to where it will tell you the info you need.

Caerydd
02-05-2008, 04:57 AM
new upate working great for me :)

sweede
02-05-2008, 07:50 PM
For those that have been visiting my site, http://dramaloot.com/ , you may have noticed the vbadvanced block above the news.

i've taken that mod and cleaned it up to upload here to vb.org ,
Stay tuned for that !

CremeEgg
02-05-2008, 11:52 PM
For those that have been visiting my site, http://dramaloot.com/ , you may have noticed the vbadvanced block above the news.

i've taken that mod and cleaned it up to upload here to vb.org ,
Stay tuned for that !

The progresson chart? That would be ace.

Also a bit off topic but I have a question for you, on your Officers and CL's page how did you create those mouse overs?

Oh and I have another favor to ask, could you take a look at my question in the Form Hack mod? No one over theres seems to have an answer. https://vborg.vbsupport.ru/showthread.php?t=126676&page=59

sweede
02-06-2008, 12:29 AM
Also a bit off topic but I have a question for you, on your Officers and CL's page how did you create those mouse overs?


https://vborg.vbsupport.ru/showthread.php?t=169389

sweede
02-06-2008, 12:41 AM
Oh and I have another favor to ask, could you take a look at my question in the Form Hack mod? No one over theres seems to have an answer. https://vborg.vbsupport.ru/showthread.php?t=126676&page=59

I have an idea for that, but im raiding atm so it'll be a while.

Caerydd
02-06-2008, 08:16 PM
Definite donation coming your way, your work is fantastic :D

sweede
02-06-2008, 08:21 PM
i really need to get a new paypal account setup before people start sending me money !

Caerydd
02-07-2008, 07:09 AM
Yus, yus you do :P

Cinjun
02-07-2008, 01:39 PM
Sweede,

Man thank you for this. I was using the old Itemstats and found it to be very cumbersome and slow hitting Allakhazam. This is definitely a great plugin -- again thank you!

~C

BlackRabbit1971
02-11-2008, 03:55 AM
i really need to get a new paypal account setup before people start sending me money !

Yes... very muchly..

sweede
02-11-2008, 04:02 AM
i really need to get a new paypal account setup before people start sending me money !

not that i'm greedy or anything but i updated my paypal donation email address ;)

BlackRabbit1971
02-11-2008, 10:56 AM
not that i'm greedy or anything but i updated my paypal donation email address ;)

Clicked and sent ;)

sweede
02-12-2008, 09:06 PM
Good news everyone, i finally understood why if you rebuild your post cache, my custom bbcode tags arent updated.

Rebuilding the post cache will re-enable all existing item links again.

xxshatteredsoul
02-15-2008, 01:52 PM
I'm also working to get it where if you post a wowhead URL , instead of making the URL clickable, it grabs the item name from the URL and create the item link accordingly

i.e.
http://www.wowhead.com/?item=18609
turns into
Anathema

I have it working on my forums currently but i had to modify another addon entirely to get it to work.

When I try doing the following what you said I type "http://www.wowhead.com/?item=18609" in a reply and it just shows up as a url. When I type Anathema it shows up how its supposed to. Isn't the URL supposed to turn into [item]?

xxshatteredsoul
02-15-2008, 05:50 PM
I am also getting a Operation Aborted error in IE when I put my mouse over the item link which brings me to a Internet Explorer cannot display the webpage page I press back and it gives me the same error again when I put my mouse over it press back once more and it works. Can you fix this error or tell me if I forgot to do something besides upload the product file? I am using Internet Explorer 7

Caerydd
02-15-2008, 08:24 PM
weird, I was getting that message while I was at work, but only when I tried to browse to my gallery pages....

sweede
02-15-2008, 08:49 PM
I am also getting a Operation Aborted error in IE when I put my mouse over the item link which brings me to a Internet Explorer cannot display the webpage page I press back and it gives me the same error again when I put my mouse over it press back once more and it works. Can you fix this error or tell me if I forgot to do something besides upload the product file? I am using Internet Explorer 7

This happens when you mouse over a link before the page is fully loaded (including images).

sweede
02-15-2008, 08:56 PM
When I try doing the following what you said I type "http://www.wowhead.com/?item=18609" in a reply and it just shows up as a url. When I type Anathema it shows up how its supposed to. Isn't the URL supposed to turn into [item]?

Thats odd, you do have the latest version install right? It may be a conflict of another mod though..

xxshatteredsoul
02-15-2008, 09:07 PM
Thats odd, you do have the latest version install right? It may be a conflict of another mod though..

Yup just downloaded and installed today.

sweede
02-16-2008, 04:28 PM
Yup just downloaded and installed today.

Can you go to your plugin list page

http://underthemain.net/vbtest/admincp/plugin.php

and Ctrl+A , copy paste that whole list to me in a PM ?

Caerydd
02-17-2008, 10:03 PM
Okay, i can now report that this addon causes my photoplog installation to be inaccessible to IE users when wowhead bbcode is enabled. I disable the bbcode product and IE users are able to access the photoplog installation again. (I did a report to photoplog here: http://www.photoplog.com/forum/showthread.php?t=2140)

As you can see from the link, I found a bug in IE7 that causes this: http://support.microsoft.com/kb/927917/en-us

I don't know how many of my users use IE yet, we're still testing, but this is a fairly major down. I can't afford photopost atm. :(

xxshatteredsoul
02-17-2008, 10:59 PM
Ok I PMed you everything in my plugin.php let me know if you figure anything out.

Caerydd
02-20-2008, 04:58 PM
Seems to be a problem with where the wowhead script is placed.

http://www.wowhead.com/?forums&topic=7708

If placed before the base url thingy, it apparently stopped giving those errors.

Caerydd
02-20-2008, 05:03 PM
For me, specifically, it breaks it in gallery templates because for the gallery, and the gallery only, it goes after the line

<base href="http://athanatoi.quillsabroad.com/forums/index.php" />
<!-- WoWHead Mouseover-Tooltips -->
<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>

And it needs to go before it. Searching for a way to get it inserted before the base url, but not finding it :( (On forum pages it is inserted first.)

Double the edit. I fixed the problem by editing the shell_blank template

$stylevar[htmldoctype]
<html dir="$stylevar[textdirection]" lang="$stylevar[languagecode]">
<head>
<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>
$headinclude
<title>$pagetitle</title>
</head>
<body>
$header
$navbar

$html

$footer
</body>
</html>

Of course, I think I have the wowhead script url twice on my page now, so have to find where the addon inserts it >>

mikeylikesitz
02-20-2008, 11:07 PM
this is an ongoing issue with any mod that places the <base url=""> tag before the js causes this error, this was my issue because vbseo does the same. Hopefully either wowhead or sweede finds a fix work around

acrine
02-21-2008, 12:53 AM
I'm having the same IE issue and my page doesn't seem to have any of the issues that others listed. My wowhead script is right after the head tag on every one of my forum pages, yet I'm still having IE crash if you mouse-over an item before the page loads.

Anyone have any thoughts?

http://www.catalyst-raid.com/forum
is where my forum is.

Caerydd
02-21-2008, 05:25 AM
Until they do, the fix in my last post appears to eliminate th problem - place the script line BEFORE $headinclude in shell_blank template. This does not require you to remove what sweede's addon inserts.

Martinjepsen
02-21-2008, 01:08 PM
Im having troubles with the eqdkp hack, any page that should list an item, is going blank,
i think it might be the setting in vbulletin_wowhead.php that does this, but i'm not sure what to set it to.

sweede
02-22-2008, 08:13 AM
I'll have to go over the EqDKP addition and fix it.

As for the other problem, i think i might have a solution for it, but i couldnt test it because i didnt want to buy vbseo.

I do have a copy of photoblog but i dont use it. Since this mod also causes issues, i'll be able to fix the template issue correctly.

Just as a note, I generally don't want to have to have anyone modify templates to use this addon.

Caerydd
02-22-2008, 08:21 AM
^^ Thanks for keeping up sweede. I would prefer not to have the shell_blank template edit indeed, it was just a temporary solution that allowed me to have both functioning :)

:up:

Martinjepsen
02-22-2008, 11:28 PM
well i got them sorta working, but im getting : Fatal error: Call to undefined method SQL_DB::escape_string_like() in /forum/includes/init.php(329) : eval()'d code on line 30

http://dawning-guild.eu/dkp

i had to remove all the Function definitions in vbulletin_wowhead.php as it was firing them twice


Ive looked through the code in the vbulletin_wowhead.php and it seems to steal a lot of info from VB, but wouldn't it be simpler to just have it fetch the data directly from the database? now I'm not good at php or coding in general, so my opinion isn't worth much, I'm just looking for a solution that works.
Thank you for this great add-on.

sweede
02-23-2008, 01:41 AM
It should be importing the vbulletin global file and associated data such as the database class and vbulletin registry. The main reason i did this is so that you wouldnt have to configure anything but the path in vbulletin_wowhead.php

i'll look at it later tonight / tomorrow morning and get an update out.

CremeEgg
02-29-2008, 09:29 AM
Just a quick post, have you put any thought into using WoWDB in a mod like this?

As far as I can see it's almost the same as WoW Head.

http://www.wowdb.com/syndication.aspx

sweede
02-29-2008, 09:35 AM
wowdb doesnt provide XML feeds of their items like wowhead does. to actually support wowdb i would have to hit wowhead (or the armory) to get the item id from the item name, then i can generate the code for wowdb.. but, why would you want to do that? If the item existed in say, wowdb and not in wowhead, your users would have to know the item ID before they can link it via wowdb.

BlackRabbit1971
02-29-2008, 09:40 AM
Yeah, what Sweede said..

CremeEgg
02-29-2008, 08:37 PM
wowdb doesnt provide XML feeds of their items like wowhead does. to actually support wowdb i would have to hit wowhead (or the armory) to get the item id from the item name, then i can generate the code for wowdb.. but, why would you want to do that? If the item existed in say, wowdb and not in wowhead, your users would have to know the item ID before they can link it via wowdb.

I didn't realise it was quite so shite a site. lol

xxshatteredsoul
02-29-2008, 09:42 PM
Ok I PMed you everything in my plugin.php let me know if you figure anything out.

Any luck figuring out how to fix this yet :)?

sweede
02-29-2008, 10:29 PM
Any luck figuring out how to fix this yet :)?

Man, im so sorry i have been working 12s a lot and havent had time to look at anything.

i'll look at it tonight after my wife goes to bed and i'm up wasting time so i dont ruin my sleep schedule.

sweede
02-29-2008, 10:38 PM
I didn't realise it was quite so shite a site. lol


The only cool thing i like about the wowdb site is the wishlist builder thing. everything else is exactly like wowhead except flashier and "larger".

wowhead.com is also am infinetly faster website. The original creator of the website did not get the full value of the website when he sold it.

sub_ubi
03-06-2008, 06:38 AM
Anyone have this running on 3.7?

sweede
03-06-2008, 10:36 AM
works fine on 3.7 , when i added this to vb.org 3.7 wasnt out. i didnt feel the need to create a duplicate entry for vbb 3.7

Wayne Luke
03-06-2008, 05:41 PM
Does this version do spell linking as well?

samual
03-06-2008, 09:45 PM
Any instructions on install? Very new to all this. Thanks.

samual
03-06-2008, 11:49 PM
Never mind got it!!

Caerydd
03-07-2008, 10:49 AM
Does this version do spell linking as well?

No, sweede said that wowhead does not provide xml for spells yet.

andrewkhunn
03-11-2008, 08:35 PM
Seems to be a problem with where the wowhead script is placed.

http://www.wowhead.com/?forums&topic=7708

If placed before the base url thingy, it apparently stopped giving those errors.

You definitely need to get this fixed. The reference to the Wowhead JavaScript widget needs to be before the base declaration in vBulletin. Brought down a bunch of my users today before I randomly remembered reading about this in this thread.

I ended up fixing it by just caching the external JavaScript locally for now. Looking into a more elegant solution presently.

andrewkhunn
03-12-2008, 07:30 AM
This was more insidious than I had imagined. Not only is there a conflict with base and the external script, but apparently modifying the headers while a page is loading (which is exactly what this plugin attempts to do) causes the operation aborted error as well.

More details here: http://shauninman.com/archive/2007/04/13/operation_aborted

sweede
03-12-2008, 11:20 AM
I don't know why, but i am completly unable to reproduce the issue in IE 7.0. It really limits my ability to test and debug this issue completly.

Also, my plugin doesnt modify the headers in IE. It modifies the headers in PHP memory before IE even knows it exists. This isn't the source of the error.

It's the wowhead javascript file that is the apparent problem. It also appears that a possible solution is simply adding a </base> tag to close off the <base> tag.

For those who do and can reproduce this issue, try modifying the wowhead_headerinclude template and add </base> to the very first line (before <!-- WoWHead Mouseover-Tooltips --> )

and let me know how that works for you ?

Caerydd
03-12-2008, 05:05 PM
I found that users with different permissions for photoplog also caused the error.

I'm just installing the vbsurvey tool atm, will try your fix after that's done.

andrewkhunn
03-12-2008, 05:28 PM
I don't know why, but i am completly unable to reproduce the issue in IE 7.0. It really limits my ability to test and debug this issue completly.

Also, my plugin doesnt modify the headers in IE. It modifies the headers in PHP memory before IE even knows it exists. This isn't the source of the error.

It's the wowhead javascript file that is the apparent problem. It also appears that a possible solution is simply adding a </base> tag to close off the <base> tag.

For those who do and can reproduce this issue, try modifying the wowhead_headerinclude template and add </base> to the very first line (before <!-- WoWHead Mouseover-Tooltips --> )

and let me know how that works for you ?

Yeah, I completely removed your insertion into the header by disabling the specific hook and added the entries in manually with a locally cached copy of power.js...and I am still having issues.

Trying your fix now as well. I'll report back here with results.

andrewkhunn
03-12-2008, 06:31 PM
Adding </base> at the top of the default template worked for me. Dirty workaround though. :)

mikeylikesitz
03-13-2008, 12:51 AM
it doesnt seem to be an issue with IE7 except in rare rare instances, this seems to be pointed to older IE such as IE 6 which apparently quite of my users still use.

maelfius
03-25-2008, 04:53 AM
I am also seeing the vbulletin SQL_DB::escape_string_like errors. A Fix for this would be greatly appreciated.

Unless most of the functions that are defined in vbulletin_wowhead.php (that are duplicated by the vbulletin plugin) are commented out, you get duplicate defined functions. With the functions commented, SQL_DB::escape_string_like errors occur.

This appears to indicate the use of EQDKP hack and the use of the vbulletin mod are mutually exclusive.

jluerken
03-25-2008, 09:36 AM
Is there a way that the items can be shown in German?

sweede
03-25-2008, 09:53 AM
I am also seeing the vbulletin SQL_DB::escape_string_like errors. A Fix for this would be greatly appreciated.

Unless most of the functions that are defined in vbulletin_wowhead.php (that are duplicated by the vbulletin plugin) are commented out, you get duplicate defined functions. With the functions commented, SQL_DB::escape_string_like errors occur.

This appears to indicate the use of EQDKP hack and the use of the vbulletin mod are mutually exclusive.


The error is most likely because the database class object in EqDKP and Vbulletin share the same name ($db). to work around this, i unset the $db variable and reference the vbulletin DB exclusivly , $vbulletin->db->



Since i do not care about eqdkp data, I had to some how force eqdkp to go into the vbulletin class to pull the data from the database. Since most likely your EqDKP installation and your vbulletin installation will be in different directories (i.e. /forums and /eqdkp ), i have to change the php script local path (via chdir) to the vbulletin directroy, run all of the stuff i need to, then change back to EqDKP.

Currently i have on line 25,
unset($db);

Perhaps i should have this before the init.php include from vbulletin.

Please try removing line 25 and placing the following;
before line 13.

$olddir = getcwd();
$eqdkp_db = $db; // Save EqDKPs database object
unset($db); // delete current EqDKP object

before line 180 (before chdir($olddir); )

unset($db); // Delete current Vbulletin Object (we are done with it)
$db = $eqdkp_db; // Copy EqDKP object back to default
unset($eqdkp_db); // Unset copy of EqDKP Object
chdir($olddir);

I really can't think of a work around other than re-writing EqDKP and intergrating it within Vbulletin. Not something i think i am prepared to do at this time.

sweede
03-25-2008, 10:11 AM
Is there a way that the items can be shown in German?

I don't know if i can or not.
the plugin works as follows;

https://vborg.vbsupport.ru/showpost.php?p=1414424&postcount=36

the question i would have for you, is that if you visit wowhead.com, is the website in german or english ?

sweede
03-25-2008, 10:12 AM
Adding </base> at the top of the default template worked for me. Dirty workaround though. :)

This is good news i think :) , i'll have an update here soon and address that issue.

sweede
03-25-2008, 02:18 PM
For those that are having issues, would you please revert any work aroudns you may have done and try the following.



Plugins & Products -> Add New Plugin

Product WoW Head ItemStats
Hook Location global_complete
Title Wowhead Itemstats base tag fix
Plugin PHP Code
$output = preg_replace("/(<base href=\".*\">)/",
"\\1</base>",$output);


Thank you.

ssslippy
04-04-2008, 10:48 AM
If you edit a post the item bold disapears.
Also I tried doing the above edit however is there a way to avoid the IE error if the page has not finished loading?

Is there a way to make it so the links dont function till the page loads.

sweede
04-04-2008, 11:30 AM
If you edit a post the item bold disapears.


https://vborg.vbsupport.ru/showpost.php?p=1397392&postcount=21

The Ajax editor doesnt understand what is going on since i take the item bbcode and turn it into a URL. when you edit or make a post with the WYSIWYG editor interface, it just thinks your making a normal URL type bbcode tag and drops the css information about the item link

ssslippy
04-05-2008, 01:58 AM
So any advice on how to avoid the IE crashes when u mouseover a link?

OLDrCF
04-05-2008, 03:16 AM
Installed this mod on 3.6.9 and it's buggered the site, can't access it or the admin panel, error get is:

Fatal error: Cannot redeclare http_get() in ......../includes/init.php(336) : eval()'d code on line 60

Can any help me getting this fixed pleasE?

ssslippy
04-05-2008, 04:44 AM
OLDrCF is your host not allowing remote file calls?

OLDrCF
04-05-2008, 05:50 AM
According to them Fsockopen was enabled (if that's the one) but not sure otherwise ... I just want to remove the mod and get the forums working at this stage and will investigate further afterwards.

sweede
04-05-2008, 11:04 AM
Your issue has nothing to do with remote file calls, but something that i should not have done in the first place.

First, lets get rid of your issue. To do this we're going to have to disable the plugin in SQL itself.
Open up phpmyadmin or some other tool to log into your vbulletin forum database.

Run the following:

UPDATE PREFIX_plugin SET active = 0 WHERE product = "wowhead_itemstats"

Replace "PREFIX_" with the prefix of your tables set in the config.php (usually vbb_)

Once this is done, you should be able to log into your admin panel once again.

I have updated my product so that if you have an existing plugin that already contains a function called "http_get" you wont run into the same issue as OLDrCE.

sweede
04-05-2008, 11:08 AM
So any advice on how to avoid the IE crashes when u mouseover a link?


Unfortunately i do not. I have not been able to reproduce the issue effectively enough to properly create a work around.

Look through this thread though, there might be some info buried in here that i may have missed.

OLDrCF
04-07-2008, 06:56 AM
Well I ended up just nuking the site and going from an older backup. I'll have another crack at it this week and let you know how I get on sweede - although this time I'll be backing up before I do anything :D.

AFMichael
04-07-2008, 11:25 AM
I'm assuming that this requires EqDKP to be installed?

Caerydd
04-07-2008, 04:34 PM
it does not ned eqdkp at all.

ssslippy
04-08-2008, 05:12 AM
Unfortunately i do not. I have not been able to reproduce the issue effectively enough to properly create a work around.

Look through this thread though, there might be some info buried in here that i may have missed.

To duplicate this issue is quite easy. If the page has not finished loading mouse over the link and your IE will crash.

sweede
04-08-2008, 06:27 AM
My problem is that in IE 8.0 (even in IE 7.0 compat mode), it does NOT cause an operation aborted error. even before, my page loads were always -very- fast as i never used graphics heavy skins.

http://support.microsoft.com/default.aspx/kb/927917

However, IE 8.0 always displays this inconsistancy so i can test possibilities until the error goes away.

So, reading the KB article and another source, the script tag in HTML 4.0 has an attribute called "DEFER"

http://www.htmlcodetutorial.com/scripts/_SCRIPT_DEFER.html

Loading up the wowhead_headerinclude template and simply adding "DEFER" in the script tag caused the error message to go away.

<script DEFER src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>

Please verify that it works by visiting http://underthemain.net/forums/showthread.php?p=12 , refreshing teh page while trying to mouse over any item links

sweede
04-08-2008, 06:29 AM
I'm assuming that this requires EqDKP to be installed?

It is completly independant of EqDKP and as said above, does not use any of its functionality.

I will though, be adding EqDKP back to my test site and re-writing some of EqDKP to better intergrate with this mod for those that use both on their guild sites.

ssslippy
04-09-2008, 01:25 AM
Sweede, GENIUS. It works wonders. Got it working on my test sie with the code.

Also not after doing some research I believe the proper way is to use:

<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript" defer="defer"></script>

Masked Crusader
04-10-2008, 07:00 PM
Hey Sweede --

The BBCode icon for the [item] tag is now broken. Apparently the wowhead link is no longer valid.

Can you please let me know where I should update the link and what I should update it to?

Thanks.

sweede
04-10-2008, 09:07 PM
You mean the icon you click when making a post to wrap the [item] tag around the selected text?

http://www.wowwiki.com/images/6/6e/Icon-wowhead-22x22.png

but that should still work.

that is added to teh toolbar in the WoWhead - Adds Icon to toolbar plugin.

Sixpack
04-11-2008, 12:55 AM
Sweede!

Nice mod, working well.. Just one query though - I am running a forum with a white backdrop, and was hoping that somehow I could edit the colour of the basic/low quality items, to a darker scale? At the moment they are coming up white (aka flasks, potions, leathers etc) and I would love if it could come up as a different colour, something more readable!!

Any Ideas? Help would be appreciated!!

ssslippy
04-12-2008, 10:32 AM
One more request, can this mod also create the bbcode for spell linking. Wowhead already supports it however I appreciate how this mod doesnt require the item #.

sweede
04-12-2008, 10:43 AM
One more request, can this mod also create the bbcode for spell linking. Wowhead already supports it however I appreciate how this mod doesnt require the item #.

https://vborg.vbsupport.ru/showpost.php?p=1435836&postcount=83

sweede
04-12-2008, 10:57 AM
Sweede!

Nice mod, working well.. Just one query though - I am running a forum with a white backdrop, and was hoping that somehow I could edit the colour of the basic/low quality items, to a darker scale? At the moment they are coming up white (aka flasks, potions, leathers etc) and I would love if it could come up as a different colour, something more readable!!

Any Ideas? Help would be appreciated!!


I added a color "configuration" to this by adding CSS that overrides the wowhead default css.

vbulletin options -> wow head item stats

the common item color, i found that #444444 works well.

Hopefully it still overrides the imported CSS from the wowhead tooltip script.

KURTZ
04-13-2008, 11:01 PM
Swede just wondering is it compatible onto 3.7.x?

sweede
04-13-2008, 11:31 PM
havent had any issue with it.

KURTZ
04-14-2008, 10:37 AM
OK thx Sweede :) i'll try ...

KURTZ
04-16-2008, 03:01 PM
OK, just tested onto 3.7.x and it runs ... anyway i've a question Sweede, i don't understand the 'read me' file ... where i should do these edits?

sweede
04-16-2008, 03:11 PM
There was a readme file?

you should only have had to import the XML file. the zip file attached was for something totally different

KURTZ
04-16-2008, 03:26 PM
There was a readme file?

you should only have had to import the XML file. the zip file attached was for something totally different

yes there is a read me.html into your package ...

sweede
04-16-2008, 03:31 PM
[----------------------------------------------------------------------------]
[ For the EqDKP + vBulletin Users,
[ i've whipped up a quick script to add the wowhead power tooltips to your
[ EqDKP installation and makes use of the already cached item info from your
[ existing table provided by this mod.
[
[ The attached zip file will contain the php file you need to upload to the server
[ and the edits that are required to complete the changes.
[
[ Enjoy !


unless you are using EqDKP, you do not use the zip file.

ssslippy
04-17-2008, 02:01 PM
I attempted to the EQDKP setup and it caused 500 server errors. I was unable to locate anything in the apache logs or the mysql logs.

The edits in the following are off and dont follow the pattern of the line they are replacing.
viewmember.code
viewevent.code
viewraid.code

KURTZ
04-21-2008, 02:47 PM
Sweede is possible to implement an option which can allow the usage of this code only to a specific UG?

quarum
04-22-2008, 01:33 PM
I have this working on my site - but it is not respecting the colors - it seems to take the colors from the sites defatul css and not from the WoWHead css.

Mouseovers work great - I love this - but would like the colors to display properly. Any thoughts?

My site is at www.argoswow.com

(and yes, I am a vBulletin noob - just switched the site over yesterday - so please be nice to me until I understand all this.)

Have fun!

sweede
04-22-2008, 04:04 PM
you are of course refering to the pasting of wowhead item urls (http://www.wowhead.com/?item=29759) into the editor box as opposed to typing out Ruby Slippers instead ?

I noticed this on my site to but havent had time to fully investigate it.

quarum
04-22-2008, 04:09 PM
If I use Ruby Slippers the mouse over works great - pops up with all the info, however the color is not being displayed purple, like the Epic is set to display. It is just holding the standard colors of my skin.

TruthElixirX
04-22-2008, 10:00 PM
The EQdkp part is still broken, any help? I get this:



Warning: include_once(./vbulletin_wowhead.code) [function.include-once]: failed to open stream: No such file or directory in /home2/berserk/public_html/wow/tier6dkp/common.php on line 20

Warning: include_once() [function.include]: Failed opening './vbulletin_wowhead.code' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home2/berserk/public_html/wow/tier6dkp/common.php on line 20

sweede
04-22-2008, 10:16 PM
The EQdkp part is still broken, any help? I get this:



Warning: include_once(./vbulletin_wowhead.code) [function.include-once]: failed to open stream: No such file or directory in /home2/berserk/public_html/wow/tier6dkp/common.php on line 20

Warning: include_once() [function.include]: Failed opening './vbulletin_wowhead.code' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home2/berserk/public_html/wow/tier6dkp/common.php on line 20



Sorry but that has nothing to do with my plugin.

sweede
04-22-2008, 10:19 PM
If I use Ruby Slippers the mouse over works great - pops up with all the info, however the color is not being displayed purple, like the Epic is set to display. It is just holding the standard colors of my skin.

Install this plugin,
https://vborg.vbsupport.ru/showthread.php?p=1496875

Update to 0.4.3 of Wowhead Item tooltips

Go to admincp ->options -> WoW item stats options -> enable debugging

Create a new post with an item in it ( Ruby Slippers or http://wowhead.com/?item=33585 ).

go to admincp -> devlog , click on the wow item stats click, click on "wowhead_build_url"

that should look like
<a class="q1" style="text-decoration: none; font-weight: bold;" href="http://www.wowhead.com/?item=34414" target="_blank">[Shattered Sun Banner]</a>

quarum
04-22-2008, 11:21 PM
Okay - its working - but I have noticed that when you edit the post - that seems to be when it stops working.

Any thoughts?

Basically the first time I post - it is fine - if I go back and edit the post - then it seems to be defaulting back to the standard text colors of the theme. The only way to get it back is to delete the post and make a totally new post. Something in the formatting of the post when it gets edited might the culprit?

sweede
04-22-2008, 11:53 PM
Please re-read the mod description. i added a note about your issue.

quarum
04-23-2008, 11:03 AM
Perfect - thanks for everything!!!!!!!!!

TruthElixirX
04-23-2008, 11:34 AM
Sorry but that has nothing to do with my plugin.

It does though, from your readme.html:


common.code
add
Code:

include_once( $eqdkp_root_path . "vbulletin_wowhead.code");

after
Code:

setcookie('herefirst', 'yes');





And the error is saying


Warning: include_once(./vbulletin_wowhead.code) [function.include-once]: failed to open stream: No such file or directory in /home2/berserk/public_html/wow/tier6dkp/common.php on line 20


Which means it cannot locate the file for some reason, and when I add the full path of the file it starts telling me it cannot redeclare functions. This is from the EQdkp add on.

sweede
04-23-2008, 12:23 PM
wtf?

in the entire readme.html file, every instance of the characters php was changed to code :|

TruthElixirX
04-23-2008, 01:34 PM
wtf?

in the entire readme.html file, every instance of the characters php was changed to code :|

Yeah...

I'm acrtually installing this on a EQdkp set up for someone else. I thought maybe there were different versions of EQdkp (as in perl, php, coldfusion, asp, etc ) and that the .code thing meant EQdkp would automaticlly replace it.

So, uh, should I uninstall it from the EQdkp setup?

sweede
04-23-2008, 01:50 PM
change all references of .code to .php and it may work. you may have to do some additional work though depending on your specific eqdkp setup.

TruthElixirX
04-24-2008, 10:54 PM
I'm now getting this error:



Fatal error: Cannot redeclare itemstats_parse() (previously declared in /home2/berserk/public_html/wow/tier6dkp/vbulletin_wowhead.php:139) in /home2/berserk/public_html/forums/includes/init.php(329) : eval()'d code on line 37

sweede
04-25-2008, 12:38 PM
hmm.. i wrote the vbulletin_wowhead.php file quite some time ago, before i re-worked the item stats plugin.

I updated the plugin and the zip file, please try those.

TruthElixirX
04-26-2008, 05:39 PM
New problem:


Parse error: syntax error, unexpected ')' in /home2/berserk/public_html/wow/tier6dkp/vbulletin_wowhead.php on line 38



Line 34-39:


function itemstats_parse($item)
{
$o = new wowhead();
$o->debug($item_name,"itemstats_parse");
return $o->wowhead_parse($item));
}

I believe wowhead_parse($item)); needs to be wowhead_parse($item);.

I took out the extra ) and it now does this:



Fatal error: Cannot redeclare itemstats_parse() (previously declared in /home2/berserk/public_html/wow/tier6dkp/vbulletin_wowhead.php:34) in /home2/berserk/public_html/forums/includes/init.php(329) : eval()'d code on line 37

sweede
04-26-2008, 08:33 PM
You didnt install the new XML file

TruthElixirX
04-27-2008, 01:31 AM
You didnt install the new XML file

>.>
<.<

D'oh.


It appears to be working now. Thanks!

comicus
04-29-2008, 04:58 PM
Hey there. I've been a big fan of this mod for awhile now!

does this work with 3.7? Thanks!

sweede
04-29-2008, 05:01 PM
Yes, Now that 3.7 is out i will most likely create a new project thread in the 3.7 section also.

comicus
04-30-2008, 02:36 AM
faaantastic! thanks. =)

BlackRabbit1971
05-01-2008, 11:12 AM
Sweede, the .js has been updated (http://www.wowinsider.com/2008/04/30/wowhead-power-updated/) and a forced reload of it by the end user is required before your addon will work again..

I'd sugest a change in your xml...

<template name="wowhead_headerinclude" templatetype="template" date="1207639601" username="sweede" version="0.4.1"><![CDATA[<!-- WoWHead Mouseover-Tooltips -->
<script src="http://www.wowhead.com/widgets/power.js"

To:

<template name="wowhead_headerinclude" templatetype="template" date="1207639601" username="sweede" version="0.4.1"><![CDATA[<!-- WoWHead Mouseover-Tooltips -->
<script src="http://www.wowhead.com/widgets/power.js?lol"

Can you think of a way to set something in Admin to force an update? rather than an xml update in future?



Anyone wanting to quick fix..

Under "Styles & Templates" go to the (WoW Head ItemStats Templates >> wowhead_headerinclude template and find

<script src="http://www.wowhead.com/widgets/power.js" type="text/javascript"></script>

Replace with:

<script src="http://www.wowhead.com/widgets/power.js?lol" type="text/javascript"></script>

(please note that you'll have to repeat this for each template you use)

I hope this helps... and thanks again Sweede for such a cool addon.

sweede
05-01-2008, 01:05 PM
This isn't something that most people should ever have to do.

The browser cache should keep the power.js file up to date since the request for the file (should) always be http:://www.wowhead.com/widget/power.js . you can view your own browsers file cache and see that there (should) is only one copy of the above file and view it's last modified (downloaded) time.

Now, im not saying dont do this or you're wrong to do this, it's just that this isnt a reason to update the plugins XML file.

I also cannot find anywhere on the wowhead.com site that describes anything that wowinsider claims.

BlackRabbit1971
05-01-2008, 03:01 PM
After taking a closer look, its true that the .js file will get renewed when it times out/ your browser fetches the new version. This can take time and if you have a user base that likes everything working and not have to wait then this is a quick fix and does work.. I do agree it isn't worth updating the xml.

The older cached js file won't break anything on your boards but it will not show any hover information either, stating that the item can't be found. :(

So, you have 2 options really, you can wait and eventually the .js file will be fetched by your users browsers and start working again YAY! or you can temp change the template and force your users browsers to download the new js file. I guess it all depends on what your users are like and how much they whine at you. lol

Deepdog009
05-03-2008, 12:49 PM
Sweede I've been looking at the WOWhead javascript and I have a few ideas...

Let me test them and then I will post my findings here... L8ter;)

Danoxth
05-03-2008, 10:49 PM
Just put this over to my 3.7 board and works a treat, however I do have one issue.

On the posting box the button which brings up instant Item tags does not have an image.

It appears as if its pointing to WoW Wiki, more specificly to "http://www.wowwiki.com/images/6/6e/Icon-wowhead-22x22.png"

How would I go about editing this so I can have it pointing to an image on my own server?

Thanks for any help in advance!

Deepdog009
05-04-2008, 12:08 AM
Here are some minor adjustments that i've been playing around with...

unzip and view testertips1.html

I tested with Sweede's mod and it works Ok...

ssslippy
05-04-2008, 05:54 PM
The wowwiki relocated the image. You should not be using others bandwith to host any image. This package should be updated to include the image if u are allowed to, and then the code be updated to point to that.

KURTZ
05-04-2008, 09:19 PM
i put mine onto my ftp ... :)

sweede
05-04-2008, 10:03 PM
Wowwiki merged with wikia as it's primary wiki backend / host

the new URL is
http://images.wikia.com/wowwiki/images/6/6e/Icon-wowhead-22x22.png

Plugins & Products -> Plugin Manager

Search for "WoWhead - Adds Icon to toolbar" and edit

the 3rd line in the plugin, change to
$wowhead_itemcode[buttonimage] = "http://images.wikia.com/wowwiki/images/6/6e/Icon-wowhead-22x22.png";

Danoxth
05-05-2008, 01:57 PM
Problem solved, thanks!

Like KURTZ I just popped it on my server :)

sweede
05-05-2008, 11:08 PM
Here are some minor adjustments that i've been playing around with...

unzip and view testertips1.html

I tested with Sweede's mod and it works Ok...

Thats an interesting use. I'm not sure what practicale uses it would have ;) but i can see people wanting to use it for spoiler text or something like that

Kinneas
05-08-2008, 11:37 AM
Thanks for this :)

Sadly Gryphon's version stopped working for me all of a sudden and I haven't been able to fix it. This works just fine though.

sweede
05-17-2008, 07:28 PM
Ive updated this mod to include a fix for editing a post with an item link and having the WYSIWYG editor enabled.

The item links are still represented by "html" links in the editor, but when the post is saved, the item links retain their item color information.

djbass
05-18-2008, 01:32 AM
The item links are still represented by "html" links in the editor, but when the post is saved, the item links retain their item color information.

They can be easily edited in their "html" form anyway by using the toggle button for the WYSIWYG editor.

80844

With the update they will seamlessly change between the two formats.

sweede
05-18-2008, 01:59 AM
They can be easily edited in their "html" form anyway by using the toggle button for the WYSIWYG editor.

80844

With the update they will seamlessly change between the two formats.

Editing the HTML in the WYSIWYG mode could remove the class tag and cause the old behavior.

I do have an update that should fix that though.

ssslippy
05-18-2008, 03:22 AM
What happened to the EQDKP intergration?

quarum
05-19-2008, 08:18 PM
I noticed today that my RSS feeds had not imported for a couple days. So I ran them manually. WHen I ran them I got this error:

Fatal error: Cannot redeclare parse_wysiwyg_item() (previously declared

in /home/content/html/vb/includes/functions_wysiwyg.php(115) : eval()'d code:3)

in /home/content/html/vb/includes/functions_wysiwyg.php(115) : eval()'d code on line 21

I posted on the vB main site and they said disable plugins. I started disabling them one at a time, ran the RSS and my RSS feeds started again when I disabled all the WoW Head ItemStats Plugins.

I am guessing that it has something to do with the WoWHead WYSIWYG parser.

vB 3.70. I pull down 4 RSS feeds from different WoW sites. Let me know if you need more info.

Thanks

sweede
05-19-2008, 08:31 PM
This should be fixed in teh 0.4.5a version

quarum
05-19-2008, 09:48 PM
This should be fixed in teh 0.4.5a version

I uninstalled the mod - then reinstalled the 45a. Added a new RSS feed, ran the RSS task and got this error:

Fatal error: Call to undefined function parse_wysiwyg_item() in /home/content/html/vb/includes/functions_wysiwyg.php on line 622

I disabled WoWHead WYSIWYG parser and the RSS feed imported.

freebase69
05-20-2008, 08:06 AM
Your fix didn't fix it. I'm getting the wysiwyg error as well. I did the upgrade, even though it was still working fine, and when I tried to post a new thread I got an error. I disabled this hack a viola, issue gone.

Take another peek at the code please. I'd hate to have to pull the plug on this one.

sweede
05-20-2008, 10:51 AM
I added a new RSS feed and ran the task and got the same errors. I fixed a few things, ran the task again and it completed as expected.

0.4.5B

Btw, a new version will be out soon that will support pasting of wowhead URLS for Spells and Quests to link in the forums. More info on that later.

quarum
05-20-2008, 11:29 AM
I added a new RSS feed and ran the task and got the same errors. I fixed a few things, ran the task again and it completed as expected.

0.4.5B

Btw, a new version will be out soon that will support pasting of wowhead URLS for Spells and Quests to link in the forums. More info on that later.

Just updated to 0.4.5B and RSS working again - thank you so much for the fast reply.

Looking forward to that next addition you are working on - thanks again!

Enjoy your day!

freebase69
05-25-2008, 11:59 PM
Well it seems to be working again. Thanks for the update Sweede.

ssslippy
06-13-2008, 12:04 AM
I had someone post 35 item links and gave me a 500 error. Any idea on how I can avoid this?

sweede
06-13-2008, 12:18 AM
we'll, seeing as how i'm not psycic or whatever, i havent any clue what caused the 500 error. it could have been an apache crash , php crash, permission error, corrupted data sent to my product or an error that isnt caught and is causing output buffering to fail.

It may not even be my product but some other product but because you're using [item] tag you assume it's my product.

In otherwords, Need more Info.

Kinneas
06-16-2008, 09:07 AM
Btw, a new version will be out soon that will support pasting of wowhead URLS for Spells and Quests to link in the forums. More info on that later.

Sounds awesome. Can't wait for this :D

KURTZ
06-16-2008, 09:18 AM
Sweede, i'm wondering: why you don't release this for 3.7.x?

Kinneas
06-16-2008, 10:49 AM
Far as I can see this still works perfectly on 3.7.x :)

sweede
06-17-2008, 11:59 AM
Sweede, i'm wondering: why you don't release this for 3.7.x?

It will work without issues on 3.7. Although it's probably a mistake on my part, i don't feel the need to make a new post with the exact same information in another forum just yet.

Luxus
06-18-2008, 02:55 AM
does it works with de.wowhead.com (german version of wowhead?) i see a smf script that works with all languages!

sweede
06-18-2008, 10:30 AM
The next release will have the language support, but between work, setting up my 125 gallon fish tank in our apartment, leveling my hottie paladin and drinking, getting time to code the update ( it's quite a large re-write btw ) is hard to find.

I do work on it peice by peice and i will have one released soon (can't tm it cause it's tm'd by blizzard blue posters).

Caerydd
06-18-2008, 12:30 PM
Erm, we have just started using eqdkp, is there any way to apply these to an eqdkp installation that is separate to vbulletin? Also, the download for the eqdkp thing seems to be missing, unless I'm seeing things.

I really don't trust the old itemstats plugin, as it is no longer officially supported and is hacked to get wowhead.com tooltips >> If there is no way to use your script, Sweede, I'll just go with that but I thought I'd ask first.

sweede
06-18-2008, 12:52 PM
Here's a list of things on my todo.. list..

Create a Drop-In Replacement for ItemStats. I have installed EqDKP Plus and have been reverse.. "including", trying to find the key file that needs to be replaced and how to best code the replacement. This is the easy one and requires really only minor code changes to my current plugin.

Update with wowheads supplied Langauge Support. To understand my problem with this one, you have to understand how i search for the item and return the itemID into the URL.

When you post Foo , it auto-creates a URL, http://www.wowhead.com/?item=Foo&xml and this returns the XML of the item. the XML contains the ItemID which i then use to create the URL back to wowhead. The problem now is that with special characters (non-english, such as ? in Agon?a sin l?mites ), i can't just simply create http://es.wowhead.com/?item=Agon?a+sin+l?mites&xml however, http://es.wowhead.com/?item=Agonia+sin+limites&xml gives the correct response.

Notice the change from ? to i. i'm not sure that there is an easy and quick way to make this translation in PHP. Some other characters such as the german ? symbol, i can't seem to get working via URL ( http://de.wowhead.com/?item=Magierklinge+des+Gro?marschalls&xml )

The best way seems to enforce posting English Names only to which then i can get the translated name and display that. However what i would have to do here is hit wowhead.com for the Item Name to ItemID , then hit wowhead.com with the ItemID in whatever langauge selected (i.e. http://es.wowhead.com/?item=12345& would return the XML in spanish). I would rather not have 2 requests to wowhead when a new item is posted (itemID's are cached with their name, so you only need to do the lookup during the initial post).

The other option is of course, posting the complete wowhead URL for non-english URLs. Posting http://de.wowhead.com/?item=30901 will return the item name in german.

sweede
06-18-2008, 12:54 PM
Erm, we have just started using eqdkp, is there any way to apply these to an eqdkp installation that is separate to vbulletin? Also, the download for the eqdkp thing seems to be missing, unless I'm seeing things.

1) There will be, but you will have to supply the path to your vbulletin installation.
2) No your not seeing things, it is missing and soon to be replaced :)
3) I havent forgotten about your crafting database mod, i just havent really had much time to re-work it.

Deepdog009
06-18-2008, 10:25 PM
Doing a awesome job Sweede...

Keep the ball ROLLING......>>>:up:

sweede
06-20-2008, 08:39 AM
Please see https://vborg.vbsupport.ru/showthread.php?t=183035 for 3.7 version