View Full Version : Show Thread Enhancements - CES Dynamic [IMG] Resize (Plugin Version)
thincom2000
09-08-2007, 10:00 PM
CES DYNAMIC [IMG] RESIZE
Version: 1.2.2
This mod is based on TECK's Dynamic Picture Resize for [IMG] tag mod. I made this mod after seeing a discussion in the thread about the potential number of file edits necessary to add some requested features, and then realized the entire mod could be accomplished with essentially just 1 plugin. TECK suggested that for ease of support I release my updated product file in a new thread, so here it is.
*** NEWS ***
7/8/2009 - v1.2.2 released
9/23/2007 - v1.2.1 released
9/21/2007 - v1.2.0 released
9/13/2007 - v1.1.0 released
9/11/2007 - v1.0.4 released
9/9/2007 - support thread opened, v1.0.1 - 1.0.3 released
9/8/2007 - v1.0.0 released
Products to Install: 1
Plugins Included: 7
Files to Upload: 0
New Templates: 1
Template Edits: 0
Files to Edit: 0
What It Does:
When using the [IMG] bbcode tag, a user may add an image to his/her post that is too ginormous for your intended vBulletin style, pushing things out of the way, and not looking particularly nice. This hack resizes oversized images to specified acceptable dimensions, anywhere that the [IMG] tag is used.
Current Features: show a disclaimer when an image has been resized (option)
clicking the image opens in parent or new window (option)
multiple images on a line will be resized so their total width is below the set max
Known Issues:
- None
*** Changelog ***
As of Version 1.2.2:
- bug fix: XSS flaw
As of Version 1.2.1:
- bug fix: table explosion
As of Version 1.2.0:
- new feature: max width sharing for multiple images on a line
- bug fix: onclick interferes with [url]
- bug fix: onclick properties not passed to resize disclaimer
- bug fix: images separated by line breaks
- bug fix: [img] ignores [noparse]
As of Version 1.1.0:
- new feature: maximum height
- extended: maximum width can be in pixels or percentage
- bug fix: resize message class not set in Internet Explorer
- updated templates: dynamicpic_script
xandizitxu
09-09-2007, 07:53 PM
Thanks! I will test soon and post results!
Not working man!
see here what is happening FIXED NOT NEEDED MORE THE URL! please help =) this mod is really needed the image is that -> FIXED NOT NEEDED MORE THE URL!
thincom2000
09-09-2007, 08:19 PM
Okay, thank you. This issue occurs when you have HTML disabled in posts. I will look into this and see why this made any difference. Also, it looks as though you haven't fixed the word-wrap bug in 3.6.8. See this thread: http://www.vbulletin.com/forum/project.php?issueid=22752
xandizitxu
09-09-2007, 08:47 PM
Okay thanks for informing, i didn't know this
thincom2000
09-09-2007, 09:01 PM
Okay, the new version converts the [IMG] tag to a BB-Code first, so the HTML issue is averted.
xandizitxu
09-09-2007, 09:07 PM
It worked but now a bug appeared
FIXED NOT NEEDED MORE THE URL! take a look again
thincom2000
09-09-2007, 09:10 PM
Aha, okay. Seems to be a size issue :rolleyes:. Should be an easy one to fix.
xandizitxu
09-09-2007, 09:12 PM
\o/ Well with this I think my board is complete!
ITs working, now its a minor bug, not so BUG i can say, if i change the dimension on AdminCP the only thing that changes is the red text alert, only when updating the thread it works ^^ but its not a problem thanks for the hard working !
thincom2000
09-09-2007, 09:36 PM
Zip updated. Everything should be correct now. I'm going out for the night, so if there are any bugs remaining I probably won't get to them until tomorrow.
mktrilogy
09-10-2007, 08:21 AM
signature now only displays url
is it possible to only resize the post and not the sig?
thincom2000
09-10-2007, 10:41 AM
signature now only displays url
is it possible to only resize the post and not the sig?
I was unable to duplicate this behavior. The only thing I can think of is that your sig permissions are not set. First let me know if you are using any mods that modify permissions, such as Advanced BBCode Permissions or CES Parser Permissions. Also, please check your Usergroup Permissions under Signature Permissions. In vBulletin Options make sure [IMG] Code is enabled.
But to answer your other question: resizing the images in only one area would almost defeat the purpose of using this mod at all. If you're concerned about the alert "This image was resized," it doesn't appear in signatures or private messages.
sadiq6210
09-10-2007, 03:11 PM
Thanks
But
Is there a screenshot ?
thincom2000
09-10-2007, 03:40 PM
No screenshot (not sure what it would prove). You can view the dev testing thread here: http://www.crackedeggstudios.com/project.php?issueid=36
Computer Guru
09-10-2007, 10:00 PM
Thanks. Installed.
mktrilogy
09-11-2007, 01:19 AM
in my case it only changes the image into url into thus images are not displayed.
thincom2000
09-11-2007, 03:08 AM
That's not really too helpful. What are the settings I asked about earlier?
mktrilogy
09-11-2007, 05:07 AM
I was unable to duplicate this behavior. The only thing I can think of is that your sig permissions are not set. First let me know if you are using any mods that modify permissions, such as Advanced BBCode Permissions or CES Parser Permissions. Also, please check your Usergroup Permissions under Signature Permissions. In vBulletin Options make sure [IMG] Code is enabled.
But to answer your other question: resizing the images in only one area would almost defeat the purpose of using this mod at all. If you're concerned about the alert "This image was resized," it doesn't appear in signatures or private messages.
using bbcode manager
image code is enabled of course.
It does not resize my sig, it makes them url. no alert message, just url. all images that uses img code becomes url
nickypoooo
09-11-2007, 06:11 AM
using bbcode manager
image code is enabled of course.
It does not resize my sig, it makes them url. no alert message, just url. all images that uses img code becomes url
I'm having the same problem, It make my sig UR.
same here all images that uses img code becomes url.
Uninstalled.
thincom2000
09-11-2007, 12:21 PM
using bbcode manager
image code is enabled of course.
It does not resize my sig, it makes them url. no alert message, just url. all images that uses img code becomes url
I can only figure that there is a conflict since I have messed with the settings ad nauseum and can't figure out why this is occurring on your install. Please list any mods that hook into bbcode_parse_start (check the Plugin Manager, and sort by hook location instead of product).
Stoebi
09-11-2007, 02:18 PM
Hi
Really nice hack, thank you. :) I have some little problems.
My option for your hack:
'Enable/disable a message above each image that has been resized' is Off (value = 0)
If this option turned off, firefox displays an error message. Please see the image attached with this post (2nd line).
.resizeimage { max-width: $vboptions[ces_dynamicpic_width]px; }
* html .resizeimage, .resizednote { width: expression((this.width > intval($vboptions[ces_dynamicpic_width] - 1))) ? '$vboptions[ces_dynamicpic_width]px' : 'auto'); }IE, Firefox and Opera have problems with this peace of code. Please see the image attached with this post (1st line).
IE 7 does not display the background-color for $dynamicpic['note_true'] if this option 'Enable/disable a message above each image that has been resized' enabled.
My wish:
Allow to resize if 'Enable/disable a message above each image that has been resized' disabled.
Kind Regards,
Stoebi
thincom2000
09-11-2007, 03:05 PM
I hate IE. I have managed to fix everything you mentioned above except the background color. The problem is that IE is inheriting the background-color from the postbit, and then ignoring anything afterwards.
Stoebi
09-11-2007, 03:31 PM
Hi
thank you very much for your quick answer. :)
To solve the background-color for IE 7 you need to add this peace of code to this line:
return ($dynamicpic['note_true'] ? "<div class=\"resizednote\" id=\"$link\">" : "") . "<img src=\"$link\" border=\"0\" alt=\"\" $dynamicpic[image] />" . ($dynamicpic['note_true'] ? "</div>" : "");
Regards,
Stoebi
thincom2000
09-11-2007, 03:40 PM
But that is not the resized note div. That is a containing div... Doing that makes a huge undesired color splotch, if your image is smaller than necessary to be resized.
Also that causes the message not to display at all in IE7.
Stoebi
09-11-2007, 03:53 PM
Hm
you need to re-edit and save your post with your image. Suspect, i will searching for another way :)
Regards,
Stoebi
thincom2000
09-11-2007, 04:55 PM
Hm... I found another bug when the resize message is enabled. If you click to View Selection Source in Firefox, it runs onload() again, and duplicates the image every time you do this. This bug has been addressed in the next release.
Still clueless about the IE background... Maybe it has something to do with the order IE runs CSS and Javascript. Does anyone know anything about IE?
xandizitxu
09-11-2007, 05:05 PM
For me works great! I use firefox
Use FIREFOX and be happy!
PS: On IE don't work O.O
Stoebi
09-11-2007, 06:09 PM
IE and setAttribute() :(
http://www.quirksmode.org/dom/w3c_core.html#attributes
I've no ideas or workaround atm. :(
Thx for 1.0.4 :)
thincom2000
09-11-2007, 06:33 PM
Thanks for the link. I was able to get the class to set in IE.
In the template, find: wrap.setAttribute('class', 'resizednote');
Replace with: wrap.setAttribute('class', 'resizednote');
wrap.attributes['class'].value = 'resizednote';
This will be included in the next build.
xandizitxu
09-11-2007, 06:41 PM
I will wait for the next so! \o/
Great mod!
Stoebi
09-11-2007, 06:52 PM
Thx a lot, it works for IE now :)
Regards, Stoebi
mrghostno1
09-11-2007, 07:45 PM
Is there a way to make this work with % ? Because i saw in the code something like
+ 'px'
So this would not allow me to use a % resize. I mean, there's not need for user with 1600 screen to see an 1200 image resizes, as it is for a 800 screen user...
Thats why i would like to resize according to each user screen resolution.
Ted S
09-12-2007, 12:20 AM
I'm having a similar issue. New images posted with the IMG tag are resized while old ones are not.
thincom2000
09-12-2007, 12:35 AM
Is there a way to make this work with % ?
I will make this an option in the next release. Also the next release will allow setting a max height (but I don't think this would work desirably in % and it will have to use px).
New images posted with the IMG tag are resized while old ones are not.
In the AdminCP, use your Maintenance Tools' Update Counters and Rebuild the Post & Sig Caches.
mrghostno1
09-12-2007, 02:55 AM
Really thnks dude! Ultra fast support! I'll download this one, for sure.
thincom2000
09-13-2007, 01:41 PM
The new version is now available. Supports setting a max height in pixels and using % for the max width.
Dave_W
09-13-2007, 02:07 PM
I'm installing this just now. Great job. Haven't tested but judging from your feedback here it's going to work fine. I'll let you know If I come across a problem.
-Dave
xandizitxu
09-13-2007, 04:43 PM
update installed!
EDIT: BUGGED MY SITE :/
ON FIREFOX THE IMAGE BECOMES a 1px
[FIXED!!! JUST REMOVED THE OLD TEMPLATE OF DYNAMIC PIC AND GOT IT WORKING!]
ON IE THE IMAGE TRUE SIZE DON'T OPEN IN NEW WINDOW AND NO DISCLAIMER [NOT FIXED :(]
http://www.hakkeshu.com/forums/showthread.php?t=29
Well ^^ thats only it
mrghostno1
09-13-2007, 07:30 PM
every time i enable it, all images turn in to url to the image, they dont show anymore.
Using fixed width, and fluid %. showing disc. or not. doesnt work anyway. :(
thincom2000
09-14-2007, 01:07 AM
every time i enable it, all images turn in to url to the image, they dont show anymore.
Using fixed width, and fluid %. showing disc. or not. doesnt work anyway. :(
A number of users reported this in earlier builds, though no one ever got back to me when I started asking them about various settings. This is likely to be a conflict with some other mod. What mods are you using with plugins using the bbcode_parse_start hook?
thincom2000
09-14-2007, 01:09 AM
ON IE THE IMAGE TRUE SIZE DON'T OPEN IN NEW WINDOW AND NO DISCLAIMER [NOT FIXED :(]
I checked your site and it seems to be working as designed in IE.
xandizitxu
09-14-2007, 01:42 AM
I checked your site and it seems to be working as designed in IE.
on my IE 7.0 don't :(
thincom2000
09-14-2007, 02:08 AM
Hm... I don't know what to say. I have tested your site in both normal and 64-bit Internet Explorer 7, and haven't seen any issues. Try clearing your browser cache, maybe?
Dave_W
09-14-2007, 09:18 AM
Hey, installed on my site, works a charm, although I seem to be getting the problem where Sig images get turned into URL's. I think you addressed this problem already so i'll check and get back to you. Either way this works great, i'm clicking installed because me and my members love this.
-Dave (http://www.TheBestCaseScenario.com/forum)
EDIT: Fixed by rebuilding Sig cache, nominated for MOTM.
offline
09-14-2007, 02:23 PM
I have installed your mod and it resizes everything properly but I have a few issues...
1. When using in conjunction with vbadvanced I get the "resized" message no mater what my setting are. View my front page, I have a test image posted... http://www.chattanoogans.com/
2. When viewing the message it doesnt make the image clicable to view the orginal image even when I have the option set. You can view the message at...
http://www.chattanoogans.com/forums/forum-announcements-polls/6-image-resize-test.html
PS. Using IE 7
mrghostno1
09-14-2007, 03:14 PM
What mods are you using with plugins using the bbcode_parse_start hook?
I'm not sure about this, but i'm using SID's hide hack and I had vBAnonymizer (unistalled atm).
thincom2000
09-14-2007, 03:14 PM
@offline, I don't know if you changed something or not. I checked and saw it working as you described in IE 7. Then after 30 mins of trying to figure it out I refreshed the page and it's working as designed...
@mrghostno1, thanks for getting back to me with this. It gives me somewhere to start looking.
thincom2000
09-14-2007, 03:41 PM
For users using sid's [hide] hack...
The issue is that AFTER all the parsing is done for a post, the [hide] hack reparses the post. This would not be a problem if the post was reparsed properly. But a huge number of coders are under the misconception that using the function $bbcode->do_parse() is the best way to do this.
The truth is, that do_parse bypasses the bbcode_parse_start hook, which breaks any modifications that may be using it. Not only that, but it still runs bbcode_parse_complete, which can create even more problems when bbcode_parse_start was never called.
So if you're using the hide hack (or potentially any other hack that runs do_parse)
In the postbit_display_complete plugin, find:
$hide_post['message'] = $parser->do_parse($hide_post['message'],true);
Replace with:
$hide_post['message'] = $parser->parse($hide_post['message'], $this->thread['forumid']);
mrghostno1
09-14-2007, 05:47 PM
Thnks thincom200, but... didn't work :( still got the same.
btw, i found this code only under "hide hack ajax request"
There's also a "fetch hide tag" with postbit_display_complete, but couldn't find that code.
Other plugins using postbit_display_complete
Last seen online (Postbit)
Warning System (Postbit)
offline
09-14-2007, 06:25 PM
@offline, I don't know if you changed something or not. I checked and saw it working as you described in IE 7. Then after 30 mins of trying to figure it out I refreshed the page and it's working as designed...
@mrghostno1, thanks for getting back to me with this. It gives me somewhere to start looking.
Wierd, it still doesnt work for me, give me an error on the bottom of the page and I still can't click on the image.
offline
09-14-2007, 06:52 PM
I went home and tried it and when I first viewed chattanoogans.com home page it loaded with no errors then I click on the message title above it "Image Resize Test" viewing the message then I click the back button to bring me back to the home page and then the error came up.
thincom2000
09-14-2007, 07:24 PM
In the template, find:
* html .resizeimage, .resizednote { width: expression((this.width > intval(600 - 1))) ? '600px' : 'auto'); }
Replace it with:
* html .resizeimage, .resizednote { width: expression((this.width > intval(600 - 1)) ? '600px' : 'auto'); }
That's the only place I could find an expected ';', so let me know if that changes anything.
mrghostno1
09-14-2007, 09:07 PM
Is this for me? Anyway, what's the difference between the 2 codes? for me they look the same...
Once more thnks for ultra fast support :)
edit: tried to reinstall, still no image at all when enabled.
offline
09-14-2007, 09:10 PM
Well it still doesn't work properly but I can now click on the image to make it bigger on the fornt page but when viewing the message itself it is still not clickable.
By the way I wanted to say thanks for the mod and thank a million for trying to help me get it working.
thincom2000
09-14-2007, 11:22 PM
The "image was resized" message is not clickable in the public version. Is this what you meant?
EDIT: It depends on how you navigate to the post for some reason. Doing so through the forums and it functions normally. Doing so from your vBa module and it breaks. Hitting back after going through vBa, then clicking it again and it functions normally. I'm at a loss.
ForYou
09-15-2007, 12:57 PM
Hello ,
I was installed the hack and work good but all the image was appear links not image , when i do edit the post the image will show ,
http://dardasha.net/montada/showpost.php?p=1107840&postcount=116
but my forums is big and alot of posts and i can't do edit for all posts ,
Regards
impuLsive
09-15-2007, 01:24 PM
All images turned into links in signatures, and I can't un-do this. I tried running the things in "Update Counters", but no luck. Please post a fix as this mod just broke 800 of my users sigs :-\
thincom2000
09-15-2007, 02:22 PM
but my forums is big and alot of posts and i can't do edit for all posts
If editing the post works, then the update counters method should fix it for you.
thincom2000
09-15-2007, 02:27 PM
All images turned into links in signatures, and I can't un-do this. I tried running the things in "Update Counters", but no luck. Please post a fix I have posted many times in this thread that I am unable to duplicate this behavior at all on my board. If someone can create a test board where this DOES happen, I will gladly take a look and post the fix.
mrghostno1
09-16-2007, 04:39 PM
Editing the post works for me too, updating the counter works too.
However, all the images that were in the single line now became each on a line, editing shows the code ok, but it places on per line, making posts get a real long scroll down...
After disabling, the post became ok again. But when i enable CES Dynamic Resize, again all images showing as links, so i would need to update counters all again...
Bug report: Images with link
https://vborg.vbsupport.ru/ (http)
Dont show up when resize is enabled
thincom2000
09-16-2007, 05:41 PM
all the images that were in the single line now became each on a line, editing shows the code ok, but it places on per line, making posts get a real long scroll down...
This should only occur if the resize message is enabled. This occurs because the message can only be rendered on a new line. I will look into adjusting this in the next version, but it would complicate the code.
Bug report: Images with link
image.gif (http)
Dont show up when resize is enabled
This is very odd. Perhaps it is related to stack order. I will look into this.
mrghostno1
09-16-2007, 07:34 PM
Actually i'm with the image disclaimer disabled, and still getting one per line...
I'm doing a rebuild befor and after each enable/disable of this mod. :(
And every image got 1 per line, even the ones wich didn't need to be resized.
When disclaimer is disabled the linked images show ok, but you can't reach the link since the full image is opened, this isn't possible to fix i think. Unless you added the link to full image only on the disclaimer text.
thincom2000
09-16-2007, 08:40 PM
When disclaimer is disabled the linked images show ok, but you can't reach the link since the full image is opened, this isn't possible to fix i think. Unless you added the link to full image only on the disclaimer text.
This sounds like a good solution. Unfortunately I am having a great deal of trouble getting images to go by % and be on the same line without the % having weird results. See here: http://www.crackedeggstudios.com/project.php?issueid=36
mrghostno1
09-16-2007, 11:52 PM
I don't get it, shouldn't the second image be shown under the other? Since it's over width.
In may case i have small thumbs. I'm confuse
Dave_W
09-17-2007, 08:44 AM
Hey, as I've said before, this is a great mod. I just have one small problem. Members of my website have Sig Images that are made up in parts, so they can link them to different places, but it still looks like one large image (basically, to get around our signature size rules).
Unfortunately, since installing this mod a newline appears between the images, ruining the effect. I've enclosed a screen-shot for your perusal. Although I could fix it myself, I'd rather you did it-it's your code and I want everyone to get the benefits of this mod.
http://www.thebestcasescenario.com/davew/sig1.png
http://www.thebestcasescenario.com/davew/sig2.png
Thanks,
-Dave
thincom2000
09-17-2007, 11:55 AM
Hi, it took a bit of searching around on some forums, but I figured out why the javascript in my test version stopped working, so I will be addressing all these issues quite shortly.
thincom2000
09-17-2007, 04:10 PM
shouldn't the second image be shown under the other? Since it's over width.
In may case i have small thumbs. I'm confuse
Okay, I think I am done with the updates to the mod and should be uploading it relatively soon. What will happen now is that all images remain on the same line if they were entered on the same line (that is, original line breaks are maintained).
This would be a bad thing if multiple images in a line were oversized, because even after resize, leaving them together would probably still be too big. This was the original reason for forcing the images to separate lines.
Now, however, the mod will treat ALL images on a line together as a single image, and resize them accordingly. Basically this means they will all have to share the maximum width, and each will be smaller than if they were the only image. I think this is the best solution without getting invasive on post layout again.
The code structure has changed. In order to accomplish the "width sharing" all widths have to be calculated first (otherwise the ones resized first would mess up the calculations). Once that is complete the images are finally resized. A new plugin had to be added to avoid the onload() bug. This is the bug (or feature?) where Javascript will only run 1 onload command in an entire page. This was partially your issue if sometimes the images weren't clickable. Although the real thing to blame is the session hash vBulletin hides in every URL. Somehow this prevents Javascript functions from running more than once. It must be the session hash because clicking a vBulletin link doesn't work as expected, yet directly typing the URL does work (and this is the only difference I can tell between the URLs). Anyone (staff?) care to comment?
All resize commands have been moved to the $onload variable in the body tag. In addition, a second new plugin had to be added to insert a regex to prevent each image from breaking the intended layout and eventually style (this is the line break fix).
To address the https://vborg.vbsupport.ru/ reported bug, where the link opens the image and not the address in the url bb-code: this is actually not a bug, but intended functionality. For now, if you want to link resized images elsewhere, use captions. Or right click and open the link that way. I will add a feature so that the link to the original image moves to the disclaimer if wrapped in a URL tag. If the disclaimer is disabled and this is the case, the link to the original image will disappear.
mrghostno1
09-17-2007, 10:57 PM
Now, however, the mod will treat ALL images on a line together as a single image, and resize them accordingly.
But this doesn't apply to images wich have (each one) smaller size then the limit right?
Just to make it clear, for me and others, because vbulletin already break-line if the width of all images is too long.
thincom2000
09-18-2007, 01:42 AM
As I said, images in these cases are not treated individually. vBulletin cannot word wrap because the disclaimer forces a line break anyway (even when disabled), so this is the method that is used. The javascript cannot suppress one form of a line break instead of another. Though this is possible, the entire mod would have to be rewritten, and then a user with javascript disabled will still be seeing huge images. If a user doesn't like the overall resize, they should edit their posts. That's what post preview is for.
I have spent 2 days changing up this mod so that users who were breaking site rules anyway (using a workaround to essentially use huge images) wouldn't be affected by line breaks. If a user is smart enough to figure out the workaround, they should also know that the simplest way to stop a block-level div from adding line breaks is to enclose it in a table cell. There are some excellent table bb-codes available (for example, NuHit packages [table], [tr], [td] with NuWiki) so admins wouldn't have to enable HTML to allow something like this.
But that's enough of a rant. I think I've squashed most of the bugs with this new version finally. All I have left to do now is add the [url] checks.
thincom2000
09-21-2007, 04:08 AM
The new version has been posted.
@offline, all of the bugs you reported have been fixed in this version.
@Dave_W, the "bug" you reported has been fixed in this version through "width-sharing."
@mrghostno1, the [url] (and other tags) bug you reported has been fixed in this version.
New options have been added. You may wish to configure.
Note: The width sharing interferes with word wrapping for the sake of speed. I just don't think it would be efficient to add 2 more regexes to have a word wrap work on images again. Plus it is likely that images placed together on a line are intended to be viewed side-by-side anyway, and word wrap could become frustrating to these users.
Changing it back would have to be done entirely on the Javascript side (adding 2 nicely slow regexes), so users with Javascript disabled would experience it as is anyway.
xandizitxu
09-21-2007, 02:59 PM
Thx for the update \o/ already installed ^^
A good feature is to implement Highslide JS ^^
Thanks again for the mod!
xandizitxu
09-21-2007, 03:07 PM
Okay, broke my template :/
http://www.hakkeshu.com/forums/showthread.php?p=133#post133 Take a look
The image should be on top not down
thincom2000
09-21-2007, 06:33 PM
This is the stupidest bug I have seen. It is impossible to run the bbcode_parse_complete code in showthread. Why does this only work in Project Tools? The variable has been globalized and I have even tried storing the recurse value in a $vbulletin->dynamicpic object with no luck.
The recurse value is ALWAYS zero on showthread, and even when skipping the check the regex is too lazy to bother on showthread. Does anyone have any solution? I am so fed up with the postbit at this point and on the verge of only supporting use of this mod in Project Tools.
Until someone else finds a fix, I'm out.
xandizitxu
09-21-2007, 06:37 PM
Oh, no problem, could u send me the last version? it was working for me :\
thincom2000
09-21-2007, 09:19 PM
I would, but I try not to archive out-of-date versions of my mods. Hopefully someone else has not updated yet.
xandizitxu
09-21-2007, 09:31 PM
I found a backup here
^^
thincom2000
09-21-2007, 11:57 PM
Could you upload it? lol
Maybe I can find something in the old plugins that would explain wth is wrong.
Charlie98902
09-22-2007, 12:15 AM
Sorry I over wrote the old plugin.
Charlie98902
09-22-2007, 12:18 AM
Sorry I over wrote the old plugin.
I posted in the wrong section here is the error I get with the new update and this didn't happen on the older version.
With the new update on this mod I am now getting an error in firefox I know for sure.
I am running VB 3.6.8 the last version of this mod was fine now I get this when navigating the forum. The only thing I did was turn it on and lowered the size settings on this mod, everything else is at default.
Attached Thumbnails
mrghostno1
09-22-2007, 12:51 AM
Not working here, style get all buged out. I can't be doing cache update all the time.
Sorry.
thincom2000
09-22-2007, 06:56 PM
This has been established. The current version only works in Project Tools. If anyone still has a copy of the old zip archive, it would be extremely helpful in finding out what broke.
Charlie98902
09-22-2007, 07:22 PM
I would like the prior version too. I think I'll save the older one next time for when these things happen.
xandizitxu
09-22-2007, 07:58 PM
Old Version 1.1.0
Charlie98902
09-22-2007, 08:20 PM
Old Version 1.1.0
Thank you.
thincom2000
09-23-2007, 04:29 PM
Okay I figured out the style-breaking bug in 1.2.0. What happens is that when the post is first parsed (so when you click Update Counters or Post Preview) the post will display correctly, because the bb-code parser will be run. Afterwards, however, if the post was cached, it will not run the bbcode parser and will skip an important regex. This will result in broken tables and a Javascript hang.
The Javascript breaks if the post is cached because the onload triggers aren't set. So the fix would be disabling post caching for posts with images. At this point, the mod would mean slowing things down a little bit... for me it doesn't make a difference because I had to disable post caching for other reasons, but I will upload both 1.2.1 and the old 1.1.0 (thanks to xandizitxu) so users can choose.
xandizitxu
09-23-2007, 05:20 PM
As always I will test it ^^
Your mod is great ^^
mrghostno1
09-23-2007, 09:02 PM
Still not working for me. A se of images like this:
http://thumbnails.freeimagehost.eu/109/6fb2a31080016.gif (http://www.freeimagehost.eu/image/6fb2a31080016) http://thumbnails.freeimagehost.eu/109/1bc5b71080017.gif (http://www.freeimagehost.eu/image/1bc5b71080017) http://thumbnails.freeimagehost.eu/109/070cf61080018.gif (http://www.freeimagehost.eu/image/070cf61080018) http://thumbnails.freeimagehost.eu/109/b44a591080019.gif (http://www.freeimagehost.eu/image/b44a591080019)
Simply doesn't show, they all disappear, even after post rebuild and/or post editing.
As they are smaller then the 80% limit I entered, i though they wouldn't be touch.
If the images are posted alone, without URL linking, they show ok. Even with the "Disable Link to Original Image" box empty.
Also, not sure if it was after i clean the "Disable Link to Original Image" box, but a larger image just got CROPED, insted of resized.
thincom2000
09-24-2007, 10:55 AM
Well, first I should mention that your URLs will be conflicted now that you completely emptied the "Disable Link to Original Image" field.
The images disappearing usually happens when there is a bug in the Javascript. The reason it would happen even to unresized images is because the Javascript decides to resize or not, and if the Javascript is broken... Have you tested any images that had to be resized?
I am not having any more issues on my install, matching your settings. Please link me to the page you described.
yoyoyoyo
09-24-2007, 11:28 AM
I went to look at pictures that had been resized with the previous hack from TECK and they were not resized. I went in to edit the posts containing the images and instead of the BB code I saw html (I do not allow html in posts).
version 1.2.1 does not work for me but version 1.1.0 does seem to work fine, except when someone goes to edit a post the html is displayed like this:
<div id="http://images.buycostumes.com/mgen/merchandiser/19879.jpg"><img src="http://images.buycostumes.com/mgen/merchandiser/19879.jpg" border="0" alt="" class="resizeimage" onload="resize_image(this, 'http://images.buycostumes.com/mgen/merchandiser/19879.jpg', true);" /></div>instead of bb code like this:
https://vborg.vbsupport.ru/external/2007/09/14.jpg
so for now I will go back to the version from TECK and the file edits, since that was working fine.
AndyA
09-24-2007, 12:49 PM
This mod doesn't seem to work fully for me, it resizes the images but doesn't display any resize notification and it doesn't open the full size image. I've checked all the settings.
P.S tested in Firefox and IE
vb 3.6.8
thincom2000
09-24-2007, 02:39 PM
I am not having ANY issues on my install. If you are having problems, please link me to your test thread or I will be unable to help.
SliceofLife
09-26-2007, 07:09 AM
There were two xml files included. Am I supposed to install both of them?
I installed the 121 file, and this isn't working. It's showing previously posted images as URL links. Not what I wanted. :(
SliceofLife
09-26-2007, 07:12 AM
I uninstalled old version, and installed other file 110 or whatever it was, and you have to reupload images in order for it to work...
thincom2000
09-26-2007, 10:42 AM
Or you could just rebuild the post cache.
AndyA
09-26-2007, 02:55 PM
OK I'll need to install it again.
Charlie98902
09-27-2007, 11:53 AM
I still am getting the stop script error with the latest version. If needed this post has the pic of the error.
https://vborg.vbsupport.ru/showpost.php?p=1344207&postcount=78
zagman76
09-29-2007, 10:30 PM
I still am getting the stop script error with the latest version. If needed this post has the pic of the error.
https://vborg.vbsupport.ru/showpost.php?p=1344207&postcount=78
The same thing is happening to me...
zagman76
09-30-2007, 12:37 AM
it is also causing all of my sigs to align up-and-down, even though they might be formatted for left-to-right...(i'm running v110
Charlie98902
09-30-2007, 02:09 AM
I did try rebuild post cache also with the same issues.
thincom2000
09-30-2007, 03:14 AM
it is also causing all of my sigs to align up-and-down, even though they might be formatted for left-to-right...(i'm running v110
This was fixed in 1.2.1, but no one has linked me to a thread that was having problems. I can't duplicate the issues people have posted here just because my 1.2.1 install has worked flawlessly, so for the THIRD TIME people, if you are having problems with 1.2.1, you need to send me a link.
parad0xx
09-30-2007, 08:32 PM
Installing this and updating my post and sig counters caused a MySQL error and now my entire forum is unaccessible and ALL my phrases are gone.
I just had to pay $60 so I could get phone support to resolve this mess. You should learn to test your work before causing people this much grief.
AndyA
09-30-2007, 08:45 PM
This was fixed in 1.2.1, but no one has linked me to a thread that was having problems.
In my case it's because I don't want to leave a mod running on my forum if it's not working correctly. I've installed this twice but still have the same issues, i.e it resizes but doesn't link to a full size image or show any notiication that the original image has been resized.
Don't get me wrong, I appreciate your hard work and I really would like to see this working on my forums.
thincom2000
09-30-2007, 09:45 PM
Today was the first time I encountered a bug using 1.2.1. If an IMG is quoted with this installed, it is likely that you will get the "busy script" error. I'm not exactly sure why this happens, but I implemented a workaround so that IMG turns into URL in this case.
Again the stop script error only occurred for me if the IMG was inside QUOTE. If you had 1.2.1 and you can confirm other situations that cause the stop script, let me know immediately.
Computer Guru
10-04-2007, 08:50 PM
Thanks for your plugin.
It is working fine on my vBulletin 3.6.8 after rebuilding post and sig caches... HOWEVER
I'm getting the new line between images problem with the latest version. Reading through this thread, it was supposedly fixed a couple of pages back? IS there a solution for this now w/ the latest version?
Thanks!
thincom2000
10-05-2007, 06:45 PM
There are 2 versions of the product file in the ZIP. 1.1.0 is the previous version with the new line issue. Version 1.2.1 is the version with this fix, but several people have had other problems with this version that I haven't been able to reproduce.
Computer Guru
10-09-2007, 12:44 PM
I'm running 1.2.1, but have the extra space problem.
wolfe
10-09-2007, 01:06 PM
its not resizing the images in my posts.
Computer Guru
10-21-2007, 02:48 PM
Is this mod still supported? 1.2.1 does not fix the extra spacing problem.
thincom2000
10-21-2007, 03:06 PM
Send me a URL so I can see what is going on. I have a new version but I haven't changed anything except improve performance.
columbusgeek
10-21-2007, 07:07 PM
V1.2.1 did some weird offscreen fluid thingy on my install. Thanks for including 1.1.0. It works exactly how I wanted.
jags2ooo
10-22-2007, 02:26 PM
THis mod doesnt seem to work, The images that are supposed to be resized are erased instead all you see is a url to the image. dang would have been awesome if it worked
jags2ooo
10-22-2007, 02:36 PM
it works now had to rebuild signature cache, you should put that in the readme :rolleyes:
Awesome mod great job!! after all these months my forums can look organized again, so many girls with there Big huge Pink sigs >< was so annoying.
But its cropping the images instead of resizing.
thincom2000
10-22-2007, 07:14 PM
If it's cropping then the Javascript isn't working. Check if you have any Javascript errors with the mod enabled. Then check with the mod disabled. Let me know what you find.
Screamin'04
12-07-2007, 01:39 PM
Is there any way to make this work only for signatures?
thincom2000
12-07-2007, 11:50 PM
Is there any way to make this work only for signatures?
Edit the plugin called "Dynamic IMG Replace" at bbcode_parse_start.
Find the following line:
if ($this->registry->options['ces_dynamicpic_enabled'])
Replace with:
if ($this->registry->options['ces_dynamicpic_enabled'] AND $forumid == 'signature')
PimvanJ
12-24-2007, 06:50 PM
Great hack thanks a lot.
Clicks install :D
And...future request: auto-adding a watermark.
Russ_T
12-24-2007, 08:01 PM
Hmmm gives me a bunch of errors on a clean install...
Thread, (image restricted to 900px, but in fact 1280px wide)
http://www.zclub.net/forum/showthread.php?p=98508
I'll start working through the errors best I can and get back with anything I learn.
Cheers
Just to update: I looked for JS errors with it enabled and disabled and apart from the image being cropped there were no differences between the two. No extra errors or anything :(
Russ_T
12-24-2007, 08:15 PM
Hi,
In dynamicpic_script
<style>
should be
<style type="text/css">
:) Other than that all the errors I had were inherent in vb. I don't get any JS errors but there is no linking to the image, disclaimer part to image, and the image is cropped in firefox and cropped in IE7 but still forces the window to stretch (as if it weren't cropped).
It does complain that it thinks the -- in the for loop is supposed to be the end of the comments for that JS...
for (k = dyn[i][3].length; k >= 0; k--)
Which I changed to
for (k = dyn[i][3].length; k >= 0; k = k - 1)
To keep it quiet for now. There must be a better way around this?
Any ideas please? This mod looks SOOO good on talkaudio.co.uk I must have it for my forum :)
Russ_T
12-24-2007, 08:29 PM
LOL just read back through the past few posts, tried 1.1.0, it just hangs my firefox if I don't cancel the script :)
Onwards with 1.2.1 then :)
Is this script working with 3.7?
luxmail
02-08-2008, 11:34 PM
Best mod ever. Great job. Installed !!!
thincom2000
02-22-2008, 04:32 PM
Is this script working with 3.7?
This script works with 3.7, although it has some issues with member.php if you have hacked vB to allow IMG-code in your profile fields. I am planning basically a rewrite that supports post caching and works after AJAX edits and replies.
rapidphim
02-25-2008, 03:45 AM
thanks much.. will try it out.
A.Chakery
03-03-2008, 12:27 PM
i dont know why i have problem with any image resizer! when i install this mod , and enable it every image will be converted to image links! can any one help me?? it'll be really appriciated
justchil
03-03-2008, 01:19 PM
Edit: NM found it :)
justchil
03-03-2008, 01:28 PM
i dont know why i have problem with any image resizer! when i install this mod , and enable it every image will be converted to image links! can any one help me?? it'll be really appriciated
You need to rebuild your post cache under Update Counters -> Maintenance -> Rebuild post cache
A.Chakery
03-03-2008, 05:54 PM
You need to rebuild your post cache under Update Counters -> Maintenance -> Rebuild post cache
thanks bro, really appriciated! it's working nice.
clicks on install!
sub_ubi
03-08-2008, 08:03 PM
Anyone had any trouble uninstalling?
thincom2000
03-08-2008, 08:44 PM
I can't think of any reasons why you would. You may need to rebuild the post cache if you fail XHTML validation, but I think this would also happen when the mod doesn't even work with Javascript disabled. I don't think these posts would have been cached though, since this mod currently disables caching for posts with images.
iDaemon
03-17-2008, 07:55 PM
installed
vithorius
04-09-2008, 05:00 PM
every time i enable it, all images turn in to url to the image, they dont show anymore.
Using fixed width, and fluid %. showing disc. or not. doesnt work anyway. :(
I have the very same problem...
I have the following plugins:
- AME - The Automatic Media Embeder v.1.2.0
Automatically embeds media URLs with posts
- Archive Adsense v. 1.0
Adds Adsense banners to the top and bottom of your archive pages.
- CES Dynamic [IMG] Resize v. 1.2.1
Dynamically resizes an oversized [IMG] to preset dimensions.
- Cyb - Advanced 'New Posts v. 2.0
Cyb - Advanced 'New Posts'
- Cyb - Advanced Permissions Based on Post Count v. 4.2
Cyb - Advanced Permissions Based on Post Count
- iTrader v. 2.0.1
Trader Feedback System
- vBadvanced CMPS v. 3.0.0
vBadvanced Content Management & Portal System
thincom2000
04-09-2008, 09:53 PM
You need to rebuild the post cache for existing posts.
vithorius
04-10-2008, 08:02 AM
You need to rebuild the post cache for existing posts.
Great! This worked for me! :up: :cool: :up:
P.S: - IE 6 seems not to resize the images... (Firefox is just OK!)
Computer Guru
04-12-2008, 09:22 AM
I'm sorry, but this mod has way too many bugs.
I'm now using this resizer, and it's working great:
https://vborg.vbsupport.ru/showthread.php?t=157228
thincom2000
04-12-2008, 06:58 PM
If you could post which settings were not working for you, it will be helpful when I do the rewrite for 3.7
vithorius
04-17-2008, 07:31 AM
I'm sorry, but this mod has way too many bugs.
I'm now using this resizer, and it's working great:
https://vborg.vbsupport.ru/showthread.php?t=157228
Unfortunately, I must agree with you...!
I have this hack installed on 3.6.8, but there is two annoying bugs:
a) - EVERY SINGLE DAY (!) I have to go to the forum Admincp and run the "rebuild message cache" feature on the maintenance... The images just get lost on the posts and all we see is the URL for the images, but no images at all... :(
b) some images just get cut... They are not resized... They are cut...
This is a MAJOR hack, USEFUL and should be considered by Jelsoft to include a similar feature on vB! But those two annoying bugs are getting me mad...
(please excuse my poor english)
thincom2000
04-17-2008, 01:18 PM
a) - EVERY SINGLE DAY (!) I have to go to the forum Admincp and run the "rebuild message cache" feature on the maintenance... The images just get lost on the posts and all we see is the URL for the images, but no images at all... :(
b) some images just get cut... They are not resized... They are cut...
Hi, and thanks for finally reporting these.
a) I think I can see why this is occurring. The mod was originally designed to disable caching in posts where images need to be resized, but that was removed in the last version, so now every time the post is cached, the parser forgets it $has_img_tags. This will be addressed in the rewrite.
b) As for this, I cannot say exactly why this is occurring. This happened to me frequently during testing, but I have not seen it since. It sounds like the javascript is broken. Is your browser reporting any javascript errors? Can you confirm in the page source that the template dynamicpic_script was appended to headinclude?
vithorius
04-20-2008, 03:34 PM
Hi, and thanks for finally reporting these.
a) I think I can see why this is occurring. The mod was originally designed to disable caching in posts where images need to be resized, but that was removed in the last version, so now every time the post is cached, the parser forgets it $has_img_tags. This will be addressed in the rewrite.
b) As for this, I cannot say exactly why this is occurring. This happened to me frequently during testing, but I have not seen it since. It sounds like the javascript is broken. Is your browser reporting any javascript errors? Can you confirm in the page source that the template dynamicpic_script was appended to headinclude?
I'm sorry...! I had to quit...!
I've just uninstalled this script... I'm now trying this one:
NCODE IMAGE RESIZER FOR VBULLETIN 3.6
https://vborg.vbsupport.ru/showthread.php?t=118048
Creed3020
03-10-2009, 11:29 PM
I have this mod installed on my 3.6.10 forum and with maximum image width set to 1000 this mod is making all our images turn into links. Is this a common issue?
Thanks.
edenx
05-16-2009, 02:42 PM
Is there a 3.8 ver of this?
thincom2000
05-16-2009, 05:52 PM
For now I cannot support this modification. We stopped developing it about a year ago and have since stopped using it on our own sites.
If the status changes, I will update this thread. Otherwise, I recommend using another mod.
steven.hartland
07-08-2009, 03:19 PM
Just wanted to make people aware that this code is exploitable, and enables users to rewrite any part of the page :(
So until fixed I would disable this plugin if you have it installed
N.B. I've notified the developer of the precise details of the issue.
vBulletin® v3.8.12 by vBS, Copyright ©2000-2025, vBulletin Solutions Inc.