PDA

View Full Version : New Posting Features - vbPostCheck - Warn if someone posted while you were typing


hambil
04-03-2007, 10:00 PM
Note: This product is now being supported at www.catnine.net

Keywords: Post, warning, check, new

Description:
Gives the user a warning if someone has posted in the same thread while they where typing their reply. The user can than choose to review their post, and continue.

Version 1.1.0:

Uses the same warning method as other vBulletin post warnings (see screenshots)
Works with quickreply
Shows new post in Topic Review section (for non quickreply)
Added option to do an auto template replace
Added option to enable or disable the productSpecial thanks to Dismounted for his contributions, and welcome as a co-author/supporter.

Version 1.0.0:

Warns on new posts in same thread while you where typing your reply
Fully phrased
No file edits or uploadsInstall
Download the product-postcheck.xml file
Import using the product manager

hambil
04-04-2007, 06:51 PM
No - 5 stars not 1 star! I hit the wrong button...

Hopefully someone will wander along and fix it for me.

In the meantime, er, welcome to my lastest hack :D

nexialys
04-04-2007, 06:51 PM
i hope that open a new window when alerted ?!

you forgot to drop your site url in the script!

nexialys
04-04-2007, 06:53 PM
No - 5 stars not 1 star! I hit the wrong button...
hah ha... you've done that you too.. lol :D

badly nobody will edit .. lol

hambil
04-04-2007, 06:53 PM
i hope that open a new window when alerted ?!

you forgot to drop your site url in the script!
Yeah, it's a chicken and egg thing. You have to post to get the url to the threads, and you need the url to the thread to post. I usually just do a quick update of the hack within a few minutes of posting here, once I know the topic id.

hambil
04-04-2007, 06:55 PM
i hope that open a new window when alerted ?!

you forgot to drop your site url in the script!
No, it looks like any other vb error message. However, nothing is lost. When you hit 'review' it takes you back to your post with everything still there.

nexialys
04-04-2007, 07:04 PM
Yeah, it's a chicken and egg thing. You have to post to get the url to the threads, and you need the url to the thread to post. I usually just do a quick update of the hack within a few minutes of posting here, once I know the topic id.

i meant this:$vbulletin->options['vbpostcheck']['form_action'] = 'http://www.catnine.net/vb/newreply.php?do=postreply&t=' . $_REQUEST['t'] . '&skip=1';

... use $vbulletin->options[bburl]

hambil
04-04-2007, 07:05 PM
Oh, crap

I hate bugs. Hold on, quick fix.

It worked on my board :D

hambil
04-04-2007, 07:11 PM
i meant this:$vbulletin->options['vbpostcheck']['form_action'] = 'http://www.catnine.net/vb/newreply.php?do=postreply&t=' . $_REQUEST['t'] . '&skip=1';... use $vbulletin->options[bburl]
Put a new xml file up. That should fix her up. I need more sleep lol :)

bashy
04-04-2007, 07:11 PM
Wow, what a great hack, me installing now :) thanks!!

FleaBag
04-04-2007, 07:11 PM
Very nice hambil! Thanks. :)

Rated 5 stars... We'll get you there eventually!

nexialys
04-04-2007, 07:12 PM
Oh, crap
I hate bugs. Hold on, quick fix.
It worked on my board :D

That need to be quoted for the posterity... :D :D :D

ringoflight
04-04-2007, 07:14 PM
Installed and working!

bashy
04-04-2007, 07:40 PM
Didnt work for me, I posted using IE and posted under another name using FF and did not get a warning!!

hambil
04-04-2007, 07:41 PM
Don't use quick reply. By it's very nature quick reply doesn't bother checking.

bashy
04-04-2007, 07:43 PM
Damn, that will explain that then pmsl...... cheers m8 :)

bashy
04-04-2007, 07:47 PM
ok works now using full reply sort of lol

It does not show that last post it shows the penultimate post!!!! see image last post and image not last post
please see the image as the error message as some code thats out of place :(

hambil
04-04-2007, 08:21 PM
I don't understand - sorry. It looks like you edited the template or the phrase, and that's where the odd characters are coming from on the warning message.

As for the last post/not last post, could you explain better, please?

rjmjr69
04-04-2007, 09:26 PM
How many queries if any does this add? Does it take up much resources? Looks very nice and extremely useful

""""Clicks Install until answered"""""

Thanks

Hornstar
04-04-2007, 10:09 PM
yeah i always remember those threads were you post, and then you edit saying, damn, you beat me to it. but that is all fun in the community, trying to beat someone to the thread, i think if i installed this, it would kind of take away that atmosphere. but either way, great work on creating this, im sure it will be very useful for lots of boards.

MThornback
04-05-2007, 12:39 AM
You are brilliant *installed*

MThornback
04-05-2007, 12:45 AM
No - 5 stars not 1 star! I hit the wrong button...

Hopefully someone will wander along and fix it for me.

In the meantime, er, welcome to my lastest hack :D

I did that too...sorry Hambil :(

hambil
04-05-2007, 02:09 AM
Damn you Thorn in my Back!!! :D I'll accept a MOTM nomination in repayment :p

Milad
04-05-2007, 03:37 AM
I think your hack contains XSS issue, you use $_REQUEST in the HTML without any check, this opens a security hole.

hambil
04-05-2007, 03:50 AM
I think your hack contains XSS issue, you use $_REQUEST in the HTML without any check, this opens a security hole.
I change the code to run $_REQUEST['t'] through the cleanup process. Other than that no security issue should exist, since I'm only reloading request and post information, not using it in anyway.

Rat1972
04-05-2007, 05:03 AM
Damn you Thorn in my Back!!! :D I'll accept a MOTM nomination in repayment :p

i asked for this mod a week or two ago and now its here. Ofcourse i will nominate it ;) and ofcourse the five stars.
I hope in the future it will also work with quick reply, but that isnt a must. I am glad with this one!

Good work!

Click install

bashy
04-05-2007, 05:06 AM
I only added to the phrase nothing that could have added that extra code, i didnt touch any template!?

It warned me about the last post being made, but when i went to review it it was not the last post it was the post before the last post!

I don't understand - sorry. It looks like you edited the template or the phrase, and that's where the odd characters are coming from on the warning message.

As for the last post/not last post, could you explain better, please?

hambil
04-05-2007, 07:41 AM
I only added to the phrase nothing that could have added that extra code, i didnt touch any template!?

It warned me about the last post being made, but when i went to review it it was not the last post it was the post before the last post!
It checks to see if any posts have been made since you started your post. There could be more than one.

I might consider complicating the query a bit, and providing some varied phrasing. e.g. "A new reply" and "x new replies".

I'll look into the quick reply at the same time. If I do it, I'll make it off by default and admin settable. I can speak only for myself but if I'm using quick reply I don't want a bunch of checks and stuff slowing me down and asking me questions. That's why I using quick reply ;)

Dismounted
04-05-2007, 08:32 AM
Damn! You stole my idea :(, I was in the process of making this. Oh well. But I have a solution to make it work with quick reply :).

hambil
04-05-2007, 09:13 AM
It's not an issue of making it work with quickreply. I chose not to. However, I'll probably make it optional in the next release.

MThornback
04-05-2007, 12:03 PM
Damn you Thorn in my Back!!! :D I'll accept a MOTM nomination in repayment :p

Happily done and done :D

I'm also looking forward to the quick reply add-on to this....I know more of my users use it than the standard reply :)

tandy
04-06-2007, 08:10 AM
Everything fine with IE but warning appear for all reply in firefox.

audis3
04-06-2007, 11:51 AM
Installed and you have 5 stars ;)
Thanks!

PoetJA-1975
04-08-2007, 07:44 PM
Very nice share HAMBIL = Thanx ;)

Jacquii.

Tralala
04-08-2007, 08:41 PM
/bookmarks

I'll install when it supports Quick Reply.

Thanks for sharing this great add-on!

hambil
04-09-2007, 09:29 PM
Since it has been heavily requested, I'll be releasing an update to this soon that supports quick reply. This will require a much more complex (but ultimately more intuitive) method for displaying the warning, due to the AJAX nature of quick reply. Hopefully the upgrade will be ready within the next day or two.

Dismounted
04-10-2007, 11:21 AM
Use the $error[] array.

Luky
04-12-2007, 06:34 AM
99% of my users depend on quick reply ;)

captainslater
04-12-2007, 06:35 AM
Since it has been heavily requested, I'll be releasing an update to this soon that supports quick reply. This will require a much more complex (but ultimately more intuitive) method for displaying the warning, due to the AJAX nature of quick reply. Hopefully the upgrade will be ready within the next day or two.
Great news :)

eNtitY~
04-24-2007, 03:41 PM
I would install this but I think it would be annoying since it doesn't open into a new window, if your browsing new posts or posting it will always change the screen your on to notify you?

Hmm, and yeah once its supported in Quick reply I might consider this.

gutterboy
04-29-2007, 08:16 PM
Great mod - thanks!

gutterboy
04-30-2007, 12:14 PM
Yeah... I have now installed & tested this & was a bit miffed it didn't work with quick reply seeing as forums that use it I assume 90% of users posting use it; any news on when that will be released?

It also just gives you screen telling you that someone has posted & then gives you the choice to continue or go back & edit your post; however, when you go back to edit your post it doesn't show the new post(s) in the topic preview??

Thanks!

hambil
04-30-2007, 06:22 PM
Yeah... I have now installed & tested this & was a bit miffed it didn't work with quick reply
Miffed at my free hack? You might want to lower your vb.org expectations a tad :)

It also just gives you screen telling you that someone has posted & then gives you the choice to continue or go back & edit your post; however, when you go back to edit your post it doesn't show the new post(s) in the topic preview??Yes, that is a problem. I've fixed it, and also added quick reply, but it's a tricky and I haven't worked out the bugs enough to post yet - mostly due to some other things eating up my time. It is a planned and promised release, so hang in there if you can :)

Thanks!You're welcome :)

hambil
04-30-2007, 06:25 PM
Use the $error[] array.
It's not that simple. The $error array works fine (thank you) but detecting if a new post has been added while quick reply was being used is very tricky. At the moment the method I've developed ignores quick replies from pages other than the last. My assumption being that if you are quick replying on page 2 of 10 you don't care about the most recent post anyway. Plus, the data just isn't available to test against.

Dismounted
05-01-2007, 09:02 AM
You could always add an extra field (w/ timestamp) to quick reply to check against.

hambil
05-01-2007, 12:38 PM
You could always add an extra field (w/ timestamp) to quick reply to check against.
In the database? Add a query or two? I don't want to do that, and nothing else is going to survive a page load.

Dismounted
05-02-2007, 07:28 AM
No, a form field, then on submit, check the timestamp.

Braders
05-03-2007, 11:02 AM
Thanks Hambil.

I put it to our users and a majority of 87% to 13% ruled that they want it installed.

Much obliged.

Lee

BBI-Ross
05-04-2007, 12:05 PM
Everything fine with IE but warning appear for all reply in firefox.

Has a fix been found for this problem?

hambil
05-04-2007, 12:26 PM
Has a fix been found for this problem?
Given that I haven't used EI other than to run tests in ages, this has to be a setup/setting issue of some sort on your end. I run this day in and day out with Firefox.

hambil
05-04-2007, 12:27 PM
No, a form field, then on submit, check the timestamp.
I'll look and see if that can be done without file edits.

Luky
05-05-2007, 09:13 AM
Hurry up with the quick reply!! Joke :) You know i didnt think quick reply and standard reply methods were so different o.o

Dismounted
05-06-2007, 05:36 AM
I'll look and see if that can be done without file edits.
It can be done with only template edits and plugins, I've done it but I deleted the files when you released the hack. :(

MotMann
05-06-2007, 03:26 PM
I cant find the Hack in the ACP :(

Luky
05-07-2007, 08:22 AM
I dont belive there are any options, i dont see a need for any.. its a simple mod! :)

Ekka
05-08-2007, 08:08 PM
This has saved me a few times already ... great idea. :up:

hambil
05-08-2007, 08:14 PM
It can be done with only template edits and plugins, I've done it but I deleted the files when you released the hack. :(
Well then do it. I'll co-author you. I'm just really pressed for time and the masses shouldn't suffer for that.

I also plan to add other checks as I think of them btw - thus the generic name 'PostCheck'. For example, I want it to warn about uneven quote tags.

Dismounted
05-09-2007, 07:39 AM
To enable in Quick Reply, just follow the instructions.

1./ In the template 'SHOWTHREAD', find:
<div style="margin-top:$stylevar[cellpadding]px">
Add Below:
<if condition="$poststarttime = TIMENOW"><input type="hidden" name="poststarttime" value="$poststarttime" /></if>

2./ Upload the attached product XML.

Panagioths
05-10-2007, 12:30 PM
thnx for your immediate actions mate. Cheers!

hambil
05-10-2007, 06:49 PM
Updated to work with quickreply. See first post.

PoetJA-1975
05-10-2007, 08:29 PM
AWESOME HAMBIL! Thanx for the update!

Jacquii.

Luky
05-11-2007, 01:09 AM
Finally! :*

Illustrious
05-11-2007, 01:37 AM
Awesome, I was waiting for you to update with the quick-reply. Downloaded, installed, nominated, and voted 5 stars. Great hack :).

Illustrious
05-11-2007, 01:50 AM
There seems to be a bug where it warns on quick reply every time (at least with the WYSIWYG editor)

Luky
05-11-2007, 02:27 AM
Doesnt work.

hambil
05-11-2007, 02:44 AM
Fixed.

Luky
05-11-2007, 03:00 AM
=/ You fixed the error where it says EVERY quick reply says the message of review post?

hambil
05-11-2007, 03:03 AM
=/ You fixed the error where it says EVERY quick reply says the message of review post?
<sarcasm>No, I fixed some random errors and ignored the ones people posted about. </sarcasm>

Yes, that is what I fixed ;)

Luky
05-15-2007, 12:01 PM
I think you lie, because it didnt work when i tried it at the time i posted, its been fixed again since then?

Panagioths
05-15-2007, 03:57 PM
I think that you do something wrong. The bug is fixed mate.

BigJimTheLug
05-15-2007, 04:15 PM
*INstalled* this is so cool!

bkaul
05-16-2007, 02:18 PM
<sarcasm>No, I fixed some random errors and ignored the ones people posted about. </sarcasm>

Yes, that is what I fixed ;)

I'm seeing this problem on my forum as well, and I just downloaded the latest version of the product about 30 seconds ago.

Edit: Hrm... well, I was seeing this, then I hard deleted the test post where I had first noticed it, and now it's not occurring anymore on subsequent posts. Weird :confused:

bkaul
05-16-2007, 02:25 PM
V 1.1 is installed and looks good. Suggested enhancement for future version: use AJAX to update the showthread page with the new post when using Quick Reply :)

bkaul
05-16-2007, 08:52 PM
One other issue I hadn't noticed (as an admin), but my users are reporting -
the minimum time between posts setting (default = 60 seconds for flood prevention) is enforced between the initial attempt to submit and the resubmission when this product interrupts them. I've dropped the minimum post time setting from where I had it at 10 seconds down to 1, so this shouldn't be a practical problem for me, but for larger boards where flood prevention is important, this could become an issue. Every time a regular user tries to submit, if someone's posted in front of them, they'll have to wait another xx seconds to retry, and if someone else has posted in that time, they'll have to wait again, etc.

Obviously disabling the flood prevention delay works around this entirely, but it might be something to look into for the future.

gutterboy
05-16-2007, 11:56 PM
One other issue I hadn't noticed (as an admin), but my users are reporting -
the minimum time between posts setting (default = 60 seconds for flood prevention) is enforced between the initial attempt to submit and the resubmission when this product interrupts them. I've dropped the minimum post time setting from where I had it at 10 seconds down to 1, so this shouldn't be a practical problem for me, but for larger boards where flood prevention is important, this could become an issue. Every time a regular user tries to submit, if someone's posted in front of them, they'll have to wait another xx seconds to retry, and if someone else has posted in that time, they'll have to wait again, etc.

Obviously disabling the flood prevention delay works around this entirely, but it might be something to look into for the future.

Yeah... I installed the latest version & one of my users was testing it & stated the below & saying it was like he was in like a kinda loop..

"I try to quick reply; It gives me the "a new reply has been posted" message; I hit "okay" and try to quick reply again; it gives me the "this forum requires that you wait XX seconds between posts message; I hit okay and try to quick reply; it gives me the "a new reply has been posted"".

Have disabled it for now..... but thanks for your continued work on this! :)

hambil
05-17-2007, 12:24 AM
Yeah... I installed the latest version & one of my users was testing it & stated the below & saying it was like he was in like a kinda loop..

"I try to quick reply; It gives me the "a new reply has been posted" message; I hit "okay" and try to quick reply again; it gives me the "this forum requires that you wait XX seconds between posts message; I hit okay and try to quick reply; it gives me the "a new reply has been posted"".

Have disabled it for now..... but thanks for your continued work on this! :)
That's interesting. I'll see if I can disable flood checking for the resubmitted post, since it's not really appropriate.

dxguru
05-17-2007, 07:51 AM
I've also got the problem where a quick reply ALWAYS says there has been a new post on the first submit :(

PoetJA-1975
05-17-2007, 07:34 PM
Yeah... I installed the latest version & one of my users was testing it & stated the below & saying it was like he was in like a kinda loop..

"I try to quick reply; It gives me the "a new reply has been posted" message; I hit "okay" and try to quick reply again; it gives me the "this forum requires that you wait XX seconds between posts message; I hit okay and try to quick reply; it gives me the "a new reply has been posted"".

Have disabled it for now..... but thanks for your continued work on this! :)

Same thing here. I had to uninstall, but will look forward to the next update and bugs are worked out ;)

Jacquii.

hambil
05-17-2007, 09:50 PM
I've also got the problem where a quick reply ALWAYS says there has been a new post on the first submit :(
I have this running on my board and do not have this problem. I suspect the template edit has failed for you and the others reporting this issue - probably due to skin or other customization. Turn off auto-replace in the hacks settings, and manually update your template.

Mrdby
05-18-2007, 07:26 PM
3.6.6?

Dismounted
05-19-2007, 11:25 AM
This will work on any version of the 3.6 branch.

ShackMaster
05-21-2007, 05:54 PM
Not sure if you've been notified, but it does have a bug with at least 3.6.7 where the Manage Attachments will not work from the Go Advanced button on Quick Reply (user will get a No Permissions error)... supposedly due to a conflict with the $poststarttime variable that is added to the showthread template.

Once you get this issue worked out with vB 3.6.7... I'll be all over it again. This is probably one of the best hacks ever developed. I appreciate your work on it.

hambil
05-22-2007, 09:10 AM
Not sure if you've been notified, but it does have a bug with at least 3.6.7 where the Manage Attachments will not work from the Go Advanced button on Quick Reply (user will get a No Permissions error)... supposedly due to a conflict with the $poststarttime variable that is added to the showthread template.

Once you get this issue worked out with vB 3.6.7... I'll be all over it again. This is probably one of the best hacks ever developed. I appreciate your work on it.
Hmmm. Well, I'm upgrading to 3.6.7 now, so hopefully I'll be able to look at it soon. Thanks :)

cheat-master30
05-24-2007, 12:54 PM
Not sure if this is the right mod, or if I forgot to update, but with this version shown in the screenshot on vBulletin 3.6.7, there is this problem:


http://h1.ripway.com/ukmidis/image004.jpg

How do you remove the end / and > from being visible? Tried templates, but couldn't find the cause of that.

hambil
05-24-2007, 01:50 PM
Not sure if this is the right mod
That's the old version. You need to update.

cheat-master30
05-24-2007, 02:31 PM
Thanks, I'll update now.

gutterboy
06-15-2007, 08:31 PM
That's interesting. I'll see if I can disable flood checking for the resubmitted post, since it's not really appropriate.

Has this issue been addressed yet?

Thanks!

Carlos2
06-16-2007, 02:48 AM
I uninstalled this hack because sometimes is very awful and difficult to answer a post because always somebody answer the thread before you and always the post Stop you your answer. If could be only a announcement to the user that are posts that he didnt read without stoping the writeninng of the post...