View Full Version : Add-On Releases - Post Edit History (PEH)
Surviver
11-27-2006, 10:00 PM
Edithistory (1.5.0 B 3)
What does this Modification?
This Modification saves a version of a post if someone edits it. If there are saved edits for a post, you can view the "Post History" and you are able to restore old posts.
Also you can compare saved versions of a post.
Installation
Installation-Instructions are included in the zip-File
What's new in Version 1.5.0 B 2?
In this version i made a lot of improvement: eg. I've overwritten the code, the Ajax Compare function now works properly (Screen #3) and I implented a function to mass restore posts of a user. (Screen #6)
Screenshots
#1
71292
#2
71293
#3 (Compare saved version)
71294
#4 (Usergroup Permissions)
71295
#5
71296
#6 (Mass Restore posts of a user)
71297
Not translated yet
- Admin Help
ss
I only get a blank page after the update, waht can I do?
See the new FAQ (http://vbpoint.net/board/faq.php?faq=peh)
ss
Regards
Surviver
PS: I'm very sorry about my bad english ;)
PPS:If you use it, please klick install (https://vborg.vbsupport.ru/vborg_miscactions.php?do=installhack&threadid=132708)!
Masiello
11-28-2006, 04:11 PM
Thanks, wow my first post!
Stoebi
11-28-2006, 04:25 PM
Thx a lot :)
Nice work!
iran.gs
11-28-2006, 04:41 PM
Nice, Installed
Very nice! I made a slight change to the phrase and position. I think it looks better there (for those using the legacy postbit). If anyone else wants to do it I just added the text after:
<if condition="$show['postcount']">#<a href="showpost.php?$session[sessionurl]p=$post[postid]&postcount=$post[postcount]" target="new" rel="nofollow" id="postcount$post[postid]" name="$post[postcount]"><strong>$post[postcount]</strong></a></if>
COBRAws
11-29-2006, 12:18 AM
What's the difference with this one by Lieva?
https://vborg.vbsupport.ru/showthread.php?t=105989
Viper007Bond
11-29-2006, 02:07 AM
What's the difference with this one by Lieva?
https://vborg.vbsupport.ru/showthread.php?t=105989
That one is for vB 3.5.x and doesn't work properly with vB 3.6.x. ;)
Viper007Bond
11-29-2006, 02:32 AM
Installed on my test install and works great!
I did change the "edit_history_edit_bit" template though:
<tr>
<td class="tcat" width="45%" colspan="3">$vbphrase[new]</td>
<td class="tcat" width="45%" colspan="3">$vbphrase[old]</td>
</tr>
to...
<tr>
<td class="tcat" width="10%" colspan="2"> </td>
<td class="tcat" width="45%" colspan="2">$vbphrase[new]</td>
<td class="tcat" width="45%" colspan="2">$vbphrase[old]</td>
</tr>
Makes the headers line up a lot better. :)
I also changed the "&" in the URL to "&" to make it validate. ;)
Viper007Bond
11-29-2006, 03:01 AM
Hmm, seems you're missing a "TABLE_PREFIX" somewhere:
Database error in vBulletin 3.6.4:
Invalid SQL:
SELECT edithistory.*, user.*, edithistory.dateline as editdate FROM
vb_edithistory as edithistory
LEFT JOIN user as user ON(user.userid = edithistory.edituserid)
WHERE edithistory.postid = 361324
ORDER BY editid DESC;
MySQL Error : Table 'finalgear_vb.user' doesn't exist
Error Number : 1146
Date : Wednesday, November 29th 2006 @ 05:00:39 AM
Script : http://forums.finalgear.com/edithistory.php?do=viewedithistory&postid=361324
Referrer :
IP Address : [removed]
Username : Viper007Bond
Classname : vb_database
Surviver
11-29-2006, 03:48 AM
Very nice! I made a slight change to the phrase and position. I think it looks better there (for those using the legacy postbit). If anyone else wants to do it I just added the text after:
<if condition="$show['postcount']">#<a href="showpost.php?$session[sessionurl]p=$post[postid]&postcount=$post[postcount]" target="new" rel="nofollow" id="postcount$post[postid]" name="$post[postcount]"><strong>$post[postcount]</strong></a></if>
Thank you for this, looks cool :)
What's the difference with this one by Lieva?
https://vborg.vbsupport.ru/showthread.php?t=105989
This Hack is for 3.6.x :P
That one is for vB 3.5.x and doesn't work properly with vB 3.6.x. ;)
Installed on my test install and works great!
I did change the "edit_history_edit_bit" template though:
<tr>
<td class="tcat" width="45%" colspan="3">$vbphrase[new]</td>
<td class="tcat" width="45%" colspan="3">$vbphrase[old]</td>
</tr>
to...
<tr>
<td class="tcat" width="10%" colspan="2"> </td>
<td class="tcat" width="45%" colspan="2">$vbphrase[new]</td>
<td class="tcat" width="45%" colspan="2">$vbphrase[old]</td>
</tr>
Makes the headers line up a lot better. :)
I also changed the "&" in the URL to "&" to make it validate. ;)
Ok, cachged in the New Version :)
Hmm, seems you're missing a "TABLE_PREFIX" somewhere:
Database error in vBulletin 3.6.4:
Invalid SQL:
SELECT edithistory.*, user.*, edithistory.dateline as editdate FROM
vb_edithistory as edithistory
LEFT JOIN user as user ON(user.userid = edithistory.edituserid)
WHERE edithistory.postid = 361324
ORDER BY editid DESC;
MySQL Error : Table 'finalgear_vb.user' doesn't exist
Error Number : 1146
Date : Wednesday, November 29th 2006 @ 05:00:39 AM
Script : http://forums.finalgear.com/edithistory.php?do=viewedithistory&postid=361324
Referrer :
IP Address : [removed]
Username : Viper007Bond
Classname : vb_database
Thank you for reporting that, fixed in Version 1.1.6
Greetings Surviver
*updated*
Viper007Bond
11-29-2006, 04:13 AM
Thank you for reporting that, fixed in Version 1.1.6
Not fixed. I dunno if it failed to install correctly or what (I run a good sized forum and it mighta timed out while altering a table? *shrugs*).
Database error in vBulletin 3.6.4:
Invalid SQL:
SELECT edithistory.*, user.*, edithistory.dateline as editdate FROM
vb_edithistory as edithistory
LEFT JOIN user as user ON(user.userid = edithistory.edituserid)
WHERE edithistory.postid = 361324
ORDER BY editid DESC;
MySQL Error : Table 'finalgear_vb.user' doesn't exist
Error Number : 1146
Date : Wednesday, November 29th 2006 @ 06:12:09 AM
Script : http://forums.finalgear.com/edithistory.php?do=viewedithistory&postid=361324
Referrer : http://forums.finalgear.com/showthread.php?t=15110
IP Address : [removed]
Username : Viper007Bond
Classname : vb_database
COBRAws
11-29-2006, 04:46 AM
This Hack is for 3.6.x :P[/B]
I think you should say its a port of X hack ;)
Surviver
11-29-2006, 10:33 AM
I think you should say its a port of X hack ;)
No, it isn't ;)
Surviver
11-29-2006, 10:37 AM
Not fixed. I dunno if it failed to install correctly or what (I run a good sized forum and it mighta timed out while altering a table? *shrugs*).
Database error in vBulletin 3.6.4:
Invalid SQL:
SELECT edithistory.*, user.*, edithistory.dateline as editdate FROM
vb_edithistory as edithistory
LEFT JOIN user as user ON(user.userid = edithistory.edituserid)
WHERE edithistory.postid = 361324
ORDER BY editid DESC;
MySQL Error : Table 'finalgear_vb.user' doesn't exist
Error Number : 1146
Date : Wednesday, November 29th 2006 @ 06:12:09 AM
Script : http://forums.finalgear.com/edithistory.php?do=viewedithistory&postid=361324
Referrer : http://forums.finalgear.com/showthread.php?t=15110
IP Address : [removed]
Username : Viper007Bond
Classname : vb_database
Ok, noew its really fixed, i attached the wrng file :alien:
captainslater
11-29-2006, 11:13 AM
Thx Surviver, installed :)
Viper007Bond
11-29-2006, 05:32 PM
Ok, noew its really fixed, i attached the wrng file :alien:
Yay, works great now! :D
I made the cron daily though as it's not super important that excess post histories be removed for me ASAP. :)
KidCharlemane
12-01-2006, 01:23 AM
How long are old posts saved? Im assuming this is configurable? I dont see any documentation with the hack so I'm asking here.
Viper007Bond
12-01-2006, 03:16 AM
How long are old posts saved?
As long as the original posts exists. Why would you want it another way?
KidCharlemane
12-01-2006, 04:03 AM
Well, because it seems like it would add a lot of database bloat on large forums.
Viper007Bond
12-01-2006, 09:14 AM
Well, because it seems like it would add a lot of database bloat on large forums.
It's a separate database table and it doesn't add any extra queries when viewing posts. Where's the bloat in that? I mean sure, it adds extra filesize to the database, but are you that pressed for space?
beduino
12-01-2006, 10:37 AM
Hello Surviver!
Really the hack is awesome :D
And the video !!!!!!!!!!!!!!!!!!! :) I love it! Final is funny too ;)
All the best
Beduino
Surviver
12-01-2006, 11:31 AM
As long as the original posts exists. Why would you want it another way?
Well, because it seems like it would add a lot of database bloat on large forums.
It's a separate database table and it doesn't add any extra queries when viewing posts. Where's the bloat in that? I mean sure, it adds extra filesize to the database, but are you that pressed for space?
You can activate/deactivate ist per Usergroup and Forum ;)
You can ever run the Cron, maybe once a wekk or once a day ;)
Greetings SUrviver
Surviver
12-01-2006, 08:27 PM
Update !
v 1.1.6
[F] Fixed table Prefix Bug
[+] Some Templatecachnges
v 1.1.7
[+] New Option: BBCode Type
[+] Edithistory Results will now be paginated
v 1.1.8
[+] Added Advanced WOL support
[+] Edits can now be deleted
[+] New Usergrouppermissions
v 1.1.9
[+] Some hooks added
Protonus
12-01-2006, 09:32 PM
Thank you SO much !! This is awesome!
ninjamaster
12-01-2006, 10:35 PM
thanks nice work
Who all can see the edit histories? Can you set it so that admin/moderators are the only users who can see the edits and history?
Surviver
12-02-2006, 08:20 PM
Who all can see the edit histories? Can you set it so that admin/moderators are the only users who can see the edits and history?
You must activate it in the forums you want.
The Permissions you can set up in the Usergroup manager, there are some Settings aviable:
Can view own Edithistory
Yes No
Can view all Edithistory
Yes No
Can restore own Edithistorys
Yes No
Can restore all Edithistorys
Yes No
Log Edits done by this Group ?
Yes No
Can delete own edits ?
Yes No
Can delete all edits ?
Yes No
DannyMilner
12-02-2006, 09:07 PM
Great idea, I will be installing...
Nathan2006
12-03-2006, 01:16 AM
Thank you Surviver,
This is really good this version :D
Install
Just 1 small problem, How do I make the text full on the edit history (Screeshot added)
Thank you :)
Surviver
12-03-2006, 04:27 AM
Thank you Surviver,
This is really good this version :D
Install
Just 1 small problem, How do I make the text full on the edit history (Screeshot added)
Thank you :)
Mmmh, ist does work for me ...
Has you installed a hack like bbcode permissions ?
Greetings Surviver
Nathan2006
12-03-2006, 04:32 AM
Mmmh, ist does work for me ...
Has you installed a hack like bbcode permissions ?
Greetings Surviver
Hi,
Yes I have Advanced BBCode Permissions (https://vborg.vbsupport.ru/showthread.php?t=122942) installed :(
I just disabled it and it worked great.
Is there anyway to overcome this problem without removing the other hack?
Thank you for you're reply :)
Surviver
12-03-2006, 07:10 AM
Hi,
Yes I have Advanced BBCode Permissions (https://vborg.vbsupport.ru/showthread.php?t=122942) installed :(
I just disabled it and it worked great.
Is there anyway to overcome this problem without removing the other hack?
Thank you for you're reply :)
This Hack makes Prolems, i've written some Hacks with parsing bbcode (guestboo, this and an other), and all didn't work with this Hack.
I dont know hy, but i use the vBulletin Standard to parse bbCode.
It seems that the other Hack has a bu, i've heared about it often ;)
Greetings SUrviver
Viper007Bond
12-03-2006, 11:23 PM
Seems there's still SQL issues, this time with your cron. :(
Invalid SQL:
DELETE edithistory
FROM vb_edithistory as edithistory
LEFT JOIN vb_post as vb_post ON(vb_post.postid = vb_edithistory.postid)
WHERE vb_post.postid IS NULL;
MySQL Error : Unknown table 'vb_edithistory' in on clause
Error Number : 1109
Date : Sunday, December 3rd 2006 @ 12:18:02 PM
Script : http://forums.finalgear.com/ajax_cron.php?rand=764482
Referrer : http://forums.finalgear.com/showthread.php?t=13083&page=36
IP Address : 83.160.166.100
Username : Unregistered
Classname : vb_database
ajax_cron.php is an AJAX replacement for the built in image cron, but that shouldn't be affecting this. It's the same thing, it just runs the crons as JS rather than images. ;)
Nathan2006
12-04-2006, 12:40 AM
This Hack makes Prolems, i've written some Hacks with parsing bbcode (guestboo, this and an other), and all didn't work with this Hack.
I dont know hy, but i use the vBulletin Standard to parse bbCode.
It seems that the other Hack has a bu, i've heared about it often ;)
Greetings SUrviver
its not that much of a problem really lol I only have a few members who use different fonts and colors ;)
Thanks for your reply tho :)
COBRAws
12-04-2006, 12:49 AM
No, it isn't ;)
Oh, ok sorry.
So whats the difference with the 3.5 Post Edit History Viewer hack? Because I'll update soon and dont know if I need to switch or stay.
Thanks!
Surviver
12-04-2006, 12:08 PM
Seems there's still SQL issues, this time with your cron. :(
Invalid SQL:
DELETE edithistory
FROM vb_edithistory as edithistory
LEFT JOIN vb_post as vb_post ON(vb_post.postid = vb_edithistory.postid)
WHERE vb_post.postid IS NULL;
MySQL Error : Unknown table 'vb_edithistory' in on clause
Error Number : 1109
Date : Sunday, December 3rd 2006 @ 12:18:02 PM
Script : http://forums.finalgear.com/ajax_cron.php?rand=764482
Referrer : http://forums.finalgear.com/showthread.php?t=13083&page=36
IP Address : 83.160.166.100
Username : Unregistered
Classname : vb_database
ajax_cron.php is an AJAX replacement for the built in image cron, but that shouldn't be affecting this. It's the same thing, it just runs the crons as JS rather than images. ;)
Yes, this is a konow bug, it will be fixed in Version 1.2.0 ;)
Oh, ok sorry.
So whats the difference with the 3.5 Post Edit History Viewer hack? Because I'll update soon and dont know if I need to switch or stay.
Thanks!
I don't know the other Hack very good, but with this Hack you have Usergroupsettings, Forumsettings, You can restore Posts and some more ;)
-----
Greetings Surviver
Surviver
12-09-2006, 02:11 PM
New Version in the first Post !!
Viper007Bond
12-09-2006, 02:31 PM
Cool!
Surviver
12-09-2006, 02:59 PM
Cool!
I hope all will work fine now :)
Viper007Bond
12-09-2006, 03:26 PM
Sadly, it doesn't. :(
Database error in vBulletin 3.6.4:
Invalid SQL:
INSERT INTO vb_edithistory
(postid, oldtitle, newtitle, oldtxt, newtxt, newreason, oldreason, dateline, edituserid, editusername)
VALUES
((366862, '', '', '[post contents removed]', '', '', 1165684492, 13306, '[username removed]');
MySQL Error : Unknown column 'newreason' in 'field list'
Error Number : 1054
Date : Saturday, December 9th 2006 @ 05:14:52 PM
Script : http://forums.finalgear.com/editpost.php?do=updatepost&postid=366862
Referrer :
IP Address : [removed]
Username : [removed]
Classname : vb_database
Did you make sure to add in upgrade code that'd ALTER the table?
Surviver
12-09-2006, 05:08 PM
Sadly, it doesn't. :(
Database error in vBulletin 3.6.4:
Invalid SQL:
INSERT INTO vb_edithistory
(postid, oldtitle, newtitle, oldtxt, newtxt, newreason, oldreason, dateline, edituserid, editusername)
VALUES
((366862, '', '', '[post contents removed]', '', '', 1165684492, 13306, '[username removed]');
MySQL Error : Unknown column 'newreason' in 'field list'
Error Number : 1054
Date : Saturday, December 9th 2006 @ 05:14:52 PM
Script : http://forums.finalgear.com/editpost.php?do=updatepost&postid=366862
Referrer :
IP Address : [removed]
Username : [removed]
Classname : vb_database
Did you make sure to add in upgrade code that'd ALTER the table?
The install code had the false Version ;)
new Version attached :)
Viper007Bond
12-10-2006, 12:37 AM
Thanks. :)
EDIT: Bah!
Altering Table edithistory ...
Fatal error: Call to a member function on a non-object in [...]/forums/htdocs/admincp/plugin.php(1941) : eval()'d code on line 3
Surviver
12-10-2006, 04:52 AM
Thanks. :)
EDIT: Bah!
Altering Table edithistory ...
Fatal error: Call to a member function on a non-object in [...]/forums/htdocs/admincp/plugin.php(1941) : eval()'d code on line 3
Ok, Got to ACP -> Plugins & Products -> Manage Products -> Post Edit History -> Edit -> Go -> Version -> Enter 1.2.0 -> Save.
The Import the ATtached Produkt !
Say if it works :)
Greetings SUrviver
Viper007Bond
12-10-2006, 06:15 AM
Version was already at 1.2.0 (guess it never got updated since the import failed).
Importing the file you just attached results in a DB error:
Database error in vBulletin 3.6.4:
Invalid SQL:
ALTER TABLE vb_edithistory CHANGE reason oldreason varchar(255);
MySQL Error : Unknown column 'reason' in 'vb_edithistory'
Error Number : 1054
Date : Sunday, December 10th 2006 @ 08:14:17 AM
Script : http://forums.finalgear.com/admincp/plugin.php?do=productimport
Referrer : http://forums.finalgear.com/admincp/plugin.php?do=productadd
IP Address : [removed]
Username : Viper007Bond
Classname : vb_database
Surviver
12-10-2006, 06:42 AM
Version was already at 1.2.0 (guess it never got updated since the import failed).
Importing the file you just attached results in a DB error:
Database error in vBulletin 3.6.4:
Invalid SQL:
ALTER TABLE vb_edithistory CHANGE reason oldreason varchar(255);
MySQL Error : Unknown column 'reason' in 'vb_edithistory'
Error Number : 1054
Date : Sunday, December 10th 2006 @ 08:14:17 AM
Script : http://forums.finalgear.com/admincp/plugin.php?do=productimport
Referrer : http://forums.finalgear.com/admincp/plugin.php?do=productadd
IP Address : [removed]
Username : Viper007Bond
Classname : vb_database
Sorry my Mistake, run the following QUery
ALTER TABLE vb_edithistory CHANGE oldreason reason varchar(255);
Then import the product again !
Greetings Surviver
Nathan2006
12-10-2006, 09:14 AM
Thanks Surviver,
Updated and working great!
;)
Viper007Bond
12-10-2006, 10:41 AM
Ran the query, changed the version number in my admin area to 1.2.1 (so the broken upgrade code wouldn't run), and ran the XML you had attached. Everything works now. :)
Surviver
12-10-2006, 12:12 PM
Ran the query, changed the version number in my admin area to 1.2.1 (so the broken upgrade code wouldn't run), and ran the XML you had attached. Everything works now. :)
Cool, and Sorry for my Mistakes ;)
Protonus
12-10-2006, 10:12 PM
Updated, works, thanx!
Jackal von ?RF
12-14-2006, 06:56 PM
At my forums there have been two cases when a user edited all of his messages to remove them from the forums (in one case he had over a thousand messages and it took him two days to edit them). What I've done to them is ban them (removing their right to edit their own posts) and restored all the messages from a backup (takes a couple of hours when writing some SQL scripts manually).
It would be nice if this mod offered the possibility to mass-undo all edits which a user made within a specific time frame. The same way as the prune tools in vB's Admin CP work. It should show all individual edits (before and after editing), when it was done, who edited it, and there should be a checkbox for selecting the edits which should be undone.
It would also be nice for the program to send a PM to the admins/moderators when a user edits many of his old messages in a short time. It should be configurable so, that editing even one old message (for example older than 30 days) would send a PM. Then the moderators could quickly stop the user from editing all of his messages away.
Anyways, thanks for your work. Your script looks promising. I'll try it soon. I first thought about creating a similar script myself, but luckily you had already done the job. :) (I might even offer some help in adding these features I requested, if I really like your script and I have the time.)
EDIT 1:
I looked quickly through your code (v1.2.1) and noticed the query in \includes\cron\edithistory.php. Wouldn't it look much nicer if it was written like this?
$vbulletin->db->query_write("
DELETE edithistory
FROM " . TABLE_PREFIX . "edithistory AS edithistory
LEFT JOIN " . TABLE_PREFIX . "post AS post ON (post.postid = edithistory.postid)
WHERE post.postid IS NULL
");
Or does this have to do with the incompatibility between MySQL 4.0 and 4.1 as mentioned here (http://dev.mysql.com/doc/refman/4.1/en/delete.html)? In that case how about writing it without the "AS" keyword like this? Also there should be a comment which would tell about the incompatibility and why the SQL had to be written in an ugly way. (In any case format the SQL to have less tabs; indentation of one tab instead of eight.)
$vbulletin->db->query_write("
DELETE " . TABLE_PREFIX . "edithistory
FROM " . TABLE_PREFIX . "edithistory
LEFT JOIN " . TABLE_PREFIX . "post ON (" . TABLE_PREFIX . "post.postid = " . TABLE_PREFIX . "edithistory.postid)
WHERE " . TABLE_PREFIX . "post.postid IS NULL
");
EDIT 2:
Does the field edithistory.postid have an index at all? I noticed quite many queries use it in the WHERE condition, but I didn't find anywhere an index for it to be created. This might create full scans of the edithistory table...
Also, I noticed the following line of code. Since reason is a text field, the value assigned to it should be quoted in the SQL query. It would be a good habbit to always quote the values, even if you know that they are numeric.
$db->query_write("UPDATE " .TABLE_PREFIX. "editlog SET reason = ".$edit['oldreason']." WHERE postid = ".$postinfo['postid']."");
Also, I noticed from my DB dump of vB3.5.x (first install was 2.3.5 or older) that the editlog.reason field is defined as `reason` varchar(200) NOT NULL default '' but in your code you have the oldreason and newreason fields defined as varchar(255). Could somebody with a clean vB3.6.x install check that what the size should be?
EDIT 3:
As somebody already mentioned, there's no need for the cron job to run more often that once a day or week (I think it's now by default once an hour). It's rare that posts get physically deleted, so most of the time the cron job would do nothing. I hope you have checked that it uses indexes correctly and runs quickly. I'm just a bit worried because checking every postid might take some time for a big board... My board has some 300K posts and also boards with millions of posts exist. It would be better to remove those rows from edithistory when a post gets physically deleted, and not in a cron job.
PS: I think you should tick the boxes "Additional files" and "Is in Beta stage" for this mod. Also I recommend you to write more comments in your code (I didn't notice any).
Surviver
12-15-2006, 11:43 AM
At my forums there have been two cases when a user edited all of his messages to remove them from the forums (in one case he had over a thousand messages and it took him two days to edit them). What I've done to them is ban them (removing their right to edit their own posts) and restored all the messages from a backup (takes a couple of hours when writing some SQL scripts manually).
It would be nice if this mod offered the possibility to mass-undo all edits which a user made within a specific time frame. The same way as the prune tools in vB's Admin CP work. It should show all individual edits (before and after editing), when it was done, who edited it, and there should be a checkbox for selecting the edits which should be undone.
I will see, waht I can do ;)
It would also be nice for the program to send a PM to the admins/moderators when a user edits many of his old messages in a short time. It should be configurable so, that editing even one old message (for example older than 30 days) would send a PM. Then the moderators could quickly stop the user from editing all of his messages away.
This would add 1-2 Querys if you edit a post ... (And not nany user would use ist)
Anyways, thanks for your work. Your script looks promising. I'll try it soon. I first thought about creating a similar script myself, but luckily you had already done the job. :) (I might even offer some help in adding these features I requested, if I really like your script and I have the time.)
EDIT 1:
I looked quickly through your code (v1.2.1) and noticed the query in \includes\cron\edithistory.php. Wouldn't it look much nicer if it was written like this?
$vbulletin->db->query_write("
DELETE edithistory
FROM " . TABLE_PREFIX . "edithistory AS edithistory
LEFT JOIN " . TABLE_PREFIX . "post AS post ON (post.postid = edithistory.postid)
WHERE post.postid IS NULL
");
Or does this have to do with the incompatibility between MySQL 4.0 and 4.1 as mentioned here (http://dev.mysql.com/doc/refman/4.1/en/delete.html)? In that case how about writing it without the "AS" keyword like this? Also there should be a comment which would tell about the incompatibility and why the SQL had to be written in an ugly way. (In any case format the SQL to have less tabs; indentation of one tab instead of eight.)
$vbulletin->db->query_write("
DELETE " . TABLE_PREFIX . "edithistory
FROM " . TABLE_PREFIX . "edithistory
LEFT JOIN " . TABLE_PREFIX . "post ON (" . TABLE_PREFIX . "post.postid = " . TABLE_PREFIX . "edithistory.postid)
WHERE " . TABLE_PREFIX . "post.postid IS NULL
");
Or does this have to do with the incompatibility between MySQL 4.0 and 4.1 as mentioned here (http://dev.mysql.com/doc/refman/4.1/en/delete.html)? Yes !
EDIT 2:
Does the field edithistory.postid have an index at all? I noticed quite many queries use it in the WHERE condition, but I didn't find anywhere an index for it to be created. This might create full scans of the edithistory table...
I will add it !
Also, I noticed the following line of code. Since reason is a text field, the value assigned to it should be quoted in the SQL query. It would be a good habbit to always quote the values, even if you know that they are numeric.
$db->query_write("UPDATE " .TABLE_PREFIX. "editlog SET reason = ".$edit['oldreason']." WHERE postid = ".$postinfo['postid']."");
I will fix it ! :)
Also, I noticed from my DB dump of vB3.5.x (first install was 2.3.5 or older) that the editlog.reason field is defined as `reason` varchar(200) NOT NULL default '' but in your code you have the oldreason and newreason fields defined as varchar(255). Could somebody with a clean vB3.6.x install check that what the size should be?
Why is the size important? ;)
EDIT 3:
As somebody already mentioned, there's no need for the cron job to run more often that once a day or week (I think it's now by default once an hour). It's rare that posts get physically deleted, so most of the time the cron job would do nothing. I hope you have checked that it uses indexes correctly and runs quickly. I'm just a bit worried because checking every postid might take some time for a big board... My board has some 300K posts and also boards with millions of posts exist. It would be better to remove those rows from edithistory when a post gets physically deleted, and not in a cron job.
PS: I think you should tick the boxes "Additional files" and "Is in Beta stage" for this mod. Also I recommend you to write more comments in your code (I didn't notice any).
I will check Additional Files, but it is not really a beta Release.
Maybe it has some bug, but its no relly Beta ;)
Thanky for your feedback !
Greetings Surviver
Jackal von ?RF
12-16-2006, 04:31 AM
This would add 1-2 Querys if you edit a post ... (And not nany user would use ist)
Another way would be have search functions in the Admin CP, with which it would be possible to search for suspicious mass edits of old messages. For example in the same place where the controls for mass undoing the edits would be. Or some other way to view all edits which the users have done (just like there is the Moderator Log to see all moderation actions). The biggest problem might be, that how a large number of edits could be visualized informatively and effectively in a small space.
The feature of sending automatic PMs is not very important (and might not even be the optimal solution to the problem), so don't worry about implementing it yet. Maybe I'll make a custom tool for analyzing the edit actions. In any case I'll first need to experiment a bit to find a good way to visualize the edits, after I've had the edit history in use for some time and gathered real usage data.
I'll keep you informed if I get some good ideas.
Why is the size important? ;)
Well, since they are VARCHAR fields, I suppose it doesn't take any more space from the database than a VARCHAR(200) would take. So it's not really a problem. Just a matter of style and consistency.
Surviver
12-16-2006, 11:41 AM
Another way would be have search functions in the Admin CP, with which it would be possible to search for suspicious mass edits of old messages. For example in the same place where the controls for mass undoing the edits would be. Or some other way to view all edits which the users have done (just like there is the Moderator Log to see all moderation actions). The biggest problem might be, that how a large number of edits could be visualized informatively and effectively in a small space.
The feature of sending automatic PMs is not very important (and might not even be the optimal solution to the problem), so don't worry about implementing it yet. Maybe I'll make a custom tool for analyzing the edit actions. In any case I'll first need to experiment a bit to find a good way to visualize the edits, after I've had the edit history in use for some time and gathered real usage data.
I'll keep you informed if I get some good ideas.
Well, since they are VARCHAR fields, I suppose it doesn't take any more space from the database than a VARCHAR(200) would take. So it's not really a problem. Just a matter of style and consistency.
Ok, i will canch it in the new version. Annd i'll add an index ;)
Jackal von ?RF
01-08-2007, 08:01 PM
Database error in vBulletin 3.6.4:
Invalid SQL:
UPDATE vb_editlog SET reason = fda WHERE postid = 354660;
MySQL Error : Unknown column 'fda' in 'field list'
Error Number : 1054
Date : Monday, January 8th 2007 @ 11:59:09 PM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=5
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
This has not yet been fixed in v1.2.2. Also, the value needs to be escaped. If only single quotes are added to the query, it will make the database vulnerable to SQL injection attack:
Database error in vBulletin 3.6.4:
Invalid SQL:
UPDATE vb_editlog SET reason = 'aa ' bee' WHERE postid = 354660;
MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'bee' WHERE postid = 354660' at line 1
Error Number : 1064
Date : Tuesday, January 9th 2007 @ 12:03:10 AM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=6
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
I also found that the rest of your the code is vulnerable to SQL injection attacks. You must ALWAYS escape EVERY parameter that is put to an SQL query:
Database error in vBulletin 3.6.4:
Invalid SQL:
INSERT INTO vb_editlog (postid, userid, username, dateline, reason) VALUES('354660', '468', 'Jackal von ?RF', '1168294059', 'a ' b');
MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'b')' at line 1
Error Number : 1064
Date : Tuesday, January 9th 2007 @ 12:07:39 AM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=12
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
I've attached a version of edithistory.php where the above security holes have been fixed.
All users of PEH 1.2.2 (and below) are STRONGLY RECOMMENDED to apply this patch, or disable PEH.
PS: I noticed that there are more detailed instructions for installing PEH at http://www.my-vb.org/board/showthread.php?t=236 (fortunately I can read German, I'm worried about everybody else ;)). Could you also make the English instructions more detailed? Also, please include the instructions as a text file to the ZIP file, so that it would not be necessary to read this thread for the instructions.
Surviver
01-10-2007, 05:37 PM
Database error in vBulletin 3.6.4:
Invalid SQL:
UPDATE vb_editlog SET reason = fda WHERE postid = 354660;
MySQL Error : Unknown column 'fda' in 'field list'
Error Number : 1054
Date : Monday, January 8th 2007 @ 11:59:09 PM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=5
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
This has not yet been fixed in v1.2.2. Also, the value needs to be escaped. If only single quotes are added to the query, it will make the database vulnerable to SQL injection attack:
Database error in vBulletin 3.6.4:
Invalid SQL:
UPDATE vb_editlog SET reason = 'aa ' bee' WHERE postid = 354660;
MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'bee' WHERE postid = 354660' at line 1
Error Number : 1064
Date : Tuesday, January 9th 2007 @ 12:03:10 AM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=6
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
I also found that the rest of your the code is vulnerable to SQL injection attacks. You must ALWAYS escape EVERY parameter that is put to an SQL query:
Database error in vBulletin 3.6.4:
Invalid SQL:
INSERT INTO vb_editlog (postid, userid, username, dateline, reason) VALUES('354660', '468', 'Jackal von ?RF', '1168294059', 'a ' b');
MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'b')' at line 1
Error Number : 1064
Date : Tuesday, January 9th 2007 @ 12:07:39 AM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=12
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
I've attached a version of edithistory.php where the above security holes have been fixed.
All users of PEH 1.2.2 (and below) are STRONGLY RECOMMENDED to apply this patch, or disable PEH.
PS: I noticed that there are more detailed instructions for installing PEH at http://www.my-vb.org/board/showthread.php?t=236 (fortunately I can read German, I'm worried about everybody else ;)). Could you also make the English instructions more detailed? Also, please include the instructions as a text file to the ZIP file, so that it would not be necessary to read this thread for the instructions.
Thank you, this is MY Mistake. I will attache a complete fixed Version in the first post, i inserted your name as co-author ;)
I'll include the Installation Instructions,. but the Problem is, my English is too bad :(
I'll give my best ;)
Greetings SUrviver
Surviver
01-10-2007, 06:22 PM
Database error in vBulletin 3.6.4:
Invalid SQL:
UPDATE vb_editlog SET reason = fda WHERE postid = 354660;
MySQL Error : Unknown column 'fda' in 'field list'
Error Number : 1054
Date : Monday, January 8th 2007 @ 11:59:09 PM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=5
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
This has not yet been fixed in v1.2.2. Also, the value needs to be escaped. If only single quotes are added to the query, it will make the database vulnerable to SQL injection attack:
Database error in vBulletin 3.6.4:
Invalid SQL:
UPDATE vb_editlog SET reason = 'aa ' bee' WHERE postid = 354660;
MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'bee' WHERE postid = 354660' at line 1
Error Number : 1064
Date : Tuesday, January 9th 2007 @ 12:03:10 AM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=6
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
I also found that the rest of your the code is vulnerable to SQL injection attacks. You must ALWAYS escape EVERY parameter that is put to an SQL query:
Database error in vBulletin 3.6.4:
Invalid SQL:
INSERT INTO vb_editlog (postid, userid, username, dateline, reason) VALUES('354660', '468', 'Jackal von ?RF', '1168294059', 'a ' b');
MySQL Error : You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'b')' at line 1
Error Number : 1064
Date : Tuesday, January 9th 2007 @ 12:07:39 AM
Script : http://foorumit.fffin.com/edithistory.php?do=restore&editid=12
Referrer :
IP Address : x.x.x.x
Username : Jackal von ?RF
Classname : vb_database
I've attached a version of edithistory.php where the above security holes have been fixed.
All users of PEH 1.2.2 (and below) are STRONGLY RECOMMENDED to apply this patch, or disable PEH.
PS: I noticed that there are more detailed instructions for installing PEH at http://www.my-vb.org/board/showthread.php?t=236 (fortunately I can read German, I'm worried about everybody else ;)). Could you also make the English instructions more detailed? Also, please include the instructions as a text file to the ZIP file, so that it would not be necessary to read this thread for the instructions.
Update, Thanks again !
Pottsy
01-12-2007, 07:55 AM
I tried to update it to 1.2.3 (upload all new files and import xml with "allow overwrite") and got:
Database error in vBulletin 3.6.4:
Invalid SQL:
ALTER TABLE edithistory CHANGE reason oldreason varchar(200);
MySQL Error : Unknown column 'reason' in 'edithistory'
Error Number : 1054
Date : Friday, January 12th 2007 @ 09:50:17 AM
Script : xxxxxxplugin.php?do=productimport
Referrer : xxxxxxx?do=productadd
IP Address : xx.xx.xx.xx
Username : xxxxx
Classname : vb_database
EDIT: Got it working by running query
ALTER TABLE edithistory CHANGE oldreason reason varchar(255);
and then doing the import again.
TrIn@dOr
01-12-2007, 10:21 AM
Very nice, perhaps u can add in the explanations that by default NO usergroup can view the historys!! :P
Surviver
01-12-2007, 11:18 AM
I tried to update it to 1.2.3 (upload all new files and import xml with "allow overwrite") and got:
Database error in vBulletin 3.6.4:
Invalid SQL:
ALTER TABLE edithistory CHANGE reason oldreason varchar(200);
MySQL Error : Unknown column 'reason' in 'edithistory'
Error Number : 1054
Date : Friday, January 12th 2007 @ 09:50:17 AM
Script : xxxxxxplugin.php?do=productimport
Referrer : xxxxxxx?do=productadd
IP Address : xx.xx.xx.xx
Username : xxxxx
Classname : vb_database
EDIT: Got it working by running query
ALTER TABLE edithistory CHANGE oldreason reason varchar(255);
and then doing the import again.
I'll look at this
//I can nnot repoduce the Problem.
It works fine for me ;)
* Altering Table post ...Done!
* Altering Table usergroup ...Done!
* Creating Table edithistory ... Done!
* Altering Table edithistory ...Done!
* Altering Table edithistory ...Done!
* Altering Table edithistory ...Done!
* Altering Table edithistory ...Done!
* Altering Table forum ...Done!
* Altering Table edithistory ...Done!
* Altering Table edithistory ...Done!
* Adding Index postid ...Done!
Very nice, perhaps u can add in the explanations that by default NO usergroup can view the historys!! :P
This is Default
Nathan2006
01-13-2007, 06:55 PM
Thanks Surviver,
Updated and working :)
ben_erhan
01-13-2007, 08:39 PM
I have made all the changes on 3.6.3 but it did not work.
I could not see the edit history link anywhere?
If I want this hack, is it necessary to upgrade the version of vb?
Surviver
01-14-2007, 06:11 AM
I have made all the changes on 3.6.3 but it did not work.
I could not see the edit history link anywhere?
If I want this hack, is it necessary to upgrade the version of vb?
you must use a 3.6.x Version of vB. Did you the Template-Edits and are you sure youzr members have the right rights ?
Greeetins Surviver
Duran26
01-14-2007, 01:39 PM
Hello,
Nice Script. Thank you.
But I canĀ“t find the link "Edit History" in my Forum.
What might be wrong ?
regards
Surviver
01-14-2007, 01:43 PM
Hello,
Nice Script. Thank you.
But I can?t find the link "Edit History" in my Forum.
What might be wrong ?
regards
1.) IT's not active in the specified Forum
2.) The User has not the rights
3.) You didn't the Template Edit
Greetings Surviver
Duran26
01-14-2007, 02:10 PM
1.) IT's not active in the specified Forum
2.) The User has not the rights
3.) You didn't the Template Edit
Greetings Surviver
1.) Where can i activate it ?
2.) The User is the Superadmin
3.) Done
Surviver
01-14-2007, 03:43 PM
1.) Where can i activate it ?
2.) The User is the Superadmin
3.) Done
1.) AdminCP -> Forum Manager -> Select Forum -> Edithistory Active ?
1.) That has nothing to say. AdminCP -> Usergroupmanager ->Select usergroups -> Post Edit History Permissions
Greetins Surviver
stwilson
01-14-2007, 05:46 PM
I have followed the setup instructions to the letter:
-uploaded files
-installed product
-modified templates
But I still do not see the option to enable this feature in the Forum Manager >Edit section. I cannot locate the Edithistory Active setting. What am I missing??? I'm looking forward to using this mod.
ST
Duran26
01-14-2007, 06:27 PM
1.) That has nothing to say. AdminCP -> Usergroupmanager ->Select usergroups -> Post Edit History Permissions
Hello Surviver,
Thank you very much!
It works now !!
The permissions in the Usergroupmanager was the problem.
have a nice day ! :)
Surviver
01-14-2007, 06:36 PM
Hello Surviver,
Thank you very much!
It works now !!
The permissions in the Usergroupmanager was the problem.
have a nice day ! :)
Thats good, thanks ;)
Greetins Surviver
Spinball
01-14-2007, 06:39 PM
The link to the video does not work.
stwilson
01-15-2007, 03:32 AM
I have followed the setup instructions to the letter:
-uploaded files
-installed product
-modified templates
But I still do not see the option to enable this feature in the Forum Manager >Edit section. I cannot locate the Edithistory Active setting. What am I missing??? I'm looking forward to using this mod.
ST
I uninstalled and reinstalled and got it to work. Nice MOD! Thank you.
ST
MThornback
01-16-2007, 12:20 PM
I use a customized postbit and I laid out the edit display differently than the coder's.....
<if condition="$post[editcount]==0">
<else />
<if condition="$show['edithistorylink'] AND $post[editcount] > '0'">
<td valign="top">
<fieldset class="fieldset">
<legend><b>Post Edit History</b>:</legend>
<a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase 1=$post[editcount]>$vbphrase[saved_edits]</phrase></a></td>
</if>
</if>
Its not much...but it saves room if there are no edits on that perticular post...all are free to use it if they wish :)
With the author's permission i'd like to release it as a template mod too :o
Surviver
01-16-2007, 02:37 PM
I use a customized postbit and I laid out the edit display differently than the coder's.....
<if condition="$post[editcount]==0">
<else />
<if condition="$show['edithistorylink'] AND $post[editcount] > '0'">
<td valign="top">
<fieldset class="fieldset">
<legend><b>Post Edit History</b>:</legend>
<a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase 1=$post[editcount]>$vbphrase[saved_edits]</phrase></a></td>
</if>
</if>
Its not much...but it saves room if there are no edits on that perticular post...all are free to use it if they wish :)
With the author's permission i'd like to release it as a template mod too :o
If you like .. Release id as a template mod :)
TheWhite
01-21-2007, 12:45 AM
If I have to update from a previous version what must i do?
Regards
Surviver
01-21-2007, 04:21 AM
If I have to update from a previous version what must i do?
Regards
Overite all Files an import the Product again, ALlow Override ;)
voteforbird
02-09-2007, 05:31 PM
Nevermind
madmaca
05-16-2007, 04:05 PM
This seems to have stopped working for 3.6.6 :(
Can anyone else confirm?
stwilson
05-17-2007, 04:13 AM
It is working fine for me in 3.6.7.
MThornback
05-17-2007, 06:19 AM
Works for me too....
You may have reverted your templates to accommodate the changes in the 3.6.6 release...you'd need to reapply them afterwards :)
ChopBam
05-18-2007, 04:55 PM
Just installed it. It works fine for me in 3.6.7.
Here's a change I made.
I edited the phrase to "Edit History" like you can see on the first page. However, I also made use of the $post[editcount] feature by not having the "Edit History" link even show up if there is no edit history. Just a small change, but real handy dandy.
<if condition="$show['edithistorylink'] && $post[editcount] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase>$vbphrase[saved_edits]</phrase><a></if>
Oh, and I suggest that you add to the readme the fact that you need to allow this for usergroups before it'll work. I was confused at first but started reading the thread and found out that way. Other people might not be so fortunate.
MThornback
05-18-2007, 05:55 PM
Just installed it. It works fine for me in 3.6.7.
Here's a change I made.
I edited the phrase to "Edit History" like you can see on the first page. However, I also made use of the $post[editcount] feature by not having the "Edit History" link even show up if there is no edit history. Just a small change, but real handy dandy.
<if condition="$show['edithistorylink'] && $post[editcount] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase>$vbphrase[saved_edits]</phrase><a></if>
Oh, and I suggest that you add to the readme the fact that you need to allow this for usergroups before it'll work. I was confused at first but started reading the thread and found out that way. Other people might not be so fortunate.
OR...you could use the template mod I released that uses some of the exact same code :)
https://vborg.vbsupport.ru/showthread.php?t=136683
ChopBam
05-18-2007, 05:58 PM
Wow, I didn't even see yours, and our code does exactly the same thing.
Great minds think alike I guess. :p
I haven't read through this thread, so I may have missed it because of that.
BadgerDog
05-20-2007, 04:29 PM
Installed on v3.6.7 PL1 then un-installed as it didn't work.
Edit function never appeared anywhere....
Ensured it was turned ON and all files were in correct places, but no go...
Regards,
Badger
Edit: Sorry meant MThornback 's version of template edits, as I would have preferred those had this worked.
ChopBam
05-25-2007, 06:24 PM
You did enable it for usergroups, yes?
BadgerDog
05-25-2007, 10:32 PM
You did enable it for usergroups, yes?
Yes, but that wasn't my problem...
I am using MThornback's optional version and I did the following...
To: MThornback in another thread....
I had to remove the hack from postbit and put it ONLY in postbit_legacy...
For whatever reason, that kick started it and it's now working. I like the elegance of the way you've approached it. No edit.. no show save history link... nice.. ;)
Thanks for your help...
Regards,
Badger
vengefuldeath87
06-12-2007, 08:25 PM
The default template didnt really work for me, so i made a button for it:
In postbit Find:
<img style="display: none" id="progress_$postid" src="$stylevar[imgdir_misc]/progress.gif" alt="$vbphrase[loading_editor_please_wait]" />
Add under:
<if condition="$show['edithistorylink']"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]" rel="nofollow"><phrase 1=$post[editcount]><img src="$stylevar[imgdir_button]/postedits.gif" alt="$vbphrase[saved_edits]" border="0" /></phrase><a></if>
Pop the attached image in your images/buttons dir, and you should be good to go.
you should be able to do similer with the legacy template, but i didnt bother on my board.
Surviver
06-13-2007, 03:28 AM
The default template didnt really work for me, so i made a button for it:
In postbit Find:
<img style="display: none" id="progress_$postid" src="$stylevar[imgdir_misc]/progress.gif" alt="$vbphrase[loading_editor_please_wait]" />
Add under:
<if condition="$show['edithistorylink']"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]" rel="nofollow"><phrase 1=$post[editcount]><img src="$stylevar[imgdir_button]/postedits.gif" alt="$vbphrase[saved_edits]" border="0" /></phrase><a></if>
Pop the attached image in your images/buttons dir, and you should be good to go.
you should be able to do similer with the legacy template, but i didnt bother on my board.
Wow very nice, Thank you!
Can you translate this to german? If so, i will integrate these Buttons in the Hack as default ;)
The Germany Text: Editierungs-Verlauf
Thanks in advance!
Greetings Surviver
vengefuldeath87
06-13-2007, 10:49 AM
ok, give these a try
Surviver
06-13-2007, 06:00 PM
Thanks :)
I'll release a new version in a few weeks (after holidays :P)
Greetings Surviver
Surviver
06-13-2007, 07:08 PM
I'm importing the product but it takes ages...still loading after 5 min??
Yes this is right because it alteres the post-tabel - if its very big this can take much time ;)
aj8690
06-13-2007, 07:12 PM
This is awesome!!! Thank you so much.
[nominated for motm]
dutchbb
06-13-2007, 07:21 PM
Yes this is right because it alteres the post-tabel - if its very big this can take much time ;)
Ok thanks.
It's done now but it's not working, i edited a post and no history link is showed, I did the template changes for postbit legacy.
David Lama
06-14-2007, 03:24 AM
is there a version of this for 3.5 and up? :) sounds awesome
Surviver
06-14-2007, 11:41 AM
Ok thanks.
It's done now but it's not working, i edited a post and no history link is showed, I did the template changes for postbit legacy.
You have to activate this Hack global per Forum and per Usergroup ;)
is there a version of this for 3.5 and up? :) sounds awesome
No, this Version is only for 3.6 (never tested with 3.5)
dutchbb
06-14-2007, 11:54 AM
You have to activate this Hack global per Forum and per Usergroup ;)
Oh ,ok thanks. Great hack, vbulletin should seriously consider this for the next release!
Trigr
06-14-2007, 02:11 PM
uhm no .xml file in the attachment? did i miss it?
[e] why yes i did .............
my bad. installed and appreciate the work.
id like a 3.6.7 aswell, if you plan on updating, thanks
vengefuldeath87
06-16-2007, 08:05 AM
Ive installed it on 3.6.7 with no issues, should be fully compatable.
David Lama
06-16-2007, 11:52 PM
it works?? hmmm
wrestlepower
06-17-2007, 11:14 AM
ok, i've installed it as per instructions, set up the forum and usergrioup permissions and attempted to test it. If i edit a post, it will show in the postbit (legacy) that there has been an edit but when i click on it to see the previous version, it says that the post ahs never been edited.
Any ideas?
Surviver
06-17-2007, 12:14 PM
Does the edithistory table exist?
saidsrc
06-23-2007, 10:50 AM
there is a bug,
when i want to change user group permissions,
ist going to database error,
and this ++++ing hack :@
i reseted my forum :@
Hi
This keeps timing out in the install script. We have a very large post table (approx 7million posts) and I guess its timing out attempting to change that.
Could you please give me the raw SQL for the post table change and I'll give it a go that way?
Cheers
Simon
Right.
THis is urgent.
I now have a problem, as this install script didn't fully run, and I now can't make changes to my usergroups as it throws up a db error :
MySQL Error : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054
whenever I try to update the usergroup.
Please help asap - first of all to remove this problem.
cheat-master30
06-29-2007, 08:41 AM
Right.
THis is urgent.
I now have a problem, as this install script didn't fully run, and I now can't make changes to my usergroups as it throws up a db error :
MySQL Error : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054whenever I try to update the usergroup.
Please help asap - first of all to remove this problem.
Same, even though I uninstalled the product and no plugins for it actually exist. I think the uninstall process is screwed.
Dioxin
07-05-2007, 09:34 AM
if the title of a saved post contains a quote character and i restore this post the quote character in the restored post will get messed up.
some sort of conversion error.
could you please fix this bug :)
could this fix solve the problem:
$postdm->setr('title', unhtmlspecialchars($edit['oldtitle']));
Is there any reason why no support is being offered?
ragtek
07-05-2007, 08:09 PM
surviver is on holiday ;)
thats the reason
Surviver
07-07-2007, 12:53 PM
Right.
THis is urgent.
I now have a problem, as this install script didn't fully run, and I now can't make changes to my usergroups as it throws up a db error :
MySQL Error : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054
whenever I try to update the usergroup.
Please help asap - first of all to remove this problem.
Re,ove the file bitfield_edithistory.xmlfrom the dir includes/xml - this will fix the problem.
Or better add the column to the uisergrouzptable.
Same, even though I uninstalled the product and no plugins for it actually exist. I think the uninstall process is screwed.
if the title of a saved post contains a quote character and i restore this post the quote character in the restored post will get messed up.
some sort of conversion error.
could you please fix this bug :)
could this fix solve the problem:
$postdm->setr('title', unhtmlspecialchars($edit['oldtitle']));
I'll fix this in thenext release ;)
Is there any reason why no support is being offered?
surviver is on holiday ;)
thats the reason
Thanks ragtek
magnus
07-07-2007, 10:41 PM
How many posts back does this modification save? Does it save only the most recent edit, or every edit since creation?
Surviver
07-10-2007, 01:52 PM
How many posts back does this modification save? Does it save only the most recent edit, or every edit since creation?
It saves every edit since creation ;)
mfyvie
07-13-2007, 01:42 PM
You can activate/deactivate ist per Usergroup and Forum ;)
Hi Survivor - nice hack. I just have one suggestion. Could you include that instruction into the instructions in the .zip file? I dutifully followed all instructions and was wondering why it didn't work. Then I discovered in post #22 that I needed to manually activate this on a usergroup basis. It might also be an idea to default the settings to on for the admin and super mod usergroups. This might save some people a lot of confusion (either that, or make sure it is written in the instructions).
I've also made a small change to the template edit as follows:
<if condition="$show['edithistorylink']"><if condition="$post['editcount'] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase 1=$post[editcount]>$vbphrase[saved_edits]</phrase><a></if></if>This has the advantage of only displaying the edits link if there are actually edits. I don't think it makes sense to display an edits link when the number of edits is 0.
Thanks again for a great mod.
ragtek
07-13-2007, 01:48 PM
Hi Survivor - nice hack. I just have one suggestion. Could you include that instruction into the instructions in the .zip file? I dutifully followed all instructions and was wondering why it didn't work. Then I discovered in post #22 that I needed to manually activate this on a usergroup basis. It might also be an idea to default the settings to on for the admin and super mod usergroups. This might save some people a lot of confusion (either that, or make sure it is written in the instructions).
I've also made a small change to the template edit as follows:
<if condition="$show['edithistorylink']"><if condition="$post['editcount'] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase 1=$post[editcount]>$vbphrase[saved_edits]</phrase><a></if></if>This has the advantage of only displaying the edits link if there are actually edits. I don't think it makes sense to display an edits link when the number of edits is 0.
Thanks again for a great mod.
good idee
Surviver
07-14-2007, 03:09 PM
Hi Survivor - nice hack. I just have one suggestion. Could you include that instruction into the instructions in the .zip file? I dutifully followed all instructions and was wondering why it didn't work. Then I discovered in post #22 that I needed to manually activate this on a usergroup basis. It might also be an idea to default the settings to on for the admin and super mod usergroups. This might save some people a lot of confusion (either that, or make sure it is written in the instructions).
I've also made a small change to the template edit as follows:
<if condition="$show['edithistorylink']"><if condition="$post['editcount'] > 0"><a href="edithistory.php?do=viewedithistory&postid=$post[postid]"><phrase 1=$post[editcount]>$vbphrase[saved_edits]</phrase><a></if></if>This has the advantage of only displaying the edits link if there are actually edits. I don't think it makes sense to display an edits link when the number of edits is 0.
Thanks again for a great mod.
Thanks for your suggestion - the next update is coming and i will consider your suggestion ;)
Surviver
07-14-2007, 04:24 PM
*** Update ***
--> Changes see first post
TrIn@dOr
07-18-2007, 07:17 PM
Nice
richTV
07-19-2007, 11:03 PM
Hello, tnx for sharing this.
glad to read also that members have installed it fine under 3.6.7 as this is what i have too.
my question:
in the .zip file, do i only need what is in the folder:
Post Edit History\edithistory_1-2-5
i ask because u also have stuff in the folder:
Post Edit History
such as an Upload folder, and .txt files and 1 .xml file
did u do intentionally do this for a German version and an English version?
TIA
richTV
07-19-2007, 11:21 PM
also, to not show a link in which an edit does NOT exist, do i need to install the template written by MThornback [Post Edit History (PEH) Alternate Postbit Layout] or is this already included in the update u recently made?
i ask because u said:
1.2.5
=====
- Bugfix: Fixed a problem with entities
- New Feature: Now you can compare saved edits via ajax
- Change: Optimized some code
- Change: Cronjob phrased
- Change: Optimized Installcode
- Change: Link will only show up if post was edited
so i just wanted to know whether or not the update is already built in or we need to add his template too.
TIA
Surviver
07-20-2007, 02:22 PM
Hello, tnx for sharing this.
glad to read also that members have installed it fine under 3.6.7 as this is what i have too.
my question:
in the .zip file, do i only need what is in the folder:
Post Edit History\edithistory_1-2-5
i ask because u also have stuff in the folder:
Post Edit History
such as an Upload folder, and .txt files and 1 .xml file
did u do intentionally do this for a German version and an English version?
TIA
I don't understand your problem. Just read readme.txt ;)
also, to not show a link in which an edit does NOT exist, do i need to install the template written by MThornback [Post Edit History (PEH) Alternate Postbit Layout] or is this already included in the update u recently made?
i ask because u said:
1.2.5
=====
- Bugfix: Fixed a problem with entities
- New Feature: Now you can compare saved edits via ajax
- Change: Optimized some code
- Change: Cronjob phrased
- Change: Optimized Installcode
- Change: Link will only show up if post was edited
so i just wanted to know whether or not the update is already built in or we need to add his template too.
TIA
Yes, the update contains this change ;)
Nathan2006
07-24-2007, 10:06 PM
This is a lot better
Thank you for the update :)
nnjj.net
08-08-2007, 07:59 AM
is it working on 3.6.8? and after install where I can see the effect?
Surviver
08-12-2007, 07:00 AM
is it working on 3.6.8? and after install where I can see the effect?
Yes, ist works with 3.6.8
If the System is enabled and you have the permissions to view and the templateedits are done - in postbit/_legacy
nnjj.net
08-12-2007, 07:20 AM
thanks a lot, I have installed it
can you provide a screenshop plz?
I still can't see the effect :S
aslan
08-12-2007, 02:42 PM
I've installed that hack and I can see on the vb options. But I can't see anything on the board. I've opened the hack from the options still nothing is showing on edited post.
no history no image nothing, it's all like old time.
I'm using 3.6.7 PL1 and I've installed all the files inc. templates as written on the text file.
Can you help me about that please?
ragtek
08-12-2007, 02:43 PM
just edit an post, than you will see it
aslan
08-12-2007, 02:51 PM
I did this. Even I login with normal user name and edited but still nothing....
Nathan2006
08-12-2007, 04:39 PM
I've installed that hack and I can see on the vb options. But I can't see anything on the board. I've opened the hack from the options still nothing is showing on edited post.
no history no image nothing, it's all like old time.
I'm using 3.6.7 PL1 and I've installed all the files inc. templates as written on the text file.
Can you help me about that please?
Have you change the user settings in Usergroups?
COBRAws
08-12-2007, 05:05 PM
Is there a way to import Post History from Post Edit History Viewer (https://vborg.vbsupport.ru/showthread.php?t=105989).
THanks
aslan
08-12-2007, 11:14 PM
Have you change the user settings in Usergroups?
Thanks a lot Nathan. :)
Everything seems fine now.
Nathan2006
08-12-2007, 11:56 PM
Thanks a lot Nathan. :)
Everything seems fine now.
np glad you got it working :)
Gray Matter
08-13-2007, 10:14 PM
This is a great hack, but the templates that go along with it have some slight design issues inside them and (in my opinion) are not visually appealing at all.
I have a few questions:
Why does the username of the thread starter appear two times in the edit_history_view template? This is redundant. The second username should be the username of the post creator.
What is the variable #$i? I cannot figure out what this is, as it is just displaying a useless number...
What conditions must be met in order to show the compare link? I can't find any way to configure it.
Why are there colspan="2" attributes on everything in the editbit template? These aren't necessary as there are only three columns in the table, and there are three columns in every row...
What is the purpose of the CSS in the edit_history_view template?
and a few suggestions:
Add a conditional so that if there is no post title, the "" won't display in the phrase "Edithistory of post "X" in thread "Y." This makes the text ridiculous by showing an unfilled set of quotation marks.
When there is no title for the post, the "Post" row will just show a link that says "(Post)." This looks a little redundant, having "Post: (Post)." You should use a conditional to remove the parentheses when there is no post title, and also, I think, change the phrase text to "Show Post."
The title row should not show when there are no titles to display. ;)
The reason row should not show when there are no reasons to display.
The edit time of the post should have a <span class="time"> on it, to keep with vB standards and also to set apart the time itself.
Remove the closing </span> tag within the compare conditional. There is no opening tag for this so it shouldn't be there.
Why is the phrase "cancle_compare" spelled "cancle?" The proper spelling is "cancel," unless there's some foreign version that I'm unaware of.
The "message" text TD should have a valign="top" on it, since it looks a little out of place in the middle of a large post.
The last two rows of the editbit table look really unorganized. You should try to configure them differently for a better-looking effect.
Sometimes you write "Edit History," and other times as "Edithistory." Why the two versions? You should choose one (may I suggest "Edit History"). :p
You have an ampersand that's not encoded in the link of the "Delete All Edits of This Post" link. ;)
Thanks for listening to me rant. Just some constructive criticism. :p
For anyone who's interested in applying the changes I suggested and removing the unnecessary stuff, I've attached my two templates and two screenshots (one for a post with a title and reason, and one for a post without them) as well. Feel free to use them (They are XHTML 1.0 valid, by the way). Keep in mind that if you use them, you must add two phrases: edithistory_of_post_in_thread_x (Text: Edit History of post in thread "{1}") and show_post (Text: Show Post). Enjoy. :)
BobbyBig
08-17-2007, 09:50 PM
Thank you, installed this for our community Forum.
Please get the User Mass Restore Option implemented, it is required badly :)
Gute Arbeit.
regards
Pottsy
08-21-2007, 12:33 PM
Help!! :)
I have uninstalled this product, but in my usergroup options there is a table left behind. No title, 7 blank Yes/No options, no description.
If I try to change any usergroup options, I get an error (below).
How can I remove PEH from my forum? I have tried installing again, then removing, but still the same. Pleeeeeease help!
Error:
Database error in vBulletin 3.6.8:
Invalid SQL:
UPDATE usergroup SET
### UPDATE QUERY GENERATED BY fetch_query_sql() ###
`title` = 'Dealers',
`description` = '',
`usertitle` = 'Commercial user',
`opentag` = '',
`closetag` = '',
`passwordexpires` = '0',
`passwordhistory` = '0',
`ispublicgroup` = '0',
`canoverride` = '0',
`mgccustomusergroupperms` = '0',
`nbmsgshowchatbox` = '10',
`allowhtmlpermissions` = '0',
`edithistorypermissions` = '0',
`vbwikiroles` = '',
`vbwikipermissions` = '63',
`forumpermissions` = '782591',
`genericpermissions` = '505943751',
`attachlimit` = '0',
`pmquota` = '750',
`pmpermissions` = '3',
`pmsendmax` = '5',
`calendarpermissions` = '63',
`wolpermissions` = '1',
`adminpermissions` = '0',
`genericoptions` = '62',
`profilepicmaxwidth` = '100',
`profilepicmaxheight` = '100',
`profilepicmaxsize` = '65535',
`avatarmaxwidth` = '90',
`avatarmaxheight` = '90',
`avatarmaxsize` = '20000',
`signaturepermissions` = '136703',
`sigpicmaxwidth` = '1',
`sigpicmaxheight` = '1',
`sigpicmaxsize` = '1',
`sigmaxrawchars` = '1000',
`sigmaxchars` = '500',
`sigmaxlines` = '5',
`sigmaxsizebbcode` = '4',
`sigmaximages` = '0'
WHERE usergroupid=10;
MySQL Error : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054
Date : Tuesday, August 21st 2007 @ 02:28:04 PM
Script : http://www.mydomain.com/forum/admincp/usergroup.php?do=update
Referrer : http://www.mydomain.com/forum/admincp/usergroup.php?do=edit&usergroupid=10
IP Address : x.x.x.x
Username : Pottsy
Classname : vb_database
Pottsy
08-21-2007, 01:04 PM
OK, panic over - I read this (https://vborg.vbsupport.ru/showpost.php?p=1285160&postcount=109).
Surviver
08-25-2007, 06:01 AM
This is a great hack, but the templates that go along with it have some slight design issues inside them and (in my opinion) are not visually appealing at all.
I have a few questions:
Why does the username of the thread starter appear two times in the edit_history_view template? This is redundant. The second username should be the username of the post creator.
What is the variable #$i? I cannot figure out what this is, as it is just displaying a useless number...
What conditions must be met in order to show the compare link? I can't find any way to configure it.
Why are there colspan="2" attributes on everything in the editbit template? These aren't necessary as there are only three columns in the table, and there are three columns in every row...
What is the purpose of the CSS in the edit_history_view template?
and a few suggestions:
Add a conditional so that if there is no post title, the "" won't display in the phrase "Edithistory of post "X" in thread "Y." This makes the text ridiculous by showing an unfilled set of quotation marks.
When there is no title for the post, the "Post" row will just show a link that says "(Post)." This looks a little redundant, having "Post: (Post)." You should use a conditional to remove the parentheses when there is no post title, and also, I think, change the phrase text to "Show Post."
The title row should not show when there are no titles to display. ;)
The reason row should not show when there are no reasons to display.
The edit time of the post should have a <span class="time"> on it, to keep with vB standards and also to set apart the time itself.
Remove the closing </span> tag within the compare conditional. There is no opening tag for this so it shouldn't be there.
Why is the phrase "cancle_compare" spelled "cancle?" The proper spelling is "cancel," unless there's some foreign version that I'm unaware of.
The "message" text TD should have a valign="top" on it, since it looks a little out of place in the middle of a large post.
The last two rows of the editbit table look really unorganized. You should try to configure them differently for a better-looking effect.
Sometimes you write "Edit History," and other times as "Edithistory." Why the two versions? You should choose one (may I suggest "Edit History"). :p
You have an ampersand that's not encoded in the link of the "Delete All Edits of This Post" link. ;)
Thanks for listening to me rant. Just some constructive criticism. :p
For anyone who's interested in applying the changes I suggested and removing the unnecessary stuff, I've attached my two templates and two screenshots (one for a post with a title and reason, and one for a post without them) as well. Feel free to use them (They are XHTML 1.0 valid, by the way). Keep in mind that if you use them, you must add two phrases: edithistory_of_post_in_thread_x (Text: Edit History of post in thread "{1}") and show_post (Text: Show Post). Enjoy. :)
At first thank you for your post!
1.)That seems to be the bug - once it should be the threadstarter and the other should be the postauthor!
2.)Where did you finde it?
3.)You have to set the usergroup permissions. If this does not work, check if the templates are ok.
4.)You're right
5.)This is the CSS for comparing the edits
1.)Noticed for future Versions
2.)Noticed for future Versions
3.)Noticed for future Versions
4.)Noticed for future Versions
5.)Noticed for future Versions
6.)Noticed for future Versions
7.)This happens if i write very fast :D Maybe i will change this ;)
8.)Noticed for future Versions
9.)The Problem is i'm not a designer :D I will try to find a better solution :)
10.)hehe, ok i will use "Edut History" in future :)
11.)Noticed for future Versions
Thank you for your particural suggestions!
That's nice feedback :)
Greetings Surviver
edgecutioner
10-16-2007, 12:25 PM
Right.
THis is urgent.
I now have a problem, as this install script didn't fully run, and I now can't make changes to my usergroups as it throws up a db error :
MySQL Error : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054whenever I try to update the usergroup.
Please help asap - first of all to remove this problem.
Yes, ist works with 3.6.8
If the System is enabled and you have the permissions to view and the templateedits are done - in postbit/_legacy
It has bugs when you uninstall it namely the quote posted post above
Help!! :)
I have uninstalled this product, but in my usergroup options there is a table left behind. No title, 7 blank Yes/No options, no description.
If I try to change any usergroup options, I get an error (below).
How can I remove PEH from my forum? I have tried installing again, then removing, but still the same. Pleeeeeease help!
Error:
Database error in vBulletin 3.6.8:
Invalid SQL:
UPDATE usergroup SET
### UPDATE QUERY GENERATED BY fetch_query_sql() ###
`title` = 'Dealers',
`description` = '',
`usertitle` = 'Commercial user',
`opentag` = '',
`closetag` = '',
`passwordexpires` = '0',
`passwordhistory` = '0',
`ispublicgroup` = '0',
`canoverride` = '0',
`mgccustomusergroupperms` = '0',
`nbmsgshowchatbox` = '10',
`allowhtmlpermissions` = '0',
`edithistorypermissions` = '0',
`vbwikiroles` = '',
`vbwikipermissions` = '63',
`forumpermissions` = '782591',
`genericpermissions` = '505943751',
`attachlimit` = '0',
`pmquota` = '750',
`pmpermissions` = '3',
`pmsendmax` = '5',
`calendarpermissions` = '63',
`wolpermissions` = '1',
`adminpermissions` = '0',
`genericoptions` = '62',
`profilepicmaxwidth` = '100',
`profilepicmaxheight` = '100',
`profilepicmaxsize` = '65535',
`avatarmaxwidth` = '90',
`avatarmaxheight` = '90',
`avatarmaxsize` = '20000',
`signaturepermissions` = '136703',
`sigpicmaxwidth` = '1',
`sigpicmaxheight` = '1',
`sigpicmaxsize` = '1',
`sigmaxrawchars` = '1000',
`sigmaxchars` = '500',
`sigmaxlines` = '5',
`sigmaxsizebbcode` = '4',
`sigmaximages` = '0'
WHERE usergroupid=10;
MySQL Error : Unknown column 'edithistorypermissions' in 'field list'
Error Number : 1054
Date : Tuesday, August 21st 2007 @ 02:28:04 PM
Script : http://www.mydomain.com/forum/admincp/usergroup.php?do=update
Referrer : http://www.mydomain.com/forum/admincp/usergroup.php?do=edit&usergroupid=10
IP Address : x.x.x.x
Username : Pottsy
Classname : vb_database
I get the same DB error. any suggestions?
Surviver
10-17-2007, 07:04 PM
I get the same DB error. any suggestions?
Just reaf the thread - but will be fixed in the next realease (will be released in the next days ;))
https://vborg.vbsupport.ru/showpost.php?p=1285160&postcount=109
CDarklock
10-17-2007, 07:56 PM
I installed this mod, made the template changes, edited a post... and, um, nothing. I can't seem to find any difference. There's no link to a change history. Is this mod working as expected with 3.6.8?
I also have some suggestions for enhancements, when time is available for such things... I'd like the history extended to deleted posts, so when you can see a deleted post slug you can click a link to see what was deleted and still have access to the full history, and also the ability to revert a deleted post to any selected historical copy of that post without damaging the history.
FleXy
10-17-2007, 11:28 PM
thanks for this mod
1) can i administrate mass all history... purge all history from administrator panel?
2) will it drop all tables if i need uninstall?
thanks.
Surviver
10-21-2007, 07:11 PM
*** Update ***
|Jordan|
10-21-2007, 07:32 PM
Is B for beta? If it is, Surviver should check the beta box in thread settings
Surviver
10-21-2007, 07:33 PM
Is B for beta? If it is, Surviver should check the beta box in thread settings
Oooh, you're right.
Sorry, B means Beta and I forgot to check the box ;)
COBRAws
10-21-2007, 07:39 PM
*** Update ***
Any indications on how should we update? Any files to be deleted from the server?
Thanks for the update :)
aquariumpros
10-21-2007, 08:41 PM
Great Hack!!
Had previous version running - (working other then the compare) ---
Just updated to this version; and shows a completely black page when trying to view the edit history.
Any advice?
TIA,
COBRAws
10-21-2007, 09:03 PM
So far new version works great. No bugs found.
aquariumpros
10-21-2007, 09:24 PM
Great Hack!!
Had previous version running - (working other then the compare) ---
Just updated to this version; and shows a completely black page when trying to view the edit history.
Any advice?
TIA,
After a complete removal of previous version, and reinstallation of the new version = 100% working!
Many thanks for this!!
pollon
10-21-2007, 10:35 PM
When I try to edit a post (full editor) I get this at the top of the page:
Parse error: syntax error, unexpected T_ELSE in ......../public_html/forums/editpost.php(305) : eval()'d code on line 39
I don't see any "edit history" link on postbit. :( I'm on3.6.8 Patch Level 1.
Can you please help me??
Nathan2006
10-22-2007, 03:22 AM
Hi,
I have updated and after deleting all the files from the server and uninstalling this hack
completely All I get is a blank white page.
I have also tried on IE & FireFox too and all I get is the white page.
I've also checked all the settings and everything else in user-groups :(
Thank you for any help :)
Surviver
10-22-2007, 11:37 AM
When I try to edit a post (full editor) I get this at the top of the page:
Parse error: syntax error, unexpected T_ELSE in ......../public_html/forums/editpost.php(305) : eval()'d code on line 39
I don't see any "edit history" link on postbit. :( I'm on3.6.8 Patch Level 1.
Can you please help me??
I cannot confirm this. Try to disable all other addons, and check again.
Hi,
I have updated and after deleting all the files from the server and uninstalling this hack
completely All I get is a blank white page.
I have also tried on IE & FireFox too and all I get is the white page.
I've also checked all the settings and everything else in user-groups :(
Thank you for any help :)
? If you uninstalled the hack, weher ist the problem?
FleXy
10-22-2007, 01:17 PM
old version work well
with new i got BLANK page when i try to view old post history
FleXy
10-22-2007, 01:20 PM
i mean i reinstall plugin also at 3.6.8 VB with Path Level 1. I see links to view old post, but thay give me blank page.
Nathan2006
10-22-2007, 06:42 PM
? If you uninstalled the hack, weher ist the problem?
Sorry I was very tired today and missed out that I had reinstalled it again :)
But still a blank page :(
old version work well
with new i got BLANK page when i try to view old post history
I'm glad someone else is having the same problem too :)
Surviver
10-23-2007, 03:52 AM
Maybe your Templates / Templateedits are not up to date, the url has changed in the new version.
BadgerDog
10-23-2007, 12:52 PM
old version work well
with new i got BLANK page when i try to view old post history
Same problem... :(
I have updated from v1.2.5 to this new 1.5.0b2 and now all I get is a blank page when I try to look at the edit history of posts that have edits. :confused:
Now what should I do?
I probably should have left the old version running as it was working fine, but I didn't realize that this new version was a beta test.
Thanks for any help...
Regards,
Badger
BadgerDog
10-23-2007, 12:59 PM
A different question....
If I want to un-install this mod, I see how to clean out all of the actual code modules and files, but how do I get rid of all of the old stored (in the database?) older versions of "saved" posts?
Thanks
Regards,
Badger
Surviver
10-23-2007, 01:28 PM
Same problem... :(
I have updated from v1.2.5 to this new 1.5.0b2 and now all I get is a blank page when I try to look at the edit history of posts that have edits. :confused:
Now what should I do?
I probably should have left the old version running as it was working fine, but I didn't realize that this new version was a beta test.
Thanks for any help...
Regards,
Badger
Please read the post above.
BadgerDog
10-23-2007, 01:34 PM
Please read the post above.
I don't understand what you mean?
Are you referring to this post?
Maybe your Templates / Templateedits are not up to date, the url has changed in the new version.
The templates are current (v3.6.7pl1) and the postbit edits were made as per your instructions? What URL are you referring to that's changed?
Thanks
Regards,
Badger
FleXy
10-23-2007, 04:49 PM
Maybe your Templates / Templateedits are not up to date, the url has changed in the new version.
it's help me
thanks :-)
does not know that need to change templates one time more.
FleXy
10-23-2007, 04:50 PM
If I want to un-install this mod, I see how to clean out all of the actual code modules and files, but how do I get rid of all of the old stored (in the database?) older versions of "saved" posts?
I think it will be cleaned when you uninstall plugin (drop all tables)
Surviver View Post, I am right?
Paul M
10-23-2007, 08:57 PM
I've been using this a while so decided to update my test forum to the new beta.
First of all I got the blank page problem - this is due to the url to view the edit history being completely different, I had to remove the old postbit edit and re-apply the new one.
I also had to edit a few phrases -quite a few of them appear to be in German.
I also found the text size in the comparisons to be very small (almost unreadable) so I added a font-size: 12px; to all the CSS diff_xxx classes - this also highlighted that the .diff-unchanged class is completely missing from the peh_view template.
I also think the text comparisons are backwards - it seems that text added to a new post is being highlighted as red (deleted) while text removed from the old post is showing as green (added).
I'm also curious why you have this marked as unsupported when you clearly appear to be supporting it ?
rolfw1
10-23-2007, 10:51 PM
Well done, nice mod. Clicked Installed. :)
Surviver
10-24-2007, 03:49 AM
I think it will be cleaned when you uninstall plugin (drop all tables)
Surviver View Post, I am right?
Yes you're right ;)
Surviver
10-24-2007, 04:02 AM
I also had to edit a few phrases -quite a few of them appear to be in German.
Okay, I will kool at this and translate them.
I also found the text size in the comparisons to be very small (almost unreadable) so I added a font-size: 12px; to all the CSS diff_xxx classes - this also highlighted that the .diff-unchanged class is completely missing from the peh_view template.
Will be changed in the next release ;)
Regars Surviver
BadgerDog
10-24-2007, 09:41 AM
I think it will be cleaned when you uninstall plugin (drop all tables)
Surviver View Post, I am right?
Thank you .... :up:
Uninstalled.....
Regards,
Badger
yoyoyoyo
10-24-2007, 10:40 AM
Will be changed in the next release ;)Thanks - any timeline or idea when that might happen? :)
Surviver
10-24-2007, 06:08 PM
Thanks - any timeline or idea when that might happen? :)
No, but i want to wait so time in order to fix bugs if there are ;)
Illustrious
10-25-2007, 03:55 AM
Why are there two things (product file/upload folders) in the zip?
Illustrious
10-25-2007, 04:17 AM
And outside of the fact that most of the new stuff is in German, it looks pretty solid. I sure hope you fix that quickly though.
Paul M
10-28-2007, 07:53 PM
In the edit history, when you click on the delete option it pops up a message asking you if you are sure, however, when you click on restore, it just goes ahead and restores the post - it would be better if this option was consistant with the delete option (i.e. pops up an "are you sure" confirmation).
Jackal von ?RF
10-29-2007, 09:50 AM
In the edit history, when you click on the delete option it pops up a message asking you if you are sure, however, when you click on restore, it just goes ahead and restores the post - it would be better if this option was consistant with the delete option (i.e. pops up an "are you sure" confirmation).
Restoring creates a new entry to the edit history (if I remember right) so it's always possible to undo a restore operation. That's why there should be no confirmation dialog, because it would only decrease the usability/effectiveness.
And in any case, the benefit of all confirmation dialogs is questionable, because the users will quickly learn to click the confirmation dialog as a reflex, without thinking about it, which means that the confirmation dialog adds one more unnecessary button press but does not prevent the users from accidentally deleting stuff (for example on Windows, deleting a file is a key combination "Shift+Delete, Enter" and the confirmatin dialog is pointless because the user instinctively always presses Enter before stopping to think about the dialog). It's always better to allow some way to undo the action in the rare case of an accidental button press.
TrIn@dOr
10-29-2007, 10:51 AM
updated, all good so far.
Darat
11-06-2007, 07:29 PM
We're testing this at the moment on our forum (forums.randi.org. Our Members can only edit their posts for up to 120 minutes but with this installed they can restore a post after this period - is it possible for the "restore" feature to respect the editing time limit on posts?
Surviver
11-08-2007, 03:59 AM
We're testing this at the moment on our forum (forums.randi.org. Our Members can only edit their posts for up to 120 minutes but with this installed they can restore a post after this period - is it possible for the "restore" feature to respect the editing time limit on posts?
Good Idea, i think i will implnt a setting fpr this (own limit, becaus restore ist not the sam es edit ;))
Regards Surviver
BobbyBig
11-27-2007, 02:30 PM
solved, please delete
stwilson
12-03-2007, 06:07 PM
I have a situation where I needed to uninstall this MOD. The uninstall works great but there is some leftover stuff that I cannot get rid of. See attached. After the install there are still the options that show up in the Usergroups area for the different user groups. The options have lost all their text but the shell is still there. How do I get rid of this?
Surviver
12-06-2007, 05:43 PM
I have a situation where I needed to uninstall this MOD. The uninstall works great but there is some leftover stuff that I cannot get rid of. See attached. After the install there are still the options that show up in the Usergroups area for the different user groups. The options have lost all their text but the shell is still there. How do I get rid of this?
Remove the File bitfield_peh.xml (dir includes/xml)
Gray Matter
12-24-2007, 09:10 AM
For anyone interested in importing their histories from this wonderful hack into 3.7's new default system:
https://vborg.vbsupport.ru/showthread.php?t=166038
Hornstar
12-24-2007, 10:48 AM
I actually wish that vbulletins was more improved like this one
Doctor Dan
02-27-2008, 02:54 AM
I have this mod up and running on a small testforum, but I was wondering what other people's experiences are using this mod in a "production environment," i.e. a live forum with thousands of posts being edited.
One minor comment: having three different files with the same name "edithistory.php" which need to be installed in three different vB subdirectories isn't such a good idea. Each file name should be unique, so that if the wrong file is accidentally installed in the wrong subdirectory, it is obvious simply by looking at the directory's contents what the problem is.
- Dan
Elenna
02-27-2008, 04:18 PM
Great add-on, thanks so much!
Just out of curiosity, is there a way (via admin interface or otherwise) to see which posts were edited during a certain time frame?
Zero2Cool
03-02-2008, 07:54 AM
By clicking in der user acp on "restore posts of this user" i get the message that i have the no rights.
It's possible that all admins can use this option?
msvi007
03-09-2008, 04:08 PM
By clicking in der user acp on "restore posts of this user" i get the message that i have the no rights.
It's possible that all admins can use this option?
Change it in the usergroup permissions for the admin user group to yes
droid101
03-18-2008, 03:19 AM
So... what are the template edits in English? :)
scan-pa
03-18-2008, 11:53 PM
I used a free German to English translation website and did each phrase one by one and swapped them in the phrase section.
jawatkin
04-03-2008, 03:07 AM
Strangest thing.. Installed and see the options in User menu and Forum menu, but the Usergroup permissions "box" isn't there. Anyone have any idea? So odd. (3.6.8)
Skyrider
04-05-2008, 10:48 AM
How do I see see history button? This seems to work through the adminCP, but I can't see any "see history" button in any posts.. Any help?
how I can burn all edit history
Viper007Bond
05-07-2008, 07:55 AM
How do I see see history button? This seems to work through the adminCP, but I can't see any "see history" button in any posts.. Any help?
Read "templateedits-edithistory.txt".
Gray Matter
05-09-2008, 12:06 AM
how I can burn all edit history
What do you mean by "burn" the history? If you want to erase it, simply uninstall the product. If you are upgrading to 3.7 and you want to convert the hack's edit histories into the 3.7 edit history system, check out my importer (https://vborg.vbsupport.ru/showthread.php?t=166038) which will do this seamlessly for you and very quickly. :)
vithorius
07-01-2008, 05:28 PM
This is one of the BEST Mods ever for vB 3.6.x!!!! :up: :up:
Thank you so very much!!!
fatal1980
10-04-2008, 04:14 PM
Does this mod still work for 3.7?
Paul M
10-04-2008, 04:34 PM
Yes.
ragtek
10-05-2008, 08:51 AM
But you should also know that this feature is included in 3.7;)
Paul M
10-06-2008, 10:53 PM
It is, but i prefer this version and dont use the built in 3.7 feature. :)
fatal1980
10-09-2008, 01:59 AM
Never knew that. Thanks.
vithorius
10-16-2008, 09:11 AM
It is, but i prefer this version and dont use the built in 3.7 feature. :)
Hummm... Interesting... What is the main reason why you do it? :confused:
Thank you Paul! :up:
okyesno
02-05-2009, 02:28 PM
Is there any control for post history ?
inciarco
03-23-2010, 06:54 PM
Hello.
The "Swith to Compare Mode" Utility is Working Fine on vB373 But Not on vB384, (I Just Noticed Today when I used it on vB384).
On vB384 Appears the Text "Array" in the Place the Sentences should be, but the Background Color of them Works Fine.
Is there Some Code I Can Edit on the Plugins or in the Mod's Files to Correct the "Array" Text that Appears Instead of the Phrases? :confused:
(I'm Using Version "1-5-0_B_3").
I Appreciate Your Help and Guide.
My Best Regards.
:)
Is anything like this around for vBulletin 4?
Carpesimia
07-25-2011, 06:29 PM
Agreed. We can view the post edits individually, but could use an undo or better yet BULK undo...
akz645
07-30-2015, 09:22 AM
Anything like this for vbulletin 4?
vBulletin® v3.8.12 by vBS, Copyright ©2000-2025, vBulletin Solutions Inc.