PDA

View Full Version : vBulletin Mail System


Pages : [1] 2

filburt1
09-04-2006, 10:00 PM
BEFORE YOU READ FURTHER, DO NOT INSTALL THIS MODIFICATION IN ITS PRESENT STATE. READ THE RELEVANT SECTIONS OF THIS POST FIRST IF YOU WISH TO INSTALL VBMS. I AM NOT OFFICIALLY SUPPORTING THIS MODIFICATION.

Note: For now, this thread will serve for all support questions. Obviously, the thread is going to get very long, very soon, and quickly lose any manageability. I hope to have a Premum Modification forum set up for vBMS, depending on whether the administration here supports it.

The vBulletin Mail System is now a free modification, instead of $40 to $48 (depending on the license). All features of the developer license (notes, etc.) are public as well. These files will be released shortly; they are not available yet.

For product information: http://www.webdesignforums.net/vbms/ .

What's attached to this thread?

The latest development version of vBMS, designed for 3.5 (incompatible with 3.0 in many ways, incompatible with 3.6 in a handful of ways). It is not to be installed in a live environment under any conditions.

What does this mean?

The forum at http://www.webdesignforums.net/vbms/forum/ will no longer serve as a support forum. If you have questions, you should do one of two things:
Post in this thread ONLY. All technical, historical, and nearly all other threads should be posted here. In all likelyhood, I will not response to technical questions in this thread, and I will not respond to such requests via private messages or other means. By posting in this thread, tens of thousands of other users can help you in addition to me (provided they don't get there first and I have the time).
If the question is personal for me only--no development questions--then send me a private message. Send the private message only through my site (http://www.webdesignforums.net/), not this site, so I can easily look up your customer history. Effectively, this involves billing only, or other licensing questions. What about those who purchased the product?

When you bought vBMS, you were paying for the stable 3.0 release that has been around for over a year, and a 2.3.x release that has been around for much longer (since 2003). You still have access to those products (they will be released in the new forum). However, your license has been inherited to a standard open-source license: you may now install vBMS on as many domains and forums as you like, as well as freely distribute it.

Your input has also allowed a stable 3.5 version to be very close to completion. The expertise of the tens of thousands of coders who are now exposed to vBMS--which includes the developers of vBulletin themselves--will further improve the product to create a stable and full-featured product for vBulletin 3.5, 3.6, and beyond.

If your intention was to buy a 3.5 release, please note that it was clearly and repeatedly mentioned that a 3.5 version was only under development, not readily available, and that the version available was specifically not suitable for live use. I apologize if you thought this was different as I attempted to make it abundantly clear, including specifically telling people not to buy vBMS if they are running vBulletin 3.5 or later.

However, with this transition to open source, you will still get what you paid for, and faster: a stable 3.5/3.6 release.

Why go open-source?

To be honest, it is not fair to those who bought a vBMS license but have upgraded their installation of vBulletin to beyond 3.0. This will allow a much faster development cycle with support from many vBulletin modification developers. There are secondary reasons as well:
Time. vBMS is well over 16,000 lines of code. Managing a product of that scope is simply beyond the several hours free I have each week to develop the product. Also, with Jelsoft churning out the vBulletin versions, developing a product that is dependent on frequent changes is extremely difficult. That is not to say that frequent new versions of vBulletin is a bad thing; it simply makes development difficult.
Product scale. As mentioned above, vBMS is huge--far bigger than the majority of vBMS additions and even bigger than some of the version transitions of vBulletin itself.
Reverse engineering vBulletin. As a factor of the two above, I am finding it increasingly difficult to develop for vBulletin. While I applaud Jelsoft for offering a product and specifically not mangling, encrypting, or otherwise prohibiting the viewing of its source (obviously, for customers only), there is still much to be done to favor strongly to developers who build products exclusively for their product. Others who feel catoring towards developers can help Jelsoft can see my request for a "developer license" of vBulletin (http://www.vbulletin.com/forum/showthread.php?t=131612).
Fraud. As many people know, online software vendors are among the worst hit for credit card fraud, and it's extremely damaging: even if a thousand copies of a piece of software are sold, it only takes one single fraudulent order to leak the product, voiding, in all honesty, the majority of future orders. After putting a great deal of time into vBMS to see it stolen so brazenly, it demoralized me.
Bad experiences. I have appealed several times to the community to hire additional developers, but the developers I hand-picked did not work out on these occasions. So far, none of the experiences has sped up development time, so paid outside help has not worked out.
Personal reasons. I have changed jobs, taken on part-time work (I'm still poor), and even had a death in the family break up my work.But the ultimate reason: I want vBMS to be available for all current versions of vBulletin so those who paid good money do not feel cheated.

What can and can't I do with an open-source vBMS in terms of licensing?

You can:
Distribute vBMS to anybody you like.
Modify vBMS to do whatever you like (excluding changing copyright notices), and then claim the changes as your own.
Remove mentions of vBMS, the "vBulletin Mail System", or other branding.
Develop special distributions of vBMS that you have extensively modified, and distribute those changes as a package
Sell any components of vBMS that you have directly created (this is allowed, but discouraged). Only the components themselves may be sold, not the entire package with your modifications included.You cannot:
Advertise any of your modifications that you may be selling at vBulletin.org.
Use vBMS for any illegal purposes, including use vBMS on a forum without an active vBulletin license.
Modify vBMS to do whatever you like, and then claim the entire product as your own.
Remove mentions of vBMS, the "vBulletin Mail System", or other branding, and replace them with others that imply you exclusively developed the product.
Sell any components of vBMS that the product originally contained or others have freely developed.
Sell the product as a whole, including a modified product.What technical skills do I need to understand how vBMS works?

You need the usual vBulletin skills in general. This means PHP, MySQL, HTML, and CSS. You also should have a working knowledge of XML.

You'll also need to familiarize yourself with how MIME headers in e-mails work. If you want to modify how vBMS receives and routes mail, you'll need to understand the beast that is the imap library: http://www.php.net/imap . The imap library is only used to receive messages; sending messages has no dependency on imap.

Will you help with development?

I'll offer simple assistance in whatever free time I have--and I'll only do it publicly in the new forum. I will not write extensive parts of code for you or talk to you privately about vBMS. I will enjoy answering questions about how vBMS works at a high-level, and then you can see the inner workings to see how it's actually implemented.

So can vBMS actually be installed?

The version of vBMS that has been uploaded is the latest development version. It can be installed on a test forum, but there are several critical bugs that need to be resolved. You can browse the old support forums (http://www.webdesignforums.net/vbms/) for an overview of those bugs. I have a suspicion that they are simple fixes to you, the community with experience with vBulletin.

What is the first goal of those movement to open-source?

I wish to have a stable version of vBMS with little to no known bugs available for vBulletin 3.5 and 3.6 as soon as possible to appease past and present customers. Feature additions should come later; compatibility and bug fixes should be the utmost priority. When the stable version for 3.5 and 3.6 is available, then new features can be added. At the old forums, there is a list of feature requests, many of which have been addressed.

What will be my role in this?

As a user experienced with vBulletin development, both you and others will benefit from a stable 3.5/3.6 version of vBMS. That should be the priority. Feature additions, visual tweaks, etc. come later. Compatibility and just making it work completely with the features already present is the most important.

What remains to be done for a transition to open-source?

The version of vBMS attached to this thread is the latest one to which customers had access. It is still littered with copyright information and warnings about piracy. While the copyright information is still valid and will perpetually be valid, you can obviously ignore the piracy warnings. A proper version will be uploaded within several days that is fully suitable for open-source use.

Remember, this means that the piracy warning is no longer applicable, but the copyright information is applicable and must never, under any circumstances, be removed.

Any last thoughts?

As with any modification, back up your site files, but more importantly, your database, before proceeding. vBMS makes a significant number of alterations and new tables.

Cole2026
09-05-2006, 08:36 PM
Awesome, I've heard this is a great bit of software. Much thanks for releasing for free. ;)

Shazz
09-05-2006, 09:26 PM
Nice, Good job on this :)

Slave
09-05-2006, 09:27 PM
As a paying customer I'm happy to see this go free as long as someone is able to release the changes required to fix it so that it works on 3.5 and hopefully 3.6 sooner than later.

If it's a case that someone takes the code, does the fixes and then keeps them for themselves then I and many others will be very cheesed off.

If possible, could any coder that is looking to work on this hack, please let us know via this thread .. we've been waiting for a working version of this since Feb '06 and it would be lovely to know we are going somewhere with it.

filburt1
09-05-2006, 09:29 PM
I agree 100% with you, Slave. The purpose of this free release is to first offer a stable 3.5/3.6 release. I also specifically am not permitting people to build a stable version and then sell it; doing so is not only unethical, but will make me take legal action against you.

I'm hoping the community can come together to rapidly make this a stable product, and then add new features later.

Eric
09-05-2006, 09:46 PM
This seems very interesting.

/me goes to take a look

Slave
09-05-2006, 09:56 PM
btw .. I take it that this is the latest dev version?

If it is, could I suggest you also release, or change it to, the version before that which used the vB cron system. The reason being is that I always felt that version was the closest to being a working product. Everything seemed to work apart from the cron, which now that any coder can have a look at the problem (including perhaps vB.com coders themselves) it can hopefully be fixed.

From what I remember of the threads at the time if the cron job was run manually it worked, so it was just something within the vb cron system that didn't like running it automatically.

filburt1
09-05-2006, 10:09 PM
If the developers can't get the new cron working, then I'll upload an older one.

The advantage over this implementation is that it can be set to run every n minutes. vB's cron system only allows every minute, or every given n minute.

Eric
09-05-2006, 10:35 PM
* Eric will try to get this working with 3.6 ;)

Guest190829
09-05-2006, 11:57 PM
Is there a bug list we can work off of?

filburt1
09-06-2006, 12:15 AM
I can post one later. One biggie is the emulated cron job doesn't always run automatically.

Paul M
09-06-2006, 12:49 AM
Can you describe, briefly, how is the emulated cron meant to work ?

filburt1
09-06-2006, 12:50 AM
Similar to the built-in system, it shows a 1x1 image (or an error icon if the cron fails) that checks the mail in the background. A global plugin checks to see when the last checkmail was, and if it was a certain time ago, it'll show the image.

Paul M
09-06-2006, 01:13 AM
Actually, is the only reason you do you own cron because you can't set more than four options in the minutes (or six in vb 3.6) ? - because the cron system itself can do as many as you want (you could run every two minutes if you want) - that 4/6 is only a limitation of the ACP inteface screen.

Cole2026
09-06-2006, 01:26 AM
I'm sort of leaning on an option with vBulletin to have cron-based, cron jobs. It would make things so much easier, as most servers support cron jobs.

bada_bing
09-06-2006, 01:42 AM
Wow I would love to see someone make this stable...

filburt1
09-06-2006, 01:51 AM
Actually, is the only reason you do you own cron because you can't set more than four options in the minutes (or six in vb 3.6) ? - because the cron system itself can do as many as you want (you could run every two minutes if you want) - that 4/6 is only a limitation of the ACP inteface screen.
That, and it was dying for seeminly no reason when run as a scheduled task. It would run just fine manually in the admin CP container for it, but it would just never run on its own for some reason.

But if you (all) want to convert it back to the scheduled task system, go right ahead; you're probably more experienced with the behavior in question.

filburt1
09-06-2006, 02:04 AM
I'm sort of leaning on an option with vBulletin to have cron-based, cron jobs. It would make things so much easier, as most servers support cron jobs.
Not all do, though, including IIS and crappy hosts who don't expose the functionality to their users. As a bit of nostalgia, the 2.3.x version of vBMS actually did require Unix cron jobs, mainly because there was no standardized alternative at the time.

Here's also what's new in this version over the one featured on the product home page. This page was intended to go live alongside a stable version, so it's not an official page. All the features listed on the page are in this version, and I believe all of the ones in the screenshot work.

http://www.intertubes.org/vbms-vb3-21/index.php

...which brings up a huge feature: the permissions system. It looks daunting in the code, but it's actually very simple, and even better, easily extensible. We can get to that when the time comes...and the permission system doesn't have any bugs that I recall for now.

Obviously, ignore all the ordering information on that page.

Wired1
09-06-2006, 02:28 AM
Rock on Filburt :)

Paul M
09-06-2006, 02:47 AM
That, and it was dying for seeminly no reason when run as a scheduled task. It would run just fine manually in the admin CP container for it, but it would just never run on its own for some reason.The usual reason for that is that people forget that cron jobs are run by any random user (or guest) - so they won't have the same permissions as you running the code manually.

Floris
09-06-2006, 05:42 AM
filbert1, this is really great news, thanks for sharing this on vBulletin.org :thumbsup:

sensimilla
09-06-2006, 06:42 AM
Great! :) I was considering buying it long time ago :)

Now its free.. shouldnt be its a huge work well done!

Tahnks

Kmaster
09-06-2006, 08:59 AM
run install file, but received below error:-

The vBMS Installer couldn't start: "Error 0 (not well-formed (invalid token)) parsing XML for file c:\program files\easyphp1-8\www\test/includes/xml/vbms_installation_resources.xml; return type was boolean." Please make sure you uploaded all of the necessary files to their proper locations

pretty sure, all files has uploaded into folder.

michaelk
09-06-2006, 08:59 AM
Hello,

I have a problem :confused:

Datenbankfehler in vBulletin 3.6.0:

Invalid SQL:
SELECT phrasetypeid, title, product
FROM vb_3phrasetype
WHERE phrasetypeid IN (500);

MySQL-Fehler : Unknown column 'phrasetypeid' in 'field list'
Fehler-Nr. : 1054
Datum : Wednesday, September 6th 2006 @ 11:57:08 AM
Skript : http://---------.de/admincp/vbms_install.php
Referrer :
IP-Adresse : -------
Benutzername : -----
Klassenname : vb_database


Gru? Michael

kall
09-06-2006, 09:37 AM
Hello,

I have a problem :confused:



Gru? Michael
Indeed you do .. you are trying to install this 3.5 (as clearly stated in the first post) on a 3.6.0 board.

The latest development version of vBMS, designed for 3.5 (incompatible with 3.0 in many ways, incompatible with 3.6 in a handful of ways). It is not to be installed in a live environment under any conditions.

filburt1
09-06-2006, 12:15 PM
Indeed you do .. you are trying to install this 3.5 (as clearly stated in the first post) on a 3.6.0 board.
Thank you for pointing that out before I did. :)

filburt1
09-06-2006, 12:20 PM
The XML is valid according to Firefox. It may be whatever XML parser PHP is using on your system, or an ancient PHP version.

BCC
09-06-2006, 02:41 PM
Would Love To See This Ported to Suit vBulletin 3.6.0 :)

Kmaster
09-06-2006, 02:43 PM
I'm try it in vb354 english version without error, but in my Tai language vb354 receive the error as bove mentioned.

bang
09-06-2006, 02:57 PM
glad to see this go free, however, I have trouble understanding who exactly will be developing vBMS now?

filburt1
09-06-2006, 05:27 PM
glad to see this go free, however, I have trouble understanding who exactly will be developing vBMS now?
You, the community.

Paul M
09-06-2006, 07:16 PM
The cron job file (vbms_checkmail.php) appears to be supplied in the forum root folder, it should be in the /includes/cron folder.

filburt1
09-06-2006, 07:20 PM
That's necessary for the new system; the old one was in /includes/cron as it should be.

Paul M
09-07-2006, 12:16 AM
Hmm, the install created a vb cron job pointing to the file in includes/cron - obviousy this failed (every minute) as the file was not there.

filburt1
09-07-2006, 12:17 AM
Yes, that is a holdover bug from this version. It's an easy fix though; in vbms_installation_resources.xml, just remove the step that adds that cron job.

Paul M
09-07-2006, 01:35 AM
Well another bug, which may be due to you crossing over the two cron methods is that the installation does not seem to create the vb options setting "vbms_checkmail_interval" - so the custom cron is going to run all the while.

sensimilla
09-07-2006, 07:01 AM
Installation went fine but the cronjobs are not working and no email is sent or recieved.

The Chief
09-07-2006, 02:25 PM
This is awesome, I'll check it out later this weekend and hopefully will install on myetalk.com :D

Thanks for your support!!

amykhar
09-07-2006, 02:29 PM
A request. Instead of having all that looooooooong former customer info in the first post and the mod description elsewhere, can you please put all the customer stuff elsewhere and a short description of the mod and a screenshot or two in the first post? Scrolling through looooooooooong unrelated stuff on each page isn't much fun.

filburt1
09-07-2006, 03:17 PM
Dammit, with all respect, please read the first post (this isn't directed towards Amy):

1. There are known bugs involving e-mail transmission and reception, and especially the scheduled tasks which are mentioned several times in this thread alone.
2. DO NOT INSTALL IT ON A LIVE SERVER.

The Chief
09-07-2006, 05:38 PM
Dammit, with all respect, please read the first post (this isn't directed towards Amy):

1. There are known bugs involving e-mail transmission and reception, and especially the scheduled tasks which are mentioned several times in this thread alone.
2. DO NOT INSTALL IT ON A LIVE SERVER.
Hmm, so we can't use this product?

Hope to see a fix soon :)

filburt1
09-07-2006, 06:20 PM
Again, please read the first post thoroughly. This modification exists here in order for the community to come together and develop the stable version.

amykhar
09-07-2006, 06:34 PM
This probably should have been put in the coder's forum until it's ready for release. You're just going to go nuts answering 'is it done yet?'

Injektilo
09-07-2006, 08:32 PM
Fatal error: Call to undefined function: imap_open() in /home/katsekal/public_html/forum/includes/vbms_class_installer.php on line 798

filburt1
09-07-2006, 09:02 PM
Please read the system requirements.

jugo
09-07-2006, 10:37 PM
I applaud you fil on making this open source for further development. I am a paid license owner of vBMS and honestly, I would pay for it again.

Paul M
09-08-2006, 12:04 AM
Again, please read the first post thoroughly. This modification exists here in order for the community to come together and develop the stable version.That's a nice thought, how do you intend to do this in an actual practical manner ? How are you going to co-ordinate the changes that people suggest/make into new versions for everyone else to keep up to date with ?

filburt1
09-08-2006, 12:23 AM
In the case of a separate forum, it is a matter of creating two sticky threads; one with a bundle of every fix available (the full product), and one with user-submitted fixes.

I do have means of running a dedicated CVS server, but I imagine it's beyond the abilities of most users (no disrespect intended; CVS is a piece of crap and not easy to use, especially if it's not built into your IDE like it is with Eclipse).

amykhar
09-08-2006, 12:50 AM
But, it may not ever BECOME a separate forum. It might always be a thread because every big mod really needs its own forum and that's just not a possible thing to do. Given that the premium forums are for mods that have been installed by tons of users, and this mod doesn't have working code, I think it's really premature to be expecting a premium forum for it.

COBRAws
09-08-2006, 02:20 AM
I applaud you fil on making this open source for further development. I am a paid license owner of vBMS and honestly, I would pay for it again.
I wouldnt. This is getting nowhere in the near future. I hope someone takes this project and finish it once for all.


ps. I paid for the license too. And regreat it since March 06 because no progress was being made.

filburt1
09-08-2006, 02:38 AM
Not one individual will take this project and finish it; the entire point of making it open-source is to appease customers who paid for it, mistakenly believing they were getting a 3.5 version, and never received the final version, only development builds as provided by the developer's license.

Instead, I expect quite a few developers to join in and assist each other (with my input as necessary) to develop the final product beyond what I could have done under the circumstances. Customers win because they will have paid $40 to $48 and gotten the final product, and what's more, the product beyond what was offered in the first place. New users win because they get a free, powerful, and community-driven web mail modification for their forums. I win as a result of the two factors just described.

The alternatives I considered:

Do nothing (always an option for any decision) and not look at the code ever again, just stating that the latest version is what's for sale, and that's it. That would piss off current customers, and there would be no future sales because vBMS would be incompatible from that point on with all vBulletin versions developed since.
Hire developers to continue, regardless of whether I broke even or made a small profit. I tried that twice, and it didn't work out.
Submit it to Sourceforge. I strongly considered that one, but I chose not to in order to restrict the codebase to vBulletin license holders, and to only expose the project to people in a vBulletin context.
Either give away or sell the codebase to Jelsoft. After consideration, they decided not to pick up the project at this time.
Submit it here. It would have the same benefits as submitting to Sourceforge, but would have greater exposure to vBulletin users.

You'll note that option #1 happened with HiveMail, vBMS's primary competitor, although I never planned the two to directly compete as I considered Hivemail to be a more full-featured product at the time, and it's standalone vs. vBulletin-powered. The same result happened: customers got pissed off, development didn't progress at all, and didn't get their money back. Hivemail hasn't been open-sourced to my knowledge, and from the posts I read, development is non-existent, and users are out far more than $40.

This solution, to reiterate, I chose to favor the community, not my tiny PayPal account and equally tiny checking account. This way, customers get a product beyond what they paid for, and future users are able to enjoy vBMS as well.

As for your discussion, Amy: I realize there could never be a dedicated forum for it (hosted here, that is; hosting it myself would not let me restrict access to vBulletin license holders). However, I can always try out the CVS server option. If you and others have alternatives, I'm more than happy to hear them. Anything to create an efficient collaborative environment, I'm all for.

Finally, I'd like this thread to be devoted to vBMS development, not arguments over the product's history or transition to open-source.

So, on that note, if somebody installs vBMS (and also to those who have tried using this version), let's start compiling a definitive list of bugs that need to be fixed.

A high-level list without specifics yet:

Sending mail is not always reliable. It varies greatly depending on whether you try to send attachments. This is now because vBMS supports both attachments and HTML messages (along with RFC compliance of sending a plain text version of that HTML), so a multipart/mixed message is necessary. Some mail servers butcher those headers; I know under Windows and PHP, including the Comcast SMTP servers, the message would get butchered and never sent properly (despite PHP reporting success).

If you can make a message that doesn't send properly, go back, check the option for "test the message without actually sending it", then copy and paste the output here; I suggest using the WYSIWYG editor here so it preserves the colors. Remember to censor out the important stuff (your e-mail address, for example), but keep the rest there, especially the headers and delimiters.
Receiving mail does not happen automatically. It occasionally fails manually. First, we should get the manual process working, then the automatic, which should be trivial. To test mail manually, go to vbms_checkmail.php in your forums' root directory (not the one in /includes/cron which is the one that the vB cron system used to use). If you look at the top of the file, I recall there being a switch you can add to the URL to include output. If you leave off the switch, you can refer to the mail checking logs in the admin CP vBMS section.

I suggest keeping it simple; just one user, no filters or anything fancy like that. Make sure you set up a catch-all account, nothing else like Outlook uses that account, and keep out things like attachments for now.
The installer would fail for some users. I could never reproduce the problem, so the installer gives you an error message, post it in full detail. That XML error message is strange: try opening /includes/xml/vbms_installation_resources.xml in your web browser and make sure it doesn't give you any errors (if it does, the file might be corrupted because Firefox thinks its valid XML over here).
Blank admin CP pages. I couldn't reproduce that all, but my suspicion is interference from other modifications the user installed. If you get blank admin CP pages, post a list of modifications you've installed.

Paul M
09-08-2006, 04:28 AM
As I posted yesterday, when I installed this version it did not create the vb options setting "vbms_checkmail_interval".

Slave
09-08-2006, 12:07 PM
The advantage over this implementation is that it can be set to run every n minutes. vB's cron system only allows every minute, or every given n minute.

For me, I'm be more than happy to have more than one cron job showing in the cron manager.

I just think, given the complexity of the code, people are more likely to be able to fix the old cron way of doing things because that is how people are used to doing things and have managed to get cron working, so why not this mod, instead of having to learn how you have worked your new cron before even trying to work out how to fix it.

* Slave shrugs ..

Given that it is now open source, am I allowed to give the older beta to someone to have a look at?

filburt1
09-08-2006, 12:26 PM
I can post some earlier versions later (or just allow public access to the vBMS forum).

Slave
09-08-2006, 12:38 PM
I can post some earlier versions later (or just allow public access to the vBMS forum).
Either one would be cool :)

In fact, allowing access to the vbms forums might be the way forward, to allow coders to chat about (and release) versions before release here at vb.org ..

filburt1
09-08-2006, 12:40 PM
Just moving all discussion to the vBMS forums would be simplest, but the only thing holding me back is keeping out users who don't have vBulletin licenses. If Jelsoft provided an API for hand-chosen forums to keep out unlicensed users, that would be different, but they never will for customer privacy reasons.

Slave
09-08-2006, 12:46 PM
Well .. people like vba and v3 arcade do it .. if I remember (it was so long ago that I signed up to their forums) they have a code string within a code quote on vb.org which has to be entered into the signup page of their forum ..

At least I think that's how they do it ..

filburt1
09-08-2006, 01:58 PM
That does give me an idea (that one you suggested is too insecure because if the code is leaked once, it's perpetually useless), involving a data exchange between vB.org and my server. I'll need to give it more thought.

Snake
09-09-2006, 05:41 PM
filburt1, I don't know how to thank you for realeasing it for free. Thanks a bunch! But is this going to work on 3.6.0 as well?

FireLighter
09-09-2006, 09:57 PM
Hey,

This is a great hack, and I desperatley want to use it. But during installation I get this error:
Database error in vBulletin 3.6.0:

Invalid SQL:
SELECT phrasetypeid, title, product
FROM phrasetype
WHERE phrasetypeid IN (500);

MySQL Error : Unknown column 'phrasetypeid' in 'field list'
Error Number : 1054
Date : Saturday, September 9th 2006 @ 06:25:24 PM
Script : http://CENSOR/forums/admincp/vbms_install.php
Referrer :
IP Address : CENSOR
Username : FireLighter
Classname : vb_database

What should I do?

Thanks,
-Josh

kall
09-09-2006, 10:38 PM
Hey,

This is a great hack, and I desperatley want to use it. But during installation I get this error:


What should I do?

Thanks,
-Josh
You should:

a) Read the first post, noting the part where it says this is a 3.5 Modification.
b) Read the Forum Title, which states this Forum is for 3.5 Modifications.
c) Not try to install this 3.5 Modification on your 3.6.0 Forum.

:)

Wired1
09-10-2006, 03:15 AM
filburt1, I don't know how to thank you for realeasing it for free. Thanks a bunch! But is this going to work on 3.6.0 as well?
Read the post at the very top of the thread, and also read kall's post.

BWilliams
09-10-2006, 05:27 AM
getting this error during install:

Fatal error: Call to undefined function: imap_open() in /home/socaps/public_html/vBulletin/includes/vbms_class_installer.php on line 798

The status bar does not increase past 7% (Step 1) after several minutes.

Ideas ??

blueuniverse
09-10-2006, 12:21 PM
BEFORE YOU READ FURTHER, DO NOT INSTALL THIS MODIFICATION IN ITS PRESENT STATE. READ THE RELEVANT SECTIONS OF THIS POST FIRST IF YOU WISH TO INSTALL VBMS. I AM NOT OFFICIALLY SUPPORTING THIS MODIFICATION.

In particular, a problem is noted with the install. It's not here for installations, it's here for coders to iron out the bugs.

Paul M
09-10-2006, 12:32 PM
You have to have php with imap support installed.

COBRAws
09-10-2006, 08:25 PM
filburt1 if you want a dedicated forum for vBMS hosted at vbulletin.org, it would be better if you released a functional version for vB instead of complaining about jelsoft not giving a dedicated section for people to discuss this hack.

Besides, since this wen Open Source, i've not seen any progress.

filburt1
09-10-2006, 08:28 PM
It's been open source for a week. You can't possibly expect people to learn a product that consists of 16,000 lines of code in a week, or perhaps even a month.

If there was a functional version that I developed for vB 3.5, then I wouldn't have gone open-source and kept the product closed-source and commercial. I haven't complained about a damn thing about a local forum here for vBMS; I discussed it with the staff here (speaking as a moderator here), they said no for know (along with all foreseeable future forums for any other modification released here), and I'm keeping this thread there.

BWilliams
09-10-2006, 10:35 PM
You have to have php with imap support installed.
How would I go about installing imap support? My hosting company uses cPanel.

P.S. I am trying to install this on a beta site to play around with.

Wired1
09-11-2006, 04:08 AM
BWilliams: Talk to your hosting company.

Brent H
09-16-2006, 08:04 AM
Wow, discussion about this sure ended abruptly.

Eggie
09-16-2006, 10:46 AM
I installed this. It received my test message twice via vbms.php but now i have 5 messages I can see via cPanel but vbms.php is not getting them.

Snake
09-16-2006, 11:32 AM
If you're looking for people to cooperate with you to develop this hack together, then why release it and post it in the mods forum? And especially when it's not even working...

Brent H
09-16-2006, 06:41 PM
Why not release it here:
http://code.google.com/hosting/

Honestly, if you're trying to go open-source, then trying to restrict the code to vBulletin license holders ONLY is a pretty fruitless effort.

Focus on getting people involved. Focus less on how you're going to maintain control of the source code.

Hell, I'll put it up myself just to get things going.

COBRAws
09-19-2006, 04:41 PM
If you're looking for people to cooperate with you to develop this hack together, then why release it and post it in the mods forum? And especially when it's not even working...
no way! Dont you see all people cooperating and making this hack work? LOL

Welcome back to february 2006, the diff is that you didnt loose your money.

NitroXploit
09-19-2006, 06:13 PM
Exactly...

filburt1
09-19-2006, 06:21 PM
Please get your facts straight before outright accusing me of not working on the damn thing since Feburary 2006.

I will host forums for discussion on my site as soon as I set up a cross-site authentication system.

cbr929rrerion
09-20-2006, 04:37 AM
OK.. I have installed this on my 3.5 board, it seems to work so far, no errors, seems smooth..

Now.. I can go to the compose and send a mail to anyone at any email address as normal, but I am not receiving any emails. If I reply back or try to just send to my alias@mydomain.com I get a failure notice it cant be sent..

any help would be appreciated..

Paul M
09-20-2006, 05:08 AM
You read all the warnings about it not working right ?

donatas
09-20-2006, 10:23 AM
i've read all 6 pages of topic, know that's many bugs/unfinished things but
installed,all fine can send mail, but when receive message "in reply" message doesn't putted in inbox (via cpanel i can see it, it's on server) is any chance to fix it? :)
ps: no any error messages/warnigs in scripts

y2ksw
09-20-2006, 11:33 AM
Nice to see this Open Source, right in the moment I was thinking about buying a license to check it out - and modify it to get it work with 3.6.x :)

filburt1
09-20-2006, 12:19 PM
OK.. I have installed this on my 3.5 board, it seems to work so far, no errors, seems smooth..

Now.. I can go to the compose and send a mail to anyone at any email address as normal, but I am not receiving any emails. If I reply back or try to just send to my alias@mydomain.com I get a failure notice it cant be sent..

any help would be appreciated..
What is the exact text of the failure notice? Are you sure you have a catch-all account?

deathemperor
09-21-2006, 10:06 AM
is it possible to get the vbms for vbulletin 3.0.x anywhere ?

filburt1
09-21-2006, 11:57 AM
is it possible to get the vbms for vbulletin 3.0.x anywhere ?
Attached.

deathemperor
09-21-2006, 12:31 PM
great, that was quick, thanks

Wired1
09-22-2006, 07:33 PM
Honestly, if you're trying to go open-source, then trying to restrict the code to vBulletin license holders ONLY is a pretty fruitless effort.I believe he means open souce as in the vBulletin community would help to build it for the vBulletin community.

The SPECIFIC community being the ones who have actually PAID for vBulletin. He doesn't want vBulletin pirates to have easy access to it. Yes, there's no doubt that eventually a paying vBulletin license holder will hand over the code to a pirate, but there's nothing wrong with discouraging them a bit.

Brent H
09-23-2006, 03:12 AM
I believe he means open souce as in the vBulletin community would help to build it for the vBulletin community.

The SPECIFIC community being the ones who have actually PAID for vBulletin. He doesn't want vBulletin pirates to have easy access to it. Yes, there's no doubt that eventually a paying vBulletin license holder will hand over the code to a pirate, but there's nothing wrong with discouraging them a bit.

Understandable. However, it might be wise to choose a better place for trying to organize any reasonably sized group of people willing to fix and improve this.

Throwing some buggy code into a release forum here won't get anyone interested in helping. You need a centralized location to make plans from and a way to discuss various aspects of this thing in separate areas... That can't happen here and I doubt it will happen at all, based on the "gotta keep it away from people without vB!" attitude I see here. That seems selfish and counter productive. Is someone really going to obtain a hacked version of vBulletin because of this mod?

I don't see a problem at all with using the existing VBMS forum and organizing stuff from there. If you're really that paranoid about non vB owners seeing everything, throw a password on the forums, put the password in a PHP box here and away you go.

It's been two weeks since this was made "open source" and I haven't seen so much as one person saying "okay, let's get organized".

If I had any kind of coding ability, I'd be the first to step up and take this under my wing. I don't have that ability, but I do have the willingness to help and will do whatever it takes to get this working.

filburt1
09-23-2006, 03:18 AM
You described the situation quite well, and I agree that it will help. Unfortunately, the solution of a password is secure at first but fails immediately once the password gets out.

I am working on connecting my site to vB.org to provide a casual authentication system, This way, the discussion can take place in its own forum, or whole set of forums (hell, maybe the existing forums currently only for customers), and still be restricted to vBulletin license holders.

Several fraudulent purchases of vBMS were made (stolen credit card, hacked PayPal account, etc.). I've also seen literally hundreds of pirated vBulletin forum installations. Finally, vBMS, or at least its concept of providing administration-free web mail to forum users, is popular and often-requested. I have no doubt that it is the correct decision to insist that only those most likely to own vBulletin licenses can access the product. As you note, the only problem is balancing this need of protecting both vBMS and vBulletin while still making it easy for as many people as possible to collaborate on the project.

Brent H
09-23-2006, 03:38 AM
^^
Well said :)

I'm glad to hear that efforts are still being made. It's hard work to maintain something of this size on one's own, so I congratulate you on what you've accomplished so far. If there's any way I can help, any way at all, let me know and I'll be happy to assist.

MPDev
09-27-2006, 12:07 PM
I have this running on my 3.6 system (installed under 3.5) with some minor modifications.

line 74 in vbms_new.php:

if (!empty($_POST['action']))

line 31 in vbms_class_mail_message.php:

define("VBMS_CRLF", "\n");

and I run the vbms_cron.php as a cron:

*/1 * * * * /usr/bin/wget -q http://www.mysite.com/forum/includes/cron/vbms_cron.php --delete-after

I'd be glad to pitch in where I could as time permits; our users have used this for some time with no problems and other than these few changes for 3.6, everything seems to be working fine now.

COBRAws
09-28-2006, 12:55 AM
I have this running on my 3.6 system (installed under 3.5) with some minor modifications.

line 74 in vbms_new.php:

if (!empty($_POST['action']))

line 31 in vbms_class_mail_message.php:

define("VBMS_CRLF", "\n");

and I run the vbms_cron.php as a cron:

*/1 * * * * /usr/bin/wget -q http://www.mysite.com/forum/includes/cron/vbms_cron.php --delete-after

I'd be glad to pitch in where I could as time permits; our users have used this for some time with no problems and other than these few changes for 3.6, everything seems to be working fine now.
are those all the changes? Thanks

darkblade25
09-28-2006, 06:08 AM
I have this running on my 3.6 system (installed under 3.5) with some minor modifications.

line 74 in vbms_new.php:

if (!empty($_POST['action']))

line 31 in vbms_class_mail_message.php:

define("VBMS_CRLF", "\n");

and I run the vbms_cron.php as a cron:

*/1 * * * * /usr/bin/wget -q http://www.mysite.com/forum/includes/cron/vbms_cron.php --delete-after

I'd be glad to pitch in where I could as time permits; our users have used this for some time with no problems and other than these few changes for 3.6, everything seems to be working fine now.
Is that all the changes that you made and does it run without any bugs? I want to put this in my site too.

filburt1
09-28-2006, 02:43 PM
<i>Very</i> strange that changing the VBMS_CRLF constant from \r\n to \n would work; IIRC, the RFC requires a CRLF (hence the name of the constant) instead of just a newline character.

But hey, that's why this is open-source, right?

darkblade25
09-28-2006, 04:54 PM
So I am assuming it works. Rihgt?

FireLighter
09-28-2006, 11:05 PM
This is great: progress! However does this solve the installation problems? I too would love to use this, but will be patient if necessary. Thanks for this amazing modification and for providing it to the community for free!

I look forward to see more as time goes on,
-Josh

COBRAws
09-29-2006, 10:34 PM
Any confirmation that with MPDev's final edit vBMS is finally a Functional product?

Thanks

Kingzor
09-30-2006, 06:10 PM
Installer working for 3.6 yet? Would like to finally get a working product that I paid for.

kall
09-30-2006, 07:50 PM
Installer working for 3.6 yet? Would like to finally get a working product that I paid for.
You didn't pay for a working 3.6 version, as that has never been offered.

The purpose of this thread is to allow a group (or individual) effort to get vBMS to 3.6.x working status.

ianwilcox
10-01-2006, 11:33 PM
How is this progressing , Who is now devloping this modifcation :)

kall
10-02-2006, 04:15 AM
The community is.. or, that is what is intended by Filburt releasing it here.

You could even work on it! :D

MPDev
10-02-2006, 01:09 PM
Without the change to the CRLF, the email wasn't being sent as HTML - the headers were being sent as part of the text message.

So far, everything is working on my 3.6 installation with no complaints from my users; however, as I said, I installed under 3.5 originally, so I haven't had the opportunity to try the installer under 3.6.

I did have a problem during the upgrade process from 3.5 to 3.6 and I had to clear out the xml files from the includes/xml directory (except for vB defaults). I never tracked down which XML file it was that was interfering with the upgrade; but once I was upgraded I moved the other XML files back and all was well.

Kingzor
10-02-2006, 08:14 PM
You didn't pay for a working 3.6 version, as that has never been offered.
I payed for this when 3.0.x was the major flavor with promise's of upgrades being free.
Thats like saying ok you paid for xxxx antivirus BUT you dont get any updates to the virus definitions.

Edit:
Heres a even better one

Its like paying for vbull, but you dont get any updates.

COBRAws
10-02-2006, 09:43 PM
You didn't pay for a working 3.6 version, as that has never been offered.

The purpose of this thread is to allow a group (or individual) effort to get vBMS to 3.6.x working status.
well, i paid for a 3.5 and was never released. I thought this thread was for a working 3.5 vbms not 3.6

Appart from this, can some vborg Staff member update the original release with the updated? Because I dont see anywhere a link to download the working one...

kall
10-02-2006, 09:50 PM
I payed for this when 3.0.x was the major flavor with promise's of upgrades being free.
Thats like saying ok you paid for xxxx antivirus BUT you dont get any updates to the virus definitions.

Edit:
Heres a even better one

Its like paying for vbull, but you dont get any updates.
No, it isn't.

It *would* be, if you purchased vB under a clearly spelt out condition that you wouldn't receive updates.

filburt1
10-02-2006, 10:47 PM
well, i paid for a 3.5 and was never released. I thought this thread was for a working 3.5 vbms not 3.6

Appart from this, can some vborg Staff member update the original release with the updated? Because I dont see anywhere a link to download the working one...
If somebody compiles a final working version, I'll add it.

filburt1
10-02-2006, 10:48 PM
I payed for this when 3.0.x was the major flavor with promise's of upgrades being free.
Thats like saying ok you paid for xxxx antivirus BUT you dont get any updates to the virus definitions.

Edit:
Heres a even better one

Its like paying for vbull, but you dont get any updates.
That's what happens already. You need to pay $30 a year, or $85.

COBRAws
10-10-2006, 01:14 AM
Any progress on this? Its the same as the day it was "released".
Thank you.

filburt1
10-10-2006, 01:23 AM
You'll note the last several posts already discuss changes that seem to fix all known issues.

BCC
10-10-2006, 10:59 AM
Im Very Intrested in Getting this Modification for 3.6.0, I Have Read the Comments from Other Users, and Understand a the Problems Here for 3.6.0 Use, Is it Possible for Me to Pay Some to Port this Hack for my Personal Use? As I Need this ASAP?

Wired1
10-11-2006, 02:08 PM
Im Very Intrested in Getting this Modification for 3.6.0, I Have Read the Comments from Other Users, and Understand a the Problems Here for 3.6.0 Use, Is it Possible for Me to Pay Some to Port this Hack for my Personal Use? As I Need this ASAP?

1. Please don't type in all caps.
2. No one can be paid to port this, as that is specifically against the open source release constraints that filburt noted IN THE FIRST POST when he transferred this from closed to open source.

If someone does update the code with the fixes, I'll throw it up on my test server and see how it goes. Offhand, I wonder if this could be merged w/ google's gmail for domain thing (which I've only read a bit about)

ShadowWeaver
10-18-2006, 09:58 AM
is anyone actually working on that thing? ;)

PoetJA-1975
10-18-2006, 11:02 AM
You'll note the last several posts already discuss changes that seem to fix all known issues.
Release: 05. Sep 2006
Installs: 38
Last Update: Never
Rating: https://vborg.vbsupport.ru/external/2006/10/6.gif

3.5.4 is my friend - This modification seems heaven-scented... Should I bother?

Jacquii.

COBRAws
10-19-2006, 10:36 PM
this hack is now lost, always was imho... damn

Brent H
10-22-2006, 05:39 AM
I'm a bit disappointed as well... Maybe DChapman will save the day with ZointsMail ;)

I may not be a coder, but as I said a couple pages back - I'm more than willing to do what I can to make sure this thing gets updated. Nothing seems to have been accomplished and a more optimal place for development has not been created, despite the author's claims that he was working something out.

Killsparer
10-23-2006, 09:38 AM
But according to this post, there doesn't seem to be much work left:
https://vborg.vbsupport.ru/showpost.php?p=1084564&postcount=89

"Just" a working 3.6 installation and the above mentioned changes.

dieselpowered
10-26-2006, 06:09 AM
I must be honest, this is exactly what I need...once a stable version is available I am all over this!!

whiteeagle0
10-27-2006, 01:49 AM
will the mail system hack work with vbulletin 3.6.2

Blackhat
10-28-2006, 04:26 PM
I dont think so. I get this error when trying to install on my 3.6.0 test site

Database error in vBulletin 3.6.0:

Invalid SQL:
SELECT phrasetypeid, title, product
FROM vb3_phrasetype
WHERE phrasetypeid IN (500);

MySQL Error : Unknown column 'phrasetypeid' in 'field list'
Error Number : 1054
Date : Saturday, October 28th 2006 @ 01:25:28 PM
Script : http://www.wwwwww.no/admincp/vbms_install.php
Referrer :
IP Address : 85.165.161.211
Username : admin
Classname : vb_database

noreturn
10-29-2006, 12:12 AM
Many people are asking about it working on 3.6x. Yet I am still wondering if it installs and works on 3.4 (or 3.5) as that it what it was being developed for and paid for at that time of development. Does any one know for certain if this is installing and also working on 3.5 (or not)?

And I suppose I should add this question to this to be more precise.....If it is installing and working on 3.5, is it with (or without) those edits shown that were done to get it to work for 3.6 posted by MPDev two pages back? Or are those edits ONLY for 3.6?

Thank You

COBRAws
10-29-2006, 04:46 PM
Ok, now I have this question... as this is getting NOWHERE, like I always said, the zip was NEVER updated with the code fixes posted here, and this is OPEN SOURCE, now, I am not able to pay someone else to fix it and port it right?

So.... should I go to paypal and start a buyer complaint noting the things I've said above, or should I be resigned waiting for a magical coder to fix this? Because, when I am being nailed, I can be a VERY annoying and I can find plenty of time to be annoy.

Someone just clear my thoughts out please, at least the open source and paid request for update point

Thank you

noreturn
11-02-2006, 02:23 PM
Yes, that is a holdover bug from this version. It's an easy fix though; in vbms_installation_resources.xml, just remove the step that adds that cron job.

Could you please tell me what line numbers to remove from the file you mentioned. Or exactly what the code reads that should be removed.

Thanks
noreturn

Brent H
11-05-2006, 05:18 AM
2 months and no updates... Someone should just cut the crap and release this in SourceForge or something. This is getting ridiculous.

noreturn
11-05-2006, 05:53 AM
Every install I attempt goes through, however the operation of vbms fails.

I have looked all over the zip for a file that it seems to be calling for but there is no file in the zip by that name. I even looked in old version of Filburt1 zip and do not see the file. The file being looked for by vbms is called vbms_cron.php. Not to be found.

Bellow Here is what my host is telling me.

From: "Site5 Technical Support" <customer.service@site5.com>


Hi,


The file you are trying to process in cron is not in the directory indicated by the URL.


root@leto [/home/stargaze/www/includes/cron]# ls -al vbms_cron.php
/bin/ls: vbms_cron.php: No such file or directory
root@leto [/home/stargaze/www/includes/cron]#


Please upload vbms_cron.php into the cron directory and this should work for you.


Thank You,
Eric
System Administrator
Site5 Internet Solutions, Inc.
http://www.site5.com


Technical Support:
24 hours a day / 7 days a week

Killsparer
11-08-2006, 09:27 AM
Some status-update would be nice.
Does the install-method of v3.6 differ that much from 3.5?

Lionel
11-10-2006, 08:41 AM
I am able to manually install on 3.60, seems to work. I only have some trivial bugs, such as deleting an empty folder will give you a scalar error; strangely you hit back in the browser and attempt to delete it again, it works. I am also so far not able to display the set options properly. They are inserted in the db, but when you visit the page again, none are checked, and the forward $key is always displaying "Warning: value for replyforwardprefix not specified and no constraint type defined"

I still need to import the FAQ

Lionel
11-10-2006, 09:45 AM
got the filters and the options to work.

in vbms_filters.php

I simply replaced the $_POST call with (last line only)

if ($_REQUEST['action'] == "delete")
{
vbms_api_safe_call("delete_filter", $_GET['filterid']);
}
else if ($_REQUEST['action']=='add')

i did the same thing with the options by adding a hidden input in the templates and doing a

else if ($_REQUEST['do']=='addoptions')

This does not seem too complicated to fix.

I even added a private calendar link :-)

Slave
11-10-2006, 01:02 PM
What do you mean by manually install? How long did it take and how easy was it? .. and is it something you could share?

Lionel
11-10-2006, 01:22 PM
The problem is the phrasetype table structure is not the same from 3.54 to 3.60
I had xml error from the very first line of the install. So what I did, I opened the xml and ran the queries one by one in php admin, simply changing {tp} with my prefix. Once all the tables were created and the inserts done (a matter of minutes), I imported the templates xml from the upload styles input.

Did the same for the phrases. That took a couple of minutes.

The biggest headache is the settings. I had to do them one by one, but it's only 14 of them. You need also to set the settinggroup (1 entry with phpadmin)

Then the fun begins. I replaced all $DB_Site with $db (just a search and replace for all the files).

Then within the php, some changes are needed, around $_POST calls. I introduced a hidden input in the templates and instead of if(!empty($_POST)) I made it if ($_REQUEST['do']=='addfilter') for example, and that took care of the checkboxes not displaying the updates.

Did the same thing in vbms_new.php

I would say I have it 90% working on 3.60. I still have that annoying error when deleting an empty folder. But if you go back and do it, then it is fine.

The solution posted earlier by MPDev define("VBMS_CRLF", "\n");

took care of making the html emails clean.

For some reasons, it sends double emails.

I am still sorting out the very 2 or 3 remaining issues.

I really don't know what was filburt1 problem. I am no way near the masters of this site, but am able to sort the issues, which so far seems to be insignificant.

Slave
11-10-2006, 04:27 PM
Thanks Lionel :)

I'll take a look this weekend and see what I can do .. if you could keep us updated with and changes that would be great, thanks again :D

Lionel
11-11-2006, 03:49 PM
Like I said before, I got this 97% working on 3.60. I am receiving, sending, getting email notifications about new mail received, create filters, folders etc...

Only the faq remains to be imported from the xml and the only bug left is deleting the empty folder. The function api_safe_call seems to be checking only for folders with messages. But what is stranged, after I get that database error, I simply hit back in browser and am able to delete empty folder this time. Same step at first try gives me a database problem.

FireLighter
11-11-2006, 06:53 PM
Awesome! Thanks Lionel! I can't wait to try installing it - do keep us updated.

Thanks a lot,
-Josh

filburt1
11-11-2006, 08:55 PM
Random musings:
1. Yes, phrasetype is the main incompatibility issue.
2. Somewhere in there, there's the line:
$DB_site &= $vbulletin->db;
It was obviously a quick compatibility fix.
3. The issues were all caused by trivial problems, I suspected. I just didn't have any time left to fix them, so I released it to free. Glad to see it's made the progress it has.

If you can get it working to the point where it's redistributable, attach it here and I'll update the first post.
The problem is the phrasetype table structure is not the same from 3.54 to 3.60
I had xml error from the very first line of the install. So what I did, I opened the xml and ran the queries one by one in php admin, simply changing {tp} with my prefix. Once all the tables were created and the inserts done (a matter of minutes), I imported the templates xml from the upload styles input.

Did the same for the phrases. That took a couple of minutes.

The biggest headache is the settings. I had to do them one by one, but it's only 14 of them. You need also to set the settinggroup (1 entry with phpadmin)

Then the fun begins. I replaced all $DB_Site with $db (just a search and replace for all the files).

Then within the php, some changes are needed, around $_POST calls. I introduced a hidden input in the templates and instead of if(!empty($_POST)) I made it if ($_REQUEST['do']=='addfilter') for example, and that took care of the checkboxes not displaying the updates.

Did the same thing in vbms_new.php

I would say I have it 90% working on 3.60. I still have that annoying error when deleting an empty folder. But if you go back and do it, then it is fine.

The solution posted earlier by MPDev

took care of making the html emails clean.

For some reasons, it sends double emails.

I am still sorting out the very 2 or 3 remaining issues.

I really don't know what was filburt1 problem. I am no way near the masters of this site, but am able to sort the issues, which so far seems to be insignificant.

Lionel
11-11-2006, 09:36 PM
What I don't get, the cronimage, the envelope with the exclamation mark, displays every minute at the bottom of the footer. That should tell me that the cron did not run. The log tells me it was not possible to connect to IMAP, yet I get the mails, as per the image (I borrowed that code from the 3.07 zipped version that you uploaded)

One of the files, I think it was the cron, not sure, will not work until I changed it to $db so I played it safe and changed them all. I also changed some $vboptions into $vbulletin->options. Like Paul M. pointed in a post earlier, the interval settings had to be added.

Now, once I get the last bug out I could upload all my changes, someone else would have to package the xml. I still have not learned how to do it, as I code mostly for myself and work off database directly and use debug mode for settings.

filburt1
11-11-2006, 09:38 PM
Try looking in the logs to see if there were warnings or something.

I don't get what the screenshot is for, though; it's just showing you have unread mail somewhere (isread, read, whatever is 0, not 1, for one of your messages).

Lionel
11-11-2006, 09:44 PM
That image, I got the code from the other zip that you uploaded. It's the code that pops up under the navbar of any vb page when you have a message.

I disabled loggin errors, because all there was in there is unable to connect to imap, which is not true.

I posted screenshot to show you that email is coming. Cron is running by itself.

Lionel
11-11-2006, 10:11 PM
This is another screenshot

I also need to fix the notification to real email. It comes empty

And I have not yet tested attachments.

Lionel
11-12-2006, 12:12 AM
Some great news.
the main reason why the cron was not running in the cron folder is because

require_once( "./includes/vbms_preinit.php");

should have been

require_once(DIR . "/includes/vbms_preinit.php");

This is my log nowWarning 11-11-06 09:10 PM Running mail check despite there being 15 seconds minimum until next scheduled run
Debug 11-11-06 09:10 PM Connecting to mail server
Debug 11-11-06 09:10 PM Retrieving message count...
Information 11-11-06 09:10 PM There are 0 messages on the POP3 server that need to be downloaded
Debug 11-11-06 09:10 PM Closing connection
Information 11-11-06 09:10 PM vBMS mail checking completed

Lionel
11-12-2006, 12:23 AM
Worth checking also. Since I am forcing TLS, I had to change in the checkmail_functions
$vulletin->options['vbms_notls']

to$vulletin->options['vbms_forcenotls']

as the correct options was 'vbms_forcenotls'. I am not sure if I picked that from comparing 3.07, but somehow this is what it was in vbulletin options.

Lionel
11-12-2006, 12:27 AM
and the very simple query to take care of phrase type, replacing TP_ with your prefix:

INSERT INTO `TP_phrasetype` VALUES ('vbms', 'vBulletin Mail System (vBMS)', 3, 'wdf_vbms', 0);

Lionel
11-12-2006, 12:48 AM
BTW I solved the previous mystery of failed image and successful cron: I forgot I had hardcoded the login values :-)

Lionel
11-12-2006, 12:52 AM
I wonder what is the name of the 1x1 successful gif? Now that it is successfull i get a broken image

Lionel
11-12-2006, 01:01 AM
here is a copy of my working cron (in the cron folder)

Lionel
11-12-2006, 02:54 AM
everything is just fine. The problem that I am now facing, the cron is not deleting the mail from server after retrieving it, therefore the same email is retrieved over and over.

Lionel
11-12-2006, 03:10 AM
I just found out that setting was also missing

vbms_expunge

Lionel
11-12-2006, 03:58 AM
99% working on vb 3.60

only the 'empty folder delete' bug left to squash and the faq (which is nothing)

I am not clear which cron is doing the job, the one at root or the one at the cron folder, and I don't care to find out as the job is being done as designed by filburt.

I did the whole thing manually.

If I can get a couple of you guys to signup at my site and beat it up so I am 100% sure it works, then I will release step by step instructions of what I did plus my sql and modified files plus a couple templates I changed to accomodate the php changes. Hopefully for the rest of you, someone else will take over and pack it into a product (personally I don't see the need to do so as this is independent from any vb files)

Anyway, a big thank you to filburt for releasing this. It will be a welcome addition to my site.

just send me a PM for a link

P.S. I will hold from installing any other hacks for the next two days, as it will be easier for me to retrieve the last queries from the database.

There is also a minor bug in the groups permissions. For some reasons you must save it twice for the changes to take effect.

filburt1
11-12-2006, 04:29 AM
Very happy to see that you were able to turn it into a stable product.

The 1x1 GIF should be a clear GIF in your forums' root folder, IIRC.

vbms_expunge controls whether mail is deleted or not once downloaded, which would explain your duplicates.

Lionel
11-12-2006, 04:37 AM
I am now adding the various who's online locations as plugins

COBRAws
11-13-2006, 05:23 AM
Lionel, thanks for all the help ;)

Lionel
11-13-2006, 03:57 PM
Please don't PM me and offer me money to install for you. Hack belongs to filburt. If you want it badly, register at my site and test it out so I am sure it's bug free, then I will post instructions for all.

filburt1
11-13-2006, 04:00 PM
Moreover, it's against the licensing terms I clearly put forth in the first post for him to sell you the product. Do not request it from him for pay.

If you want it so badly, offer to test it and help him bundle it into an installable package so the whole community can view it.

Killsparer
11-13-2006, 05:09 PM
Please don't PM me and offer me money to install for you. Hack belongs to filburt. If you want it badly, register at my site and test it out so I am sure it's bug free, then I will post instructions for all.

Thanks for finishing the addon!

So what is the URL of your site? I really would like to take a look.

Lionel
11-13-2006, 05:47 PM
I sent you a PM.
I don't like to post my URL in public. In fact I removed it from my profile. I am paranoid. I think this is where those Russians spammers come and get vb url then bombard your forums. :-)

Killsparer
11-13-2006, 06:29 PM
I sent you a PM.

Thanks!
I already did some testing. I believe most of the bugs i found (until now) have already been mentioned:

- Folder-delete = Database error-message

- Mail sent via forum arrives two times at my mail-client (mail-header seems to contain duplicate entries of "to" and "subject")

- I tried to sent a second mail to check the above error, but i got the "Sorry, you can only send one message every 1 minutes."-message, even after currently ten minutes.

Lionel
11-13-2006, 06:34 PM
Floodcheck. Someone else reported it. I am currently looking at it. I can't duplicate it with a regular user, but did find something worth investigating.

That folder delete, I am detemine to squash it today.

Can you PM me a copy of mail received?

Did you try sending an email to your forum address to test the cron?

Killsparer
11-13-2006, 06:43 PM
Can you PM me a copy of mail received?

Done.
If you need anything else, just ask.

Did you try sending an email to your forum address to test the cron?

Yes, and it worked as far as i can see.

Lionel
11-13-2006, 07:36 PM
I believe floodcheck has been solved.
Another problem I spotted: Quotas. If you empty your sent item folder, quotas is reset at a negative value.

Lionel
11-13-2006, 07:43 PM
Some interesting info in the email you received. It carries the xmailer info from filburt forum

Lionel
11-13-2006, 08:42 PM
got the delete folder bug out of the way. Now, let's hunt for the double email.

Lionel
11-13-2006, 09:28 PM
Quota is behaving ok now.

Lionel
11-13-2006, 09:58 PM
HTML email has been possible all along. The advanced editor must be used instead of standard editor.

So I am not considering this as a bug. On my site I will simply add additional instructions for end users.

nix
11-14-2006, 09:20 PM
Wow, great job. Looking forward to this.

DaNIEL MeNTED
11-15-2006, 01:21 AM
This is just what I was looking for... tagging for updates!

Killsparer
11-16-2006, 03:19 PM
Any news? All this progress makes me quite hopeful! :knockedout:

filburt1
11-16-2006, 03:52 PM
The X-Mailer-Info might be what you're talking about:
"X-Mailer-Info" => VBMS_URL,
vbms_class_mail_message.php

That should describe what was used to send the message, and it's accurate that it points to the vBMS product URL.

Lionel
11-16-2006, 07:34 PM
Any news? All this progress makes me quite hopeful! :knockedout:

you tell me. You have most of my files already and whatever problems you reported, I believe was fixed.

Killsparer
11-16-2006, 07:53 PM
you tell me. You have most of my files already and whatever problems you reported, I believe was fixed.

Eh, got your files? Did i miss a mail?
(Or perhaps i just missunderstood something.)

But i just tested the version at your forum again. The mail sent from there arrived twice again at my client.

Lionel
11-16-2006, 07:55 PM
OK, then it was someone else. I get the double emails, you get the double emails, 2 other guys don't.

So all that is left is the double email and email not being html on site, when received from an alias.

It might help to know which php version everyone uses so I could narrow down that double emails issue.

Problem is I get help only once, then everyone disappears.

Killsparer
11-16-2006, 09:09 PM
OK, then it was someone else. I get the double emails, you get the double emails, 2 other guys don't.

No expert here, but could it not just be a problem with the mail-header? Both mails contain the following (adress edited out):

To: xxxx@myclient.com
Subject: test-mail 4
MIME-Version: 1.0
From: "killsparer" <Killsparer@yourforum.com>
To: xxxx@myclient.com
Subject: test-mail 4
Date: Thu, 16 Nov 2006 16:49:24 -0500

What i mean is, that the header contains "to" and "subject" twice. Couldn't it cause the double-mails?

dodgeboard.com
11-17-2006, 12:12 AM
OK, then it was someone else. I get the double emails, you get the double emails, 2 other guys don't.

So all that is left is the double email and email not being html on site, when received from an alias.

It might help to know which php version everyone uses so I could narrow down that double emails issue.

Problem is I get help only once, then everyone disappears.

I am getting the double emails when sending to either my hotmail addy or my pop addy. What, if any information do you need from me? I'll help however I can.

Lionel
11-17-2006, 12:18 AM
Later on or tomorrow, I'll look at that double emails issue.

dodgeboard.com
11-17-2006, 12:23 AM
I did some test driving on the VBMS and it looks like we're almost there for a working VBMS. I want to extend a big CONGRATS to all that have worked on this. It will be a very welcomed addition to vBulletin. A HUGE thankyou to Lionel for spending so much time on this and to Filburt for helping and releasing the product as open source. Way to go guys!

dodgeboard.com
11-17-2006, 09:25 PM
No expert here, but could it not just be a problem with the mail-header? Both mails contain the following (adress edited out):



What i mean is, that the header contains "to" and "subject" twice. Couldn't it cause the double-mails?


This is a good point. Mine are the same; (2) To: lines, (2) subject: lines
Noticing also in the header that the emails are only milliseconds behind each other. Almost like the CC line and the TO lines are getting joined, but creating two TO: lines in the header. ???

Perhaps something in the email header creation is fubar? Dupe table entries?

dodgeboard.com
11-17-2006, 09:50 PM
Ok, so I think we are onto something here. When I send it with a subject line "this is a subject line"

I get this in the subject line on the preview panel of Outlook;

this is with a subject line this is with a subject line

But when I double click on the email to show it in a seperate window, it only shows one, so Outlook is dealing with the duplicate entry and excluding one of the subject line entries in the header.

So the header duplicating the subject line and duplicating the TO: line is the reason why we get two emails. Now, we need to figure out why the header is being compiled this way for some users and not all of them. I tried a theory; logginginto your forums using cookies and without- both methods resulted in dupe emails.

Lionel, do you have...or can you get...header from one of the users that does not get the dupe emails?

DaNIEL MeNTED
11-17-2006, 10:00 PM
Technically its the duplication of the TO: line.

With the caveat that I have not looked at the code...

The protocol requires that each recipient be identified individually. When you send an email with 3 people in the "to:" the server actually breaks that down into 3 "RCPT TO: X@X.com" commands that are sent to the server on the other end of the communication... assuming the code it is going to acheive the same thing.

dodgeboard.com
11-17-2006, 10:19 PM
Well, look this over Daniel and see if you can spot something that would be causing this.

function vbms_api_send_message(
$to, $subject, $bbcode, $attachments = false, $xpriority = VBMS_XPRIORITY_NORMAL, $savecopy = true,
$addsignature = true, $reformatsignature = true, $testonly = false, $previewtype = false, $userid = 0)
{
// prep fields
$to = trim($to);
vbms_adjust_userid($userid);

if ($attachments === false)
{
$attachments = array();
}

if (!empty($to) and is_array($attachments) and $userid > 0)
{
global $DB_site, $bbuserinfo, $vboptions, $vbulletin;

// get missing data if not the current user
$permissions = vbms_get_permissions_by_userid($userid);

// set priority to normal if no permission
if ($xpriority != VBMS_XPRIORITY_NORMAL and !$permissions[VBMS_PERMISSIONS_CAN_USE_PRIORITIES])
{
$xpriority = VBMS_XPRIORITY_NORMAL;
}

// do attachment permission checks
if (!empty($attachments))
{
if (!$permissions[VBMS_PERMISSIONS_CAN_SEND_ATTACHMENTS])
{
return vbms_api_result::create_fail_instance("vbms_no_attachment_send_permissions");
}
else if (sizeof($attachments) > $permissions[VBMS_PERMISSIONS_MAX_ATTACHMENT_COUNT])
{
return vbms_api_result::create_fail_instance("vbms_too_many_attachments");
}
else if ($permissions[VBMS_PERMISSIONS_MAX_ATTACHMENT_FILESIZE] > 0)
{
// check bytes used
$totalbytes = 0;
foreach ($attachments as $attachment)
{
$totalbytes += $attachment['filesize'];
}

if ($totalbytes > $permissions[VBMS_PERMISSIONS_MAX_ATTACHMENT_FILESIZE])
{
$given = vb_number_format($totalbytes, 1, true);
$allowed = vb_number_format($permissions[VBMS_PERMISSIONS_MAX_ATTACHMENT_FILESIZE], 1, true);
return vbms_api_result::create_fail_instance("vbms_attachments_too_large", array($given, $allowed));
}
}

// check extensions
$allowedexts = vbms_get_valid_attachment_extensions();
foreach ($attachments as $attachment)
{
$extension = file_extension($attachment['filename']);

if (!in_array($extension, $allowedexts))
{
return vbms_api_result::create_fail_instance(
"vbms_denied_attachment_extension",
array(vbms_grammatical_implode($allowedexts)));
}
}
}

// load the signature, if necessary
if ($addsignature)
{
if ($userid != $bbuserinfo['userid'])
{
$user = $DB_site->query_first(
"SELECT signature
FROM " . TABLE_PREFIX . "usertextfield
WHERE userid = $userid");
$signature = $user['signature'];
}
else
{
$signature = $bbuserinfo['signature'];
}
}

// load alias and username, if necessary
if ($userid != $bbuserinfo['userid'])
{
$user = $DB_site->query_first(
"SELECT username, vbms_alias
FROM " . TABLE_PREFIX . "user
WHERE userid = $userid");
}
else
{
$user = $bbuserinfo;
}

$to = vbms_converttos($to);

// -----------------------------------------------------------------------
// construct a mail object and send it
// -----------------------------------------------------------------------

// construct
$object = new vbms_mail_message();

// set fields
$object->set_subject($subject);
$object->set_from($user['vbms_alias'], $user['username']);
$object->set_message_bbcode($bbcode);
$object->set_recipients($to);
$object->set_xpriority($xpriority);

// apply signature/trailer options
$object->apply_options($signature, $rewritesignature,
$permissions[VBMS_PERMISSIONS_REQUIRE_TRAILER],
$permissions[VBMS_PERMISSIONS_ABUSE_LEADER]);

// add attachments
foreach ($attachments as $attachment)
{
$object->add_attachment(
$attachment['filename'], $attachment['data'],
$attachment['mimetype']);
}

if ($previewtype !== false)
{
global $vbphrase, $stylevar;

$html = $object->construct_message_html($previewtype);

print_output($html);
return vbms_api_result::get_void_success_instance();
}
else
{
// send it
$result = $object->send($testonly);
if ($result !== true)
{
return vbms_api_result::create_fail_instance("vbms_senderror",
array(trim($result)));
}
else
{
// update floodcheck dateline
if ($permissions[VBMS_PERMISSIONS_SEND_FLOODCHECK] > 0)
{
$vbulletin->db->query(
"REPLACE INTO " . TABLE_PREFIX . "vbms_sendfloodcheck
(userid, dateline)
VALUES
($userid, " . TIMENOW . ")");
}

// add to sent messages (and increment quota)
if ($savecopy)
{
$bytes = sizeof($bbcode);
$bbcode = addslashes($bbcode);

$from = addslashes("\"" . $user['username'] . "\" <" .
$user['vbms_alias'] . "@" .
$vboptions['vbms_todomain'] . ">");
$subject = addslashes($subject);
$message = addslashes($bbcode);
$messageid = vbms_get_first_available_messageid();
$DB_site->query(
"INSERT INTO " . TABLE_PREFIX . "vbms_message
(messageid, format, userid, folderid, xpriority,
dateline, readflag, fromname, subject, message)
VALUES
($messageid, \"bbcode\", $userid, " .
VBMS_FOLDER_SENTMESSAGES . ", $xpriority,
" . TIMENOW . ", 1, \"$from\", \"$subject\",
\"$message\")");
vbms_api_adjust_quota_usage($bytes, $userid);
}

return vbms_api_result::get_void_success_instance();
}
}
}
else
{
return vbms_api_result::get_invalid_arguments_instance();
}
}

dodgeboard.com
11-17-2006, 11:00 PM
POP accounts seem to be handling the dupe subject line issue better than IMAP like hotmail.

subject line on sent message: testing things out

Hot mail shows: testing things out testing things out

POP accounts show: testing things out

Lionel
11-17-2006, 11:03 PM
interesting. I have only one subject line every time, but the email shows the to as recipient@email.com;recipient@email.com

thus the double emails.

I'll take a closer look at function vbms_api_send_message()

Lionel
11-17-2006, 11:35 PM
I have been debugging every step of the send process and at every instance it echo only one email address on the screen.

DaNIEL MeNTED
11-17-2006, 11:49 PM
Well, look this over Daniel and see if you can spot something that would be causing this.


$to = vbms_converttos($to);


Not sure what that function is doing...

But bear in mind I'm not a coder... just a bit of a M$ mailserver guru.

The duplicated subject line isn't the issue... the duplicated mail address is...

dodgeboard.com
11-17-2006, 11:51 PM
Agreed! But the fact that both are getting duplicated may give us a better idea of where to look in the code.

I am not a coder either, but a guru of all sorts.

DaNIEL MeNTED
11-17-2006, 11:54 PM
how is $to being built?

Lionel
11-17-2006, 11:55 PM
Guess what. I managed to get only one email, but I do not know if that is breaking something else.

In vbms_class_mail_message.php: function construct_mime_message(), in the $headermap = array I simply commented out the //"To" => $this->to,
which I noticed was being called again in the function below

function send($testonly = false)

$result = mail($this->to, $this->subject, $this->html, $headers);

dodgeboard.com
11-17-2006, 11:56 PM
You rock MAN!! I'll do some more testing on your system.

Lionel
11-17-2006, 11:56 PM
$to = vbms_converttos($to);

don't touch this function, it has nothing to do with it, that deals with the aliases.

dodgeboard.com
11-18-2006, 12:00 AM
welp, that fixed it for me, both POP and IMAP. Everything else seems okay... so far.

Will do some more testing...

Lionel
11-18-2006, 12:01 AM
welp, that fixed it for me, both POP and IMAP. Everything else seems okay... so far.

Will do some more testing...

Like I said, we need to do some intensive testing, I am not sure if that breaks something else, such as multiple recipients :tired:

dodgeboard.com
11-18-2006, 12:03 AM
try commenting out this as well...

"Subject" => $this->subject,

To see if it fixes the double subject issue

I still get an echo on IMAP emails in the subject line

dodgeboard.com
11-18-2006, 12:04 AM
Like I said, we need to do some intensive testing, I am not sure if that breaks something else, such as multiple recipients :tired:

Multiple recipients is working ok

Lionel
11-18-2006, 12:04 AM
try commenting out this as well...

"Subject" => $this->subject,

To see if it fixes the double subject issue

I still get an echo on IMAP emails in the subject line

I'll try, although I haven't got that double subject issue.

dodgeboard.com
11-18-2006, 12:05 AM
you'll only notice it on Hotmail...POP email ricipients seem to correct it.

Lionel
11-18-2006, 12:06 AM
anyway, commenting it out did not hurt. Try it

Lionel
11-18-2006, 12:07 AM
If nothing else is broken, the last major issue is alias to alias does not receive html

dodgeboard.com
11-18-2006, 12:07 AM
I'll try, although I haven't got that double subject issue.


Okay- that fixed it on the subject line issue as well. and I still see the subject line (but only once on both pop and IMAP. headers look perfect now!!

You da man!!

DaNIEL MeNTED
11-18-2006, 12:16 AM
Rather than that what happens if you change:


$result = mail($this->to, $this->subject, $this->html, $headers);



$result = mail($headers, $this->html);


I don't see why the code is constructing the header then defining the TO: and Subject: a second time?

Lionel
11-18-2006, 12:17 AM
ok, here are my files

You need to make 2 small templates changes

in VBMS_FILTERS add this in the form action

<input type="hidden" name="do" value="addfilter" />

same for VBMS_OPTIONS. Add
<input type="hidden" name="do" value="addoptions" />

Now, we have not tested attachments at all.

working 3.60 version here (https://vborg.vbsupport.ru/showpost.php?p=1120600&postcount=227)

Lionel
11-18-2006, 12:18 AM
Rather than that what happens if you change:


$result = mail($this->to, $this->subject, $this->html, $headers);



$result = mail($headers, $this->html);


I don't see why the code is constructing the header then defining the TO: and Subject: a second time?

That does not send the mail at all.

dodgeboard.com
11-18-2006, 12:19 AM
I've tested attachments and they seem to be working ok

Lionel
11-18-2006, 12:21 AM
One more thing. I am on a redhat server so I hardcoded it to force NOTLS.

Lionel
11-18-2006, 12:22 AM
Dodgeboard, I am going to send you an email to your alias. Check for html. I will be sending you smilies.

DaNIEL MeNTED
11-18-2006, 12:22 AM
That does not send the mail at all.



:confused:

Like I said... I'm not a coder. I looked up the reference for the PHP mail() function -

Function usage : mail([RECIPIENT],[SUBJECT],[MESSAGE],[EXTRAHEADERS], [EXTRAPARAMS]);

So that means you need to define TO and SUBJECT when calling mail(). Doing it again in the additional header information in $header is going to cause mail() to parse the to and subject twice.

So you've definately got it...

Lionel
11-18-2006, 12:23 AM
what is your username/alias?

dodgeboard.com
11-18-2006, 12:24 AM
Does the installer in the files you uploaded incorporate the manual database queries that you ran and mentioned in post 127?

dodgeboard.com
11-18-2006, 12:26 AM
what is your username/alias?


ummm
username: dodgeboard.com
alias: dodgeboard@yoursite.com

Lionel
11-18-2006, 12:26 AM
ok, I did not put any installer. Do you have access to a development board?

dodgeboard.com
11-18-2006, 12:28 AM
nope,

it's on my to-do list though :D

You want to set it (VBMS) up for me? :cool:

Lionel
11-18-2006, 12:31 AM
The installer should be the same as the original post. Only one query to change, the one for phraseid as per my post before. If not, then I'll post the individual queries.

I am mostly concerned that all the settings will be installed. Paul M mentioned some missing, but could not verify that as I did a manual install.

dodgeboard.com
11-18-2006, 12:34 AM
Dodgeboard, I am going to send you an email to your alias. Check for html. I will be sending you smilies.


Never got the HTML email....

but hey, that's not a real big deal...
:laugh:

Edit: yeah I got it, but the html was displaying the code.

Lionel
11-18-2006, 12:35 AM
So I guess Filburt the ball is in your court. Works for me on 3.60

Lionel
11-18-2006, 12:35 AM
Never got the HTML email....

but hey, that's not a real big deal...
:laugh:

it displays the code huh?

dodgeboard.com
11-18-2006, 12:36 AM
yeah

---but not a big issue

If someone can now get this packaged into a completed product with the installer bugs incorporated, we'd be in good shape.

Lionel
11-18-2006, 12:38 AM
yeah

---but not a big issue

no good. I'll get to that later on or tomorrow. I think I know the reason.

Can't help on installer. Like I stated before, I code only on my site and never learned how to package those things. I am still doing it the 3.07 way.

dodgeboard.com
11-18-2006, 12:40 AM
okay- you made some real progress today! Thanks for all your efforts. Email me if you need anything webmaster at dodgeboard.com

Lionel
11-18-2006, 12:41 AM
Thanks, you've been a tremendous help.

filburt1
11-18-2006, 12:45 AM
I must say, it's pretty damned impressive what you guys have done with it, especially figuring it out so quickly. I'd like to think it's because I coded it with some high-level concepts in mind, but more likely, you're PHP gods. ;)

The installer's a +++++. What specific problems is it causing?

BTW, header duplication and problems will occur within the vbms_mail_message class. The API function you posted is just a wrapper to provide safe arguments for the class and to easily say "just send the message" without all the extra code.

dodgeboard.com
11-18-2006, 12:49 AM
post 127:

The problem is the phrasetype table structure is not the same from 3.54 to 3.60
I had xml error from the very first line of the install. So what I did, I opened the xml and ran the queries one by one in php admin, simply changing {tp} with my prefix. Once all the tables were created and the inserts done (a matter of minutes), I imported the templates xml from the upload styles input.

Did the same for the phrases. That took a couple of minutes.

The biggest headache is the settings. I had to do them one by one, but it's only 14 of them. You need also to set the settinggroup (1 entry with phpadmin)

Then the fun begins. I replaced all $DB_Site with $db (just a search and replace for all the files).
Filburt,

Can you package these changes so that the queries are properly executed?

Then use the files posted by Lionel on post 197 to put together a 3.6.0 beta release.

filburt1
11-18-2006, 12:53 AM
I have no idea how the phrasing works in vB 3.6, so I don't know even how to start fixing that one. The table prefixes should automagically be replaced when queries are run. It should add the settings and create the group as well.

If the whole process changed in 3.6 versus 3.5, then I don't know what to do. I have near-zero experience with 3.6.

(also don't have <oXygen/> installed right now)

Lionel
11-18-2006, 12:53 AM
You need to deal with that single line for phrasetype (database has changed from 3.54 to 3.60)

And need to make sure all settings are there (15 of them). Here are 3 screenshots of what the complete settings should be. Some of them, I 'borrowed' from the 3.07 version to manually install.

I also borrowed the code below navbar to display new emails from the 3.07 version

Lionel
11-18-2006, 12:58 AM
I have no idea how the phrasing works in vB 3.6, so I don't know even how to start fixing that one. The table prefixes should automagically be replaced when queries are run. It should add the settings and create the group as well.

If the whole process changed in 3.6 versus 3.5, then I don't know what to do. I have near-zero experience with 3.6.

(also don't have <oXygen/> installed right now)

OK here is what I did

1-Imported the phrases directly from Filburt xml into english language

2-Did same thing for templates

replace new_ with your prefix

for settings you are on your own. My sql files have my autoincrements

working 3.60 version here (https://vborg.vbsupport.ru/showpost.php?p=1120600&postcount=227)

DaNIEL MeNTED
11-18-2006, 01:56 AM
I think you mean "replace WDF_ with your own prefix"

dodgeboard.com
11-18-2006, 01:59 AM
I think you mean "replace WDF_ with your own prefix"

If you look at the text files Lionel uploaded, you'll see:

INSERT INTO new_product VALUES ('wdf_vbms', 'Vbulletin Mail System', 'Vbulletin Mail System', '2.52', 1, '', '');

I think he means to replace the new_product table line with your own prefix. Same with new_settinggroup and new_phrasetype in the corresponding files

DaNIEL MeNTED
11-18-2006, 02:04 AM
Doh! Thats what I get for working on 2 things at once...

Lionel
11-18-2006, 02:13 AM
I also put this at the end of navbar template so members know when they have new mail.

<!-- vBMS new mail notification -->
<if condition="$vbulletin->options['vbms_enabled'] and $vbulletin->options['vbms_headernotification'] and $vbms_newmessages['newcount'] > 0">
<br />
<table cellpadding="$stylevar[outerborderwidth]" cellspacing="0" border="0" class="tborder" width="$stylevar[tablewidth]" align="center">
<tr>
<td>
<table cellpadding="$stylevar[cellpadding]" cellspacing="$stylevar[cellspacing]" border="0" width="100%">
<tr>
<td class="thead" colspan="2">$vbphrase[vbms_you_have_new_email]</b>
</td>
</tr>
<tr>
<td class="alt2" style="width:30px; text-align:center; overflow:hidden; padding:1px; vertical-align:middle">
<span style="font-family:'Trebuchet MS', Verdana, Tahoma, Arial, sans-serif; font-weight:bold; font-size:xx-large">!</span>
</td>
<td valign="top" class="alt1">
<b>
<if condition="$vbms_newmessages['newcount'] == 1">
$vbphrase[vbms_one_unread_message]
<else />
<phrase 1="$vbms_newmessages[newcount]">$vbphrase[vbms_x_unread_messages]</phrase>
</if>
</b><br />
<span class="smallfont"><phrase 1="/forums/vbms.php?$session[sessionurl]">$vbphrase[vbms_to_read_your_email]</phrase>
</span>
</td>
</tr>
</table>
</td>
</tr>
</table>
</if>
<!-- / vBMS new mail notification -->

Lionel
11-18-2006, 02:18 AM
You guys make sure you have 15 settings, and the one for NOTLS is named force_notls and not notls.

If you have problems, post it and I will help you.

Lionel
11-18-2006, 03:29 AM
My setup is very different. So in the code that I posted, you need to look for and replace every instance of

" . "user

with

" . TABLE_PREFIX . "user

Lionel
11-18-2006, 04:49 AM
in vbms_functions.php look for

// convert ab aliases to actuals
$result = $db->query("
SELECT LCASE(alias) AS alias, actual FROM " . TABLE_PREFIX . "vbms_addressbook
WHERE userid = " . $bbuserinfo['userid']);

and replace with

$alias=str_replace("\"","",$to);

// convert ab aliases to actuals
$result = $db->query("
SELECT LCASE(alias) AS alias, actual FROM " . TABLE_PREFIX . "vbms_addressbook
WHERE alias='$alias' AND userid = " . $bbuserinfo['userid']);

before sending, the script looks at the address book for an alias and if you do have an address book, it assumes that the entry exists, not taking into consideration new emails that you are replying to. Since it will not find it, it will throw an error.

The fix above introduce the alias in the WHERE clause, so if alias is not in there it will ignore it and send the mail without errors.

Andre31
11-18-2006, 05:45 PM
Work this nice Addon under 3.6.2 without Problems? I´ve tried, but i became trouble with the installer. Have anybody an idea?

filburt1
11-18-2006, 06:56 PM
Did you read any of the posts in this thread?

Lionel
11-19-2006, 08:00 AM
Instructions.

BACKUP your database and your templates

Run the included queries in phpadmin. Make sure you replace the " . TABLE_PREFIX . " with your own prefix
Merge the included templates into your existing style by importing the xml in Upload/Download Templates
Import the product. That will set the phrases, the plugins and the settings
upload the files
Refresh admincp and look for the new link for the mail system and set your settingsKnow bugs: Permissions need to be setup twice for it to be accepted.

This has been working on my site with no reported problems.
Some FAQ are specific to my site and you will not need. Simply delete them in FAQ admin

If you want to display a mail notification to your members on the site, follow the instructions here
https://vborg.vbsupport.ru/showpost.php?p=1119785&postcount=221

uploaded images

dodgeboard.com
11-19-2006, 02:52 PM
At Query:

UPDATE phrase SET product = "wdf_vbms" WHERE varname LIKE "vbms%" OR phrasetypeid = 500

Error
SQL query:

UPDATE phrase SET product = "wdf_vbms" WHERE varname LIKE "vbms%" OR phrasetypeid =500

MySQL said:

#1054 - Unknown column 'phrasetypeid' in 'where clause'

Lionel
11-19-2006, 02:54 PM
At Query:

UPDATE phrase SET product = "wdf_vbms" WHERE varname LIKE "vbms%" OR phrasetypeid = 500

disregard this query. Since this is a copy of my product, you don't need. or simply remove that part

"OR phrasetypeid =500 "

dodgeboard.com
11-19-2006, 02:55 PM
same with this one? (same error)


UPDATE phrasetype SET product = "wdf_vbms" WHERE phrasetypeid = 500

Lionel
11-19-2006, 03:02 PM
same with this one? (same error)


UPDATE phrasetype SET product = "wdf_vbms" WHERE phrasetypeid = 500


ignore it too. Ignore the ones referring to phrasetypeid. I simply copied the original query and forgot to remove them.

I am attaching missing images.

dodgeboard.com
11-19-2006, 03:02 PM
FYI: queries for CREATE TABLE vbms_usergroupsetting and vbms_sendfloodcheck are listed twice in the sql.txt file- you get an error on the second instance

EDIT: and vbms_log

All other queries executed properly

So I made the corrections to the SQL.TXT and am uploading it here.

I also elimintated the table prefix as well.

Lionel, why do we even need a table prefix since all the tables are already prefixed with vbms_ ?

Lionel
11-19-2006, 03:09 PM
FYI: queries for CREATE TABLE vbms_usergroupsetting and vbms_sendfloodcheck are listed twice in the sql.txt file- you get an error on the second instance

EDIT: and vbms_log

All other queries executed properly

So I made the corrections to the SQL.TXT and am uploading it here.

I also elimintated the table prefix as well.

Lionel, why do we even need a table prefix since all the tables are already prefixed with vbms_ ?

you do, because all the queries in php use " . TABLE_PREFIX ."vbms_whatever

Lionel
11-19-2006, 03:17 PM
I am not sure this was included


INSERT INTO `TP_phrasetype` VALUES ('vbms', 'vBulletin Mail System (vBMS)', 3, 'wdf_vbms', 0);

REPLACE TP_ with your prefix.

Lionel
11-19-2006, 03:19 PM
And he forgot to autoincrement messageid in " . TABLE_PREFIX . "vbms_message

You need to do it too in php admin

DaNIEL MeNTED
11-19-2006, 06:12 PM
Couple of things... the cron job seems to fail.

Aaand... any settings changes and the cron job is disabled and set to run only on the 1st.

Slave
11-19-2006, 06:59 PM
Thanks for the instructions Lionel :) .. I've managed to get it to the point of being able to send a mail out but it doesn't seem to be checking for new mail .. do i need to set the cron job up as mentioned earlier in this thread? I've set it to check for mail every 2 mins and to log in the settings but nothing has appeared there as yet ..

Also .. How do I change the name from "Haitiwebs Mail" showing in the title of the page and in the breadcrumbs? I don't seem to be able to find it in the settings ..

Thanks :)

Lionel
11-19-2006, 08:04 PM
the cron job is in the plugin. Make sure that the plugin is enable (2 of them) specially the parse templates which adds to the $cronimage found in footer.

To change the name, look in vbms_function.php

Lionel
11-19-2006, 08:07 PM
Forget about the cron in the cronjobs. This is not using a cronjob like we know it. In fact delete it. It was not supposed to be there.

Lionel
11-19-2006, 08:30 PM
This is what activates the cron: Check e-mail. Make sure you have those 2 plugins which were included in the product

<plugins>
<plugin active="1" executionorder="6">
<title>Initialize front-end vBMS page elements</title>
<hookname>global_start</hookname>
<phpcode><![CDATA[require_once(DIR . "/includes/vbms_frontend_init.php");]]></phpcode>
</plugin>
<plugin active="1" executionorder="5">
<title>Check e-mail</title>
<hookname>parse_templates</hookname>
<phpcode><![CDATA[require_once(DIR . "/includes/vbms_functions.php");
$cronimage .= vbms_get_check_mail_img_html();]]></phpcode>
</plugin>
</plugins>

Do a view source on any forum page and towards the end of the page see if you have that line

<img src="http://www.yoursite.com/forums/vbms_checkmail.php?&amp;rand=23720" alt="" />

Anomalies
11-19-2006, 08:37 PM
Is this going to get updated with the fixes?

Lionel
11-19-2006, 08:38 PM
Is this going to get updated with the fixes?


feel free to do so

Anomalies
11-19-2006, 08:46 PM
feel free to do so

I'll use the Gmail account, 1000 times better.

Lionel
11-19-2006, 08:49 PM
Don't be a a smart ass, I was asking a question. If you can't give a simple answer then don't even bother. Unless this is updated by the developer or one of his co developers - it is useless.

Useless to you. If you can't read, move on, this hack is not for you. I've got this 100% bug free on my site and I know of 2 other sites that has it up and running.

I stated that I don't know how to pack it into a product, filburt said he does not know. If you can't appreciate what was done and call me a smart ass, move on.

edit....
and it's good that you changed your post

dodgeboard.com
11-19-2006, 08:57 PM
Listen folks, a lot of people have worked hard on this and for nothing.

I too am having problems with the install simply because I am not a coder. It wasn't until just recently that Lionel worked out all the issues with the product.

Now, for us noobs, we must wait for a savvy coder to come along and wrap all the manual fixes into a final product that has an automated install.

I am waiting patiently as well. Getting snotty is not going to move this along any faster. Let's respect those that have worked hard on this product to get it to where it is.

It wont be long now. Thanks Lionel!

Lionel
11-19-2006, 09:00 PM
Me, I am out of here. I will not waste my time to be called names.

dodgeboard.com
11-19-2006, 09:07 PM
No good deed goes unpunished Lionel.

Please don't let what one ungrateful member says run ya away.

You've done more with fixing this than anyone...and it is appreciated, very much!

You ROCK MAN!

Anomalies: Thanks for setting back the movement! We keep running off the good coders who are doing their best on what IS a free product, this will never come to fruition.

Lionel
11-19-2006, 09:08 PM
Whoever needs help to get it running, just PM me with access and I'll set it up for you.

Killsparer
11-19-2006, 09:21 PM
I also wanted to thank you very much for your help in getting this addon running!

You shouldn't care too much about any insults made by this guy. It's the internet, it's nearly impossible not to meet people like him sooner or later.

Lionel
11-19-2006, 09:54 PM
Dodgeboard, you are all set.

You need to setup the settings, permissions etc.. (mainly create the catchall account).
It appears that you removed the $cronimage in your template. It will never work without it.

And one last step for you to do (optional)

https://vborg.vbsupport.ru/showpost.php?p=1119785&postcount=221