How do I display my titles correctly?

[davidw]

Say for example, I am pulling 3 article from 2 forums.
I am currently using this to print articles of a couple different forums.
if (!isset($title))
{
eval('$article .= "' . fetch_template('title') . '";');
}

if (isset($article))
{
eval('$article .= "' . fetch_template('article') . '";');
}The problem (obviously) is that it only displays the title to the first forum set. Instead of doing this:

Forum title
thread
thread
thread

Forum title
thread
thread
thread

It obviously does this:

Forum title
thread
thread
thread

thread
thread
thread

What would I need to change this to in order to make this work correctly?

[davidw]

bump

[Marco van Herwaarden]

You would really need to show more of your code to answer this.

[davidw]

Ok, Here's a bigger, more practical chunk...$getnews = $db->query_read("
SELECT t.threadid, t.title, t.lastpost, t.forumid, t.open, t.replycount, t.postusername, t.postuserid, t.lastposter, t.dateline, t.views, t.visible, t.firstpostid, f.title AS forumtitle, post.pagetext AS preview
FROM " . TABLE_PREFIX . "forum f
INNER JOIN " . TABLE_PREFIX . "thread t ON t.forumid = f.forumid AND t.visible = 1 AND " . $desclimit . " > ( SELECT count(" . $desclimit . ") FROM " . TABLE_PREFIX . "thread WHERE forumid = f.forumid AND visible = 1 AND dateline > t.dateline )
LEFT OUTER JOIN " . TABLE_PREFIX . "post AS post ON post.postid = t.firstpostid WHERE t.forumid IN (" . implode(',', $myforumid) . ")
ORDER BY field(f.forumid," . implode(',', $myforumid) . "), t.dateline desc
");

while($news = $db->fetch_array($getnews))
{
$news['title'] = preg_replace('/\<[a-zA-Z0-9 \&lt;\<\,\&gt;\>\.\?\/\:\;\~\"\`\!\@\#\$\%\^\&\*\(\)\_\-\+\=]*\>/', '', $news['title']);
$news['title'] = fetch_trimmed_title(fetch_censored_text(unhtmlspec ialchars($news['title'])), $titlelen);
$news['forumtitle'] = stripslashes($news['forumtitle']);
$news['date'] = vbdate($vbulletin->options['dateformat'], $news['dateline']);
$news['time'] = vbdate($vbulletin->options['timeformat'], $news['dateline']);
$news['replycount'] = vb_number_format($news['replycount']);
$news['views'] = vb_number_format($news['views']);
$news['postusername'] = $news['postusername'];
$news['lastposter'] = $news['lastposter'];
$news['preview'] = preg_replace('/\<[a-zA-Z0-9 \&lt;\<\,\&gt;\>\.\?\/\:\;\~\"\`\!\@\#\$\%\^\&\*\(\)\_\-\+\=]*\>/', '', $news['preview']);
$news['pagetext'] = htmlspecialchars_uni(strip_bbcode(fetch_censored_t ext(substr($news['preview'], 0, $charlimit))));

$news['endoftextless'] = '... <br />&nbsp;<font size=2><a href="showthread.php?t='. $news['threadid'] .'" title="'. $news['preview'] .'" target="blank">[Read more here]</a></font>';
$news['endoftextmore'] = '<br />&nbsp;<font size=2><a href="showthread.php?t='. $news['threadid'] .'" title="'. $news['preview'] .'" target="blank">[Click here for source]</a></font>';
$endoftext = (strlen($news['pagetext']) > $charlimit) ? $news['endoftextless'] : $news['endoftextmore'];

if (!isset($vbnewscms_articlebit))
{
eval('$vbnewscms_articlebit .= "' . fetch_template('vbnewscms_sectionhead') . '";');
}

if (isset($vbnewscms_articlebit))
{
eval('$vbnewscms_articlebit .= "' . fetch_template('vbnewscms_articlebit') . '";');
}

if (!isset($vbnewscms_sectionend))
{
eval('$vbnewscms_sectionend .= "' . fetch_template('vbnewscms_sectionend') . '";');
}
}It still has 3 other bugs aside from this one, but this is the worst offender.

[davidw]

I'm just wondering if a switch would work

[davidw]

bump

[Marco van Herwaarden]

i would use a 'forumbit' template, to hold all the threads for that forum, and then evaluate that upon a change of forumid (you already are ordering it by forumid).

[Freesteyelz]

I think I know what this is for... :D

[davidw]

Yeah - and this is the only problem left. After this... 2-3 small bugs that are easy to fix (one is resident on fixing this one :P).

I had an idea though, If I could find a way to separate/isolate out one (any) forum from the query, I can fix the problem. I am not sure how to do this though. Marco gave me that idea above. Although, I'm already using an "articlebit" template (I could call it forumbit) that serves pretty much the same purpose.