Require Approval for HTML Signatures

[antialiasis]

This hack in a nutshell: To avoid security risks and general page mess-ups by users who are inexperienced at HTML, users will have to get HTML signatures approved before they are shown in the forums.

The full functionality of this hack is perhaps better explained by the features and screenshots.

Admin and approver features:

- Fully phrased (unless I missed something)
- Specify groups which can approve HTML signatures in the Admin CP (moderators, super moderators and administrators by default)
- View list of all unapproved HTML signatures
- View a single HTML signature's code without having it executed on the page or preview it after making sure it does not posess a security risk

User features:

- Either use a normal BBCode signature, which does not need approval, or an advanced HTML signature
- Normal BBCode signature, if any, is used while HTML signature has not yet been approved
- HTML is shown as "on" in Forum Rules box when editing HTML signature to avoid confusion, and is parsed in HTML signature preview

PLEASE NOTE THAT THIS HACK FAILS CATASTROPHICALLY IN VBULLETIN 3.6.0. A separate version for vBulletin 3.6 will be released soon.


Version History:

1.6: Another missing TABLE_PREFIX added and the setting is now definitely included. No changes have been made to htmlsig.php, so to upgrade you only need to download the zip and import the new product-htmlsigapproval.xml.
1.5: HTML signatures now work in PMs. Added missing TABLE_PREFIX in a query. To upgrade: Again, reupload htmlsig.php and import the new product-htmlsigapproval.xml, making sure that "Allow Overwrite" is on.
1.1: It used to make HTML disabled in your already-approved HTML signature again after you edited it; now that's fixed. To upgrade: Reupload htmlsig.php and import the new product-htmlsigapproval.xml through the Admin CP, making sure that "Allow Overwrite" is ON.
1.0: Initial release.

---

Difficulty: Easy
Template edits: 5
Product installs: 1
File uploads: 1
Code modifications: 0
Additional database rows: 2

INSTALLATION INSTRUCTIONS

1: Unzip htmlsigapproval.zip.
2: Upload htmlsig.php to your main forum folder (the one containing global.php, forumdisplay.php, etc.)
3: Import product-htmlsigapproval.xml via the Admin CP Product Manager.
4: Go to vBulletin Options in the Admin CP, select User Profile Options and scroll to the bottom. Edit the setting "Groups that can approve of HTML signatures" to the groups you want to be able to approve HTML signatures. (Leave it as 5,6,7 if you want moderators, super moderators and administrators to have that ability.)
5: Make sure that "Allow HTML in Signatures?", located a little bit higher in the same setting group, is set to no - there's not much use having an HTML signature approval system if people can use HTML in their normal signatures without needing to have them approved!
6: Make the following template edits:

In modifysignature FIND

<!-- message area -->
<div class="smallfont">$vbphrase[your_signature]:</div>
$messagearea
<!-- / message area -->

ABOVE it add

<if condition="$usehtmlsignature"><div class="smallfont">$vbphrase[note_html_signature_approval]</div><br /></if>

and BELOW it (below the earlier code you searched for, not below what you just inserted) add

<if condition="$usehtmlsignature">
<span class="smallfont"><a href="profile.php?$session[sessionurl]do=editsignature&amp;htmlsig=no">$vbphrase[standard_signature]</a></span>
<else />
<span class="smallfont"><a href="profile.php?$session[sessionurl]do=editsignature&amp;htmlsig=yes">$vbphrase[html_signature]</a></span>
</if>

FIND

<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="updatesignature" />

ABOVE it add

<if condition="$usehtmlsignature">
<input type="hidden" name="htmlsig" value="yes" />
</if>

FIND

<td class="tcat">$vbphrase[edit_signature]</td>

REPLACE with

<td class="tcat"><if condition="$usehtmlsignature">$vbphrase[edit_html_signature]<else />$vbphrase[edit_signature]</if></td>


In footer FIND

<if condition="$show['modcplink']"><a href="$modcpdir/index.php$session[sessionurl_q]">$vbphrase[mod]</a> -</if>

BELOW it add

<if condition="$show['htmlsiglink']"><a href="htmlsig.php$session[sessionurl_q]">$vbphrase[manage_html_signatures]</a> -</if>

7: Inform your users of the change so they won't get confused. ;)

Please report any problems with the hack in this thread. I will try to fix them as soon as possible.

EDIT: Heh, forgot to attach the screenshots.

[Snake]

Whoa what a great feature to have for my forums. Thanks!

[antialiasis]

Updated to version 1.1 for a fairly important feature.

[antialiasis]

Version 1.5. HTML sigs now work in PMs and the hack will now be functional with table prefixes.

[ComputerVitals]

When importing the xml.. I get this


Database error in vBulletin 3.5.4:

Invalid SQL:

ALTER TABLE usertextfield
ADD htmlsignature TEXT;

MySQL Error : Table 'cvital_forum.usertextfield' doesn't exist

[P Grizz]

i'm using 3.5.3

i seem to be having 2 issues, the link to approve sigs in the footer simply isnt there.

also if i try to access htmlsig.php directly, it says I do not have permission to access the page. Is this a usergroup permissions situation? I couldnt find anything in usergroup permissions or in options.

"Groups that can approve of HTML signatures" is not visible in user profile settings.

[antialiasis]

Both of those should be fixed now.

I also just realized that HTML signatures aren't working in post/PM previews, and am working on that.

[P Grizz]

i"m still having the same problem....although last time installing this screwed up everyone's sigs....but once i uninstalled it and got rid of the extra code, they're sigs went back to normal...however, i reinstalled this with the fix and all the same problems I was having before still apply, accept everyone's sig is fine.....I can only assume it's either the version of vb I have, or a conflict with another plugin. Thanks for the effort though.

[antialiasis]

The problem is definitely just the lack of that setting (as it checks for the setting when deciding whether to display the link in the bottom bar and gives you a no-permission message if you aren't in one of the allowed usergroups), but I can't for the life of me figure out why it isn't being added to your setting list since it definitely is a part of the product XML. I have only tested it on 3.5.4, but it seems very odd that this would have changed majorly since 3.5.3. I have a test board running 3.5.3, so I'll check if I succeed in installing it there...

EDIT: I installed it at my test forum and it worked just fine. Are you absolutely sure you imported the new product?

Incidentally, I updated the template edit instructions. They're pretty much just making the code a little more readable, though, so changing them should not be necessary.

[ComputerVitals]

Just installed using your updated xml..
Works great here.

One question though.
When you add the link to the footer, I run vbdavanced, the link there is wrong but when in the forum the link is fine, Any way of making the link work in both? Or hiding the link in the front vbadvanced?
More info.. my root is just vbadvanced, the forums are in .com/forum/

[antialiasis]

Shouldn't be too hard. Just find where you put

<a href="htmlsig.php$session[sessionurl_q]">$vbphrase[manage_html_signatures]</a>

and replace it with

<a href="/forum/htmlsig.php$session[sessionurl_q]">$vbphrase[manage_html_signatures]</a>

That should work if I understood you correctly about the directories.

[ComputerVitals]

Doh.. one line away..

I tried to put it as forum/ and it would go forum/forum/ when inside the forum.. Adding it your way with the / before fixes it.

[antialiasis]

This version works fine on my 3.8.1 forum, or at least I don't remember having to modify it to work.