Remove 1 Query Per Page

[Trigunflame]

[CENTER]Remove 1 Database Query Per Page
Reduce your forums query usage !

Summary: (Quoted From Original Hack for vb3)

Removes 1 Query Per Page.

Instructions:

1. Open includes/class_core.php
2. Go to about line 2538 and look for
$this->set('location', WOLPATH);
3. Above that, paste the following.
$this->set('old_location', $session['location']);
4. Go to about line 2818 and look for the following:
// registered user
if (!SESSION_BYPASS)
{
if (TIMENOW - $this->userinfo['lastactivity'] > $this->registry->options['cookietimeout'])
{
// see if session has 'expired' and if new post indicators need resetting
$this->registry->db->shutdown_query("
UPDATE " . TABLE_PREFIX . "user
SET
lastvisit = lastactivity,
lastactivity = " . TIMENOW . "
WHERE userid = " . $this->userinfo['userid'] . "
", 'lastvisit');

$this->userinfo['lastvisit'] = $this->userinfo['lastactivity'];
}
else
{
$this->registry->db->shutdown_query("
UPDATE " . TABLE_PREFIX . "user
SET lastactivity = " . TIMENOW . "
WHERE userid = " . $this->userinfo['userid'] . "
", 'lastvisit');
}
}
5. Replace that with the following:
// registered user
if (!SESSION_BYPASS)
{
if (TIMENOW - $this->userinfo['lastactivity'] > $this->registry->options['cookietimeout'])
{
// see if session has 'expired' and if new post indicators need resetting
$this->registry->db->shutdown_query("
UPDATE " . TABLE_PREFIX . "user
SET
lastvisit = lastactivity,
lastactivity = " . TIMENOW . "
WHERE userid = " . $this->userinfo['userid'] . "
", 'lastvisit');

$this->userinfo['lastvisit'] = $this->userinfo['lastactivity'];
}
elseif ($this->vars['old_location'] != WOLPATH || THIS_SCRIPT == 'misc' || THIS_SCRIPT == 'online')
{
$this->registry->db->shutdown_query("
UPDATE " . TABLE_PREFIX . "user
SET lastactivity = " . TIMENOW . "
WHERE userid = " . $this->userinfo['userid'] . "
", 'lastvisit');
}
}

[Corriewf]

Awesome! Thanks!

[Trigunflame]

Awesome! Thanks!
Welcomez :)

[Protoman]

think the vB team will add this to the next version??

[Zia]

* Zia kliks install

Trigunflame :) what is next tremendious idea to make page laod faster & fatser ?

:D

[Kihon Kata]

INstalled! Thanks! but I am running ministats and I am not seeing a decrease on queries listed in there during page loads.

[Trigunflame]

Because if you would look at the query:

$this->registry->db->shutdown_query()

It is a shutdown query that is run as the script is ending, and is not shown in any query counters. Nevertheless it is still sending that query to your forums mysql database which affects the system.

I didnt say this would necessarily make your forum "Faster", I just said it would reduce a query, lol.

Go read my thread in vb3 if you dont believe me...

[GenSec]

/me cliks install

Thank you, very usefull!

[GenSec]

/me cliks install

Thank you, very usefull!

[Trigunflame]

* GenSec cliks install


Thank you, very usefull!

Doublepost, might wanna delete one; lol.

[Kihon Kata]

Because if you would look at the query:

$this->registry->db->shutdown_query()

It is a shutdown query that is run as the script is ending, and is not shown in any query counters. Nevertheless it is still sending that query to your forums mysql database which affects the system.

I didnt say this would necessarily make your forum "Faster", I just said it would reduce a query, lol.

Go read my thread in vb3 if you dont believe me...

Oh, all I said is that when the stats lists, it's the same number of queries listed, that's all. Nothing about speed or "Faster".

Anyhow, thanks for this

[Snake]

Thank you very much. I always wanted to reduce the query usage on my forums but guess what, this helps a lot! :)

[NuclioN]

Trigunflame the code to replace at the very bottom of the last replacement says you have to overwrite. That section in the original has this:


$this->registry->db->shutdown_query("
UPDATE " . TABLE_PREFIX . "user
SET lastactivity = " . TIMENOW . "
WHERE userid = " . $this->userinfo['userid'] . "
", 'lastvisit');
}
}
}
}
}


-----------------------

According to the manual i have to overwrite the first two } is that correct?

[Trigunflame]

Trigunflame the code to replace at the very bottom of the last replacement says you have to overwrite. That section in the original has this:


$this->registry->db->shutdown_query("
UPDATE " . TABLE_PREFIX . "user
SET lastactivity = " . TIMENOW . "
WHERE userid = " . $this->userinfo['userid'] . "
", 'lastvisit');
}
}
}
}
}


-----------------------

According to the manual i have to overwrite the first two } is that correct?

Just replace the php code in the first php example, with the php code in the 2nd example.

[NuclioN]

Tnx :) Every reduce of query is usefull

[o0Hubba0o]

3. Above that, paste the below

So does it go above? Or does it go below?

Wait, I think I understand now that I look at what I typed, your saying to paste what's below above this "$this->set('location', WOLPATH); " right? Maybe change it to say: "3. Above that, paste the following:". ;) Otherwise more people might get confused if they're looking at this right after getting up in the morning like me hehe.

[Trigunflame]

So does it go above? Or does it go below?

Wait, I think I understand now that I look at what I typed, your saying to paste what's below above this "$this->set('location', WOLPATH); " right? Maybe change it to say: "3. Above that, paste the following:". ;) Otherwise more people might get confused if they're looking at this right after getting up in the morning like me hehe.

It doesnt matter if you paste it below it or above it, just a 1 liner.

[Trigunflame]

*bump*

[dutchbb]

I'm still not sure what changes when I remove the query. And if it doesn't change speed I rather keep the extra query

[Trigunflame]

I'm still not sure what changes when I remove the query. And if it doesn't change speed I rather keep the extra query

If you dont care, dont worry about it :tired:

[Trigunflame]

Gotta love bumps.. but no this really is important...

[Oblivion Knight]

Is there anything fundamentally changed by this?

The only reason I haven't installed it personally, is because Jelsoft generally do a good job at optimising their code and queries. If they could have originally saved on this query without losing some kind of functionality, I'd be wondering why they didn't.

[Trigunflame]

Is there anything fundamentally changed by this?

The only reason I haven't installed it personally, is because Jelsoft generally do a good job at optimising their code and queries. If they could have originally saved on this query without losing some kind of functionality, I'd be wondering why they didn't.

Well good thing you asked that actually. I just noticed earlier today that I need to update this hack to reflect a change in 3.5.x that I didnt account for when i ported it from vb3.

It deals with how sessions are updated; before in vb3 it was handled in a single function; now it uses 2 seperate functions for updating the user last active and the session.

So yes, it wont hurt anything to use this small addition.. but it does need to be expanded to deal with the session table as well; which would/could save 2 queries as opposed to the 1.

[MissKalunji]

Well good thing you asked that actually. I just noticed earlier today that I need to update this hack to reflect a change in 3.5.x that I didnt account for when i ported it from vb3.

It deals with how sessions are updated; before in vb3 it was handled in a single function; now it uses 2 seperate functions for updating the user last active and the session.

So yes, it wont hurt anything to use this small addition.. but it does need to be expanded to deal with the session table as well; which would/could save 2 queries as opposed to the 1.


Waiting on update :)

[EasyTarget]

hmm... bump

[Alien]

I'm very interested in this.. I'll wait for update. :)

[Trigunflame]

Yes.. will be done sometime, lol lots of things on my todo list.

[Alien]

Look forward to it!

I'm currently running 3.5.4, will this mess up anything regarding sessions or can I still run this one until the other one is out?

[Zia]

Caching Template...also reduce 1 query.....this also reduce 1 ..
hope to get an update about this(Remove 1 Query Per Page) hack

[MissKalunji]

Caching Template...also reduce 1 query.....this also reduce 1 ..
hope to get an update about this(Remove 1 Query Per Page) hack


accelerator :P accelerates

and compress less loading

isnt the world perfect now? lol

sure is for me

thanks! Trigunflame (i cant never spell his name right)

[Alien]

World will be perfect if someone can confirm this doesn't mess anything up in 3.5.4 so i can use it until he updates it further. The "sessions" thing he mentioned made me nervous so wanted confirmation. ;)

[MissKalunji]

what session thing?

[Alien]

Umm?

Post #23 in this thread...

[Alien]

Does anyone have an answer to this question?

[Trigunflame]

It shouldnt mess up anything.

[Alien]

Thank you so much!

[mark99]

Does it work with 3.6?

[Skyline_GT]

wow thanks. Very useful

[rjmjr69]

Does this work in 3.6.4?